Re: [PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup

2015-08-31 Thread Stefan Bruens
On Monday 24 August 2015 01:24:59 Noralf Trønnes wrote: > Den 24.08.2015 00:24, skrev Stefan Brüns: > > Avoid a crash, as master->setup may be NULL (e.g. xilinx controller). > > Even if master->setup is set, spi_setup does several compatibility/ > > sanity checks which should not be skipped (fixes

Re: [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information

2015-08-31 Thread Javier Martinez Canillas
Hello Jonathan, On 08/22/2015 07:59 PM, Jonathan Cameron wrote: > On 20/08/15 08:07, Javier Martinez Canillas wrote: >> The SPI core always reports the MODALIAS uevent as "spi:" >> regardless of the mechanism that was used to register the device >> (i.e: OF or board code) and the table that is use

Re: [PATCH RESEND 04/16] staging: rtl8188eu: remove unused macro GEN_DRV_CMD_HANDLER

2015-08-31 Thread Luca Ceresoli
Dear Larry, Larry Finger wrote: On 08/28/2015 03:45 PM, Luca Ceresoli wrote: Signed-off-by: Luca Ceresoli Cc: Larry Finger Cc: Greg Kroah-Hartman Empty commit messages are generally not accepted. Meaning something like this? commit 96ac283d6490932ff5097259c18a4d03bdddb010 Author: Ch

Re: [PATCH RESEND 01/16] staging: rtl8188eu: rtw_mlme_ext.c: reorder the report functions

2015-08-31 Thread Luca Ceresoli
Dear Larry, thanks for your review. Larry Finger wrote: On 08/28/2015 03:45 PM, Luca Ceresoli wrote: Some of the report_*() functions are internal and will be declared static, and their declaration removed from rtw_mlme_ext.h, in a later commit. This would break compilation, since they are ar

randconfig build error with next-20150831, in drivers/staging/ipath

2015-08-31 Thread Jim Davis
Building with the attached random configuration file, ERROR: "ib_alloc_device" [drivers/staging/ipath/ib_ipath.ko] undefined! ERROR: "ib_dealloc_device" [drivers/staging/ipath/ib_ipath.ko] undefined! ERROR: "ib_dispatch_event" [drivers/staging/ipath/ib_ipath.ko] undefined! ERROR: "ib_register_devi

Re: [PATCH] staging: iio: adc: lpc32xx: use correct reutrn value

2015-08-31 Thread Jonathan Cameron
On 30/08/15 09:12, Peng Fan wrote: > To lpc32xx_adc driver, when platform_get_resource or > platform_get_irq failed, we should use -ENXIO as a > return value, but not -EBUSY. > > Signed-off-by: Peng Fan > Cc: Jonathan Cameron > Cc: Hartmut Knaack > Cc: Lars-Peter Clausen > Cc: Peter Meerwald

RE: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

2015-08-31 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Monday, August 31, 2015 7:02 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; > jbottom...@parallels

Re: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

2015-08-31 Thread James Bottomley
On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote: > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying > tags. What's the actual problem description this causes? James > Signed-off-by: K. Y. Srinivasan > Cc: sta...@vger.kernel.org > --- > drivers/scsi/storvs

[PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

2015-08-31 Thread K. Y. Srinivasan
Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying tags. Signed-off-by: K. Y. Srinivasan Cc: sta...@vger.kernel.org --- drivers/scsi/storvsc_drv.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvs