[PATCH] Staging : wilc1000: Remove braces for single statement blocks

This patch fixes the following checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Shraddha Barke --- drivers/staging/wilc1000/coreconfigurator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/core

Re: [PATCH 2/4] Staging: most: fix snprintf() is printing too much

On Tue, Jul 28, 2015 at 05:16:09PM +0200, Christian Gromm wrote: > This patch prevents snprintf from exceeding a given buffer size. > > Reported-by: Dan Carpenter > Signed-off-by: Christian Gromm > --- > - snprintf(devnod_buf, PAGE_SIZE, "%s-%s", mdev, mdev_ch); > + snpr

[PATCH] Staging : wilc1000: Remove unnecessary parentheses

Remove parentheses around the right hand side of an assignment as they are not needed The semantic patch used is : @@ expression E; expression f; constant C; @@ ( f = (E == C) | f = - ( E - ) ) Signed-off-by: Shraddha Barke --- drivers/staging/wilc1000/wilc_sdio.c | 2 +- 1 file changed, 1

Re: [RFC PATCH] staging: rtl8192e: Rework EEPROM handling code

On Tue, Jul 28, 2015 at 11:52:42PM +0200, Mateusz Kulikowski wrote: > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.c > b/drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.c > index ed54193..fe4e282 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.c > +++ b/drivers/staging/rtl81

Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

On Tue, Jul 28, 2015 at 10:49:52AM -0700, Joshua Clayton wrote: > > Changing the line breaks here is a tiny change on the same line and so > > it's fine. It fits into the one thing per patch rule. > > This is the style I prefer (getting rid of the explicit == true) > > - if ((r8712_is_cckrat

[RFC PATCH] staging: rtl8192e: Rework EEPROM handling code

Device configuration is stored in SPI EEPROM (93c46 or 93c56) configured in 128|256x16 mode. Communication is handled using gpio bitbang. Signed-off-by: Mateusz Kulikowski --- Notes: I did little cleanup of EEPROM handling code. This file basically implements bitbang SPI using s

[PATCH 08/11] staging: rtl8192e: Remove phy_RF8256_Config_ParaFile

Merge function into rtl92e_config_rf as having them separated gives no benefit. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190

[PATCH 10/11] staging: rtl8192e: Drop large switch in rtl92e_config_rf

The same steps were made for each RF path independently. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 69 +++--- 1 file changed, 9 insertions(+), 60 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/driv

[PATCH 06/11] staging: rtl8192e: Simplify rtl92e_is_halfn_supported_by_ap

Function should return struct member - no extra logic is needed. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl81

[PATCH 05/11] staging: rtl8192e: MgntActSet_RF_State: remove ProtectOrNot parameter

It is set at the very beginning of function to a constant value. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 ++-- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 60 +++--- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 +-

[PATCH 04/11] staging: rtl8192e: Remove rtl8192_data_hard_resume

Function is empty; rtllib checks if handler is NULL. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 14

[PATCH 11/11] staging: rtl8192e: probe: iounmap mmio when probe fails

In case of probe failure, io memory was not released properly. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl

[PATCH 07/11] staging: rtl8192e: Simplify rtl92e_set_bandwidth

Move phy version check outside of the loop. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 53 -- 1 file changed, 18 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/

[PATCH 09/11] staging: rtl8192e: Fix IW_IOCTL macro

Macro caused checkpatch complaints - replace [] braces with () and use [] braces as array initializers. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 68 +++--- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/drivers/st

[PATCH 03/11] staging: rtl8192e: Remove rtl8192_data_hard_stop

Function is empty; rtllib checks if handler is NULL. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 584b

[PATCH 00/11] staging: rtl8192e: More cleanups

Another cleanup series for 8192e driver. It should apply cleanly to current staging-next (6e64e224). Series was target tested as usual. Patches 1-5 are trivial. Patch 11 fixes possible resource leak (when probe fails). Mateusz Kulikowski (11): staging: rtl8192e: Remove rtl8192_phy_updateInitGa

[PATCH 02/11] staging: rtl8192e: Remove ActUpdateChannelAccessSetting

Function is empty and called only once. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 6 -- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 --- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 4 3 files changed, 13 deletions(-) diff --git a

[PATCH 01/11] staging: rtl8192e: Remove rtl8192_phy_updateInitGain

Function is empty and called only once. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 1 - drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 4 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h | 1 - 3 files changed, 6 deletions(-) diff --git a/drivers

[PATCH v3 5/5] staging: lustre: added a space between concatenated strings

A space has been inserted between two concatenated strings as required from checkpatch.pl These two updates do not lead to any problem as DFID is defined as a string in ./drivers/staging/lustre/lustre/include/lustre/lustre_user.h The script checkpatch.pl does not return any other warning/error.

[PATCH v3 2/5] staging: lustre: fixed comments without */ on a new line

This patch fixes 4 comments without */ on a new line Signed-off-by: Mario Bambagini --- drivers/staging/lustre/lustre/llite/llite_capa.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lus

[PATCH v3 4/5] staging: lustre: modified comparisons against NULL

The explicit comparisons against NULL has been modified to be shorter. Signed-off-by: Mario Bambagini --- drivers/staging/lustre/lustre/llite/llite_capa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/l

[PATCH v3 1/5] staging: lustre: fixed lines longer than 80 chars

this set of patches fixes several code style problems: -patch 1: lines with more than 80 chars -patch 2: comments without */ on a separate line -patch 3: bad alignment of lines split on more than one line -patch 4: modified comparisons against NULL -patch 5: added spaces between concatenated string

[PATCH v3 3/5] staging: lustre: fixed bad alignment

This patch fixes 7 bad alignments. When a line is split on more than one line, the other lines must be aligned with paranthesis. Signed-off-by: Mario Bambagini --- drivers/staging/lustre/lustre/llite/llite_capa.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/

Re: [patch 1/2] Staging: rtl8192e: array overflow in rtl92e_set_swcam()

On 28.07.2015 17:48, Dan Carpenter wrote: > "EntryNo" is comes from the user in the ioctl and it's a number between > 0-255. The ieee->swcamtable[] array only has 32 elements so it can > result in memory corruption. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/staging/rtl8192e/rtl8

Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

On Tuesday, July 28, 2015 06:56:38 PM Dan Carpenter wrote: > On Tue, Jul 28, 2015 at 08:50:04AM -0700, Joshua Clayton wrote: > > On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote: > > > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > > > b/drivers/staging/rtl8712/rtl871x_io

[PATCH -next] staging: most: fix aim-network build errors

"eth_mac_addr" [drivers/staging/most/aim-network/aim_network.ko] undefined! Signed-off-by: Randy Dunlap Cc: Andrey Shvetsov To: Christian Gromm Cc: Michael Fabry Cc: Christian Gromm --- drivers/staging/most/aim-network/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletio

Re: [RFC] Generic VME UIO

Hi Dmitry, On 22/07/15 19:09, Dmitry Kalinkin wrote: Linux kernel has supported VME bus since 2009. The support comes in a form of kernel driver API that is backed by a couple drivers for PCI-VME bridges. There is also a vme_user driver that provides a generic userpsace interface to do data tra

re: Staging: most: add MOST driver's aim-v4l2 module

Hello Christian Gromm, The patch 3d31c0cb6c12: "Staging: most: add MOST driver's aim-v4l2 module" from Jul 24, 2015, leads to the following static checker warning: drivers/staging/most/aim-v4l2/video.c:623 aim_exit() error: double unlock 'spin_lock:&list_lock' drivers/staging/mos

re: Staging: most: add MOST driver's hdm-usb module

Hello Christian Gromm, The patch a4198cdf0c34: "Staging: most: add MOST driver's hdm-usb module" from Jul 24, 2015, leads to the following static checker warning: drivers/staging/most/hdm-usb/hdm_usb.c:147 trigger_resync_vr() error: doing dma on the stack (&data) drivers/staging/

[PATCH 3/6] staging: unisys: visornic - correctly reset flag prior to send_enbdis()

From: Tim Sell Because devdata->enab_dis_acked is the flag used to determine whether an enable/disable operation to the IO partition has completed, it should always be cleared prior to initiating the operation. The call added to visornic_enable_with_timeout() added in this patch makes the usage

[PATCH 5/6] staging: unisys: visornic: enable skb->len error-check, remove DEBUG blocks

From: Tim Sell * A skb->len error-check was enabled (removed from a "#ifdef DEBUG" block). * Several unneeded "#ifdef DEBUG" blocks were removed. * A dev_err() was converted to the more-appropriate netdev_err(). Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/

[PATCH 0/6] staging: unisys: more visornic fixes

This patch series contains fixes for problems found in visornic during testing. Two patches that were rejected from the previous set were revised to address the issues that were brought up, and the patch from Kees Cook was rebased so that it would apply cleanly. Kees Cook (1): staging: unisys:

[PATCH 6/6] staging: unisys: visornic - consolidate+simplify xmit watermark checks

From: Tim Sell The code that tests for high and low xmit watermarks was consolidatedand simplified. The output behavior should be identical, with the exception of an off-by-one error being corrected in the tests done when the counters overflowed. Signed-off-by: Tim Sell Signed-off-by: Benjamin

[PATCH 4/6] staging: unisys: visornic_resume needs to mirror _serverdown_complete

From: Tim Sell Previously we simplified the serverdown function to basically turn it into a dev_close(), but missed the analogous logic in visornic_resume() (which is essentially the "book-end" of visornic_serverdown_complete()). As a result, during IO partition recovery, the nic would go closed

[PATCH 2/6] staging: unisys: visornic - prevent lock recursion after IO recovery

From: Tim Sell In the patch which changed the serverdown logic to by synchronous, we were mistakenly holding on to devdata->priv_lock in the call to visornic_serverdown_complete(), which ultimately ended up recursively attempting to grab the same lock via the path: --> dev_close -->

[PATCH 1/6] staging: unisys: avoid format string parsing

From: Kees Cook This makes sure the kthread name can't be parsed as a format string. Signed-off-by: Kees Cook Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visornic/v

[patch 2/2] staging: rtl8192e: don't just print an error and continue

I was looking at how TOTAL_CAM_ENTRY is used and I saw this code. We print an error but continue writing "EntryNo" to a register as if it were valid. "EntryNo" is controlled by the user in rtl8192_ioctl() so it definitely can be invalid. I'm not positive what happens with the invalid data but it

Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

On Tue, Jul 28, 2015 at 08:50:04AM -0700, Joshua Clayton wrote: > On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote: > > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > > index 83d4bca..1ded691 100644 > > > --- a/drivers

Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

On Tue, 28 Jul 2015, Joshua Clayton wrote: > On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote: > > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > > index 83d4bca..1ded691 100644 > > > --- a/drivers/staging/rtl8712/r

Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote: > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > index 83d4bca..1ded691 100644 > > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > +++ b/drivers/staging/rtl8712/r

[patch 1/2] Staging: rtl8192e: array overflow in rtl92e_set_swcam()

"EntryNo" is comes from the user in the ioctl and it's a number between 0-255. The ieee->swcamtable[] array only has 32 elements so it can result in memory corruption. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_

Re: [PATCH 1/4] Staging: most: fix bad min() casting

On Tue, Jul 28, 2015 at 05:16:08PM +0200, Christian Gromm wrote: > This patch fixes wrong casting. A high value of "len" is casted to > negative and thus the minimum resulting in memory corruption. > It can't actually though, because it's capped at a PAGE_SIZE, I think. Pretty much all kernel rea

Re: [PATCHv2,2/2] Staging: dgnc: dgnc_driver.c: Add end tag to dgnc_init_module()

On Mon, Jul 27, 2015 at 04:10:29PM +0800, Navy Cheng wrote: > if (rc < 0) > - return rc; > + goto end; Ideally, you should be able to guess from the label name sort of what the goto does. Good names are like "goto unregister;" or "goto err_free_sd;". "end" is a bad

Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > index 83d4bca..1ded691 100644 > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > @@ -204,13 +204,13 @@ static inline char *tra

[PATCH 4/4] Staging: most: fix passing a potential null pointer

This patch fixes passing of a potential null pointer. Reported-by: Dan Carpenter Signed-off-by: Christian Gromm --- drivers/staging/most/aim-cdev/cdev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev

[PATCH 1/4] Staging: most: fix bad min() casting

This patch fixes wrong casting. A high value of "len" is casted to negative and thus the minimum resulting in memory corruption. Reported-by: Dan Carpenter Signed-off-by: Christian Gromm --- drivers/staging/most/mostcore/core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 3/4] Staging: most: fix dereferencing freed memory

This patch fixes the dereferencing of freed memory. Reported-by: Dan Carpenter Signed-off-by: Christian Gromm --- drivers/staging/most/aim-cdev/cdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cde

[PATCH 2/4] Staging: most: fix snprintf() is printing too much

This patch prevents snprintf from exceeding a given buffer size. Reported-by: Dan Carpenter Signed-off-by: Christian Gromm --- drivers/staging/most/mostcore/core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most

Re: [PATCH] staging: dgnc: dgnc_neo.c: Style and spelling fixes

On Tue, Jul 28, 2015 at 06:18:05PM +0530, Bhaktipriya Shridhar wrote: > This patch fixes: > 1.Fixes comments that are over 80-characters either by: > -breaking up comment lines, into multi-line comments (kernel style) or > -shortening comments (Done in 7 places): > - Chan

Re: [staging:staging-testing 413/420] drivers/staging/most/aim-cdev/cdev.c:128 aim_close() error: dereferencing freed memory 'channel'

On Mon, 27 Jul 2015 12:18:33 +0300 Dan Carpenter wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 59cc3399efd61fabb7f4aa23d4498bd9b01e5f6d > commit: 9bc79bbcd0c526e3ec7b98e08c5d34648bb3c158 [413/420] Staging: most: add > MOST driver's

[PATCH V3 RESEND 6/8] staging: rtl8712: rename function

Rename r8712_get_ndis_wlan_bssid_ex_sz() to r8712_get_wlan_bssid_ex_sz(), which corresponds to the struct whose size it measures. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/rtl871x_cmd.c | 8 drivers/staging/rtl8712/rtl871x_mlme.c | 16 drivers/

[PATCH V3 RESEND 7/8] staging: rtl8712: remove typedefs

Coding style fix. Get rid of typedefs NDIS_802_11_RATES and NDIS_802_11_RATES_EX Undo any casting that was done as a result of the typedef. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 ++-- drivers/staging/rtl8712/wlan_bssdef.h | 7 +-

[PATCH V3 RESEND 5/8] staging: rtl8712: remove duplicate struct

struct ndis_wlan_bssid_ex is a doppelganger of struct wlan_bssid_ex, and is used about a third as often. Switch all instances to wlan_bssid_ex, and remove ndis_wlan_bssid_ex This also gets rid of a use of typedef NDIS_802_11_RATES_EX Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/rt

[PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

Change the value to a name that conforms to Linux coding style. "rates" is equally expressive in this context, and I have left alone a comment and function name that describe the rates as supported rates. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/ieee80211.c | 22 +

[PATCH V3 RESEND 2/8] staging: rtl8712: simplify size calculation

replace item-by-item size calculation of a struct with the size of the struct. This gets rid of a use of typedef NDIS_802_11_RATES_EX Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/rtl871x_cmd.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/

Re: [PATCHv2,2/2] Staging: dgnc: dgnc_driver.c: Add end tag to dgnc_init_module()

On Mon, Jul 27, 2015 at 03:26:57PM +0530, Sudip Mukherjee wrote: > On Mon, Jul 27, 2015 at 04:10:29PM +0800, Navy Cheng wrote: > > The work flow of dgnc_init_module() is base on if statment. Here is a > > nest "if" in the function. > > > > To avoid the nest if statment, make the code easier to und

[PATCH] staging: dgnc: dgnc_neo.c: Style and spelling fixes

This patch fixes: 1.Fixes comments that are over 80-characters either by: -breaking up comment lines, into multi-line comments (kernel style) or -shortening comments (Done in 7 places): - Changed "Why?Becuz" to "Since" (6 places) - Removed the commen

Re: [PATCH V3 0/8] clean up wlan_bssdef.h

On Tuesday, July 28, 2015 07:27:53 AM Julia Lawall wrote: > Something horrible seems to have happened in your patch sending process, > and you have the same message over and over. > I see that now. :( This was a failed work-around to git-send-email I forgot I had done early in the day. I'll fix

Re: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation

On Tuesday, July 28, 2015 05:16:56 PM Sudip Mukherjee wrote: > On Mon, Jul 27, 2015 at 09:41:10PM -0700, Joshua Clayton wrote: > > r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)" > > where the underlying struct has a 6 * unsigned char. > > Simplify the calculation by just subtract

Re: [PATCH v2] staging: android: Fixed line over 80 char

On Tue, Jul 28, 2015 at 04:19:36PM +0530, Jignesh R Patel wrote: > From: Jignesh R Patel For your next patches please do not add this From: line here. It is not needed. It will be taken from your email From: header. regards sudip ___ devel mailing list

Re: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation

On Mon, Jul 27, 2015 at 09:41:10PM -0700, Joshua Clayton wrote: > r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)" > where the underlying struct has a 6 * unsigned char. > Simplify the calculation by just subtracting the variable part from > the size of the struct. > > This also g

Re: [PATCH v2 3/5] staging: lustre: fix bad alignment

On Mon, Jul 27, 2015 at 09:20:23PM +0200, Mario Bambagini wrote: > This patch fixes 8 bad alignments. When a line is split on > more than one line, the other lines must be aligned with > paranthesis. > > Signed-off-by: Mario Bambagini > --- > drivers/staging/lustre/lustre/llite/llite_capa.c | 16

Re: [PATCH v2 2/5] staging: lustre: fixed 80-char rule

On Mon, Jul 27, 2015 at 09:20:22PM +0200, Mario Bambagini wrote: > This patch fixes 2 lines longer than 80 chars > > The first one is a function whose argument has been moved to next line. > The second one is a comment split on two lines > > Signed-off-by: Mario Bambagini > --- > > -static in

Re: [PATCH] Staging : rtl8188eu : os_dep : Compression of lines for immediate return

On Mon, Jul 27, 2015 at 07:37:40PM +0530, Shraddha Barke wrote: > This patch compresses two lines into a single line if immediate return is > found. Also remove variable ret as it is no longer needed. Hi Shraddha, Something is wrong. All your patches are coming 2 times. You had me in the Cc list o

Re: [PATCH] Staging: dgnc: Merge lines and remove unused variable for immediate return

On Mon, Jul 27, 2015 at 07:35:15PM +0530, Shraddha Barke wrote: > This patch compresses two lines into a single line if immediate return > is found. Variable rc is dropped as it is no longer needed. same patch again? regards sudip ___ devel mailing list

[PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt when hvsock's callback is running

In the SMP guest case, when the per-channel callback hvsock_events() is running on virtual CPU A, if the guest tries to close the connection on virtual CPU B: we invoke vmbus_close() -> vmbus_close_internal(), then we can have trouble: on B, vmbus_close_internal() will send IPI reset_channel_cb() t

Re: [PATCH] Staging: dgnc: Merge lines and remove unused variable for immediate return

On Mon, Jul 27, 2015 at 07:29:36PM +0530, Shraddha Barke wrote: > This patch compresses two lines into a single line if immediate return > is found. Variable rc is dropped as it is no longer needed. > > - return rc; > + return wait_event_interruptible(un->un_flags_wait, ((un->un_flags &

[PATCH V4 6/7] hvsock: introduce Hyper-V VM Sockets feature

Hyper-V VM sockets (hvsock) supplies a byte-stream based communication mechanism between the host and a guest. It's kind of TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V VM Sockets, applications between the host and a guest can talk with each other direc

[PATCH V4 5/7] Drivers: hv: vmbus: add a helper function to set a channel's pending send size

This will be used by the coming net/hvsock driver. Signed-off-by: Dexuan Cui --- include/linux/hyperv.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index fda9790..47c5c1a 100644 --- a/include/linux/hyperv.h +++ b/include/linux/hyperv.

[PATCH V4 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability

This will be used by the coming net/hvsock driver. Signed-off-by: Dexuan Cui --- drivers/hv/channel.c | 134 ++ drivers/hv/hyperv_vmbus.h | 4 ++ drivers/hv/ring_buffer.c | 14 + include/linux/hyperv.h| 32 +++ 4 files changed

[PATCH V4 2/7] Drivers: hv: vmbus: define a new VMBus message type for hvsock

A function to send the type of message is also added. The coming net/hvsock driver will use this function to proactively request the host to offer a VMBus channel for a new hvsock connection. Signed-off-by: Dexuan Cui --- drivers/hv/channel.c | 15 +++ drivers/hv/channel_mgmt.c

[PATCH V4 4/7] Drivers: hv: vmbus: add APIs to register callbacks to process hvsock connection

With the 2 APIs supplied by the VMBus driver, the coming net/hvsock driver can register 2 callbacks and can know when a new hvsock connection is offered by the host, and when a hvsock connection is being closed by the host. Signed-off-by: Dexuan Cui --- drivers/hv/Makefile | 4 ++- dr

[PATCH V4 1/7] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock)

A helper function is also added. Signed-off-by: Dexuan Cui --- include/linux/hyperv.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 30d3a1f..2ca3ac1 100644 --- a/include/linux/hyperv.h +++ b/include/linux/hyperv.h @@ -236,6 +236,

[PATCH v4 0/7] introduce Hyper-V VM Sockets(hvsock)

Changes since v1: - updated "[PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature" - added __init and __exit for the module init/exit functions - net/hv_sock/Kconfig: "default m" -> "default m if HYPERV" - MODULE_LICENSE: "Dual MIT/GPL" -> "Dual BSD/GPL" Changes since

[PATCH v2] staging: android: Fixed line over 80 char

From: Jignesh R Patel Fixes the following checkpatch warning: Warning: Line over 80 characters Signed-off-by: Jignesh R Patel --- drivers/staging/android/ion/ion_cma_heap.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/dr

Re: [PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem

The subject isn't right. You aren't patch checkpatch.pl itself you're patching android. The version doesn't go in the subject. The subject is too vague. On Tue, Jul 28, 2015 at 03:28:33PM +0530, Jignesh R Patel wrote: > From: Jignesh R Patel Not needed. > > This patch fix coding style probl

[PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem

From: Jignesh R Patel This patch fix coding style problem of more then 80 character in one line. This patch does not change any logic. Signed-off-by: Jignesh R Patel --- drivers/staging/android/ion/ion_cma_heap.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH 00/21] cover letter of Atmel WILC1000 patches

Looks good. :) Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: comedi: das1800: add missing break in switch

On 27/07/15 18:27, H Hartley Sweeten wrote: Commit 06ad6bd8 "staging: comedi: das1800: cleanup das1800_probe()" Accidently removed the 'break' statement for case 0x8 of the switch. Add it back. Reported-by: coverity (CID 1309550) Signed-off-by: H Hartley Sweeten Cc: Ian Abbott CC: Greg Kroah-

Re: [PATCH] Staging: dgnc: dgnc_neo.c: Fix line over 80 characters

On Tue, Jul 28, 2015 at 02:06:26PM +0530, Bhaktipriya Shridhar wrote: > > - /* Why? Becuz Exar's spec says we have to zero it out before setting it > */ > + /* Why? Becuz Exar's spec says > + * we have to zero it out before setting it */ This is sort of weird indenting and not kern

[PATCH 16/21] staging: wilc1000: remove unnecessary inner braces

This patch removes unnecessary inner braces. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_sdio.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/wilc_sdio.c index 29

[PATCH 20/21] staging: wilc1000: remove unnecessary spcae

From: "Kim, Leo" This patch removes the warnings reported by checkpatch.pl on space prohibited between function name and open parenthesis '(' Signed-off-by: Kim, Leo Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 20 ++-- 1 file changed, 10 insertions(+),

[PATCH 18/21] staging: wilc1000: remove braces {} for single statement blocks

From: "Kim, Leo" This patch removes the warnings reported by checkpatch.pl on braces {} not necessary for the single statement blocks. Signed-off-by: Kim, Leo Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 78 --- 1 file changed, 26 inserti

[PATCH 19/21] staging: wilc1000: remove warnings on the multiple blank lines uses

From: "Kim, Leo" This patch removes the warnings reported by checkpatch.pl for using multiple blank lines. Signed-off-by: Kim, Leo Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 69 --- 1 file changed, 69 deletions(-) diff --git a/drivers/

[PATCH 21/21] staging: wilc1000: update TODO list of WILC1000

The TODO list is updated for the WILC1000 kernel driver. The TODO list contains many items listed in time sequence. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/TODO | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/TODO b/drivers/

[PATCH 17/21] staging: wilc1000: remove unnecessary blank lines

This patch removes the following warnings reported by checkpatch.pl. - Blank lines aren't necessary after an open brace '{' - Blank lines aren't necessary before a close brace '}' Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_sdio.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 10/21] staging: wilc1000: remove unused functions

This patch removes the dead functions which are not used anymore. - sdio_check_bs - sdio_xfer_cnt Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_sdio.c | 56 drivers/staging/wilc1000/wilc_wlan.c | 1 - 2 files changed, 57 deletions

[PATCH 15/21] staging: wilc1000: remove warnings on missing blank line

This patch removes the warnings reported by checkpatch.pl on missing a blank line after declarations. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/wilc_sdio.c

[PATCH 13/21] staging: wilc1000: remove errors on required space

This patch removes the errors reported by checkpatch.pl, which is the space required before the open parenthesis '('. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/d

[PATCH 12/21] staging: wilc1000: alignment should match open parenthesis

From: "Jude.Lee" This patch fixes the checks reported by checkpatch.pl alignment should match open parenthesis Signed-off-by: Jude.Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/sta

[PATCH 11/21] staging: wilc1000: remove multiple blank lines

From: "Jude.Lee" This patch removes the warnings reported by checkpatch.pl for using multiple blank lines. Signed-off-by: Jude.Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/wilc1000/coreco

[PATCH 08/21] staging: wilc1000: remove a dead preprocessor conditionals

This patch removes the preprocessor conditionals which are related to the WILC1000_SINGLE_TRANSFER definition becasue this is not used. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_sdio.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/staging/

[PATCH 14/21] staging: wilc1000: remove warnings on unnecessary braces

This patch removes the warnings reported by checkpatch.pl on the braces {} not necessary for any arm of this statement. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_sdio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c

[PATCH 09/21] staging: wilc1000: #ifdef conditionals cover entire functions

This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than portions of functions or expressions becausue doing so makes code harder to read. Signed-off-by: Tony Cho --- drivers/

[PATCH 05/21] staging: wilc1000: remove the warnings on missing blank line

This patch removes the warnings reported by checkpatch.pl on missing a blank line after declaration. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_sdio.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/

[PATCH 06/21] staging: wilc1000: remove the warnings on unnecessary braces

This patch removes the warnings reported by checkpatch.pl on {} not necessary for the single statement blocks. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_sdio.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/staging/wilc1

[PATCH 02/21] staging: wilc1000: describe the config symbol fully

This patch removes the warnings reported by checkpatch.pl on the short description for the config symbol in the Kconfig by adding more comments to describe the config symbol in more detail. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Kconfig | 28 1 file cha

[PATCH 01/21] staging: wilc1000: remove unnecessary files

This patch removes the following files which are not used anymore. - fifo_buffer.c - fifo_buffer.h - coreconfigsimulator.h - wilc_wfi_netdevice.c Signed-off-by: Robin Hwang Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Makefile | 4 +- drive

[PATCH 07/21] staging: wilc1000: remove preprocessor conditionals unused

This patch removes unused preprocessor conditionals for the PLAT_AML8726_M3_BACKUP and PLAT_AML8726_M3 which are not used and so dead codes. They are also platform-dependent codes. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_sdio.c | 174 +-- 1 file

[PATCH 04/21] staging: wilc1000: remove warnings on the multiple line uses

This patch removes the warnings reported by checkpatch.pl for using multiple blank lines. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_sdio.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/wilc_sdio

  1   2   >