If DEBUG is set dumpVGAReg is called and tries to access
XGISR which is defined as (xgifb_info->dev_info.P3c4)
which is not known within this function.
-> add as parameter to dumpVGAReg so xgifb_info becomes known
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/XGI_main_26.c | 8
This makes sure the kthread name can't be parsed as a format string.
Signed-off-by: Kees Cook
---
drivers/staging/unisys/visornic/visornic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic
On Fri, Jul 24, 2015 at 01:35:51PM -0700, Greg KH wrote:
> On Fri, Jul 24, 2015 at 12:00:19PM -0400, Benjamin Romer wrote:
> > From: Neil Horman
> >
> > Missed this in my initial review. The usage counter that guards against
> > kthread task is horribly racy. The atomic is self consistent, but
On Fri, Jul 24, 2015 at 04:11:47PM +0200, Christian Gromm wrote:
> This patchset adds the components of the Media Oriented Systems Transport
> (MOST) driver to the kernel's driver staging area and adapts the build
> system accordingly. By including this driver Linux applications will be
> able to a
On Fri, Jul 24, 2015 at 04:11:48PM +0200, Christian Gromm wrote:
> This patch adds the core module of the MOST driver to the kernel's driver
> staging area. This module is part of the MOST driver and handles the
> configuration interface in sysfs, the buffer management and the data
> routing.
I
On Fri, Jul 24, 2015 at 12:00:24PM -0400, Benjamin Romer wrote:
> From: Tim Sell
>
> The code that tests for high and low xmit watermarks was consolidated and
> simplified. The output behavior should be identical, with the exception
> of an off-by-one error being corrected in the tests done when
On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote:
> linux/ieee80211.h already defines constants for information element IDs.
> Include it where needed, resolve discrepancies in naming, and remove the
> duplicated definitions.
>
> While at it, wrap a line that was too long and remove
On Fri, Jul 24, 2015 at 12:00:20PM -0400, Benjamin Romer wrote:
> From: Tim Sell
>
> Add an error check here for use with dynamic debugging.
>
> Signed-off-by: Benjamin Romer
> Signed-off-by: Tim Sell
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 6 +++---
> 1 file changed, 3 inse
On Fri, Jul 24, 2015 at 12:00:19PM -0400, Benjamin Romer wrote:
> From: Neil Horman
>
> Missed this in my initial review. The usage counter that guards against
> kthread task is horribly racy. The atomic is self consistent, but theres
> nothing that prevents the service_resp_queue function from
On Thu, Jul 23, 2015 at 09:57:50PM -0700, Joshua Clayton wrote:
> struct ndis_wlan_bssid_ex is a dopelganger of
> struct wlan_bssid_ex, and is used about a third as often
>
> Switch all instances to wlan_bssid_ex
>
> This also gets rid of a use of typedef NDIS_802_11_RATES_EX
>
> Signed-off-by:
On Thursday, July 23, 2015 8:47 AM, Ian Abbott wrote:
>
> Fix some minor problems in the testing of asynchronous commands for the AI
> and AO subdevices and remove some redundant code.
>
> The main problem is that the testing of a new command can affect the
> operation of an already running command
Reviewed-by: Bernd Porr
Ian Abbott wrote:
`devpriv->ai_timer` is used while an asynchronous command is running on
the AI subdevice. It also gets modified by the subdevice's `cmdtest`
handler for checking new asynchronous commands
(`usbduxsigma_ai_cmdtest()`), which is not correct as it's allow
Reviewed-by: Bernd Porr
Ian Abbott wrote:
The AI subdevice `cmdtest` handler `usbduxsigma_ai_cmdtest()` ensures
that `cmd->scan_begin_src == TRIG_TIMER` by the end of step 2 of the
command checking code, so assume that this is the case for step 3
onwards and remove the redundant code.
Signed-o
Reviewed-by: Bernd Porr
Ian Abbott wrote:
The return value of the `cmdtest` handler for a subdevice checks the
prospective new command in various steps and returns the step number at
which any problem was detected, or 0 if no problem was detected. It is
allowed to modify the command in various
Reviewed-by: Bernd Porr
Ian Abbott wrote:
The return value of the `cmdtest` handler for a subdevice checks the
prospective new command in various steps and returns the step number at
which any problem was detected, or 0 if no problem was detected. It is
allowed to modify the command in various
Reviewed-by: Bernd Porr
Ian Abbott wrote:
The `cmdtest` and `cmd` handlers for the AO subdevice
(`usbduxsigma_ao_cmdtest()` and `usbduxsigma_ao_cmd()`) support "scan"
timing of commands with all channels updated every "scan" period. There
is some disabled code to use "convert" timing in high s
Reviewed-by: Bernd Porr
Ian Abbott wrote:
`devpriv->ao_timer` is used while an asynchronous command is running on
the AO subdevice. It also gets modified by the subdevice's `cmdtest`
handler for checking new asynchronous commands,
`usbduxsigma_ao_cmdtest()`, which is not correct as it's allowe
Defining and using strtoul in lustre code results in the following
compile warnings (arm64:allmodconfig).
include/linux/libcfs/libcfs_string.h:105:0: warning: "strtoul" redefined
#define strtoul(str, endp, base) simple_strtoul(str, endp, base)
include/acpi/platform/aclinux.h:122:0: note:
From: Prarit Bhargava
This patch adds modalias files that export the device UUID type to sysfs
so that udev can autoload the appropriate device driver on demand. Note
that is required a minor name change to the channel device sysfs files
which are currently named visorbus_dev_groups, and are now
From: Prarit Bhargava
This patch adds an module alias and a MODULE_DEVICE_TABLE to autoload the
visorhba driver when an appropriate device is created by the visorbus.
Signed-off-by: Prarit Bhargava
---
drivers/staging/unisys/visorhba/visorhba_main.c | 2 ++
1 file changed, 2 insertions(+)
dif
From: Prarit Bhargava
This patch adds an module alias and a MODULE_DEVICE_TABLE to autoload
the
visorhid driver when an appropriate device is created by the visorbus.
Additional code cleanups to match the other visor* drivers.
Signed-off-by: Prarit Bhargava
---
drivers/staging/unisys/visorhid/
From: Prarit Bhargava
This file has a lot of dead comments and needs to be cleaned up.
Signed-off-by: Prarit Bhargava
---
drivers/staging/unisys/include/channel_guid.h | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/unisys/include/chann
From: Prarit Bhargava
Define additional strings for module loading code ease of use.
Signed-off-by: Prarit Bhargava
---
drivers/staging/unisys/include/channel_guid.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/unisys/include/channel_guid.h
b/drivers/staging/unisys/
From: Prarit Bhargava
This patch adds an module alias and a MODULE_DEVICE_TABLE to autoload the
visornic driver when an appropriate device is created by the visorbus.
Signed-off-by: Prarit Bhargava
---
drivers/staging/unisys/visornic/visornic_main.c | 2 ++
1 file changed, 2 insertions(+)
dif
This patch series adds support for automatically loading the unisys
drivers from modules.
Prarit Bhargava (6):
drivers, staging, unisys, cleanup channel_guid.h
staging: unisys: add UUID strings to channel_guid.h
drivers, staging, unisys Add modalias files to visorbus devices
drivers, stagi
From: Tim Sell
Add an error check here for use with dynamic debugging.
Signed-off-by: Benjamin Romer
Signed-off-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_m
From: Tim Sell
The code that tests for high and low xmit watermarks was consolidated and
simplified. The output behavior should be identical, with the exception
of an off-by-one error being corrected in the tests done when the counters
overflowed.
Note that the literals passed to max() macros ne
From: Tim Sell
Logic to check for failures of visorchannel_signalinsert() and
visorchannel_signalremove() were added, and a new sent_post_failed counter
tracks the number of times we failed to post a rcv buffer to the IO
partition.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
dri
From: David Kershner
This driver create a host bus adapter device when s-Par sends a
device create message to create a storage adapter on the visorbus.
When the message is received by visorbus, the visorhba_probe function
is called and the hba device is created and managed by the visorhba
driver.
From: Neil Horman
Missed this in my initial review. The usage counter that guards against
kthread task is horribly racy. The atomic is self consistent, but theres
nothing that prevents the service_resp_queue function from re-incrementing
it immediately after the check in disable_with_timeout is
From: Tim Sell
After IO partition recovery, it was possible to get into a situation where
a visornic device would repeatedly report:
NETDEV WATCHDOG: eth0 (): transmit queue 0 timed out
The actual problem would affect any visornic device that was rapidly
transmitting at the same time the IO
From: Tim Sell
visornic tx reset handling is done asynchronously via a workqueue in
visornic_timeout_reset(). As a result, it needs to use rtnl_lock() /
rtnl_unlock() to lock against possible simultaneous close() of the network
device.
(I consulted the bnx2 driver as a model here, as that drive
This patch series fixes more technical issues and bugs found in visornic
testing.
David Kershner (1):
staging: unisys: Process more than one response per check
Neil Horman (1):
staging: unisys: visornic: fix serialization mechanism around usage
atomic
Tim Sell (5):
staging: unisys: add
From: David Kershner
When s-Par is in polling mode it checks every 2 ms to see if there is
a response from the IO service partition in the queue. Currently it
just reads one entry per 2 ms, this needs to be changed so it drains
the queue on each check.
Signed-off-by: David Kershner
Signed-off-b
This patch adds data structures and handlers for messages related
to SRIOV Virtual Function.
Signed-off-by: Haiyang Zhang
Reviewed-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h | 29 ++
drivers/net/hyperv/netvsc.c | 43 +
linux/ieee80211.h already defines constants for information element IDs.
Include it where needed, resolve discrepancies in naming, and remove the
duplicated definitions.
While at it, wrap a line that was too long and remove extra parentheses
in an expression that mixes only equality and logical op
Flag is never set. Remove it and the code that is dead because of it.
Signed-off-by: Jakub Sitnicki
---
drivers/staging/rtl8188eu/hal/odm.c | 11 --
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 21 --
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2
This patch adds the hdm-dim2 module of the MOST driver to the kernel's
driver staging area. This module is part of the MOST driver and handles
the MediaLB interface of the MOST network interface controller.
This patch is needed in order to use the MediaLB peripheral interface of
the network interf
This patch adds the hdm-usb module of the MOST driver to the kernel's
driver staging area. This module is part of the MOST driver and handles
the USB interface of the MOST network interface controller.
This patch is needed in order to use the USB peripheral interface of the
network interface contr
This patch adds the documentation to the MOST driver that describes its ABI
interface and the basic usage.
Signed-off-by: Christian Gromm
---
.../most/Documentation/ABI/sysfs-class-most.txt| 181
.../staging/most/Documentation/driver_usage.txt| 180
This patch adds the hdm-i2c module of the MOST driver to the kernel's
driver staging area. This module is part of the MOST driver and handles
the I2C interface of the MOST network interface controller.
This patch is needed in order to use the I2C peripheral interface of the
network interface contr
This patch adds the aim-cdev module of the MOST driver to the kernel's
driver staging area. This module is part of the MOST driver and handles
user space interaction by means of character devices.
This patch is needed in order to have access to MOST data through
character devices.
Signed-off-by:
This patch adds the aim-sound module of the MOST driver to the kernel's
driver staging area. This module is part of the MOST driver and handles
user space interaction by means of ALSA devices.
This patch is needed in order to have access to MOST synchronous data
through ALSA devices.
Signed-off-b
This patch adds the aim-v4l2 module of the MOST driver to the kernel's
driver staging area. This module is part of the MOST driver and handles
user space interaction by means of V4L2.
This patch is needed in order to have access to MOST isochronous AVP data
through V4L2 devices.
Signed-off-by: Ch
This patch adds the core module of the MOST driver to the kernel's driver
staging area. This module is part of the MOST driver and handles the
configuration interface in sysfs, the buffer management and the data
routing.
Signed-off-by: Christian Gromm
---
This patchset adds the components of the
This patch adds the aim-network module of the MOST driver to the kernel's
driver staging area. This module is part of the MOST driver and handles
user space interaction by means of network devices.
This patch is needed in order to have access to MOST Ethernet Packets (MEP)
through a networking dev
This patchset adds the components of the Media Oriented Systems Transport
(MOST) driver to the kernel's driver staging area and adapts the build
system accordingly. By including this driver Linux applications will be
able to access a MOST network: The Automotive Information Backbone and the
de-fact
Dan,
On Friday, July 24, 2015 01:52:27 PM Dan Carpenter wrote:
> Write a better subject line.
>
> On Thu, Jul 23, 2015 at 09:53:18PM -0700, Joshua Clayton wrote:
> > change instances SupportedRates to compliant and sane "rates"
> > This change in no way harms readability, and brings several lines
On Fri, Jul 24, 2015 at 05:39:29AM -0700, Joshua Clayton wrote:
> On Friday, July 24, 2015 02:02:56 PM Sudip Mukherjee wrote:
> > On Thu, Jul 23, 2015 at 09:57:50PM -0700, Joshua Clayton wrote:
> > > struct ndis_wlan_bssid_ex is a dopelganger of
> > > struct wlan_bssid_ex, and is used about a third
On Fri 2015-07-24 07:39:15, atull wrote:
> On Fri, 24 Jul 2015, Pavel Machek wrote:
>
> Hi Pavel,
>
> Thanks for your your feedback in cleaning up these docs.
>
> > Hi!
> >
> > > +What:/sys/class/fpga_manager//state
> > > +Date:July 2015
> > > +KernelVersion: 4.2
> > >
On Friday, July 24, 2015 02:02:56 PM Sudip Mukherjee wrote:
> On Thu, Jul 23, 2015 at 09:57:50PM -0700, Joshua Clayton wrote:
> > struct ndis_wlan_bssid_ex is a dopelganger of
> > struct wlan_bssid_ex, and is used about a third as often
> >
> > Switch all instances to wlan_bssid_ex
> >
> > This a
On Fri, 24 Jul 2015, Pavel Machek wrote:
Hi Pavel,
Thanks for your your feedback in cleaning up these docs.
> Hi!
>
> > +What: /sys/class/fpga_manager//state
> > +Date: July 2015
> > +KernelVersion: 4.2
> > +Contact: Alan Tull
> > +Description: Read fpga m
> At the begin of my work on this patchset I even denied clock disable call if
> slave is registered (to minimize code that can affect transfer).
I hacked something like this, but it seems it was not enough.
> If only slave mode is used, then this logic is not needed.
This is not sufficent. We
Write a better subject line.
On Thu, Jul 23, 2015 at 09:53:18PM -0700, Joshua Clayton wrote:
> change instances SupportedRates to compliant and sane "rates"
> This change in no way harms readability, and brings several lines
> under the 80 character limit.
>
Yeah, but it does a some other stuff
On Thu, Jul 23, 2015 at 09:38:33PM -0700, Joshua Clayton wrote:
> r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
> where the underlying struct has a 6 * unsigned char.
> Simplify the calculation by just subtracting the variable part from
> the size of the struct.
>
> This also g
On 24.07.2015 12:27, Wolfram Sang wrote:
Still doesn't work for me and I think I understand why. Do you run your
I2C controller in slave mode only?
Yes.
That might work, but using it in
master/slave mode simultanously won't work yet as I see it:
* After every transfer (as master), clocks get
Hi Andrey,
On Mon, Jul 20, 2015 at 11:35:43PM +0300, Andrey Danin wrote:
> Initialization code is based on NVEC driver.
>
> There is a HW bug in AP20 that was also mentioned in kernel sources
> for Toshiba AC100.
>
> Signed-off-by: Andrey Danin
Still doesn't work for me and I think I understan
On Fri, Jul 24, 2015 at 11:57:01AM +0530, Sudip Mukherjee wrote:
> This is also ok, the function is supposed to return ret or-ed with the
> relevant flags based on the scan position. It is considered error if 0
> is returned (without any flag).
Yeah. You're right. I looked through my list again
On Thu, Jul 23, 2015 at 09:57:50PM -0700, Joshua Clayton wrote:
> struct ndis_wlan_bssid_ex is a dopelganger of
> struct wlan_bssid_ex, and is used about a third as often
>
> Switch all instances to wlan_bssid_ex
>
> This also gets rid of a use of typedef NDIS_802_11_RATES_EX
>
> Signed-off-by:
Hi!
> +What:/sys/class/fpga_manager//state
> +Date:July 2015
> +KernelVersion: 4.2
> +Contact: Alan Tull
> +Description: Read fpga manager state as a string.
fpga->FPGA.
> + Valid states may vary by manufacturer; superset is:
> +
60 matches
Mail list logo
