On Fri, Jul 24, 2015 at 12:00:24PM -0400, Benjamin Romer wrote:
> From: Tim Sell <timothy.s...@unisys.com>
> 
> The code that tests for high and low xmit watermarks was consolidated and
> simplified. The output behavior should be identical, with the exception
> of an off-by-one error being corrected in the tests done when the counters
> overflowed.
> 
> Note that the literals passed to max() macros need to be explicitly
> specified as unsigned long (UL), in order to prevent gcc warnings:
> 
>     warning: comparison of distinct pointer types lacks a cast

You do know about max_t(), right?  Please redo this with that call
instead of the odd casting.

thanks,

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to