Re: [PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue

On Thu, Jul 09, 2015 at 11:39:11AM +0530, Ronit Halder wrote: > Fixed a coding style issue. > > Signed-off-by: Ronit Halder Greg has commented in your v1 that it is a false positive. See that: #define DEFINE_DMA_BUF_EXPORT_INFO(a) \ struct dma_buf_export_info a = { .exp_name = KBUILD_MO

[PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue

Fixed a coding style issue. Signed-off-by: Ronit Halder --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 6f48112..e44f5e6 100644 --- a/drivers/staging/android/ion/ion.c +++ b/dri

[PATCH] staging: xgifb: prefer using the BIT macro

From: Hari Prasath Gujulan Elango This patch uses the BIT macro for bit shift operation. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/xgifb/XGI_main_26.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/st

Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote: > From: Ronit Halder > > Fixed a coding style issue. > > Signed-off-by: Ronit Halder > --- > drivers/staging/android/ion/ion.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/android/ion/ion.c > b/drivers/stagin

Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

On Thu, 2015-07-09 at 11:05 +0530, Sudip Mukherjee wrote: > On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote: > > From: Ronit Halder > > You do not need a From: here. Please fix your gitconfig file and > git send-email will give your name correctly in the email header. > > regards > sudip

Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote: > From: Ronit Halder You do not need a From: here. Please fix your gitconfig file and git send-email will give your name correctly in the email header. regards sudip ___ devel mailing list de...@l

[PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

From: Ronit Halder Fixed a coding style issue. Signed-off-by: Ronit Halder --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 6f48112..e44f5e6 100644 --- a/drivers/staging/androi

Re: Clarification for the use of additional fields in the message body

Hi Markus, On Wed, Jul 8, 2015 at 11:46 PM, SF Markus Elfring wrote: >> Is there truly no way to simplify that process? > > I see some software development possibilities which could improve > the communication with high volume mailing lists. You shouldn't need any software development, most peop

Re: [PATCH net-next,v2] hv_netvsc: Add support to set MTU reservation from guest side

From: Haiyang Zhang Date: Mon, 6 Jul 2015 14:11:37 -0700 > When packet encapsulation is in use, the MTU needs to be reduced for > headroom reservation. > The existing code takes the updated MTU value only from the host side. > But vSwitch extensions, such as Open vSwitch, require the flexibility

[PATCH v3] staging: rtl8188eu: core: Fixed 80 character length warning

When the checkpatch.pl script was run, it showed lines with length more than 80 characters in rtw_ap.c file. Fixed line number 382 by breaking it up into two lines within 80 characters. Signed-off-by: Sreenath Madasu --- drivers/staging/rtl8188eu/core/rtw_ap.c | 3 ++- 1 file changed, 2 insertio

Re: [PATCH] defines modified to match the 80-char rule

On Mon, 2015-07-06 at 14:16 +0200, Krzysztof Hałasa wrote: > Joe Perches writes: > > >> So, could we have the localized readability when it makes sense, > >> and the default rules when nothing else applies? > > > > Then the question becomes how local. > > The answer seems easy to me: as much as

Re: [PATCH] Alternate rtl8192cu driver.

On Wed, Jul 08, 2015 at 12:10:15PM +0200, P. Varet wrote: > And Greg KH wrote: > > >That's as "supported" as anything is with Linux :) > > Kind of dispiriting... but so it goes. Why? That's better than you will get from any other operating system, where you don't have access to the developers w

Re: [PATCH 28/37] usb: gadget: pxa27x_udc: add ep capabilities support

Robert Baldyga writes: > Convert endpoint configuration to new capabilities model. The commit message is very short to judge the patch's correctness. I'll side up with Felipe's opinion. If it's fine by him, so it is by me. Cheers. -- Robert ___ devel

Re: [PATCH v2] staging: lustre: make ptlrpc_init static

fix sparse warning in lustre/ptlrpc/ptlrpc_module.c:54:12: warning: symbol 'ptlrpc_init' was not declared. Should it be static? The __init macro is moved before the function name to match standard usage. Signed-off-by: Matt Mooney --- drivers/staging/lustre/lustre/ptlrpc/ptlrpc_module.c |

interested in growing sales?

Hey, We can help you to grow business fast. We provide target email marketing services and can generate you more business and leads. We are looking for long term cooperation which can increase your business sales 2-4 times than now. Please reply back so i can go over options for you. Thanks, Ro

Re: Clarification for the use of additional fields in the message body

On Wed, Jul 08, 2015 at 09:05:53PM +1000, Julian Calaby wrote: > If multiple people are submitting identical changes, then the one that > is applied is the one the maintainer sees first, which will most > likely be determined by which one hit their inbox / list first. Nobody > is going to look at t

Re: Clarification for the use of additional fields in the message body

> Note also that some maintainers have work flow that deliberately smash > the date (i.e., because they are using a system such as guilt), > so if you are depending on the submitted timestamp, it's going to > break on you. Thanks for your hint. I am just trying to offer the possibility for the re

Generic VME UIO driver

> On 08 Jul 2015, at 16:22, Martyn Welch wrote: > > On 06/07/15 18:24, Dmitry Kalinkin wrote: >>> Some functionality was dropped as it was not good practice >>> >(such as receiving VME interrupts in user space, it's not really doable if >>> >the slave card is Release On Register Access rather th

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

> On 08 Jul 2015, at 16:57, Martyn Welch wrote: > > > > On 07/07/15 11:52, Dmitry Kalinkin wrote: >> The API I had in mind would have only vme_master_read and >> vme_master_write that would take absolute addresses (not relative to >> any window). These variants of access functions would then t

[PATCH] vme: lower alignment requirement in pci bridge drivers

Universe II allows PCI address grannularity of 4K or 64K depending on the window id. tsi148 only supports 64K. Existing driver implementations are validating window size against this grannularity and then use that very size as alignment parameter to pci_bus_alloc_resource. This constraint is exces

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

> On 08 Jul 2015, at 16:41, Martyn Welch wrote: > > On 07/07/15 13:51, Alessio Igor Bogani wrote: >>> Current VME stack links windows not to the boards, but to device drivers. >>> >Driver >>> >could potentially minimise window usage within it’s scope (any sort of >>> >window >>> >reusing, like m

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On 07/07/15 11:52, Dmitry Kalinkin wrote: The API I had in mind would have only vme_master_read and vme_master_write that would take absolute addresses (not relative to any window). These variants of access functions would then try to reuse any window that is already able to serve the request o

Re: [PATCH v2 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()

On Wed, Jul 08 2015, Robert Baldyga wrote: > Since maxpacket_limit was introduced all UDC drivers should use > usb_ep_set_maxpacket_limit() function instead of setting maxpacket value > manually. ep.maxpacket_limit contains actual maximum maxpacket value > supported by hardware which is needed by e

Re: [PATCH v2 5/5] usb: gadget: atmel_usba_udc: add missing ret value check

On Wed, Jul 08 2015, Robert Baldyga wrote: > Add missing return value check. In case of error print debug message > and return error code. > > Signed-off-by: Robert Baldyga > Acked-by: Nicolas Ferre Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 4 > 1 file

Re: Clarification for the use of additional fields in the message body

> Is there truly no way to simplify that process? I see some software development possibilities which could improve the communication with high volume mailing lists. > You should be sending the patches directly with SMTP using git-send-email, This tool is also fine for the publishing of a lot o

Re: [PATCH v2 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit()

On Wed, Jul 08 2015, Robert Baldyga wrote: > Since maxpacket_limit was introduced all UDC drivers should use > usb_ep_set_maxpacket_limit() function instead of setting maxpacket value > manually. ep.maxpacket_limit contains actual maximum maxpacket value > supported by hardware which is needed by e

Re: [PATCH v2 2/5] usb: gadget: midi: avoid redundant f_midi_set_alt() call

On Wed, Jul 08 2015, Robert Baldyga wrote: > Function midi registers two interfaces with single set_alt() function > which means that f_midi_set_alt() is called twice when configuration > is set. That means that endpoint initialization and ep request allocation > is done two times. To avoid this pr

Re: [PATCH v2 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

On Wed, Jul 08 2015, Robert Baldyga wrote: > Function ffs_do_functionfs_bind() calls functionfs_bind() which allocates > usb request and increments refcounts. These things needs to be cleaned > up by if further steps of initialization fail by calling functionfs_unbind(). > > Signed-off-by: Robert B

Re: [PATCH 15/20] staging/lustre/libcfs: get rid of debugfs/lnet/console_backoff

On Jul 8, 2015, at 4:28 AM, Dan Carpenter wrote: > On Mon, Jul 06, 2015 at 12:48:53PM -0400, gr...@linuxhacker.ru wrote: >> +static int param_set_uint_minmax(const char *val, >> + const struct kernel_param *kp, >> + unsigned int min, unsigne

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On 07/07/15 13:51, Alessio Igor Bogani wrote: Current VME stack links windows not to the boards, but to device drivers. >Driver >could potentially minimise window usage within it’s scope (any sort of >window >reusing, like mapping whole A16 once to be used with all boards), but this >won’t >work

[PATCH] staging: lustre: remove dead code

From: Hari Prasath Gujulan Elango This patch removes commented code. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/lustre/lustre/osc/osc_cache.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/osc_cache.c b/drivers/staging/lustre/lus

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On 07/07/15 08:08, Alessio Igor Bogani wrote: I would be glad to try it if the maintainer is willing to receive this type of changes. Such requirements have come up in the past. I'd welcome such support being contributed to the kernel. My view has been that such an API could be built on top o

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On 06/07/15 18:24, Dmitry Kalinkin wrote: Some functionality was dropped as it was not good practice >(such as receiving VME interrupts in user space, it's not really doable if >the slave card is Release On Register Access rather than Release on >Acknowledge), Didn't know about RORA. I wonder

[PATCH] Staging: ozwpan: ozusbsvc1.c: Fix missing blank line after declarations

This patch fixes a missing line after declarations issue. Signed-off-by: Johannes Postma --- drivers/staging/ozwpan/ozusbsvc1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ozwpan/ozusbsvc1.c b/drivers/staging/ozwpan/ozusbsvc1.c index 301fee8..b6cfecb 100644 --- a/drivers

Re: [PATCH v2 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

Hello. On 7/8/2015 12:05 PM, Robert Baldyga wrote: Function ffs_do_functionfs_bind() calls functionfs_bind() which allocates usb request and increments refcounts. These things needs to be cleaned up by if further steps of initialization fail by calling functionfs_unbind(). Signed-off-by: Rob

[PATCH 34/37] usb: musb: gadget: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/musb/musb_gadget.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index 625d482f..043248a 100644 --- a/driver

[PATCH 35/37] usb: renesas: gadget: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/renesas_usbhs/mod_gadget.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index dc2aa32..ed8d890 100

[PATCH 37/37] usb: gadget: epautoconf: add endpoint capabilities flags verification

Introduce endpoint matching mechanism basing on endpoint capabilities flags. We check if endpoint supports transfer type and direction requested in ep descriptor. Since we have this new endpoint matching mechanism there is no need to have old code guessing endpoint capabilities basing on its name,

[PATCH 36/37] usb: gadget: atmel_usba_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/atmel_usba_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 37d414e..2

[PATCH 33/37] usb: isp1760: udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/isp1760/isp1760-udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c index 3699962..1c3d0fd 100644 ---

[PATCH 31/37] usb: gadget: s3c2410_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/s3c2410_udc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c index 5d9aa81..eb3571e 100

[PATCH 32/37] usb: gadget: udc-xilinx: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/udc-xilinx.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c index 1f24274..1cbb0ac 100644 --

[PATCH 30/37] usb: gadget: s3c-hsudc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/s3c-hsudc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/usb/gadget/udc/s3c-hsudc.c b/drivers/usb/gadget/udc/s3c-hsudc.c index 85a712a..e9def42 1006

[PATCH 29/37] usb: gadget: r8a66597-udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/r8a66597-udc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c index 0293f71..baa0609

[PATCH 28/37] usb: gadget: pxa27x_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/pxa27x_udc.h | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.h b/drivers/usb/gadget/udc/px

[PATCH 27/37] usb: gadget: pxa25x_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/pxa25x_udc.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c index f

[PATCH 26/37] usb: gadget: pch_ud: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/pch_udc.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c index 613547f..cc8f

[PATCH 21/37] usb: gadget: mv_u3d_core: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/mv_u3d_core.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c index ea35a24..4c48969 100644

[PATCH 24/37] usb: gadget: net2280: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/net2280.c | 50 ++-- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/ne

[PATCH 25/37] usb: gadget: omap_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/omap_udc.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/omap_udc.c index e2fcdb8..9b7d394

[PATCH 23/37] usb: gadget: net2272: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/net2272.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c index 195baf3..34ec1ec 100644 --- a/dr

[PATCH 19/37] usb: gadget: lpc32xx_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/lpc32xx_udc.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c inde

[PATCH 22/37] usb: gadget: mv_udc_core: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/mv_udc_core.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index d32160d..306a7ff 100644

[PATCH 20/37] usb: gadget: m66592-udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/m66592-udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c index 309706f..e404553 10064

[PATCH 16/37] usb: gadget: fusb300_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/fusb300_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/fusb300_udc.c b/drivers/usb/gadget/udc/fusb300_udc.c index 3970f45..948845c 10

[PATCH 17/37] usb: gadget: goku_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/goku_udc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c index 9e8d842..46b8d14 100644 --- a/dri

[PATCH 18/37] usb: gadget: gr_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/gr_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c index c886887..8aa2593 100644 --- a/drive

[PATCH 15/37] usb: gadget: fsl_udc_core: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/fsl_udc_core.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c index c60022b..aab52

[PATCH 12/37] usb: gadget: dummy-hcd: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/dummy_hcd.c | 65 +- 1 file changed, 50 insertions(+), 15 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc

[PATCH 14/37] usb: gadget: fsl_qe_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/fsl_qe_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c index e0822f1..5fb6f8b 10064

[PATCH 13/37] usb: gadget: fotg210-udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/fotg210-udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c index e547ea7..960c70c 10

[PATCH 11/37] usb: gadget: bdc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/bdc/bdc_ep.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c b/drivers/usb/gadget/udc/bdc/bdc_ep.c index b04980c..f9a8f57 100644 --

[PATCH 10/37] usb: gadget: bcm63xx_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/bcm63xx_udc.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc/bcm63xx_u

[PATCH 09/37] usb: gadget: at91_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/at91_udc.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_ud

[PATCH 08/37] usb: gadget: amd5536udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/udc/amd5536udc.c | 57 ++--- 1 file changed, 47 insertions(+), 10 deletions(-) diff --git a/drivers/usb/gadget/udc/amd5536udc.c b/drivers/usb/gadget/ud

[PATCH 02/37] usb: gadget: add endpoint capabilities flags

Introduce struct usb_ep_caps which contains information about capabilities of usb endpoints - supported transfer types and directions. This structure should be filled by UDC driver for each of its endpoints, and will be used in epautoconf in new ep matching mechanism which will replace ugly guessin

[PATCH 03/37] usb: gadget: add endpoint capabilities helper macros

Add macros useful while initializing array of endpoint capabilities structures. These macros makes structure initialization more compact to decrease number of code lines and increase readability of code. Signed-off-by: Robert Baldyga --- include/linux/usb/gadget.h | 20 1 fi

[PATCH 07/37] usb: dwc3: gadget: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/dwc3/gadget.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 333a7c0..8d1f768 100644 --- a/drivers/usb/dwc3/gadg

[PATCH 06/37] usb: dwc2: gadget: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 4d47b7c..8771b66 100644 --- a/drivers/usb/dwc2/gadg

[PATCH 05/37] usb: chipidea: udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga --- drivers/usb/chipidea/udc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 764f668..eff7cfb 100644 --- a/drivers/usb/chipi

[PATCH 04/37] staging: emxx_udc: add ep capabilities support

Convert endpoint configuration to new capabilities model. Fixed typo in "epc-nulk" to "epc-bulk". Signed-off-by: Robert Baldyga --- drivers/staging/emxx_udc/emxx_udc.c | 60 ++--- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/drivers/staging/emx

[PATCH 00/37] usb: gadget: rework ep matching and claiming mechanism

Hello, This patch series reworks endpoint matching and claiming mechanism in epautoconf. The patch (1) introduces new safer endpoint claiming method, basing on new 'claimed' flag. It was discussed here [1]. I proposed this solution over year ago and it was accepted, but apparently I forgot to sen

[PATCH 01/37] usb: gadget: encapsulate endpoint claiming mechanism

So far it was necessary for usb functions to set ep->driver_data in endpoint obtained from autoconfig to non-null value, to indicate that endpoint is claimed by function (in autoconfig it was checked if endpoint has set this field to non-null value, and if it has, it was assumed that it is claimed)

Re: Clarification for the use of additional fields in the message body

Hi Markus, On Wed, Jul 8, 2015 at 7:28 PM, SF Markus Elfring wrote: >> If it's harmless, then no, but in this case, people are questioning >> why you're adding it as it adds no value > > Some Git software developers care to keep the information complete > for the author commit. > > >> to anyone a

Re: [PATCH] Alternate rtl8192cu driver.

Also it would really help if you could test this on a 32 bit system. If we knew this is 32 vs 64 bit bug that would help. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo

Re: [PATCH] Alternate rtl8192cu driver.

On Wed, Jul 08, 2015 at 12:10:15PM +0200, P. Varet wrote: > On 08/07/15 11:14, Dan Carpenter wrote: > > >This is a useless kind of statement because the bug is so jumbled up. > > I know! Honestly, I did not really understand the question in the > first place, seeing as the bug is still open. I'm

Re: [PATCH] Alternate rtl8192cu driver.

On 08/07/15 11:14, Dan Carpenter wrote: This is a useless kind of statement because the bug is so jumbled up. I know! Honestly, I did not really understand the question in the first place, seeing as the bug is still open. I'm sure you realize that in the absence of a precise question, I can

Re: Clarification for the use of additional fields in the message body

> If it's harmless, then no, but in this case, people are questioning > why you're adding it as it adds no value Some Git software developers care to keep the information complete for the author commit. > to anyone and makes it look like you don't know what you're doing. I specify message field

Re: [PATCH] Alternate rtl8192cu driver.

On Tue, Jul 07, 2015 at 11:37:55PM +0200, P. Varet wrote: > On 07/07/15 11:54, Dan Carpenter wrote: > > >https://bugzilla.kernel.org/show_bug.cgi?id=57171 > > > >This bug is a confusing mix of issues and it seems to be fixed. Just > >use network manager. > > Hi Dan! Thank you for your reply! >

[PATCH v2 5/5] usb: gadget: atmel_usba_udc: add missing ret value check

Add missing return value check. In case of error print debug message and return error code. Signed-off-by: Robert Baldyga Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/atmel_usba_udc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/driver

[PATCH v2 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()

Since maxpacket_limit was introduced all UDC drivers should use usb_ep_set_maxpacket_limit() function instead of setting maxpacket value manually. ep.maxpacket_limit contains actual maximum maxpacket value supported by hardware which is needed by epautoconf. Signed-off-by: Robert Baldyga --- dri

[PATCH v2 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit()

Since maxpacket_limit was introduced all UDC drivers should use usb_ep_set_maxpacket_limit() function instead of setting maxpacket value manually. ep.maxpacket_limit contains actual maximum maxpacket value supported by hardware which is needed by epautoconf. Signed-off-by: Robert Baldyga --- dri

[PATCH v2 2/5] usb: gadget: midi: avoid redundant f_midi_set_alt() call

Function midi registers two interfaces with single set_alt() function which means that f_midi_set_alt() is called twice when configuration is set. That means that endpoint initialization and ep request allocation is done two times. To avoid this problem we do such things only once, for interface nu

[PATCH v2 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

Function ffs_do_functionfs_bind() calls functionfs_bind() which allocates usb request and increments refcounts. These things needs to be cleaned up by if further steps of initialization fail by calling functionfs_unbind(). Signed-off-by: Robert Baldyga --- drivers/usb/gadget/function/f_fs.c | 9

[PATCH v2 0/5] usb: gadget: miscellaneous fixes

Hello, This patch set contains few small bugfixes found in usb gadget functions and UDC drivers. The most important is the [1] as it fixes bug causing BUG_ON() in f_fs driver. Remaining patches contain minor fixes. Best regards, Robert Baldyga Changelog: v2: - Addressed comments from Dan Carpen

Re: [PATCH 18/20] staging/lustre/libcfs: get rid of debugfs/lnet/debug_mb

On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote: > +static int libcfs_param_debug_mb_set(const char *val, > + const struct kernel_param *kp) > +{ > + int rc; > + unsigned num; > + > + rc = kstrtouint(val, 0, &num); > + if (rc ==

Re: staging: wilc1000: One function call less in mac_ioctl() after error detection

>> The kfree() function was called in two cases by the mac_ioctl() function >> during error handling even if the passed variable did not contain a pointer >> for a valid data item. >> >> * This implementation detail could be improved by the introduction >> of another jump label. >> >> * Drop an u

Re: [PATCH 15/20] staging/lustre/libcfs: get rid of debugfs/lnet/console_backoff

Of course, this is not a critical flaw. Don't resend. Fix it later if you want. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 15/20] staging/lustre/libcfs: get rid of debugfs/lnet/console_backoff

On Mon, Jul 06, 2015 at 12:48:53PM -0400, gr...@linuxhacker.ru wrote: > +static int param_set_uint_minmax(const char *val, > + const struct kernel_param *kp, > + unsigned int min, unsigned int max) > +{ > + unsigned int num; > + int

Re: [PATCH 5/5] usb: gadget: atmel_usba_udc: add missing ret value check

Le 07/07/2015 16:02, Robert Baldyga a écrit : > Add missing return value check. In case of error print debug message > and return error code. > > Signed-off-by: Robert Baldyga Yes, it's indeed missing: Acked-by: Nicolas Ferre Thanks, bye. > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 4 +

Re: [PATCH 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

On Tue, Jul 07, 2015 at 06:00:27PM +0200, Robert Baldyga wrote: > Decrement is done in ffs_func_unbind() which is not called in this > error path. Oh. Duh. I got functionfs_unbind() and ffs_func_unbind() mixed up. Sorry. regards, dan carpenter ___ de

Re: [RESEND] mfd: rtsx: add support for rts522A

On Wed, 08 Jul 2015, 敬锐 wrote: > > > On 07/07/2015 07:46 PM, Lee Jones wrote: > > On Mon, 29 Jun 2015, micky_ch...@realsil.com.cn wrote: > > > >> From: Micky Ching > >> > >> rts522a(rts5227s) is derived from rts5227, and mainly same with rts5227. > >> Add it to file mfd/rts5227.c to support thi

Re: Clarification for the use of additional fields in the message body

Hi Markus, On Wed, Jul 8, 2015 at 5:09 PM, SF Markus Elfring wrote: >> There's a file in the documentation directory of the kernel >> tree describing submitting patches and email client setup. >> Read them both, > > I read this information several times. > > >> do what they say without anything e

Re: Clarification for the use of additional fields in the message body

> There's a file in the documentation directory of the kernel > tree describing submitting patches and email client setup. > Read them both, I read this information several times. > do what they say without anything extra. Do you see any special consequences if a bit of "extra" functionality is