On Mon, Jul 06, 2015 at 12:48:53PM -0400, gr...@linuxhacker.ru wrote:
> +static int param_set_uint_minmax(const char *val,
> +                              const struct kernel_param *kp,
> +                              unsigned int min, unsigned int max)
> +{
> +     unsigned int num;
> +     int ret;
> +
> +     if (!val)
> +             return -EINVAL;
> +     ret = kstrtouint(val, 0, &num);
> +     if (ret == -EINVAL || num < min || num > max)
                              ^^^
Smatch is smart enough to know that "num" can be uninitialized here on
some paths.  It doesn't generate a warning yet because a lot of the
kernel has error paths where we mostly assume things won't fail.

It should probably be:

        ret = kstrtouint(val, 0, &num);
        if (ret)
                return ret;
        if (num < min || num > max)
                return -EINVAL;

> +             return -EINVAL;
> +     *((unsigned int *)kp->arg) = num;
> +     return 0;
> +}

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to