Modify i2c-parport driver to use the new parallel port device model.
Tested-by: Jean Delvare
Acked-by: Wolfram Sang
Signed-off-by: Sudip Mukherjee
---
v2: Changed to one space instead of tab in i2c_parport_driver.
i2c_parport_cb is made local, devmodel added to driver structure,
and probe rem
On Thu, May 21, 2015 at 07:51:18AM +0200, Willy Tarreau wrote:
> On Wed, May 20, 2015 at 05:46:44PM +0200, Richard Weinberger wrote:
> > On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
> > wrote:
> > > Lets give the parport subsystem a proper name and start
> > > maintaining the files.
> >
> > E
On Wed, May 20, 2015 at 10:36:04PM +0200, Richard Weinberger wrote:
> Am 20.05.2015 um 18:33 schrieb One Thousand Gnomes:
> > On Wed, 20 May 2015 17:46:44 +0200
> > Richard Weinberger wrote:
> >
> >> On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
> >> wrote:
> >>> Lets give the parport subsyst
On Wed, May 20, 2015 at 05:46:44PM +0200, Richard Weinberger wrote:
> On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
> wrote:
> > Lets give the parport subsystem a proper name and start
> > maintaining the files.
>
> Excuse me, but usually someone takes over the maintainer role after
> proving
On Wed, May 20, 2015 at 06:02:06PM -0700, Joe Perches wrote:
> Perhaps space aligned declarations should have some
> checkpatch --strict warning for 2 or more spaces
> around any assignment of the declaration.
>
> int a = 1;// 2+ spaces before =
> int b = 2;
On Wed, 2015-05-20 at 19:59 +0200, Jean Delvare wrote:
> On Wed, 20 May 2015 22:44:52 +0530, Sudip Mukherjee wrote:
> > On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote:
> > > On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
> > > > static struct parport_driver i2c_parp
On 2015/05/20, 1:42 PM, "Dan Carpenter" wrote:
>In Smatch, it the equivalent warning is turned off by default because
>there are too many false positives, but you can enable it with the
>--spammy flag.
>
>kchecker --spammy drivers/staging/lustre/lustre/ptlrpc/nrs.c
>
>drivers/staging/lustre/lustr
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Wednesday, May 20, 2015 9:46 AM
> To: de...@linuxdriverproject.org
> Cc: KY Srinivasan; Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui;
> Ingo Molnar; H. Peter Anvin; Thomas Gleixner; x...@kernel.o
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Tuesday, May 19, 2015 5:16 AM
> To: de...@linuxdriverproject.org
> Cc: KY Srinivasan; Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui;
> Ingo Molnar; Paul E. McKenney; Rafael J. Wysocki; Peter Zijls
Simplify prism2_wep_init error check code employing goto when a failure is
detected.
Removed pr_debug which was given a checkpatch.pl error because of literal string
splitted across two lines of code, it was seldom going to be printed anyway.
Signed-off-by: Pedro Marzo Perez
---
.../rtl8192u/i
Opening braces should never be in a new line.
Correct include indentation.
Signed-off-by: Pedro Marzo Perez
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt
The checkpatch.pl script reports several errors at file ieee80211_crypt_wep.c,
this patch fixes them.
Pedro Marzo Perez (3):
Simplify error check code at prism2_wep_init
Remove two useless lines at ieee80211_wep_null
Correct include indentation and openning braces at new line
.../rtl8192u/
Remove two lines at ieee80211_wep_null which checkpatch.pl reported as errors.
The first one because it has a C99 comment style and the second one because it
is a void
return which is useless.
Signed-off-by: Pedro Marzo Perez
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 2 --
Am 20.05.2015 um 18:33 schrieb One Thousand Gnomes:
> On Wed, 20 May 2015 17:46:44 +0200
> Richard Weinberger wrote:
>
>> On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
>> wrote:
>>> Lets give the parport subsystem a proper name and start
>>> maintaining the files.
>>
>> Excuse me, but usually
On 05/20/2015 02:46 PM, Jagan Teki wrote:
On 21 May 2015 at 01:10, Larry Finger wrote:
On 05/20/2015 01:41 PM, Jagan Teki wrote:
On 18 May 2015 at 22:02, Jagan Teki wrote:
Fixes Warning encounter this by applying checkpatch.pl against this file:
Prefer ether_addr_copy() over memcpy() if th
On 21 May 2015 at 01:10, Larry Finger wrote:
> On 05/20/2015 01:41 PM, Jagan Teki wrote:
>>
>> On 18 May 2015 at 22:02, Jagan Teki wrote:
>>>
>>> Fixes Warning encounter this by applying checkpatch.pl against this file:
>>> Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
>>> are
In Smatch, it the equivalent warning is turned off by default because
there are too many false positives, but you can enable it with the
--spammy flag.
kchecker --spammy drivers/staging/lustre/lustre/ptlrpc/nrs.c
drivers/staging/lustre/lustre/ptlrpc/nrs.c:512 nrs_resource_put_safe()
warn: 'spin_l
On 05/20/2015 01:41 PM, Jagan Teki wrote:
On 18 May 2015 at 22:02, Jagan Teki wrote:
Fixes Warning encounter this by applying checkpatch.pl against this file:
Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
are __aligned(2)
pahole output for respective structures:
- addr->sa_d
On Thu, May 21, 2015 at 12:11:46AM +0530, Jagan Teki wrote:
> Ping!
No answer means that Greg hasn't gotten to it yet and no one else has
an issue with it. Wait for 2 weeks before asking or 4 weeks if a merge
window is open.
regards,
dan carpenter
___
On Wed, May 20, 2015 at 04:51:59PM +, Dilger, Andreas wrote:
> On 2015/05/18, 3:21 PM, "Dan Carpenter" wrote:
>
> >On Mon, May 18, 2015 at 08:34:51PM +0200, Adrian Remonda wrote:
> >> Fixed sparse warning: context imbalance in 'nrs_resource_put_safe' -
> >> 'different lock contexts for basic
On Thu, May 21, 2015 at 12:12:38AM +0530, Jagan Teki wrote:
> On 18 May 2015 at 22:34, Jagan Teki wrote:
> > This patch fixes line over 80 characters warninings while
> > running checkpatch.pl - "WARNING: line over 80 characters"
> >
> > Signed-off-by: Jagan Teki
> > Cc: Greg Kroah-Hartman
> > C
On 18 May 2015 at 22:34, Jagan Teki wrote:
> This patch fixes line over 80 characters warninings while
> running checkpatch.pl - "WARNING: line over 80 characters"
>
> Signed-off-by: Jagan Teki
> Cc: Greg Kroah-Hartman
> Cc: Larry Finger
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 52
>
On 18 May 2015 at 22:02, Jagan Teki wrote:
> Fixes Warning encounter this by applying checkpatch.pl against this file:
> Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
> are __aligned(2)
>
> pahole output for respective structures:
> - addr->sa_data
> struct sockaddr {
>
On Wed, 20 May 2015 22:44:52 +0530, Sudip Mukherjee wrote:
> On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote:
> > On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
> > > static struct parport_driver i2c_parport_driver = {
> > > - .name = "i2c-parport",
> > > - .attach
> > > static struct parport_driver i2c_parport_driver = {
> > > - .name = "i2c-parport",
> > > - .attach = i2c_parport_attach,
> > > - .detach = i2c_parport_detach,
> > > + .name = "i2c-parport",
> > > + .match_port = i2c_parport_attach,
> > > + .detach = i2c_parport_detac
On Wed, May 20, 2015 at 09:28:16AM -0700, Joe Perches wrote:
> On Wed, 2015-05-20 at 17:46 +0200, Richard Weinberger wrote:
> > On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
> > wrote:
> > > Lets give the parport subsystem a proper name and start
> > > maintaining the files.
> >
> > Excuse me,
On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote:
> On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
> > Modify i2c-parport driver to use the new parallel port device model.
> >
> > Tested-by: Jean Delvare
> > Signed-off-by: Sudip Mukherjee
> > ---
>
> In general:
>
On 2015/05/18, 3:21 PM, "Dan Carpenter" wrote:
>On Mon, May 18, 2015 at 08:34:51PM +0200, Adrian Remonda wrote:
>> Fixed sparse warning: context imbalance in 'nrs_resource_put_safe' -
>> 'different lock contexts for basic block' by releasing the lock on each
>> iteration of the for loop.
>>
>
>T
When general-purpose kexec (not kdump) is being performed in Hyper-V guest
the newly booted kernel fails with an MCE error coming from the host. It
is the same error which was fixed in the "Drivers: hv: vmbus: Implement
the protocol for tearing down vmbus state" commit - monitor pages remain
specia
At the very late stage of kexec a driver (which are not being unloaded) can
try to post a message or signal an event. This will crash the kernel as we
already did hv_cleanup() and the hypercall page is NULL.
Move all common (between 32 and 64 bit code) declarations to the beginning
of the do_hyper
We already have hv_synic_free() which frees all per-cpu pages for all
CPUs, let's remove the hv_synic_free_cpu() call from hv_synic_cleanup()
so it will be possible to do separate cleanup (writing to MSRs) and final
freeing. This is going to be used to assist kexec.
Signed-off-by: Vitaly Kuznetsov
To make general-purpose kexec (not just kdump) possible for Hyper-V guests
we need to perform some additional cleanup before starting new kernel (see
[PATCH 2/3] for the detailed description).
Know limitations: kexec with balloned out memory is not possible as the
newly loaded kernel doesn't know
On Wed, 20 May 2015 17:46:44 +0200
Richard Weinberger wrote:
> On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
> wrote:
> > Lets give the parport subsystem a proper name and start
> > maintaining the files.
>
> Excuse me, but usually someone takes over the maintainer role after
> proving that
On Wed, 2015-05-20 at 17:46 +0200, Richard Weinberger wrote:
> On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
> wrote:
> > Lets give the parport subsystem a proper name and start
> > maintaining the files.
>
> Excuse me, but usually someone takes over the maintainer role after
> proving that he
On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
> Modify i2c-parport driver to use the new parallel port device model.
>
> Tested-by: Jean Delvare
> Signed-off-by: Sudip Mukherjee
> ---
In general:
Acked-by: Wolfram Sang
> static struct parport_driver i2c_parport_driver = {
On Wed, May 20, 2015 at 08:56:59PM +0530, Sudip Mukherjee wrote:
> As of now i2c-parport was connecting to all the available parallel
> ports. Lets limit that to maximum of 4 instances and at the same time
> define which instance connects to which parallel port.
>
> Tested-by: Jean Delvare
> Sign
On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
wrote:
> Lets give the parport subsystem a proper name and start
> maintaining the files.
Excuse me, but usually someone takes over the maintainer role after
proving that he
cares for a sub system for a certain period of time.
Or did I miss somethi
Modify paride driver to use the new parallel port device model.
Tested-by: Alan Cox
Signed-off-by: Sudip Mukherjee
---
One change after testing by Alan, par_cb is made a local variable
instead of a global one.
drivers/block/paride/paride.c | 57 ++-
dri
Lets give the parport subsystem a proper name and start
maintaining the files.
Signed-off-by: Sudip Mukherjee
---
MAINTAINERS | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 86d9398..0eb5ce2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@
Modify i2c-parport driver to use the new parallel port device model.
Tested-by: Jean Delvare
Signed-off-by: Sudip Mukherjee
---
i2c_parport_cb is made local, devmodel added to driver structure,
and probe removed.
drivers/i2c/busses/i2c-parport.c | 15 ++-
1 file chang
After 5 versions of WIP, finally a patch submission.
parport subsystem is now in the transition stage and supports the old
model and the new device model. 3 of the drivers have been converted
into new model and tested.
After other drivers are converted we can remove the old code from
parport.
Sudi
As of now i2c-parport was connecting to all the available parallel
ports. Lets limit that to maximum of 4 instances and at the same time
define which instance connects to which parallel port.
Tested-by: Jean Delvare
Signed-off-by: Sudip Mukherjee
---
MODULE_PARM_DESC modified
drivers/i2c/buss
Converted to use the new device-model parallel port.
Signed-off-by: Sudip Mukherjee
---
The comment about panel_cb.flags can be removed, it is kept just
for the comment to remind us that it might be better to use
PARPORT_DEV_EXCL.
drivers/staging/panel/panel.c | 14 +-
1 file chang
parport subsystem starts using the device-model. Drivers using the
device-model has to define devmodel as true and should register the
device with parport using parport_register_dev_model().
Tested-by: Jean Delvare
Tested-by: Alan Cox
Signed-off-by: Sudip Mukherjee
---
patch: renaming of cnt
On Mon, May 18, 2015 at 12:37:09PM +0100, Ian Abbott wrote:
> On 16/05/15 05:16, Geliang Tang wrote:
> >1) Fixed an error found by checkpatch.pl.
> >ERROR: space required after that ',' (ctx:VxV)
> >./drivers/ni_mio_common.c:3764
> >2) Changed "register 0x%x" to "register=0x%x" to keep the
This patch fixes most of the lines over 80 characters long in
dgnc_sysfs.c. I couldn't find a way to break line 202-207 in a sensible
way. If there is a way, let me know.
Signed-off-by: Wim de With
---
drivers/staging/dgnc/dgnc_sysfs.c | 110 +-
1 file changed
On Wed, May 20, 2015 at 10:00:45AM +0100, Ian Abbott wrote:
> On 20/05/15 09:22, Sudip Mukherjee wrote:
> >On Wed, May 20, 2015 at 09:24:18AM +0200, Amaury Denoyelle wrote:
> >>Sudip Mukherjee wrote:
> >>
> >>>On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
> >>>
> >yes, i notice
On Wed, May 20, 2015 at 10:26:30AM +0200, pmarzo wrote:
> On mié, 2015-05-20 at 00:46 +0300, Dan Carpenter wrote:
> > I was planning to leave this one for Greg but since you asked me to
> > comment...
> >
> > This patch is ok as one patch. The subject is "clean up
> > prism2_wep_init()" and that'
On 20/05/15 09:22, Sudip Mukherjee wrote:
On Wed, May 20, 2015 at 09:24:18AM +0200, Amaury Denoyelle wrote:
Sudip Mukherjee wrote:
On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
@@ -1381,7 +1382,9 @@ static int set_ai_fifo_segment_length(struct
comedi_device *dev,
On 19/05/15 18:57, Amaury Denoyelle wrote:
This patch reformat multi-line comments which are not properly written
according to the kernel coding style in cb_pcidas64.c
Signed-off-by: Amaury Denoyelle
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 140 ++-
1 file c
On 19/05/15 18:57, Amaury Denoyelle wrote:
This patch fixes coding style errors reported by checkpatch.pl for
cb_pcidas64.c, about too long source code lines.
Signed-off-by: Amaury Denoyelle
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 14 ++
1 file changed, 10 insertions(+
On mié, 2015-05-20 at 00:46 +0300, Dan Carpenter wrote:
> I was planning to leave this one for Greg but since you asked me to
> comment...
>
> This patch is ok as one patch. The subject is "clean up
> prism2_wep_init()" and that's one thing. Breaking it up into tiny
> patches would probably make
On Wed, May 20, 2015 at 09:24:18AM +0200, Amaury Denoyelle wrote:
> Sudip Mukherjee wrote:
>
> > On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
> >
> > > @@ -1381,7 +1382,9 @@ static int set_ai_fifo_segment_length(struct
> > > comedi_device *dev,
> > > return devpriv->ai_fi
Thanks!
But rather than that, this whole function (lprocfs_exp_setup) needs to go,
since it's not used by anything on the client.
The removal is sitting in my queue of "stop using procfs in lustre" patches
that I am going to submit real soon now and this patch would just create
an unnecessary con
Sudip Mukherjee wrote:
> On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
>
> > @@ -1381,7 +1382,9 @@ static int set_ai_fifo_segment_length(struct
> > comedi_device *dev,
> > return devpriv->ai_fifo_segment_length;
> > }
> >
> > -/* adjusts the size of hardware fifo (whi
This patch was generated by coccicheck and replaces kzalloc followed
by memcpy with kmemdup
Signed-off-by: Nitesh Dumbre
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index 57c6ddd..c988be4 100644
--- a/drivers/sta
56 matches
Mail list logo
