On Mon, May 18, 2015 at 12:37:09PM +0100, Ian Abbott wrote:
> On 16/05/15 05:16, Geliang Tang wrote:
> >1) Fixed an error found by checkpatch.pl.
> > ERROR: space required after that ',' (ctx:VxV)
> > ./drivers/ni_mio_common.c:3764
> >2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
> > of this file.
> >3) The kernel version is next-20150515, 4.1.0-rc3.
>
> You shouldn't mention point 3 in the commit message as it will look a bit
> strange when it ends up in the commit log. If you need to mention that, it
> should go after the commit message, separated from the patch by a "---" line
> like this:
>
> Body of commit message goes here.
>
> Signed off by and Cc lines go here.
> ---
> Additional patch commentary goes here.
> ---
> Actual patch goes here.
>
> Git will ignore the additional commentary when the patch is applied.
>
> >
> >Signed-off-by: Geliang Tang <geliangt...@163.com>
> >---
> > drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c
> >b/drivers/staging/comedi/drivers/ni_mio_common.c
> >index 9dfd4e6..6cc304a 100644
> >--- a/drivers/staging/comedi/drivers/ni_mio_common.c
> >+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> >@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct
> >comedi_device *dev,
> > if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
> > regmap = &ni_gpct_to_stc_regmap[reg];
> > } else {
> >- dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
> >+ dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
> > __func__, reg);
> > return 0;
> > }
> >
>
> Apart from that niggle, the patch looks good!
>
> Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
>
> --
> -=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=-
> -=( Web: http://www.mev.co.uk/ )=-
Thank you for your review. I revised the patch as you suggested.
Here it is.
>From d864f6af18a44031a241e10e64d98f9e6b8c0660 Mon Sep 17 00:00:00 2001
From: Geliang Tang <geliangt...@163.com>
Date: Wed, 20 May 2015 14:26:13 +0000
Subject: [PATCH v2] staging: comedi: fix coding style issues
1) Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764
2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
of this file.
Signed-off-by: Geliang Tang <geliangt...@163.com>
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
---
Changes in v2:
- remove the kernel version in the commit message.
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c
b/drivers/staging/comedi/drivers/ni_mio_common.c
index 9dfd4e6..6cc304a 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct
comedi_device *dev,
if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
regmap = &ni_gpct_to_stc_regmap[reg];
} else {
- dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
+ dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
__func__, reg);
return 0;
}
--
2.3.4
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
