Current code does not lock anything when calculating the TX and RX stats.
As a result, the RX and TX data reported by ifconfig are not accuracy in a
system with high network throughput and multiple CPUs (in my test,
RX/TX = 83% between 2 HyperV VM nodes which have 8 vCPUs and 40G Ethernet).
This p
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, May 13, 2015 9:52 PM
> To: Simon Xiao
> Cc: KY Srinivasan; Haiyang Zhang; de...@linuxdriverproject.org;
> net...@vger.kernel.org; linux-ker...@vger.kernel.org
> Subject: Re: [PATCH net-next,1/1] hv_n
From: six...@microsoft.com
Date: Tue, 12 May 2015 15:50:02 -0700
> From: Simon Xiao
>
> Current code does not lock anything when calculating the TX and RX stats.
> As a result, the RX and TX data reported by ifconfig are not accuracy in a
> system with high network throughput and multiple CPUs (
Fixed a few spelling errors in comments.
Signed-off-by: Colin Cronin
---
drivers/staging/skein/skein_api.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/skein/skein_api.h
b/drivers/staging/skein/skein_api.h
index 171b875..7da8b38 100644
--- a/drivers/
Fixed a spelling error in a comment.
Signed-off-by: Colin Cronin
---
drivers/staging/comedi/comedi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 7455740..66edda1 100644
--- a/drivers/staging/comedi/co
On 13/05/15 05:36, Dan Carpenter wrote:
> How come you didn't use my patch as a base to work from, you shouldn't
> be passing tkip_ctx at all.
Hi Dan, my mistake. To be honest I assumed that the idea was not to
touch tkip.c at all, that's why I had to pass tkip_ctx... sorry about
that :-(
Coming b
On Wed, May 13, 2015 at 05:01:40PM -0700, colincronin wrote:
> Fixed a spelling error in a comment.
>
> Signed-off-by: Colin Cronin
This name doesn't match the "From:" line in your email header, please
fix it up to match properly.
thanks,
greg k-h
__
On Wed, May 13, 2015 at 05:03:04PM -0700, colincronin wrote:
> Fixed a few spelling errors in comments.
>
> Signed-off-by: Colin Cronin
> ---
> drivers/staging/skein/skein_api.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Same problem with the From: line.
Can you fix your ema
Fixed a few spelling errors in comments.
Signed-off-by: Colin Cronin
---
drivers/staging/skein/skein_api.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/skein/skein_api.h
b/drivers/staging/skein/skein_api.h
index 171b875..7da8b38 100644
--- a/drivers/
Fixed a spelling error in a comment.
Signed-off-by: Colin Cronin
---
drivers/staging/comedi/comedi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 7455740..66edda1 100644
--- a/drivers/staging/comedi/co
On Wed, May 13, 2015 at 02:26:25PM -0700, colincronin wrote:
> Fixed spelling error in comment
>
> Signed-off-by: Colin Cronin
> ---
> drivers/staging/comedi/comedi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Where are patches 001-301 in this series?
I think you need to fix up yo
On Wed, May 13, 2015 at 02:08:00PM -0700, colincronin wrote:
> Fixed some spelling issues.
>
> Signed-off-by: Colin Cronin
> ---
> drivers/staging/comedi/drivers/8255_pci.c | 2 +-
> drivers/staging/comedi/drivers/addi_apci_1500.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-
On Wed, May 13, 2015 at 02:58:23PM -0700, colincronin wrote:
> Fixed spelling issues and corrected references.
>
> Signed-off-by: Colin Cronin
> ---
> drivers/staging/i2o/i2o_proc.c | 72
> +-
> 1 file changed, 36 insertions(+), 36 deletions(-)
This file
On Wed, 13 May 2015 14:58:13 -0700
colincronin wrote:
> Fixed a spelling error in comments.
>
> Signed-off-by: Colin Cronin
> ---
> drivers/staging/i2o/i2o_scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
i2o is going away - please just drop the i2o ones from your patching.
Ala
Several functions in this driver return a boolean: _SUCCESS = 1 on success,
_FAIL = 0 on error, defined in
drivers/staging/rtl8188eu/include/osdep_service.h.
The common practice in the Linux kernel is to return 0 on success, a negative
error code otherwise. This has the advantage that the return v
"step 2" does mean much as there is no "step 1" stated anywhere...
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/os_dep/os_intfs
Even though these are not reported by checkpatch, they are coding style issues.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/o
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
dif
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/
Also remove them from .h files.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/include/osdep_intf.h | 2 --
drivers/staging/rtl8188eu/include/recv_osdep.h | 3 ---
drivers/staging/rtl8188eu/os_dep/os_intfs.c| 15 +--
3 files
Fixes checkpatch warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c
b/drivers/staging/rtl8712/os_intfs.c
index fd78d22..27a875b 100644
--- a/dri
"step 2" does mean much as there is no "step 1" stated anywhere...
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c
b/driver
Fixed spelling issues and corrected references.
Signed-off-by: Colin Cronin
---
drivers/staging/i2o/i2o_proc.c | 72 +-
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/i2o/i2o_proc.c b/drivers/staging/i2o/i2o_proc.c
index ad
Fixed a spelling error in comments.
Signed-off-by: Colin Cronin
---
drivers/staging/i2o/i2o_scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/i2o/i2o_scsi.c b/drivers/staging/i2o/i2o_scsi.c
index 1b11dcb..5ff36c4 100644
--- a/drivers/staging/i2o/i2o_scsi.
Fixed spelling error in comment
Signed-off-by: Colin Cronin
---
drivers/staging/comedi/comedi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 7455740..66edda1 100644
--- a/drivers/staging/comedi/comedi.
Fixed some spelling issues.
Signed-off-by: Colin Cronin
---
drivers/staging/comedi/drivers/8255_pci.c | 2 +-
drivers/staging/comedi/drivers/addi_apci_1500.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8255_pci.c
b/drivers/stagin
A network supplied parameter was not checked before division, leading to
a divide-by-zero. Since this happens in the softirq path, it leads to a
crash. A PoC follows below, which requires the ozprotocol.h file from
this module.
=-=-=-=-=-=
#include
#include
#include
#include
#include
#
The ozwpan driver accepts network packets, parses them, and converts
them into various USB functionality. There are numerous security
vulnerabilities in the handling of these packets. Two of them result in
a memcpy(kernel_buffer, network_packet, -length), one of them is a
divide-by-zero, and one of
Using signed integers, the subtraction between required_size and offset
could wind up being negative, resulting in a memcpy into a heap buffer
with a negative length, resulting in huge amounts of network-supplied
data being copied into the heap, which could potentially lead to remote
code execution
Since elt->length is a u8, we can make this variable a u8. Then we can
do proper bounds checking more easily. Without this, a potentially
negative value is passed to the memcpy inside oz_hcd_get_desc_cnf,
resulting in a remotely exploitable heap overflow with network
supplied data.
This could resu
The subtraction here was using a signed integer and did not have any
bounds checking at all. This commit adds proper bounds checking, made
easy by use of an unsigned integer. This way, a single packet won't be
able to remotely trigger a massive loop, locking up the system for a
considerable amount
From: Don Zickus
The bus device and regular device were using two different
structs. Let's combine them as they are not entirely different
from one another.
This allows us to move this creation up the stack later and
actually remove bus/dev_info easily.
Most of the churn is just renaming devda
From: Don Zickus
I used 0 as the device id for the bus root, neglecting the fact that
device 0 is a valid id in Unisys's configuration. Modify this to
use UINT_MAX instead as a unique number.
As fallout from this change it was noticed the bus_no and dev_no was not
defined the same way consisten
From: Don Zickus
Most bus functions pass bus_no around and then do a lookup inside each
function to find the bus_info struct. Instead just pass the pointer.
This prepares us for a later conversion to using visor_device.
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/sta
From: Don Zickus
This patch removes the legacy bus_info struct and instead creates
and passes around a traditional struct device.
This allows us to remove a lot of the various look up code and
removes the doubt if the struct exists or not.
Half of the churn is just the conversion of visorchipse
From: Don Zickus
Instead of creating a channel struct to temporarily hold the channel
info and passing it through multiple functions until the device is
created, just create the channel from the start.
This allows us to remove the channel_info struct.
I noticed 'chan_info.addr_type' was not bei
From: Don Zickus
The bus driver doesn't work in server mode, just remove the left over
pieces.
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c| 66 +++---
drivers/staging/unisys/visorbus/visorbus_private.h | 5 --
From: Don Zickus
Removing stuff that isn't being used. Another prepartion patch to
allow us to use visor_device everywhere without the baggage of
bus/dev_info.
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c| 72
From: Don Zickus
Most device functions pass bus_no and dev_no around and then do a lookup
inside each function to find the dev_info struct. Instead just pass the
pointer.
This prepares us for a later conversion to using visor device.
No real technical changes. Just function header changes and
From: David Kershner
Diagchannel needs to go to standard include.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
.../common-spar/include/channels/diagchannel.h | 427 -
drivers/staging/unisys/include/diagchannel.h | 427 +
2 f
From: David Kershner
Give the enum the correct values instead of based on other values.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/diagchannel.h | 34
1 file changed, 10 insertions(+), 24 deletions(-)
diff --git
From: David Kershner
remove uisqueue.h, uisthread.h, and uisutils.h
replace HOSTADDRESS with u64
remove "uisutils.h" from header list in visorchipset.c
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/uisqueue.h | 396
From: David Kershner
Channel.h is used by all channels, it needs to be in include.
Controlvm Channel is only used by visorbus, it needs to just be there.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
.../unisys/common-spar/include/channels/channel.h | 590 --
From: Don Zickus
This patch removes the legacy dev_info struct and instead creates
and passes around a traditional struct device.
This allows us to remove a lot of the various look up code and
removes the doubt if the struct exists or not.
Half of the churn is just the conversion of visorchipse
From: Don Zickus
Convert the device attribute files to properly use visor_device.
This removes a whole bunch of checks and assumptions and simplifies
the code. Everything is straightforward.
No testing down as I can't mimic channel info correctl.
Signed-off-by: Don Zickus
Signed-off-by: Benja
From: Don Zickus
In order to remove bus_info, we need to migrate vbus_hdr_info into
the public namespace of visor_device. Because the struct is private,
we use a void * to hide the contents.
As a result, we need to allocate vbus_hdr_info and manage it.
Also work around vbus_valid, as that vari
From: Don Zickus
The visorbus driver has three _info structs lying around
(device, bus, channel) that store subsets of info from the
bigger structs.
Having these structs around make resource handling very difficult
and more complicated than it needs to be. Use the device
infrastructure and inst
From: Don Zickus
In order for bus/dev_info structs to become public structs, one
element, pending_msg_hdr, needs to become opaque. This is to keep
all the internals of the controlvm struct private to the bus layer.
So a simple conversion of embedding the pending_msg_hdr struct into
a pointer is
From: David Kershner
Move vbuschannel.h into visorbus.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
.../common-spar/include/channels/vbuschannel.h | 94 --
drivers/staging/unisys/visorbus/vbuschannel.h | 94 ++
2 files change
From: David Kershner
Move last three files out of common-spar
iochannel.h --> include (will be used by visorhba and visornic)
version.h --> moved to include
controlvmcompletionstatus.h --> moved to visorbus, part of
controlvmchannel.h
Signed-off-by: David Kershner
Signed-off-by
From: David Kershner
Diagchannel.h is used primarily for the diagnostics channel. The
diagnostics channel is not being used by linux guests currently, so
the majority of the file is not needed. What is left is what is
needed to perform postcode vmcalls. Those postcodes will eventually
end up in t
From: Don Zickus
If we are going to remove the bus_info structs than we need a way
to find the devices when the *_create/destroy cmds are sent over
the vmchannel.
This function crudely impements what pci has. It takes a bus_no
and dev_no and finds the matching 'struct visor_device'.
This funct
From: Don Zickus
Now that the header file movement is complete, remove the temporary ccflags
include
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/Makefile
From: Jes Sorensen
min_size/max_size aren't used anywhere, and they were just causing
headaches in the drivers being ported over to the new interfaces.
Signed-off-by: Jes Sorensen
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-
From: Don Zickus
There was a bunch of channel creation checks before the
visorchannel_create function was called, moving some of those
checks inside. This keeps the outside code cleaner and handles
the situation where a caller forgets to make these checks.
Signed-off-by: Don Zickus
Signed-off-
From: David Kershner
Get rid of unused values in the enum.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/diagchannel.h | 32 +++-
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/unisys/inc
From: Don Zickus
Properly hook into the struct device groups element. This allows the
core infrastructure to manage the files instead of the bus layer. And
makes the code easier to read.
I didn't clean up the _show functions just modified them a bit to handle
the different args for now and to
From: Don Zickus
Handling the sysfs attributes become easier to deal with when you can just
run container_of(dev) to get devdata.
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 28 -
1 file changed, 9 inser
From: Don Zickus
This patch is an attempt to help hide the channel info behind
accessory functions. I was trying to keep visorchannel as private
as possible.
The only function missing that seemed to be needed for now was
the ability to set the clientpartition. So I expose that here.
Signed-of
From: David Kershner
Makefiles still had common-spar listed in ccflags.
This gets rid of them.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/Makefile | 2 --
drivers/staging/unisys/visorchannel/Makefile | 2 --
2 files changed, 4 deletion
From: David Kershner
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/sparstop.h | 29 -
1 file changed, 29 deletions(-)
delete mode 100644 drivers/staging/unisys/include/sparstop.h
diff --git a/drivers/staging/unisys/
From: David Kershner
Move hypervisor calls into visorbus and move vbusdeviceinfo.h into
visorbus.
Drivers will call into that to update clientInfo field.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
.../unisys/common-spar/include/iovmcall_gnuc.h | 49 -
.../unisys/
From: Don Zickus
Remove stale code.
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 32 -
1 file changed, 32 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unis
From: Don Zickus
This patch moves the attributes to underneath the bus device correctly.
This will help remove a bunch of cruft from the code and let the kernel
infrastructure manage the sysfs files instead of the driver.
After the move remove all the leftover code.
Signed-off-by: Don Zickus
S
From: David Kershner
Get rid of common-spar/include/diagnostics/appos_subsystems.h.
No one is using it.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
.../include/diagnostics/appos_subsystems.h | 310 -
drivers/staging/unisys/include/uisutils.h
From: Don Zickus
The conversion to visor_device caused some compile issues.The main
problem was the new fields in 'struct visor_device' were not public.
Remove one that wasn't being used for now.
struct irq_info intr
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/staging
From: Don Zickus
To prep for the moving of include files, temporarily add the
visorbus/ as a ccflags -I. Once the header files are all
transitioned, we can remove this.
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/Makefile | 1 +
1 file changed,
From: Don Zickus
Simplify things by moving the version file handling into the core.
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 66 +++--
1 file changed, 30 insertions(+), 36 deletions(-)
diff --git a/drive
From: Don Zickus
Mimicing what other drivers do, this seems appropriate. Yeah, it
is a bus, but it is a bus _device_. This makes things work better
and smoother. Now the sysfs looks like
[root@dhcp-17-174 visorbus]# ls -l /sys/bus/visorbus/devices/
total 0
lrwxrwxrwx. 1 root root 0 Apr 17 16:
From: David Kershner
Controlframework was only needed by controlvmchannel, move the
structures into that header file.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
.../include/channels/controlframework.h| 62 --
.../include/channels/controlvmc
From: Jes Sorensen
This preps for the possible build breakage in the next few
patches.
Signed-off-by: Jes Sorensen
[updated changelog to reflect new patch order; instead
of 'fixes' the patch 'prevents' - dcz]
Signed-off-by: Don Zickus
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/
From: Jes Sorensen
Signed-off-by: Jes Sorensen
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchipset.
From: Jes Sorensen
Signed-off-by: Jes Sorensen
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 40 +++---
1 file changed, 17 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/uni
From: Jes Sorensen
Signed-off-by: Jes Sorensen
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchipset
From: Jes Sorensen
Signed-off-by: Jes Sorensen
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 56 --
1 file changed, 56 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visor
This patch series continues the redesign and cleanup of the Unisys s-Par
driver set, continuing work on the visorbus driver and consolidation of other
drivers' code into the visorbus driver to reduce complexity. The patches were
cleaned up so there should be no warnings or errors generated at all d
On Wed, May 13, 2015 at 02:35:25PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> check return value of kmalloc before accessing the memory pointer and
> return -ENOMEM if allocation fails.
>
Looks good. Thanks!
regards,
dan carpenter
___
devel m
On Wed, May 13, 2015 at 05:27:10PM +0300, Dan Carpenter wrote:
> On Wed, May 13, 2015 at 01:36:44PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote:
> > > On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote:
> > > > On W
check return value of kmalloc before accessing the memory pointer and
return -ENOMEM if allocation fails.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Return -ENOMEM for memory allocation failure.
---
drivers/staging/wlan-ng/p80211conv.c | 2 ++
1 file changed, 2 insertions(+)
diff
Nestle (Malaysia) Berhad
22-1, 22nd floor, Menara Surian
No. 1, Jalan PJU 7/3
Mutiara Damansara 47810
Petaling Jaya
Selangor, Malaysia.
HADIAH BONUS KHAS TAHUN BARU.
Kami berasa sukacita untuk memaklumkan kepada anda nantikan siaran keputusan
Hadiah Bonus Nestl? (Malaysia) Berhad khas yang diad
On Wed, May 13, 2015 at 01:36:44PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote:
> > On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote:
> > > On Wed, May 13, 2015 at 11:32:50AM +, Gujulan Elango, Hari Prasath
> > >
On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote:
> On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote:
> > On Wed, May 13, 2015 at 11:32:50AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > check return value of kmalloc before accessing the memory pointer.This
>
Hello Oleg,
On Wed, May 13, 2015 at 01:53:35AM +, Drokin, Oleg wrote:
> Hello!
>
> On May 12, 2015, at 6:43 PM, George G. Davis wrote:
>
> > Greetings,
> >
> > Resending this using the correct version of get_maintainers.pl.
> >
> > As recommended in the thread "SPDX-License-Identifier” [1]
On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote:
> On Wed, May 13, 2015 at 11:32:50AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > check return value of kmalloc before accessing the memory pointer.This
> > function returns a non-zero value on failure hence a return value of
On Wed, May 13, 2015 at 11:32:50AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> check return value of kmalloc before accessing the memory pointer.This
> function returns a non-zero value on failure hence a return value of 1
> is used.
Could you do some reasearch where this thing is freed?
S
check return value of kmalloc before accessing the memory pointer.This
function returns a non-zero value on failure hence a return value of 1
is used.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wlan-ng/p80211conv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers
On Wed, May 13, 2015 at 10:36:28AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> check the return value of kzalloc before accessing the memory pointer
>
> Signed-off-by: Hari Prasath Gujulan Elango
Looks good.
regards,
dan carpenter
___
devel m
check the return value of kzalloc before accessing the memory pointer
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c
b/drivers/staging/lustre/l
What? No, that patch can't work at all. It will just oops directly
when you do:
> +memcpy(&tx->p1k, &tkey->tx_ttak, p1k_len);
How come you didn't use my patch as a base to work from, you shouldn't
be passing tkip_ctx at all.
regards,
dan carpenter
_
Actually, to be honest, I would prefer if you moved things without
changing it too much. I have a script to review "move code to a new
function" patches but if everything moves and changes as well then it's
confusing and I have to do it by hand.
regards,
dan carpenter
__
On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
> On 11.05.2015 10:26, Dan Carpenter wrote:
> (...)
> >> */
> >>skb_pull(sub_skb, SNAP_SIZE);
> >> - memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src,
>
On 13/05/15 05:53, Tolga Ceylan wrote:
In ni_ai_cmd() bitwise or construction of ai_trig in case of TRIG_NOW
is faulty. Register address is accidentally in the expression,
but this has no effect. This is an accidental left-over code
that used to call a function with register address as one of
the
94 matches
Mail list logo
