On Thu, May 07, 2015 at 10:04:32PM +0200, Greg Kroah-Hartman wrote:
> On Thu, May 07, 2015 at 03:06:52PM +0530, Sudip Mukherjee wrote:
> > the previous patch of the series made this variable unused.
>
> What do you mean? There was only one other patch in this series, never
> send a patch that cau
Hello!
On May 7, 2015, at 8:09 AM, Dan Carpenter wrote:
>>> Clean up spacing in some variable declarations, to be more consistent.
>>>
>>> It's small, but I need to start somewhere. Please let me know if I'm not
>>> adhering to proper procedure for trivial cleanups.
>>
>> It's actually Lustre
This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV:
- it uses a hack to check if the remote entity is a subdev;
- it still uses the legacy entity subtype check macro, that
will be removed soon.
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
b/d
Instead of relying on media subtype, use the new macros to detect
if an entity is a subdev or an A/V DMA entity.
Please note that most drivers assume that there's just AV_DMA or
V4L2 subdevs. This is not true anymore, as we've added MC support
for DVB, and there are plans to add support for ALSA a
On omap3/omap4/davinci drivers, MEDIA_ENT_T_V4L2_SUBDEV macro is
abused in order to "simplify" the pad checks.
Basically, it does a logical or of this macro, in order to check
for a local index and if the entity is either a subdev or not.
As we'll get rid of MEDIA_ENT_T_V4L2_SUBDEV macro, replace
This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, as it uses a
hack to check if the remote entity is a subdev. Get rid of it.
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/staging/media/omap4iss/iss_ipipe.c
b/drivers/staging/media/omap4iss/iss_ipipe.c
index eaa82da30f50..2c809e7a8da6
On 05/05/15 17:32, Geert Uytterhoeven wrote:
> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> functionality only, can still be compiled if GPIOLIB is not enabled.
>
> Relax the dependency on GPIOL
On Thu, May 07, 2015 at 03:06:52PM +0530, Sudip Mukherjee wrote:
> the previous patch of the series made this variable unused.
What do you mean? There was only one other patch in this series, never
send a patch that causes a build warning.
greg k-h
___
On Thu, May 07, 2015 at 09:51:35AM -0500, German Rivera wrote:
> I'll remove the nested #ifdef. However, as I explained before, these
> #ifdefs are needed to be able to make the code compile without the
> GIC-ITS support in place. Of course, the code will not be moved out
> of staging with these #i
This changes calls to printk with loglevel of KERN_DEBUG to the
more appropriate pr_debug as found by running checkpatch on the
file,rtllib_crypt.c.
Signed-off-by: Nicholas Krause
---
drivers/staging/rtl8192e/rtllib_crypt.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --gi
On Thu, 7 May 2015, Dan Carpenter wrote:
> On Thu, May 07, 2015 at 03:36:05AM +, Dilger, Andreas wrote:
> > On 2015/05/06, 6:02 AM, "Mike Shuey" wrote:
> >
> > >Clean up spacing in some variable declarations, to be more consistent.
> > >
> > >It's small, but I need to start somewhere. Please
On Thu, 2015-05-07 at 10:08 -0400, Jes Sorensen wrote:
> Dan Carpenter writes:
> > On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
> >> NACK!
> > SHOUTING!
> It's normal to write NACK in upper case
Not with an exclamation point.
___
deve
On 05/07/2015 08:03 AM, Dan Carpenter wrote:
On Wed, May 06, 2015 at 04:28:22PM -0500, J. German Rivera wrote:
+/*
+ * FIXME: Enable this code when the GIC-ITS MC support patch is merged
+ */
+#ifdef GIC_ITS_MC_SUPPORT
+static int mc_bus_msi_prepare(struct irq_domain *domain, struct device *de
Joe Perches writes:
> On Thu, 2015-05-07 at 10:08 -0400, Jes Sorensen wrote:
>> Dan Carpenter writes:
>> > On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
>> >> NACK!
>> > SHOUTING!
>> It's normal to write NACK in upper case
>
> Not with an exclamation point.
I would add a tag if
On 05/07/2015 08:21 AM, Sudip Mukherjee wrote:
On Thu, May 07, 2015 at 08:01:53AM -0500, Jaime Arrocha wrote:
On 05/07/2015 12:34 AM, Sudip Mukherjee wrote:
On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
Errors found by checkpatch.pl.
ERROR: code indent should use tabs wher
On 05/07/2015 09:27 AM, Jaime Arrocha wrote:
-- Forwarded message --
From: Jaime Arrocha
Date: Wed, May 6, 2015 at 4:08 PM
Subject: [PATCH] staging: comedi: drivers: das16m1.c: checkpatch error fix
To: g...@kroah.com
Cc: abbo...@mev.co.uk, hswee...@visionengravers.com,
de...@dr
"Gujulan Elango, Hari Prasath (H.)" writes:
> On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
>> On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
>> > "Gujulan Elango, Hari Prasath (H.)" writes:
>> > > Remove the goto and return error directly thereby removing a variab
Dan Carpenter writes:
> On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
>> "Gujulan Elango, Hari Prasath (H.)" writes:
>> > Remove the goto and return error directly thereby removing a variable
>> >
>> > Signed-off-by: Hari Prasath Gujulan Elango
>> > ---
>> > drivers/staging/rtl8
On Wed, May 06, 2015 at 04:28:22PM -0500, J. German Rivera wrote:
> @@ -350,17 +324,280 @@ int dprc_scan_container(struct fsl_mc_device
> *mc_bus_dev)
>* Discover objects in the DPRC:
>*/
> mutex_lock(&mc_bus->scan_mutex);
> - error = dprc_scan_objects(mc_bus_dev);
> +
On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
> On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
> > "Gujulan Elango, Hari Prasath (H.)" writes:
> > > Remove the goto and return error directly thereby removing a variable
> > >
> > > Signed-off-by: Hari Prasath Gujulan
On 05/07/2015 12:34 AM, Sudip Mukherjee wrote:
On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
Errors found by checkpatch.pl.
ERROR: code indent should use tabs where possible
/drivers/staging/comedi/drivers/das16m1.c:49
/drivers/staging/comedi/drivers/das16m1.c:50
Signed-off-b
On Thu, May 07, 2015 at 08:01:53AM -0500, Jaime Arrocha wrote:
>
>
> On 05/07/2015 12:34 AM, Sudip Mukherjee wrote:
> >On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
> >>Errors found by checkpatch.pl.
> >>ERROR: code indent should use tabs where possible
> >>/drivers/staging/comed
On Wed, May 06, 2015 at 04:28:22PM -0500, J. German Rivera wrote:
> +/*
> + * FIXME: Enable this code when the GIC-ITS MC support patch is merged
> + */
> +#ifdef GIC_ITS_MC_SUPPORT
> +static int mc_bus_msi_prepare(struct irq_domain *domain, struct device *dev,
> + int nve
On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
> "Gujulan Elango, Hari Prasath (H.)" writes:
> > Remove the goto and return error directly thereby removing a variable
> >
> > Signed-off-by: Hari Prasath Gujulan Elango
> > ---
> > drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c |
On Thu, May 07, 2015 at 03:36:05AM +, Dilger, Andreas wrote:
> On 2015/05/06, 6:02 AM, "Mike Shuey" wrote:
>
> >Clean up spacing in some variable declarations, to be more consistent.
> >
> >It's small, but I need to start somewhere. Please let me know if I'm not
> >adhering to proper procedu
"Gujulan Elango, Hari Prasath (H.)" writes:
> Remove the goto and return error directly thereby removing a variable
>
> Signed-off-by: Hari Prasath Gujulan Elango
> ---
> drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
NACK!
The
Remove the goto and return error directly thereby removing a variable
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
b/d
the remove callback will be called in two cases, 1) if the driver is
removed and 2) if the pci device is removed. as of now all the board
cleanups were being done in the module unload section so if the module
is unloaded everything works. But if the pci device is removed then the
loaded driver will
move the cleanup function before the remove call as the next patch of
the series is going to use that.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 61 ++---
1 file changed, 30 insertions(+), 31 deletions(-)
diff --git a/drivers/stagin
the previous patch of the series made this variable unused.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorchipset/visorchipset_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c
b/drivers/staging/unisys/visorchips
these functions were just defined and never used.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorchipset/visorchipset.h | 4 ---
.../unisys/visorchipset/visorchipset_main.c| 41 --
2 files changed, 45 deletions(-)
diff --git a/drivers/staging/unisys/
On Wed, May 06, 2015 at 02:34:49PM -0700, Garret Kelly wrote:
> > Can't we fix this properly, to use the correct type of pointer instead
> > for non-__iomem allocations?
>
> You mean making an alternate screen_base pointer inside fb_info that
> isn't __iomem? There are already a bunch of framebuf
This is to officially inform you that you been accredited with an ATM CARD
worth $2.8Million Dollars on the ongoing Global international ATM Card Award
held on 2nd of May 2015. Email address for this award was selected from
databases of major shopping mails, electricity companies,railways statio
33 matches
Mail list logo
