Re: [HPDD-discuss] [PATCH] Staging: lustre: file.c: fix coding style

2015-03-18 Thread Julia Lawall
On Wed, 18 Mar 2015, Patrick Farrell wrote: > Uck, my reply made the formatting even worse. I'm trying to say it should > look like this: > +rc = ll_intent_file_open(file->f_path.dentry, > +NULL, 0, it); > Not like this: > +

Re: [PATCH] Staging: lustre: ldlm_pool: fix coding style

2015-03-18 Thread Greg KH
On Wed, Mar 18, 2015 at 09:11:22PM +0100, Guillaume Turchini wrote: > Errors and warnings of coding style rules corrected. You need to be a bit more specific and say what exact errors and warnings were fixed. And please only fix one type of error or warning per patch you send out. This patch sho

Re: [PATCH] staging: lustre: linux: linux-prim: fixed coding style warnings and errors

2015-03-18 Thread Greg KH
On Wed, Mar 18, 2015 at 07:22:49PM +0100, Roberto Medina wrote: > From: Roberto Medina > > Coding style fixes due to exported symbols and comment style. > > Signed-off-by: Roberto Medina As we spoke in person, it's best to do only one logical thing per patch, but this one is just so easy to re

[PATCHv2 4/5] Drivers: Staging: ft1000: Fix blank line warning

2015-03-18 Thread Janakarajan Natarajan
Merges variable declaration and definition. Signed-off-by: Janakarajan Natarajan --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1

[PATCHv2 3/5] Drivers: Staging: ft1000: Refactoring if-else statement

2015-03-18 Thread Janakarajan Natarajan
Minor change to convert if-else to if statement Signed-off-by: Janakarajan Natarajan --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-p

[PATCHv2 2/5] Drivers: Staging: ft1000: Fix extra parenthesis warnings

2015-03-18 Thread Janakarajan Natarajan
Minor changes to remove extra parenthesis Signed-off-by: Janakarajan Natarajan --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 2 +- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia

[PATCHv2 1/5] Drivers: Staging: ft1000: Single line if-statement changes

2015-03-18 Thread Janakarajan Natarajan
Minor change to remove {} for single line if statements Signed-off-by: Janakarajan Natarajan --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/drivers/staging/ft1000/f

[PATCHv2 0/5] ft1000 driver checkpatch.pl fixes

2015-03-18 Thread Janakarajan Natarajan
Minor changes to fix ft1000 driver checkpatch.pl warnings Janakarajan Natarajan (5): Drivers: Staging: ft1000: Single line if-statement changes Drivers: Staging: ft1000: Fix extra parenthesis warnings Drivers: Staging: ft1000: Refactoring if-else statement Drivers: Staging: ft1000: Fix bla

[PATCHv2 5/5] Drivers: Staging: ft1000: checkpatch.pl header file warning fix

2015-03-18 Thread Janakarajan Natarajan
Replaces and with and Signed-off-by: Janakarajan Natarajan --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c index b

[PATCH V2 1/1] X86: hyperv: Enable MSR based APIC access

2015-03-18 Thread K. Y. Srinivasan
If the hypervisor supports MSR based access to the APIC registers (EOI, TPR and ICR), implement the MSR based access. Signed-off-by: K. Y. Srinivasan --- Changes from V1: Addressed comments from Ingo Molnar arch/x86/kernel/cpu/mshyperv.c | 62 1 fil

[PATCH] Staging: lustre: ldlm_pool: fix coding style

2015-03-18 Thread Guillaume Turchini
Errors and warnings of coding style rules corrected. Signed-off-by: Guillaume Turchini --- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c b/drivers/staging/lustre/lustr

Re: [PATCH] Staging: lustre: file.c: fix coding style

2015-03-18 Thread Dan Carpenter
Fix your email client From header to use your full name. The subject is very vague. On Wed, Mar 18, 2015 at 08:08:48PM +0100, p...@amd48-systeme.lip6.fr wrote: > Several warnings and errors of coding style rules corrected. Which? > Compile tested. Put this under the --- cut off. regards, dan

Re: [HPDD-discuss] [PATCH] Staging: lustre: file.c: fix coding style

2015-03-18 Thread Patrick Farrell
Uck, my reply made the formatting even worse. I'm trying to say it should look like this: +rc = ll_intent_file_open(file->f_path.dentry, +NULL, 0, it); Not like this: +rc = ll_intent_file_open(file->f_path.dentry, +

Re: [HPDD-discuss] [PATCH] Staging: lustre: file.c: fix coding style

2015-03-18 Thread Patrick Farrell
Perhaps this is just a formatting error in my email client, but shouldn't NULL be one more space over to line up with the '(' above? On 03/18/2015 02:08 PM, p...@amd48-systeme.lip6.fr wrote: + rc = ll_intent_file_open(file->f_path.dentry, +

[PATCH] MAINTAINERS: change Arve's last name encoding to UTF-8

2015-03-18 Thread Baruch Siach
All other non ASCII names in this file are also UTF-8 encoded. Signed-off-by: Baruch Siach --- I'm pretty sure this patch as it goes through the mail system will fail to apply using 'git am', because the email encoding is not well defined, but the intention is clear. --- MAINTAINERS | 2 +- 1 fi

[PATCH] Staging: fbtft: add declaration of non-static functions

2015-03-18 Thread Peter Poklop
This patch fixes these sparse warnings: drivers/staging/fbtft/fbtft-sysfs.c:23:5: warning: symbol 'fbtft_gamma_parse_str' was not declared. Should it be static? drivers/staging/fbtft/fbtft-sysfs.c:153:6: warning: symbol 'fbtft_expand_debug_value' was not declared. Should it be static? drivers/sta

[PATCH] Staging: lustre: file.c: fix coding style

2015-03-18 Thread py
Several warnings and errors of coding style rules corrected. Compile tested. Signed-off-by: Pierre-Yves Péneau --- drivers/staging/lustre/lustre/llite/file.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/stagin

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Lorenzo Stoakes
On 18 March 2015 at 10:59, Dan Carpenter wrote: > Call it a v2 patch. Put a note under the --- cut off line: > v2: updated to apply to latest linux-next > > http://kernelnewbies.org/PatchTipsAndTricks Since each changed patch in the resend already incorporates changes to update to apply to the l

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Lorenzo Stoakes
On 18 March 2015 at 11:25, Dan Carpenter wrote: > Could you read your patches again and find other similar white space > issues. Done. Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdr

[PATCH RESEND v2 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Lorenzo Stoakes
This patch takes into account that cursor->vstart, crtc->vScreen and share->pvMem are pointers to memory-mapped I/O and thus we should use memset_io to make this explicit. In addition, some architectures require special treatment of memory-mapped I/O so the previous code could actually break withou

[PATCH RESEND v2 4/5] staging: sm750fb: Fix __iomem pointer types

2015-03-18 Thread Lorenzo Stoakes
This patch annotates pointers as referring to I/O mapped memory where they ought to be, removes now unnecessary ugly casts, eliminates an incorrect deref on I/O mapped memory by using iowrite16 instead, and updates the pointer arithmetic accordingly to take into account that the pointers are now by

Re: [PATCH] octeon-usb: fix 'too many leading tabs'

2015-03-18 Thread Aaro Koskinen
Hi, On Wed, Mar 18, 2015 at 10:18:29PM +0530, Amitoj Kaur Chawla wrote: > This file contained a lot of warnings of line of over 80 characters > and that the code needs to be refactored due to nested if else > conditions. > > The file was accordingly edited to remove some of the warnings. > > Sig

[PATCH] staging: lustre: linux: linux-prim: fixed coding style warnings and errors

2015-03-18 Thread Roberto Medina
From: Roberto Medina Coding style fixes due to exported symbols and comment style. Signed-off-by: Roberto Medina --- .../lustre/lustre/libcfs/linux/linux-prim.c| 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/lustre/lustre/li

Re: [PATCH octeon-usb] fix 'line over 80 characters'

2015-03-18 Thread Aaro Koskinen
Hi, On Wed, Mar 18, 2015 at 08:12:32PM +0530, Amitoj Kaur Chawla wrote: > This file contained a warning of a line being over 80 characters and > so the file has been edited to remove that warning. > > Signed-off-by: Amitoj Kaur Chawla > --- > drivers/staging/octeon-usb/octeon-hcd.c | 2 +- > 1

[PATCH V2 10/10] Drivers: hv: vmbus: Fix a siganlling host signalling issue

2015-03-18 Thread K. Y. Srinivasan
Handle the case when the write to the ringbuffer fails. In this case, unconditionally signal the host. Since we may have deferred signalling the host based on the kick_q parameter, signalling the host unconditionally in this case deals with the issue. Signed-off-by: K. Y. Srinivasan --- drivers/

[PATCH V2 02/10] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure

2015-03-18 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov When add_memory() fails the following BUG is observed: [ 743.646107] hv_balloon: hot_add memory failed error is -17 [ 743.679973] [ 743.680930] = [ 743.680930] [ BUG: bad unlock balance detected! ] [ 743.680930] 3.19.0-rc5_bug1131426

[PATCH V2 07/10] Drivers: hv: vmbus: Fix a bug in rescind processing in vmbus_close_internal()

2015-03-18 Thread K. Y. Srinivasan
When a channel has been rescinded, the close operation is a noop. Restructure the code so we deal with the rescind condition after we properly cleanup the channel. I would like to thank Dexuan Cui for observing this problem. The current code leaks memory when the channel is rescinded. The current

[PATCH V2 00/10] Drivers: hv: vmbus: Some miscellaneous fixes

2015-03-18 Thread K. Y. Srinivasan
Some miscellaneous fixes to the vmbus driver and the balloon driver. Currently the char-next tree is broken and some of the patches in this set fix the issue. In this version of the set, Nick has addressed review comments from Greg on the patch: 0004-Drivers-hv-vmbus-Correcting-truncation-error-fo

[PATCH V2 08/10] hv: hypervvssd: call endmntent before call setmntent again

2015-03-18 Thread K. Y. Srinivasan
From: Vaughan Cao If freeze fails, vss_operate will re-enter itself to thaw. But it forgets to call endmntent() before it recalls setmntent() again. Signed-off-by: Vaughan Cao Signed-off-by: K. Y. Srinivasan --- tools/hv/hv_vss_daemon.c | 10 -- 1 files changed, 8 insertions(+), 2 d

[PATCH V2 05/10] hv: vmbus: missing curly braces in vmbus_process_offer()

2015-03-18 Thread K. Y. Srinivasan
From: Dan Carpenter The indenting makes it clear that there were curly braces intended here. Fixes: 2dd37cb81580 ('Drivers: hv: vmbus: Handle both rescind and offer messages in the same context') Signed-off-by: Dan Carpenter Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c |

[PATCH V2 04/10] Drivers: hv: vmbus: Correcting truncation error for constant HV_CRASH_CTL_CRASH_NOTIFY

2015-03-18 Thread K. Y. Srinivasan
From: Nick Meier HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number. Depending on the usage context, the value may be truncated. This patch is in response from the following email from Wu Fengguang : From: Wu Fengguang Subject: [char-misc:char-misc-testing 25/45] drivers/hv/vmbus_drv.c:67:9

[PATCH V2 09/10] Drivers: hv: vmbus: Export the vmbus_sendpacket_pagebuffer_ctl()

2015-03-18 Thread K. Y. Srinivasan
Export the vmbus_sendpacket_pagebuffer_ctl() interface. This export will be used by the netvsc driver. Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index 2c8206d..fddd

[PATCH V2 06/10] tools: hv: fcopy_daemon: support >2GB files for x86_32 guest

2015-03-18 Thread K. Y. Srinivasan
From: Dexuan Cui Without this patch, hv_fcopy_daemon's hv_copy_data() -> pwrite() will fail for >2GB file offset. The current char-next branch is broken and this patch fixes the bug. Signed-off-by: Alex Ng Signed-off-by: Dexuan Cui Cc: K. Y. Srinivasan Signed-off-by: K. Y. Srinivasan --- t

[PATCH V2 03/10] Drivers: hv: hv_balloon: don't lose memory when onlining order is not natural

2015-03-18 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov Memory blocks can be onlined in random order. When this order is not natural some memory pages are not onlined because of the redundant check in hv_online_page(). Here is a real world scenario: 1) Host tries to hot-add the following (process_hot_add): pg_start=rg_start=0

[PATCH V2 01/10] Drivers: hv: vmbus: Perform device register in the per-channel work element

2015-03-18 Thread K. Y. Srinivasan
This patch is a continuation of the rescind handling cleanup work. We cannot block in the global message handling work context especially if we are blocking waiting for the host to wake us up. I would like to thank Dexuan Cui for observing this problem. The current char-next branch is broken and

[PATCH] staging: fbtft: Use strcmp instead of strncmp

2015-03-18 Thread Ravindran, Madhusudhanan (M.)
Since both buffers are null terminated, strncmp is not needed. Signed-off-by: Madhusudhanan Ravindran --- drivers/staging/fbtft/fbtft_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c inde

[PATCH] octeon-usb: fix 'too many leading tabs'

2015-03-18 Thread Amitoj Kaur Chawla
This file contained a lot of warnings of line of over 80 characters and that the code needs to be refactored due to nested if else conditions. The file was accordingly edited to remove some of the warnings. Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/octeon-usb/octeon-hcd.c | 8 --

Re: [PATCH 3/4] staging/lustre: use __aligned(size) instead of __attribute__(aligned(size))

2015-03-18 Thread Mario J. Rugiero
OK, I'll do that, thanks. Mario. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH octeon-usb] fix 'line over 80 characters'

2015-03-18 Thread Greg KH
On Wed, Mar 18, 2015 at 08:12:32PM +0530, Amitoj Kaur Chawla wrote: > > This file contained a warning of a line being over 80 characters and > so the file has been edited to remove that warning. > > Signed-off-by: Amitoj Kaur Chawla Why did you put the driver name within the []? It needs to g

[PATCH octeon-usb] fix 'line over 80 characters'

2015-03-18 Thread Amitoj Kaur Chawla
This file contained a warning of a line being over 80 characters and so the file has been edited to remove that warning. Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/o

Re: [PATCH 4/9] Correcting truncation error for constant HV_CRASH_CTL_CRASH_NOTIFY

2015-03-18 Thread Greg KH
On Wed, Mar 18, 2015 at 02:23:09PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Wednesday, March 18, 2015 12:27 AM > > To: KY Srinivasan > > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > > o...@a

RE: [PATCH 4/9] Correcting truncation error for constant HV_CRASH_CTL_CRASH_NOTIFY

2015-03-18 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, March 18, 2015 12:27 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; Nick Meier > Subject: Re: [P

Re: [PATCH] clocking-wizard: fix one coding style problem.

2015-03-18 Thread Greg KH
On Mon, Feb 16, 2015 at 12:14:09AM +0700, Tan Nguyen wrote: > Added one line after variable declaration. > > Signed-off-by: Tan Nguyen > --- > drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + > 1 file changed, 1 insertion(+) Patch does not apply to my tree, someone else already ma

Re: [PATCH v2] Staging: dgnc: release the lock before testing for nullity

2015-03-18 Thread Dan Carpenter
I don't know anyone with this hardware who can test a patch. If you find someone then you should send a patch to reorder the other original unlock and deref. Otherwise, I would just leave it alone for now. regards, dan carpenter ___ devel mailing list

Re: [PATCH v2] Staging: dgnc: release the lock before testing for nullity

2015-03-18 Thread Quentin Lambert
On 18/03/2015 14:54, Dan Carpenter wrote: On Wed, Mar 18, 2015 at 02:43:01PM +0100, Quentin Lambert wrote: On 18/03/2015 14:36, Dan Carpenter wrote: This changelog still doesn't make sense so I took a look at the code. tty_ldisc_deref() is an unlock function. So this is a lock ordering bug

Re: [PATCH v2] Staging: dgnc: release the lock before testing for nullity

2015-03-18 Thread Dan Carpenter
On Wed, Mar 18, 2015 at 02:43:01PM +0100, Quentin Lambert wrote: > > > On 18/03/2015 14:36, Dan Carpenter wrote: > >This changelog still doesn't make sense so I took a look at the code. > > > >tty_ldisc_deref() is an unlock function. So this is a lock ordering > >bug. What makes you think the o

Re: [PATCH v2] Staging: dgnc: release the lock before testing for nullity

2015-03-18 Thread Quentin Lambert
On 18/03/2015 14:36, Dan Carpenter wrote: This changelog still doesn't make sense so I took a look at the code. tty_ldisc_deref() is an unlock function. So this is a lock ordering bug. What makes you think the original ordering was correct? Who reported this bug? What are the effects of th

Re: [PATCH v2] Staging: dgnc: release the lock before testing for nullity

2015-03-18 Thread Dan Carpenter
On Wed, Mar 18, 2015 at 02:21:08PM +0100, Quentin Lambert wrote: > The refactoring intrduced in > c84a083b995b ("Staging: dgnc: Use goto for spinlock release before return") > inverts the order in which the lock is released and ld is tested for nullity. > > This patch restores the execution flow.

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Sudip Mukherjee
On Wed, Mar 18, 2015 at 04:23:39PM +0300, Dan Carpenter wrote: > > https://lkml.org/lkml/2015/3/10/685 > > > > You were making random white space changes and not on the same line. It > was hard to review because you had to count how many u32 arguments there > were (a million) and really look at

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Dan Carpenter
On Wed, Mar 18, 2015 at 06:36:07PM +0530, Sudip Mukherjee wrote: > On Wed, Mar 18, 2015 at 02:25:09PM +0300, Dan Carpenter wrote: > > On Wed, Mar 18, 2015 at 11:12:20AM +, Lorenzo Stoakes wrote: > > > On 18 March 2015 at 10:50, Vitaly Kuznetsov wrote: > > If it's a white space thing on the sam

[PATCH v2] Staging: dgnc: release the lock before testing for nullity

2015-03-18 Thread Quentin Lambert
The refactoring intrduced in c84a083b995b ("Staging: dgnc: Use goto for spinlock release before return") inverts the order in which the lock is released and ld is tested for nullity. This patch restores the execution flow. Fixes: c84a083b995b ("Staging: dgnc: Use goto for spinlock release before

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Sudip Mukherjee
On Wed, Mar 18, 2015 at 02:25:09PM +0300, Dan Carpenter wrote: > On Wed, Mar 18, 2015 at 11:12:20AM +, Lorenzo Stoakes wrote: > > On 18 March 2015 at 10:50, Vitaly Kuznetsov wrote: > If it's a white space thing on the same line then it's generally ok to > fix it. The "one thing per patch" is

Re: [PATCH 3/4] staging/lustre: use __aligned(size) instead of __attribute__(aligned(size))

2015-03-18 Thread Greg KH
On Wed, Mar 18, 2015 at 09:30:24AM -0300, Mario J. Rugiero wrote: > I didn't expect that. Maybe I used the wrong linux-next? > Just to make sure, what should I be making the patches against? I made them > against the latest next branch I was able to find on Linus tree, is that > right? linux-next

Re: [PATCH] Staging: dgnc: release the lock before testing for nullity

2015-03-18 Thread Dan Carpenter
This patch has no changelog. What's the bug? On Wed, Mar 18, 2015 at 01:51:52PM +0100, Quentin Lambert wrote: > Fixes: c84a083b995b ("Staging: dgnc: Use goto for spinlock release before > return") > Don't put a blank line here. > Signed-off-by: Quentin Lambert regards, dan carpenter _

[PATCH] Staging: dgnc: release the lock before testing for nullity

2015-03-18 Thread Quentin Lambert
Fixes: c84a083b995b ("Staging: dgnc: Use goto for spinlock release before return") Signed-off-by: Quentin Lambert --- drivers/staging/dgnc/dgnc_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 8445f

Re: [PATCH 3/4] staging/lustre: use __aligned(size) instead of __attribute__(aligned(size))

2015-03-18 Thread Mario J. Rugiero
I didn't expect that. Maybe I used the wrong linux-next? Just to make sure, what should I be making the patches against? I made them against the latest next branch I was able to find on Linus tree, is that right? ___ devel mailing list de...@linuxdriv

Prezado usuário

2015-03-18 Thread WEBADMIN
Prezado usuário Seu e-mail excedeu 2 GB criado pelo webmaster, você está atualmente rodando a 2,30 GB, que não pode enviar ou receber mensagem nova dentro o próximo 24 horas até que você verificar que a conta de e-mail. Por favor, digite seus dados abaixo para verificar a sua conta: (1) e-mail:

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Dan Carpenter
On Wed, Mar 18, 2015 at 11:12:20AM +, Lorenzo Stoakes wrote: > On 18 March 2015 at 10:50, Vitaly Kuznetsov wrote: > > ERROR is reported by scripts/checkpatch.pl (spaces are missing after > > ','). This coding style problem was there before your patch but I don't > > think it makes sense to pre

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Lorenzo Stoakes
On 18 March 2015 at 10:59, Dan Carpenter wrote: > Btw, sorry for coming down hard on you. You're a newbie and expected to > make these mistakes. Your patches are good and appreciated. Thanks and no problem, I expect to receive robust criticism given the high standards in the kernel and see it a

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Lorenzo Stoakes
On 18 March 2015 at 10:50, Vitaly Kuznetsov wrote: > ERROR is reported by scripts/checkpatch.pl (spaces are missing after > ','). This coding style problem was there before your patch but I don't > think it makes sense to preserve it. [snip] > WARNING: please, no spaces at the start of a line >

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Dan Carpenter
On Wed, Mar 18, 2015 at 10:46:52AM +, Lorenzo Stoakes wrote: > On 18 March 2015 at 10:17, Dan Carpenter wrote: > > Why is there a RESEND in the subject. > > To avoid confusion (and Sudip explicitly mentioned there might be > some), and in addition I had to update my patch series to take into

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Lorenzo Stoakes
On 18 March 2015 at 10:52, Dan Carpenter wrote: > I often say "don't resend" because something is minor and I don't want > to slow you down but since you were resending it anyway then please fix > it. Also changelogs are really easy to fix. In mutt, you can do it > without leaving your email cli

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Dan Carpenter
On Wed, Mar 18, 2015 at 10:44:53AM +, Lorenzo Stoakes wrote: > On 18 March 2015 at 10:18, Dan Carpenter wrote: > >> > >> This changelog still sucks. It doesn't describe the effect of this > >> behavior change for the user. It doesn't even make it clear that you > >> are aware that this is a

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Vitaly Kuznetsov
Lorenzo Stoakes writes: > This patch uses memset_io instead of memset when using memset on __iomem > qualified pointers. This fixes the following sparse warnings:- > > drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1 > (different address spaces) > drivers/staging/sm7

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Lorenzo Stoakes
On 18 March 2015 at 10:17, Dan Carpenter wrote: > Why is there a RESEND in the subject. To avoid confusion (and Sudip explicitly mentioned there might be some), and in addition I had to update my patch series to take into account that it no longer applied due to another patch which applies the AN

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Lorenzo Stoakes
On 18 March 2015 at 10:18, Dan Carpenter wrote: >> >> This changelog still sucks. It doesn't describe the effect of this >> behavior change for the user. It doesn't even make it clear that you >> are aware that this is a behavior change. > > It doesn't say to me that you have asked yourself if t

[PATCH] staging: rtl8192u: fix sparse warnings for static declaration

2015-03-18 Thread vibi sreenivasan
This patch fixes following sparse warning drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol 'ieee80211_check_auth_response' was not declared. Should it be static? Signed-off-by: Vibi Sreenivasan --- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c |2 +- 1 fil

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Dan Carpenter
On Wed, Mar 18, 2015 at 01:17:17PM +0300, Dan Carpenter wrote: > Why is there a RESEND in the subject. > > On Wed, Mar 18, 2015 at 08:57:22AM +, Lorenzo Stoakes wrote: > > This patch uses memset_io instead of memset when using memset on __iomem > > qualified pointers. This fixes the following

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Dan Carpenter
Why is there a RESEND in the subject. On Wed, Mar 18, 2015 at 08:57:22AM +, Lorenzo Stoakes wrote: > This patch uses memset_io instead of memset when using memset on __iomem > qualified pointers. This fixes the following sparse warnings:- > > drivers/staging/sm750fb/sm750.c:489:17: warning: i

Re: [PATCH 3/4] staging/lustre: use __aligned(size) instead of __attribute__(aligned(size))

2015-03-18 Thread Greg KH
On Tue, Mar 10, 2015 at 12:02:04PM -0300, Mario J. Rugiero wrote: > Replace uses of __attribute__(aligned(size)) by __aligned(size), as suggested > by checkpatch. > > Signed-off-by: Mario J. Rugiero > --- > drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +- > 1 file changed

Re: [PATCH 4/4] staging/lustre: use __packed instead of __attribute__(packed)

2015-03-18 Thread Greg KH
On Tue, Mar 10, 2015 at 12:02:05PM -0300, Mario J. Rugiero wrote: > Replace __attribute__(packed) by __packed as suggested by checkpatch. > > Signed-off-by: Mario J. Rugiero > --- > .../include/linux/libcfs/libcfs_kernelcomm.h | 2 +- > .../staging/lustre/include/linux/lnet/lib-types.h |

[PATCH v5] staging: sm750fb: Fixed no space and indent warns

2015-03-18 Thread Ragavendra Nagraj
This patch fixes the no spaces and indent warnings identified by the checkpath.pl script for the entire ddk750_chip.c file by using appropriate tab spaces and indents accordingly. Signed-off-by: Ragavendra Nagraj --- Changes in v5: - Created patch for latest staging-next branch. drivers/stagi

Hello

2015-03-18 Thread Miss Lina duc Kien
Hello, My name is Lina duc Kien,the daughter of Nguyen Duc Kien.I look very good before writing you and I am sorry i do not write english good.I want to know if there is chance or project i can make with you in your country.why i am asking was that my father who co-founded the Asia Commercial

Hello

2015-03-18 Thread Miss Lina duc Kien
Hello, My name is Lina duc Kien,the daughter of Nguyen Duc Kien.I look very good before writing you and I am sorry i do not write english good.I want to know if there is chance or project i can make with you in your country.why i am asking was that my father who co-founded the Asia Commercial

Hello

2015-03-18 Thread Miss Lina duc Kien
Hello, My name is Lina duc Kien,the daughter of Nguyen Duc Kien.I look very good before writing you and I am sorry i do not write english good.I want to know if there is chance or project i can make with you in your country.why i am asking was that my father who co-founded the Asia Commercial

[PATCH] staging: i2o: Use kstrdup rather than duplicating its implementation

2015-03-18 Thread Abdul Hussain S
The semantic patch that makes this change is available in scripts/coccinelle/api/kstrdup.cocci Signed-off-by: Abdul Hussain S --- drivers/staging/i2o/memory.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/i2o/memory.c b/drivers/staging/i2o/memory.c inde

[PATCH RESEND 5/5] staging: sm750fb: Remove spinlock helper function

2015-03-18 Thread Lorenzo Stoakes
This patch removes the unnecessary spinlock helper function and instead calls spin_lock and spin_unlock directly. This does *not* resolve sparse warnings about context imbalances but these are spurious. Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750.c | 53

[PATCH RESEND 3/5] staging: sm750fb: Remove unused function

2015-03-18 Thread Lorenzo Stoakes
This patch removes the unused hw712_fillrect function. This patch fixes the following sparse warning:- drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750_accel.c |

[PATCH RESEND 4/5] staging: sm750fb: Fix __iomem pointer types

2015-03-18 Thread Lorenzo Stoakes
This patch annotates pointers as referring to I/O mapped memory where they ought to be, removes now unnecessary ugly casts, eliminates an incorrect deref on I/O mapped memory by using iowrite16 instead, and updates the pointer arithmetic accordingly to take into account that the pointers are now by

[PATCH RESEND 2/5] staging: sm750fb: Make internal functions static

2015-03-18 Thread Lorenzo Stoakes
This patch declares externally unavailable functions static. This fixes the following sparse warnings:- drivers/staging/sm750fb/ddk750_swi2c.c:223:6: warning: symbol 'swI2CStart' was not declared. Should it be static? drivers/staging/sm750fb/ddk750_swi2c.c:234:6: warning: symbol 'swI2CStop' was

[PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-18 Thread Lorenzo Stoakes
This patch uses memset_io instead of memset when using memset on __iomem qualified pointers. This fixes the following sparse warnings:- drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1 (different address spaces) drivers/staging/sm750fb/sm750.c:490:17: warning: incorre

Re: [PATCH v2 6/6] staging: sm750fb: Remove spinlock helper function

2015-03-18 Thread Lorenzo Stoakes
On 18 March 2015 at 07:52, Sudip Mukherjee wrote: > your series is not applying anymore to linux-next. > looks like some patches came from the Outreachy and were already > applied. > please redo it against staging-testing. Will do that now! I think at this point it'll be easier for me to resend t

Re: [PATCH v2 6/6] staging: sm750fb: Remove spinlock helper function

2015-03-18 Thread Sudip Mukherjee
On Wed, Mar 11, 2015 at 03:03:39PM +, Lorenzo Stoakes wrote: > On 11 March 2015 at 14:58, Sudip Mukherjee wrote: > > I am more than happy to resend the whole series as necessary if that > makes it easier for Greg or anyone else :) I have previously > resubmitted an entire patch series only fo

Re: [PATCH v4] staging: sm750fb: Fixed no space and indent warns

2015-03-18 Thread Sudip Mukherjee
On Mon, Mar 16, 2015 at 10:16:09PM -0700, Ragavendra Nagraj wrote: > This patch fixes the no spaces and indent warnings identified by the > checkpath.pl script for the entire ddk750_chip.c file by using > appropriate tab spaces and indents accordingly. your patch is no longer applying to linux-next

Re: [PATCH 4/9] Correcting truncation error for constant HV_CRASH_CTL_CRASH_NOTIFY

2015-03-18 Thread Greg KH
On Tue, Mar 17, 2015 at 05:41:56PM -0700, K. Y. Srinivasan wrote: > From: Nick Meier > > HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number. Depending on the usage context, > the value may be truncated. This patch is in response from the following > email from Intel: "from Intel:" is really vague, pl

Re: [PATCH 4/9] Correcting truncation error for constant HV_CRASH_CTL_CRASH_NOTIFY

2015-03-18 Thread Greg KH
On Tue, Mar 17, 2015 at 05:41:56PM -0700, K. Y. Srinivasan wrote: > From: Nick Meier > > HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number. Depending on the usage context, > the value may be truncated. This patch is in response from the following > email from Intel: Subject should have "hv:" at the