[no subject]

From: bachar To: de...@linuxdriverproject.org Date: 09/02/2014 Subject: =?utf-8?B?aGV5ICwgcGxlYXNlIGxldCBtZSBrbm93IGhvdyB0byBwcm9jZWVk?= Content-Type:multipart/alternative; boundary="69047ebcadc1a5c255ff34c7d042c831"; --69047ebcadc1a5c255ff34c7d042c831 Content-Type:text/plain; charset=utf-8 P

[PATCH 10/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

Fix coding style issue where the open curly brace '{' should be on the same line as the if statement. Signed-off-by: An Ha --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coe

[PATCH 05/12] Staging: rtl8821ae: hal_bt_coexist: fix pointer placement coding style issue

Fix pointer placement coding style issue, where using "foo *" is preferable over "foo*". Signed-off-by: An Ha --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drive

[PATCH 07/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

Remove unnecessary whitespace before a quoted newline. Signed-off-by: An Ha --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae

[PATCH 12/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

Fix coding style issue which requires a blank line after declarations. Signed-off-by: An Ha --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal

[PATCH 02/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

Fix coding style issue which requires a space before the open curly brace '{'. Signed-off-by: An Ha --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/sta

[PATCH 09/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

Fix coding style issue where the else conditional statement should follow the closing curly brace '}'. Signed-off-by: An Ha --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_co

[PATCH 11/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

Fix coding style issue which requires a space after the equal sign '='. Signed-off-by: An Ha --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl882

[PATCH 08/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

Fix coding style issue where the if statement unnecessarily uses curly braces for one line statements. Signed-off-by: An Ha --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl88

[PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style

Fix commenting style from C99 comments to C89 comments Signed-off-by: An Ha --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal

[PATCH 03/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

Fix coding style issue which requires a space after the open parenthesis '('. Signed-off-by: An Ha --- .../staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 50 +++--- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexis

[PATCH 04/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

Fix coding style issue which requires a space after a comma. Signed-off-by: An Ha --- .../staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 26 +++--- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/st

[PATCH 06/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

Remove whitespace after open parenthesis '('. Signed-off-by: An Ha --- drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt

Re: [PATCH] staging: android: add a blank line after declarations

On Sun, Aug 31, 2014 at 09:43:15PM +0100, Grzegorz Swirski wrote: > Signed-off-by: Grzegorz Swirski > --- > drivers/staging/android/sync.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c > index e7b2e02..0d37495 100644 > --

[PATCH 1/2] staging: lustre: ldlm: expand the GOTO macro

From: Julia Lawall The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ identifier lbl; identifier rc; constant c; @@ - GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); + rc; + goto lbl; // Signed-off-by: Julia Law

[PATCH 2/2] staging: lustre: ldlm: simplify rc initialization

From: Julia Lawall Simplify initialization of rc to take advantage of the fact that it is done at statement level. Signed-off-by: Julia Lawall --- drivers/staging/lustre/lustre/ldlm/ldlm_request.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/

Re: [PATCH] staging: xillybus: Move out of staging

On Mon, Sep 01, 2014 at 10:01:38PM +0300, Eli Billauer wrote: > Hello Tobias, > > Thanks for that heads-up. I'll make a separate patch for MAINTAINERS if and > when the driver goes out of staging. No point risking the failure to apply > the major patch because of a clash on MAINTAINERS. You can s

Re: [PATCH] staging: xillybus: Move out of staging

Hello Tobias, Thanks for that heads-up. I'll make a separate patch for MAINTAINERS if and when the driver goes out of staging. No point risking the failure to apply the major patch because of a clash on MAINTAINERS. Regards, Eli On 01/09/14 15:33, Tobias Klauser wrote: I shall continue b

Re: [PATCH 2/2] staging: dgnc: Replace fixed-size board array with list

On 09/01, Dan Carpenter wrote: > On Sun, Aug 31, 2014 at 11:23:58PM +0200, Konrad Zapalowicz wrote: > > Each registered board is asigned a data structure to keep it's state. > > So far this was implemented using the static array of fixed-size. This > > commit changes the implementation by replacing

Re: [PATCH] staging: xillybus: Move out of staging

Hello, Dan. Thanks a lot for reviewing the driver. There are indeed a few things that need fixing. I'll be back with patches and responses in a matter of a few days. As for the --strict option, I wasn't aware of it. I learn something new every time. :) Thanks again, Eli On 01/09/14 15:

Re: [PATCH] staging: xillybus: Move out of staging

On Mon, 2014-09-01 at 15:13 +0300, Dan Carpenter wrote: > Pretty nice. This is very special purpose hardware and the UAPI for > this is fine. The documentation seems good. I had some minor style > comments but nothing major stands out. > > These days I quite like the --strict option for checkpa

[PATCH 1/2] imx-drm: ipuv3-plane: fix ipu_plane_dpms()

When unbinding imx-drm, the following oops was observed: Unable to handle kernel NULL pointer dereference at virtual address 0004 pgd = e995c000 [0004] *pgd=4fea5831 Internal error: Oops: 817 [#1] SMP ARM Modules linked in: bnep rfcomm bluetooth nfsd exportfs hid_cypress brcmfmac brcmutil

[PATCH 2/2] imx-drm: imx-ldb: fix NULL pointer in imx_ldb_unbind()

When trying to unbind imx-drm, the following oops was observed from the imx-ldb driver: Unable to handle kernel NULL pointer dereference at virtual address 001c pgd = de954000 [001c] *pgd=2e92c831, *pte=, *ppte= Internal error: Oops: 17 [#1] SMP ARM Modules linked in: bnep

[PATCH 0/2] Two imx-drm oops fixes

Greg, Here's two oops fixes for imx-drm, which I've had queued up for a number of months now. Shawn posted different fixes for the same oops recently as well. drivers/staging/imx-drm/imx-ldb.c | 3 +++ drivers/staging/imx-drm/ipuv3-plane.c | 3 ++- 2 files changed, 5 insertions(+), 1 deleti

Re: your mail

No subject. It should be a subject about adding spaces. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH - resend] checkpatch: Remove unnecessary + after {8,8}

There's a useless "+" use that needs to be removed as perl 5.20 emits a "Useless use of greediness modifier '+'" message each time it's hit. Reported-by: Greg KH Signed-off-by: Joe Perches --- Resending, maybe Andrew's all-seeing eye blinked... On Fri, 2014-07-11 at 19:05 -0700, Greg KH wrote:

Re: [PATCH] staging: lustre: lov_pack: fix coding style issue

On Mon, 2014-09-01 at 23:52 +0800, sunwxg wrote: > Fix the style error checking by checkpatch.pl > ERROR: space required after that ',' [] > diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c > b/drivers/staging/lustre/lustre/lov/lov_pack.c [] > @@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int le

[PATCH] staging: lustre: lov_pack: fix coding style issue

From: Sun Wang Fix the style error checking by checkpatch.pl ERROR: space required after that ',' Signed-off-by: Sun Wang --- drivers/staging/lustre/lustre/lov/lov_pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/driver

[no subject]

From: Sun Wang Subject: [PATCH] staging: lustre: lov_pack: fix coding style issue Fix the style error checking by checkpatch.pl ERROR: space required after that ',' Signed-off-by: Sun Wang --- drivers/staging/lustre/lustre/lov/lov_pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 8/8] staging: rtl8188eu: Rename Hal8188EPwrSeq.h to pwrseq.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/pwrseq.c |2 +- drivers/staging/rtl8188eu/include/Hal8188EPwrSeq.h | 341 drivers/staging/rtl8188eu/include/pwrseq.h | 341 drivers/staging/rtl8188eu/include/rtl8188

[PATCH 7/8] staging: rtl8188eu: Hal8188EPwrSeq.h: fix lines over 80 char

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/Hal8188EPwrSeq.h | 411 ++-- 1 file changed, 288 insertions(+), 123 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/Hal8188EPwrSeq.h b/drivers/staging/rtl8188eu/include/Hal8188EPwrSeq.h index fabb20

[PATCH 5/8] staging: rtl8188eu: Rename HalPwrSeqCmd.c to pwrseqcmd.c

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile |2 +- drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c | 123 -- drivers/staging/rtl8188eu/hal/pwrseqcmd.c| 123 ++ 3 files changed, 124 insertions(+), 124 deletio

[PATCH 6/8] staging: rtl8188eu: Rename HalPwrSeqCmd.h to pwrseqcmd.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/pwrseqcmd.c |2 +- drivers/staging/rtl8188eu/include/Hal8188EPwrSeq.h |2 +- drivers/staging/rtl8188eu/include/HalPwrSeqCmd.h | 90 drivers/staging/rtl8188eu/include/pwrseqcmd.h | 90 +

[PATCH 4/8] staging: rtl8188eu: Rename Hal8188EPwrSeq.c to pwrseq.c

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile |2 +- drivers/staging/rtl8188eu/hal/Hal8188EPwrSeq.c | 102 drivers/staging/rtl8188eu/hal/pwrseq.c | 102 3 files changed, 103 insertions(+), 103 delet

[PATCH 3/8] staging: rtl8188eu: HalPwrSeqCmd.h: Remove unnecessary comments.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/HalPwrSeqCmd.h | 108 +++--- 1 file changed, 35 insertions(+), 73 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/HalPwrSeqCmd.h b/drivers/staging/rtl8188eu/include/HalPwrSeqCmd.h index fc24ce4..980

[PATCH 2/8] staging: rtl8188eu: Hal8188EPwrSeq.c: fix lines over 80 characters.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/Hal8188EPwrSeq.c | 46 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/Hal8188EPwrSeq.c b/drivers/staging/rtl8188eu/hal/Hal8188EPwrSeq.c index fc23bf1..4c29e63

[PATCH 1/8] staging: rtl8188eu: Rework function HalPwrSeqCmdParsing()

Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c | 64 +- drivers/staging/rtl8188eu/hal/usb_halinit.c | 12 +++- drivers/staging/rtl8188eu/include/HalPwrSeqCmd.h |4 +- 3 files changed

[PATCH] staging: dgnc: split two assignments into the two assignments on two lines.

split two assignments into the two assignments on two lines. CC: Lidza Louina CC: Mark Hounschell Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/TODO |2 -- drivers/staging/dgnc/dgnc_cls.c| 15 ++- drivers/staging/dgnc/dgnc_driver.c | 10 ++ drive

[PATCH] staging: comedi: ni_at_a2150: range check board index

The "ni_at_a2150" driver determines the board type by calling `a2150_probe()`. This reads a register and converts it to a board index in the range 0 to 3. However, the board table array it indexes into (`a2150_boards[]`) only has 2 entries. Return an error from the Comedi driver "attach" handler

[PATCH] android: fix reference leak in sync_fence_create

According to the documentation sync_fence_create takes ownership of the point, not a reference on the point. This fixes a memory leak introduced in 3.17's android fence rework. Signed-off-by: Maarten Lankhorst Cc: Colin Cross Cc: Dan Carpenter --- drivers/staging/android/sync.c | 1 - 1 file

Re: [PATCH 2/2] android: add sync_fence_create_dma

On Mon, Sep 01, 2014 at 02:33:59PM +0200, Maarten Lankhorst wrote: > Hey, > > Op 28-08-14 om 13:57 schreef Dan Carpenter: > > On Thu, Aug 28, 2014 at 08:54:05AM +0200, Maarten Lankhorst wrote: > >> Hey, > >> > >> On 15-08-14 08:46, Greg Kroah-Hartman wrote: > >>> On Thu, Aug 14, 2014 at 11:54:52AM

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

On Sun, 2014-08-31 at 13:02 -0700, Greg Kroah-Hartman wrote: > Adding Alan Cox, as he pushed this driver upstream... It's sort of a false positive. The existing code will work fine. Arguably all of this should be using the dma_ APIs. Alan ___ devel

Re: [PATCH 2/2] android: add sync_fence_create_dma

Hey, Op 28-08-14 om 13:57 schreef Dan Carpenter: > On Thu, Aug 28, 2014 at 08:54:05AM +0200, Maarten Lankhorst wrote: >> Hey, >> >> On 15-08-14 08:46, Greg Kroah-Hartman wrote: >>> On Thu, Aug 14, 2014 at 11:54:52AM +0200, Maarten Lankhorst wrote: This allows users of dma fences to create a a

Re: [PATCH] staging: xillybus: Move out of staging

On 2014-08-31 at 09:57:01 +0200, Eli Billauer wrote: > This driver has been functional and stable throughout the year it has spent > in the staging area. It has been patched for minor bugs, coding style issues > and improvements during this period, so I suppose its time has come. > > I shall cont

Re: [PATCH] staging: xillybus: Move out of staging

Pretty nice. This is very special purpose hardware and the UAPI for this is fine. The documentation seems good. I had some minor style comments but nothing major stands out. These days I quite like the --strict option for checkpatch.pl. for i in $(find drivers/staging/xillybus/ -name \*\.c)

Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c

>> > Same comments as the previous ones, please redo all of these patches. >> > >> Should all the alterations be in one big single patch, insted of small ones? > > Your first version broke the build if we applied only the first patch. > That's not allowed. I now understand that, thank you. > Also

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

On Mon, Sep 01, 2014 at 12:35:14PM +0300, Dan Carpenter wrote: > On Sun, Aug 31, 2014 at 09:46:22PM +0530, Sudip Mukherjee wrote: > > @@ -133,9 +134,15 @@ static ssize_t goldfish_audio_read(struct file *fp, > > char __user *buf, > > AUDIO_READ_BUFFER_AVA

[PATCH 20/28] staging: comedi: amplc_pci230: make `intr_running` a bitfield

Change the `intr_running` member of `struct pci230_private` into a single-bit bitfield of type `bool` to save a bit of space. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/come

[PATCH 23/28] staging: comedi: amplc_pci230: reduce indentation in pci230_ao_inttrig_scan_begin()

Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c index 727de3d..a44b056 10064

[PATCH 27/28] staging: comedi: amplc_pci230: change pci230_handle_ao_fifo() return type

Change the return type of `pci230_handle_ao_fifo()` from `int` to `bool`. A return value of `true` indicates the AO command is still running. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) di

[PATCH 25/28] staging: comedi: amplc_pci230: reduce indentation in pci230_ai_inttrig_convert()

Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 54 +-- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c index e0b40b3..b0313c8 10064

[PATCH 22/28] staging: comedi: amplc_pci230: rewrite shared resource handling

Some counter channels may be required for AI commands and AO commands. Depending on how the commands are set up, it may not be possible to run both at the same time, so we keep some state and code to find out if the required resources are busy or not. The existing code is a bit unwieldy - the code

[PATCH 21/28] staging: comedi: amplc_pci230: replace `state` member with bitfields

The `state` member of `struct pci230_private` is used with the atomic bit-op functions and has a couple of bits defined, `AI_CMD_STARTED` and `AO_CMD_STARTED`. Spin-locks are used to protect the clearing of these bits and other stuff. No special protection is used for setting these bits. Replace

[PATCH 28/28] staging: comedi: amplc_pci230: simplify interrupt enable handling

`struct pci230_private` has two members to manage the enabled interrupt sources. `int_en` is the interrupt sources we want to be enabled and `ier` is a shadow of the write-only interrupt enable register. They have the same value most of the time. They differ in the interrupt handler (`pci230_int

[PATCH 16/28] staging: comedi: amplc_pci230: remove 'inline'

Some functions in "amplc_pci230.c" are declared `inline`. Remove the `inline` specifiers and let the compiler do what it wants with them. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-)

[PATCH 26/28] staging: comedi: amplc_pci230: reduce indentation in pci230_ai_start()

Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 229 +- 1 file changed, 112 insertions(+), 117 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c index b0313c8..27ff5be 100

[PATCH 24/28] staging: comedi: amplc_pci230: reduce indentation in pci230_ao_start()

Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 113 -- 1 file changed, 54 insertions(+), 59 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c index a44b056..e0b40b3 10064

[PATCH 04/28] staging: comedi: amplc_pci230: collapse some 'else { if' chains

Where the only thing in an `else { ... }` block is another `if` statement, collapse it to an `else if {` block where it makes sense to do so. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 55 +++ 1 file changed, 22 insertions(+), 33 deletio

[PATCH 06/28] staging: comedi: amplc_pci230: no need to manipulate PCI ref count

This driver no longer supports a "legacy" attach mechanism that searches for a suitable PCI device and increments it's reference count, but since the common "detach" handler `pci230_detach()` still has a left-over `pci_dev_put()`, a matching `pci_dev_get()` is needed in the "auto_attach" handler `p

[PATCH 15/28] staging: comedi: amplc_pci230: simplify pci230_ai_read()

`pci230_ai_read()` reads a sample from the ADC data register and converts it to a comedi sample value. The AI sample may have 12 or 16 bits of resolution, depending on the board type, but 12-bit sample values are in bits 15 to 4 of the register. The hardware value is signed, 2's complement if set

[PATCH 14/28] staging: comedi: amplc_pci230: simplify pci230_ao_mangle_datum()

`pci230_ao_mangle_datum()` converts comedi sample values for the AO subdevice to hardware register values. The comedi sample value will be an unsigned value in the range 0 to 4095 (assuming 12-bit resolution). The hardware wants the value shifted so the m.s. bit of the sample in in bit 15. If set

[PATCH 09/28] staging: comedi: amplc_pci230: no need to comedi_set_hw_dev() here

The comedi core module calls `comedi_set_hw_dev()` to associate the hardware `struct device` with the `struct comedi_device` before it calls the comedi driver's "auto_attach" hook `pci230_auto_attach()`. There is no need for `pci230_auto_attach()` to call `comedi_set_hw_dev()` itself, so remove th

[PATCH 10/28] staging: comedi: amplc_pci230: absorb pci230_alloc_private()

`pci230_alloc_private()` is now only called from `pci230_auto_attach()` to allocate private device storage and initialize various spin-lock members therein. Absorb the body of `pci230_alloc_private()` into `pci230_auto_attach()` itself. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drive

[PATCH 19/28] staging: comedi: amplc_pci230: use comedi_range_is_bipolar()

Use the inline `comedi_range_is_bipolar()` function from "comedidev.h" to decide whether a range is bipolar or unipolar instead of using the local static arrays `pci230_ai_bipolar[]` and `pci230_ao_bipolar[]` which can then be removed. Change the types of the `ai_bipolar` and `ao_bipolar` members

[PATCH 03/28] staging: comedi: amplc_pci230: remove some unnecessary parentheses

Remove some pairs of parentheses that don't really improve readability. Also, reduce the amount of leading whitespace in a few places. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 75 +-- 1 file changed, 36 insertions(+), 39 deletions(-)

[PATCH 12/28] staging: comedi: amplc_pci230: remove ao_chans member

The PCI230(+) has an AO subdevice with 2 channels, but the PCI260(+) has none. The `ao_chans` member of `struct pci230_board` indicates whether the board has an AO subdevice and the number of AO channels. The `ao_bits` member indicates the AO sample width in bits and will only be non-zero for boa

[PATCH 18/28] staging: comedi: amplc_pci230: add `pci230_` prefix to functions

Most functions in "amplc_pci230" are named with the prefix `pci230_`, apart from one or two that have the prefix `amplc_pci230_` and a few odd-balls with no particular prefix. Rename the ones without a prefix for consistency. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pc

[PATCH 08/28] staging: comedi: amplc_pci230: absorb pci230_attach_common()

`pci230_attach_common()` is now only called from `pci230_auto_attach()`, so absorb it into that function. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 48 --- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/drivers/staging/

[PATCH 17/28] staging: comedi: amplc_pci230: rename pci230_ai_rinsn()

Rename the AI subdevice "insn_read" handler function `pci230_ai_rinsn()` to `pci230_ai_insn_read()` for consistency. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/driv

[PATCH 11/28] staging: comedi: amplc_pci230: remove ai_chans member

All boards supported by the "amplc_pci230" driver have 16 AI channels, so the `ai_chans` member of `struct pci230_board` is superfluous and can be removed. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) dif

[PATCH 13/28] staging: comedi: amplc_pci230: shrink struct pci230_board

The `ai_bits`, `ao_bits`, and `min_hwver` members of `struct pci230_board` are only set to small, non-negative values, so make them `unsigned char`. The `have_dio` member is used as a boolean so change it to a bitfield of type `bool`. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers

[PATCH 05/28] staging: comedi: amplc_pci230: remove "legacy" attach mechanism

The "amplc_pci230" driver currently retains the legacy attach mechanism to allow devices to be attached manually via the `COMEDI_DEVCONFIG` ioctl. The only real use for this is to pretend that a PCI230+ or PCI260+ is a PCI230 or PCI260 for backwards compatibility, as they have different number of

[PATCH 07/28] staging: comedi: amplc_pci230: set detach handler to comedi_pci_detach()

Since the comedi driver's "detach`" handler `pci230_detach()` now merely calls `comedi_pci_detach()` with the same parameter, use `comedi_pci_detach()` itself as the "detach" handler. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 7 +-- 1 file changed, 1 inser

[PATCH 02/28] staging: comedi: amplc_pci230: don't use multiple blank lines

Fix checkpatch issues: "CHECK: Please don't use multiple blank lines". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c

[PATCH 01/28] staging: comedi: amplc_pci230: update MODULE_DESCRIPTION()

Replace the generic, Comedi low-level driver module description string with something more specific. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/dr

[PATCH 00/28] staging: comedi: more clean-up and remove legacy attach

Continue to clean up the amplc_pci230 driver code and remove the legacy attach mechanism, since it isn't very useful for this driver (see PATCH 05/28). 01) staging: comedi: amplc_pci230: update MODULE_DESCRIPTION() 02) staging: comedi: amplc_pci230: don't use multiple blank lines 03) staging: come

Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c

On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote: > > Same comments as the previous ones, please redo all of these patches. > > > Should all the alterations be in one big single patch, insted of small ones? Your first version broke the build if we applied only the first patch. That'

Re: [PATCH 0/4] staging: comedi: hwdrv_apci1500: coding style cleanups

On 2014-09-01 04:37, Chase Southwood wrote: This patchset begins by removing unneeded braces and commented out lines of code, and then tidies whitespace issues that are revealed after the braces/dead code is removed. Chase Southwood (4): staging: comedi: hwdrv_apci1500: remove unneeded braces

Re: [PATCH] staging: comedi: hwdrv_apci3501: change printk to dev_err

On 2014-09-01 04:36, Chase Southwood wrote: dev_err() is preferred to printk() in device drivers. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Review

Re: [PATCH] staging: lustre: lnet: lib-ptl.c: sparsa warning: symbol not declared

On Sun, Aug 31, 2014 at 03:23:35PM +0530, Sudip Mukherjee wrote: > fixed sparse warning of following symbol not declared: > warning: symbol 'lnet_ptl_cleanup' was not declared. Should it be static? > warning: symbol 'lnet_ptl_setup' was not declared. Should it be static? > > > > Signed-off-by: S

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

On Sun, Aug 31, 2014 at 09:46:22PM +0530, Sudip Mukherjee wrote: > @@ -133,9 +134,15 @@ static ssize_t goldfish_audio_read(struct file *fp, char > __user *buf, > AUDIO_READ_BUFFER_AVAILABLE); > > /* copy data to user space */ > -

Re: [PATCH 2/2] staging: dgnc: Replace fixed-size board array with list

On Sun, Aug 31, 2014 at 11:23:58PM +0200, Konrad Zapalowicz wrote: > Each registered board is asigned a data structure to keep it's state. > So far this was implemented using the static array of fixed-size. This > commit changes the implementation by replacing the array with dynamic > solution base

Re: [PATCH] staging: comedi: usbduxsigma: fix more sparse endianness warnings

On 2014-09-01 10:23, Ian Abbott wrote: On 2014-08-31 20:45, Chase Southwood wrote: Sparse shows a couple of warnings like: drivers/staging/comedi/drivers/usbduxsigma.c:787:23: warning: cast to restricted __be32 Looking at the indicated lines shows that the issue is caused by an incorrect cast

Re: [PATCH] staging: comedi: hwdrv_apci035: remove useless return statement

On 2014-09-01 04:35, Chase Southwood wrote: Checkpatch pointed out a void function with a return statement. It can be removed. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c | 2 -- 1 file changed, 2 deletio

Re: [PATCH] staging: comedi: usbduxsigma: fix more sparse endianness warnings

On 2014-08-31 20:45, Chase Southwood wrote: Sparse shows a couple of warnings like: drivers/staging/comedi/drivers/usbduxsigma.c:787:23: warning: cast to restricted __be32 Looking at the indicated lines shows that the issue is caused by an incorrect cast to uint32_t instead of __be32. Fix thi

[PATCH v2 3/3] staging: iio: light: isl29018: add ACPI support

Add support for enumerating the device through ACPI. Signed-off-by: Laurentiu Palcu --- Changes in v2: * fix the unnecessary casting from const char * to char * and back; Thank you Jonathan for the reviews, laurentiu drivers/staging/iio/light/isl29018.c | 46 +++--

Re: [PATCH] staging: comedi: usbdux: fix more sparse endianness warnings

On 2014-08-31 20:44, Chase Southwood wrote: Sparse shows a couple of warnings like: drivers/staging/comedi/drivers/usbdux.c:889:20: warning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers/usbdux.c:889:20:expected unsigned short [unsigned] [short] [userty

Re: your mail

On Mon, Sep 01, 2014 at 03:34:56PM +0800, sunwxg wrote: > From: Sun Wang > > Subject: [PATCH] staging: unisys: visorutil: procobjecttree: fix coding style > issue > Your email headers are mangled. The subject is vague. regards, dan carpenter ___

[no subject]

From: Sun Wang Subject: [PATCH] staging: unisys: visorutil: procobjecttree: fix coding style issue Coding style issues, the changes include: -Remove '{}' Signed-off-by: Sun Wang --- drivers/staging/unisys/visorutil/procobjecttree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v3 07/11] wireless: hostap: proc: print properly escaped SSID

On Wed, 2014-08-20 at 12:42 +0300, Andy Shevchenko wrote: > Instead of substituting non-printable characters by '_' let's print SSID > properly escaped by using recently added %*pE specifier. Here is kbuild robot fixup. >From f88ff364a1b117d3c86186206eeaa54ff906147a Mon Sep 17 00:00:00 2001 From: