Involvement in Linux Project needed

Hello All, I have recently joined Linux driver project and wanted to cointribute into it and Please let me know the process how i can start working and contributing in Linux existing driver project. Regards Sanjeev Sharma ___ devel mailing list de...@li

Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation

On Tuesday 29 July 2014 02:47 PM, Dan Carpenter wrote: > On Tue, Jul 29, 2014 at 10:05:38AM +0200, Tobias Klauser wrote: > >> Wouldn't it be better to annotate the data member in struct tagSCmdRequest >> with __user instead of introducing all these casts? Hi, Yes, having the data member annotate

RE: [PATCH 00/19] staging: comedi: amplc_pci230: tidy up a bit

On Tuesday, July 29, 2014 4:58 AM, Ian Abbott wrote: > > Tidy up the "amplc_pci230" driver a bit. There are more changes to come > after this. The only one of these that should alter the object code is > patch 06, which replaces a udelay() call with usleep_range(). > > 01) staging: comedi: amplc

RE: [PATCH 13/19] staging: comedi: amplc_pci230: remove unnecessary braces

On Tuesday, July 29, 2014 4:58 AM, Ian Abbott wrote: > Signed-off-by: Ian Abbott > --- > drivers/staging/comedi/drivers/amplc_pci230.c | 151 > ++ > 1 file changed, 58 insertions(+), 93 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c > b/driv

[PATCH v5 0/4] Staging: rts5208: Use standard debug features

Use standard debug features instead of relying on the custom configuration option CONFIG_RTS5208_DEBUG and a series of home grown macros. Changes in v5: * remove useless prints used just to mark when entering a function (we should prefer ftrace for that) Changes in v4: * use dev_dbg instead of

[PATCH v5 2/4] Staging: rts5208: Replace custom macro with dev_dbg

Use dev_dbg macro to control tracing verbosity through dynamic debug facility. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/debug.h | 43 --- drivers/staging/rts5208/ms.c | 102 + drivers/staging/rts5208/rtsx.c | 6 +- drivers/stag

[PATCH v5 3/4] Staging: rts5208: Use dev_dbg and %*ph specifier to dump memory

Use dev_dbg with %*ph format specifier to dump memory instead of relying on custom macro. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c | 7 +++ drivers/staging/rts5208/sd.c

[PATCH v5 4/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option

CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options instead. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/Kconfig | 7 --- drivers/staging/rts5208/sd.c| 5 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rts5208/

[PATCH v5 1/4] Staging: rts5208: Remove useless debug prints

Remove all debug printks used just to mark when we enter a function. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 24 drivers/staging/rts5208/rtsx_scsi.c | 4 2 files changed, 28 deletions(-) diff --git a/drivers/staging/rts5208/ms.c b/dri

[PATCH 01/26] staging: comedi: add an 'mmio' member to comedi_device

All the comedi drivers that use memory mapped io currently have a void __iomem * member in their private data for the driver. For some of the drivers this is actually the only member in that data. For convienence, add a new member to the comedi_device for this void __iomem *. Signed-off-by: H Har

[PATCH 20/26] staging: comedi: ni_labpc: pass comedi_device to the I/O callbacks

This driver uses some callbacks in the private data to handle the port mapped or memory mapped I/O used to access the hardware. Pass the comedi_device pointer to the helper functions so that the base address can be found and does not need to be included in each call. Also, remove the inline from

[PATCH 26/26] staging: comedi: amplc_dio200: use the comedi_device 'mmio' member

The amplc_dio200_common module currently uses a union in the private data to determine if the hardware uses port or memory mapped I/O. Use the new 'mmio' member in the comedi_device for the ioremap'ed base address and remove all the union code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc

[PATCH 25/26] staging: comedi: ii_pci20kc: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the __iomem * base address. Since this was the only member in the private data, remove the struct and its allocation. This legacy driver is a bit strange. The base address of the board is passed to the (*attach) using by the user using the comedi

[PATCH 05/26] staging: comedi: me_daq: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me_daq.c | 67 +++-- 1 file changed, 31 insertions(+), 36 deletions(-) diff --g

[PATCH 23/26] staging: comedi: ni_labpc: refactor labpc_8255_mmio()

Refactor the 8255 support code in preperation for using the comedi_device 'mmio' member. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a

[PATCH 19/26] staging: comedi: mite: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed 'daq_io_addr'. Move the iounmap of this address from mite_detach() to the drivers that use the mite module. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mite.c

[PATCH 07/26] staging: comedi: icp_multi: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/icp_multi.c | 80 +- 1 file changed, 35 insertions(+), 45 deletions(-) diff --g

[PATCH 12/26] staging: comedi: ni_6527: iounmap resource when detached

PCI bar 1 is ioremap'ed during the (*auto_attach). This resource needs to be iounmap'ed when the driver is (*detach)ed. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_6527.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driv

[PATCH 08/26] staging: comedi: addi_apci_3xxx: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi_apci_3xxx.c | 68 +++-- 1 file changed, 29 insertions(+), 39 deletions(-) diff --g

[PATCH 24/26] staging: comedi: ni_labpc: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Only the ni_labpc_pci module does the ioremap, its also the only module that sets the 'has_mmio' member in the boardinfo. Remove this member from the boardinfo and use dev->mmio to determine if the I/O is memory mapped

[PATCH 02/26] staging: comedi: 8255_pci: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Since this was the only member in the private data, remove the struct and its allocation. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/8255_pci.c | 21 +

[PATCH 15/26] staging: comedi: rtd520: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address of PCI bar 2. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 195 +++- 1 file changed, 91 insertions(+), 104 deletion

[PATCH 21/26] staging: comedi: ni_labpc: don't pass dev->iobase to labpc_counter_load()

Use the comedi_device parameter that is passed to this function to find the dev->iobase so it does not have to be included in each call. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc.c | 20 ++-- 1 file change

[PATCH 17/26] staging: comedi: mite: inline mite_setup()

This exported function simply calls mite_setup2() with the 'use_iodsbsr_1' parameter set to 0. Inline the simple function and remove the EXPORT_SYMBOL_GPL. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mite.c | 6 -- drivers/stag

[PATCH 11/26] staging: comedi: ni_6527: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_6527.c | 85 +--- 1 file changed, 33 insertions(+), 52 deletions(-) diff --g

[PATCH 10/26] staging: comedi: dt3000: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt3000.c | 104 ++-- 1 file changed, 44 insertions(+), 60 deletions(-) diff --g

[PATCH 00/26] staging: comedi: tidy up memory mapped I/O

Some of the comedi drivers use memory mapped I/O. Currently all of these drivers save the ioremap'ed base address in their private data. Add a new member, 'mmio' to the comedi_device struct so the drivers don't need to carry it in the private data. For some drivers this allows removing the private

[PATCH 09/26] staging: comedi: daqboard2000: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/daqboard2000.c | 76 +++ 1 file changed, 31 insertions(+), 45 deletions(-) diff --g

[PATCH 16/26] staging: comedi: s626: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/s626.c | 194 +++--- 1 file changed, 88 insertions(+), 106 deletions(-) diff --

[PATCH 04/26] staging: comedi: gsc_hpdi: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/gsc_hpdi.c | 44 ++- 1 file changed, 20 insertions(+), 24 deletions(-) diff --g

[PATCH 22/26] staging: comedi: ni_labpc: don't pass dev->iobase to labpc_counter_set_mode()

Use the comedi_device parameter that is passed to this function to find the dev->iobase so it does not have to be included in each call. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc.c | 17 +++-- 1 file changed,

[PATCH 18/26] staging: comedi: mite: pass comedi_device to mite_setup()

For aesthetics, pass the comedi_device to mite_setup() and mite_setup2() so that the dev->class_dev can be used in the dev_{level} message to make the messages have consistancy with the other comedi drivers. Remove the extra dev_warn() noise in the drivers when mite_setup() fails. Rename the 'use

[PATCH 06/26] staging: comedi: mf6x4: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mf6x4.c | 47 +++--- 1 file changed, 21 insertions(+), 26 deletions(-) diff --g

[PATCH 14/26] staging: comedi: cb_pcidas64: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address of PCI bar 3. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 41 ++-- 1 file changed, 14 insertions(+), 27 deletions

[PATCH 03/26] staging: comedi: ni_65xx: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Since this was the only member in the private data, remove the struct and its allocation. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_65xx.c | 80 ++

[PATCH 13/26] staging: comedi: ni_670x: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed base address. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_670x.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a

Re: [PATCH 2/2] staging/nvec: Use platform_get_irq()

Am Dienstag 29 Juli 2014, 13:16:15 schrieb Thierry Reding: > From: Thierry Reding > > As opposed to platform_get_resource(), the platform_get_irq() function > has special code to handle driver probe deferral when booting using DT > and where an interrupt provider hasn't been registered yet. While

Re: [PATCH 1/2] staging/nvec: Do not pass resource to mfd_add_devices()

Am Dienstag 29 Juli 2014, 13:16:14 schrieb Thierry Reding: > From: Thierry Reding > > The mfd_add_devices() function takes a struct resource * as fifth > argument, but the nvec driver passes in a void __iomem *. The driver > gets away with it because none of the subdevices ever directly access >

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

> "KY" == KY Srinivasan writes: KY> We will fix this bug in the next release of Windows; we are also KY> looking at backporting the fix to prior versions of Windows. Excellent. Thanks for looking into this! -- Martin K. Petersen Oracle Linux Engineering ___

[PATCH 3/8] staging: unisys: remove U32 type

This patch switches all use of the U32 typedef to use the kernel's u32 type instead. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/channels/channel.c | 8 +- drivers/staging/unisys/channels/chanstub.c | 4 +- drivers/staging/unisys/channels/chanstub.h |

[PATCH 4/8] staging: unisys: remove U64 type

This patch switches all use of the U64 typedef to use the kernel's u64 type instead. Signed-off-by: Benjamin Romer --- .../unisys/common-spar/include/channels/channel.h | 42 ++--- .../include/channels/controlframework.h| 2 +- .../include/channels/controlvmchannel.

[PATCH 7/8] staging: unisys: remove S32 type

Delete the S32 type from commontypes.h since it wasn't being used. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/commontypes.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/include/commontypes.h b/drivers/staging/unisys/include/commontypes.h index

[PATCH 1/8] staging: unisys: remove U8 type

This patch switches all use of the U8 typedef to use the kernel's u8 type instead. Signed-off-by: Benjamin Romer --- .../unisys/common-spar/include/channels/channel.h | 54 +- .../include/channels/controlframework.h| 4 +- .../include/channels/controlvmchannel.h

[PATCH 6/8] staging: unisys: remove S16 type

This patch switches all use of the S16 typedef to use the kernel's s16 type instead. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/channels/diagchannel.h | 2 +- drivers/staging/unisys/include/commontypes.h | 1 - 2 files changed, 1 insertion(+

[PATCH 8/8] staging: unisys: remove S64 type

This patch switches all use of the S64 typedef to use the kernel's s64 type instead. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/commontypes.h | 2 -- drivers/staging/unisys/include/uisutils.h| 4 ++-- drivers/staging/unisys/visorchipset/file.c | 4 ++-- 3 files change

[PATCH 0/8] staging: unisys: remove locally defined types

The include/commontypes.h file defines many types locally when the kernel's existing types should have been used instead. This patch series converts all of the U8 through U64 and S8 through S64 types, and removes the extraneous type definition. Benjamin Romer (8): staging: unisys: remove U8 type

[PATCH 5/8] staging: unisys: remove S8 type

Delete the S8 type from commontypes.h since it wasn't being used. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/commontypes.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/include/commontypes.h b/drivers/staging/unisys/include/commontypes.h index 2

[PATCH 2/8] staging: unisys: remove U16 type

This patch switches all use of the U16 typedef to use the kernel's u16 type instead. Signed-off-by: Benjamin Romer --- .../include/channels/controlframework.h| 18 .../include/channels/controlvmchannel.h| 24 +++--- .../common-spar/include

[PATCH] staging: vt6655: Fix device table definition.

From: Fernando Apesteguia Add static to the definition of the pci device table. Signed-off-by: Fernando Apesteguia --- drivers/staging/vt6655/device_main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/devi

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

> -Original Message- > From: James Bottomley [mailto:jbottom...@parallels.com] > Sent: Monday, July 28, 2014 1:03 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; h...@infradead.org; sits...@gmail.com; > de...@linuxdriverproject.org; a...@canonical.com; > martin.peter...@oracle.

Re: [PATCH 02/19] staging: comedi: ni_tio: tidy up Gi_Counting_Mode_Reg_Bits

On 2014-07-29 17:04, Hartley Sweeten wrote: On Tuesday, July 29, 2014 2:22 AM, Ian Abbott wrote: I see the original function was inline as well, so maybe that should be a separate patch to remove the inlines. As you noted, the original was inline. I plan on removing these. I renamed the funct

RE: [PATCH 02/19] staging: comedi: ni_tio: tidy up Gi_Counting_Mode_Reg_Bits

On Tuesday, July 29, 2014 2:22 AM, Ian Abbott wrote: > On 2014-07-29 10:07, Ian Abbott wrote: >> On 2014-07-28 18:26, H Hartley Sweeten wrote: >>> Convert this enum into defines and rename all the CamelCase symbols. >>> >>> For aesthetics, move the new defines so they are associated with the >>> re

Re: Question about further cleanup in staging/bcm

Your patches are ok so far. We can't ack the future patches until we see them but it sounds reasonable. I guess send them bit by bit so you don't feel bad if we ask you to redo them. On Tue, Jul 29, 2014 at 05:08:42PM +0200, Matthias Beyer wrote: > * remove developer debug BCM_DEBUG() macros >

[PATCH 1/9] drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c: use correct structure type name in sizeof

From: Julia Lawall Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used can be found in message

[PATCH 0/9] use correct structure type name in sizeof

These patches fix typos in the name of a type referenced in a sizeof command. These problems are not caught by the compiler, because they have no impact on execution - the size of a pointer is independent of the size of the pointed value. The semantic patch that finds these problems is shown belo

[PATCH 14/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in IpVersion4()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 96 --- 1 file changed, 75 insertions(+), 21 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 589bd42..747790d 100644 --- a/drivers/staging/bcm/Qos.c +++

Re: [PATCH 03/27] Staging: bcm: Qos.c: Replaced do-while(0) jumps with goto and label, removes one level of indentation

Don't resend (this could be fixed in a follow on patch, or whatever). It would be nicer to just return false directly. The label could be renamed to "found:". Don't worry that returning messes up the debugging, just delete the debug output because it is nonsense anyway. regards, dan carpenter _

Question about further cleanup in staging/bcm

Hi, I just send my last patchset for the files in staging/bcm, so my first iteration is ready. I want to do more cleanup in this part of the kernel, I hope it is desired. My next steps would be: 1) I would like to start renaming variables inside functions and static functions for the se

[PATCH 1/2] staging: unisys: remove parahotplug proc entry

Remove the parahotplug proc code entirely in preparation for replacement with sysfs entries. Since visorchipset_proc_read_writeonly() is orphaned by the removal, it is removed as well. Signed-off-by: Benjamin Romer --- v6: the patch was split into remove and rewrite parts, instead of trying to mo

[PATCH 2/2] staging: unisys: add sysfs entries for parahotplug support

This patch adds new a new directory parahotplug to the visorchipset sysfs directory, and two new attributes, deviceenabled, and devicedisabled, into the new directory, to add s-Par parahotplug support. The parahotplug interface is used to deal with SR-IOV recovery situations on s-Par guest partiti

[PATCH 27/27] Staging: bcm: Qos.c: checkpatch.pl fix: Indentation of case-statements fixed

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 86 ++- 1 file changed, 41 insertions(+), 45 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index d4c9a09..b3ac614 100644 --- a/drivers/staging/bcm/Qos.c +++

[PATCH 15/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in PruneQueue()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 50 +++ 1 file changed, 37 insertions(+), 13 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 747790d..4bba0a9 100644 --- a/drivers/staging/bcm/Qos.c +++

[PATCH 13/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchDestPort()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 0f733f9..589bd42 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qo

[PATCH 16/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in flush_all_queues()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 4bba0a9..1608ba4f 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos.

[PATCH 10/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchTos()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 9465817..b24ee8a 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos.c @@ -1

[PATCH 11/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchProtocol()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index b24ee8a..891f690 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos.

[PATCH 12/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchSrcPort()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 891f690..0f733f9 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos.c @@ -1

[PATCH 24/27] Staging: bcm: Qos.c: checkpatch.pl fix: Added blank lines after declarations

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index f8eb3fe..80c5c65 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos.c @@ -396,6 +396,7 @@ static USHORT

[PATCH 23/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in EThCSGetPktInfo()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 51 +-- 1 file changed, 40 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index b277ae6..f8eb3fe 100644 --- a/drivers/staging/bcm/Qos.c +++

[PATCH 22/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in EThCSClassifyPkt()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 47 +++ 1 file changed, 35 insertions(+), 12 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 3ab287e..b277ae6 100644 --- a/drivers/staging/bcm/Qos.c +++

[PATCH 08/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchSrcIpAddress()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 9455c25..f3cef86 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos.c @@ -42

[PATCH 17/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in ClassifyPacket()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 193 +++--- 1 file changed, 148 insertions(+), 45 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 1608ba4f..2176d28 100644 --- a/drivers/staging/bcm/Qos.c +

[PATCH 25/27] Staging: bcm: Qos.c: checkpatch.pl fix: Transformed C99-style comments

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 80c5c65..13cfd06 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos.c @@ -459,8 +459,8

[PATCH 20/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchEThTypeSAP()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 40 +--- 1 file changed, 33 insertions(+), 7 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index ee50481..f5f85d7 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drive

[PATCH 26/27] Staging: bcm: Qos.c: checkpatch.pl fix: Removed parentheses from return statement

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 13cfd06..d4c9a09 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos.c @@ -865,7 +865,7 @@ U

[PATCH 19/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchDestMACAdress()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 9895252..ee50481 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/

[PATCH 18/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchSrcMACAdress()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 2176d28..9895252 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Q

[PATCH 09/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchDestIpAddress()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index f3cef86..9465817 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos

[PATCH 21/27] Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchVLANRules()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 53 +-- 1 file changed, 42 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index f5f85d7..3ab287e 100644 --- a/drivers/staging/bcm/Qos.c +++

[PATCH 07/27] Staging: bcm: Qos.c: Replaced if-else return with ternary operator

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 2cc87b5..9455c25 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos.c @@ -605,10 +605,7

[PATCH 05/27] Staging: bcm: Qos.c: Replaced member accessing by variable in flush_all_queues()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index d01470f..e59abe4 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bc

[PATCH 02/27] Staging: bcm: Qos.c: Replaced member accessing with variable in MatchDestIpAddress()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 769adb7..817d115 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos.c @@ -77,15 +77,

[PATCH 01/27] Staging: bcm: Qos.c: Replaced member accessing with variable in PruneQueue()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 0eb78a8..769adb7 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/staging/bcm/Qos.c

[PATCH 04/27] Staging: bcm: Qos.c: Replaced member accessing with variable in PruneQueue()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index c4a75a8..d01470f 100644 --- a/drivers/staging/bcm/Qos.c +++ b/drivers/stagi

[PATCH 03/27] Staging: bcm: Qos.c: Replaced do-while(0) jumps with goto and label, removes one level of indentation

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 115 +++--- 1 file changed, 57 insertions(+), 58 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index 817d115..c4a75a8 100644 --- a/drivers/staging/bcm/Qos.c +++

[PATCH 06/27] Staging: bcm: Qos.c: Replaced do-while(0) breaks with continue

This patch replaces the do-while(0); loop which is used for breaking if a check fails by using the `continue` statement. This saves one indentation level. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Qos.c | 95 +++ 1 file changed, 46 insertio

[PATCH 00/27] drivers/staging/bcm/Qos.c cleanup patches

Hi, these are my patches for the drivers/staging/bcm/Qos.c file. Please review them. If you want, I can squash the "Line length / Whitespace cleanup" patches into one big patch, but I guess it is better this way, also for reviewing them. Please note, as always: As I do not have the appropr

Re: [PATCH v5] staging: unisys: move parahotplug to sysfs

On Tue, 2014-07-29 at 16:58 +0300, Dan Carpenter wrote: > > This is broken code which clearly hasn't been tested. Wat??? Oh, I think I see what you mean. When I said tested, I meant that the entries appear in sysfs instead of proc, not that they pass data anywhere or work with s-Par correctly. I

Re: [PATCH v5] staging: unisys: move parahotplug to sysfs

On Tue, Jul 29, 2014 at 08:15:38AM -0500, Romer, Benjamin M wrote: > On Tue, 2014-07-29 at 12:13 +0300, Dan Carpenter wrote: > > > This is the same bug I mentioned ealier in a different patch. > > Yes, I know that - my intent was to get this patch in to move the entry, > then fix the error in the

Re: [PATCH] staging: dgnc: removes comment related to the delete code.

On 2014-07-29 at 15:02:42 +0200, Seunghun Lee wrote: > This patch removes comment related to the delete code. > > CC: Lidza Louina > CC: Mark Hounschell > Signed-off-by: Seunghun Lee > --- > drivers/staging/dgnc/dgnc_cls.c |3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers

Re: [PATCH v5] staging: unisys: move parahotplug to sysfs

On Tue, 2014-07-29 at 12:13 +0300, Dan Carpenter wrote: > This is the same bug I mentioned ealier in a different patch. Yes, I know that - my intent was to get this patch in to move the entry, then fix the error in the function, like how the other sysfs functions got fixed. The code in this patch

[PATCH] staging: dgnc: removes comment related to the delete code.

This patch removes comment related to the delete code. CC: Lidza Louina CC: Mark Hounschell Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_cls.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c index 4b65306..

Re: [PATCH v2 0/6] drivers/staging/bcm/IPv6Protocol.c: cleanup patches

Looks good, thanks. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 4/6] Staging: bcm: IPv6Protocol.c: Replaced member accessing with variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/IPv6Protocol.c b/drivers/staging/bcm/IPv6Protocol.c index deb67b1..8a35c1f 100644 --- a/drivers/staging/bcm/IPv6Protocol.c +++ b

[PATCH v2 6/6] Staging: bcm: IPv6Protocol.c: Line length fixes

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 93 -- 1 file changed, 60 insertions(+), 33 deletions(-) diff --git a/drivers/staging/bcm/IPv6Protocol.c b/drivers/staging/bcm/IPv6Protocol.c index 01ad11f..27f3f41 100644 --- a/drivers/st

[PATCH v2 3/6] Staging: bcm: IPv6Procotol.c: Replaced member accessing with variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/IPv6Protocol.c b/drivers/staging/bcm/IPv6Protocol.c index 5bcdaf9..deb67b1 100644 --- a/drivers/staging/bcm/IPv6Protocol.c +++ b

[PATCH v2 2/6] Staging: bcm: IPv6Protocol.c: Removed unnecessary if-else blocks

This patch simplifies if (a) { x = false; } else { if (b) { x = false; } } to if (a || b) { x = false; } Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletion

[PATCH v2 0/6] drivers/staging/bcm/IPv6Protocol.c: cleanup patches

Hi, these are my patches for the drivers/staging/bcm/IPv6Protocol.c file. The suggested changes are included. I rebased onto latest HEAD of greg KHs staging-next branch. Please note: I'm not able to test these patches as I do not have the appropriate hardware, I compiled them at least. Kin

[PATCH v2 5/6] Staging: bcm: IPv6Protocol.c: Whitespace cleanup

Removes whitespace before semicolons and add blank line after declaration. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/IPv6Protocol.c b/drivers/staging/bcm/IPv6Protocol.c

[PATCH v2 1/6] Staging: bcm: IPv6Protocol.c: Reindented switch-case

This patch removes the unneccessary blocks inside the case statements and fixes the indentation of their content. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 88 +- 1 file changed, 40 insertions(+), 48 deletions(-) diff --git a/driv

  1   2   >