Yie,
Am 21.07.2014 04:44, schrieb Yue Zhang (OSTC DEV):
>> From: Richard Weinberger [mailto:richard.weinber...@gmail.com]
>> Why 10? Is this a random number which works by accident for ifplugd?
>> What about other networking implementations, is 10 also ok for them?
>> --
>> Thanks,
>> //richard
>
Herzlichen Glьckwunsch !
Ich mцchte Ihnen mitteilen zu kцnnen das neue EURO LOTTO POWER PLAY eine
Tochtergesellschaft des NEW YORK-LOTTO zieht vom Samstag, 19.Juli 2014 , im
Bundesstaat New York von denen Sie einer der glьcklichen Gewinner sind.
Ihre E-mail-Adresse an Ticket-Nummer angehдng
From: Benoit Taine
Date: Fri, 18 Jul 2014 17:26:47 +0200
> We should prefer `const struct pci_device_id` over
> `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> This issue was reported by checkpatch.
>
> A simplified version of the semantic patch that makes this change is as
>
> From: Varka Bhadram [mailto:varkabhad...@gmail.com]
> Sent: Friday, July 18, 2014 6:13 PM
>
> On 07/18/2014 04:25 PM, Yue Zhang wrote:
> > @@ -816,8 +816,21 @@ static void netvsc_link_change(struct work_struct
> *w)
> >
> > rtnl_unlock();
> >
> > - if (refresh)
> > - call_usermod
> From: Richard Weinberger [mailto:richard.weinber...@gmail.com]
> Sent: Friday, July 18, 2014 9:41 PM
>
> On Fri, Jul 18, 2014 at 12:55 PM, Yue Zhang wrote:
> > From: Yue Zhang
> >
> > This patch addresses the comment from Olaf Hering and Greg KH
> > for a previous commit 3a494e710367 ("hyperv:
Add blist flags to permit the reading of the VPD pages even when
the target may claim SPC-2 compliance. MSFT targets currently
claim SPC-2 compliance while they implement post SPC-2 features.
With this patch we can correctly handle WRITE_SAME_16 issues.
Signed-off-by: K. Y. Srinivasan
---
driver
The following changes since commit 1795cd9b3a91d4b5473c97f491d63892442212ab:
Linux 3.16-rc5 (2014-07-13 14:04:33 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.16-rc6
for you to fetch changes up to 9359003385a
On 20/07/14 17:32, Jonathan Cameron wrote:
On 16/07/14 14:07, Josef Gajdusek wrote:
This patch splits hmc5843.c to multiple files - the interface-agnostic
hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is
another step to add support of SPI-enabled hmc5983.
Signed-off
On 16/07/14 14:07, Josef Gajdusek wrote:
This patch splits hmc5843.c to multiple files - the interface-agnostic
hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is
another step to add support of SPI-enabled hmc5983.
Signed-off-by: Josef Gajdusek
Unfortunately taking t
On 16/07/14 14:07, Josef Gajdusek wrote:
This patch changes hmc5843.c to use regmap. This provides transparent caching
to the code as well as abstraction necessary to add support for SPI-based
hmc5983.
Signed-off-by: Josef Gajdusek
Applied to the togreg branch of iio.git. Will be initially pu
On Sun, Jul 20, 2014 at 08:30:23AM -0700, Joe Perches wrote:
> On Sun, 2014-07-20 at 15:22 +0200, Riccardo Lucchese wrote:
> > Make the code clearer by introducing a local variable and removing the
> > unnecessary 'if' statement.
> >
> > Signed-off-by: Riccardo Lucchese
> > Acked-by: Julia Lawall
On Sun, 2014-07-20 at 15:22 +0200, Riccardo Lucchese wrote:
> Make the code clearer by introducing a local variable and removing the
> unnecessary 'if' statement.
>
> Signed-off-by: Riccardo Lucchese
> Acked-by: Julia Lawall
> ---
> Changes in v2:
> - Improved the commit message:
> - change
An issue in 'line over 80 characters' fixed by removing over-lined comment
to the previous line.
Signed-off-by: Sam Asadi
---
drivers/staging/comedi/drivers/adv_pci1710.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c
b/dr
A 'line over 80' issue fixed, by removing comment to previous line. And
also, by this, 'a blank line' isssue resolved.
Signed-off-by: Sam Asadi
---
drivers/staging/comedi/drivers/adv_pci1710.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drive
An issue in 'line over 80 characters' fixed by removing over-lined
comment to the previous line.
Signed-off-by: Sam Asadi
---
drivers/staging/comedi/drivers/adv_pci1710.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c
b/driv
An issue in 'line over 80 characters' fixed by taking back over-lined comment
a few characters.
Signed-off-by: Sam Asadi
---
drivers/staging/comedi/drivers/adv_pci1710.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c
b/drivers
An issue in 'line over 80 characters' fixed and over-lined comment
removed to the previous line.
Signed-off-by: Sam Asadi
---
drivers/staging/comedi/drivers/adv_pci1710.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c
b/driv
By removing a comment to previous line, 'line over 80' issue
fixed.
Signed-off-by: Sam Asadi
---
drivers/staging/comedi/drivers/adv_pci1710.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c
b/drivers/staging/comedi/drivers/ad
A 'line over 80 characters' fixed by removing over-lined comment
to previous line.
Signed-off-by: Sam Asadi
---
drivers/staging/comedi/drivers/adv_pci1710.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c
b/drivers/staging/co
Fix the following checkpatch.pl issue in lov_request.c:
ERROR: space required before the open brace '{'
Signed-off-by: Riccardo Lucchese
Acked-by: Julia Lawall
---
Changes in v2:
- Changed the subject line to follow the same convention used by
previous commits to the same file.
- Added Acke
Hello,
This patch series contains one cleanup and two coding style fixes for
lov_request.c.
This iteration addresses the review comments received by v1.
Changes in v2:
- Improved the commit messages.
- Introduced a local variable in lov_check_set() to make the code clearer.
Thanks,
riccardo
Make the code clearer by introducing a local variable and removing the
unnecessary 'if' statement.
Signed-off-by: Riccardo Lucchese
Acked-by: Julia Lawall
---
Changes in v2:
- Improved the commit message:
- changed the subject line to follow the same convention used by
previous commit
Fix the following checkpatch.pl issue in lov_request.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Riccardo Lucchese
Acked-by: Julia Lawall
---
Changes in v2:
- Changed the subject line to follow the same convention used by
previous commits to the same file.
- Added Ack
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/nvm.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/nvm.c b/drivers/staging/bcm/nvm.c
index c38c803..0d197c0 100644
--- a/drivers/staging/bcm/nvm.c
+++ b/drivers/staging/bcm/nvm.c
@@ -1042,6 +1
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/nvm.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/bcm/nvm.c b/drivers/staging/bcm/nvm.c
index edbd0f9..c38c803 100644
--- a/drivers/staging/bcm/nvm.c
+++ b/drivers/staging/bcm/nvm.c
@@ -10
Hi,
these are some patches for the
drivers/staging/bcm/nvm.c
file.
Note: As I do not have the appropriate hardware, I'm not able to test these
patches. I compiled them at least.
Kind regards,
Matthias Beyer
Matthias Beyer (5):
Staging: bcm: nvm.c: Shortened lines
Staging: bcm: nvm.c:
This patch outsources a chunk of code into an own function. It also
refactors the variable names which are used within this function.
The function name may be not appropriate.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/nvm.c | 70 ---
1 fil
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/nvm.c | 64 +--
1 file changed, 40 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/bcm/nvm.c b/drivers/staging/bcm/nvm.c
index 8ce4d41..76c86eb 100644
--- a/drivers/staging/bcm/nvm.c
+++
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/nvm.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/bcm/nvm.c b/drivers/staging/bcm/nvm.c
index 4aa195c..edbd0f9 100644
--- a/drivers/staging/bcm/nvm.c
+++ b/drivers/staging/bcm
On Sun, Jul 20, 2014 at 02:37:47PM +0300, Dan Carpenter wrote:
> On Sun, Jul 20, 2014 at 01:08:36PM +0200, Riccardo Lucchese wrote:
> > Dan,
> >
> > On Sun, Jul 20, 2014 at 07:52:53AM +0300, Dan Carpenter wrote:
> > > On Sat, Jul 19, 2014 at 09:34:56PM +0200, Riccardo Lucchese wrote:
[...]
> > > I
On Sun, Jul 20, 2014 at 01:08:36PM +0200, Riccardo Lucchese wrote:
> Dan,
>
> On Sun, Jul 20, 2014 at 07:52:53AM +0300, Dan Carpenter wrote:
> > On Sat, Jul 19, 2014 at 09:34:56PM +0200, Riccardo Lucchese wrote:
> > > It is silly to go through an if statement to set a single boolean
> > > value in
Dan,
On Sun, Jul 20, 2014 at 07:52:53AM +0300, Dan Carpenter wrote:
> On Sat, Jul 19, 2014 at 09:34:56PM +0200, Riccardo Lucchese wrote:
> > It is silly to go through an if statement to set a single boolean
> > value in function of a single boolean expression. In the function
> > lov_check_set, as
On Sat, Jul 19, 2014 at 12:59:22PM -0700, Joe Perches wrote:
> On Sat, 2014-07-19 at 21:34 +0200, Riccardo Lucchese wrote:
> > It is silly to go through an if statement to set a single boolean
> > value in function of a single boolean expression. In the function
> > lov_check_set, assign the return
On 07/20/2014 05:51 PM, Chen Gang wrote:
> On 07/20/2014 05:45 PM, Richard Weinberger wrote:
>>
>>
>> Am 20.07.2014 10:38, schrieb Chen Gang:
>>> On 07/19/2014 02:02 AM, Chen Gang wrote:
> 2014-07-18 18:51 GMT+08:00 Richard Weinberger :
>> Am 18.07.2014 12:44, schrieb Chen Gang:
>>> On
On 07/20/2014 05:45 PM, Richard Weinberger wrote:
>
>
> Am 20.07.2014 10:38, schrieb Chen Gang:
>> On 07/19/2014 02:02 AM, Chen Gang wrote:
2014-07-18 18:51 GMT+08:00 Richard Weinberger :
> Am 18.07.2014 12:44, schrieb Chen Gang:
>> On 07/18/2014 03:35 PM, Richard Weinberger wrote:
>
Am 20.07.2014 10:38, schrieb Chen Gang:
> On 07/19/2014 02:02 AM, Chen Gang wrote:
>>> 2014-07-18 18:51 GMT+08:00 Richard Weinberger :
Am 18.07.2014 12:44, schrieb Chen Gang:
> On 07/18/2014 03:35 PM, Richard Weinberger wrote:
>> Am 18.07.2014 02:36, schrieb Chen Gang:
>>>
>>
On 07/20/2014 04:38 PM, Chen Gang wrote:
> On 07/19/2014 02:02 AM, Chen Gang wrote:
>>> 2014-07-18 18:51 GMT+08:00 Richard Weinberger :
Am 18.07.2014 12:44, schrieb Chen Gang:
> On 07/18/2014 03:35 PM, Richard Weinberger wrote:
>> Am 18.07.2014 02:36, schrieb Chen Gang:
>>>
>>>
Removed redundant comments in the header file wcmd.h
Signed-off-by: Igor Bezukh
---
Changes v2: I've missed another redundant comment "//ms"
so I've deleted it and added "vt6655" to the patch subject
drivers/staging/vt6655/wcmd.h | 15 ++-
1 file changed, 2 insertions(+), 13 dele
Removed redundant comments in the header file wcmd.h
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/wcmd.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/vt6655/wcmd.h b/drivers/staging/vt6655/wcmd.h
index 2844476..696916c 100644
--- a/drivers/staging/vt
On 07/19/2014 02:02 AM, Chen Gang wrote:
>> 2014-07-18 18:51 GMT+08:00 Richard Weinberger :
>>> Am 18.07.2014 12:44, schrieb Chen Gang:
On 07/18/2014 03:35 PM, Richard Weinberger wrote:
> Am 18.07.2014 02:36, schrieb Chen Gang:
>>
>> On 07/18/2014 02:09 AM, Richard Weinberger wrote
This patch fixes the errors report by the checkpatch script.
Most of them are use of C99 comments.
The checkpatch doesn't report any errors after the clean up.
However, please not that there are still ton of warnings left.
Signed-off-by: Petar Dimitrijevic
---
drivers/staging/vt6655/datarate.c
41 matches
Mail list logo
