The following changes since commit 86281966c7395aa9a13a20c52e26005f5e142451:
Merge tag 'iio-fixes-for-3.15b' of
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-linus
(2014-04-30 14:19:23 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux
Hi Greg,
Please merge this patchset, It has been pending for some time.
regards,
navin patidar
On Wed, May 7, 2014 at 9:27 AM, wrote:
> From: navin patidar
>
> Following patches remove unused functions, variables and functions with empty
> definition.
>
> navin patidar (13):
> staging: rtl8
I was already sent for this. :-)
https://lkml.org/lkml/2014/5/16/114
Regards,
Daeseok Youn.
2014-05-21 6:48 GMT+09:00 Dan Carpenter :
> On Tue, May 20, 2014 at 11:28:59PM +0200, Rickard Strandqvist wrote:
>> There is otherwise a risk of a possible null pointer dereference.
>>
>> Was largely found
On Tue, May 20, 2014 at 06:26:51PM -0500, Larry Finger wrote:
> On 05/20/2014 04:31 PM, Rickard Strandqvist wrote:
> >There is otherwise a risk of a possible null pointer dereference.
> >
> >Was largely found by using a static code analysis program called cppcheck.
> >
> >Signed-off-by: Rickard Str
On Tue, May 20, 2014 at 11:31:16PM +0200, Rickard Strandqvist wrote:
> + if (!padapter) {
> + goto error_exit;
> + }
Btw, I forgot to mention this before but please run your patches through
scripts/checkpatch.pl.
regards,
dan carpenter
___
On 05/20/2014 04:31 PM, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 127 ++
On Mon, May 19, 2014 at 11:39:00PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
This one is called from line6_disconnect
On Tue, May 20, 2014 at 11:34:25PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
This is a real bug. :)
Reviewed-by: Da
On Tue, May 20, 2014 at 11:31:16PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
"padapter" can't be NULL. Just remove the check.
regards,
dan carpenter
___
On Tue, May 20, 2014 at 11:32:53PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
Could you mention in the change log which pointer you are worried about?
I th
On Tue, May 20, 2014 at 11:28:59PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
This is the empty string by default, or a module parameter. I have
looked at
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8712/usb_intf.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8192u/r8192U_core.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --g
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 127 ++-
1 file changed, 66 insertions(+), 6
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/ozwpan/ozproto.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers
On Tue, May 20, 2014 at 05:12:46PM +0200, Matthias Beyer wrote:
> This patch outsources the code from the IsFlash2x() check in
> bcm_char_ioctl_nvm_rw() function to shorten it.
>
This patch introduces a bug. Please fix and resend.
Also move the function forward so we don't need a declaration.
On Tue, May 20, 2014 at 05:12:45PM +0200, Matthias Beyer wrote:
> This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command
> handling to shorten the bcm_char_ioctl_nvm_rw() function.
>
This one is grand. I wish you had put the function ahead so we don't
have to have the forward d
On Tue, May 20, 2014 at 05:12:44PM +0200, Matthias Beyer wrote:
> @@ -410,7 +412,8 @@ static int bcm_char_ioctl_gpio_set_request(void __user
> *argp,
> if (IoBuffer.InputLength > sizeof(gpio_info))
> return -EINVAL;
>
> - if (copy_from_user(&gpio_info, IoBuffer.InputBuffe
Use proper line terminations.
Signed-off-by: Joe Perches
---
drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +-
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
drivers/staging/rtl8723au/hal/usb_ops_linux.c | 4 ++--
drivers/staging/rtl8723au/os_dep/usb_intf.c | 2 +-
4 files changed,
On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote:
> On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote:
>
> but some kind of tests are needed to ensure nothing breaks before
> digging into that ...
I have some test: slightly modified version of tests from
https://github.com/wernerd/Ske
On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote:
> On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote:
>
> > Do you have any other series pending for this driver?
>
> No and I won't be doing anything else for the next couple of days --
> some darn weekly edition to deal with :)
:)
On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote:
> Do you have any other series pending for this driver?
No and I won't be doing anything else for the next couple of days --
some darn weekly edition to deal with :)
It seems like most of the straightforward stuff has been dealt with at
this
Thanks for the reviews!
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Jim Davis writes:
> Building with the attached random configuration file,
>
> drivers/staging/rtl8723au/core/rtw_cmd.c: In function ‘dynamic_chk_wk_hdl’:
> drivers/staging/rtl8723au/core/rtw_cmd.c:1036:2: error: implicit declaration
> of
> function ‘rtl8723a_sreset_xmit_status_check’
> [-Werror=
Hi,
I applied some fixes to my patches as they did not compile before.
I guess I'm not able to test these patches without the appropriate hardware,
unfortunately. Hope you guys like them anyway.
Regards,
Matthias Beyer
Matthias Beyer (3):
Staging: bcm: Fixed line lengths
Staging: bcm: Outso
This patch outsources the code from the IsFlash2x() check in
bcm_char_ioctl_nvm_rw() function to shorten it.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 101 --
1 file changed, 58 insertions(+), 43 deletions(-)
diff --git a/drivers/s
This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command
handling to shorten the bcm_char_ioctl_nvm_rw() function.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 72 ++-
1 file changed, 44 insertions(+), 28 deletions(-)
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 76 ---
1 file changed, 50 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index ae7490b..e5283dd 100644
--- a/drivers/staging/bcm/B
Hello,
On Tue, May 20, 2014 at 08:54:09AM +0300, Eli Billauer wrote:
> That seems OK to me, but the problem I'm concerned with is this: In
> devm_get_free_pages() it says
>
> devres = devres_alloc(devm_pages_release,
> sizeof(struct pages_devres), GFP_KERNEL);
> if (unli
Jake,
On Tue, May 20, 2014 at 07:56:12AM -0600, Jake Edge wrote:
>
> Clean up a few more things in skein to get it closer to mainline
> inclusion. The first may be questionable (so I probably should have
> put it last -- oh well, I can always respin), but it seemed like
> putting all of the thre
On 2014-05-20 at 15:04:50 +0200, Matthias Beyer wrote:
> Hi,
>
> I did some cleanup for the file
>
> drivers/staging/bcm/Bcmchar.c
>
> The patches shorten some lines and do some code outsourcing from large
> functions
> into smaller ones.
>
> Can someone tell me how to compile (and maybe
Rename a few more variables and structure member names to lower case.
Signed-off-by: Jake Edge
---
against staging-next branch of staging tree
drivers/staging/skein/skein.c | 148 +-
drivers/staging/skein/skein.h | 34
drivers/staging/skein
fix some comment typos
Signed-off-by: Jake Edge
---
against staging-next branch of staging tree
drivers/staging/skein/threefish_api.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/skein/threefish_api.h
b/drivers/staging/skein/threefish_
Clean up a few more things in skein to get it closer to mainline
inclusion. The first may be questionable (so I probably should have
put it last -- oh well, I can always respin), but it seemed like
putting all of the threefish block functions in one file, like the
skein block functions are all in
On Tue, 2014-05-20 at 10:09 +0900, Greg KH wrote:
> On Mon, May 19, 2014 at 10:57:08PM +0300, Dan Carpenter wrote:
> > On Mon, May 19, 2014 at 09:42:22AM -0500, Romer, Benjamin M wrote:
> > > On Sun, 2014-05-18 at 09:49 -0700, Greg KH wrote:
> > > > Also, why are these entries moving to debugfs at
Hi,
I did some cleanup for the file
drivers/staging/bcm/Bcmchar.c
The patches shorten some lines and do some code outsourcing from large functions
into smaller ones.
Can someone tell me how to compile (and maybe even test) my patches?
I'm not on the ML, please keep me in CC.
Regards,
Matt
This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command
handling to shorten the bcm_char_ioctl_nvm_rw() function.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 72 ++-
1 file changed, 44 insertions(+), 28 deletions(-)
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 76 ---
1 file changed, 50 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index ae7490b..e5283dd 100644
--- a/drivers/staging/bcm/B
This patch outsources the code from the IsFlash2x() check in
bcm_char_ioctl_nvm_rw() function to shorten it.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 98 ---
1 file changed, 56 insertions(+), 42 deletions(-)
diff --git a/drivers/s
Am 20.05.2014 13:41, schrieb Dan Carpenter:
> Those concerns are valid but the code was like that in the original so
> we should merge this patch as is and hope some volunteer will fix things
> up in a follow on patch.
>
> Fixing them in this patch would be a mistake anyway because of the one
>
>
> On Tue, May 20, 2014 at 02:17:26PM +0300, Tomas Winkler wrote:
> > I'd like to ask what is the policy for back porting fixes for drivers
> > that already graduated from staging but the fix is needed in kernel
> > version where it is still in the staging.
>
> Same as anything else, just provi
Those concerns are valid but the code was like that in the original so
we should merge this patch as is and hope some volunteer will fix things
up in a follow on patch.
Fixing them in this patch would be a mistake anyway because of the one
thing per patch rule.
regards,
dan carpenter
On Tue, May 20, 2014 at 02:17:26PM +0300, Tomas Winkler wrote:
> I'd like to ask what is the policy for back porting fixes for drivers
> that already graduated from staging but the fix is needed in kernel
> version where it is still in the staging.
Same as anything else, just provide the backport
Am 20.05.2014 12:33, schrieb Peter Senna Tschudin:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
>
> Verified by compilation only.
>
> The coccinelle script th
On Tue, May 20, 2014 at 12:33:45PM +0200, Peter Senna Tschudin wrote:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
>
> Verified by compilation only.
>
> The coc
I'd like to ask what is the policy for back porting fixes for drivers
that already graduated from staging but the fix is needed in kernel
version where it is still in the staging.
Thanks
___
devel mailing list
de...@linuxdriverproject.org
http://driverd
Am 20.05.2014 12:33, schrieb Peter Senna Tschudin:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
>
> Verified by compilation only.
>
> The coccinelle script th
Am 20.05.2014 12:33, schrieb Peter Senna Tschudin:
> This patch remove variables that are initialized with a constant,
> are never updated, and are only used as parameter of return.
> Return the constant instead of using a variable.
>
> Verified by compilation only.
>
> The coccinelle script th
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
//
@@
type T;
constant C;
identif
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
//
@@
type T;
constant C;
identif
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
//
@@
type T;
constant C;
identif
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
//
@@
type T;
constant C;
identif
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
//
@@
type T;
constant C;
identif
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
//
@@
type T;
constant C;
identif
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
//
@@
type T;
constant C;
identif
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
//
@@
type T;
constant C;
identif
Am 18.05.2014 19:27, schrieb Joe Perches:
> On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote:
>> Remove prohibited space and fix line over 80 characters of
>> memset(...) to meet kernel coding style.
> []
>> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
>> b/drivers/stag
Hi Greg,
Please accept this as the acknowledgment to your reply.
I will take over ozwpan maintainer role from Rupesh.
Thanks
Tateno
From: Greg KH [gre...@linuxfoundation.org]
Sent: 20 May 2014 02:29
To: Gujare, Rupesh
Cc: de...@driverdev.osuosl.org; linux
Now, those are some beautiful changelogs. ;) Thanks so much.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, May 19, 2014 at 11:39 PM, Rickard Strandqvist
wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/staging/line6/toneport.c | 14 +
Hello, Tejun.
On 19/05/14 23:17, Tejun Heo wrote:
What can't it just do the following?
if (dma_mapping_error(dev, dma_handle)) {
devres_free(dr);
return dma_handle;
}
The caller would have to invoke dma_mapping_error() again but is that
a proble
61 matches
Mail list logo
