This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.se...@gmail.com>

---
 drivers/staging/ozwpan/ozhcd.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index b3d401a..7be0058 100644
--- a/drivers/staging/ozwpan/ozhcd.c
+++ b/drivers/staging/ozwpan/ozhcd.c
@@ -1997,7 +1997,6 @@ static void oz_get_hub_descriptor(struct usb_hcd *hcd,
 static int oz_set_port_feature(struct usb_hcd *hcd, u16 wvalue, u16 windex)
 {
        struct oz_port *port;
-       int err = 0;
        u8 port_id = (u8)windex;
        struct oz_hcd *ozhcd = oz_hcd_private(hcd);
        unsigned set_bits = 0;
@@ -2064,7 +2063,7 @@ static int oz_set_port_feature(struct usb_hcd *hcd, u16 
wvalue, u16 windex)
                spin_unlock_bh(&port->port_lock);
        }
        oz_dbg(HUB, "Port[%d] status = 0x%x\n", port_id, port->status);
-       return err;
+       return 0;
 }
 
 /*
@@ -2073,7 +2072,6 @@ static int oz_set_port_feature(struct usb_hcd *hcd, u16 
wvalue, u16 windex)
 static int oz_clear_port_feature(struct usb_hcd *hcd, u16 wvalue, u16 windex)
 {
        struct oz_port *port;
-       int err = 0;
        u8 port_id = (u8)windex;
        struct oz_hcd *ozhcd = oz_hcd_private(hcd);
        unsigned clear_bits = 0;
@@ -2140,7 +2138,7 @@ static int oz_clear_port_feature(struct usb_hcd *hcd, u16 
wvalue, u16 windex)
        }
        oz_dbg(HUB, "Port[%d] status = 0x%x\n",
               port_id, ozhcd->ports[port_id-1].status);
-       return err;
+       return 0;
 }
 
 /*

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to