This is patch for fixing of minor coding style problems.
Signed-off-by: Adithya K
---
drivers/staging/gdm72xx/gdm_qos.c |3 ++-
drivers/staging/gdm72xx/gdm_sdio.c |1 +
drivers/staging/gdm72xx/gdm_usb.c |2 +-
drivers/staging/gdm72xx/gdm_wimax.c |3 +++
drivers/staging/gdm72
Hi Lee
Sorry for previous email, only [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx:
add support for pre_reqand post_req"
if need for 3.15 fix.
Best Regards.
micky.
On 04/29/2014 03:36 PM, Ulf Hansson wrote:
On 29 April 2014 03:54, wrote:
>From: Micky Ching
>
>This reverts commit c42deffd5b53c9e
Hi Lee
It seems Chris is too busy to responding, so would you help to pick this
patch for 3.15 fix.
Best Regards.
micky.
On 04/29/2014 03:30 PM, Ulf Hansson wrote:
On 29 April 2014 03:54, wrote:
>From: Micky Ching
>
>This reverts commit 1f7b581b3ffcb2a8437397a02f4af89fa6934d08.
>
>The patch
Christian Engelmayer writes:
> Fix a potential leak in the error path of function update_bcn_wps_ie().
> Move the affected input verification to the beginning of the function so
> that it may return directly without leaking already allocated memory.
> Detected by Coverity - CID 1077718.
>
> Signed
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Friday, May 2, 2014 3:19 PM
> To: Haiyang Zhang
> Cc: jim.ep...@gmail.com; s...@canb.auug.org.au; linux-n...@vger.kernel.org;
> linux-ker...@vger.kernel.org; KY Srinivasan; de...@linuxdriverproject.org;
> net..
This change ensures the driver can be built successfully without the
CONFIG_SYSFS flag.
MS-TFS: 182270
Signed-off-by: Haiyang Zhang
Reviewed-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h |2 ++
drivers/net/hyperv/netvsc_drv.c | 12 +++-
drivers/net/hyperv/rndis_filt
On Wed, May 07, 2014 at 09:33:20PM +0200, Christian Engelmayer wrote:
> Function rtw_mp_SetRFPath() dynamically allocates a temporary buffer that
> is not freed in all error paths. Use a centralized exit path and make sure
> that all memory is freed correctly. Detected by Coverity - CID 1077714.
>
Function rtw_wx_read32() dynamically allocates a temporary buffer that is not
freed in all error paths. Use a centralized exit path and make sure that all
memory is freed correctly. Detected by Coverity - CID 1077711.
Signed-off-by: Christian Engelmayer
---
drivers/staging/rtl8188eu/os_dep/ioctl
Commit fb841d67 (staging: vt6656: don't leak 'param' in vt6656_hostap_ioctl()
when returning -EOPNOTSUPP) cleaned up direct returns in the ioctl switch
statement that leaked already allocated memory. Fix the same issue for
VIAWGET_HOSTAPD_SCAN_REQ and VIAWGET_HOSTAPD_MLME that are not supported by
Fix a potential leak in the error path of function update_bcn_wps_ie().
Move the affected input verification to the beginning of the function so
that it may return directly without leaking already allocated memory.
Detected by Coverity - CID 1077718.
Signed-off-by: Christian Engelmayer
---
v3: Re
Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused. Thus remove
it. With the last variable declaration gone, there is no more need for an own
block. Remove it and adapt the indenting accordingly.
Signed-off-by: Christian Engelmayer
---
v3: Resend after v2 failed to apply
* reba
Function rtw_wx_set_enc_ext() dynamically allocates a temporary buffer that
is not freed in all error paths. Use a centralized exit path and make sure
that all memory is freed correctly. Detected by Coverity - CID 1077712.
Signed-off-by: Christian Engelmayer
---
drivers/staging/rtl8188eu/os_dep/
Fix the error path when a cookie mismatch is detected. In that case the
function jumps to the exit label without setting the uninitialized, local
variable 'return_error'. Detected by Coverity - CID 201453.
Signed-off-by: Christian Engelmayer
---
v2: Resend after v1 failed to apply
* rebased a
Fix a potential leak in the error path of rtw_set_key(). In case the requested
algorithm is not supported by the driver, the function returns without
enqueuing or freeing the already allocated command and parameter structs. Use
a centralized exit path and make sure that all memory is freed correctl
This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards.
The -2a version has 32 on-board DIO channels. In case this variant is
detected, local variable 'has_dio' is set accordingly. Otherwise it is
left uninitialized and the following subdevice instantiation depends on
the stack. De
Fix a potential leak in the error path of r871x_wx_set_enc_ext(). In case the
requested algorithm is not supported by the driver, the function returns
without freeing the already allocated 'param' struct. Move the input
verification to the beginning of the function so that the direct return is
safe
Function rtw_mp_SetRFPath() dynamically allocates a temporary buffer that
is not freed in all error paths. Use a centralized exit path and make sure
that all memory is freed correctly. Detected by Coverity - CID 1077714.
Signed-off-by: Christian Engelmayer
---
drivers/staging/rtl8188eu/os_dep/io
Fix potential leaks in the error paths of r8712_set_key(). In case the
algorithm specific checks fail, the function returns without enqueuing
or freeing the already allocated command and parameter structs. Use a
centralized exit path and make sure that all memory is freed correctly.
Detected by Cov
Function rtw_mp_pwrtrk() dynamically allocates a temporary buffer that
is not freed in all error paths. Use a centralized exit path and make sure
that all memory is freed correctly. Detected by Coverity - 1077715.
Signed-off-by: Christian Engelmayer
---
drivers/staging/rtl8188eu/os_dep/ioctl_lin
This is a cleanup of staging/rtl8188eu/os_dep/ioctl_linux.c regarding Coverity
resource leak findings.
The changes leave the current implementation intact and just attack the problems
in the error paths, however, it seems that we could get easily rid of some of
the mallocs altogether.
char *in
Function rtw_mp_QueryDrv() dynamically allocates a temporary buffer that
is not freed in all error paths. Use a centralized exit path and make sure
that all memory is freed correctly. Detected by Coverity - CID 1077713.
Signed-off-by: Christian Engelmayer
---
drivers/staging/rtl8188eu/os_dep/ioc
Remove a needless pointer initialisation and call to get_status_port_fn()
in functions remove_bypass_tpl_auto() and set_tpl_fn(). Variable
'pbpctl_dev_b' is set correctly later in the function before first use.
Signed-off-by: Christian Engelmayer
---
v2: Resend after v1 failed to apply
* reba
Pointer 'pwdev_priv' in function rtw_wdev_free() is unused - thus remove it.
Signed-off-by: Christian Engelmayer
---
v2: Resend after v1 failed to apply
* rebased against staging-next - commit 09c3fbba (staging: rtl8188eu:
Remove 'u8 *pbuf' from struct recv_buf)
* fixed mua: no multip
On Wed, May 07, 2014 at 06:02:44PM +0200, fernando.apesteg...@gmail.com wrote:
> From: Fernando Apesteguia
>
> Add blank line after declarations and delete extra blank line at the
> beginning of the function
>
> Signed-off-by: Fernando Apesteguia
Great. Thanks.
regards,
dan carpenter
__
On Wed, May 07, 2014 at 09:06:54AM -0700, Laura Abbott wrote:
> On 5/7/2014 4:17 AM, Dan Carpenter wrote:
> > These days most people don't use git to send patches so I have added a
> > section about that.
> >
>
> Do you mean most people *do* use git to send patches? Or most people don't
> use e-m
On 5/7/2014 4:17 AM, Dan Carpenter wrote:
> These days most people don't use git to send patches so I have added a
> section about that.
>
Do you mean most people *do* use git to send patches? Or most people don't
use e-mail clients?
Laura
--
Qualcomm Innovation Center, Inc. is a member of Cod
From: Fernando Apesteguia
Add blank line after declarations and delete extra blank line at the
beginning of the function
Signed-off-by: Fernando Apesteguia
---
drivers/staging/silicom/bpctl_mod.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/silicom/bp
On Wednesday, May 07, 2014 12:03 AM, Chase Southwood wrote:
> This patchset removes the last dependency on this driver's boardinfo (the
> timer subdevice init), and then removes the boardinfo from the driver.
>
> To be applied on top of my prior patchset "staging: comedi:
> addi_apci_1564: further
Fixes the following warning:
drivers/staging/wlags49_h2/sta_h2.c:4471:10: warning: symbol 'fw_image' was not
declared. Should it be static?
Signed-off-by: Luis Ortega
---
drivers/staging/wlags49_h2/sta_h2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlag
On Wed, May 07, 2014 at 03:39:15PM +0300, Dan Carpenter wrote:
> I wonder if there is some kind of tutorial which teaches people to
> choose the least specific subject possible? We should find which
> tutorial it is and update it. John, can you give us a hint here which
> tutorial you are using?
I wonder if there is some kind of tutorial which teaches people to
choose the least specific subject possible? We should find which
tutorial it is and update it. John, can you give us a hint here which
tutorial you are using?
On Wed, May 07, 2014 at 01:30:02PM +0100, John Church wrote:
> This pa
This patch fixes a coding style issue for a line that was over 80 characters
long.
Signed-off-by: John Church
---
drivers/staging/android/timed_gpio.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/timed_gpio.c
b/drivers/staging/android/time
Fix smatch warning "dgnc_cleanup_board() info:
redundant null check on brd->flipbuf calling kfree()"
in dgnc_driver.c
Signed-off-by: Ebru Akagunduz
---
drivers/staging/dgnc/dgnc_driver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/d
On Wed, May 07, 2014 at 04:05:27PM +0530, Adithya wrote:
> Hi All,
>
> This is patch for fixing of minor coding style problems. This is
> part of Eudyptula Challenge.
>
Write what you fixed.
> Thanks,
> Adithya.K
Not in the correct format. Use git send-email or read
Documentation/email-clien
These days most people don't use git to send patches so I have added a
section about that.
Signed-off-by: Dan Carpenter
diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt
index 4e30eba..9004a5fd 100644
--- a/Documentation/email-clients.txt
+++ b/Documentation/email-cl
On Wed, May 07, 2014 at 04:05:27PM +0530, Adithya wrote:
> Hi All,
>
> This is patch for fixing of minor coding style problems. This is part
> of Eudyptula Challenge.
>
> Thanks,
> Adithya.K
Can you please read the Documentation/SubmittingPatches file and then
resend this in a format I can ap
Hi All,
This is patch for fixing of minor coding style problems. This is part
of Eudyptula Challenge.
Thanks,
Adithya.K
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
index 50d43ad..5ed32b9 100644
--- a/drivers/staging/gdm72xx/gdm_qos.c
+++ b/drivers/stagi
On 2014/05/07 12:08 AM, H Hartley Sweeten wrote:
> The Diamond Systems OPMM-1616-XT board is a PC/104 module with 16
> optoisolated inputs and 16 relay outputs.
>
> The PEARL-MM-P board is a PC/104 module with 16 relay outputs.
>
> Both of these boards can be supported by the pcl730 driver.
>
>
On 2014/05/07 08:02 AM, Chase Southwood wrote:
> This patchset removes the last dependency on this driver's boardinfo (the
> timer subdevice init), and then removes the boardinfo from the driver.
>
> To be applied on top of my prior patchset "staging: comedi:
> addi_apci_1564: further cleanups"
>
On Wed, May 07, 2014 at 09:55:47AM +0300, Andy Shevchenko wrote:
> > @@ -1824,6 +1817,15 @@ static int r871x_wx_set_enc_ext(struct net_device
> > *dev,
> > default:
> > return -EINVAL;
> > }
> > +
> > + param_len = sizeof(struct ieee_param) + pext->key_len;
> > + param = (s
On Wed, May 07, 2014 at 07:23:33AM +0100, John Church wrote:
> This patch fixes a coding style issue. It modifies a single line
> that was over 80 characters long.
>
> Thanks,
> John
> Signed-off-by: John Church
This patch isn't sent in the correct way. Use git send-email or
read Documentation
On Thu, 2014-05-01 at 11:45 +0200, Christian Engelmayer wrote:
> Fix a potential leak in the error path of r871x_wx_set_enc_ext(). In case the
> requested algorithm is not supported by the driver, the function returns
> without freeing the already allocated 'param' struct. Move the input
> verifica
This driver only supports a single board type. Remove the boardinfo and
its use in the driver.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --gi
The only board served by this driver always has a timer, so we can init
the timer subdevice without checking first.
The boardinfo about the timer can also be removed and the data used
directly.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/driv
This patchset removes the last dependency on this driver's boardinfo (the
timer subdevice init), and then removes the boardinfo from the driver.
To be applied on top of my prior patchset "staging: comedi:
addi_apci_1564: further cleanups"
Chase Southwood (2):
staging: comedi: addi_apci_1564: re
45 matches
Mail list logo
