On Wed, May 07, 2014 at 04:05:27PM +0530, Adithya wrote: > Hi All, > > This is patch for fixing of minor coding style problems. This is > part of Eudyptula Challenge. >
Write what you fixed. > Thanks, > Adithya.K Not in the correct format. Use git send-email or read Documentation/email-clients.txt. Send it to yourself first, save the email as raw text including headers and everything. `cat raw_email.txt | git am`. Review the git log with `git log -p`. When that works then resend the patch. No Signed-off-by line. > diff --git a/drivers/staging/gdm72xx/gdm_qos.c > b/drivers/staging/gdm72xx/gdm_qos.c > index 50d43ad..5ed32b9 100644 > --- a/drivers/staging/gdm72xx/gdm_qos.c > +++ b/drivers/staging/gdm72xx/gdm_qos.c > @@ -229,6 +229,7 @@ static u32 extract_qos_list(struct nic *nic, struct > list_head *head) > entry = list_entry( > qcb->qos_list[i].prev, > struct qos_entry_s, list); > + > list_move_tail(&entry->list, head); > qcb->csr[i].qos_buf_count++; > This is a false positive because it sees the "struct qos_entry_s," and thinks it's a declaration but it's not. Don't obey checkpatch.pl if checkpatch.pl is wrong. > diff --git a/drivers/staging/gdm72xx/gdm_usb.c > b/drivers/staging/gdm72xx/gdm_usb.c > index 20539d8..8fd1b1f 100644 > --- a/drivers/staging/gdm72xx/gdm_usb.c > +++ b/drivers/staging/gdm72xx/gdm_usb.c > @@ -759,7 +759,7 @@ static int k_mode_thread(void *arg) > spin_lock_irqsave(&k_lock, flags2); > } > wait_event_interruptible_lock_irq(k_wait, > - !list_empty(&k_list) || > k_mode_stop, > + !list_empty(&k_list) || k_mode_stop, > k_lock); > spin_unlock_irqrestore(&k_lock, flags2); > } No. The alignment is all kinds of messed up now. The original was better. regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
