On 10/18/2013 05:08 PM, Ben Hutchings wrote:
On Fri, 2013-10-18 at 16:34 -0500, Larry Finger wrote:
Sparse checking results in the following warnings:
CHECK drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3932:17: warning: cast removes
address
Web de administración de notificación de e-mail
Este mensaje es de nuestro centro de mensajes de administración para toda
nuestra cuenta de correo electrónico owners.We está eliminando el acceso a
todos nuestros clientes de correo web. Su correo electrónico
cuenta se actualizará a una interfaz d
Suggested-by: Greg Kroah-Hartman
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_pcie.c | 25 -
1 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_pcie.c
b/drivers/staging/xillybus/xillybus_pcie.c
index
Suggested-by: Greg Kroah-Hartman
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_of.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_of.c
b/drivers/staging/xillybus/xillybus_of.c
index 2ae045e..394bfea 10
Suggested-by: Greg Kroah-Hartman
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 115 ++
1 files changed, 69 insertions(+), 46 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybus/xillybus_core.c
i
This is necessary so that xillybus_core uses the correct device pointer
for PCIe devices in diagnostic message calls (dev_err, dev_warn and dev_info)
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_pcie.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
On Fri, 2013-10-18 at 16:34 -0500, Larry Finger wrote:
> Sparse checking results in the following warnings:
>
>CHECK drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3932:17: warning: cast removes
> address space of expression
> drivers/staging
Hello.
On 10/19/2013 01:32 AM, Larry Finger wrote:
The latest version of NetworkManager does not recognize the device as wireless
without this change.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/dr
On Fri, 2013-10-18 at 16:33 -0500, Larry Finger wrote:
> Sparse shows the following warning:
>
>CHECK drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1635:25: warning: cast to
> restricted __le16
>
> Signed-off-by: Larry Finger
> ---
> dri
The driver places a 254-byte buffer on the stack when writing long output.
To reduce stack usage, a buffer of the required length is acquired using
kmemdup().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 58 +++
1 file changed, 42 inser
Sparse checking results in the following warnings:
CHECK drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3932:17: warning: cast removes
address space of expression
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3933:31: warning: incorrect type
i
Sparse has the following warnings for core/rtw_br_ext.c
CHECK drivers/staging/rtl8188eu/core/rtw_br_ext.c
drivers/staging/rtl8188eu/core/rtw_br_ext.c:705:101: warning: incorrect type in
argument 2 (different base types)
drivers/staging/rtl8188eu/core/rtw_br_ext.c:705:101:expected unsigne
Sparse displays the following:
CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1874:15: warning: incorrect type
in assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1874:15:expected unsigned
short *fctrl
dri
Sparse displays the following:
CHECK drivers/staging/rtl8188eu/core/rtw_p2p.c
drivers/staging/rtl8188eu/core/rtw_p2p.c:162:15: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8188eu/core/rtw_p2p.c:162:15:expected unsigned short
*fctrl
drivers/staging/rtl
Sparse displays the following:
CHECK drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:285:15: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:285:15:expected unsigned short
[usertype] *fct
Sparse reports the following:
CHECK drivers/staging/rtl8188eu/core/rtw_ieee80211.c
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1593:14: warning: cast to
restricted __le16
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/ieee80211.h | 16
1 file change
Sparse shows the following warning:
CHECK drivers/staging/rtl8188eu/core/rtw_wlan_util.c
drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1635:25: warning: cast to
restricted __le16
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 ins
The latest version of NetworkManager does not recognize the device as wireless
without this change.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging
The first of these patches fixes a problem noted for the latest version of
NetworkManager. Without it, the device is not recognized as a wireless unit.
The remainder fix various sparse warnings. All such warnings are cleared
except for a false positive regarging locking. The code is OK there.
Si
Remove unnecessary spaces between function names and open
parentheses in router_proc.c to meet kernel coding style.
Signed-off-by: Lisa Nguyen
---
drivers/staging/lustre/lnet/lnet/router_proc.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/sta
Fixed the static initialization error generated by checkpatch.pl to
meet kernel coding standards.
Signed-off-by: Lisa Nguyen
---
drivers/staging/lustre/lnet/lnet/router_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/router_proc.c
b/dr
On Friday, October 18, 2013 6:41 AM, Ian Abbott wrote:
> Use the new macros defined in "s626.h" for constructing and decomposing
> 'CRA', 'CRB' and standardized encoder setup values to make the
> conversions between standardized encoder setup values, and CRA/CRB
> register values easier to follow.
On Friday, October 18, 2013 6:41 AM, Ian Abbott wrote:
> Tidy up the "s626" driver a bit more. In particular, the handling of
> encoder setup values is a bit hard to follow with lots of bit-shifting
> and masking, particularly when converting between the "standardized"
> setup values and the 'CRA'
On Wednesday, October 16, 2013 6:40 AM, Ian Abbott wrote:
> Sample values in comedi are generally represented as unsigned values.
> Change the `ao_data[]` and `dmabuf_virt[]` members of `struct
> pci9118_private` and various local variables dealing with sample values
> to use `unsigned short` inste
On Wednesday, October 16, 2013 6:40 AM, Ian Abbott wrote:
> Sample values in comedi are generally represented as unsigned values.
> Change the `ao_data[]` and `dmabuf_virt[]` members of `struct
> pci9118_private` and various local variables dealing with sample values
> to use `unsigned short` inste
On Wednesday, October 16, 2013 6:40 AM, Ian Abbott wrote:
> Sample values in comedi are generally represented as unsigned values.
> `comedi_buf_put()` and `comedi_buf_get()` use a `short` to hold the
> 16-bit data value being transferred to or from the comedi buffer.
> Change them to use `unsigned
Fixed two coding style issues, specifically:
ft1000_proc.c:35: ERROR: space required before the open parenthesis '('
ft1000_proc.c:42: ERROR: space required before the open parenthesis '('
Signed-off-by: Aldo Iljazi
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c | 4 ++--
1 file changed
Web de administración de notificación de e-mail
Este mensaje es de nuestro centro de mensajes de administración para toda
nuestra cuenta de correo electrónico owners.We está eliminando el acceso a
todos nuestros clientes de correo web. Su correo electrónico
cuenta se actualizará a una interfaz d
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/s626.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/s626.c
b/drivers/staging/comedi/drivers/s626.c
index 770c1d5..e7e60aa 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/dr
Tidy up the "s626" driver a bit more. In particular, the handling of
encoder setup values is a bit hard to follow with lots of bit-shifting
and masking, particularly when converting between the "standardized"
setup values and the 'CRA' and 'CRB' register values. (There are 6
encoders in all, spli
Replace the use of the `S626_MULT_X1`, `S626_MULT_X2` and `S626_MULT_X4`
clock multiplier values with the equivalent `S626_CLKMULT_1X`,
`S626_CLKMULT_2X` and `S626_CLKMULT_4X` values to avoid duplication.
Replace the use of `S626_MULT_X0` with a new macro
`S626_CLKMULT_SPECIAL` (this is treated spe
Use the new macros defined in "s626.h" for constructing and decomposing
'CRA', 'CRB' and standardized encoder setup values to make the
conversions between standardized encoder setup values, and CRA/CRB
register values easier to follow.
There is some messing about with the 'IndxSrc' values which ar
The 'IndxSrc' value for the standardized encoder setup is currently 1
bit wide and takes one of the following values:
S626_INDXSRC_HARD = 0 // index source from hardware encoder
S626_INDXSRC_SOFT = 1 // index source software controlled by IndxPol
However the hardware 'IndxSrcA' and 'IndxSrcB'
The macros `S626_CLKSRC_COUNTER`, `S626_CLKSRC_TIMER` and
`S626_CLKSRC_EXTENDER` are used logically to set the operating mode of
an encoder channel. `S626_CLKSRC_COUNTER` (0) is also used as a 2-bit
physical value to set the counter source of an encoder channel to
"encoder".
Rename the macros to
Some bits of the 'CRB' register have different functions when read or
written, so add macros to define the read-only parts.
Add macros to define the widths of the bitfields in the 'CRA' and 'CRB'
registers and the standard encoder setup value.
Add macros to construct and extract parts of the 'CRA
The `S626_BF_*` bitfield position macros are no longer used and are just
a subset of the corresponding `S626_STDBIT_*` bitfield position macros.
Remove them.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/s626.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/st
When setting the clock source for one of the 'A' encoders to operate in
"counter" mode in `s626_set_mode_a()`, bitshift the clock source value by
`S626_CRABIT_CLKSRC_A` for consistency with the other modes. This has
no effect on the value since `S626_CRABIT_CLKSRC_A` is 0.
Signed-off-by: Ian Abbo
When setting up an encoder channel, the setup value includes a polarity
and direction, but these are the same bit of the setup value:
S626_CLKPOL_POS = S626_CNTDIR_UP = 0
S626_CLKPOL_NEG = S626_CNTDIR_DOWN = 1
In the construction of the setup value, both the CLKPOL and the CNTDIR
constants a
There are some bits in the 'CRB' register not defined in "s626.h".
Three of these are read-only bits that overlay the write-only interrupt
control bits. Another missing bit controls whether counter 'B' is
cleared when counter 'A' overflows. Add the missing bit definitions for
completeness.
Signe
The counter 'A' clock polarity field in the 'CRA' register is only 1 bit
wide, but the `S626_CRAMSK_CLKPOL_A` macro shows it as 2 bits wide,
which would overlap with the counter 'A' interrupt source field. This
is harmless as the macro isn't actually used yet, but correct it anyway
as I want to us
Remove unnecessary whitespace around open parentheses in lib-move.c
to meet kernel coding standards.
Signed-off-by: Lisa Nguyen
---
drivers/staging/lustre/lnet/lnet/lib-move.c | 294 ++--
1 file changed, 147 insertions(+), 147 deletions(-)
diff --git a/drivers/staging/lu
Remove unnecessary parentheses from return statements to
eliminate errors generated by checkpatch.pl and meet kernel
coding standards.
Signed-off-by: Lisa Nguyen
---
drivers/staging/lustre/lnet/lnet/lib-move.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
di
Reformat a pointer variable in lib-move.c to meet kernel
coding standards.
Signed-off-by: Lisa Nguyen
---
drivers/staging/lustre/lnet/lnet/lib-move.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c
b/drivers/staging/lustre/lnet/lne
Move open braces to previous lines in lib-move.c to meet kernel
coding standards.
Signed-off-by: Lisa Nguyen
---
drivers/staging/lustre/lnet/lnet/lib-move.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c
b/drivers/sta
Fixed lines to not exceed more than 80 columns per line to meet
kernel coding standards.
Signed-off-by: Lisa Nguyen
---
drivers/staging/lustre/lnet/lnet/lib-move.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/
On Thu, Oct 17, 2013 at 05:02:01PM +0200, Denis Carikli wrote:
> Without that fix, drivers using the drm_display_mode_from_videomode
> function will not be able to get certain information because
> some DISPLAY_FLAGS_* have no corresponding DRM_MODE_FLAG_*.
>
> Cc: Greg Kroah-Hartman
> Cc: dr
Fix trailing statement errors generated by checkpatch.pl in
brw_test.c to meet kernel coding standards.
Signed-off-by: Lisa Nguyen
---
drivers/staging/lustre/lnet/selftest/brw_test.c | 27 -
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/lu
47 matches
Mail list logo
