On Thu, Oct 17, 2013 at 05:02:01PM +0200, Denis Carikli wrote: > Without that fix, drivers using the drm_display_mode_from_videomode > function will not be able to get certain information because > some DISPLAY_FLAGS_* have no corresponding DRM_MODE_FLAG_*. > > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: driverdev-devel@linuxdriverproject.org > Cc: David Airlie <airl...@linux.ie> > Cc: dri-de...@lists.freedesktop.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: Fabio Estevam <fabio.este...@freescale.com> > Cc: Sascha Hauer <ker...@pengutronix.de> > Cc: linux-arm-ker...@lists.infradead.org > Cc: Eric Bénard <e...@eukrea.com> > Signed-off-by: Denis Carikli <de...@eukrea.com> > --- > drivers/gpu/drm/drm_modes.c | 9 +++++++++ > include/uapi/drm/drm_mode.h | 4 ++++ > 2 files changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index b073315..353aaae 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -537,6 +537,15 @@ int drm_display_mode_from_videomode(const struct > videomode *vm, > dmode->flags |= DRM_MODE_FLAG_DBLSCAN; > if (vm->flags & DISPLAY_FLAGS_DOUBLECLK) > dmode->flags |= DRM_MODE_FLAG_DBLCLK; > + if (vm->flags & DISPLAY_FLAGS_DE_LOW) > + dmode->flags |= DRM_MODE_FLAG_NDATEN; > + if (vm->flags & DISPLAY_FLAGS_DE_HIGH) > + dmode->flags |= DRM_MODE_FLAG_PDATEN; > + if (vm->flags & DISPLAY_FLAGS_PIXDATA_POSEDGE) > + dmode->flags |= DRM_MODE_FLAG_PPIXDATEDGE; > + if (vm->flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE) > + dmode->flags |= DRM_MODE_FLAG_NPIXDATEDGE; > + > drm_mode_set_name(dmode); > > return 0; > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > index bafe612..13843c7 100644 > --- a/include/uapi/drm/drm_mode.h > +++ b/include/uapi/drm/drm_mode.h > @@ -66,6 +66,10 @@ > #define DRM_MODE_FLAG_3D_L_DEPTH_GFX_GFX_DEPTH (1<<19) > #define DRM_MODE_FLAG_3D_TOP_AND_BOTTOM (1<<20) > #define DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF (1<<21) > +#define DRM_MODE_FLAG_PDATEN (1<<22) > +#define DRM_MODE_FLAG_NDATEN (1<<23) > +#define DRM_MODE_FLAG_PPIXDATEDGE (1<<24) > +#define DRM_MODE_FLAG_NPIXDATEDGE (1<<25)
Do we really need to make this stuff visible to userspace? And there's no documentation to explain any of it. > > /* DPMS flags */ > /* bit compatible with the xorg definitions. */ > -- > 1.7.9.5 > > _______________________________________________ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
