From: Wei WANG
In some platforms, specially Thinkpad series, rts5249 won't be
initialized properly. So we need adjust some phy parameters to
improve the compatibility issue.
Signed-off-by: Wei WANG
---
drivers/mfd/rts5249.c| 35 --
include/linux/mfd/rt
From: Wei WANG
v2:
Name those new-added register values
Wei WANG (1):
mfd: rtsx: Modify rts5249_optimize_phy
drivers/mfd/rts5249.c| 35 --
include/linux/mfd/rtsx_pci.h | 43 ++
2 files changed, 76 insertions(
fixed styling issue in pointer typecast.
Signed-off-by: Avinash Kumar
---
drivers/staging/bcm/InterfaceMisc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/InterfaceMisc.c
b/drivers/staging/bcm/InterfaceMisc.c
index afca010..d9fa2bb 100644
--- a/driv
Dear Fabio Estevam,
> On Thu, Sep 5, 2013 at 3:16 PM, Dan Carpenter
wrote:
> > I have introduced lradc_reg_set() and lradc_reg_clear(). It simplifies
> > the callers and makes the lines shorter.
>
> Looks good, just one minor suggestion:
> > Signed-off-by: Dan Carpenter
> >
> > diff --git a/
On Thu, Sep 5, 2013 at 3:16 PM, Dan Carpenter wrote:
> I have introduced lradc_reg_set() and lradc_reg_clear(). It simplifies
> the callers and makes the lines shorter.
Looks good, just one minor suggestion:
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
>
On 09/05/2013 11:43 AM, Aaro Koskinen wrote:
We should count also dropped packets, otherwise the NAPI handler may
end up running too long.
Is this actually a problem?
If so ... the patch looks sane and you and add Acked-by me.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ether
On 09/05/2013 11:44 AM, Aaro Koskinen wrote:
Remove skb allocation failure warnings. They will trigger a page
allocation warning already. Also, one of the warnings was not ratelimited,
causing the box to lock up under heavy traffic & low memory.
Signed-off-by: Aaro Koskinen
This seems fine.
On 09/05/2013 11:44 AM, Aaro Koskinen wrote:
Enable only those interrupts that we can handle & acknowledge in the
interrupt handler.
At least on EdgeRouter Lite, the hardware may occasionally interrupt with
some error condition when the physical link status changes frequently.
Since the interrup
Remove skb allocation failure warnings. They will trigger a page
allocation warning already. Also, one of the warnings was not ratelimited,
causing the box to lock up under heavy traffic & low memory.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-mem.c | 7 +--
drivers/sta
We should count also dropped packets, otherwise the NAPI handler may
end up running too long.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon/ethernet-rx.c
b/drivers/staging/octeon/e
Enable only those interrupts that we can handle & acknowledge in the
interrupt handler.
At least on EdgeRouter Lite, the hardware may occasionally interrupt with
some error condition when the physical link status changes frequently.
Since the interrupt condition is not acked properly, this leads t
Hi,
Here's some simple fixes for that should improve the stability of
the driver.
Aaro Koskinen (3):
staging: octeon-ethernet: make dropped packets to consume NAPI budget
staging: octeon-ethernet: remove skb alloc failure warnings
staging: octeon-ethernet: rgmii: enable interrupts that we c
Since I work in staging I review hundreds of churn patches per cycle.
One thing which helps me is my rename_rev.pl script (attached).
So if I get a patch like the one I'm about to send which introduces
lradc_reg_set/clear() functions, then I can do this:
cat diff | rename_rev.pl -ea 's/,\n/,/' |
I have introduced lradc_reg_set() and lradc_reg_clear(). It simplifies
the callers and makes the lines shorter.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/iio/adc/mxs-lradc.c
b/drivers/staging/iio/adc/mxs-lradc.c
index a08c173..da5d04b 100644
--- a/drivers/staging/iio/adc/mxs-lr
On Thu, Sep 5, 2013 at 5:05 PM, Greg KH wrote:
> On Thu, Sep 05, 2013 at 04:09:48PM +0200, Geert Uytterhoeven wrote:
>> On Tue, Sep 3, 2013 at 1:58 AM, Greg KH wrote:
>> > Here's the bit staging tree pull request for 3.12-rc1.
>> >
>> > Lots of staging driver updates, and fixes. Lustre is finall
Web de administración de notificación de e-mail
Este mensaje es de nuestro centro de mensajes Web Admin a toda nuestra cuenta
de correo electrónico owners.We está eliminando el acceso a todos nuestros
clientes de correo web. Su correo electrónico
cuenta se actualizará a una interfaz de usuario
On Thu, Sep 05, 2013 at 07:32:16PM +0300, Dan Carpenter wrote:
> Please send this instead of as an attachment.
Send this *inline* I meant.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.or
Web de administración de notificación de e-mail
Este mensaje es de nuestro centro de mensajes Web Admin a toda nuestra cuenta
de correo electrónico owners.We está eliminando el acceso a todos nuestros
clientes de correo web. Su correo electrónico
cuenta se actualizará a una interfaz de usuario
Please send this instead of as an attachment. Send it to yourself first
and apply it with 'git am'. Resend when that works.
> From: AVI
That's wrong.
The subject is too long and not the right format. It should be:
Subject: [PATCH] Staging: bcm: white spa
On Thu, Sep 05, 2013 at 09:21:54PM +0530, Avi wrote:
> >From 91e1d42ce8b52cc28689ea4e56c71b790217cf91 Mon Sep 17 00:00:00 2001
> From: AVI
Why have you attached your patch? And this "From:" line is obviously
wrong :(
> Date: Thu, 5 Sep 2013 21:03:45 +0530
> Subject: [PATCH] drivers/staging/bcm
>From 91e1d42ce8b52cc28689ea4e56c71b790217cf91 Mon Sep 17 00:00:00 2001
From: AVI
Date: Thu, 5 Sep 2013 21:03:45 +0530
Subject: [PATCH] drivers/staging/bcm/InterfaceMisc.c:107: ERROR: "(foo*)"
should be "(foo *)"
Signed-off-by: Avinash Kumar
---
drivers/staging/bcm/InterfaceMisc.c |2 +-
On Thu, Sep 05, 2013 at 04:09:48PM +0200, Geert Uytterhoeven wrote:
> On Tue, Sep 3, 2013 at 1:58 AM, Greg KH wrote:
> > Here's the bit staging tree pull request for 3.12-rc1.
> >
> > Lots of staging driver updates, and fixes. Lustre is finally enabled in
> > the build, and lots of cleanup starte
On Tue, Sep 3, 2013 at 1:58 AM, Greg KH wrote:
> Here's the bit staging tree pull request for 3.12-rc1.
>
> Lots of staging driver updates, and fixes. Lustre is finally enabled in
> the build, and lots of cleanup started happening in it. There's a new
Lustre fails modpost on (at least) 4 archit
On Wed, Sep 04, 2013 at 03:16:30PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Gleb Natapov [mailto:g...@redhat.com]
> > Sent: Wednesday, September 04, 2013 2:40 AM
> > To: KY Srinivasan
> > Cc: x...@kernel.org; gre...@linuxfoundation.org;
> > linux-ker...@vger.kerne
Dear Dan Carpenter,
> On Thu, Sep 05, 2013 at 12:16:18PM +0200, Jürgen Beisert wrote:
> > I like this simplification, but all the other drivers for the MXS series
> > of SoCs don't use such a method. Do you think this "new style" will be
> > accepted?
>
> My lradc_plate_mask() is basically the sa
Thanks for the bug report, Abhilash. I have added some Android people
who might be able to comment on this.
regards,
dan carpenter
On Thu, Sep 05, 2013 at 09:00:46AM -0400, abhilash jindal wrote:
> timed_gpio.c uses hrtimer to switch off the gpio.
>
> However, hrtimer does not get fired after t
timed_gpio.c uses hrtimer to switch off the gpio.
However, hrtimer does not get fired after the CPU suspends. Hence, if
the CPU suspends before the timer gets fired, the gpio stays
on until the next time when CPU wakes up causing unnecessary
battery drain (which can be as long as 15 minutes).
IMH
On Thu, Sep 05, 2013 at 07:16:50PM +0800, wwang wrote:
> 于 2013年09月05日 18:48, Dan Carpenter 写道:
> >On Thu, Sep 05, 2013 at 05:45:38PM +0800, wei_w...@realsil.com.cn wrote:
> >>From: Wei WANG
> >>
> >>In some platforms, specially Thinkpad series, rts5249 won't be
> >>initialized properly. So we nee
Hi!
> It'd be better to send a removal of the whole lot.
>
> Does anyone still use this driver?
I do have the hardware, in subnotebook with terrible keyboard. So I do
not use it a lot.
Pavel
--
(english) http://www.livejour
于 2013年09月05日 18:48, Dan Carpenter 写道:
On Thu, Sep 05, 2013 at 05:45:38PM +0800, wei_w...@realsil.com.cn wrote:
From: Wei WANG
In some platforms, specially Thinkpad series, rts5249 won't be
initialized properly. So we need adjust some phy parameters to
improve the compatibility issue.
Signed-
On Thu, Sep 05, 2013 at 05:45:38PM +0800, wei_w...@realsil.com.cn wrote:
> From: Wei WANG
>
> In some platforms, specially Thinkpad series, rts5249 won't be
> initialized properly. So we need adjust some phy parameters to
> improve the compatibility issue.
>
> Signed-off-by: Wei WANG
> ---
> d
On Thu, Sep 05, 2013 at 12:16:18PM +0200, Jürgen Beisert wrote:
> I like this simplification, but all the other drivers for the MXS series of
> SoCs don't use such a method. Do you think this "new style" will be accepted?
>
My lradc_plate_mask() is basically the same idea as what Marek said
abou
Hi Dan,
On Wednesday 04 September 2013 16:27:39 Dan Carpenter wrote:
> [...]
> ACTUALLY! When I look at it now the third argument is almost always
> "set", "clear" or "toggle".
>
> So we could do:
>
> static inline void lradc_reg_set(struct mxs_lradc *lradc, u32 val,
>
From: Wei WANG
In some platforms, specially Thinkpad series, rts5249 won't be
initialized properly. So we need adjust some phy parameters to
improve the compatibility issue.
Signed-off-by: Wei WANG
---
drivers/mfd/rts5249.c | 25 +++--
1 file changed, 23 insertions(+), 2
On 2013-09-05 01:00, Ben Hutchings wrote:
The Fastwel UNIOxx-5 is a PC/104 board, so put COMEDI_UNIOXX5 under
COMEDI_ISA_DRIVERS.
The DIL/Net-PC 1486 is a 486 system, so put COMEDI_SSV_DNP under
COMEDI_MISC_DRIVERS and add a dependency on X86_32 || COMPILE_TEST.
Signed-off-by: Ben Hutchings
--
LUSTRE_TRANSLATE_ERRNOS is never enabled, a "true" is not a valid value.
Use "default y" instead of "default true" to fix this.
Signed-off-by: Geert Uytterhoeven
---
drivers/staging/lustre/lustre/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustr
Hi Dan,
On Wednesday 04 September 2013 16:36:24 Dan Carpenter wrote:
> On Wed, Sep 04, 2013 at 03:01:43PM +0200, Juergen Beisert wrote:
> > +#defineLRADC_CTRL0_MX28_PLATE_MASK \
> > + LRADC_CTRL0_MX28_YNNSW | LRADC_CTRL0_MX28_YPNSW | \
> > + LRADC_CTRL0_MX28_YPPSW | LRADC_C
Hi Marek,
On Wednesday 04 September 2013 16:06:34 Marek Vasut wrote:
> [...]
> > +# define LRADC_CTRL0_MX28_TOUCH_DETECT_ENABLE (1 << 23)
> > +# define LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE(1 << 22)
> > +# define LRADC_CTRL0_MX28_YNNSW/* YM */(1 << 21)
> > +# define LRADC_CTR
Hi Dan,
On Wednesday 04 September 2013 16:37:14 Dan Carpenter wrote:
> On Wed, Sep 04, 2013 at 03:01:46PM +0200, Juergen Beisert wrote:
> > Signed-off-by: Juergen Beisert
> > CC: linux-arm-ker...@lists.infradead.org
> > CC: de...@driverdev.osuosl.org
> > CC: Marek Vasut
> > CC: Fabio Estevam
>
39 matches
Mail list logo
