RE: [PATCH] staging: comedi: allow ISA and PC/104 drivers on non-ISA systems

On Friday, July 26, 2013 3:09 AM, Ian Abbott wrote: > On 2013-07-26 00:32, H Hartley Sweeten wrote: >> On Thursday, July 25, 2013 3:43 AM, Ian Abbott wrote: >>> On 2013-07-24 19:24, H Hartley Sweeten wrote: menuconfig COMEDI_ISA_DRIVERS bool "Comedi ISA and PC/104 drivers

[PATCH 16/18] staging: comedi: usbdux: tidy up usbdux_detach()

Make sure the usb intfdata is always cleared when the device is detached. Refactor the code to remove an indent level. Always unlink the urbs when the device is detached. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 21 +

[PATCH 18/18] staging: comedi: usbduxsigma: absorb usbduxsigma_attach_common() into caller

This function is only called by usbduxsigma_auto_attach(). Absorb it and refactor the code a bit to match the usbdux driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxsigma.c | 171 --- 1 file changed

[PATCH 14/18] staging: comedi: usbduxsigma: move urb unlink into usbduxsigma_detach()

For aesthetics, move the final force unlink of the urbs from usbduxsigma_free_usb_buffers() to usbduxsigma_detach(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxsigma.c | 12 +++- 1 file changed, 7 insertions(+), 5 del

[PATCH 17/18] staging: comedi: usbdux: tidy up usbdux_free_usb_buffers()

For aesthetics, pass the comedi_device pointer to this function instead of the private data pointer. The usb_kill_urb() calls are not needed. All the urbs were unlinked before this function was called. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/

[PATCH 15/18] staging: comedi: usbduxsigma: always clear the usb intfdata in (*detach)

Make sure the usb intfdata is always cleared when the device is detached. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxsigma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drive

[PATCH 11/18] staging: comedi: usbdux: tidy up usbdux_alloc_usb_buffers()

Tidy up the error path by doing all the basic allocations then checking for failures. We have the comedi device now so fill in the urb->context. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 32 ++--

[PATCH 13/18] staging: comedi: usbduxsigma: init 'pwm_buf_sz' in usbduxsigma_auto_attach()

Initialize this variable with then_ai_urbs and n_ao_urbs in the attach. Then usbduxsigma_alloc_usb_buffers() can just check the variable to determine if the urb needs to be allocated. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbd

[PATCH 12/18] staging: comedi: usbduxsigma: 'dac_commands' does not need to be kzalloc()'d

The 'dac_commands' buffer is used to pass the ao channel list from usbduxsigma_ao_cmd() to the urb callback, usbduxsigma_ao_urb_complete(). This buffer does not need to be allocated. Change it into a simple array of the correct size. Rename the variable to 'ao_chanlist' to clarify what it actually

[PATCH 10/18] staging: comedi: usbduxsigma: return void from usbduxsigma_pwm_pattern()

This function never fails and currently returns '1' so that the usbduxsigma_pwm_write() function returns to proper value (insn->n). It's also called by usbduxsigma_pwm_config() which also returns the '1' value. The proper return code for this function should be '0' to indicate success. Change the

[PATCH 07/18] staging: comedi: usbdux: remove usbdux_pwm_read()

The pwm subdevice is not readable so this callback function is not needed. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/comedi/drivers/us

[PATCH 08/18] staging: comedi: usbdux: tidy up usbdux_pwm_config()

Rename the local variable used for the private data pointer to 'devpriv'. Tidy up the function a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 32 +--- 1 file changed, 13 insertions(+), 19

[PATCH 06/18] staging: comedi: usbdux: tidy up usbdux_pwm_write()

Remove the sanity check of the private data. This function can only be called if the private data was successfully allocated in the attach. Tidy up the function a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 26 +

[PATCH 09/18] staging: comedi: usbdux: return void from usbdux_pwm_pattern()

This function never fails and currently returns '1' so that the usbdux_pwm_write() function returns to proper value (insn->n). It's also called by usbdux_pwm_config() which also returns the '1' value. The proper return code for this function should be '0' to indicate success. Change the return ty

[PATCH 03/18] staging: comedi: usbduxsigma: remove the usb endpoint defines

The endpoint defines are each only used in one place and don't help clarify the code. Remove the defines and just open code the values. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxsigma.c | 19 +-- 1 file chang

[PATCH 04/18] staging: comedi: usbdux: tidy up usbdux_pwm_period()

Rename the local variable used for the private data pointer to 'devpriv'. Fix the fx2delay calculation so it does not use floating point values. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 11 ++- 1 file changed,

[PATCH 05/18] staging: comedi: usbdux: tidy up usbdux_pwm_pattern()

Rename the local variable used for the private data pointer to 'devpriv'. Remove the sanity check of the private data. This function can only be called if the private data was successfully allocated in the attach. Tidy up the function to make it more concise. Signed-off-by: H Hartley Sweeten Cc

[PATCH 00/18] staging: comedi: tidy up usbdux drivers

The usbdux and usbduxsigma drivers are very similar and should be able to share some common code. Tidy up the drivers a bit so that the common pieces can be located and pulled out. H Hartley Sweeten (18): staging: comedi: usbdux: generalize the usb_submit_urb functions staging: comedi: usbdux

[PATCH 02/18] staging: comedi: usbduxsigma: generalize the ai/ao usb_kill_urb()

Generalize a helper function to replace for() loops in usbduxsigma_{ai,ao}_stop() that call usb_kill_urb() to unlink all the urbs. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxsigma.c | 28 1 file

[PATCH 01/18] staging: comedi: usbdux: generalize the usb_submit_urb functions

Generalize a helper function to replace usbduxsub_submit_{in,out}urbs(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 47 +++-- 1 file changed, 15 insertions(+), 32 deletions(-) diff --git a/dr

[PATCH v2] staging/lustre: lloop depends on BLOCK

From: Xiong Zhou In the lustre client driver, lloop depends on BLOCK. Add an option for this dependence. Last version of this patch makes LUSTRE_FS depends on BLOCK. Remove unnecessary jdb head files which depends on BLOCK. Signed-off-by: Xiong Zhou --- drivers/staging/lustre/lustre/Kconfig

[PATCH 2/2] staging: olpc_dcon: provide detailed FB_OLPC_DCON help section

The FB_OLPC_DCON help section is to short according to checkpatch.pl. We want more information about the controller type, its task, its video pipeline position and so on. There are no style issues, remove checkpatch.pl TODO entry. Signed-off-by: Jens Frederich --- drivers/staging/olpc_dcon/Kcon

[PATCH 37/38] staging: comedi: das16: remove some unnecessary parentheses

These parentheses are not necessary. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/sta

[PATCH 38/38] staging: comedi: das16: tidy up multi-line comments

Tidy up the multi-line comments to follow the CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 147 + 1 file changed, 77 insertions(+), 70 deletions(-) diff --git a/drivers/staging/

[PATCH 36/38] staging: comedi: das16: tidy up user ai/ao range initialization

The allocation of the user range tables could fail. Make sure to check for it. Change the kmalloc()'s to kzalloc()'s to make sure the allocated range tables are initialized to a known state. Change the local variables so they can be used for both the ai and ao range initialization and use shorter

[PATCH 35/38] staging: comedi: das16: remove an unnecessary check in the attach

If the user does not specify the analog output range the private data 'user_ao_range_table' will not be allocated. The comedi core will detect the NULL s->range_table and automatically set it to &range_unknown. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/

[PATCH 33/38] staging: comedi: das16: change MODULE_DESCRIPTION

Change the MODULE_DESCRIPTION to something useful instead of the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stag

[PATCH 34/38] staging: comedi: das16: fix das16_detach()

The function das16_reset() needs a valid dev->iobase. Since the iobase is requested after the devpriv has been allocated in the attach, move the das16_reset() call into the if (devpriv) and add a if (dev->iobase). Also, move the release of the extra iobase into the if (devpriv) to prevent an inval

[PATCH 30/38] staging: comedi: das16: fix a > 80 char line issue

Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.c index 7dae83e..c4f0853 100644

[PATCH 28/38] staging: comedi: das16: cleanup printk message in board attach

Convert this printk message into a dev_err(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/com

[PATCH 32/38] staging: comedi: das16: tidy up private data definition

Remove the comments and add some whitespace to help readability. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 40 ++ 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/drivers/st

[PATCH 31/38] staging: comedi: das16: cleanup comedi_error() messages

Some of these messages are missing the terminating '\n' and most of them have the quoted string split across lines. Change all of them to dev_err() messages and fix the issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c |

[PATCH 29/38] staging: comedi: das16: absorb das1600_mode_detect() into caller

This function is only called during the board attach to determine the pacer clock speed for the boards capable of bursting. Absorb it into the caller and remove the attach noise. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c

[PATCH 27/38] staging: comedi: das16: fail attach if board id is incorrect

This driver probes the board id during the attach to ensure that the user is attempting to attach to the correct board type. Currently an error message is output if the ids are not consistent but the attach continues anyway. Make the attach fail if the id bits do not match. Also, cleanup the print

[PATCH 26/38] staging: comedi: das16: tidy up the register map defines

Add the suffix _REG to all the register defines to better indicate what they are. Add a prefix to all the register bit defines to avoid namespace clashes and to better indicate what they are. Tidy up the whitesapce. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- d

[PATCH 25/38] staging: comedi: das16: tidy up 8255 digital i/o subdevice

The 8255 digital i/o subdevice is only available on some of the boards supported by this driver. Currently the 'i8255_offset' member of the boardinfo is used to indicate that it is available. To clarify this support, add a 'has_8255' bit-field flag to the boardinfo. We can then use this flag to co

[PATCH 24/38] staging: comedi: das16: remove 'i8254_offset' from boardinfo

All the boards supported by this driver have an 8254 timer at offset 0x0c. Remove this unused information from the boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 23 --- 1 file changed, 23 delet

[PATCH 21/38] staging: comedi: das16: move some functions to improve readability

For aesthetics, move some of the functions to make the code easier to follow. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 300 - 1 file changed, 146 insertions(+), 154 deletions(-) diff --g

[PATCH 22/38] staging: comedi: das16: remove unnecessary test in das16_interrupt()

The timer is only started by the ai subdevice in das16_cmd_exec() and this function can only be called if the device is attached. Remove the unnecessary sanity check. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 15 ---

[PATCH 23/38] staging: comedi: das16: move boardinfo declaration

Now that the boardinfo does not require any forward declarations, move it near the definition of the struct. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 424 - 1 file changed, 212 insertions

[PATCH 20/38] staging: comedi: das16: tidy up das16_ai_insn_read()

Factor out the loop that waits for the ai conversion to complete. Tidy up the function a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- This also fixes a bug introduced by PATCH 05/38. The 'val' should be >> 4 not the 'data[n]'. If necessary I will rebase this

[PATCH 19/38] staging: comedi: das16: introduce das16_ai_{en, dis}able() helpers

Introduce a couple helper functions to enable and disable the analog input interrupt/dma conversions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 53 +- 1 file changed, 33 insertions(+), 20

[PATCH 18/38] staging: comedi: das16: remove the register map comments

This is just extra cruft. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 87 +- 1 file changed, 2 insertions(+), 85 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c

[PATCH 17/38] staging: comedi: das16: remove unused static const variable

This variable is not used in the driver. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/d

[PATCH 16/38] staging: comedi: das16: remove unused DAS16_SIZE

This define is not used in the driver. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.

[PATCH 15/38] staging: comedi: das16: add a 'can_burst' flag to the private data

If the boardinfo 'size' is > 0x400 it indicates that the board has additional registers that allow bursting of analog input data. To better indicate this add a flag to the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/d

[PATCH 14/38] staging: comedi: das16: remove 'volatile' on private data variables

As indicated by checkpatch.pl, "WARNING: Use of volatile is usually wrong: ...". The variables in the private data that are marked volatile don't need to be. Remove the volatile. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c |

[PATCH 13/38] staging: comedi: das16: remove DEBUG_PRINT macro

This macro outputs some printk() debug info that is just added noise. Remove it as well as the DEBUG stuff. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers

[PATCH 11/38] staging: comedi: das16: remove 'ai_unipolar' and 'ai_singleended'

These members in the private data are only used during the board attach. Move the reading of the status register to the board attach and just check the value where needed when initializing the analog input subdevice. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- d

[PATCH 10/38] staging: comedi: das16: remove unused struct definition

This struct is not used by the driver. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/d

[PATCH 12/38] staging: comedi: das16: remove reg_dump()

This function just prints some development debug information. There is no reason to leave this in the final driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 20 1 file changed, 20 deletions(-) diff

[PATCH 08/38] staging: comedi: das16: cleanup analog output subdevice

All the boards supported by this driver that have analog outputs use the same function to handle the (*insn_write) for the subdevice. They all also have 12-bit resolution (maxdata = 0x0fff). Remove the 'ao' and 'ao_nbits' members from the boardinfo and replace them with a simple bit-field flag 'ha

[PATCH 09/38] staging: comedi: das16: tidy up the comedi_lrange tables

Cleanup the whitespace in the tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 97 ++ 1 file changed, 51 insertions(+), 46 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.

[PATCH 06/38] staging: comedi: das16: all supported board have digital inputs

All the boards supported by this driver have digital inputs and all of then use the same function to handle the (*insn_bits) for the subdevice. Remove the 'di' member from the boardinfo and always initialize the digital input subdevice during the board attach. Tidy up the subdevice init a bit as

[PATCH 07/38] staging: comedi: das16: all supported board have digital outputs

All the boards supported by this driver have digital outputs and all of then use the same function to handle the (*insn_bits) for the subdevice. Remove the 'do_' member from the boardinfo and always initialize the digital output subdevice during the board attach. Tidy up the subdevice init a bit

[PATCH 05/38] staging: comedi: das16: change boardinfo 'ai_nbits' to 'ai_maxdata'

The subdevice functions that used this boardinfo can use the subdevice 's->maxdata' value instead. Tidy up those functions. Change the boardinfo so that the calculation is not needed during the attach. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/

[PATCH 03/38] staging: comedi: das16: fix DMA init during board attach

DMA support is optional in this driver. To enable it, the user passes the desired DMA channel during the board attach. A timer is then used by the driver to periodically get the analog input data from the DMA. Since the DMA support is optional, modify the init code so that it only fails if the DMA

[PATCH 02/38] staging: comedi: das16: remove DMA irq support

As noted in the driver, a timer is always used by this driver to handle the DMA because samples could be dropped while waiting for the DMA done interrupt. Remove the irq setup code as well as the interrupt handler. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- dri

[PATCH 04/38] staging: comedi: das16: all supported board have analog inputs

All the boards supported by this driver have analog inputs and all of then use the same function to handle the (*insn_read) for the subdevice. Remove the 'ai' member from the boardinfo and always initalize the analog input subdevice during the board attach. Tidy up the subdevice init a bit. Sign

[PATCH 01/38] staging: comedi: das16: "timer_mode" is always used for DMA

As noted in the driver, a timer is always used by this driver to handle the DMA due to buggy DMA controllers and the lack of a hardware fifo in some of the supported boards. Remove all the non-timer mode specific code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 00/38] staging: comedi: das16: cleanup driver

Remove the disabled interrupt support code. This driver always uses a timer with DMA due to the hardware dropping samples when interrrupts are used. Cleanup the boardinfo to just contain the necessary board specific information. Tidy up the driver. H Hartley Sweeten (38): staging: comedi: das1

Re: linux-next: Tree for Jul 29 (staging/gdm724x)

On Mon, Jul 29, 2013 at 10:04:41AM -0700, Randy Dunlap wrote: > On 07/28/13 23:39, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20130726: > > > > on i386: > # CONFIG_TTY is not set Thanks, now fixed. greg k-h ___ devel mailing list de...

Re: [PATCH v2 1/5] Staging: bcm: LeakyBucket: Fixed spacing/tabing issues

On Sun, Jul 28, 2013 at 03:34:43AM +0800, Lilis Iskandar wrote: > Sorry, I'm using git send-email now (previously Evolution). Fingers > crossed there won't be any more formatting issues. I also tested the > patches by emailing them to myself and use git am. > > Joe, I don't understand what you mea

Re: [PATCH] staging: android: logger..c fixed a brace coding style issue

On Sun, Jul 28, 2013 at 04:47:51PM +0300, abbasjasim wrote: > fixed a coding style issue. > > Signed-off-by: Abbas J. Mohammed > --- > drivers/staging/android/logger.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/android/logger.c > b/drivers/stagin

Re: [PATCH 09/20] staging: octeon-usb: cvmx-usb: replace long udelays with mdelays

> > > -cvmx_wait_usec(1000); > > > +mdelay(1); > > > > why not udelay here? > > It's long enough so that mdelay can be used. :) sorry, I was meaning usleep_range :) > > > -cvmx_wait_usec(5); > > > +mdelay(50); > > > > and why not msleep here? > > cvmx_usb_enable() is calle

Re: [PATCH 09/20] staging: octeon-usb: cvmx-usb: replace long udelays with mdelays

Hi, On Mon, Jul 29, 2013 at 07:52:14PM +0200, Andi Shyti wrote: > > -cvmx_wait_usec(1000); > > +mdelay(1); > > why not udelay here? It's long enough so that mdelay can be used. :) > > -cvmx_wait_usec(5); > > +mdelay(50); > > and why not msleep here? cvmx_usb_enable() is ca

Re: [PATCH 09/20] staging: octeon-usb: cvmx-usb: replace long udelays with mdelays

Hi Aaro, > -cvmx_wait_usec(1000); > +mdelay(1); why not udelay here? > -cvmx_wait_usec(5); > +mdelay(50); and why not msleep here? Andi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/ma

Re: linux-next: Tree for Jul 29 (staging/gdm724x)

On 07/28/13 23:39, Stephen Rothwell wrote: > Hi all, > > Changes since 20130726: > on i386: # CONFIG_TTY is not set ERROR: "tty_port_tty_get" [drivers/staging/gdm724x/gdmtty.ko] undefined! ERROR: "tty_port_close_end" [drivers/staging/gdm724x/gdmtty.ko] undefined! ERROR: "tty_register_driver" [

[PATCH 18/20] staging: octeon-usb: cvmx-usb: convert @return

Convert "@return" to "Returns: ". Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 72 +-- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-usb/cvmx-usb.c index

[PATCH 20/20] staging: octeon-usb: cvmx-usb: reformat documentation

Reformat the high-level documentation to human readable plain text by removing HTML and other tags. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.h | 101 -- 1 file changed, 48 insertions(+), 53 deletions(-) diff --git a/drivers/staging/oct

[PATCH 16/20] staging: octeon-usb: cvmx-usb: delete duplicated documentation from .h file

Delete duplicated function call documentation from the .h file. These functions are just internal anyway, and the .h file will be completely removed in the future when the driver will be made a single self-contained .c file. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.h

[PATCH 14/20] staging: octeon-usb: cvmx-usb: reformat long comments

Reformat long comments according to multi-line comment style. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 717 ++ 1 file changed, 462 insertions(+), 255 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/stagin

[PATCH 15/20] staging: octeon-usb: cvmx-usb: delete @INTERNAL

Delete "@INTERNAL" from comments. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-usb/cvmx-usb.c index 025671a..d3da546 100644 --- a/d

[PATCH 17/20] staging: octeon-usb: cvmx-usb: convert @param

Convert "@param name" inside comments to "@name:". Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 268 +- 1 file changed, 134 insertions(+), 134 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-us

[PATCH 06/20] staging: octeon-usb: cvmx-usb: delete __cplusplus

Delete __cplusplus. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.h b/drivers/staging/octeon-usb/cvmx-usb.h index ffabfbe..e7b524b 100644 --- a/drivers/staging/octeon-usb/cvmx

[PATCH 01/20] staging: octeon-usb: depend on CAVIUM_OCTEON_SOC

The USB driver should depend on SOC instead of CPU. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/Kconfig b/drivers/staging/octeon-usb/Kconfig index 018af6d..16ea17f 100644 --- a

[PATCH 11/20] staging: octeon-usb: cvmx-usb: replace cvmx_le16_to_cpu with le16_to_cpu

Replace cvmx_le16_to_cpu() with le16_to_cpu(). Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-usb/cvmx-usb.c index 906c7d8..49a1794 10064

[PATCH 09/20] staging: octeon-usb: cvmx-usb: replace long udelays with mdelays

Replace long udelays with mdelays. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-usb/cvmx-usb.c index efea87b..fadc695 100644 --- a/dri

[PATCH 10/20] staging: octeon-usb: cvmx-usb: replace cvmx_wait_usec with udelay

Just use udelay(). Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-usb/cvmx-usb.c index fadc695..906c7d8 100644 --- a/drivers/staging/oc

[PATCH 00/20] staging: octeon-usb: cvmx-usb cleanups

Hi, These are cleanups mainly for cvmx-usb file. No functional changes. Tested with EdgeRouter Lite + USB mass storage. Aaro Koskinen (20): staging: octeon-usb: depend on CAVIUM_OCTEON_SOC staging: octeon-usb: use correct board type for EdgeRouter Lite staging: octeon-usb: cvmx-usb: delete

[PATCH 19/20] staging: octeon-usb: cvmx-usb: delete CVS keyword markers

Delete CVS keyword markers. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 2 -- drivers/staging/octeon-usb/cvmx-usb.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-usb/cvmx-usb.c index a3ac340..fa0

[PATCH 05/20] staging: octeon-usb: cvmx-usb: delete redundant example code

Delete redundant example code found in comments. It's already there in the driver proper. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.h | 209 +- 1 file changed, 1 insertion(+), 208 deletions(-) diff --git a/drivers/staging/octeon-usb/cvm

[PATCH 02/20] staging: octeon-usb: use correct board type for EdgeRouter Lite

Use CVMX_BOARD_TYPE_UBNT_E100 for EdgeRouter Lite. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-usb/cvmx-usb.c index bf36649..6c7bcf

[PATCH 07/20] staging: octeon-usb: cvmx-usb: utilize Linux error codes

Use generic Linux error codes to replace cvmx_usb_status_t. The conversion table: Before After cvmx_usb_status_t int CVMX_USB_SUCCESS0 CVMX_USB_INVALID_PARAM -EINVAL CVMX_USB_NO_MEMORY

[PATCH 03/20] staging: octeon-usb: cvmx-usb: delete driver-specific tracing code

Delete call, parameter, and return value tracing. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 325 +- 1 file changed, 87 insertions(+), 238 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-usb/

[PATCH 12/20] staging: octeon-usb: cvmx-usb: delete __cvmx_usb_complete_to_string()

Delete a redundant function. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-usb/cvmx-usb.c index 49a1794..976ba19 100644 --- a/

[PATCH 04/20] staging: octeon-usb: cvmx-usb: delete redundant debug flags

Delete redudant debug flags and dead code behind them. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 87 +-- drivers/staging/octeon-usb/cvmx-usb.h | 7 --- 2 files changed, 2 insertions(+), 92 deletions(-) diff --git a/drivers/staging/

[PATCH 08/20] staging: octeon-usb: cvmx-usb: eliminate cvmx_likely/unlikely

Just use likely/unlikely. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/cvmx-usb.c | 94 +-- 1 file changed, 46 insertions(+), 48 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usb.c b/drivers/staging/octeon-usb/cvmx-usb.c index 9604353.

JOB OFFER

Hello Dear, I am Mr. Tony Morgan, Native of Scotland . I am residing in Rome for about Three months now working, but my family is in London,I will love to hire a caring male or female house keeper directly who is willing to work in my house in London as a house keeper.I will like you to know tha

Re: [patch] staging: comedi: dt9812: Resolves sparse endian warnings.

Ok, I'll send in this additional patch. On Mon, Jul 29, 2013 at 9:03 AM, Ian Abbott wrote: > On 2013-07-26 19:19, H Hartley Sweeten wrote: >> >> On Friday, July 26, 2013 10:59 AM, Shaun Laing wrote: >> >> Please make sure to copy the mailing list... ;-) >> >>> I'm sorry Hartley, >>> >>> I'm real

Re: [patch] staging: comedi: dt9812: Resolves sparse endian warnings.

On 2013-07-26 19:19, H Hartley Sweeten wrote: On Friday, July 26, 2013 10:59 AM, Shaun Laing wrote: Please make sure to copy the mailing list... ;-) I'm sorry Hartley, I'm really new at this so there's probably something I'm doing wrong. Do you have time to help me figure this out? Here's ho

[PATCH resend] staging: zcache: fix "zcache=" kernel parameter

From: Piotr Sarna Commit 835f2f5 ("staging: zcache: enable zcache to be built/loaded as a module") introduced an incorrect handling of "zcache=" parameter. Inside zcache_comp_init() function, zcache_comp_name variable is checked for being empty. If not empty, the above variable is tested for bei