As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...". The variables in the private data that are marked
volatile don't need to be. Remove the volatile.
Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com>
Cc: Ian Abbott <abbo...@mev.co.uk>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
drivers/staging/comedi/drivers/das16.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das16.c
b/drivers/staging/comedi/drivers/das16.c
index d86ed2c..95261a6 100644
--- a/drivers/staging/comedi/drivers/das16.c
+++ b/drivers/staging/comedi/drivers/das16.c
@@ -351,8 +351,8 @@ static inline int timer_period(void)
struct das16_private_struct {
unsigned int clockbase; /* master clock speed in ns */
- volatile unsigned int control_state; /* dma, interrupt and trigger
control bits */
- volatile unsigned long adc_byte_count; /* number of bytes remaining */
+ unsigned int control_state; /* dma, interrupt and trigger control
bits */
+ unsigned long adc_byte_count; /* number of bytes remaining */
/* divisor dividing master clock to get conversion frequency */
unsigned int divisor1;
/* divisor dividing master clock to get conversion frequency */
@@ -361,7 +361,7 @@ struct das16_private_struct {
uint16_t *dma_buffer[2];
dma_addr_t dma_buffer_addr[2];
unsigned int current_buffer;
- volatile unsigned int dma_transfer_size; /* target number of
bytes to transfer per dma shot */
+ unsigned int dma_transfer_size; /* target number of bytes to transfer
per dma shot */
/**
* user-defined analog input and output ranges
* defined from config options
@@ -370,7 +370,7 @@ struct das16_private_struct {
struct comedi_lrange *user_ao_range_table;
struct timer_list timer; /* for timed interrupt */
- volatile short timer_running;
+ short timer_running;
unsigned long extra_iobase;
};
--
1.8.3.2
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
