On 2021-08-16 14:40, Harry Wentland wrote:
On 2021-08-16 7:10 a.m., Brian Starkey wrote:
On Fri, Aug 13, 2021 at 10:42:12AM +0530, Sharma, Shashank wrote:
Hello Brian,
(+Uma in cc)
Thanks for your comments, Let me try to fill-in for Harry to keep the
design
discussion going. Please find my c
Greetings,
Original proposal:
https://www.mail-archive.com/amd-gfx@lists.freedesktop.org/msg62387.html
Abstract: Add "preferred color format", "active color format", "active
bpc", and "active Broadcast RGB" drm properties,
to control color information send to the monitor.
It seems that the
ers
> - elaborated commit message (Luis)
> - collected given tags (incl. Andrew's SoB, see below)
>
> I added Andrew's SoB since part of the fixes I took from him. Andrew,
> feel free to amend or tell me how you want me to do.
>
> [...]
> drivers/power/re
Document the compatible for GE B1x5pv2 boards.
Signed-off-by: Sebastian Reichel
---
Documentation/devicetree/bindings/arm/fsl.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
b/Documentation/devicetree/bindings/arm/fsl.yaml
Document binding for congatec.
Signed-off-by: Sebastian Reichel
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index
from the blank
time. In order to expose the correct display size to userspace,
the stride is increased without increasing the width.
Without this patch systems with this display resolution hang
indefinitely during boot up.
Suggested-by: Boris Brezillon
Signed-off-by: Sebastian Reichel
s) and also the bootloader enables it
in case an something (e.g. an unpatched kernel) disabled this
incorrectly.
A workaround for this issue is describing the square wave pin
as fixed-clock, which is registered early and basically how
this pin is used on the i.MX6.
Suggested-by: Saravana Kannan
Signed-of
This adds device tree files for the General Electric Healthcare
(GEHC) B1x5v2 series. All models make use of Congatec's QMX6 module,
which is described in its own device tree include, so that it can
also be used by other boards.
Signed-off-by: Sebastian Reichel
---
arch/arm/boot/dts/Mak
ps://lore.kernel.org/dri-devel/20200910162831.321556-1-sebastian.reic...@collabora.com/
-- Sebastian
Sebastian Reichel (5):
rtc: m41t80: add support for fixed clock
drm/imx: Add 8 pixel alignment fix
dt-bindings: vendor-prefixes: add congatec
dt-bindings: arm: fsl: add GE B1x5pv2 boards
ARM: dts: imx6:
On 2021-04-26 20:56, Harry Wentland wrote:
On 2021-04-26 2:07 p.m., Ville Syrjälä wrote:
On Mon, Apr 26, 2021 at 01:38:50PM -0400, Harry Wentland wrote:
From: Bhawanpreet Lakha
Add the following color encodings
- RGB versions for BT601, BT709, BT2020
- DCI-P3: Used for digital movies
Signed-
more legacy applications working.
Delay frequency settings have been taken over from
drm_fb_helper_generic_probe().
Reported-by: Carl Philipp Klemm
Tested-by: Carl Philipp Klemm
Signed-off-by: Sebastian Reichel
---
Hi,
I still need to fix my Droid 4, so I only compile tested this
myself
> ---
Reviewed-by: Sebastian Reichel
Also maybe add this, so that it is properly backported. OTOH old code did
not have IRQF_ONESHOT either.
Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")
-- Sebastian
> Change in v2:
> -Modify the fourth parameter
7; tag with the
first 12 characters of the SHA-1 ID, and the one line summary. Do
not split the tag across multiple lines, tags are exempt from the
"wrap at 75 columns" rule in order to simplify parsing scripts.
Otherwise:
Reviewed-by: Sebastian Reichel
-- Sebastian
> Signed-off-by:
same
time using the libcamera cam command.
I would like to thank you a lot for making this possible.
If you like to you can add:
Tested-by: Sebastian Fricke
On 02.02.2021 15:56, Heiko Stuebner wrote:
The rk3399 has two ISPs and right now only the first one is usable.
The second ISP is connected to
Hey Heiko,
On 03.02.2021 20:54, Heiko Stübner wrote:
Hi Sebastian,
Am Mittwoch, 3. Februar 2021, 19:14:22 CET schrieb Sebastian Fricke:
Hey Heiko,
I have tested your patch set on my nanoPC-T4, here is a complete log
with:
- relevant kernel log entries
- system information
- media ctl output
Hey Heiko,
On 10.02.2021 12:15, Heiko Stübner wrote:
Hi Sebastian,
Am Freitag, 5. Februar 2021, 15:55:56 CET schrieb Heiko Stübner:
Hi Sebastian,
I did some tests myself today as well and can confirm your
hdmi related finding - at least when plugged in on boot.
I tried some combinations of
LP855x backlight driver,
> - TI LP8727 charger driver,
> - TI LP8788 MFD (ADC, LEDs, charger and regulator) drivers.
>
> Signed-off-by: Krzysztof Kozlowski
> Cc: Mark Brown
> Cc: Jonathan Cameron
> Cc: Jingoo Han
> Cc: Lee Jones
> Cc: Pavel Machek
> Cc: Thierr
Hey Heiko,
On 11.02.2021 15:42, Heiko Stübner wrote:
Hi Sebastian,
Am Donnerstag, 11. Februar 2021, 06:25:15 CET schrieb Sebastian Fricke:
Hey Heiko,
On 10.02.2021 12:15, Heiko Stübner wrote:
>Hi Sebastian,
>
>Am Freitag, 5. Februar 2021, 15:55:56 CET schrieb Heiko Stübner:
>&g
: Sebastian Fricke
Greetings,
Sebastian
On 10.02.2021 12:10, Heiko Stuebner wrote:
The rk3399 has two ISPs and right now only the first one is usable.
The second ISP is connected to the TXRX dphy on the soc.
The phy of ISP1 is only accessible through the DSI controller's
io-memory, so this s
Document binding for congatec.
Signed-off-by: Sebastian Reichel
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index
devicetree/bindings/clock/clock-bindings.txt.
Signed-off-by: Sebastian Reichel
---
Documentation/devicetree/bindings/rtc/rtc-m41t80.txt | 1 +
drivers/rtc/rtc-m41t80.c | 3 +++
2 files changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/rtc/rtc-m4
This adds device tree files for the General Electric Healthcare
(GEHC) B1x5v2 series. All models make use of Congatec's QMX6 module,
which is described in its own device tree include, so that it can
also be used by other boards.
Signed-off-by: Sebastian Reichel
---
arch/arm/boot/dts/Mak
full context for the problem.
https://lore.kernel.org/dri-devel/20200910162831.321556-1-sebastian.reic...@collabora.com/
-- Sebastian
Sebastian Reichel (6):
rtc: m41t80: add support for protected clock
drm/imx: Add 8 pixel alignment fix
dt-bindings: vendor-prefixes: add congatec
dt-bindin
The binding is already used by the driver. Update documentation
accordingly.
Signed-off-by: Sebastian Reichel
---
Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
b/Documentation
Document the compatible for GE B1x5pv2 boards.
Signed-off-by: Sebastian Reichel
---
Documentation/devicetree/bindings/arm/fsl.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
b/Documentation/devicetree/bindings/arm/fsl.yaml
from the blank
time. In order to expose the correct display size to userspace,
the stride is increased without increasing the width.
Suggested-by: Boris Brezillon
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/imx/imx-drm-core.c | 19 ++-
drivers/gpu/drm/imx/imx-ldb.c
Hi,
On Mon, Feb 22, 2021 at 10:26:26PM +0100, Alexandre Belloni wrote:
> On 22/02/2021 22:20:47+0100, Alexandre Belloni wrote:
> > On 22/02/2021 18:12:42+0100, Sebastian Reichel wrote:
> > > Congatec's QMX6 system on module (SoM) uses a m41t62 as RTC. The
> > > m
Hi,
On Mon, Feb 22, 2021 at 06:15:11PM -0600, Rob Herring wrote:
> On Mon, Feb 22, 2021 at 11:13 AM Sebastian Reichel
> wrote:
> >
> > The binding is already used by the driver. Update documentation
> > accordingly.
> >
> > Signed-off-by: Sebastian Reichel
&
From: Sebastian Reichel
Disable TE for Droid 4 panel, since implementation is currently
broken. Also disable it for N950 panel, which is untested.
Reported-by: Tony Lindgren
Reported-by: Tomi Valkeinen
Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")
Sig
Hi,
On Sat, Mar 06, 2021 at 11:56:45AM -0800, Rob Herring wrote:
> On Tue, Feb 23, 2021 at 02:26:57AM +0100, Sebastian Reichel wrote:
> > On Mon, Feb 22, 2021 at 10:26:26PM +0100, Alexandre Belloni wrote:
> > > On 22/02/2021 22:20:47+0100, Alexandre Belloni wrote:
> > &g
On 2021-05-17 10:57, Pekka Paalanen wrote:
On Fri, 14 May 2021 17:05:11 -0400
Harry Wentland wrote:
On 2021-04-27 10:50 a.m., Pekka Paalanen wrote:
> On Mon, 26 Apr 2021 13:38:49 -0400
> Harry Wentland wrote:
...
>> ## Mastering Luminances
>>
>> Now we are able to use the PQ 2084 EOTF to
On 2021-05-14 23:07, Harry Wentland wrote:
Use the new DRM RFC doc section to capture the RFC previously only
described in the cover letter at
https://patchwork.freedesktop.org/series/89506/
Update the RFC based on feedback received:
* don't use color_encoding property to define color space
*
On 2021-05-18 16:19, Harry Wentland wrote:
On 2021-05-18 3:56 a.m., Pekka Paalanen wrote:
On Mon, 17 May 2021 15:39:03 -0400
Vitaly Prosyak wrote:
On 2021-05-17 12:48 p.m., Sebastian Wick wrote:
On 2021-05-17 10:57, Pekka Paalanen wrote:
On Fri, 14 May 2021 17:05:11 -0400
Harry Wentland
Hi Laurent,
On Sun, Nov 29, 2020 at 12:08:47AM +0200, Laurent Pinchart wrote:
> On Fri, Nov 27, 2020 at 09:04:29PM +0100, Sebastian Reichel wrote:
> > The probe routine acquires the reset GPIO using GPIOD_OUT_LOW. Directly
> > afterwards it calls acx565akm_detect(), which sets th
er Ujfalusi
Reported-by: Tony Lindgren
Reported-by: Aaro Koskinen
Reported-by: Ivaylo Dimitrov
Cc: Merlijn Wajer
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Fixes: 1c8fc3f0c5d2 ("drm/panel: Add driver for the Sony ACX565AKM panel")
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/pan
Hi,
On Mon, Nov 09, 2020 at 12:08:33PM +0200, Tomi Valkeinen wrote:
> On 09/11/2020 11:52, Laurent Pinchart wrote:
> > Hi Tomi,
> >
> > Thank you for the patch.
> >
> > On Thu, Nov 05, 2020 at 02:03:04PM +0200, Tomi Valkeinen wrote:
> >> From: Sebas
will result in panel drivers being compatible only
> with specific DSI hosts. It's a difficult issue, but I think we need to
> extend the DSI API to handle this cleanly.
Just some background info, since I looked into this while moving
the driver to the common drm/dsi infrastructure (I used existing
DSI drivers as reference):
IIRC most DSI host drivers do not seem support command mode at all.
Some seemed to support it from within the host driver, though. I
remember Exynos getting the TE gpio in the host driver and using
the IRQ routine to self-refresh (which would effectively always
refresh wasting lots of power compared to only refreshing on page
flip).
Also there are some command mode panel drivers (can be found by
looking for drivers _not_ setting the MIPI_DSI_MODE_VIDEO flag):
* panel-novatek-nt35510.c
* panel-samsung-s6d16d0.c
* panel-samsung-s6e63j0x03.c
* panel-samsung-s6e3ha2.c
* panel-sharp-lq101r1sx01.c
* panel-sony-acx424akp.c
So extending the DSI API will involve more drivers than omapdrm and
its DSI command mode panel driver and should probably be done in its
own series.
-- Sebastian
signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
routines. Assuming the problem does not get solved
magically the system will be busy printing warnings forever.
I have been through that fun while working on the OMAP DSI
command mode patches and I suggest to only do ratelimited
logging in the code related to damage tracking.
-- Sebastian
signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
sted-by: Sam Ravnborg
> Cc: Thierry Reding
> Cc: Sam Ravnborg
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Rob Herring
> Cc: Lucas Stach
> Cc: Sebastian Reichel
> Signed-off-by: Liu Ying
> ---
Is this part of a bigger patchset updating the fsl,imx6q-ldb
bindi
On Tue, 07 Sep 2021 10:19:03 +
Simon Ser wrote:
> FWIW, I've just hit a case where a compositor leaves a "rotation" KMS
> prop set behind, then Xorg tries to startup and fails because it doesn't
> reset this prop. So none of this is theoretical.
>
> I still think a "reset all KMS props to an
e with respect to all
> the component devices that make up the aggregate device.
>
> Cc: Sebastian Reichel
> Cc:
> Cc: Daniel Vetter
> Cc: "Rafael J. Wysocki"
> Cc: Rob Clark
> Cc: Russell King
> Cc: Saravana Kannan
> Signed-off-by: Stephen Boyd
>
t; drivers/gpu/drm/panel/panel-dsi-cm.c:271: WARNING: use scnprintf or sprintf.
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> Signed-off-by: Qing Wang
> ---
The patch subject could be more specific (this updates just one panel driver).
Otherwise
mapdss-base and omapdss, and just compile everything
> into omapdrm.ko.
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/Kconfig | 119 ++-
> drivers
Hi,
On Tue, Nov 24, 2020 at 02:45:09PM +0200, Tomi Valkeinen wrote:
> The functions in display.c are not used, so drop the file.
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/
Hi,
On Tue, Nov 24, 2020 at 02:45:10PM +0200, Tomi Valkeinen wrote:
> dssdev->owner is set, but never used. We can drop the field.
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/
gt; calls to dispc.
>
> Signed-off-by: Tomi Valkeinen
> Acked-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/base.c| 5 --
> drivers/gpu/drm/omapdrm/dss/dispc.c | 101 +++---
> drivers/gp
Hi,
On Tue, Nov 24, 2020 at 02:45:12PM +0200, Tomi Valkeinen wrote:
> dss_mgr_ops was needed with the multi-module architecture, but is no
> longer needed. We can thus remove it and use direct calls.
>
> Signed-off-by: Tomi Valkeinen
> Acked-by: Laurent Pinchart
> ---
Revi
Hi,
On Tue, Nov 24, 2020 at 02:45:13PM +0200, Tomi Valkeinen wrote:
> Use the common MIPI_DCS_GET_ERROR_COUNT_ON_DSI define instead of
> driver's own.
>
> Signed-off-by: Tomi Valkeinen
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/panel/pane
Hi,
On Tue, Nov 24, 2020 at 02:45:14PM +0200, Tomi Valkeinen wrote:
> Simplify the code by moving code from _dsicm_enable_te() into
> dsicm_power_on().
>
> Signed-off-by: Tomi Valkeinen
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/panel/p
Hi,
On Tue, Nov 24, 2020 at 02:45:15PM +0200, Tomi Valkeinen wrote:
> Add address-cells & size-cells to DSI nodes so that board files do not
> need to define them.
>
> Signed-off-by: Tomi Valkeinen
> Cc: Tony Lindgren
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
y on such cases.
>
> Signed-off-by: Tomi Valkeinen
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/pll.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/pll.c
> b/drivers/gpu/drm/omapdrm/dss/pll.c
&g
Hi,
On Tue, Nov 24, 2020 at 02:45:17PM +0200, Tomi Valkeinen wrote:
> The DSI host driver currently ignores the video mode flags in
> client->mode_flags. Add the code to take the transfer mode from client's
> mode_flags.
>
> Signed-off-by: Tomi Valkeinen
> ---
Revi
Hi,
On Tue, Nov 24, 2020 at 02:45:18PM +0200, Tomi Valkeinen wrote:
> Set the column & page address once during setup, instead of relying the
> DSI host driver to set those.
>
> Signed-off-by: Tomi Valkeinen
> ---
I'm fine with or without removal of the variables:
Hi,
On Tue, Dec 08, 2020 at 02:28:27PM +0200, Tomi Valkeinen wrote:
> Simplify the code by moving code from _dsicm_enable_te() into
> dsicm_power_on().
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Sam Ravnborg
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-
Hi,
On Tue, Dec 08, 2020 at 02:28:28PM +0200, Tomi Valkeinen wrote:
> Add address-cells & size-cells to DSI nodes so that board files do not
> need to define them.
>
> Signed-off-by: Tomi Valkeinen
> Cc: Tony Lindgren
> Acked-by: Tony Lindgren
> ---
Revie
iewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c
> b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index c3592c6db977..7fee9cf8
y on such cases.
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/pll.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/pll.c
> b
rt
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/panel/panel-dsi-cm.c | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c
> b/drivers/gpu/drm/panel/panel-dsi-cm.c
> index 38f79dca1fd0..556f9a
ng from the DSI spec:
>
> "To enable PHY synchronization the host processor should periodically
> end HS transmission and drive the Data Lanes to the LP state. This
> transition should take place at least once per frame."
>
> Signed-off-by: Tomi Valkeinen
> Reviewed
rent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 49 ---
> 1 file changed, 13 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c
> b/drivers/gpu/drm/omapdrm/dss/dsi.
ed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 11 ---
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c
> b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index 5e13478010db..c78ae99
Hi,
On Tue, Dec 08, 2020 at 02:28:35PM +0200, Tomi Valkeinen wrote:
> The "channel" usage in omap dsi driver is confusing. As the first step,
> change "channel" to "dispc_channel" when dealing with the dispc channel.
>
> Signed-off-by: Tomi Valkei
some places 1) and 2) have gotten mixed up (i.e. the code
> uses msg->channel when it should use vc), which will be fixed in the
> following patch.
>
> Note that mixing 1) and 2) currently is "fine", as at the moment we only
> support DSI peripherals with DSI virtual c
ctional changes.
>
> Signed-off-by: Tomi Valkeinen
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 54 ---
> 1 file changed, 28 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c
&
> > return r;
> > @@ -2711,11 +2711,11 @@ static int dsi_vc_send_short(struct dsi_data *dsi,
> > int vc,
> >
> > if (dsi->debug_write)
> > DSSDBG("dsi_vc_send_short(ch%d, dt %#x, b1 %#x, b2 %#x)\n",
> > -
Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c
> b/drivers/gpu/drm/om
ifferent VC for video data, the VC is in LP mode.
> Fix this by always enabling HS mode before starting a frame update.
>
> Signed-off-by: Tomi Valkeinen
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 2 ++
> 1 file changed, 2 insertions
y: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c
> b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index
Hi,
On Tue, Dec 08, 2020 at 02:28:42PM +0200, Tomi Valkeinen wrote:
> We have a useless 'if' in the dsicm_bl_update_status(), a left over from
> the conversion to DRM model. Drop the if.
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Sam Ravnborg
> ---
Re
@@ -531,6 +523,7 @@ static int dsicm_probe(struct mipi_dsi_device *dsi)
> struct panel_drv_data *ddata;
> struct backlight_device *bldev = NULL;
> struct device *dev = &dsi->dev;
> + const struct of_device_id *id;
> int r;
>
> dev_dbg(de
t; #include
> #include
> -#include
> -#include
> -#include
Note, that 'of_device_get_match_data', which I suggested in
previous patch is defined in . Otherwise
Reviewed-by: Sebastian Reichel
-- Sebastian
> #include
>
> #include
> --
> Texas Ins
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 384 +
> drivers/gpu/drm/omapdrm/dss/dsi.h | 459 ++
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 64
>
Hi,
On Tue, Dec 08, 2020 at 02:28:46PM +0200, Tomi Valkeinen wrote:
> Clean up the code by inlining dsi_enable_video_outputs and
> dsi_disable_video_outputs functions.
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reic
ra and
> can be dropped, as _dsi_display_enable() has the same WARN_ON().
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 16 +++-
> 1 file changed, 3 inse
ra and
> can be dropped, as _dsi_display_disable() has the same WARN_ON().
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 19 +++
> 1 file ch
DSI interface).
> Rename them by dropping the "display".
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 36 +++
> 1 file chang
Hi,
On Tue, Dec 08, 2020 at 02:28:50PM +0200, Tomi Valkeinen wrote:
> As we now have a fixed setup for VCs (VC0 for video stream, VC1 for
> commands), we can simplify the VC setup.
>
> Signed-off-by: Tomi Valkeinen
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drive
Hi,
On Tue, Dec 08, 2020 at 02:28:51PM +0200, Tomi Valkeinen wrote:
> Clean up the code by separating video-mode enable/disable code into
> functions of their own.
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Seb
pretty useless.
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 12 +---
> drivers/gpu/drm/omapdrm/dss/dsi.h | 2 --
> 2 files changed, 5 insertions(+), 9 de
els
> too.
>
> Fix this by skipping the set for video mode.
>
> Signed-off-by: Tomi Valkeinen
> Reviewed-by: Laurent Pinchart
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(
so prepare() cannot
> be used to send DSI commands.
>
> This patch fixes the issue by making it possible to enable the DSI
> interface any time a command is about to be sent. Disabling the
> interface is be done via delayed work.
>
> Signed-off-by: Tomi Valkeinen
> ---
R
ble, it might be good to just
keep this until it is being fixed considering this is very close to
the end of the series anyways?
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 297 +-
> drivers/gpu/drm/omapdrm/dss/dsi.h | 4 -
> 2 files changed, 8 inse
Hi,
On Mon, Dec 14, 2020 at 08:55:36PM +0200, Tomi Valkeinen wrote:
> On 14/12/2020 19:39, Sebastian Reichel wrote:
> > Hi,
> >
> > On Tue, Dec 08, 2020 at 02:28:53PM +0200, Tomi Valkeinen wrote:
> >> ULPS doesn't work, and I have been unable to get it to
./bindings/power/supply/bq25980.yaml| 1 +
> [...]
Acked-by: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
On Fri, Jan 08, 2021 at 01:23:54PM -0800, Dixit, Ashutosh wrote:
> On Tue, 24 Nov 2020 04:44:57 -0800, Tomi Valkeinen wrote:
> >
> > From: Sebastian Reichel
> >
> > The panel driver is no longer using any OMAP specific APIs, so
> > let's mo
Signed-off-by: Sebastian Reichel
---
Laurent introduced and fixed the same issue for the other panels and
this simply replicates the same solution for DSI command mode panel.
---
drivers/video/fbdev/omap2/omapfb/displays/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbd
[replace Tomi's TI mail address with something working]
Hi,
On Fri, Jan 08, 2021 at 08:58:39PM +0100, Sam Ravnborg wrote:
> Hi Sebastian,
>
> On Fri, Jan 08, 2021 at 12:24:41PM +0100, Sebastian Reichel wrote:
> > Standard DRM panel driver for DSI command mode panel use
switch to omapdrm."
and no other intermediate steps are required that way :)
But while looking through CONFIG_FB_OMAP2 references I noticed there
is also a V4L2 driver (CONFIG_VIDEO_OMAP2_VOUT), which seems to
only work with omapfb. IIUIC that driver pr
This macro is only used by omapdrm, which should print
debug messages using the DRIVER category instead of the
default CORE category.
Acked-by: Pavel Machek
Tested-by: Tony Lindgren
Tested-by: Pavel Machek
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_drv.h | 4 ++--
1
This prepares framedone interrupt handling for
manual display update support.
Acked-by: Pavel Machek
Tested-by: Tony Lindgren
Tested-by: Pavel Machek
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 50 +
drivers/gpu/drm/omapdrm
trigger a display
refresh.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 114 ++--
drivers/gpu/drm/omapdrm/omap_crtc.h | 1 +
drivers/gpu/drm/omapdrm/omap_fb.c | 19 +
3 files changed, 129 insertions(+), 5 deletions(-)
diff --git a/d
to current master
* Rework the omap3 workaround patch to only affect omap3
* Add orientation DRM property support
-- Sebastian
Sebastian Reichel (4):
drm/omap: use DRM_DEBUG_DRIVER instead of CORE
drm/omap: don't check dispc timings for DSI
drm/omap: add framedone interrupt support
e DISPC VM for DSI here.
Fixes: 7c27fa57ef31 ("drm/omap: Call dispc timings check operation directly")
Acked-by: Pavel Machek
Tested-by: Tony Lindgren
Tested-by: Pavel Machek
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 18 ++
1 file ch
-by: Ville Syrjälä
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> drivers/gpu/drm/drm_atomic_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c
> b/drivers/gpu/drm/drm_atomic_helper.c
> index 54e2ae614d
nel, we only need to add panel support in the connector .get_modes()
> handler, take connector bus flags (set by the panel) into account, and
> enable/disable the panel in the encoder enable/disable operations
> handlers.
>
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Sebas
cases. If needed
> they will be converted to operate on drm_display_mode natively.
>
> Signed-off-by: Laurent Pinchart
> Tested-by: Sebastian Reichel
> ---
Reviewed-by: Sebastian Reichel
-- Sebastian
> .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 8 +++---
>
Hi,
On Fri, Jan 11, 2019 at 05:51:19AM +0200, Laurent Pinchart wrote:
> Those components are supported by the drm_bridge infrastructure, remove
> the omapdrm-specific driver.
>
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Sebastian Reichel
> ---
Tested-by: Sebastian Reic
rent bridges. These systems can't be supported
> using drm_bridge for now (their support through the omap_dss_device
> infrastructure is not affected), this will be fixed in subsequent
> changes.
>
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Sebastian Reichel
> ---
rc5, (which contains some DSI fixes).
This worked without any manual merge conflicts :). I also rebased
rebased the DSI command mode patchset on top of it. Everything seems
to work fine on Droid 4, so the series is
Tested-by: Sebastian Reichel
I pushed out the rebased branch with DSI
rresponding drm_bridge drivers become available and get
> successfully tested with omapdrm.
>
> The omapdss components load check code is updated accordingly to ignore
> devices managed by external bridge drivers.
>
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Sebastian R
1 - 100 of 1152 matches
Mail list logo
