Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-06-13 Thread andriy.shevche...@linux.intel.com
On Mon, Jun 13, 2022 at 11:39:30AM +, Dominik Kierner wrote: > On 5/25/2022 21:46, Javier Martinez Canillas wrote: ... > > Thanks, I looked at the code briefly and think that there are things there > > that we > > could use. I.e the 3-wire SPI support that's in > > panel-solomon-ssd130x-spi

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-06-01 Thread andriy.shevche...@linux.intel.com
On Wed, May 25, 2022 at 09:46:24PM +0200, Javier Martinez Canillas wrote: > On 3/10/22 14:11, Dominik Kierner wrote: ... > > # DRM Mode Configuration via Device Tree > > > > In the old fbdev driver, the display modes are hard-coded, which means > > for every new display configuration, a new patc

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-19 Thread andriy.shevche...@linux.intel.com
On Wed, Oct 19, 2022 at 09:32:26AM +0200, Thomas Zimmermann wrote: > Am 18.10.22 um 17:52 schrieb Zack Rusin: > IIRC PSB hardware is only available in 32-bit systems. Dunno about deep details, but IIUC the Intel Tangier and Intel Annioedale are 64-bit SoCs that have Imagination + Intel IPs, the l

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-21 Thread andriy.shevche...@linux.intel.com
On Thu, Feb 20, 2025 at 04:39:23PM +, Aditya Garg wrote: > From: Hector Martin > > %p4cc is designed for DRM/V4L2 FOURCCs with their specific quirks, but > it's useful to be able to print generic 4-character codes formatted as > an integer. Extend it to add format specifiers for printing gene

Re: [PATCH v3 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-21 Thread andriy.shevche...@linux.intel.com
On Fri, Feb 21, 2025 at 07:37:17PM +, Aditya Garg wrote: > > On 21 Feb 2025, at 8:59 PM, andriy.shevche...@linux.intel.com wrote: > > On Fri, Feb 21, 2025 at 11:37:13AM +, Aditya Garg wrote: > > First of all, I do not see the cover letter. Is it only an issue on my si

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-21 Thread andriy.shevche...@linux.intel.com
On Fri, Feb 21, 2025 at 08:06:51PM +, Aditya Garg wrote: > > > Does this look good now? Made orig a union. > > Wait, it's messier. Maybe declare data type of val separately in each case? Yes, this sounds better. -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 1/3] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-21 Thread andriy.shevche...@linux.intel.com
On Fri, Feb 21, 2025 at 05:21:08PM +, Aditya Garg wrote: > > On 21 Feb 2025, at 9:21 PM, andriy.shevche...@linux.intel.com wrote: > > On Fri, Feb 21, 2025 at 11:36:00AM +, Aditya Garg wrote: ... > >> + for (x = 0; x < pixels; x++) { > >> + pix = le32_t

Re: [PATCH v3 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-21 Thread andriy.shevche...@linux.intel.com
On Fri, Feb 21, 2025 at 10:18:16PM +0200, andriy.shevche...@linux.intel.com wrote: > On Fri, Feb 21, 2025 at 07:37:17PM +, Aditya Garg wrote: > > > On 21 Feb 2025, at 8:59 PM, andriy.shevche...@linux.intel.com wrote: > > > On Fri, Feb 21, 2025 at 11:37:13AM +00

Re: [PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-21 Thread andriy.shevche...@linux.intel.com
On Fri, Feb 21, 2025 at 07:13:06PM +, Aditya Garg wrote: > > On Fri, Feb 21, 2025 at 11:37:57AM +, Aditya Garg wrote: ... > >> +} __packed; > > > > Why __packed? Please explain and justify for all the data types that are > > marked > > with this attribute. > > Just following the origin

Re: [PATCH v3 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-21 Thread andriy.shevche...@linux.intel.com
On Fri, Feb 21, 2025 at 11:37:13AM +, Aditya Garg wrote: > From: Hector Martin First of all, I do not see the cover letter. Is it only an issue on my side? > %p4cc is designed for DRM/V4L2 FOURCCs with their specific quirks, but > it's useful to be able to print generic 4-character codes for

Re: [PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-21 Thread andriy.shevche...@linux.intel.com
On Fri, Feb 21, 2025 at 11:37:57AM +, Aditya Garg wrote: > From: Kerem Karabay > > The Touch Bars found on x86 Macs support two USB configurations: one > where the device presents itself as a HID keyboard and can display > predefined sets of keys, and one where the operating system has full >

Re: [PATCH v3 1/3] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-21 Thread andriy.shevche...@linux.intel.com
On Fri, Feb 21, 2025 at 11:36:00AM +, Aditya Garg wrote: > From: Kerem Karabay > > Add XRGB emulation helper for devices that only support BGR888. ... > + for (x = 0; x < pixels; x++) { > + pix = le32_to_cpu(sbuf32[x]); > + /* write red-green-blue to output i

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread andriy.shevche...@linux.intel.com
On Tue, Feb 25, 2025 at 10:36:03AM +, Aditya Garg wrote: > > On 25 Feb 2025, at 4:03 PM, andriy.shevche...@linux.intel.com wrote: > > On Tue, Feb 25, 2025 at 10:09:42AM +, Aditya Garg wrote: ... > >> +static int appletbdrm_probe(struct usb_interface *intf, > &

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread andriy.shevche...@linux.intel.com
On Tue, Feb 25, 2025 at 09:48:11AM +0100, Thomas Zimmermann wrote: > Am 25.02.25 um 09:00 schrieb Aditya Garg: > > > On 25 Feb 2025, at 1:22 PM, Thomas Zimmermann wrote: > > > > Am 24.02.25 um 14:40 schrieb Aditya Garg: ... > > > > +struct appletbdrm_device { > > > > +struct device *dev; > >

Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-25 Thread andriy.shevche...@linux.intel.com
On Tue, Feb 25, 2025 at 08:37:32AM +0100, Thomas Zimmermann wrote: > Am 24.02.25 um 15:29 schrieb andriy.shevche...@linux.intel.com: > > On Mon, Feb 24, 2025 at 01:38:32PM +, Aditya Garg wrote: ... > > > +static void drm_fb_xrgb_to_bgr888_line(void *dbuf

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread andriy.shevche...@linux.intel.com
On Tue, Feb 25, 2025 at 10:09:42AM +, Aditya Garg wrote: > From: Kerem Karabay > > The Touch Bars found on x86 Macs support two USB configurations: one > where the device presents itself as a HID keyboard and can display > predefined sets of keys, and one where the operating system has full >

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 01:40:20PM +, Aditya Garg wrote: > From: Kerem Karabay > > The Touch Bars found on x86 Macs support two USB configurations: one > where the device presents itself as a HID keyboard and can display > predefined sets of keys, and one where the operating system has full >

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 10:18:48AM +, Aditya Garg wrote: > > > > On 24 Feb 2025, at 3:28 PM, andriy.shevche...@linux.intel.com wrote: > > > > On Sat, Feb 22, 2025 at 03:46:03PM +, Aditya Garg wrote: > >>>> On 20 Feb 2025, at 10:09 PM, Aditya Garg

Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 01:38:32PM +, Aditya Garg wrote: > From: Kerem Karabay > > Add XRGB emulation helper for devices that only support BGR888. ... > +static void drm_fb_xrgb_to_bgr888_line(void *dbuf, const void *sbuf, > unsigned int pixels) Okay the xrgb is the actual pix

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 02:32:37PM +, Aditya Garg wrote: > > On 24 Feb 2025, at 7:30 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 01:40:20PM +, Aditya Garg wrote: ... > >> +#define __APPLETBDRM_MSG_STR4(str4) ((__le32 __force)((str4[0] &

Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 02:54:07PM +, Aditya Garg wrote: > This conversion helper mimics the existing drm_fb_xrgb_to_rgb888 helper Not really. See below. > > On 24 Feb 2025, at 7:59 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 01:38:32PM +00

Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 05:00:50PM +0200, andriy.shevche...@linux.intel.com wrote: > On Mon, Feb 24, 2025 at 02:54:07PM +, Aditya Garg wrote: > > This conversion helper mimics the existing drm_fb_xrgb_to_rgb888 helper > > Not really. See below. > > > >

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 03:03:40PM +, Aditya Garg wrote: > > On 24 Feb 2025, at 8:27 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 02:32:37PM +, Aditya Garg wrote: > >>> On 24 Feb 2025, at 7:30 PM, andriy.shevche...@linux.intel.com wro

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 03:20:13PM +, Aditya Garg wrote: > > On 24 Feb 2025, at 8:41 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 03:03:40PM +, Aditya Garg wrote: > >>>> On 24 Feb 2025, at 8:27 PM, andriy.shevche...@linux.intel.com

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 03:32:56PM +, Aditya Garg wrote: > > On 24 Feb 2025, at 8:50 PM, Aditya Garg wrote: > >> On 24 Feb 2025, at 8:41 PM, andriy.shevche...@linux.intel.com wrote: > >> On Mon, Feb 24, 2025 at 03:03:40PM +, Aditya Garg wrote: > >&

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 03:39:56PM +, Aditya Garg wrote: > > On 24 Feb 2025, at 9:07 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 03:20:13PM +, Aditya Garg wrote: > >>>> On 24 Feb 2025, at 8:41 PM, andriy.shevche...@linux.intel.com

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 03:40:29PM +, Aditya Garg wrote: > > On 24 Feb 2025, at 9:08 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 03:32:56PM +, Aditya Garg wrote: > >>> On 24 Feb 2025, at 8:50 PM, Aditya Garg wrote: > >

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 03:52:03PM +, Aditya Garg wrote: > > On 24 Feb 2025, at 9:19 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 03:39:56PM +, Aditya Garg wrote: > >>>> On 24 Feb 2025, at 9:07 PM, andriy.shevche...@linux.intel.com

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 03:56:36PM +, Aditya Garg wrote: > > On 24 Feb 2025, at 9:23 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 03:40:29PM +, Aditya Garg wrote: > >>>> On 24 Feb 2025, at 9:08 PM, andriy.shevche...@linux.intel.com

Re: [PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 09:41:43AM +0100, Thomas Zimmermann wrote: > Am 22.02.25 um 10:07 schrieb Aditya Garg: ... > > > What padding, please? Why TCP UAPI headers do not have these attributes? > > > Think about it, and think about what actually __packed does and how it > > > affects > > > (badl

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Sat, Feb 22, 2025 at 03:46:03PM +, Aditya Garg wrote: > > On 20 Feb 2025, at 10:09 PM, Aditya Garg wrote: > > > > %p4cc is designed for DRM/V4L2 FOURCCs with their specific quirks, but > > it's useful to be able to print generic 4-character codes formatted as > > an integer. Extend it to a

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 10:43:54AM +, Aditya Garg wrote: > > On 24 Feb 2025, at 4:11 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 10:32:27AM +, Aditya Garg wrote: > >>>> On 24 Feb 2025, at 3:54 PM, andriy.shevche...@linux.intel.com w

Re: [PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 11:20:12AM +, Aditya Garg wrote: > > > > > It would be nice to see the difference in the code generation for the all > > __packed vs. only those that require it. > > > >> At least it's clear then > >> what happens. And if your hardware requires this, you can't do much

Re: [PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 11:57:47AM +, Aditya Garg wrote: > > On 24 Feb 2025, at 5:13 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 11:20:12AM +, Aditya Garg wrote: > >> > >>> It would be nice to see the difference i

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Sun, Feb 23, 2025 at 06:39:15AM +, Aditya Garg wrote: > > On 22 Feb 2025, at 5:41 PM, Aditya Garg wrote: > >> On 21 Feb 2025, at 8:57 PM, andriy.shevche...@linux.intel.com wrote: > >>> On Thu, Feb 20, 2025 at 04:39:23PM +, Aditya Garg wrote: ... > >

Re: [PATCH v3 1/3] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 10:19:13AM +0100, Thomas Zimmermann wrote: > Am 21.02.25 um 16:51 schrieb andriy.shevche...@linux.intel.com: > > On Fri, Feb 21, 2025 at 11:36:00AM +, Aditya Garg wrote: ... > > > + for (x = 0; x < pixels; x++) { > > > +

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Mon, Feb 24, 2025 at 10:32:27AM +, Aditya Garg wrote: > > On 24 Feb 2025, at 3:54 PM, andriy.shevche...@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 10:18:48AM +, Aditya Garg wrote: > >>>> On 24 Feb 2025, at 3:28 PM, andriy.shevche...@linux.intel.com w

Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

2025-02-24 Thread andriy.shevche...@linux.intel.com
On Sun, Feb 23, 2025 at 03:16:28PM +, Aditya Garg wrote: > > Looking at the header files, it looks like doing cpu_to_le32 on that > > variable and doing le32_to_cpu will actually reverse the order twice, on > > big endian systems, thus technically all way would not swap the order at > > all

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread andriy.shevche...@linux.intel.com
On Tue, Feb 25, 2025 at 02:53:15PM +0100, Thomas Zimmermann wrote: > Am 25.02.25 um 14:27 schrieb andriy.shevche...@linux.intel.com: > > On Tue, Feb 25, 2025 at 12:59:43PM +0100, Thomas Zimmermann wrote: > > > Am 25.02.25 um 12:01 schrieb andriy.shevche...@linux.intel.com: >

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread andriy.shevche...@linux.intel.com
On Tue, Feb 25, 2025 at 10:48:53AM +, Aditya Garg wrote: > > On 25 Feb 2025, at 4:17 PM, andriy.shevche...@linux.intel.com wrote: > > On Tue, Feb 25, 2025 at 10:36:03AM +, Aditya Garg wrote: > >>>> On 25 Feb 2025, at 4:03 PM, andriy.shevche...@linux.intel.com

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread andriy.shevche...@linux.intel.com
On Tue, Feb 25, 2025 at 12:58:17PM +0100, Thomas Zimmermann wrote: > Am 25.02.25 um 11:33 schrieb andriy.shevche...@linux.intel.com: > > On Tue, Feb 25, 2025 at 10:09:42AM +, Aditya Garg wrote: ... > > > +static int appletbdrm_probe(struct u

Re: [PATCH v5 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-25 Thread andriy.shevche...@linux.intel.com
On Tue, Feb 25, 2025 at 12:59:43PM +0100, Thomas Zimmermann wrote: > Am 25.02.25 um 12:01 schrieb andriy.shevche...@linux.intel.com: > > On Tue, Feb 25, 2025 at 10:48:53AM +, Aditya Garg wrote: > > > > On 25 Feb 2025, at 4:17 PM, andriy.shevche...@linux.intel.com wrote: &

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-28 Thread andriy.shevche...@linux.intel.com
On Thu, Feb 27, 2025 at 05:28:33PM +, Aditya Garg wrote: > > On 27 Feb 2025, at 10:24 PM, kernel test robot wrote: > > Hi Aditya, > > > > kernel test robot noticed the following build warnings: > > > > [auto build test WARNING on linus/master] > > [also build test WARNING on v6.14-rc4 next-

Re: [PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc

2025-03-12 Thread andriy.shevche...@linux.intel.com
On Wed, Mar 12, 2025 at 12:51:33PM +0100, Thomas Zimmermann wrote: > Am 12.03.25 um 10:06 schrieb Aditya Garg: ... > If you want to print out protocol-header tokens, why not use formatting > macros as we do with DRM mode? There's one for the format string [1] and one > for the argument. [2] It's