[PATCH 2/4] clk: exynos4: export sclk_hdmiphy clock

2014-04-08 Thread Tomasz Figa
Hi Tomasz, On 04.04.2014 16:53, Tomasz Stanislawski wrote: > Export sclk_hdmiphy clock to be usable from DT. > > Signed-off-by: Tomasz Stanislawski > --- > drivers/clk/samsung/clk-exynos4.c |2 +- > include/dt-bindings/clock/exynos4.h |1 + > 2 files changed, 2 insertions(+), 1 dele

[PATCH 3/4] clk: exynos4: enable clk_set_parent() propagation for sclk_hdmi and sclk_mixer clocks

2014-04-08 Thread Tomasz Figa
On 04.04.2014 16:53, Tomasz Stanislawski wrote: > This patch enables clk_set_parent() propagation for clocks used > by s5p-tv and exynos-drm drivers. > > Signed-off-by: Tomasz Stanislawski > --- > drivers/clk/samsung/clk-exynos4.c |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH 4/4] Revert "drm/exynos: add mout_hdmi clock in hdmi driver to change parent"

2014-04-08 Thread Tomasz Figa
Hi Tomasz, On 04.04.2014 16:53, Tomasz Stanislawski wrote: > This reverts commit 59956d35a8618235ea715280b49447bb36f2c975. > Probably a reason why this commit is being reverted would be a good idea. > Signed-off-by: Tomasz Stanislawski > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 14 -

[PATCH 1/5] drm/exynos: remove dummy hdmiphy clock from hdmi driver

2014-04-10 Thread Tomasz Figa
Hi Rahul, On 02.04.2014 19:13, Rahul Sharma wrote: > From: Rahul Sharma > > Exynos drm hdmi driver used to get dummy hdmiphy clock to > control the PMU bit for hdmiphy. This clock is removed > during CCF migration. This should also be cleaned from > hdmi driver. > > Signed-off-by: Rahul Sharma >

[PATCH 2/5] drm/exynos: use regmap interface to set hdmiphy control bit in pmu

2014-04-10 Thread Tomasz Figa
Hi Rahul, On 02.04.2014 19:13, Rahul Sharma wrote: > From: Rahul Sharma > > Hdmiphy control bit needs to be set before setting the resolution > to hdmi hardware. This was handled using dummy hdmiphy clock which > is removed now. > > PMU is already defined as system controller for exynos SoC. Regi

[PATCH 3/5] drm/exynos: remove unnecessary read for phy configuration values

2014-04-10 Thread Tomasz Figa
DRM_ERROR("failed to read hdmiphy config\n"); > - return; > - } > - > - for (i = 0; i < ret; i++) > - DRM_DEBUG_KMS("hdmiphy[0x%02x] write[0x%02x] - " > - "recv [0x%02x]\n", i, buffer[i], read_buffer[i]); > } > > static void hdmi_conf_apply(struct hdmi_context *hdata) > Reviewed-by: Tomasz Figa -- Best regards, Tomasz

[PATCH 4/5] drm/exynos: add support for apb mapped phys in hdmi driver

2014-04-10 Thread Tomasz Figa
Hi Rahul, On 02.04.2014 19:13, Rahul Sharma wrote: > From: Rahul Sharma > > Previous SoCs have hdmi phys which are accessible through > dedicated i2c lines. Newer SoCs have Apb mapped hdmi phys. > Hdmi driver is modified to support apb mapped phys. > > Signed-off-by: Rahul Sharma > --- > drive

[PATCH RFC 0/2] drm/exynos: refactoring drm device init/deinit

2014-04-14 Thread Tomasz Figa
Hi Inki, On 14.04.2014 13:04, Inki Dae wrote: > > >> -Original Message- >> From: Andrzej Hajda [mailto:a.hajda at samsung.com] >> Sent: Monday, April 14, 2014 5:55 PM >> To: Inki Dae >> Cc: dri-devel at lists.freedesktop.org; moderated list:ARM/S5P EXYNOS AR...; >> Kyungmin Park; Marek Szy

[PATCH RFC 0/2] drm/exynos: refactoring drm device init/deinit

2014-04-14 Thread Tomasz Figa
On 14.04.2014 15:55, Inki Dae wrote: > Hi Tomasz, > > Always thanks for your opinions. > >> -Original Message- >> From: linux-samsung-soc-owner at vger.kernel.org [mailto:linux-samsung-soc- >> owner at vger.kernel.org] On Behalf Of Tomasz Figa >> Sent:

[PATCH v4 00/34] drm/exynos: Refactor parts of the exynos driver

2014-02-07 Thread Tomasz Figa
Hi Sean, On 30.01.2014 22:18, Sean Paul wrote: > This patchset refactors parts of the exynos driver to move it closer to a > proper > drm driver (rather than just implementing a drm layer on top of the hardware > drivers). The hope is to get to a point where the dp/hdmi drivers can > implement >

[PATCH v4 00/34] drm/exynos: Refactor parts of the exynos driver

2014-02-08 Thread Tomasz Figa
On 06.02.2014 20:54, Olof Johansson wrote: > On Thu, Jan 30, 2014 at 1:18 PM, Sean Paul wrote: >> This patchset refactors parts of the exynos driver to move it closer to a >> proper >> drm driver (rather than just implementing a drm layer on top of the hardware >> drivers). The hope is to get to

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-02-08 Thread Tomasz Figa
Hi, On 30.01.2014 22:19, Sean Paul wrote: > From: Daniel Kurtz > > The i2c client was previously being passed into the hdmi driver via a > dedicated i2c driver, and then a global variable. This patch removes all > of that and just uses the device tree to get the i2c_client. This patch > also prop

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-02-11 Thread Tomasz Figa
On 10.02.2014 08:30, Inki Dae wrote: > 2014-02-08 11:52 GMT+09:00 Tomasz Figa : >> Hi, >> >> >> On 30.01.2014 22:19, Sean Paul wrote: >>> >>> From: Daniel Kurtz >>> >>> The i2c client was previously being passed into the hdmi dr

[PATCH v4 14/34] drm/exynos: hdmi: remove the i2c drivers and use devtree

2014-02-12 Thread Tomasz Figa
On 12.02.2014 00:02, Olof Johansson wrote: > On Fri, Feb 7, 2014 at 6:52 PM, Tomasz Figa wrote: > >> Adding new required properties to an already defined binding is breaking >> backwards compatibility, which is supposed to be preserved, since DT is an >> ABI. >> &g

[PATCH v4 00/34] drm/exynos: Refactor parts of the exynos driver

2014-02-27 Thread Tomasz Figa
Hi Inki, On 27.02.2014 05:43, Inki Dae wrote: > Hi Tomasz, > > > 2014-02-08 11:48 GMT+09:00 Tomasz Figa : >> On 06.02.2014 20:54, Olof Johansson wrote: >>> >>> On Thu, Jan 30, 2014 at 1:18 PM, Sean Paul wrote: >>>> >>>> This patchset

[RFC PATCH 0/4] Common Display Framework-TF

2013-02-03 Thread Tomasz Figa
Hi Laurent, On Saturday 02 of February 2013 11:39:59 Laurent Pinchart wrote: > Hi Tomasz, > > Thank you for your RFC. > > On Wednesday 30 January 2013 16:38:59 Tomasz Figa wrote: > > Hi, > > > > After pretty long time of trying to adapt Exynos-specific DSI disp

[RFC PATCH 4/4] video: display: Add Samsung s6e8ax0 display panel driver

2013-02-07 Thread Tomasz Figa
On Thursday 07 of February 2013 15:04:30 Vikas Sajjan wrote: > Hi Figa, > > On Wed, Jan 30, 2013 at 9:09 PM, Tomasz Figa wrote: > > This patch adds Common Display Framework driver for Samsung s6e8ax0 > > MIPI DSI display panel. > > > > Signed-off-by: Tomasz

[PATCH 2/2] [RFC] video: display: Adding frame related ops to MIPI DSI video source struct

2013-01-03 Thread Tomasz Figa
and clear_frame_done do not look at anything used at the moment and if frame done status monitoring will be ever needed, I think a better way should be implemented. Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Linux Platform

[RFC v2 0/5] Common Display Framework

2013-01-08 Thread Tomasz Figa
On Tuesday 08 of January 2013 11:12:26 Marcus Lorentzon wrote: > On 01/08/2013 09:18 AM, Laurent Pinchart wrote: > > On Thursday 27 December 2012 15:43:34 Tomasz Figa wrote: > >> > On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: > >>> > &g

[RFC PATCH 0/4] Common Display Framework-TF

2013-01-30 Thread Tomasz Figa
nd with some hacks to provide control over entity state to userspace using lcd device. However it can be used to demonstrate video source ops in use. Feel free to comment as much as you can. Tomasz Figa (4): video: add display-core video: add makefile & kconfig video: display

[RFC PATCH 1/4] video: add display-core

2013-01-30 Thread Tomasz Figa
Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/display/display-core.c | 295 +++ include/video/display.h | 230 +++ 2 files changed, 525 insertions(+) create mode 100644 drivers/video/display

[RFC PATCH 2/4] video: add makefile & kconfig

2013-01-30 Thread Tomasz Figa
Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/Kconfig | 1 + drivers/video/Makefile | 1 + drivers/video/display/Kconfig | 10 ++ drivers/video/display/Makefile | 1 + 4 files changed, 13 insertions(+) create mode 100644 drivers/video

[RFC PATCH 3/4] video: display: Add exynos-dsi video source driver

2013-01-30 Thread Tomasz Figa
This patch adds new driver for DSI master block available in Samsung Exynos SoCs. The driver is designed and written specifically for Common Display Framework. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/display/Kconfig |3 + drivers/video/display

[RFC PATCH 4/4] video: display: Add Samsung s6e8ax0 display panel driver

2013-01-30 Thread Tomasz Figa
This patch adds Common Display Framework driver for Samsung s6e8ax0 MIPI DSI display panel. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/video/display/Kconfig |3 + drivers/video/display/Makefile|1 + drivers/video/display/panel-s6e8ax0.c | 1027

[PATCH 0/9] Doc/DT: DT bindings for various display components

2014-02-28 Thread Tomasz Figa
Hi Tomi, On 28.02.2014 13:20, Tomi Valkeinen wrote: > Hi, > > This series is a re-send of > http://article.gmane.org/gmane.linux.drivers.devicetree/61739 > > I'm cc'ing more people, and I want to clarify the contents of the series: > > While this has been developed for OMAP, only the first patch i

[PATCH 0/4] drm/exynos: fimd: Add support for S3C6400/S3C6410

2013-05-01 Thread Tomasz Figa
Tree support: Tested-by: Tomasz Figa Tomasz Figa (4): drm/exynos: fimd: Hold pointer to driver data in context struct drm/exynos: fimd: Add support for FIMD versions without SHADOWCON register drm/exynos: fimd: Add support for FIMD variants with clock selection drm/exynos: fimd: Add

[PATCH 1/4] drm/exynos: fimd: Hold pointer to driver data in context struct

2013-05-01 Thread Tomasz Figa
This patch adds pointer to driver data to fimd_context structure, to remove the need to call drm_fimd_get_driver_data() each time access to driver data is necessary. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[PATCH 2/4] drm/exynos: fimd: Add support for FIMD versions without SHADOWCON register

2013-05-01 Thread Tomasz Figa
data. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 69 +++- 1 file changed, 49 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 264434f..a5559f6 100644

[PATCH 3/4] drm/exynos: fimd: Add support for FIMD variants with clock selection

2013-05-01 Thread Tomasz Figa
patch sets the selection bitfield to use the special clock. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index a5559f6..a2e385d

[PATCH 4/4] drm/exynos: fimd: Add support for S3C64xx SoCs

2013-05-01 Thread Tomasz Figa
The FIMD block present on S3C6400/S3C6410 SoCs is compatible with this driver, so it can be supported by it as well. This patch adds appropriate device IDs and driver data to enable this driver for S3C64xx SoCs. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 10

[PATCH] drm/exynos: fimd: Get signal polarities from device tree

2013-05-01 Thread Tomasz Figa
retrieved, in addition to standard video timings. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c

DMA mapping API abuse in exynos-drm

2013-05-04 Thread Tomasz Figa
Hi, Recently I've been working a bit on a DRM driver for the GPU of Samsung S3C6410 SoCs, which required me to familiarize a bit with exynos-drm, as it already contains a KMS driver which is compatible with the SoC I'm working with, making it a good place to put my driver in. Reading through e

Introduce a new helper framework for buffer synchronization

2013-05-13 Thread Tomasz Figa
Hi, On Monday 13 of May 2013 20:24:01 Inki Dae wrote: > > -Original Message- > > From: Maarten Lankhorst [mailto:maarten.lankhorst at canonical.com] > > Sent: Monday, May 13, 2013 6:52 PM > > To: Inki Dae > > Cc: 'Rob Clark'; 'Daniel Vetter'; 'DRI mailing list'; linux-arm- > > kernel at li

[PATCH 0/4] drm/exynos: fimd: Add support for S3C6400/S3C6410

2013-05-19 Thread Tomasz Figa
Hi, On Wednesday 01 of May 2013 21:02:25 Tomasz Figa wrote: > Much of the code in Exynos DRM subsystem is generic enough to use > it for older (non-Exynos) Samsung SoCs as well, after minor > modifications. > > This series starts adding support for previous SoCs to Exynos DRM b

[PATCH] drm/exynos: fimd: Get signal polarities from device tree

2013-05-19 Thread Tomasz Figa
Hi, On Wednesday 01 of May 2013 22:00:25 Daniel Vetter wrote: > On Wed, May 01, 2013 at 09:06:09PM +0200, Tomasz Figa wrote: > > This patch modifies the driver to perform two stage parsing of video > > timings from device tree, to get timing information as struct > > vide

[PATCH] drm/exynos: wait for the completion of pending page flip

2013-05-22 Thread Tomasz Figa
Hi Inki, On Wednesday 22 of May 2013 15:37:14 Inki Dae wrote: > 2013/5/22 St?phane Marchesin > > > On Tue, May 21, 2013 at 9:22 PM, Inki Dae wrote: > > > 2013/5/22 St?phane Marchesin > > > > > >> On Tue, May 21, 2013 at 1:08 AM, Inki Dae wrote: > > >> > This patch fixes the issue that drm_

[PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/

2013-11-01 Thread Tomasz Figa
On Friday 01 of November 2013 08:06:00 Jingoo Han wrote: > On Thursday, October 31, 2013 7:47 PM, Inki Dae wrote: > > CCing Jingoo, > > > > Is that ok to remove eDP driver from video/exynos? Isn't this driver > > really used by Linux framebuffer driver, s3c-fb.c? > > +cc Tomi Valkeinen, Jean-Chri

[PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/

2013-11-01 Thread Tomasz Figa
On Friday 01 of November 2013 08:23:59 Jingoo Han wrote: > On Friday, November 01, 2013 8:12 AM, Tomasz Figa wrote: > > On Friday 01 of November 2013 08:06:00 Jingoo Han wrote: > > > On Thursday, October 31, 2013 7:47 PM, Inki Dae wrote: > > > > CCing Jingoo, > &g

[PATCH v3 01/32] drm/exynos: Remove useless slab.h include

2013-11-01 Thread Tomasz Figa
Hi Sean, St?phane, On Tuesday 29 of October 2013 12:12:47 Sean Paul wrote: > From: St?phane Marchesin > > Signed-off-by: St?phane Marchesin > Signed-off-by: Sean Paul > --- > > Changes in v2: None > Changes in v3: None > > drivers/video/exynos/exynos_dp_core.c | 1 - > 1 file changed, 1 del

[PATCH v3 02/32] drm/exynos: Merge overlay_ops into manager_ops

2013-11-01 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:12:48 Sean Paul wrote: > This patch merges overlay_ops into manager_ops. In all cases, > overlay_ops is implemented in the same place as manager ops, it doesn't > serve a functional purpose, and doesn't make things more clear. > > Signed-off-by: Sean Paul

[PATCH v3 03/32] drm/exynos: Add an initialize function to manager and display

2013-11-01 Thread Tomasz Figa
> > Signed-off-by: Sean Paul > --- > > Changes in v2: None > Changes in v3: None > > drivers/gpu/drm/exynos/exynos_drm_drv.h | 5 + > drivers/gpu/drm/exynos/exynos_drm_encoder.c | 21 + > 2 files changed, 26 insertions(+) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 04/32] drm/exynos: Use manager_op initialize in fimd

2013-11-01 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:12:50 Sean Paul wrote: > This patch implements the intitialize manager op in fimd. > > Signed-off-by: Sean Paul > --- > > Changes in v2: None > Changes in v3: None > > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 19 +++ > 1 file changed

[PATCH v3 05/32] drm/exynos: hdmi: Implement initialize op for hdmi

2013-11-01 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:12:51 Sean Paul wrote: > This patch implements the initialize callback in the hdmi and mixer > manager. This allows us to get rid of drm_dev in the drm_hdmi level and > track it in the mixer and hdmi drivers. This is one of the things > holding back the co

[PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/

2013-11-01 Thread Tomasz Figa
On Friday 01 of November 2013 08:55:12 Jingoo Han wrote: > On Friday, November 01, 2013 8:27 AM, Tomasz Figa wrote: > > On Friday 01 of November 2013 08:23:59 Jingoo Han wrote: > > > On Friday, November 01, 2013 8:12 AM, Tomasz Figa wrote: > > > > On Friday 01 of Nov

[PATCH v3 06/32] drm/exynos: Pass exynos_drm_manager in manager ops instead of dev

2013-11-01 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:12:52 Sean Paul wrote: > This patch changes the manager ops callbacks from accepting the subdrv > device pointer to taking a pointer to the manager. This will allow us > to move closer to decoupling manager/display from subdrv, and > subsequently decouplin

[PATCH v3 02/32] drm/exynos: Merge overlay_ops into manager_ops

2013-11-01 Thread Tomasz Figa
Hi Sean, On Friday 01 of November 2013 15:50:05 Sean Paul wrote: > On Thu, Oct 31, 2013 at 7:39 PM, Tomasz Figa wrote: > > Hi Sean, > > > > On Tuesday 29 of October 2013 12:12:48 Sean Paul wrote: [snip] > >> -static void fimd_wait_for_vblank(struct device *

[PATCH v3 05/32] drm/exynos: hdmi: Implement initialize op for hdmi

2013-11-01 Thread Tomasz Figa
Hi Sean, On Friday 01 of November 2013 15:54:31 Sean Paul wrote: > On Thu, Oct 31, 2013 at 7:53 PM, Tomasz Figa wrote: > > Hi Sean, > > > > On Tuesday 29 of October 2013 12:12:51 Sean Paul wrote: [snip] > >> @@ -995,6 +1000,9 @@ static irqreturn_t mixer_irq_handle

[PATCH v3 04/32] drm/exynos: Use manager_op initialize in fimd

2013-11-01 Thread Tomasz Figa
On Friday 01 of November 2013 15:51:00 Sean Paul wrote: > On Thu, Oct 31, 2013 at 7:49 PM, Tomasz Figa wrote: > > Hi Sean, > > > > On Tuesday 29 of October 2013 12:12:50 Sean Paul wrote: > >> This patch implements the intitialize manager op in fimd. >

[PATCH v3 06/32] drm/exynos: Pass exynos_drm_manager in manager ops instead of dev

2013-11-01 Thread Tomasz Figa
On Friday 01 of November 2013 16:01:23 Sean Paul wrote: > On Thu, Oct 31, 2013 at 8:19 PM, Tomasz Figa wrote: > > Hi Sean, > > > > On Tuesday 29 of October 2013 12:12:52 Sean Paul wrote: [snip] > >> -static void fimd_win_mode_set(struct device *dev, > >

[PATCH v3 00/32] drm/exynos: Refactor parts of the exynos driver

2013-11-08 Thread Tomasz Figa
Hi Inki, Sean, On Thursday 07 of November 2013 14:48:28 Inki Dae wrote: > Hi Sean, > > When are you going to post your next version? Need more time? Other > DRM drivers have been merged to drm-next except Exynos. So plz hurry > up if you want to merge this re-factoring patch series during merge

[PATCH v3 07/32] drm/exynos: Remove apply manager callback

2013-11-08 Thread Tomasz Figa
rs/gpu/drm/exynos/exynos_mixer.c | 2 ++ > 7 files changed, 8 insertions(+), 43 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 08/32] drm/exynos: Remove dpms link between encoder/connector

2013-11-08 Thread Tomasz Figa
ew patch > Changes in v3: None > > drivers/gpu/drm/exynos/exynos_drm_connector.c | 42 > ++ drivers/gpu/drm/exynos/exynos_drm_connector.h | > 4 --- > drivers/gpu/drm/exynos/exynos_drm_encoder.c | 50 > +++ 3 files changed, 8

[PATCH v3 09/32] drm/exynos: Rename display_op power_on to dpms

2013-11-08 Thread Tomasz Figa
s/exynos_hdmi.c| 2 +- > 7 files changed, 10 insertions(+), 27 deletions(-) Patch description fails to mention about removing dummy callbacks from FIMD and ViDi drivers, but that's just a nitpick, so: Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 11/32] drm/exynos: Use unsigned long for possible_crtcs

2013-11-10 Thread Tomasz Figa
5 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 10/32] drm/exynos: Don't keep dpms state in encoder

2013-11-10 Thread Tomasz Figa
; --- > > Changes in v2: None > Changes in v3: None > > drivers/gpu/drm/exynos/exynos_drm_encoder.c | 17 - > 1 file changed, 17 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 25/32] drm/exynos: Clean up FIMD power on/off routines

2013-11-11 Thread Tomasz Figa
ers/gpu/drm/exynos/exynos_drm_fimd.c | 247 > +-- > 1 file changed, 135 insertions(+), 112 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 15/32] drm/exynos: Use drm_mode_copy to copy modes

2013-11-10 Thread Tomasz Figa
> Changes in v3: None > > drivers/gpu/drm/exynos/exynos_hdmi.c | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 16/32] drm/exynos: Disable unused crtc planes from crtc

2013-11-10 Thread Tomasz Figa
m_crtc.c| 13 +- > drivers/gpu/drm/exynos/exynos_drm_encoder.c | 65 > ++--- > 2 files changed, 15 insertions(+), 63 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 18/32] drm/exynos: Implement mode_fixup manager operation

2013-11-10 Thread Tomasz Figa
On Tuesday 29 of October 2013 12:13:04 Sean Paul wrote: > This patch adds a new manager callback for mode_fixup and pipes it > through exynos_drm_crtc. Patch description lacking explanation what this change is for. > > Signed-off-by: Sean Paul > --- > > Changes in v2: None > Changes in v3: Non

[PATCH v3 14/32] drm/exynos: Remove exynos_drm_hdmi shim

2013-11-10 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:13:00 Sean Paul wrote: > This patch trims exynos_drm_hdmi out of the driver. The reason it > existed in the first place was to make up for the mixture of > display/overlay/manager ops being spread across hdmi and mixer. With > that code now rationalized, m

[PATCH v3 12/32] drm/exynos: Split manager/display/subdrv

2013-11-10 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:12:58 Sean Paul wrote: > This patch splits display and manager from subdrv. The result is that > crtc functions can directly call into manager callbacks and encoder > functions can directly call into display callbacks. This will allow > us to remove the ex

[PATCH v3 24/32] drm/exynos: Implement dpms display callback in DP

2013-11-11 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:13:10 Sean Paul wrote: > This patch implements the dpms display callback for the DP driver. > > Signed-off-by: Sean Paul > --- > > Changes in v2: > - Added to the patchset > Changes in v3: None > > drivers/gpu/drm/exynos/exynos_dp_core.c | 173

[PATCH v3 27/32] drm/exynos: Add create_connector callback

2013-11-11 Thread Tomasz Figa
removing the exynos_drm_connector abstraction. > > Signed-off-by: Sean Paul > --- > > Changes in v2: None > Changes in v3: > - Added to the patchset > > drivers/gpu/drm/exynos/exynos_drm_core.c | 3 +++ > drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 ++ > 2 files

[PATCH v3 17/32] drm/exynos: Add mode_set manager operation

2013-11-10 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:13:03 Sean Paul wrote: > This patch adds a mode_set callback to the manager operations which > sets the crtc's current mode to the manager driver. To allow/fix/improve/extend... Patch description should say why such change is good to have. > > Signed-o

[PATCH v3 20/32] drm/exynos: Remove unused/useless fimd_context members

2013-11-11 Thread Tomasz Figa
/exynos/exynos_drm_fimd.c | 13 + > 1 file changed, 1 insertion(+), 12 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 19/32] drm/exynos: Use mode_set to configure fimd

2013-11-10 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:13:05 Sean Paul wrote: > This patch uses the mode passed into mode_set to configure fimd instead > of directly using the panel from context. This will allow us to move > the exynos_drm_display implementation from fimd into the DP driver > where it belongs.

[PATCH v3 13/32] drm/exynos: hdmi: remove the i2c drivers and use devtree

2013-11-10 Thread Tomasz Figa
Hi Sean, Daniel, Please see my comments inline. On Tuesday 29 of October 2013 12:12:59 Sean Paul wrote: > From: Daniel Kurtz > > The i2c client was previously being passed into the hdmi driver via a > dedicated i2c driver, and then a global variable. This patch removes all > of that and just us

[PATCH v3 12/32] drm/exynos: Split manager/display/subdrv

2013-11-12 Thread Tomasz Figa
On Tuesday 12 of November 2013 12:51:11 Sean Paul wrote: > On Sun, Nov 10, 2013 at 4:09 PM, Tomasz Figa wrote: > > Hi Sean, > > > > On Tuesday 29 of October 2013 12:12:58 Sean Paul wrote: > >> This patch splits display and manager from subdrv. The result is that &g

[PATCH v3 13/32] drm/exynos: hdmi: remove the i2c drivers and use devtree

2013-11-28 Thread Tomasz Figa
On Monday 11 of November 2013 09:44:27 Thierry Reding wrote: > On Sun, Nov 10, 2013 at 09:46:02PM +0100, Tomasz Figa wrote: > [...] > > On Tuesday 29 of October 2013 12:12:59 Sean Paul wrote: > [...] > > [snip] > > > @@ -1957,21 +1943,30 @@ static int hdmi_probe(struc

[PATCH v3 19/32] drm/exynos: Use mode_set to configure fimd

2013-11-28 Thread Tomasz Figa
On Friday 15 of November 2013 21:53:16 Daniel Kurtz wrote: > Hi Sean, Tomasz, > > On Mon, Nov 11, 2013 at 6:03 AM, Tomasz Figa wrote: > > Hi Sean, > > > > On Tuesday 29 of October 2013 12:13:05 Sean Paul wrote: > >> This patch uses the mode passed into mode_s

[PATCH v3 12/32] drm/exynos: Split manager/display/subdrv

2013-11-29 Thread Tomasz Figa
On Tuesday 26 of November 2013 10:00:13 Olof Johansson wrote: > On Tue, Nov 12, 2013 at 10:35 AM, Tomasz Figa > wrote: > > On Tuesday 12 of November 2013 12:51:11 Sean Paul wrote: > >> On Sun, Nov 10, 2013 at 4:09 PM, Tomasz Figa > >> wrote: > >> &g

[PATCH v3 12/32] drm/exynos: Split manager/display/subdrv

2013-11-29 Thread Tomasz Figa
On Friday 29 of November 2013 08:52:22 Daniel Vetter wrote: > On Fri, Nov 29, 2013 at 12:04:04AM +0100, Tomasz Figa wrote: > > On Tuesday 26 of November 2013 10:00:13 Olof Johansson wrote: > > > More like code written in the same style as x86 DRM stuff, where > &g

[PATCH v3 26/32] drm/exynos: Consolidate suspend/resume in drm_drv

2013-11-29 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:13:12 Sean Paul wrote: > This patch removes all of the suspend/resume logic from the individual > drivers and consolidates it in drm_drv. This consolidation reduces the > number of functions which enable/disable the hardware to just one -- the > dpms callb

[PATCH v3 28/32] drm/exynos: Implement drm_connector in hdmi directly

2013-11-29 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:13:14 Sean Paul wrote: > This patch implements drm_connector in the hdmi driver directly, instead > of using exynos_drm_connector. > > Signed-off-by: Sean Paul > --- > > Changes in v3: > - Added to the patchset > > drivers/gpu/drm/exynos/exynos_

[PATCH v3 29/32] drm/exynos: Implement drm_connector directly in dp driver

2013-11-29 Thread Tomasz Figa
- Added to the patchset > > drivers/gpu/drm/exynos/exynos_dp_core.c | 99 > ++--- > drivers/gpu/drm/exynos/exynos_dp_core.h | 4 ++ > 2 files changed, 94 insertions(+), 9 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 30/32] drm/exynos: Implement drm_connector directly in vidi driver

2013-11-29 Thread Tomasz Figa
- Added to the patchset > > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 163 > --- > 1 file changed, 107 insertions(+), 56 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 32/32] drm/exynos: Remove the exynos_drm_connector shim

2013-11-29 Thread Tomasz Figa
_connector.c > delete mode 100644 drivers/gpu/drm/exynos/exynos_drm_connector.h Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v3 31/32] drm/exynos: Move lvds bridge discovery into DP driver

2013-11-29 Thread Tomasz Figa
Hi Sean, On Tuesday 29 of October 2013 12:13:17 Sean Paul wrote: > This patch moves the lvds bridge discovery and connector pre-emption > code from exynos common code into the dp driver (since the bridge is > only applicable for dp). > > Signed-off-by: Sean Paul > --- > > Changes in v3: >

[PATCH v3 12/32] drm/exynos: Split manager/display/subdrv

2013-11-29 Thread Tomasz Figa
On Friday 29 of November 2013 09:13:19 Rob Clark wrote: > On Fri, Nov 29, 2013 at 4:10 AM, Tomasz Figa wrote: > > I would mostly agree with you if we were discussing SoC-internal > > components here. Mostly, because the ARM world is more complex and you > > can see the same

[PATCH 4/4] drm: exynos: hdmi: Add dt support for hdmiphy settings

2013-11-29 Thread Tomasz Figa
Hi Shirish, Please see my comments inline. On Monday 25 of November 2013 14:24:39 Shirish S wrote: > This patch adds dt support to hdmiphy config settings > as it is board specific and depends on the signal pattern > of board. > > Signed-off-by: Shirish S > --- > .../devicetree/bindings/video/

[PATCH v3 31/32] drm/exynos: Move lvds bridge discovery into DP driver

2013-11-30 Thread Tomasz Figa
Hi Inki, On Saturday 30 of November 2013 14:18:08 Inki Dae wrote: > Hi Tomasz, > > Thanks for review, You're welcome. > > 2013/11/30 Tomasz Figa : > > Hi Sean, > > > > On Tuesday 29 of October 2013 12:13:17 Sean Paul wrote: > >> This patch mo

[PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Tomasz Figa
VOP can support BGR formats in all windows thanks to red/blue swap option provided in WINx_CTRL0 registers. This patch enables support for ABGR, XBGR, BGR888 and BGR565 formats by using this feature. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 33

[PATCH] drm/prime: Allow internal imports without import_sg_table

2015-05-08 Thread Tomasz Figa
cts. This patch makes the helper check this condition only in case of external imports fo rwhich importing sg table is indeed needed. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/drm_prime.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c b/d

[PATCH] drm/rockchip: Add BGR formats to VOP

2015-05-08 Thread Tomasz Figa
Hi Mark, Thanks for review. On Fri, May 8, 2015 at 5:40 PM, Mark yao wrote: >> @@ -233,6 +243,7 @@ static const struct vop_win_phy win23_data = { >> .nformats = ARRAY_SIZE(formats_234), >> .enable = VOP_REG(WIN2_CTRL0, 0x1, 0), >> .format = VOP_REG(WIN2_CTRL0, 0x7, 1), >>

[PATCH v2] drm/rockchip: Add BGR formats to VOP

2015-05-11 Thread Tomasz Figa
VOP can support BGR formats in all windows thanks to red/blue swap option provided in WINx_CTRL0 registers. This patch enables support for ABGR, XBGR, BGR888 and BGR565 formats by using this feature. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 33

[PATCH v6 01/12] dt-bindings: drm/mediatek: Add Mediatek display subsystem dts binding

2015-11-24 Thread Tomasz Figa
Hi Philipp, CK, Please see my comments inline. On Thu, Nov 19, 2015 at 2:34 AM, Philipp Zabel wrote: > From: CK Hu > > Add device tree binding documentation for the display subsystem in > Mediatek MT8173 SoCs. > > Signed-off-by: CK Hu > Signed-off-by: Philipp Zabel > Acked-by: Rob Herring >

[PATCH v6 02/12] drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.

2015-11-24 Thread Tomasz Figa
Hi Philipp, CK, Please see my comments inline. On Thu, Nov 19, 2015 at 2:34 AM, Philipp Zabel wrote: [snip] > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > new file mode 100644 > index 000..508c8f3 > --- /dev/null > +++ b/drivers/gpu/drm

[PATCH v2 5/5] drm/rockchip: default enable win2/3 area0 bit

2015-07-21 Thread Tomasz Figa
On Fri, Jul 3, 2015 at 7:08 PM, Mark yao wrote: > On 2015年07月03日 17:24, Tomasz Figa wrote: >> >> On Fri, Jul 3, 2015 at 5:19 PM, Mark yao wrote: >>> >>> On 2015年07月03日 16:02, Tomasz Figa wrote: >>>> >>>> Hi Mark, >>>&g

[PATCH v2] drm/rockchip: vop: remove hardware cursor window

2015-07-21 Thread Tomasz Figa
- > 1 file changed, 11 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v2 4/5] drm/rockchip: vop: switch cursor plane to window 3

2015-07-21 Thread Tomasz Figa
I missed it originally, but if it's not too late yet... On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: > Window 1 support scale and yuv format, it's waste use it for a > cursor, use window 3 is enough. > > Signed-off-by: Mark Yao > --- > Changes in v2: None > > drivers/gpu/drm/rockchip/rockch

[GIT PULL] drm/rockchip: fixes and new features

2015-07-01 Thread Tomasz Figa
Hi Mark, On Tue, Jun 30, 2015 at 3:50 PM, Mark yao wrote: > > Hi Dave. > > Some fixes and some new features. I'd like you can pull them. > > The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898: > > drm/nouveau: Pause between setting gpu to D3hot and cutting the power

[GIT PULL] drm/rockchip: fixes and new features

2015-07-01 Thread Tomasz Figa
On Wed, Jul 1, 2015 at 5:20 PM, Daniel Vetter wrote: > On Wed, Jul 01, 2015 at 05:03:39PM +0900, Tomasz Figa wrote: >> Hi Mark, >> >> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao wrote: >> > >> > Hi Dave. >> > >> > Some fixes and som

[GIT PULL] drm/rockchip: fixes and new features

2015-07-01 Thread Tomasz Figa
On Wed, Jul 1, 2015 at 5:32 PM, Mark yao wrote: > On 2015年07月01日 16:03, Tomasz Figa wrote: >> >> Hi Mark, >> >> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao wrote: >>> >>> Hi Dave. >>> >>> Some fixes and some new features.

[GIT PULL] drm/rockchip: fixes and new features

2015-07-01 Thread Tomasz Figa
On Wed, Jul 1, 2015 at 6:13 PM, Mark yao wrote: By the way, if we're using window 3 for cursor plane, because the cursor window needs special handling, is it okay to expose the cusor window as an overlay plane to userspace, as we do currently? >>> >>> >>> special handling? what mean

[PATCH v2 1/5] drm/rockchip: vop: optimize virtual stride calculate

2015-07-02 Thread Tomasz Figa
On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: > vir_stride need number words of the virtual width, and fb->pitches > save bytes_per_pixel, so just div 4 switch to stride. > > Signed-off-by: Mark Yao > --- > Changes in v2: None > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c |2 +- > 1 fil

[PATCH v2 2/5] drm/rockchip: vop: fix yuv plane support

2015-07-02 Thread Tomasz Figa
Hi Mark, Please see my comments inline. On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: > vop support yuv with NV12, NV16 and NV24, only 2 plane yuv. > > Signed-off-by: Mark Yao > > Changes in v2: > - Uv buffer not support odd offset, align it. > - Fix error display when move yuv image. > > --

[PATCH v2 2/5] drm/rockchip: vop: fix yuv plane support

2015-07-02 Thread Tomasz Figa
On Thu, Jul 2, 2015 at 3:53 PM, Mark yao wrote: > Hi Tomasz > Thanks for your review, I will fix it soon. > > On 2015年07月02日 14:00, Tomasz Figa wrote: >> >> Hi Mark, >> >> Please see my comments inline. >> >> On Fri, Jun 26, 2015 at 7:07 P

[PATCH v2 3/5] drm/rockchip: vop: support plane scale

2015-07-03 Thread Tomasz Figa
Hi Mark, Please see my comments inline. On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: > Win_full support 1/8 to 8 scale down/up engine, support > all format scale. [snip] > @@ -351,6 +412,15 @@ static inline void vop_mask_write_relaxed(struct vop > *vop, uint32_t offset, > } > } >

[PATCH v2 4/5] drm/rockchip: vop: switch cursor plane to window 3

2015-07-03 Thread Tomasz Figa
--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Tomasz Figa Best regards, Tomasz

[PATCH v2 5/5] drm/rockchip: default enable win2/3 area0 bit

2015-07-03 Thread Tomasz Figa
Hi Mark, Please see my comments inline. On Fri, Jun 26, 2015 at 7:10 PM, Mark Yao wrote: > Win2/3 support 4 area display, but now havn't found a suitable > way to use it, and it enable by win gate and area gate, > so default enable area0 gate, so that its behaviour just like a > win. So I assum

<    1   2   3   4   5   >