On 02.04.2014 19:13, Rahul Sharma wrote:
> From: Rahul Sharma <Rahul.Sharma at samsung.com>
>
> Cleaning up unnecessary i2c read call after hdmiphy configuration.
> This check is redundant since check for hdmiphy pll lock status
> confirms the correct settings for phy.
>
> Signed-off-by: Rahul Sharma <Rahul.Sharma at samsung.com>
> Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
> b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 47b8c06..5b2cfe7 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -1518,7 +1518,6 @@ static void hdmiphy_conf_apply(struct hdmi_context
> *hdata)
> const u8 *hdmiphy_data;
> u8 buffer[32];
> u8 operation[2];
> - u8 read_buffer[32] = {0, };
> int ret;
> int i;
>
> @@ -1558,15 +1557,6 @@ static void hdmiphy_conf_apply(struct hdmi_context
> *hdata)
> return;
> }
>
> - ret = i2c_master_recv(hdata->hdmiphy_port, read_buffer, 32);
> - if (ret < 0) {
> - DRM_ERROR("failed to read hdmiphy config\n");
> - return;
> - }
> -
> - for (i = 0; i < ret; i++)
> - DRM_DEBUG_KMS("hdmiphy[0x%02x] write[0x%02x] - "
> - "recv [0x%02x]\n", i, buffer[i], read_buffer[i]);
> }
>
> static void hdmi_conf_apply(struct hdmi_context *hdata)
>
Reviewed-by: Tomasz Figa <t.figa at samsung.com>
--
Best regards,
Tomasz
