[PATCH v3] drm/shmobile: Convert to Linux IRQ interfaces

dle errors in platform_get_irq() (Geert, Sergei) * store IRQ number in struct shmob_drm_device (Laurent) Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg --- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 14 +- drivers/gpu/drm/shmobile/shmob_drm_drv.h | 1 + 2 files changed,

Re: [PATCH v5] drm/ast: Disable fast reset after DRAM initial

3. Add comment about Reset USB port to patch USB unknown device issue ast_post.c Signed-off-by: KuoHsiang Chou Acked-by: Thomas Zimmermann Thanks! I'll merge your patch into drm-misc-next. Best regards Thomas --- drivers/gpu/drm/ast/ast_drv.h | 6 +++ drivers/gpu/drm/ast/ast_mai

Re: [PATCH] drm/ast: Zero is missing in detect function

Hi Am 16.07.21 um 03:56 schrieb ainux.w...@gmail.com: From: "Ainux.Wang" The function ast_get_modes() will also return 0, when it try to get the edid, but it also do not get the edid. Signed-off-by: Ainux.Wang Acked-by: Thomas Zimmermann after the issue has been discussed a

Re: [PATCH -next v2 resend] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()

Hi Am 15.07.21 um 15:28 schrieb Yang Yingliang: Replace pci_enable_device() with pcim_enable_device(), pci_disable_device() will be called in release automatically. v2: use pcim_enable_device() Signed-off-by: Yang Yingliang Reported-by: Hulk Robot Acked-by: Thomas Zimmermann Thanks

Re: [PATCH] drm/ast: Return value when do not get edid

Am 17.07.21 um 03:14 schrieb Ainux Wang: Thomas Zimmermann 于2021年7月16日周五 下午8:00写道： Hi Am 16.07.21 um 11:55 schrieb ainux.w...@gmail.com: From: "Ainux.Wang" There is should a status when do not get edid. Well, not really. So, the problem is that VGA is not hotplug-able. It&

Re: [PATCH 3/7] drm/mipi-dbi: Use framebuffer dma-buf helpers

Hi Am 20.07.21 um 16:03 schrieb Daniel Vetter: On Fri, Jul 16, 2021 at 04:07:57PM +0200, Thomas Zimmermann wrote: Replace dma_buf_begin_cpu_access() with drm_gem_fb_begin_cpu_access(); same for _end_cpu_access(). Remove some boiler-plate code. No functional changes. There's one left

Re: [PATCH v3 0/2] allow simple{fb, drm} drivers to be used on non-x86 EFI platforms

Canillas Linux Engineering Red Hat -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer OpenPGP_signature Description: OpenPGP digital signature

Re: [PULL] drm-misc-next

Probably due to Thomas irq patches. I'll take a look. Best regards Thomas Dave. -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer OpenPGP_signatu

Re: [PATCH v3 0/2] allow simple{fb, drm} drivers to be used on non-x86 EFI platforms

n use that to check if there are any integration issues or regressions caused by these. Merged into drm-misc-next. Best regards Thomas Best regards Thomas Best regards, -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Ge

[PATCH] drm/hisilicon/hibmc: Remove variable 'priv' from hibmc_unload()

The variable 'priv' got introduced in commit 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") by accident. It's unused; remove it. Fixes a compiler warning. Signed-off-by: Thomas Zimmermann Fixes: 39a364a19e03 ("drm/hisilicon/hibmc: Convert to L

[PULL] drm-misc-fixes

_bo_util.c | 3 ++ drivers/gpu/drm/ttm/ttm_device.c | 2 + drivers/gpu/drm/vc4/vc4_hdmi.c | 49 +++--- include/drm/drm_ioctl.h| 1 + 9 files changed, 60 insertions(+), 17 deletions(-) -- Thomas

Re: [PATCH v3] drm/shmobile: Convert to Linux IRQ interfaces

Hi, if there are no further comments on this patch, I'd like to merge it soon. Am 20.07.21 um 10:09 schrieb Thomas Zimmermann: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit fro

Re: [PATCH v4 2/4] drm/shmem-helper: Switch to vmf_insert_pfn

Hi, I'm not knowledgeable enougth to give this a full review. If you can just answer my questions, fell free to add an Acked-by: Thomas Zimmermann to the patch. :) Am 13.07.21 um 22:51 schrieb Daniel Vetter: We want to stop gup, which isn't the case if we use vmf_insert_page W

Re: [PATCH v4 3/4] drm/shmem-helpers: Allocate wc pages on x86

st Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/drm_gem_shmem_helper.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 296ab1b7c07f..

Re: [PATCH v4 4/4] drm/vgem: use shmem helpers

cs (Thomas) v6: vgem also needs an MMU for remapping Cc: Thomas Zimmermann Acked-by: Thomas Zimmermann Cc: John Stultz Cc: Sumit Semwal Cc: "Christian König" Signed-off-by: Daniel Vetter Cc: Melissa Wen Cc: Chris Wilson --- drivers/gpu/drm/Kconfig

Re: [PATCH] drm/hisilicon/hibmc: remove an unused variable

isc-next. Best regards Thomas -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer OpenPGP_signature Description: OpenPGP digital signature

Re: [PATCH v4 1/4] dma-buf: Require VM_PFNMAP vma for mmap

); + + WARN_ON(!(vma->vm_flags & VM_PFNMAP)); Maybe change this to WARN_ON_ONCE(), so it doesn't fill up the kernel log. Same comment below. For either version Acked-by: Thomas Zimmermann Best regards Thomas + + return ret; } static loff_t dm

[PATCH v2 3/5] drm/gem: Clear mapping addresses for unused framebuffer planes

Set the returned mapping address to NULL if a framebuffer plane does not have a BO associated with it. Likewise, ignore mappings of NULL during framebuffer unmap operations. Allows users of the functions to perform unmap operations of certain BOs by themselfes. Signed-off-by: Thomas Zimmermann

[PATCH v2 2/5] drm/gem: Provide drm_gem_fb_{vmap,vunmap}()

ables compile-time checks * include for DRM_FORMAT_MAX_PLANES (kernel test robot) Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_atomic_helper.c | 37 +- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 73 includ

[PATCH v2 0/5] drm: Provide framebuffer vmap helpers

fix error handling after DRM_FORMAT_MAX_PLANES changes (kernel test robot) * fix includes (kernel test robot) * use [static N] notations for array parameters Thomas Zimmermann (5): drm: Define DRM_FORMAT_MAX_PLANES drm/gem: Provide drm_gem_fb_{vmap,vunmap}() drm/gem: Cle

[PATCH v2 5/5] drm/vkms: Map output framebuffer BOs with drm_gem_fb_vmap()

mappings addresses while the writeback job is active. The patchset also cleans up some internal casting an setup of the output addresses. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vkms/vkms_composer.c | 2 +- drivers/gpu/drm/vkms/vkms_drv.h | 6

[PATCH v2 4/5] drm/gud: Map framebuffer BOs with drm_gem_fb_vmap()

Abstract the framebuffer details by mapping its BOs with a call to drm_gem_fb_vmap(). Unmap with drm_gem_fb_vunmap(). The call to drm_gem_fb_vmap() ensures that all BOs are mapped correctly. Gud still only supports single-plane formats. No functional changes. Signed-off-by: Thomas Zimmermann

[PATCH v2 1/5] drm: Define DRM_FORMAT_MAX_PLANES

_SIZE. v2: * mention usage of ARRAY_SIZE() in the commit message (Maxime) * also fix error handling in drm_gem_fb_init_with_funcs() (kernel test robot) * include for DRM_FORMAT_MAX_PLANES Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_framebuffer_hel

Re: [PATCH v2 1/5] drm: Define DRM_FORMAT_MAX_PLANES

Hi Am 25.07.21 um 21:49 schrieb Sam Ravnborg: Hi Thomas, On Sun, Jul 25, 2021 at 07:44:34PM +0200, Thomas Zimmermann wrote: DRM uses a magic number of 4 for the maximum number of planes per color format. Declare this constant via DRM_FORMAT_MAX_PLANES and update the related code. Some code

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

inline void sysfb_apply_efi_quirks(struct platform_device *pd) ^~ Signed-off-by: Randy Dunlap Cc: Ard Biesheuvel Cc: linux-...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Javier Martinez Canillas Cc: Thomas Zimmermann Cc: Mark Brown Cc: linux-n

[PATCH 00/14] drm: Make DRM's IRQ helpers legacy

Patch 13 removes an unused function. Patch 14 moves the DRM IRQ helpers behind CONFIG_DRM_LEGACY. Only the old non-KMS drivers still use the functionality. Thomas Zimmermann (14): drm/amdgpu: Convert to Linux IRQ interfaces drm/arm/hdlcd: Convert to Linux IRQ interfaces drm/atmel-hlcdc:

[PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/a

[PATCH 04/14] drm/fsl-dcu: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/d

[PATCH 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

in struct amdgpu_irq. Calls to pci_msi_vector() can fail and return a negative errno code. Abort initlaizaton in thi case. The DRM IRQ midlayer does not handle this correctly. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH 10/14] drm/tidss: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tidss/t

[PATCH 05/14] drm/gma500: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/powe

[PATCH 09/14] drm/radeon: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/ra

[PATCH 02/14] drm/arm/hdlcd: Convert to Linux IRQ interfaces

ode. Abort initialization in this case. The DRM IRQ midlayer does not handle this case correctly. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/arm/hdlcd_drv.c | 174 ++-- drivers/gpu/drm/arm/hdlcd_drv.h | 1 + 2 files changed, 97 insertions(+), 78 deletions(-) di

[PATCH 08/14] drm/mxsfb: Convert to Linux IRQ interfaces

ode. Abort initialization in this case. The DRM IRQ midlayer does not handle this case correctly. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 81 +++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 2 + 2 files changed, 52 insertions(+), 31 deletions(-)

[PATCH 06/14] drm/kmb: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/kmb/kmb_

[PATCH 07/14] drm/msm: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_d

[PATCH 11/14] drm/tilcdc: Convert to Linux IRQ interfaces

ode. Abort initialization in this case. The DRM IRQ midlayer does not handle this case correctly. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 51 ++--- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 3 ++ 2 files changed, 43 insertions(+), 11 deletion

[PATCH 12/14] drm/vc4: Convert to Linux IRQ interfaces

ode. Abort initialization in this case. The DRM IRQ midlayer does not handle this case correctly. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_drv.c | 4 --- drivers/gpu/drm/vc4/vc4_drv.h | 8 +++--- drivers/gpu/drm/vc4/vc4_irq.c | 48 +++ drivers/g

[PATCH 13/14] drm: Remove unused devm_drm_irq_install()

DRM IRQ helpers will become legacy. The function devm_drm_irq_install() is unused and won't be required later. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_irq.c | 32 include/drm/drm_irq.h | 1 - 2 files changed, 33 deletions(-) diff --

[PATCH 14/14] drm: IRQ midlayer is now legacy

Hide the DRM midlayer behind CONFIG_DRM_LEGACY, make functions use the prefix drm_legacy_, and move declarations to drm_legacy.h. In struct drm_device, move the fields irq and irq_enabled behind CONFIG_DRM_LEGACY. All callers have been updated. Signed-off-by: Thomas Zimmermann --- drivers/gpu

Re: [PATCH 00/14] drm: Make DRM's IRQ helpers legacy

Hi Sam Am 27.07.21 um 20:51 schrieb Sam Ravnborg: Hi Thomas, On Tue, Jul 27, 2021 at 08:27:07PM +0200, Thomas Zimmermann wrote: DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux IRQ interfaces. DRM provide

[PULL] drm-misc-fixes

an Teki (1): drm/panel: panel-simple: Fix proper bpc for ytc700tlag_05_201c Jason Ekstrand (1): drm/ttm: Initialize debugfs from ttm_global_init() Thomas Zimmermann (1): Merge drm/drm-fixes into drm-misc-fixes drivers/gpu/drm/panel/panel-simple.c | 2 +- drivers/gpu/drm/ttm/tt

Re: [PATCH 02/14] drm/arm/hdlcd: Convert to Linux IRQ interfaces

Hi Sam Am 28.07.21 um 15:31 schrieb Sam Ravnborg: Hi Thomas, On Tue, Jul 27, 2021 at 08:27:09PM +0200, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from usin

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

this would mean that the driver misses vblank interrupts with the patch applied. Best regards Thomas Sam -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imen

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

K ioctls"). Best regards Thomas Great, thanks for testing. Thomas - I assume you will do a re-spin and there is likely some fixes for the applied IRQ conversions too. Note - irq_enabled must be cleared if request_irq fails. I did not include this in the testing here. Sam -- T

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

Hi Am 29.07.21 um 21:18 schrieb Thomas Zimmermann: Hi Am 28.07.21 um 22:11 schrieb Sam Ravnborg: Hi Dan, I think I got it - we need to set irq_enabled to true. The documentation says so: "    * @irq_enabled:    *    * Indicates that interrupt handling is en

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

Hi Am 29.07.21 um 21:24 schrieb dan.sned...@microchip.com: Hi Thomas, On 7/29/21 12:18 PM, Thomas Zimmermann wrote: Hi Am 28.07.21 um 22:11 schrieb Sam Ravnborg: Hi Dan, I think I got it - we need to set irq_enabled to true. The documentation says so: "    * @irq_en

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

ry for the confusion! I was looking at drm-misc-fixes which did not have this commit :-( Just my silly excuse why I was convinced this was the issue. Don't worry. I'll add Sam's R-b and a Tested-by from Dan to the patch. Is that ok? Best regards Thomas Sam Best r

[PATCH v3 0/5] drm: Provide framebuffer vmap helpers

or errors v2: * update commit message for first patch (Maxime) * fix error handling after DRM_FORMAT_MAX_PLANES changes (kernel test robot) * fix includes (kernel test robot) * use [static N] notations for array parameters Thomas Zimmermann (5): d

[PATCH v3 1/5] drm: Define DRM_FORMAT_MAX_PLANES

_SIZE. v2: * mention usage of ARRAY_SIZE() in the commit message (Maxime) * also fix error handling in drm_gem_fb_init_with_funcs() (kernel test robot) * include for DRM_FORMAT_MAX_PLANES Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg --- drive

[PATCH v3 3/5] drm/gem: Clear mapping addresses for unused framebuffer planes

Set the returned mapping address to NULL if a framebuffer plane does not have a BO associated with it. Likewise, ignore mappings of NULL during framebuffer unmap operations. Allows users of the functions to perform unmap operations of certain BOs by themselfes. Signed-off-by: Thomas Zimmermann

[PATCH v3 5/5] drm/vkms: Map output framebuffer BOs with drm_gem_fb_vmap()

mappings addresses while the writeback job is active. The patchset also cleans up some internal casting an setup of the output addresses. No functional changes. v3: * free instances of struct vkms_writeback_job on cleanup or errors Signed-off-by: Thomas Zimmermann Reviewed-by

[PATCH v3 2/5] drm/gem: Provide drm_gem_fb_{vmap,vunmap}()

ables compile-time checks * include for DRM_FORMAT_MAX_PLANES (kernel test robot) Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_gem_atomic_helper.c | 37 +- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 73 in

[PATCH v3 4/5] drm/gud: Map framebuffer BOs with drm_gem_fb_vmap()

Abstract the framebuffer details by mapping its BOs with a call to drm_gem_fb_vmap(). Unmap with drm_gem_fb_vunmap(). The call to drm_gem_fb_vmap() ensures that all BOs are mapped correctly. Gud still only supports single-plane formats. No functional changes. Signed-off-by: Thomas Zimmermann

Re: [PATCH] DRM: ast: Fixed coding style issues of ast_mode.c

uct drm_connector *connector) { struct ast_connector *ast_connector = to_ast_connector(connector); + ast_i2c_destroy(ast_connector->i2c); drm_connector_cleanup(connector); } -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N

Re: [PATCH 00/14] drm: Make DRM's IRQ helpers legacy

Hi Sam Am 31.07.21 um 20:50 schrieb Sam Ravnborg: Hi Thomas, On Tue, Jul 27, 2021 at 08:27:07PM +0200, Thomas Zimmermann wrote: DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux IRQ interfaces. DRM provide

Re: [PATCH 00/14] drm: Make DRM's IRQ helpers legacy

nd out a new revision soon, so maybe don't waste time with this one. Best regards Thomas [1] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_irq.c#L111 Sam -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5,

Re: [PATCH 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

Hi Am 28.07.21 um 16:03 schrieb Alex Deucher: On Wed, Jul 28, 2021 at 6:27 AM Christian König wrote: Am 27.07.21 um 20:27 schrieb Thomas Zimmermann: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers

Re: [PATCH 3/4] drm/tiny: add simple-dbi driver

.name = "simple-dbi", + .of_match_table = simple_dbi_of_match, + }, + .probe = simple_dbi_probe, + .remove = simple_dbi_remove, + .shutdown = simple_dbi_shutdown, +}; +module_spi_driver(simple_dbi_spi_driver); + +MODULE_DESCRIPTION("Simple DBI p

Re: [PATCH 3/4] drm/tiny: add simple-dbi driver

Hi Am 03.08.21 um 03:25 schrieb Icenowy Zheng: 在 2021-08-02星期一的 17:08 +0200，Thomas Zimmermann写道： Hi Am 02.08.21 um 08:35 schrieb Icenowy Zheng: Add a driver for generic MIPI DBI panels initialized with MIPI DCS commands. Currently a ST7789V-based panel is added to it. This panel has its

Re: [PATCH] drm/vbox: Convert to Linux IRQ interfaces

Hi Am 02.08.21 um 13:52 schrieb Hans de Goede: Hi, On 7/6/21 9:50 AM, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. Signed-off-by: Thomas

Re: [PATCH v5] drm/ast: Fixed CVE for DP501

09 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer OpenPGP_signature Description: OpenPGP digital signature

[PATCH v2 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

in struct amdgpu_irq. Calls to pci_msi_vector() can fail and return a negative errno code. Abort initlaizaton in thi case. The DRM IRQ midlayer does not handle this correctly. Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/am

[PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

e names in arm/hlcdc (Sam) Thomas Zimmermann (14): drm/amdgpu: Convert to Linux IRQ interfaces drm/arm/hdlcd: Convert to Linux IRQ interfaces drm/atmel-hlcdc: Convert to Linux IRQ interfaces drm/fsl-dcu: Convert to Linux IRQ interfaces drm/gma500: Convert to Linux IRQ interfaces drm/kmb:

[PATCH v2 02/14] drm/arm/hdlcd: Convert to Linux IRQ interfaces

ode. Abort initialization in this case. The DRM IRQ midlayer does not handle this case correctly. v2: * name struct drm_device variables 'drm' (Sam) Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg --- drivers/gpu/drm/arm/hdlcd_drv.c | 174 ++--

[PATCH v2 04/14] drm/fsl-dcu: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/d

[PATCH v2 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

irq() (Sam) * drop extra test for irq != IRQ_NOTCONNECTED (Sam) Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg Tested-by: Dan Sneddon --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 80 1 file changed, 47 insertions(+), 33 deletions(-) diff --git a/drivers/gpu

[PATCH v2 06/14] drm/kmb: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/kmb/kmb_

[PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_d

[PATCH v2 08/14] drm/mxsfb: Convert to Linux IRQ interfaces

ode. Abort initialization in this case. The DRM IRQ midlayer does not handle this case correctly. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 81 +++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 2 + 2 files changed, 52 insertions(+), 31 deletions(-)

[PATCH v2 05/14] drm/gma500: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/powe

[PATCH v2 09/14] drm/radeon: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher --

[PATCH v2 11/14] drm/tilcdc: Convert to Linux IRQ interfaces

ode. Abort initialization in this case. The DRM IRQ midlayer does not handle this case correctly. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 51 ++--- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 3 ++ 2 files changed, 43 insertions(+), 11 deletion

[PATCH v2 13/14] drm: Remove unused devm_drm_irq_install()

DRM IRQ helpers will become legacy. The function devm_drm_irq_install() is unused and won't be required later. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_irq.c | 32 include/drm/drm_irq.h | 1 - 2 files changed, 33 deletions(-) diff --

[PATCH v2 10/14] drm/tidss: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann Reviewed-by: Tomi Valkeinen --

[PATCH v2 12/14] drm/vc4: Convert to Linux IRQ interfaces

ode. Abort initialization in this case. The DRM IRQ midlayer does not handle this case correctly. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_drv.c | 4 --- drivers/gpu/drm/vc4/vc4_drv.h | 8 +++--- drivers/gpu/drm/vc4/vc4_irq.c | 48 +++ drivers/g

[PATCH v2 14/14] drm: IRQ midlayer is now legacy

Hide the DRM midlayer behind CONFIG_DRM_LEGACY, make functions use the prefix drm_legacy_, and move declarations to drm_legacy.h. In struct drm_device, move the fields irq and irq_enabled behind CONFIG_DRM_LEGACY. All callers have been updated. Signed-off-by: Thomas Zimmermann Acked-by: Sam

[PATCH 01/11] drm/gem: Provide offset-adjusted framebuffer BO mappings

Add an additional argument to drm_gem_fb_vmap() to return each BO's mapping adjusted by the rsp offset. Update all callers. The newly returned values point to the first by of the data stored in the framebuffer BOs. Drivers that access the BO data should use it. Signed-off-by: Thomas Zimme

[PATCH 03/11] drm/gud: Get offset-adjusted mapping from drm_gem_fb_vmap()

Pass the data parameter to drm_gem_fb_vmap() to retrieve pointers to the data. This address is different from the mapping addresses for framebuffers with non-zero offsets. Replaces gud's internal computation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gud/gud_pipe.c | 5 +++-- 1

[PATCH 00/11] Provide offset-adjusted framebuffer mappings

nput and output framebuffers. The other patches convert users of shadow-buffered planes to use the data address. After conversion, each driver will use the correct data for non-zero offsets. Thomas Zimmermann (11): drm/gem: Provide offset-adjusted framebuffer BO mappings drm/ast: Use offset-adjust

[PATCH 02/11] drm/ast: Use offset-adjusted shadow-plane mappings

For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in ast. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 06/11] drm/cirrus: Use offset-adjusted shadow-plane mappings

For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in cirrus. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/cirrus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

[PATCH 07/11] drm/gm12u320: Use offset-adjusted shadow-plane mappings

For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in gm12u320. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/gm12u320.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 04/11] drm/hyperv: Use offset-adjusted shadow-plane mappings

For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in hyperv. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 11/11] drm/vkms: Use offset-adjusted shadow-plane mappings and output

ntent written to the correct location. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vkms/vkms_composer.c | 2 +- drivers/gpu/drm/vkms/vkms_drv.h | 1 + drivers/gpu/drm/vkms/vkms_plane.c | 2 +- drivers/gpu/drm/vkms/vkms_writeback.c | 2 +- 4 files changed, 4 insertions(

[PATCH 05/11] drm/mgag200: Use offset-adjusted shadow-plane mappings

For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in mgag200. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 10/11] drm/vbox: Use offset-adjusted shadow-plane mappings

For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in vbox. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vboxvideo/vbox_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 08/11] drm/simpledrm: Use offset-adjusted shadow-plane mapping

For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in simpledrm. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/simpledrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 09/11] drm/udl: Use offset-adjusted shadow-plane mapping

For framebuffers with non-zero offset fields, shadow-plane helpers provide a pointer to the first byte of the contained data. Use it in udl. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_modeset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

Re: [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

s,   Felix Regards, Christian. -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer OpenPGP_signature Description: OpenPGP digital signature

Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

drm-drv", + .of_match_table = drm_match_table, + }, +}; + +static struct platform_driver *sprd_drm_drivers[] = { + &sprd_drm_driver, +}; + +static int __init sprd_drm_init(void) +{ + int ret; I think ret should just go away. Acked-by: Thomas Zim

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

gt;base + offset); + + writel(bits & ~clr_bits, ctx->base + offset); +} + +static inline u32 +layer_reg_rd(struct dpu_context *ctx, u32 offset, int index) +{ + u32 layer_offset = offset + index * DPU_LAY_REG_OFFSET; + + return readl(ctx->base + layer_offset); +} + +static

Re: [PATCH v8 2/2] drm/tiny: add driver for newhaven,1.8-128160EF

Hi, just trivial points below. In any case Acked-by: Thomas Zimmermann Am 31.03.21 um 11:21 schrieb Daniel Mack: This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring an Ilitek ILI9163 controller. Signed-off-by: Daniel Mack Acked-by: Daniel Vetter --- driver

Re: [PATCH 0/4] drm: Generic dumb_map_offset for TTM-based drivers

Hi Am 08.04.21 um 13:16 schrieb Daniel Vetter: On Tue, Apr 06, 2021 at 10:29:38AM +0200, Thomas Zimmermann wrote: The implementation of drm_driver.dumb_map_offset is the same for several TTM-based drivers. Provide a common function in GEM-TTM helpers. Out of curiosity, why does this not fit

Re: [PATCH 0/8] drm: Clean up mmap for TTM-based GEM drivers

Hi Am 08.04.21 um 13:19 schrieb Daniel Vetter: On Tue, Apr 06, 2021 at 11:08:55AM +0200, Thomas Zimmermann wrote: Implement mmap via struct drm_gem_object_functions.mmap for amdgpu, radeon and nouveau. This allows for using common DRM helpers for the mmap-related callbacks in struct

[PATCH v2 0/4] drm: Generic dumb_map_offset for TTM-based drivers

The implementation of drm_driver.dumb_map_offset is the same for several TTM-based drivers. Provide a common function in GEM-TTM helpers. v2: * update hibmc as well (kernel test robot) Thomas Zimmermann (4): drm/gem-ttm-helper: Provide helper for struct drm_driver.dumb_map_offset

[PATCH v2 1/4] drm/gem-ttm-helper: Provide helper for struct drm_driver.dumb_map_offset

Provides an implementation of struct drm_driver.dumb_map_offset that can be used by TTM-based GEM drivers. Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard --- drivers/gpu/drm/drm_gem_ttm_helper.c | 33 include/drm/drm_gem_ttm_helper.h | 5 - 2

[PATCH v2 2/4] drm/vram-helper: Use drm_gem_ttm_dumb_map_offset()

VRAM helpers now use drm_gem_ttm_dumb_map_offset() to implement struct drm_driver.dumb_map_offset. v2: * update hibmc as well (kernel test robot) Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard --- drivers/gpu/drm/drm_gem_vram_helper.c | 48

[PATCH v2 4/4] drm/qxl: Use drm_gem_ttm_dumb_map_offset()

Qxl now uses drm_gem_ttm_dumb_map_offset() to implement struct drm_driver.dumb_map_offset. Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard --- drivers/gpu/drm/qxl/qxl_drv.c| 3 ++- drivers/gpu/drm/qxl/qxl_drv.h| 3 --- drivers/gpu/drm/qxl/qxl_dumb.c | 17

[PATCH v2 3/4] drm/nouveau: Use drm_gem_ttm_dumb_map_offset()

Nouveau now uses drm_gem_ttm_dumb_map_offset() to implement struct drm_driver.dumb_map_offset. Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard --- drivers/gpu/drm/nouveau/nouveau_display.c | 18 -- drivers/gpu/drm/nouveau/nouveau_display.h | 2 -- drivers/gpu/drm

  1   2   3   4   5   6   7   8   9   10   >