Re: [PATCH V5 5/8] clk: mediatek: add MUX_GATE_FLAGS_2

2019-02-20 Thread Stephen Boyd
Quoting wangyan wang (2019-02-19 18:53:54) > From: chunhui dai > > Add MUX_GATE_FLAGS_2 for the clock which needs to set two falgs. s/falgs/flags/ > Such as some mux need to set the flags of "CLK_MUX_ROUND_CLOSEST". > > Signed-off-by: chunhui dai > Signed-off-by: wangyan wang > --- > driver

Re: [RFC v4 10/17] kunit: test: add test managed resource tests

2019-02-20 Thread Stephen Boyd
Quoting Brendan Higgins (2019-02-19 15:20:18) > On Fri, Feb 15, 2019 at 12:54 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-02-14 13:37:22) > > > + > > > +static struct kunit_case kunit_resource_test_cases[] = { > > > > Can these arrays

Re: [PATCH V5 5/8] clk: mediatek: add MUX_GATE_FLAGS_2

2019-02-21 Thread Stephen Boyd
Quoting mtk14994 (2019-02-20 18:34:11) > Dear Stephen, > > + unsigned char mux_flags; > > > > Why isn't it an unsigned long? Isn't this supposed to match the > > frameworks version of the clk flags? > > > it is unsigned char mux_flags ,becasuse struct clk_mux { > > > > u8 f

Re: [PATCH V6 5/8] clk: mediatek: add MUX_GATE_FLAGS_2

2019-02-25 Thread Stephen Boyd
Quoting wangyan wang (2019-02-24 18:09:09) > From: chunhui dai > > Add MUX_GATE_FLAGS_2 for the clock which needs to set two falgs. > Such as some mux need to set the flags of "CLK_MUX_ROUND_CLOSEST". > > Signed-off-by: chunhui dai > Signed-off-by: wangyan wang > --- Applied to clk-next

Re: [PATCH V6 6/8] clk: mediatek: using CLK_MUX_ROUND_CLOSEST for the clock of dpi1_sel

2019-02-25 Thread Stephen Boyd
Quoting wangyan wang (2019-02-24 18:09:10) > From: chunhui dai > > The MUX clock of dpi1_sel should select the closet clock for itself. > We could add this flag to enable this function of MUX in CCF. > > Signed-off-by: chunhui dai > Signed-off-by: wangyan wang > --- Applied to clk-next _

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-26 Thread Stephen Boyd
Quoting Brendan Higgins (2019-02-14 13:37:20) > Add support for aborting/bailing out of test cases. Needed for > implementing assertions. Can you add some more text here with the motivating reasons for implementing assertions and bailing out of test cases? For example, I wonder why unit tests can

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-28 Thread Stephen Boyd
Quoting Brendan Higgins (2019-02-28 01:03:24) > On Tue, Feb 26, 2019 at 12:35 PM Stephen Boyd wrote: > > > > when they need to abort and then the test runner would detect that error > > via the return value from the 'run test' function. That would be a more >

Re: [PATCH v4 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-06-07 Thread Stephen Boyd
Quoting Iurii Zaikin (2019-06-05 18:29:42) > On Fri, May 17, 2019 at 11:22 AM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-05-14 15:17:10) > > > diff --git a/kernel/sysctl-test.c b/kernel/sysctl-test.c > > > new file mode 100644 > > > index 0

Re: [PATCH v4 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-06-11 Thread Stephen Boyd
Quoting Brendan Higgins (2019-06-11 10:58:30) > On Fri, Jun 07, 2019 at 12:00:47PM -0700, Stephen Boyd wrote: > > Quoting Iurii Zaikin (2019-06-05 18:29:42) > > > On Fri, May 17, 2019 at 11:22 AM Stephen Boyd wrote: > > > > > > > > Quoting Brendan Hi

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-19 Thread Stephen Boyd
Quoting Brendan Higgins (2019-06-17 01:25:56) > diff --git a/kunit/test.c b/kunit/test.c > new file mode 100644 > index 0..d05d254f1521f > --- /dev/null > +++ b/kunit/test.c > @@ -0,0 +1,210 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Base unit test (KUnit) API. > + * > + * Co

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-25 Thread Stephen Boyd
Quoting Brendan Higgins (2019-06-25 13:28:25) > On Wed, Jun 19, 2019 at 5:15 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-06-17 01:25:56) > > > diff --git a/kunit/test.c b/kunit/test.c > > > new file mode 100644 > > > index 00

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-27 Thread Stephen Boyd
Quoting Brendan Higgins (2019-06-26 16:00:40) > On Tue, Jun 25, 2019 at 8:41 PM Stephen Boyd wrote: > > > scenario like below, but where it is a problem. There could be three > > CPUs, or even one CPU and three threads if you want to describe the > > extra thread sce

Re: [PATCH v1 6/6] clk: hi6220: use CLK_OF_DECLARE_DRIVER

2019-03-18 Thread Stephen Boyd
Quoting Peter Griffin (2019-03-18 12:38:51) > As now we also need to probe in the reset driver as well. > > Signed-off-by: Peter Griffin > --- > drivers/clk/hisilicon/clk-hi6220.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Doesn't this need to be squashed with the reset driver bits

Re: [PATCH v9 01/18] kunit: test: add KUnit test runner core

2019-07-15 Thread Stephen Boyd
n > Reviewed-by: Logan Gunthorpe > Reviewed-by: Luis Chamberlain Reviewed-by: Stephen Boyd Minor nits below. > diff --git a/kunit/test.c b/kunit/test.c > new file mode 100644 > index 0..571e4c65deb5c > --- /dev/null > +++ b/kunit/test.c > @@ -0,0 +1,189 @@ > +//

Re: [PATCH v9 02/18] kunit: test: add test resource management API

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-12 01:17:28) > diff --git a/kunit/test.c b/kunit/test.c > index 571e4c65deb5c..f165c9d8e10b0 100644 > --- a/kunit/test.c > +++ b/kunit/test.c > @@ -171,6 +175,96 @@ int kunit_run_tests(struct kunit_suite *suite) > return 0; > } > > +struct kunit_resource

Re: [PATCH v9 03/18] kunit: test: add string_stream a std::stream like string builder

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-12 01:17:29) > diff --git a/include/kunit/string-stream.h b/include/kunit/string-stream.h > new file mode 100644 > index 0..0552a05781afe > --- /dev/null > +++ b/include/kunit/string-stream.h > @@ -0,0 +1,49 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ >

Re: [PATCH v9 06/18] kbuild: enable building KUnit

2019-07-15 Thread Stephen Boyd
Acked-by: Masahiro Yamada > Cc: Michal Marek > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Logan Gunthorpe > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v9 02/18] kunit: test: add test resource management API

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-15 13:30:22) > On Mon, Jul 15, 2019 at 1:24 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-07-12 01:17:28) > > > diff --git a/kunit/test.c b/kunit/test.c > > > index 571e4c65deb5c..f165c9d8e10b0 100644 > > >

Re: [PATCH v9 03/18] kunit: test: add string_stream a std::stream like string builder

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-15 14:11:50) > On Mon, Jul 15, 2019 at 1:43 PM Stephen Boyd wrote: > > > > I also wonder if it would be better to just have a big slop buffer of a > > 4K page or something so that we almost never have to allocate anything > > with a st

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-15 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-12 01:17:30) > diff --git a/include/kunit/kunit-stream.h b/include/kunit/kunit-stream.h > new file mode 100644 > index 0..a7b53eabf6be4 > --- /dev/null > +++ b/include/kunit/kunit-stream.h > @@ -0,0 +1,81 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-16 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-16 01:37:34) > On Tue, Jul 16, 2019 at 12:57 AM Brendan Higgins > wrote: > > > > On Mon, Jul 15, 2019 at 3:15 PM Stephen Boyd wrote: > > > > > > Quoting Brendan Higgins (2019-07-12 01:17:30) > > > > diff --git a/in

Re: [PATCH v9 03/18] kunit: test: add string_stream a std::stream like string builder

2019-07-16 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-15 15:43:20) > On Mon, Jul 15, 2019 at 3:11 PM Brendan Higgins > wrote: > > > > On Mon, Jul 15, 2019 at 3:04 PM Stephen Boyd wrote: > > > > > > Quoting Brendan Higgins (2019-07-15 14:11:50) > > > > On

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-16 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-16 01:37:34) > On Tue, Jul 16, 2019 at 12:57 AM Brendan Higgins > wrote: > > > > A `struct kunit_stream` is usually associated with a message that is > > being built up over time like maybe an expectation; it is meant to > > capture the idea that we might want to s

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-18 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-16 11:52:01) > On Tue, Jul 16, 2019 at 10:50 AM Stephen Boyd wrote: > > > > > The only hypothetical case where this can't be done is a complicated > > assertion or expectation that does more than one check and can't be > &

Re: [PATCH] drm/msm: stop abusing dma_map/unmap for cache

2019-07-18 Thread Stephen Boyd
1 : f000 x0 : >Call trace: > __iommu_dma_unmap+0xb8/0xc0 > iommu_dma_unmap_sg+0x98/0xb8 > put_pages+0x5c/0xf0 [msm] > msm_gem_free_work+0x10c/0x150 [msm] > process_one_work+0x1e0/0x330 > worker_thread+0x40/0x438 > kthread+0x12c/0x130 > ret_from_fork+0x10/0x18 >---[ end trace afc0dc5ab81a06bf ]--- Tested-by: Stephen Boyd

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-22 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-18 17:08:34) > On Thu, Jul 18, 2019 at 12:22:33PM -0700, Brendan Higgins wrote: > > I started poking around with your suggestion while we are waiting. A > couple early observations: > > 1) It is actually easier to do than I previously thought and will probably >

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-22 Thread Stephen Boyd
Quoting Brendan Higgins (2019-07-22 15:30:49) > On Mon, Jul 22, 2019 at 1:03 PM Stephen Boyd wrote: > > > > > > What's the calling context of the assertions and expectations? I still > > don't like the fact that string stream needs to allocate buffers and

Re: [PATCH] drm/msm: Use generic bulk clock function

2019-07-25 Thread Stephen Boyd
Quoting Jordan Crouse (2019-07-25 09:53:55) > Remove the homebrewed bulk clock get function and replace it with > devm_clk_bulk_get_all(). > > Signed-off-by: Jordan Crouse > --- Reviewed-by: Stephen Boyd

[PATCH v6 47/57] video: Remove dev_err() usage after platform_get_irq()

2019-07-31 Thread Stephen Boyd
iewicz Cc: dri-devel@lists.freedesktop.org Cc: linux-fb...@vger.kernel.org Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd --- Please apply directly to subsystem trees drivers/video/fbdev/atmel_lcdfb.c | 1 - drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 1 - drivers/video/fbdev/nuc900fb.c

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-08-01 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-01 11:59:57) > On Thu, Aug 1, 2019 at 11:55 AM Brendan Higgins > wrote: > > > > On Fri, Jul 26, 2019 at 1:31 AM Petr Mladek wrote: > > > > > To be honest I do not fully understand KUnit design. I am not > > > completely sure how the tested code is isolated from th

Re: [PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation

2022-06-06 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-06 08:24:24) > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index f634371c717a..e12056cfeca8 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c > @@ -223,6 +223,15 @@ int drm_panel_get_modes(struct drm_panel *pane

Re: [PATCH v4 4/8] drm/panel: lvds: Implement .get_orientation callback

2022-06-06 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-06 08:24:27) > diff --git a/drivers/gpu/drm/panel/panel-lvds.c > b/drivers/gpu/drm/panel/panel-lvds.c > index f11252fb00fe..491b64c2c8d6 100644 > --- a/drivers/gpu/drm/panel/panel-lvds.c > +++ b/drivers/gpu/drm/panel/panel-lvds.c > @@ -99,15 +99,30 @@ static int panel

Re: [PATCH v4 8/8] drm/mediatek: Config orientation property if panel provides it

2022-06-06 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-06 08:24:31) > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index d9f10a33e6fa..c56282412bfa 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -822,6 +823,12 @@ static int mtk_

Re: [PATCH v2 02/12] dt-bindings: display/msm: hdmi: mark old GPIO properties as deprecated

2022-06-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:13) > Mark obsolete GPIO properties as deprecated. They are not used by > existing device trees. While we are at it, also drop them from the > schema example. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 03/12] dt-bindings: display/msm: hdmi: mark hdmi-mux-supply as deprecated

2022-06-08 Thread Stephen Boyd
etc). Mark it as deprecated. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 04/12] arm: dts: qcom: apq8064-ifc6410: drop hdmi-mux-supply

2022-06-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:15) > The HDMI circuitry on the IFC6410 is not powered by the 3v3. Drop the > hdmi-mux-supply property. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 05/12] drm/msm/hdmi: drop the hdmi-mux support

2022-06-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:16) > With the last (and only) in-kernel user of hdmi-mux regulator, drop it > from the HDMI driver. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 06/12] drm/msm/hdmi: drop unused GPIO support

2022-06-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:17) > @@ -543,41 +529,16 @@ static int msm_hdmi_bind(struct device *dev, struct > device *master, void *data) > hdmi_cfg->mmio_name = "core_physical"; > hdmi_cfg->qfprom_mmio_name = "qfprom_physical"; > > - for (i = 0; i < HDMI_M

Re: [PATCH v2 08/12] drm/msm/hdmi: drop empty 'none' regulator lists

2022-06-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:19) > Several platform configs use empty 'none' regulator arrays. They are not > necessary, as the code will use corresponding _cnt field and skip the > array completely. Drop them now. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 07/12] drm/msm/hdmi: enable core-vcc/core-vdda-supply for 8996 platform

2022-06-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:18) > DB820c makes use of core-vcc-supply and core-vdda-supply, however the > driver code doesn't support these regulators. Enable them for HDMI on > 8996 platform. The 'vdda-supply' name makes me think this is another scenario where the phy isn't powerin

Re: [PATCH v2 09/12] drm/msm/hdmi: drop hpd_regs usage on 8x74/8084

2022-06-08 Thread Stephen Boyd
; Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 10/12] drm/msm/hdmi: merge platform config for 8974/8084/8994/8996

2022-06-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:21) > Since there is no more difference between the HDMI platform data > between MSM8974/APQ8084/MSM8994/MSM8996, merge these configs into a > single entry. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 11/12] drm/msm/hdmi: reuse MSM8960's config for MSM8660

2022-06-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:22) > MSM8660 requires the same set of clocks and regulators as MSM8960. Reuse > MSM8960's config for the MSM8660 (8x60). > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 12/12] drm/msm/hdmi-phy: populate 8x60 HDMI PHY requirements

2022-06-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:23) > Declare that 8x60 HDMI PHY uses the core-vdda regulator and slave_iface > clock (this is the same config as is used by the 8960). > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v6 1/8] drm/panel: Add an API to allow drm to set orientation from panel

2022-06-08 Thread Stephen Boyd
panel_orientation); Then this fits on one line: return drm_connector_set_panel_orientation(connector, orientation); > +} > +EXPORT_SYMBOL(drm_connector_set_orientation_from_panel); > + Otherwise Reviewed-by: Stephen Boyd

Re: [PATCH v6 2/8] drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback

2022-06-08 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-08 02:48:10) > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > Reviewed-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v6 3/8] drm/panel: panel-edp: Implement .get_orientation callback

2022-06-08 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-08 02:48:11) > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > Reviewed-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v6 7/8] drm/panel: elida-kd35t133: Implement .get_orientation callback

2022-06-08 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-08 02:48:15) > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > Reviewed-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v6 6/8] drm/panel: ili9881c: Implement .get_orientation callback

2022-06-08 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-08 02:48:14) > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > Reviewed-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v6 5/8] drm/panel: panel-simple: Implement .get_orientation callback

2022-06-08 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-08 02:48:13) > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > Reviewed-by: Douglas Anderson > Reviewed-by: Sam Ravnborg > --- Reviewed-by: Stephen Boyd

Re: [PATCH v6 4/8] drm/panel: lvds: Implement .get_orientation callback

2022-06-08 Thread Stephen Boyd
Quoting Hsin-Yi Wang (2022-06-08 02:48:12) > To return the orientation property to drm/kms driver. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede > Reviewed-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf

2022-06-08 Thread Stephen Boyd
drm: convert drivers to use of_graph_get_remote_node") > Signed-off-by: Miaoqian Lin > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()

2022-06-09 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-02 03:20:19) > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > wrote: > > diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c > > index 54942d758ee6..fabb98d0cdb2 100644 > > --- a/drivers/clk/clk-fixed-factor.c > > +++ b/drivers/clk/clk-fixe

Re: [PATCH v2 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()

2022-06-10 Thread Stephen Boyd
Quoting Marijn Suijten (2022-06-10 00:46:32) > On 2022-06-09 15:12:09, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-06-02 03:20:19) > > > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > > > wrote: > > > > diff --git a/drivers/clk/clk-fixed-fa

Re: [PATCH v7 8/8] drm: Config orientation property if panel provides it

2022-06-10 Thread Stephen Boyd
Suggested-by: Doug Anderson > Signed-off-by: Hsin-Yi Wang > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/hdmi: fill the pwr_regs bulk regulators

2022-06-10 Thread Stephen Boyd
y. > > Fixes: 31b3b1f5e352 ("drm/msm/hdmi: use bulk regulator API") > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 06/14] drm/msm/hdmi: drop unused GPIO support

2022-06-10 Thread Stephen Boyd
. > > Reported-by: kernel test robot > Signed-off-by: Dmitry Baryshkov > --- One question Reviewed-by: Stephen Boyd > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c > index 7267167d5ef1..6d79f1b910a5 100644 > --- a/drivers/gpu/drm/msm/hdmi/h

Re: [PATCH v4] drm/msm/dp: force link training for display resolution change

2022-06-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-05-27 14:32:13) > During display resolution changes display have to be disabled first > followed by display enabling with new resolution. Display disable > will turn off both pixel clock and main link clock so that main link > have to be re trained during display enable t

Re: [PATCH v2] drm/msm/dp: check core_initialized before disable interrupts at dp_display_unbind()

2022-06-10 Thread Stephen Boyd
es really helps anyone, but OK. > > changes in v2: > -- drop the first patch (drm/msm: enable msm irq after all initializations > are done successfully at msm_drm_init()) since the problem had been fixed by > other patch > > Fixes: a65c95ff88f2 ("drm/msm/dp: stop event kernel thread when DP unbind") > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5] drm/msm/dp: force link training for display resolution change

2022-06-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-06-13 14:48:37) > During display resolution changes display have to be disabled first > followed by display enabling with new resolution. Display disable > will turn off both pixel clock and main link clock so that main link > have to be re-trained during display enable t

Re: [PATCH v6] drm/msm/dp: force link training for display resolution change

2022-06-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-06-14 14:05:02) > Display resolution change is implemented through drm modeset. Older > modeset (resolution) has to be disabled first before newer modeset > (resolution) can be enabled. Display disable will turn off both > pixel clock and main link clock so that main link

Re: [PATCH v7] drm/msm/dp: force link training for display resolution change

2022-06-15 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-06-15 08:53:57) > Display resolution change is implemented through drm modeset. Older > modeset (resolution) has to be disabled first before newer modeset > (resolution) can be enabled. Display disable will turn off both > pixel clock and main link clock so that main link

Re: [PATCH v2 4/5] drm/msm: move KMS aspace init to the separate helper

2022-06-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-05-04 17:16:04) > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index a37a3bbc04d9..98ae0036ab57 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -262,6 +263,46 @@ static int msm_drm_uninit(struct d

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-06-15 22:59:25) > Hi Dmitry > > On 6/15/2022 10:55 PM, Dmitry Baryshkov wrote: > > On 14/06/2022 22:32, Abhinav Kumar wrote: > >> intf and wb resources are not dependent on the rm global > >> state so need not be allocated during dpu_encoder_virt_atomic_mode_set(). > >>

Re: [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

2022-06-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-15 23:21:56) > > I have more or less the same setup using a longer format and using the > git-log instead of git-show. This way I can just do a git fixes > drivers/gpu/drm/msm and spot the commit in question. I've long desired to have this be part of checkpatch.pl

Re: [PATCH v4 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support

2022-06-16 Thread Stephen Boyd
Quoting Prashant Malani (2022-06-15 10:20:20) > > .../display/bridge/analogix,anx7625.yaml | 64 +++ > 1 file changed, 64 insertions(+) Can this file get a link to the product brief[1]? It helps to quickly find the block diagram. > > diff --git > a/Documentation/devicetree/

Re: [PATCH v3 07/14] drm/msm/hdmi: enable core-vcc/core-vdda-supply for 8996 platform

2022-06-16 Thread Stephen Boyd
or msm8996") > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/gem: Drop obj lock in msm_gem_free_object()

2022-06-16 Thread Stephen Boyd
Quoting Rob Clark (2022-06-13 13:50:32) > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h > index d608339c1643..432032ad4aed 100644 > --- a/drivers/gpu/drm/msm/msm_gem.h > +++ b/drivers/gpu/drm/msm/msm_gem.h > @@ -229,7 +229,19 @@ msm_gem_unlock(struct drm_gem_object *obj

Re: [PATCH v8 2/2] drm/msm/dp: clean up pixel_rate from dp_ctrl.c

2022-06-16 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-06-16 10:09:21) > dp_ctrl keep an local cache of pixel_rate which increase confusing > in regrading how pixel_rate being used. This patch refer pixel_rate > directly from dp_panel to eliminate unnecessary pixel_rate variable > from struct dp_ctrl. > > Changes in v8: > --

Re: [PATCH v8 1/2] drm/msm/dp: force link training for display resolution change

2022-06-16 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-06-16 10:09:20) > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.h > b/drivers/gpu/drm/msm/dp/dp_ctrl.h > index 0745fde..9a39b00 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.h > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.h > @@ -21,7 +21,8 @@ struct dp_ctrl { > }; > > int dp_c

Re: [PATCH v9] drm/msm/dp: force link training for display resolution change

2022-06-16 Thread Stephen Boyd
: > -- drop 0 assignment at local variable (ret = 0) > > Changes in v8: > -- add patch to remove pixel_rate from dp_ctrl > > Changes in v9: > -- forward declare dp_ctrl_on_stream_phy_test_report() > > Fixes: 62671d2ef24b ("drm/msm/dp: fixes wrong connection state caused by > failure of link train") > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/2] drm/msm/dp: remove dp_display_en/disable prototypes and data argument

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 12:49:21) > Remove unused dp_display_en/disable prototypes. While we are at it, > remove extra 'data' argument that is unused. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 13 + > 1 file changed, 5 insertions(+)

Re: [PATCH 1/2] drm/msm/dp: remove unused stubs

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 12:49:20) > Refactoring DP code transformed several functions into empty stubs. > Remove them. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

[PATCH 0/3] drm/msm/dp: More cleanups for force link train

2022-06-17 Thread Stephen Boyd
These patches do a little cleanup on the v9 patch from Kuogee. Stephen Boyd (3): drm/msm/dp: Reorganize code to avoid forward declaration drm/msm/dp: Remove pixel_rate from struct dp_ctrl drm/msm/dp: Get rid of dp_ctrl_on_stream_phy_test_report() drivers/gpu/drm/msm/dp/dp_ctrl.c | 145

[PATCH 1/3] drm/msm/dp: Reorganize code to avoid forward declaration

2022-06-17 Thread Stephen Boyd
Let's move these functions around to avoid having to forward declare dp_ctrl_on_stream_phy_test_report(). Also remove dp_ctrl_reinitialize_mainlink() forward declaration because we're doing that sort of task. Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp

[PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-17 Thread Stephen Boyd
_rate but never using it so we just remove the assignment from there. Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 57 drivers/gpu/drm/msm/dp/dp_ctrl.h | 1 - 2 files changed, 28 insertions(+), 30 deletions(-) diff --git a/dr

[PATCH 3/3] drm/msm/dp: Get rid of dp_ctrl_on_stream_phy_test_report()

2022-06-17 Thread Stephen Boyd
This API isn't really more than a couple lines now that we don't store the pixel_rate to the struct member. Inline it into the caller. Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 40 1 file changed, 15 inserti

Re: [PATCH v5 1/3] drm/msm/mdp4: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 12:14:27) > Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() > instead. > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 2/3] drm/msm/mdp5: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 12:14:28) > Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() > instead. > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 3/3] drm/msm: stop storing the array of CRTCs in struct msm_drm_private

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 12:14:29) > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 44485363f37a..567e77dae43b 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -427,20 +428,23 @@ static int msm_drm_init(struct de

Re: [PATCH] drm/msm/hdmi: drop empty bridge callbacks

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-16 01:50:54) > Drop empty callbacks msm_hdmi_bridge_enable() and > msm_hdmi_bridge_disable(). > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/hdmi: support attaching the "next" bridge

2022-06-17 Thread Stephen Boyd
; --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/3] drm/msm/hdmi: make hdmi_phy_8996 OF clk provider

2022-06-17 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 3/3] arm64: dts: qcom: msm8996: add #clock-cells to the HDMI PHY node

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 03:36:08) > Add #clock-cells property to the HDMI PHY device node to let other nodes > resolve the hdmipll clock. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

[PATCH] drm/msm/dpu: Increment vsync_cnt before waking up userspace

2022-06-21 Thread Stephen Boyd
Trogdor boards. Cc: Mark Yacoub Cc: Jessica Zhang Fixes: 885455d6bf82 ("drm/msm: Change dpu_crtc_get_vblank_counter to use vsync count.") Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-21 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 16:07:58) > On 17/06/2022 23:47, Stephen Boyd wrote: > > This struct member is stored to in the function that calls the function > > which uses it. That's possible with a function argument instead of > > storing to a struct member.

Re: [PATCH] drm/msm/dp: reset drm_dev to NULL at dp_display_unbind()

2022-06-22 Thread Stephen Boyd
> [ 53.840875] drm_dev_dbg+0xfc/0x1b8 > [ 53.844480] dp_pm_suspend+0x70/0xf8 > [ 53.848164] dpm_run_callback+0x60/0x1a0 > [ 53.85] __device_suspend+0x304/0x3f4 > [ 53.856363] dpm_suspend+0xf8/0x3a8 > [ 53.859959] dpm_suspend_start+0x8c/0xc0 > > Signed-off-by: Kuogee Hsieh > --- Any fixes tag? Reviewed-by: Stephen Boyd

Re: [PATCH v1 0/3] Add support for eDP PHY on SC7280 platform

2022-02-02 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-11-15 23:07:35) > This series adds support for the eDP PHY on Qualcomm SC7280 platform. > The changes are dependent on v4 of the new eDP PHY driver introduced by Bjorn: > https://patchwork.kernel.org/project/linux-arm-msm/list/?series=575135 > > Sankeerth Billakan

Re: [PATCH v2] drm/msm/dp: add connector type to enhance debug messages

2022-02-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-31 18:34:47) > On 27/01/2022 02:46, Kuogee Hsieh wrote: > > DP driver is a generic driver which supports both eDP and DP. > > For debugging purpose it is required to have capabilities to > > differentiate message are generated from eDP or DP. > > This patch do: > >

Re: [PATCH v3 1/4] dt-bindings: display: simple: Add sharp LQ140M1JW46 panel

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:29) > Add support for sharp LQ140M1JW46 display panel. It is a 14" eDP panel > with 1920x1080 display resolution. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 2/4] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:30) > Enable the eDP display panel support without HPD on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v3: > - Sort the nodes alphabetically > - Use - instead of _ as node names > - Place the backlight and panel

Re: [PATCH v3 3/4] drm/panel-edp: Add eDP sharp panel support

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:31) > Add support for the 14" sharp,lq140m1jw46 eDP panel. > > Signed-off-by: Sankeerth Billakanti > --- Can you share the edid-decode for this panel here under the cut "---"? It would help to see the timings and make sure everything matches.

Re: [PATCH v3 4/4] drm/msm/dp: Add driver support to utilize drm panel

2022-02-09 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-02-09 00:55:32) > Add support in the DP driver to utilize the custom eDP panels > from drm/panels. > > An eDP panel is always connected to the platform. So, the eDP > connector can be reported as always connected. The display mode > will be sourced from the panel.

Re: [PATCH v6 02/35] component: Introduce the aggregate bus_type

2022-02-10 Thread Stephen Boyd
; > > > > On Thu, Jan 27, 2022 at 12:01:08PM -0800, Stephen Boyd wrote: > > > > > The component framework only provides 'bind' and 'unbind' callbacks to > > > > > tell the host driver that it is time to assemble the aggregate

Re: [PATCH v2 1/8] drm/msm/dpu: fix dp audio condition

2022-02-15 Thread Stephen Boyd
rm/msm/dp: add audio support for Display Port on MSM") > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 2/8] drm/msm: move struct msm_display_info to dpu driver

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:37) > The msm_display_info structure is not used by the rest of msm driver, so > move it into the dpu1 (dpu_encoder.h to be precise). > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 3/8] drm/msm/dpu: remove msm_dp cached in dpu_encoder_virt

2022-02-15 Thread Stephen Boyd
> Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 4/8] drm/msm/dpu: drop bus_scaling_client field

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:39) > We do not use MSM bus client, so drop bus_scaling_client field from > dpu_encoder_virt. > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 5/8] drm/msm/dpu: encoder: drop unused mode_fixup callback

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:40) > Both cmd and vid backends provide useless mode_fixup() callback. Drop > it. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 6/8] drm/msm/dpu: switch dpu_encoder to use atomic_mode_set

2022-02-15 Thread Stephen Boyd
: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

<    3   4   5   6   7   8   9   10   11   12   >