On 2021-04-15 13:00, Thomas Zimmermann wrote:
> Selecting DRM_FBDEV_EMULATION will include the correct secttings for
> fbdev emulation. Drivers should not override this.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Stefan Agner
--
Stefan
> ---
> drivers/gpu/drm/mxsfb/
ronization with other devices. Fix
>> this by plugging in the drm_gem_fb_prepare_fb helper function.
>
> This is a regression in the 5.10 release series, so I would appreciate
> if someone could review/ack this patch so I can smash it into
> drm-misc-fixes.
Reviewed-by: Stefan
fb: Stop using DRM simple display
> pipeline helper")
Reviewed-by: Stefan Agner
I allowed myself to update the author email to the one used in the
Signed-off-by line as checkpatch.pl printed a warning.
Applied to drm-misc-fixes. Thanks!
--
Stefan
> ---
> drivers/gpu/d
On 2021-10-11 15:41, Guido Günther wrote:
> media-bus-formats.h has them in hexadecimal as well so matching with
> that file saves one conversion when debugging.
>
> Signed-off-by: Guido Günther
> Reviewed-by: Lucas Stach
> Reviewed-by: Robert Foss
Acked-by: Stefan Agner
ls.
>
> Reported-by: Martin Kepplinger
> Signed-off-by: Guido Günther
> Reviewed-by: Lucas Stach
Acked-by: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/mxsfb_kms.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.
On 2021-10-05 14:35, Matthias Schiffer wrote:
> On Thu, 2021-09-16 at 14:50 +0200, Matthias Schiffer wrote:
>> On Fri, 2020-08-21 at 15:41 +0200, Stefan Agner wrote:
>> > Hi Matthias,
>> >
>> > On 2020-08-20 12:58, Matthias Schiffer wrote:
>> > &g
Applied patchset to my fsl-dcu tree.
--
Stefan
On 2016-04-16 22:25, Stefan Agner wrote:
> Hi all,
>
> This patchset fixes several issues around unloading/unbinding
> the driver. There is still one WARNING when unloading the driver
> while vblank interrupts are enabled. I am no
ssive stack usage
Stefan Agner (11):
drm/fsl-dcu: disable clock on initialization failure and remove
drm/fsl-dcu: add extra clock for pixel clock
drm/fsl-dcu: use common clock framework for pixel clock divider
drm/fsl-dcu: add TCON driver
drm/fsl-dcu: detach panel on de
On 2016-08-22 00:13, Meng Yi wrote:
>> fsl_dev->pix_clk = clk_register_divider(dev, pix_clk_name,
>> pix_clk_in_name, 0, base + DCU_DIV_RATIO,
>> -0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL);
>> +24, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL);
>
c_free
Fixes: de5469c21ff9 ("gpu: host1x: Program the channel stream ID")
Signed-off-by: Stefan Agner
---
drivers/gpu/host1x/hw/channel_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/hw/channel_hw.c
b/drivers/gpu/host1x/hw/channel_hw.c
in
On 11.04.2019 10:23, Ben Dooks wrote:
> On 2019-04-10 23:47, Stefan Agner wrote:
>> In case the IOMMU API is not available compiling host1x fails with
>> the following error:
>> In file included from drivers/gpu/host1x/hw/host1x06.c:27:
>> drivers/gpu/host1x/h
On 02.01.2019 18:02, Ahmad Fatoum wrote:
> Hello,
>
> I got a board with the RED[0:7]/BLUE[0:7] lanes originating from the
> LCDIF swapped and would like to describe this in the device tree:
>
> This first patch extends the mxsfb driver to support
> following bus formats:
> MEDIA_BUS_FMT_BG
On 09.01.2019 15:13, Robert Chiras wrote:
> Currently, the enable of the axi clock return status is ignored, causing
> issues when the enable fails then we try to disable it. Therefore, it is
> better to check the return status and disable it only when enable
> succeeded.
> Also, remove the helper
riving and sampling edge in their name to remove the confusion. The
> driving macros are defined as the opposite of the sampling macros to
> made code simpler based on the assumption that the driving and sampling
> edges are opposite.
>
> Signed-off-by: Laurent Pinchart
>
> Acked-by: Linus Walleij
Reviewed-by: Stefan Agner
--
Stefan
> ---
> Changes since v1:
>
> - Clarify commit message
> - Address the DRM_BUS_FLAG_SYNC_* flags
> - Rebase on top of drm-next
> ---
> drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 ++---
> drivers
On 14.06.2019 22:35, Daniel Vetter wrote:
> They're the default.
>
> Aside: Would be really nice to switch the others over to
> drm_gem_object_funcs.
Acked-by: Stefan Agner
--
Stefan
>
> Signed-off-by: Daniel Vetter
> Cc: Marek Vasut
> Cc: Stefan Agner
> C
On 14.06.2019 22:35, Daniel Vetter wrote:
> They're the default.
>
> Aside: Would be really nice to switch the others over to
> drm_gem_object_funcs.
Acked-by: Stefan Agner
--
Stefan
>
> Signed-off-by: Daniel Vetter
> Cc: Stefan Agner
> Cc: Alison Wang
>
On 2019-06-30 08:18, Sam Ravnborg wrote:
> Drop use of the deprecated drmP.h header file.
> Fix fallout.
>
> Signed-off-by: Sam Ravnborg
> Cc: Stefan Agner
> Cc: Alison Wang
Acked-by: Stefan Agner
--
Stefan
> ---
> The list of cc: was too large to add all recipi
arek Vasut
> Cc: Stefan Agner
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Shawn Guo
> Cc: Sascha Hauer
> Cc: Pengutronix Kernel Team
> Cc: Fabio Estevam
> Cc: NXP Linux Team
> Cc: linux-arm-ker...@lists.infradead.org
Acked-by: Stefan Agner
--
Stefan
> ---
On 2019-07-15 18:28, Sam Ravnborg wrote:
> On Fri, Jul 05, 2019 at 10:47:30PM +0200, Stefan Agner wrote:
>> On 2019-06-30 08:18, Sam Ravnborg wrote:
>> > Drop use of the deprecated drmP.h header file.
>> >
>> > While touching the list of include files divid
On 2019-07-26 11:49, Guido Günther wrote:
> The bridge might have special requirmentes on the input bus. This
> is e.g. used by the imx-nwl bridge.
>
> Signed-off-by: Guido Günther
Looks good to me.
Reviewed-by: Stefan Agner
That is similar to what I sent for the imx DRM dr
s good to me.
Reviewed-by: Stefan Agner
--
Stefan
> ---
> drivers/gpu/drm/bridge/simple-bridge.c | 22 ++
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/simple-bridge.c
> b/drivers/gpu/drm/bridge/simple-bridge.c
>
*timings;
> + unsigned int type;
How about connector_type? That is how this field is named in other
places.
Otherwise looks good to me.
Reviewed-by: Stefan Agner
--
Stefan
> +};
> +
> struct simple_bridge {
> struct drm_bridge bridge;
> str
Hi Thierry, Hi Dave,
On 2018-09-07 01:31, Stefan Agner wrote:
> On 26.07.2018 06:36, Stefan Agner wrote:
>> If the GPIO subsystem is not ready make sure to return -EPROBE_DEFER
>> instead of silently continuing without HPD.
>>
>> Reported-by: Marcel Ziswiler
>
On 2019-07-26 16:46, Dmitry Osipenko wrote:
> 26.07.2019 17:23, Stefan Agner пишет:
>> Hi Thierry, Hi Dave,
>>
>> On 2018-09-07 01:31, Stefan Agner wrote:
>>> On 26.07.2018 06:36, Stefan Agner wrote:
>>>> If the GPIO subsystem is not ready make sure to ret
ed-off-by: Marek Vasut
> Cc: Alexander Stein
> Cc: Laurent Pinchart
> Cc: Lucas Stach
> Cc: Peng Fan
> Cc: Robby Cai
> Cc: Sam Ravnborg
> Cc: Stefan Agner
> ---
> V2: Check crtc for non-NULL before dereferencing it in
> mxsfb_crtc_set_crc_source
> ---
> d
t; Cc: Robby Cai
> Cc: Sam Ravnborg
> Cc: Stefan Agner
> ---
> drivers/gpu/drm/mxsfb/Kconfig | 16 +
> drivers/gpu/drm/mxsfb/Makefile | 2 +
> drivers/gpu/drm/mxsfb/lcdif_drv.c | 367 +
> drivers/gpu/drm/mxsfb/lcd
Hi Laurent,
On 2019-11-01 09:43, Laurent Pinchart wrote:
> Hello,
>
> I'm looking at the available options to support overlays in the display
> pipeline of the i.MX7. The LCDIF itself unfortunaltey doesn't support
> overlays, the feature being implemented in the PXP. A driver for the PXP
> is ava
On 2019-11-14 14:17, Marek Vasut wrote:
> The bus_flags and bus_format handling logic does not seem to cover
> all potential usecases. Specifically, this seems to fail with an
> "edt,etm0700g0edh6" display attached to an 24bit display interface,
> with interface-pix-fmt = "rgb24" set in DT.
>
> In
Hi Robert,
Sorry it took me so long to have a closer look at this patchset.
I will definitely merge part of it, but this particular patch actually
breaks i.MX 7. I have vertical stripes on my display with this patch
applied (using Weston with DRM backend). Not sure why this exactly
happens, from
On 2019-08-29 13:30, Robert Chiras wrote:
> Some of the registers, like LCDC_CTRL, CTRL2_OUTSTANDING_REQS and
> CTRL1_RECOVERY_ON_UNDERFLOW needs to be properly cleared/initialized
> for a better start and stop routine.
This patch uses CTRL2_OUTSTANDING_REQS which is only introduced in the
next p
On 2019-08-29 13:30, Robert Chiras wrote:
> Use BIT(x) and GEN_MASK(h, l) for better representation the inside of
> various registers.
>
> Signed-off-by: Robert Chiras
> Tested-by: Guido Günther
> ---
> drivers/gpu/drm/mxsfb/mxsfb_regs.h | 151
> ++---
> 1 file
On 2019-08-29 13:30, Robert Chiras wrote:
> Currently, the MXSFB DRM driver only supports a panel. But, its output
> display signal can also be redirected to another encoder, like a DSI
> controller. In this case, that DSI controller may act like a drm_bridge.
> In order support this use-case too,
On 2019-08-29 13:30, Robert Chiras wrote:
> From: Guido Günther
>
> The bridge might have special requirmentes on the input bus. This
> is e.g. used by the imx-nwl bridge.
>
> Signed-off-by: Guido Günther
> Reviewed-by: Stefan Agner
Applied to the drm-misc-next branch
statement is here
if (!drm_core_check_feature(dev, DRIVER_LEGACY))
^
Fix this by adding a newline after the multi-line comment.
Fixes: 058ca50ce3f1 ("drm/legacy: move lock cleanup for master into lock file
(v2)")
Link: https://github.com/ClangBuiltLinux/linux/issues/855
On 2020-02-05 23:50, Joe Perches wrote:
> On Wed, 2020-02-05 at 23:26 +0100, Stefan Agner wrote:
>> Clang prints a warning:
>> drivers/gpu/drm/drm_lock.c:363:6: warning: misleading indentation;
>> statement is not part of the previous 'if' [-Wmisleading-indentation
On 2019-08-26 14:05, Guido Günther wrote:
> Hi,
> On Wed, Aug 21, 2019 at 01:15:40PM +0300, Robert Chiras wrote:
>> This patch-set improves the use of eLCDIF block on iMX 8 SoCs (like 8MQ, 8MM
>> and 8QXP). Following, are the new features added and fixes from this
>> patch-set:
>
> I've applied th
On 2019-08-04 22:16, Sam Ravnborg wrote:
> Use drm_panel_get_modes() to access modes.
> This has a nice side effect to simplify the code.
>
> Signed-off-by: Sam Ravnborg
> Cc: Stefan Agner
> Cc: Alison Wang
> ---
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 10 +--
On 2019-08-04 22:16, Sam Ravnborg wrote:
> Use the drm_panel_get_modes() function.
Looks good to me,
Acked-by: Stefan Agner
--
Stefan
>
> Signed-off-by: Sam Ravnborg
> Cc: Marek Vasut
> Cc: Stefan Agner
> Cc: Shawn Guo
> Cc: Sascha Hauer
> Cc: Pengutronix
On 2019-08-14 12:48, Robert Chiras wrote:
> Add new optional property 'max-res', to limit the maximum supported
> resolution by the MXSFB_DRM driver.
I would also mention the reason why we need this.
I guess this needs a vendor prefix as well (fsl,max-res). I also would
like to have the ack of th
On 2019-08-14 12:48, Robert Chiras wrote:
> Currently, the enable of the axi clock return status is ignored, causing
> issues when the enable fails then we try to disable it. Therefore, it is
> better to check the return status and disable it only when enable
> succeeded.
Is this actually the case
On 2019-08-14 12:48, Robert Chiras wrote:
> Some of the regiters need, like LCDC_CTRL and CTRL2_OUTSTANDING_REQS
Typo in registers, and there is a need to many.
> needs to be properly cleared and initialized for a better start and stop
> routine.
>
> Signed-off-by: Robert Chiras
> ---
> dri
On 2019-08-14 13:14, Robert Chiras wrote:
> Hi Stefan,
> On Mi, 2019-08-14 at 13:03 +0200, Stefan Agner wrote:
>> On 2019-08-14 12:48, Robert Chiras wrote:
>> >
>> > Add new optional property 'max-res', to limit the maximum supported
>> > resolution
block braces unnecessary. Remove that as well.
>
> Issue identified using platform_get_irq.cocci coccicheck script.
>
> Signed-off-by: Deepak R Varma
Reviewed-by: Stefan Agner
--
Stefan
> ---
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +---
> 1 file changed, 1 inser
Do not use encoder disable/enable callbacks to control bypass
mode as this seems to mess with the signals not liked by
displays. This also makes more sense since the encoder is
already defined to be parallel RGB/LVDS at creation time.
Signed-off-by: Stefan Agner
---
I tested that on Vybrid. Meng
There is no need to explicitly initiate a register transfer and
turn off the DCU after initializing the plane registers. In fact,
this is harmful and leads to unnecessary flickers if the DCU has
been left on by the bootloader.
Signed-off-by: Stefan Agner
---
If you could give this and 3/3 a try
The pixel clock should not be on if the CRTC is not in use, hence
move clock enable/disable calls into CRTC callbacks.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 7 +++
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 16 +---
2 files changed, 8
mode_set_nofb
- add patch which only init fbdev if required
- remove disable unprepare pixel clock on module remove (already disabled
in CRTC disable callback).
- remove unused label
Stefan Agner (5):
drm/fsl-dcu: enable TCON bypass mode by default
drm/fsl-dcu: do not transfer registers on plane init
Do not use encoder disable/enable callbacks to control bypass
mode as this seems to mess with the signals not liked by
displays. This also makes more sense since the encoder is
already defined to be parallel RGB/LVDS at creation time.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu
There is no need to explicitly initiate a register transfer and
turn off the DCU after initializing the plane registers. In fact,
this is harmful and leads to unnecessary flickers if the DCU has
been left on by the bootloader.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu
There is no need to explicitly initiate a register transfer and
turn off the DCU after initializing the plane registers. In fact,
this is harmful and leads to unnecessary flickers if the DCU has
been left on by the bootloader.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu
Do not schedule a transfer of mode settings early. Modes should
get applied on on CRTC enable where we also enable the pixel clock.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu
Do not schedule a transfer of mode settings early. Modes should
get applied on on CRTC enable where we also enable the pixel clock.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu
The pixel clock should not be on if the CRTC is not in use, hence
move clock enable/disable calls into CRTC callbacks.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 2 ++
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 21 +
2 files changed, 3
There is no need to request a CMA backed framebuffer if fbdev
emulation is not enabled.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
b/drivers/gpu/drm
The current fbdev emulation does not allow to push back changes in
width, height or depth to KMS, hence reject any changes with an
error. This makes sure that fbdev ioctl's fail properly and user
space does not assume that changes succeeded.
Signed-off-by: Stefan Agner
---
This re
On 2016-10-12 03:42, Ville Syrjälä wrote:
> On Tue, Oct 11, 2016 at 04:15:04PM -0700, Stefan Agner wrote:
>> The current fbdev emulation does not allow to push back changes in
>> width, height or depth to KMS, hence reject any changes with an
>> error. This makes sure th
On 2016-10-12 09:12, Ville Syrjälä wrote:
> On Wed, Oct 12, 2016 at 08:55:45AM -0700, Stefan Agner wrote:
>> On 2016-10-12 03:42, Ville Syrjälä wrote:
>> > On Tue, Oct 11, 2016 at 04:15:04PM -0700, Stefan Agner wrote:
>> >> The current fbdev emulation does not
anges since v1:
- add patch to no not transfer registers in mode_set_nofb
- add patch which only init fbdev if required
- remove disable unprepare pixel clock on module remove (already disabled
in CRTC disable callback).
- remove unused label
Stefan Agner (5):
drm/fsl-dcu: enable TCON bypass mo
Do not use encoder disable/enable callbacks to control bypass
mode as this seems to mess with the signals not liked by
displays. This also makes more sense since the encoder is
already defined to be parallel RGB/LVDS at creation time.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu
Do not schedule a transfer of mode settings early. Modes should
get applied on on CRTC enable where we also enable the pixel clock.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu
The pixel clock should not be on if the CRTC is not in use, hence
move clock enable/disable calls into CRTC callbacks.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 2 ++
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 21 +
2 files changed, 3
There is no need to explicitly initiate a register transfer and
turn off the DCU after initializing the plane registers. In fact,
this is harmful and leads to unnecessary flickers if the DCU has
been left on by the bootloader.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu
There is no need to request a CMA backed framebuffer if fbdev
emulation is not enabled.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
b/drivers/gpu/drm
On 2016-10-18 00:44, Daniel Vetter wrote:
> On Mon, Oct 17, 2016 at 02:33:21PM -0700, Stefan Agner wrote:
>> There is no need to request a CMA backed framebuffer if fbdev
>> emulation is not enabled.
>>
>> Signed-off-by: Stefan Agner
>> ---
>> driver
at
>> creation
>> time.
>>
>> Signed-off-by: Stefan Agner
>> ---
>> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 ++ drivers/gpu/drm/fsl-
>> dcu/fsl_dcu_drm_rgb.c | 39 ---
>> 2 files changed, 7 insertions(+), 34 deletions(-)
&g
pixel clock when enabling CRTC (2016-10-19 17:03:02 -0700)
Stefan Agner (4):
drm/fsl-dcu: enable TCON bypass mode by default
drm/fsl-dcu: do not transfer registers on plane init
drm/fsl-dcu: do not transfer registers
Use drm_put_dev to unload the driver before disabling clocks.
Otherwise the driver might read a register during unload which
leads to an external abort.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Make sure that all outputs are disabled before unloading the DRM
driver. Otherwise vblank handling is not shut down properly and
warnings such as this appear:
WARNING: CPU: 0 PID: 540 at drivers/gpu/drm/drm_irq.c:339
drm_vblank_cleanup+0x5c/0x94
Signed-off-by: Stefan Agner
---
drivers/gpu/drm
If fbdev emulation is not in use (or not built-in), fb_helper.fbdev
is NULL. Don't call calling drm_fbdev_cma_defio_fini in this case.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gp
iver?
Any ideas?
--
Stefan
Stefan Agner (3):
drm/fb_cma_helper: do not free fbdev if there is none
drm/fsl-dcu: unload driver before disabling clocks
drm/fsl-dcu: disable outputs before unloading driver
drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++-
drivers/gpu/drm/fsl-dcu/fsl_d
f-by: Shawn Guo
> Cc: Stefan Agner
Acked-by: Stefan Agner
> ---
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 26 ++
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 25 -
> 2 files changed, 26 insertions(+), 25 deletions(-)
>
On 2016-12-28 08:48, Fabio Estevam wrote:
> From: Fabio Estevam
>
> When devm_kzalloc() fails there is no need to assign an error code
> to the 'ret' variable as it will not be used after jumping to the
> 'err_node_put' label, so just remove the assignment.
>
> Signed-off-by: Fabio Estevam
App
Dave, Marek,
On 2016-12-14 13:25, Marek Vasut wrote:
> On 12/14/2016 09:48 PM, Stefan Agner wrote:
>> The DRM subsystem specifies the pixel clock polarity from a
>> controllers perspective: DRM_BUS_FLAG_PIXDATA_NEGEDGE means
>> the controller drives the data on pixel clocks
Hi Dave,
Just two minor fixes this time around.
--
Stefan
The following changes since commit 4eaa39c63caf535dc1a8cc43b9a8677a100c09e1:
Merge branch 'drm-rockchip-next-2017-02-07' of
https://github.com/markyzq/kernel-drm-rockchip into drm-next (2017-02-08
11:28:19 +1000)
are available in th
Hi Dave,
On 2016-09-19 00:16, Philipp Zabel wrote:
> Hi Dave,
>
> this tag contains support for the I2C master controller contained in the
> HDMI TX IP core, for those boards that don't allow to mux their DDC pins
> to SoC I2C controllers. This will make the dw-hdmi driver register its
> internal
/linux-drm-fsl-dcu.git fixes-for-v4.9-rc5
for you to fetch changes up to 3d6f37102bd6e4b55a7f336d44974c0bd1c22a15:
drm/fsl-dcu: disable planes before disabling CRTC (2016-11-08 17:14:08 -0800)
--------
Stefan Agner (3):
drm/fsl-d
On 2016-10-19 17:32, Stefan Agner wrote:
> Hi All,
>
> The first patch is a better alternative to the previously posted
> patch ("drm/fsl-dcu: only init fbdev if required") as suggested
> by Daniel.
>
> The second and third are fix related issue uncovered during t
The separate file fsl_dcu_drm_fbdev.c only initialized fbdev
emulation which is a one-line operation. There is not much more
code on sight which justifies a separate file, hence call the
initialization helper directly from the drv file.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu
mechanism to change depth
without having to change kernel code.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
b/drivers/gpu/drm/fsl-dcu
On 2016-11-16 07:38, Fabio Estevam wrote:
> devm_ioremap_resource() performs NULL check for the 'res' argument,
> so remove the unneeded check.
>
> Signed-off-by: Fabio Estevam
> ---
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers
On 2016-11-16 17:35, Stefan Agner wrote:
> The separate file fsl_dcu_drm_fbdev.c only initialized fbdev
> emulation which is a one-line operation. There is not much more
> code on sight which justifies a separate file, hence call the
> initialization helper directly from the drv
io Estevam (2):
drm/fsl-dcu: Remove unneeded NULL check
drm/fsl-dcu: Propagate the real error code
Stefan Agner (4):
drm/fsl-dcu: unload driver before disabling clocks
drm/fsl-dcu: disable outputs before unloading driver
drm/fsl-dcu: remove separate compilation unit
c| 6 +--
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 5 +--
For DCU
Acked-by: Stefan Agner
> drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 5 +--
> drivers/gpu/drm/imx/imx-ldb.c | 6 +--
> drivers/gpu/drm/imx/parallel-display
On 2017-06-15 10:26, Marek Vasut wrote:
> On 06/15/2017 05:12 PM, Fabio Estevam wrote:
>> Hi Marek,
>>
>> On Mon, Jun 5, 2017 at 9:08 AM, Marek Vasut wrote:
>>
>>> I'm currently on vacation, try one more time and if it doesn't work out
>>> (which means this trivial list is not really working?), I'
> Marek Vasut (1):
> drm: mxsfb: Fix crash when provided invalid DT bindings
>
> Stefan Agner (2):
> drm: mxsfb: use bus_format to determine LCD bus width
> drm: mxsfb: fix pixel clock polarity
>
> drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 49
> ++
be fine with your change.
I am ok with relaxing that again, so from my side:
Acked-by: Stefan Agner
--
Stefan
>
> The depths must match though, so keep the != test for that.
>
> Also update the DRM_DEBUG output to be slightly more accurate, this
> doesn't only affect reques
On 2017-05-24 07:51, Daniel Vetter wrote:
> Pull a (much shorter) overview into drm_irq.c, and instead put the
> callback documentation into in-line comments in drm_drv.h.
Looks good and just found all I needed to know to fix IRQ registration
in fsl dcu.
Reviewed-by: Stefan Agner
>
efore, I
think that fixed the races I saw.
But I guess what you are saying instead of using
drm_crtc_force_disable_all I should use drm_atomic_helper_shutdown...?
Will try that.
FWIW,
Acked-by: Stefan Agner
--
Stefan
>
> Cc: Stefan Agner
> Signed-off-by: Daniel Vetter
> ---
On 2017-05-24 07:51, Daniel Vetter wrote:
> drm_irq.c contains both the irq helper library (optional) and the
> vblank support (optional, but part of the modeset uapi, and doesn't
> require the use of the irq helpers at all.
>
> Split this up for more clarity of the scope of the individual bits.
>
On 2017-05-26 00:00, Daniel Vetter wrote:
> On Thu, May 25, 2017 at 10:18 AM, Stefan Agner wrote:
>> On 2017-05-24 07:51, Daniel Vetter wrote:
>>> Again cleanup before irq disabling doesn't really stop the races,
>>> so just drop it. Proper fix would be t
bit simpler.
Do not set irq_enabled since drm_irq_install is taking care of
it.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
b/drivers
Commit 18dddadc78c9 ("drm/atomic: Introduce drm_atomic_helper_shutdown")
introduced a new helper to shutdown all CRTCs to replace the buggy
drm_crtc_force_disable_all() function. Make use of the new atomic
helper drm_atomic_helper_shutdown() to shutdown CRTCs.
Signed-off-by: St
On 2017-05-31 01:52, Daniel Vetter wrote:
> On Tue, May 30, 2017 at 02:17:04PM -0700, Stefan Agner wrote:
>> On 2017-05-26 00:00, Daniel Vetter wrote:
>> > On Thu, May 25, 2017 at 10:18 AM, Stefan Agner wrote:
>> >> On 2017-05-24 07:51, Daniel Vetter wrote:
&
On 2017-06-01 20:00, Stefan Agner wrote:
> Make use of the irq_preinstall/uninstall callback to clear and
> mask all interrupts. Use write 1 to clear as documented by the
> data sheet (writing a 0 seems to have cleared interrupt status
> too). Remove fsl_dcu_drm_irq_init and call drm
9:14 -0700)
Daniel Vetter (1):
drm/fsl: Drop drm_vblank_cleanup
Stefan Agner (2):
drm/fsl-dcu: implement irq_preinstall/uninstall callbacks
drm/fsl-dcu: use new drm_atomic_helper_shutdown
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_
ot;.
> Create a second regmap for gamma memory space using little endian.
> The registers after the first address space are not accessed yet,
> hence new device trees would even work with old kernels. Just new
> kernel need the new format so we can access the separate gamma
> reg space.
ng the controller.
Signed-off-by: Stefan Agner
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
index 2ea9dbd..deb5743 100644
--- a/drivers/g
The kernel-doc references drm_atomic_commit_planes() which does not
exist. The functions name is drm_atomic_helper_commit_planes().
Signed-off-by: Stefan Agner
---
include/drm/drm_modeset_helper_vtables.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a
On 2016-08-31 23:42, Meng Yi wrote:
> Hi Stefan,
>
> Could you test this patch on vf610, I think it will woks fine.
See comment below.
>
> When could you merge this path? And how about the patches for gamma
> correction and multi-layer support by the way?
Still need to look in those patches. I
1 - 100 of 457 matches
Mail list logo
