Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Sebastian Reichel
ers > - elaborated commit message (Luis) > - collected given tags (incl. Andrew's SoB, see below) > > I added Andrew's SoB since part of the fixes I took from him. Andrew, > feel free to amend or tell me how you want me to do. > > [...] > drivers/power/re

[PATCHv2 4/5] dt-bindings: arm: fsl: add GE B1x5pv2 boards

2021-04-28 Thread Sebastian Reichel
Document the compatible for GE B1x5pv2 boards. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/arm/fsl.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml

[PATCHv2 3/5] dt-bindings: vendor-prefixes: add congatec

2021-04-28 Thread Sebastian Reichel
Document binding for congatec. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index

[PATCHv2 2/5] drm/imx: Add 8 pixel alignment fix

2021-04-28 Thread Sebastian Reichel
from the blank time. In order to expose the correct display size to userspace, the stride is increased without increasing the width. Without this patch systems with this display resolution hang indefinitely during boot up. Suggested-by: Boris Brezillon Signed-off-by: Sebastian Reichel

[PATCHv2 1/5] rtc: m41t80: add support for fixed clock

2021-04-28 Thread Sebastian Reichel
s) and also the bootloader enables it in case an something (e.g. an unpatched kernel) disabled this incorrectly. A workaround for this issue is describing the square wave pin as fixed-clock, which is registered early and basically how this pin is used on the i.MX6. Suggested-by: Saravana Kannan Signed-of

[PATCHv2 5/5] ARM: dts: imx6: Add GE B1x5v2

2021-04-28 Thread Sebastian Reichel
This adds device tree files for the General Electric Healthcare (GEHC) B1x5v2 series. All models make use of Congatec's QMX6 module, which is described in its own device tree include, so that it can also be used by other boards. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/Mak

[PATCHv2 0/5] Support for GE B1x5v2 and B1x5Pv2

2021-04-28 Thread Sebastian Reichel
ps://lore.kernel.org/dri-devel/20200910162831.321556-1-sebastian.reic...@collabora.com/ -- Sebastian Sebastian Reichel (5): rtc: m41t80: add support for fixed clock drm/imx: Add 8 pixel alignment fix dt-bindings: vendor-prefixes: add congatec dt-bindings: arm: fsl: add GE B1x5pv2 boards ARM: dts: imx6:

[PATCHv1] drm/omap: get fbdev working for manually updated display

2021-05-01 Thread Sebastian Reichel
more legacy applications working. Delay frequency settings have been taken over from drm_fb_helper_generic_probe(). Reported-by: Carl Philipp Klemm Tested-by: Carl Philipp Klemm Signed-off-by: Sebastian Reichel --- Hi, I still need to fix my Droid 4, so I only compile tested this myself

Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT

2021-03-23 Thread Sebastian Reichel
> --- Reviewed-by: Sebastian Reichel Also maybe add this, so that it is properly backported. OTOH old code did not have IRQF_ONESHOT either. Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core") -- Sebastian > Change in v2: > -Modify the fourth parameter

Re: [PATCH] drm/omap: dsi: fix unreachable code in dsi_vc_send_short()

2021-01-26 Thread Sebastian Reichel
7; tag with the first 12 characters of the SHA-1 ID, and the one line summary. Do not split the tag across multiple lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify parsing scripts. Otherwise: Reviewed-by: Sebastian Reichel -- Sebastian > Signed-off-by:

Re: [PATCH v4] MAINTAINERS: move Milo Kim to credits

2021-02-12 Thread Sebastian Reichel
LP855x backlight driver, > - TI LP8727 charger driver, > - TI LP8788 MFD (ADC, LEDs, charger and regulator) drivers. > > Signed-off-by: Krzysztof Kozlowski > Cc: Mark Brown > Cc: Jonathan Cameron > Cc: Jingoo Han > Cc: Lee Jones > Cc: Pavel Machek > Cc: Thierr

[PATCHv1 3/6] dt-bindings: vendor-prefixes: add congatec

2021-02-22 Thread Sebastian Reichel
Document binding for congatec. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index

[PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Sebastian Reichel
devicetree/bindings/clock/clock-bindings.txt. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/rtc/rtc-m41t80.txt | 1 + drivers/rtc/rtc-m41t80.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/rtc/rtc-m4

[PATCHv1 6/6] ARM: dts: imx6: Add GE B1x5v2

2021-02-22 Thread Sebastian Reichel
This adds device tree files for the General Electric Healthcare (GEHC) B1x5v2 series. All models make use of Congatec's QMX6 module, which is described in its own device tree include, so that it can also be used by other boards. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/Mak

[PATCHv1 0/6] Support for GE B1x5v2

2021-02-22 Thread Sebastian Reichel
full context for the problem. https://lore.kernel.org/dri-devel/20200910162831.321556-1-sebastian.reic...@collabora.com/ -- Sebastian Sebastian Reichel (6): rtc: m41t80: add support for protected clock drm/imx: Add 8 pixel alignment fix dt-bindings: vendor-prefixes: add congatec dt-bindin

[PATCHv1 5/6] dt-bindings: mtd: jedec,spi-nor: add sst25vf032b

2021-02-22 Thread Sebastian Reichel
The binding is already used by the driver. Update documentation accordingly. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation

[PATCHv1 4/6] dt-bindings: arm: fsl: add GE B1x5pv2 boards

2021-02-22 Thread Sebastian Reichel
Document the compatible for GE B1x5pv2 boards. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/arm/fsl.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml

[PATCHv1 2/6] drm/imx: Add 8 pixel alignment fix

2021-02-22 Thread Sebastian Reichel
from the blank time. In order to expose the correct display size to userspace, the stride is increased without increasing the width. Suggested-by: Boris Brezillon Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/imx/imx-drm-core.c | 19 ++- drivers/gpu/drm/imx/imx-ldb.c

Re: [PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Sebastian Reichel
Hi, On Mon, Feb 22, 2021 at 10:26:26PM +0100, Alexandre Belloni wrote: > On 22/02/2021 22:20:47+0100, Alexandre Belloni wrote: > > On 22/02/2021 18:12:42+0100, Sebastian Reichel wrote: > > > Congatec's QMX6 system on module (SoM) uses a m41t62 as RTC. The > > > m

Re: [PATCHv1 5/6] dt-bindings: mtd: jedec,spi-nor: add sst25vf032b

2021-02-22 Thread Sebastian Reichel
Hi, On Mon, Feb 22, 2021 at 06:15:11PM -0600, Rob Herring wrote: > On Mon, Feb 22, 2021 at 11:13 AM Sebastian Reichel > wrote: > > > > The binding is already used by the driver. Update documentation > > accordingly. > > > > Signed-off-by: Sebastian Reichel &

[PATCH] drm/panel: panel-dsi-cm: disable TE for now

2021-02-27 Thread Sebastian Reichel
From: Sebastian Reichel Disable TE for Droid 4 panel, since implementation is currently broken. Also disable it for N950 panel, which is untested. Reported-by: Tony Lindgren Reported-by: Tomi Valkeinen Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core") Sig

Re: [PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-03-08 Thread Sebastian Reichel
Hi, On Sat, Mar 06, 2021 at 11:56:45AM -0800, Rob Herring wrote: > On Tue, Feb 23, 2021 at 02:26:57AM +0100, Sebastian Reichel wrote: > > On Mon, Feb 22, 2021 at 10:26:26PM +0100, Alexandre Belloni wrote: > > > On 22/02/2021 22:20:47+0100, Alexandre Belloni wrote: > > &g

Re: [PATCH] drm/panel: sony-acx565akm: Fix race condition in probe

2020-11-28 Thread Sebastian Reichel
Hi Laurent, On Sun, Nov 29, 2020 at 12:08:47AM +0200, Laurent Pinchart wrote: > On Fri, Nov 27, 2020 at 09:04:29PM +0100, Sebastian Reichel wrote: > > The probe routine acquires the reset GPIO using GPIOD_OUT_LOW. Directly > > afterwards it calls acx565akm_detect(), which sets th

[PATCH] drm/panel: sony-acx565akm: Fix race condition in probe

2020-11-29 Thread Sebastian Reichel
er Ujfalusi Reported-by: Tony Lindgren Reported-by: Aaro Koskinen Reported-by: Ivaylo Dimitrov Cc: Merlijn Wajer Cc: Laurent Pinchart Cc: Tomi Valkeinen Fixes: 1c8fc3f0c5d2 ("drm/panel: Add driver for the Sony ACX565AKM panel") Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/pan

Re: [PATCH v3 27/56] drm/omap: dsi: do bus locking in host driver

2020-11-09 Thread Sebastian Reichel
Hi, On Mon, Nov 09, 2020 at 12:08:33PM +0200, Tomi Valkeinen wrote: > On 09/11/2020 11:52, Laurent Pinchart wrote: > > Hi Tomi, > > > > Thank you for the patch. > > > > On Thu, Nov 05, 2020 at 02:03:04PM +0200, Tomi Valkeinen wrote: > >> From: Sebas

Re: [PATCH v3 30/56] drm/omap: dsi: move panel refresh function to host

2020-11-17 Thread Sebastian Reichel
Hi, On Mon, Nov 16, 2020 at 11:22:53AM +0200, Laurent Pinchart wrote: > On Thu, Nov 12, 2020 at 10:08:21AM +0200, Tomi Valkeinen wrote: > > On 11/11/2020 17:58, Laurent Pinchart wrote: > > > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > > b/drivers/gpu/drm/omapdrm/di

Re: [PATCH 08/10] drm/fb-helper: Restore damage area upon errors

2020-11-17 Thread Sebastian Reichel
Hi, On Mon, Nov 16, 2020 at 09:52:16PM +0100, Daniel Vetter wrote: > On Mon, Nov 16, 2020 at 09:04:35PM +0100, Thomas Zimmermann wrote: > > If the damage handling fails, restore the damage area. The next invocation > > of the damage worker will then perform the update. > > > > Signed-off-by: Thom

Re: [PATCH v4] dt-bindings: display: panel: one file of all simple LVDS panels with dual ports

2020-11-19 Thread Sebastian Reichel
sted-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Herring > Cc: Lucas Stach > Cc: Sebastian Reichel > Signed-off-by: Liu Ying > --- Is this part of a bigger patchset updating the fsl,imx6q-ldb bindi

Re: [PATCH v2 28/34] power: supply: ab8500: Migrate to aggregate driver

2021-10-13 Thread Sebastian Reichel
e with respect to all > the component devices that make up the aggregate device. > > Cc: Sebastian Reichel > Cc: > Cc: Daniel Vetter > Cc: "Rafael J. Wysocki" > Cc: Rob Clark > Cc: Russell King > Cc: Saravana Kannan > Signed-off-by: Stephen Boyd >

Re: [PATCH] drm: panel: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Sebastian Reichel
t; drivers/gpu/drm/panel/panel-dsi-cm.c:271: WARNING: use scnprintf or sprintf. > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > Signed-off-by: Qing Wang > --- The patch subject could be more specific (this updates just one panel driver). Otherwise

Re: [PATCH v4 50/80] drm/omap: squash omapdrm sub-modules into one

2020-12-14 Thread Sebastian Reichel
mapdss-base and omapdss, and just compile everything > into omapdrm.ko. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/Kconfig | 119 ++- > drivers

Re: [PATCH v4 51/80] drm/omap: remove unused display.c

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:09PM +0200, Tomi Valkeinen wrote: > The functions in display.c are not used, so drop the file. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/

Re: [PATCH v4 52/80] drm/omap: drop unused owner field

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:10PM +0200, Tomi Valkeinen wrote: > dssdev->owner is set, but never used. We can drop the field. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/

Re: [PATCH v4 53/80] drm/omap: remove dispc_ops

2020-12-14 Thread Sebastian Reichel
gt; calls to dispc. > > Signed-off-by: Tomi Valkeinen > Acked-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/base.c| 5 -- > drivers/gpu/drm/omapdrm/dss/dispc.c | 101 +++--- > drivers/gp

Re: [PATCH v4 54/80] drm/omap: remove dss_mgr_ops

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:12PM +0200, Tomi Valkeinen wrote: > dss_mgr_ops was needed with the multi-module architecture, but is no > longer needed. We can thus remove it and use direct calls. > > Signed-off-by: Tomi Valkeinen > Acked-by: Laurent Pinchart > --- Revi

Re: [PATCH v4 55/80] drm/panel: panel-dsi-cm: use MIPI_DCS_GET_ERROR_COUNT_ON_DSI

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:13PM +0200, Tomi Valkeinen wrote: > Use the common MIPI_DCS_GET_ERROR_COUNT_ON_DSI define instead of > driver's own. > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/pane

Re: [PATCH v4 56/80] drm/panel: panel-dsi-cm: cleanup tear enable

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:14PM +0200, Tomi Valkeinen wrote: > Simplify the code by moving code from _dsicm_enable_te() into > dsicm_power_on(). > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/p

Re: [PATCH v4 57/80] ARM: dts: omap5: add address-cells & size-cells to dsi

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:15PM +0200, Tomi Valkeinen wrote: > Add address-cells & size-cells to DSI nodes so that board files do not > need to define them. > > Signed-off-by: Tomi Valkeinen > Cc: Tony Lindgren > --- Reviewed-by: Sebastian Reichel -- Sebastian

Re: [PATCH v4 58/80] drm/omap: pll: fix iteration loop check

2020-12-14 Thread Sebastian Reichel
y on such cases. > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/pll.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/dss/pll.c > b/drivers/gpu/drm/omapdrm/dss/pll.c &g

Re: [PATCH v4 59/80] drm/omap: dsi: set trans_mode according to client mode_flags

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:17PM +0200, Tomi Valkeinen wrote: > The DSI host driver currently ignores the video mode flags in > client->mode_flags. Add the code to take the transfer mode from client's > mode_flags. > > Signed-off-by: Tomi Valkeinen > --- Revi

Re: [PATCH v4 60/80] drm/panel: panel-dsi-cm: set column & page at setup

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Nov 24, 2020 at 02:45:18PM +0200, Tomi Valkeinen wrote: > Set the column & page address once during setup, instead of relying the > DSI host driver to set those. > > Signed-off-by: Tomi Valkeinen > --- I'm fine with or without removal of the variables:

Re: [PATCH v5 01/29] drm/panel: panel-dsi-cm: cleanup tear enable

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:27PM +0200, Tomi Valkeinen wrote: > Simplify the code by moving code from _dsicm_enable_te() into > dsicm_power_on(). > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Sam Ravnborg > Reviewed-by: Laurent Pinchart > --- Reviewed-

Re: [PATCH v5 02/29] ARM: dts: omap5: add address-cells & size-cells to dsi

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:28PM +0200, Tomi Valkeinen wrote: > Add address-cells & size-cells to DSI nodes so that board files do not > need to define them. > > Signed-off-by: Tomi Valkeinen > Cc: Tony Lindgren > Acked-by: Tony Lindgren > --- Revie

Re: [PATCH v5 04/29] drm/omap: dsi: set trans_mode according to client mode_flags

2020-12-14 Thread Sebastian Reichel
iewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c > b/drivers/gpu/drm/omapdrm/dss/dsi.c > index c3592c6db977..7fee9cf8

Re: [PATCH v5 03/29] drm/omap: pll: fix iteration loop check

2020-12-14 Thread Sebastian Reichel
y on such cases. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/pll.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/dss/pll.c > b

Re: [PATCH v5 05/29] drm/panel: panel-dsi-cm: set column & page at setup

2020-12-14 Thread Sebastian Reichel
rt > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/panel-dsi-cm.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c > b/drivers/gpu/drm/panel/panel-dsi-cm.c > index 38f79dca1fd0..556f9a

Re: [PATCH v5 06/29] drm/omap: dsi: send nop instead of page & column

2020-12-14 Thread Sebastian Reichel
ng from the DSI spec: > > "To enable PHY synchronization the host processor should periodically > end HS transmission and drive the Data Lanes to the LP state. This > transition should take place at least once per frame." > > Signed-off-by: Tomi Valkeinen > Reviewed

Re: [PATCH v5 07/29] drm/omap: dsi: simplify VC handling

2020-12-14 Thread Sebastian Reichel
rent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 49 --- > 1 file changed, 13 insertions(+), 36 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c > b/drivers/gpu/drm/omapdrm/dss/dsi.

Re: [PATCH v5 08/29] drm/omap: dsi: drop useless channel checks

2020-12-14 Thread Sebastian Reichel
ed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 11 --- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c > b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 5e13478010db..c78ae99

Re: [PATCH v5 09/29] drm/omap: dsi: cleanup dispc channel usage

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:35PM +0200, Tomi Valkeinen wrote: > The "channel" usage in omap dsi driver is confusing. As the first step, > change "channel" to "dispc_channel" when dealing with the dispc channel. > > Signed-off-by: Tomi Valkei

Re: [PATCH v5 10/29] drm/omap: dsi: rename 'channel' to 'vc'

2020-12-14 Thread Sebastian Reichel
some places 1) and 2) have gotten mixed up (i.e. the code > uses msg->channel when it should use vc), which will be fixed in the > following patch. > > Note that mixing 1) and 2) currently is "fine", as at the moment we only > support DSI peripherals with DSI virtual c

Re: [PATCH v5 11/29] drm/omap: dsi: pass vc to various functions

2020-12-14 Thread Sebastian Reichel
ctional changes. > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 54 --- > 1 file changed, 28 insertions(+), 26 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c &

Re: [PATCH v5 12/29] drm/omap: dsi: untangle vc & channel

2020-12-14 Thread Sebastian Reichel
> > return r; > > @@ -2711,11 +2711,11 @@ static int dsi_vc_send_short(struct dsi_data *dsi, > > int vc, > > > > if (dsi->debug_write) > > DSSDBG("dsi_vc_send_short(ch%d, dt %#x, b1 %#x, b2 %#x)\n", > > -

Re: [PATCH v5 13/29] drm/omap: dsi: skip dsi_vc_enable_hs when already in correct mode

2020-12-14 Thread Sebastian Reichel
Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c > b/drivers/gpu/drm/om

Re: [PATCH v5 14/29] drm/omap: dsi: enable HS before sending the frame

2020-12-14 Thread Sebastian Reichel
ifferent VC for video data, the VC is in LP mode. > Fix this by always enabling HS mode before starting a frame update. > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 2 ++ > 1 file changed, 2 insertions

Re: [PATCH v5 15/29] drm/omap: dsi: use separate VCs for cmd and video

2020-12-14 Thread Sebastian Reichel
y: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c > b/drivers/gpu/drm/omapdrm/dss/dsi.c > index

Re: [PATCH v5 16/29] drm/panel: panel-dsi-cm: remove extra 'if'

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:42PM +0200, Tomi Valkeinen wrote: > We have a useless 'if' in the dsicm_bl_update_status(), a left over from > the conversion to DRM model. Drop the if. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Sam Ravnborg > --- Re

Re: [PATCH v5 17/29] drm/panel: panel-dsi-cm: add panel database to driver

2020-12-14 Thread Sebastian Reichel
@@ -531,6 +523,7 @@ static int dsicm_probe(struct mipi_dsi_device *dsi) > struct panel_drv_data *ddata; > struct backlight_device *bldev = NULL; > struct device *dev = &dsi->dev; > + const struct of_device_id *id; > int r; > > dev_dbg(de

Re: [PATCH v5 18/29] drm/panel: panel-dsi-cm: drop unneeded includes

2020-12-14 Thread Sebastian Reichel
t; #include > #include > -#include > -#include > -#include Note, that 'of_device_get_match_data', which I suggested in previous patch is defined in . Otherwise Reviewed-by: Sebastian Reichel -- Sebastian > #include > > #include > -- > Texas Ins

Re: [PATCH v5 19/29] drm/omap: dsi: move structs & defines to dsi.h

2020-12-14 Thread Sebastian Reichel
> Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 384 + > drivers/gpu/drm/omapdrm/dss/dsi.h | 459 ++ > drivers/gpu/drm/omapdrm/dss/omapdss.h | 64 >

Re: [PATCH v5 20/29] drm/omap: dsi: move enable/disable to bridge enable/disable

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:46PM +0200, Tomi Valkeinen wrote: > Clean up the code by inlining dsi_enable_video_outputs and > dsi_disable_video_outputs functions. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reic

Re: [PATCH v5 21/29] drm/omap: dsi: display_enable cleanup

2020-12-14 Thread Sebastian Reichel
ra and > can be dropped, as _dsi_display_enable() has the same WARN_ON(). > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 16 +++- > 1 file changed, 3 inse

Re: [PATCH v5 22/29] drm/omap: dsi: display_disable cleanup

2020-12-14 Thread Sebastian Reichel
ra and > can be dropped, as _dsi_display_disable() has the same WARN_ON(). > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 19 +++ > 1 file ch

Re: [PATCH v5 23/29] drm/omap: dsi: rename dsi_display_* functions

2020-12-14 Thread Sebastian Reichel
DSI interface). > Rename them by dropping the "display". > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 36 +++ > 1 file chang

Re: [PATCH v5 24/29] drm/omap: dsi: cleanup initial vc setup

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:50PM +0200, Tomi Valkeinen wrote: > As we now have a fixed setup for VCs (VC0 for video stream, VC1 for > commands), we can simplify the VC setup. > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel -- Sebastian > drive

Re: [PATCH v5 25/29] drm/omap: dsi: split video mode enable/disable into separate func

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:51PM +0200, Tomi Valkeinen wrote: > Clean up the code by separating video-mode enable/disable code into > functions of their own. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Seb

Re: [PATCH v5 26/29] drm/omap: dsi: fix and cleanup ddr_clk_always_on

2020-12-14 Thread Sebastian Reichel
pretty useless. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 12 +--- > drivers/gpu/drm/omapdrm/dss/dsi.h | 2 -- > 2 files changed, 5 insertions(+), 9 de

Re: [PATCH v5 28/29] drm/omap: dsi: fix DCS_CMD_ENABLE

2020-12-14 Thread Sebastian Reichel
els > too. > > Fix this by skipping the set for video mode. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(

Re: [PATCH v5 29/29] drm/omap: dsi: allow DSI commands to be sent early

2020-12-14 Thread Sebastian Reichel
so prepare() cannot > be used to send DSI commands. > > This patch fixes the issue by making it possible to enable the DSI > interface any time a command is about to be sent. Disabling the > interface is be done via delayed work. > > Signed-off-by: Tomi Valkeinen > --- R

Re: [PATCH v5 27/29] drm/omap: dsi: remove ulps support

2020-12-14 Thread Sebastian Reichel
Hi, On Tue, Dec 08, 2020 at 02:28:53PM +0200, Tomi Valkeinen wrote: > ULPS doesn't work, and I have been unable to get it to work. As ULPS > is a minor power-saving feature which requires substantial amount of > non-trivial code, and we have trouble just getting and > keeping DSI working at all, r

Re: [PATCH v5 27/29] drm/omap: dsi: remove ulps support

2020-12-14 Thread Sebastian Reichel
Hi, On Mon, Dec 14, 2020 at 08:55:36PM +0200, Tomi Valkeinen wrote: > On 14/12/2020 19:39, Sebastian Reichel wrote: > > Hi, > > > > On Tue, Dec 08, 2020 at 02:28:53PM +0200, Tomi Valkeinen wrote: > >> ULPS doesn't work, and I have been unable to get it to

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Sebastian Reichel
./bindings/power/supply/bq25980.yaml | 1 + > [...] Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 39/80] drm/panel: Move OMAP's DSI command mode panel driver

2021-01-09 Thread Sebastian Reichel
Hi, On Fri, Jan 08, 2021 at 01:23:54PM -0800, Dixit, Ashutosh wrote: > On Tue, 24 Nov 2020 04:44:57 -0800, Tomi Valkeinen wrote: > > > > From: Sebastian Reichel > > > > The panel driver is no longer using any OMAP specific APIs, so > > let's mo

[PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive

2021-01-09 Thread Sebastian Reichel
Signed-off-by: Sebastian Reichel --- Laurent introduced and fixed the same issue for the other panels and this simply replicates the same solution for DSI command mode panel. --- drivers/video/fbdev/omap2/omapfb/displays/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbd

Re: [PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive

2021-01-13 Thread Sebastian Reichel
[replace Tomi's TI mail address with something working] Hi, On Fri, Jan 08, 2021 at 08:58:39PM +0100, Sam Ravnborg wrote: > Hi Sebastian, > > On Fri, Jan 08, 2021 at 12:24:41PM +0100, Sebastian Reichel wrote: > > Standard DRM panel driver for DSI command mode panel use

omapfb removal (was: Re: [PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive)

2021-01-13 Thread Sebastian Reichel
[dropped linux-next from Cc] Hi, On Tue, Jan 12, 2021 at 03:10:56PM +0200, Tomi Valkeinen wrote: > >> But why is it it we need omapfb at all when we have omapdrm? > > > > I think there are two reasons omapfb has not been killed yet. One > > reason was missing support for manually updated DSI pan

[PATCHv6 1/4] drm/omap: use DRM_DEBUG_DRIVER instead of CORE

2019-05-23 Thread Sebastian Reichel
This macro is only used by omapdrm, which should print debug messages using the DRIVER category instead of the default CORE category. Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_drv.h | 4 ++-- 1

[PATCHv6 3/4] drm/omap: add framedone interrupt support

2019-05-23 Thread Sebastian Reichel
This prepares framedone interrupt handling for manual display update support. Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_crtc.c | 50 + drivers/gpu/drm/omapdrm

[PATCHv6 4/4] drm/omap: add support for manually updated displays

2019-05-23 Thread Sebastian Reichel
trigger a display refresh. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_crtc.c | 114 ++-- drivers/gpu/drm/omapdrm/omap_crtc.h | 1 + drivers/gpu/drm/omapdrm/omap_fb.c | 19 + 3 files changed, 129 insertions(+), 5 deletions(-) diff --git a/d

[PATCHv6 0/4] omapdrm: DSI command mode panel support

2019-05-23 Thread Sebastian Reichel
to current master * Rework the omap3 workaround patch to only affect omap3 * Add orientation DRM property support -- Sebastian Sebastian Reichel (4): drm/omap: use DRM_DEBUG_DRIVER instead of CORE drm/omap: don't check dispc timings for DSI drm/omap: add framedone interrupt support

[PATCHv6 2/4] drm/omap: don't check dispc timings for DSI

2019-05-23 Thread Sebastian Reichel
e DISPC VM for DSI here. Fixes: 7c27fa57ef31 ("drm/omap: Call dispc timings check operation directly") Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_crtc.c | 18 ++ 1 file ch

Re: [PATCH v2 01/49] drm/atomic: Constify mode argument to mode_valid_path()

2019-02-09 Thread Sebastian Reichel
-by: Ville Syrjälä > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/drm_atomic_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c > b/drivers/gpu/drm/drm_atomic_helper.c > index 54e2ae614d

Re: [PATCH v2 46/49] drm/omap: Add support for drm_panel

2019-02-09 Thread Sebastian Reichel
nel, we only need to add panel support in the connector .get_modes() > handler, take connector bus flags (set by the panel) into account, and > enable/disable the panel in the encoder enable/disable operations > handlers. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sebas

Re: [PATCH v2 29/49] drm/omap: Pass drm_display_mode to .check_timings() and .set_timings()

2019-02-09 Thread Sebastian Reichel
cases. If needed > they will be converted to operate on drm_display_mode natively. > > Signed-off-by: Laurent Pinchart > Tested-by: Sebastian Reichel > --- Reviewed-by: Sebastian Reichel -- Sebastian > .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 8 +++--- >

Re: [PATCH v2 48/49] drm/omap: Remove TFP410 and DVI connector drivers

2019-02-09 Thread Sebastian Reichel
Hi, On Fri, Jan 11, 2019 at 05:51:19AM +0200, Laurent Pinchart wrote: > Those components are supported by the drm_bridge infrastructure, remove > the omapdrm-specific driver. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sebastian Reichel > --- Tested-by: Sebastian Reic

Re: [PATCH v2 45/49] drm/omap: Add support for drm_bridge

2019-02-09 Thread Sebastian Reichel
rent bridges. These systems can't be supported > using drm_bridge for now (their support through the omap_dss_device > infrastructure is not affected), this will be fixed in subsequent > changes. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sebastian Reichel > ---

Re: [PATCH v2 00/49] omapdrm: drm_bridge and drm_panel support

2019-02-09 Thread Sebastian Reichel
rc5, (which contains some DSI fixes). This worked without any manual merge conflicts :). I also rebased rebased the DSI command mode patchset on top of it. Everything seems to work fine on Droid 4, so the series is Tested-by: Sebastian Reichel I pushed out the rebased branch with DSI

Re: [PATCH v2 47/49] drm/omap: Whitelist DT nodes to fixup with omapdss, prefix

2019-02-09 Thread Sebastian Reichel
rresponding drm_bridge drivers become available and get > successfully tested with omapdrm. > > The omapdss components load check code is updated accordingly to ignore > devices managed by external bridge drivers. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sebastian R

Re: [PATCH v2 03/49] drm/omap: dsi: Fix OF platform depopulate

2019-02-09 Thread Sebastian Reichel
dsi: Move initialization code from bind > to probe") > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/g

Re: [PATCH 0/6] omapdrm: drm_bridge and drm_panel support

2019-02-09 Thread Sebastian Reichel
Hi, On Fri, Jan 11, 2019 at 03:34:19AM +0200, Laurent Pinchart wrote: > Hi Sebastian, > > On Thursday, 20 December 2018 14:17:27 EET Sebastian Reichel wrote: > > Hi, > > > > On Mon, Dec 10, 2018 at 03:06:17AM +0200, Laurent Pinchart wrote: > > > This patch se

Re: [PATCH v2 49/49] drm/omap: Remove panel-dpi driver

2019-02-09 Thread Sebastian Reichel
Hi, On Fri, Jan 11, 2019 at 05:51:20AM +0200, Laurent Pinchart wrote: > Panels are now supported through the drm_panel infrastructure, remove > the omapdrm-specific driver. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sebastian Reichel > --- Tested-by: Sebastian Reic

Re: [PATCH v2 04/49] drm/omap: dsi: Hack-fix DSI bus flags

2019-02-09 Thread Sebastian Reichel
the omap_dss_device > structure") > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c > b/driver

Re: [PATCH v2 45/49] drm/omap: Add support for drm_bridge

2019-02-09 Thread Sebastian Reichel
rent bridges. These systems can't be supported > using drm_bridge for now (their support through the omap_dss_device > infrastructure is not affected), this will be fixed in subsequent > changes. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sebastian Reichel > --- T

Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2019-02-11 Thread Sebastian Reichel
Hi, ping & actually add the cc :) -- Sebastian On Tue, Dec 11, 2018 at 10:06:07AM +0200, Laurent Pinchart wrote: >> The problem is, that DISPC timings for DSI are not directly >> calculated from mode. Instead DSI code does some modifications >> before applying the DISPC settings. > > I wonder w

Re: [PATCH 2/7] drm: omapdrm: Cleanup drm_display_mode print str

2018-12-19 Thread Sebastian Reichel
-- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/omap_connector.c | 9 ++--- > drivers/gpu/drm/omapdrm/omap_crtc.c | 8 ++-- > 2 files changed, 4 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_connector.

Re: [PATCH 0/6] omapdrm: drm_bridge and drm_panel support

2018-12-21 Thread Sebastian Reichel
Hi, On Mon, Dec 10, 2018 at 03:06:17AM +0200, Laurent Pinchart wrote: > This patch series hooks up support for drm_bridge and drm_panel in the omapdrm > driver. > > [...] The series is Reviewed-by: Sebastian Reichel At the same time it is tested to break display on Droid 4. I do

Re: [PATCHv6 3/4] drm/omap: add framedone interrupt support

2019-05-29 Thread Sebastian Reichel
Hi Tomi, On Tue, May 28, 2019 at 01:19:01PM +0300, Tomi Valkeinen wrote: > Hi Sebastian, > > On 23/05/2019 23:07, Sebastian Reichel wrote: > > > @@ -302,6 +328,30 @@ void omap_crtc_vblank_irq(struct drm_crtc *crtc) > > DBG("%s: apply done", o

Re: [GIT PULL] omapdrm changes for 5.3

2019-06-11 Thread Sebastian Reichel
t; > > > > omapdrm changes for 5.3 > > > > - Add support for DSI command mode displays > > Thanks, pulled. Finally :) > > --------

Re: [PATCH 00/34] treewide: simplify getting the adapter of an I2C client

2019-06-27 Thread Sebastian Reichel
Hi, On Sat, Jun 08, 2019 at 12:55:39PM +0200, Wolfram Sang wrote: > While preparing a refactoring series, I noticed that some drivers use a > complicated way of determining the adapter of a client. The easy way is > to use the intended pointer: client->adapter > > These drivers do: > to_i2c

Re: [Patch v2 03/10] drm/omapdrm: using dev_get_drvdata directly

2019-07-04 Thread Sebastian Reichel
a() directly. > > Signed-off-by: Fuqian Huang > --- Most of these instances no longer exist after my WIP patchset converting omapdrm's DSI code to drm_panel. But that's no reason to keep cleanups from being applied in the meantime: Reviewed-by: Sebastian Reichel -- Sebastian

  1   2   3   4   5   6   7   >