On Thursday, 14 February 2013, Sylwester Nawrocki <
sylvester.nawro...@gmail.com> wrote:
> On 02/12/2013 06:30 PM, Sachin Kamat wrote:
>>
>> Hi Sylwester,
>>
>> On Wednesday, 6 February 2013, Sachin Kamat
wrote:
>>>
>>> This patch add
Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_mixer.c:821:5: warning:
symbol 'mixer_check_timing' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_mixer.c |2 +-
1 files changed, 1 insertions(+), 1 deletion
This patch series is only compile tested and based on linux-next
tree of 20130301.
Sachin Kamat (4):
drm/tilcdc: Fix an incorrect condition
drm/tilcdc: Remove unnecessary braces
drm/tilcdc: Remove space before tab
drm/tilcdc: Fix checkpatch error in tilcdc_panel.c
drivers/gpu/drm/tilcdc
Instead of checking if num_encoders is zero, it is being assigned 0.
Convert the assignment to a check.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
b/drivers
Silences the following checkpatch warning:
WARNING: braces {} are not necessary for any arm of this statement
if (priv->rev == 1) {
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/driv
Silences the following checkpatch warning:
WARNING: please, no space before tabs
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
b/drivers/gpu/drm/tilcdc
Fixes the following checkpatch error:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
b/dr
Hi Rob,
On 2 March 2013 20:40, Rob Clark wrote:
> On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat wrote:
>> Instead of checking if num_encoders is zero, it is being assigned 0.
>> Convert the assignment to a check.
>>
>> Signed-off-by: Sachin Kamat
>
> Signed
On 19 March 2013 15:29, Vikas Sajjan wrote:
> While migrating to common clock framework (CCF), found that the FIMD clocks
> were pulled down by the CCF.
> If CCF finds any clock(s) which has NOT been claimed by any of the
> drivers, then such clock(s) are PULLed low by CCF.
>
> By calling clk_prep
drm_add_edid_modes() returns 0 upon failure to find any modes.
Hence check for 0 and not less than 0.
Signed-off-by: Sachin Kamat
Cc: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_drm_connector.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos
Use IS_ERR instead of IS_ERR_OR_NULL on clk_get results.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index
Use IS_ERR instead of IS_ERR_OR_NULL on clk_get results.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_mixer.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/drm/exynos/exynos_mixer.c
index
Use IS_ERR instead of IS_ERR_OR_NULL on clk_get results.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c
b/drivers/gpu/drm/exynos
On 11 March 2013 15:38, Sachin Kamat wrote:
> Hi Rob,
>
> On 2 March 2013 20:40, Rob Clark wrote:
>> On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat wrote:
>>> Instead of checking if num_encoders is zero, it is being assigned 0.
>>> Convert the assignment to a che
On 25 March 2013 19:06, Rob Clark wrote:
> sorry, was offline for a while (moving), and missed the last email..
No problem :)
>
> I would guess that Tomi would send pull-req for tilcdc and omapdrm.
> Well I suppose I could do it if Tomi can't, although my
> pandas/beagles/beaglebones are not unpa
drm_add_edid_modes() returns 0 upon failure to find any modes.
Hence check for 0 and not less than 0.
Signed-off-by: Sachin Kamat
Cc: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_drm_connector.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos
On 27 March 2013 16:06, Inki Dae wrote:
> 2013/3/21 Sachin Kamat :
>> drm_add_edid_modes() returns 0 upon failure to find any modes.
>> Hence check for 0 and not less than 0.
>>
>> Signed-off-by: Sachin Kamat
>> Cc: Rahul Sharma
>> ---
>> drivers
/bindings/gpu/samsung-g2d.txt
Signed-off-by: Sachin Kamat
Cc: Inki Dae
Cc: Sylwester Nawrocki
Cc: Ajay Kumar
---
The right documentation for G2D bindings has already been merged for 3.10-rc
and hence we need this patch for 3.10-rc too, to avoid confusions due to
multiple documents
Hi Sylwester,
On 16 April 2013 23:01, Sylwester Nawrocki wrote:
> @@ -1835,16 +1859,19 @@ static int fimc_probe(struct platform_device *pdev)
> ret = exynos_drm_ippdrv_register(ippdrv);
> if (ret < 0) {
> dev_err(dev, "failed to register drm fimc device.\n");
> -
Hi Rob,
With the merge window for 3.10 about to open shortly, I was wondering
if the tilcdc patches are lined up somewhere as I could not find them
in linux-next yet.
Thanks and regards,
Sachin.
On 27 March 2013 11:53, Tomi Valkeinen wrote:
> Hi,
>
> On 2013-03-25 15:36, Rob Clark wrote:
>> sor
On 24 April 2013 09:47, Rob Clark wrote:
> On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat
> wrote:
>> Hi Rob,
>>
>> With the merge window for 3.10 about to open shortly, I was wondering
>> if the tilcdc patches are lined up somewhere as I could not find them
>
On 24 April 2013 10:08, Dave Airlie wrote:
> On Wed, Apr 24, 2013 at 2:21 PM, Sachin Kamat wrote:
>> On 24 April 2013 09:47, Rob Clark wrote:
>>> On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat
>>> wrote:
>>>> Hi Rob,
>>>>
>>>&
FIMD also requires video mode helper APIs.
Without this patch we get the following build error:
drivers/gpu/drm/exynos/exynos_drm_fimd.c:895: undefined reference to
`of_get_fb_videomode'
make: *** [vmlinux] Error 1
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/Kconfig |1 +
1
On 26 April 2013 10:11, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
>> Sent: Thursday, April 25, 2013 8:36 PM
>> To: dri-devel@lists.freedesktop.org
>> Cc: inki@samsung.com; jy0922.s...@
Hi Inki,
On 26 April 2013 10:11, Inki Dae wrote:
>
> The above line isn't needed anymore. I just removed and merged it. And I
> can't find this patch on dri-devel mailing list. Maybe you didn't still
> subscribe dri-devel mailing list.
I could find this patch on the dri-devel mailing list. Here
Silences the following checkpatch warning:
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos
exynos_drm_framebuffer_init() does not return NULL. Use IS_ERR instead.
Signed-off-by: Sachin Kamat
---
This series is based on exynos-drm-next branch of Inki Dae's tree:
git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c |
None of these functions actually return a NULL pointer. Hence use
IS_ERR() instead.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c
b/drivers/gpu
Hi Wei Yongjun,
On 7 May 2013 18:54, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> ipp_create_cmd_work() return ERR_PTR() on error and never return
> NULL, so use IS_ERR() instead
'mixer_match_types' is always compiled in. Hence of_match_ptr is not
necessary.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_mixer.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/
'break' after goto statement is redundant. Silences the following
message:
drivers/gpu/drm/exynos/exynos_drm_ipp.c:1067 exynos_drm_ipp_check_valid()
info: ignoring unreachable code.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c |1 -
1 file changed,
PTR_RET is now deprecated. Use PTR_ERR_OR_ZERO instead.
Signed-off-by: Sachin Kamat
---
Compile tested and based on the following tree:
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git (PTR_RET)
Dependent on [1]
[1] http://lkml.indiana.edu/hypermail/linux/kernel/1306.2/00010.html
Since Exynos DRM drivers do not support module build,
remove module.h header file inclusion from files that do
not have any users.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_ddc.c |1 -
drivers/gpu/drm/exynos/exynos_drm_fimc.c|1 -
drivers/gpu/drm/exynos
On 26 July 2013 07:00, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
>> Sent: Wednesday, July 24, 2013 1:43 PM
>> To: dri-devel@lists.freedesktop.org
>> Cc: inki@samsung.com; jy0922.s...@samsung.com
Remove module.h header file inclusion from files since they do
not use/refer to any code from that file.
Signed-off-by: Sachin Kamat
---
Modified the commit message.
---
drivers/gpu/drm/exynos/exynos_ddc.c |1 -
drivers/gpu/drm/exynos/exynos_drm_fimc.c|1 -
drivers/gpu/drm
On 26 July 2013 12:51, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
>> Sent: Friday, July 26, 2013 11:51 AM
>> To: Inki Dae
>> Cc: dri-devel@lists.freedesktop.org; jy0922.s...@samsung.com;
>> pat
Fixes the following sparse warning:
drivers/gpu/drm/drm_proc.c:92:5:
warning: symbol 'drm_proc_create_files' was not declared. Should it be static?
drivers/gpu/drm/drm_proc.c:175:5:
warning: symbol 'drm_proc_remove_files' was not declared. Should it be static?
Signed-
Fixes the following sparse warning:
drivers/gpu/drm/drm_irq.c:1239:6:
warning: symbol 'drm_handle_vblank_events' was not declared. Should it be
static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/drm_irq.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
Fixes the following sparse warning:
drivers/gpu/drm/drm_fb_helper.c:239:6: warning:
symbol 'drm_fb_helper_force_kernel_mode' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/drm_fb_helper.c |2 +-
1 files changed, 1 insertions(+), 1 deletion
This series adds devm_* functionality in some drivers and cleans up
some code that remained when the same was added to other drivers earlier.
This series is compile tested against the latest (6 Aug 2012) linux-next code.
Sachin Kamat (5):
drm/exynos: Remove redundant check in exynos_hdmi.c
devm_request_and_ioremap function checks the validity of the
pointer returned by platform_get_resource. Hence an additional check
in the probe function is not necessary.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c |5 -
1 files changed, 0 insertions(+), 5
devm_request_and_ioremap function checks the validity of the
pointer returned by platform_get_resource. Hence an additional check
in the probe function is not necessary.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |5 -
1 files changed, 0 insertions(+), 5
devm_kzalloc is a device managed function and makes freeing and error
handling simpler.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_vidi.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
b/drivers/gpu
devm_kzalloc is a device managed function and makes freeing and error
handling simpler.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm
devm_* functions are device managed functions and make error handling
and cleanup cleaner and simpler.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 50 ++
1 files changed, 10 insertions(+), 40 deletions(-)
diff --git a/drivers/gpu/drm
OWERMATE && INPUT_YEALINK
&& INPUT_CM109 && RC_ATI_REMOTE && IR_IMON && IR_MCEUSB && IR_REDRAT3 &&
IR_STREAMZAP && IR_IGUANA && DRM_USB) selects USB which has unmet direct
dependencies (USB_SUPPORT && USB_ARCH_HAS_HCD)
Signed-off
Select Exynos DRM based G2D only if non-DRM based Exynos G2D driver
is not selected.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/Kconfig |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index
On 10 August 2012 19:35, Sascha Hauer wrote:
> On Fri, Aug 10, 2012 at 11:00:25AM +0530, Sachin Kamat wrote:
>> DRM_USB selects USB. However, USB depends on USB_SUPPORT and
>> USB_ARCH_HAS_HCD.
>> Thus, selecting USB_SUPPORT in Kconfig avoids the following warning
>>
Hi,
Any comments on this series?
Regards
Sachin
On 1 August 2012 17:15, Sachin Kamat wrote:
> Fixes the following sparse warning:
> drivers/gpu/drm/drm_proc.c:92:5:
> warning: symbol 'drm_proc_create_files' was not declared. Should it be static?
> drivers/gpu/drm/drm_p
Hi Dave,
What is your opinion about this patch?
On 15 August 2012 01:27, Sascha Hauer wrote:
> On Tue, Aug 14, 2012 at 05:12:22PM +0530, Sachin Kamat wrote:
>>
>> In general what you suggested seems to be the right thing to do.
>> However in this particular case, ma
Hi,
Any comments on this series?
On 1 August 2012 17:15, Sachin Kamat wrote:
> Fixes the following sparse warning:
> drivers/gpu/drm/drm_proc.c:92:5:
> warning: symbol 'drm_proc_create_files' was not declared. Should it be static?
> drivers/gpu/drm/drm_proc.c:17
Fixes the following warning:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning:
symbol 'g2d_pm_ops' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
di
On 29 August 2012 12:32, Joonyoung Shim wrote:
> On 08/28/2012 05:41 PM, Sachin Kamat wrote:
>>
>> Fixes the following warning:
>> drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning:
>> symbol 'g2d_pm_ops' was not declared. Should it be stat
Fixes the following checkpatch warnings:
WARNING: sizeof *res should be sizeof(*res)
WARNING: sizeof res->regul_bulk[0] should be sizeof(res->regul_bulk[0])
WARNING: sizeof *res should be sizeof(*res)
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c |6 +++---
1
Fixes the following checkpatch warnings:
WARNING: sizeof filter_y_horiz_tap8 should be sizeof(filter_y_horiz_tap8)
WARNING: sizeof filter_y_vert_tap4 should be sizeof(filter_y_vert_tap4)
WARNING: sizeof filter_cr_horiz_tap4 should be sizeof(filter_cr_horiz_tap4)
Signed-off-by: Sachin Kamat
drm/drm_edid.h was included twice.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/i915/intel_modes.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_modes.c
b/drivers/gpu/drm/i915/intel_modes.c
index b00f1c8..49249bb 100644
--- a/drivers/gpu
subdev/bar.h was included twice.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/nouveau/core/engine/disp/nv50.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c
b/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c
index
Add CONFIG_OF to compile conditionally. of_match_ptr eliminates having
an #ifdef returning NULL for the case when OF is disabled.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_ddc.c |4 +++-
drivers/gpu/drm/exynos/exynos_hdmi.c|4 +++-
drivers/gpu/drm/exynos
This is an unlikely case. However to silence the following smatch error
add a NULL check:
drivers/gpu/drm/exynos/exynos_hdmi.c:2486 hdmi_probe()
error: potential NULL dereference 'match'.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c |2 ++
1 files
Compile tested against linux-next tree (20121224).
Sachin Kamat (10):
drm/exynos: Use devm_kzalloc in exynos_drm_ipp.c
drm/exynos: Remove explicit freeing using devm_* APIs in
exynos_drm_fimc.c
drm/exynos: Remove redundant NULL check
drm/exynos: Use devm_clk_get in exynos_drm_fimc.c
devm_kzalloc makes the code simpler by eliminating the need for
explicit freeing.
Cc: Eunchul Kim
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c
b
devm_* APIs are device managed and get freed automatically when the
device detaches. Thus explicit freeing is not needed. This saves some
code.
Cc: Eunchul Kim
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 30 +-
1 files changed, 9
devm_request_and_ioremap API checks for NULL. Hence explicit
NULL check is not necessary. Saves some code.
Cc: Eunchul Kim
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm
This eliminates the need for explicit clk_put and makes the
cleanup and exit path code simpler.
Cc: Eunchul Kim
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 46 ++---
1 files changed, 10 insertions(+), 36 deletions(-)
diff --git a
devm_* APIs are device managed and get freed automatically when the
device detaches. Thus explicit freeing is not needed. This saves some
code.
Cc: Eunchul Kim
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c | 18 --
1 files changed, 4 insertions
devm_request_and_ioremap API checks for NULL. Hence explicit
NULL check is not necessary. Saves some code.
Cc: Eunchul Kim
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm
This eliminates the need for explicit clk_put and makes the
cleanup and exit path code simpler.
Cc: Eunchul Kim
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos
devm_* APIs are device managed and get freed automatically when the
device detaches. Thus explicit freeing is not needed. This saves some
code.
Cc: Eunchul Kim
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 15 +++
1 files changed, 3 insertions(+), 12
devm_request_and_ioremap API checks for NULL. Hence explicit
NULL check is not necessary. Saves some code.
Cc: Eunchul Kim
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm
This eliminates the need for explicit clk_put and makes the
cleanup and exit path code simpler.
Cc: Eunchul Kim
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 13 -
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/exynos
On Wednesday, 26 December 2012, Inki Dae wrote:
>
>
> 2012/12/24 Sachin Kamat
>>
>> This eliminates the need for explicit clk_put and makes the
>> cleanup and exit path code simpler.
>>
>> Cc: Eunchul Kim
>> Signed-off-by: Sachin Kamat
>> ---
On Wednesday, 26 December 2012, Inki Dae wrote:
>
>
> 2012/12/24 Sachin Kamat
>>
>> This eliminates the need for explicit clk_put and makes the
>> cleanup and exit path code simpler.
>>
>> Cc: Eunchul Kim
>> Signed-off-by: Sachin Kamat
>> ---
On 27 December 2012 15:43, Inki Dae wrote:
>
>
> 2012/12/26 Sachin Kamat
>>
>>
>>
>> On Wednesday, 26 December 2012, Inki Dae wrote:
>> >
>> >
>> > 2012/12/24 Sachin Kamat
>> >>
>> >> This eliminates
This eliminates the need for explicit clk_put and makes the
cleanup and exit path code simpler.
Cc: Eunchul Kim
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 45 ++
1 files changed, 9 insertions(+), 36 deletions(-)
diff --git a
rv.c
>
> Signed-off-by: Daniel Kurtz
Acked-by: Sachin Kamat
--
With warm regards,
Sachin
Hi Ajay,
On 19 March 2014 19:52, Ajay Kumar wrote:
> Add post processor ops for MDNIE and their support functions.
> Expose an interface for the FIMD to register MDNIE PP.
>
> Signed-off-by: Ajay Kumar
> Signed-off-by: Shirish S
> Signed-off-by: Rahul Sharma
> ---
> drivers/gpu/drm/exynos/Mak
On 19 March 2014 19:52, Ajay Kumar wrote:
> Add post processor ops for IELCD and their support functions.
> Expose an interface for the FIMD to register IELCD PP.
[snip]
> +
> +#define exynos_ielcd_readl(addr) readl(ielcd->exynos_ielcd_base + addr)
> +#define exynos_ielcd_writel(addr, val) \
drm_mode_create() returns NULL if it fails to create
a new display mode. Check the value returned to avoid NULL
pointer deferencing later.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_connector.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a
Fixes the following sparse warnings:
drivers/gpu/drm/udl/udl_transfer.c:129:50:
drivers/gpu/drm/udl/udl_transfer.c:130:50:
drivers/gpu/drm/udl/udl_transfer.c:131:45:
drivers/gpu/drm/udl/udl_transfer.c:132:61:
warning: Using plain integer as NULL pointer
Signed-off-by: Sachin Kamat
---
drivers
Fixes the following sparse warnings:
drivers/gpu/drm/udl/udl_fb.c:360:6: warning:
symbol 'udl_crtc_fb_gamma_set' was not declared. Should it be static?
drivers/gpu/drm/udl/udl_fb.c:365:6: warning:
symbol 'udl_crtc_fb_gamma_get' was not declared. Should it be static?
Signed-
Fixes the following sparse warning:
drivers/gpu/drm/udl/udl_encoder.c:19:6: warning:
symbol 'udl_enc_destroy' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/udl/udl_encoder.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
di
Fixes the following sparse warning:
drivers/gpu/drm/udl/udl_modeset.c:394:5: warning:
symbol 'udl_crtc_init' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/udl/udl_modeset.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
/bindings/gpu/samsung-g2d.txt
Signed-off-by: Sachin Kamat
Cc: Inki Dae
Cc: Sylwester Nawrocki
Cc: Ajay Kumar
---
The right documentation for G2D bindings has already been merged for 3.10-rc
and hence we need this patch for 3.10-rc too, to avoid confusions due to
multiple documents
Hi Sylwester,
On 16 April 2013 23:01, Sylwester Nawrocki wrote:
> @@ -1835,16 +1859,19 @@ static int fimc_probe(struct platform_device *pdev)
> ret = exynos_drm_ippdrv_register(ippdrv);
> if (ret < 0) {
> dev_err(dev, "failed to register drm fimc device.\n");
> -
Hi Rob,
With the merge window for 3.10 about to open shortly, I was wondering
if the tilcdc patches are lined up somewhere as I could not find them
in linux-next yet.
Thanks and regards,
Sachin.
On 27 March 2013 11:53, Tomi Valkeinen wrote:
> Hi,
>
> On 2013-03-25 15:36, Rob Clark wrote:
>> sor
On 24 April 2013 09:47, Rob Clark wrote:
> On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat
> wrote:
>> Hi Rob,
>>
>> With the merge window for 3.10 about to open shortly, I was wondering
>> if the tilcdc patches are lined up somewhere as I could not find them
>
On 24 April 2013 10:08, Dave Airlie wrote:
> On Wed, Apr 24, 2013 at 2:21 PM, Sachin Kamat
> wrote:
>> On 24 April 2013 09:47, Rob Clark wrote:
>>> On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat
>>> wrote:
>>>> Hi Rob,
>>>>
>>&g
FIMD also requires video mode helper APIs.
Without this patch we get the following build error:
drivers/gpu/drm/exynos/exynos_drm_fimd.c:895: undefined reference to
`of_get_fb_videomode'
make: *** [vmlinux] Error 1
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/Kconfig |1 +
1
On 26 April 2013 10:11, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: Thursday, April 25, 2013 8:36 PM
>> To: dri-devel at lists.freedesktop.org
>> Cc: inki.dae at samsung.com; jy0922.
Hi Inki,
On 26 April 2013 10:11, Inki Dae wrote:
>
> The above line isn't needed anymore. I just removed and merged it. And I
> can't find this patch on dri-devel mailing list. Maybe you didn't still
> subscribe dri-devel mailing list.
I could find this patch on the dri-devel mailing list. Here
Silences the following checkpatch warning:
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos
exynos_drm_framebuffer_init() does not return NULL. Use IS_ERR instead.
Signed-off-by: Sachin Kamat
---
This series is based on exynos-drm-next branch of Inki Dae's tree:
git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c |
None of these functions actually return a NULL pointer. Hence use
IS_ERR() instead.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c
b/drivers/gpu
Hi Vikas,
On 2 August 2013 09:23, Vikas Sajjan wrote:
> Hi Tomasz,
>
>
> On 2 August 2013 04:50, Tomasz Figa wrote:
>>
>> Hi Vikas,
>>
>> On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote:
>> > While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
>> > connected with re
Hi Vikas,
On 1 August 2013 16:49, Vikas Sajjan wrote:
> While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
> connected with resolution 2560x1600, following error occured even with
> IOMMU enabled:
> [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to allocate buffer.
Hi Vikas,
On 6 August 2013 10:53, Vikas Sajjan wrote:
> While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
> connected with resolution 2560x1600, following error occured even with
> IOMMU enabled:
> [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to allocate buffer.
ion fails
> and if IOMMU is supported.
>
> Signed-off-by: Vikas Sajjan
> Signed-off-by: Arun Kumar
> Reviewed-by: Rob Clark
> ---
> changes since v3:
> - addressed nits pointed out by Sylwester Nawrocki samsung.com>
> and Sachin Kamat .
>
> c
Hi Chanho,
On 9 August 2013 13:10, Chanho Park wrote:
> This patch describes each nodes of rotator and specifies a example how to bind
> it.
>
> Signed-off-by: Chanho Park
> Cc: Thomas Abraham
> Cc: Kukjin Kim
> Cc: Inki Dae
> Signed-off-by: Kyungmin Park
> ---
> .../devicetree/bindings/gpu
Hi Chanho,
On 9 August 2013 13:10, Chanho Park wrote:
> The exynos4 platform is only dt-based since 3.10, we should convert driver
> data
> and ids to dt-based parsing methods. The rotator driver has a limit table to
> get
> size limit of input picture. Each SoCs has slightly different limit va
Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_drm_connector.c:199:20:
warning: symbol 'exynos_drm_best_encoder' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_connector.c |3 ++-
1 files changed, 2
201 - 300 of 395 matches
Mail list logo
