Hi Chanho, On 9 August 2013 13:10, Chanho Park <chanho61.park at samsung.com> wrote: > This patch describes each nodes of rotator and specifies a example how to bind > it. > > Signed-off-by: Chanho Park <chanho61.park at samsung.com> > Cc: Thomas Abraham <thomas.abraham at linaro.org> > Cc: Kukjin Kim <kgene.kim at samsung.com> > Cc: Inki Dae <inki.dae at samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com> > --- > .../devicetree/bindings/gpu/samsung-rotator.txt | 26 > ++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpu/samsung-rotator.txt > > diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > new file mode 100644 > index 0000000..31ee7b5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > @@ -0,0 +1,26 @@ > +* Samsung Image Rotator > + > +Required properties: > + - compatible : value should be following:
This should be "should be one of the following:" > + (a) "samsung,exynos4210-rotator" for Rotator IP in Exynos4210 > + (b) "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412 > + (c) "samsung,exynos5250-rotator" for Rotator IP in Exynos5250 > + > + - reg : Physical base address of the IP registers and length of memory > + mapped region. > + > + - interrupts : Interrupt number of Rotator > + > + - clocks : Clock number described in > Documentations/devicetree/binding/clock. The path has several typos. Instead you can simply mention clocks : from common clock binding: handle to rotator clock. -- With warm regards, Sachin