_ptr.
- Fix GCC warnings.
- Update documentation.
- Update our assert mechanism.
- Remove unnecessary wrappers.
Changes since V1:
- Use a better name for variables.
- Update documentation.
- Avoid preemption.
* See update details per commit message
Best Regards
Rodrigo Siqueira
Rodrigo Siqueira
: Rodrigo Siqueira
---
.../amd/display/amdgpu_dm/amdgpu_dm_trace.h | 13 ---
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c| 36 ---
drivers/gpu/drm/amd/display/dc/dc_trace.h | 4 +--
3 files changed, 42 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/display
ce V1:
- Remove fp_enable variables
- Rename dc_is_fp_enabled to dc_assert_fp_enabled
- Replace wrong variable type
Cc: Harry Wentland
Cc: Anson Jacob
Cc: Christian König
Cc: Hersen Wu
Cc: Aric Cyr
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
d
Cc: Anson Jacob
Cc: Christian König
Cc: Hersen Wu
Cc: Aric Cyr
Reported-by: kernel test robot
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/Makefile | 1 +
.../drm/amd/display/dc/dcn20/dcn20_resource.c | 39 +
.../drm/amd/display/dc/dcn20/dcn20_resource.h
ation only in the context that DCN
is enabled.
Cc: Harry Wentland
Cc: Anson Jacob
Cc: Christian König
Cc: Hersen Wu
Cc: Aric Cyr
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/Makefile| 4 ++
.../amd/display/amdgpu_dm/amdgpu_dm_trace.h | 21 ++
.../gpu/dr
On 07/20, Christian König wrote:
>
>
> Am 20.07.21 um 02:49 schrieb Rodrigo Siqueira:
> > We don't have any mechanism for tracing FPU operations inside the
> > display core, making the debug work a little bit tricky. This commit
> > introduces a trace mechanism i
On 07/23, Jose Maria Casanova Crespo wrote:
> s/Exporting/Importing
>
> Fixes: 805dc614d58a8 ("drm/prime: Update docs")
Fixes flag here looks a little bit overkill. Anyway, this change lgtm
Reported-by: Rodrigo Siqueira
> Cc: Daniel Vetter
> Signed-off-by: J
gt;
> - gem_obj = drm_gem_fb_get_obj(job->fb, 0);
> - dma_buf_map_set_vaddr(&map, job->priv);
> - drm_gem_shmem_vunmap(gem_obj, &map);
> + drm_gem_fb_vunmap(job->fb, vkmsjob->map);
>
> - vkmsdev = drm_device_to_vkms_device(gem_obj->dev);
> + vkmsdev = drm_device_to_vkms_device(job->fb->dev);
> vkms_set_composer(&vkmsdev->output, false);
> }
>
> --
> 2.32.0
>
Reviewed-by: Rodrigo Siqueira
--
Rodrigo Siqueira
https://siqueira.tech
* # echo 0xf > /sys/module/drm/parameters/debug
> *
> + * # For tracefs logging:
> + * # echo 0xf > /sys/module/drm/parameters/trace
> + *
> */
> enum drm_debug_category {
> /**
> @@ -325,14 +334,20 @@ static inline bool drm_debug_syslog_enabled(enum
> drm_
date our assert mechanism.
- Remove unnecessary wrappers.
Changes since V1:
- Use a better name for variables.
- Update documentation.
- Avoid preemption.
* See update details per commit message
Rodrigo Siqueira (4):
drm/amd/display: Move specific DCN2x code that uses FPU to DML
drm/amd/displ
Cc: Christian König
Cc: Hersen Wu
Cc: Aric Cyr
Cc: Jun Lei
Cc: Dmytro Laktyushkin
Cc: Qingqing Zhuo
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/Makefile| 4 +
.../amd/display/amdgpu_dm/amdgpu_dm_trace.h | 21
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
ernel test robot
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c| 19 +++
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.h| 1 +
.../drm/amd/display/dc/dcn20/dcn20_resource.c | 2 ++
.../gpu/drm/amd/display/dc/dml/dcn2x/dcn2x.c
König
Cc: Hersen Wu
Cc: Aric Cyr
Cc: Jun Lei
Cc: Dmytro Laktyushkin
Cc: Qingqing Zhuo
Reported-by: kernel test robot
Signed-off-by: Rodrigo Siqueira
---
.../drm/amd/display/dc/dcn20/dcn20_resource.c | 39 +
.../drm/amd/display/dc/dcn20/dcn20_resource.h | 2 -
.../drm/amd/displa
: Aric Cyr
Cc: Jun Lei
Cc: Dmytro Laktyushkin
Cc: Qingqing Zhuo
Reported-by: kernel test robot
Signed-off-by: Rodrigo Siqueira
---
.../amd/display/amdgpu_dm/amdgpu_dm_trace.h | 13 ++--
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c| 77 +--
drivers/gpu/drm/amd/display/dc
Nice catch!
Are you using any tool to identify this problem?
Reviewed-by: Rodrigo Siqueira
On 04/29, Wan Jiabing wrote:
> In commit 482812d56698e ("drm/amd/display: Set max TTU on
> DPG enable"), "hubp.h" was added which caused the duplicate include.
> To be on th
/amd/display/dc/dc.h
> @@ -276,8 +276,6 @@ enum surface_update_type {
> /* Forward declaration*/
> struct dc;
> struct dc_plane_state;
> -struct dc_state;
> -
>
> struct dc_cap_funcs {
> bool (*get_dcc_compression_cap)(const struct dc *dc,
> --
> 2.25.1
&g
Reviewed-by: Rodrigo Siqueira
On 04/29, Wan Jiabing wrote:
> There are two declarations of struct dc_state here.
> Remove the later duplicate more secure.
>
> Signed-off-by: Wan Jiabing
> ---
> Changelog:
> v2:
> - Remove the later duplicate instead of the former.
>
Applied to amd-staging-drm-next.
Thanks
On 04/29, Rodrigo Siqueira wrote:
> Reviewed-by: Rodrigo Siqueira
>
> On 04/29, Wan Jiabing wrote:
> > There are two declarations of struct dc_state here.
> > Remove the later duplicate more secure.
> >
>
Is your robot public available?
btw, applied to amd-staging-drm-next.
Thanks
On 04/29, Jiabing Wan wrote:
>
> >Nice catch!
> >
> >Are you using any tool to identify this problem?
>
> Yes, I have a robot including many detecting scripts :)
>
> >Reviewed-b
tches for achieving the complete
isolation of this file.
Signed-off-by: Rodrigo Siqueira
Acked-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/Makefile | 1 +
.../drm/amd/display/dc/dcn20/dcn20_resource.c | 39 +---
.../drm/amd/display/dc/dcn20/dcn20_resource.h | 2 -
.../dr
DC invokes DC_FPU_START/END in multiple parts of the code; this can
create a situation where we invoke this FPU operation in a nested way.
For avoiding this situation, this commit adds a mechanism where
dc_fpu_begin/end manages the access to kernel_fpu_begin/end.
Signed-off-by: Rodrigo Siqueira
We don't have any mechanism for tracing FPU operations inside the
display core, making the debug work a little bit tricky. For trying to
alleviate this problem, this commit introduces a trace mechanism inside
our DC_FP_START/END macros.
Signed-off-by: Rodrigo Siqueira
Acked-by: Rodrigo Siq
l FPU functions weekly until
we isolate everything in the fpu_operation folder.
Best Regards
Rodrigo Siqueira
Rodrigo Siqueira (4):
drm/amd/display: Introduce FPU directory inside DC
drm/amd/display: Add FPU event trace
drm/amd/display: Add ref count control for FPU utilization
drm/amd/dis
f the function is invoked under FP
protection. If not, it will trigger a kernel warning.
Signed-off-by: Rodrigo Siqueira
Acked-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c| 34 ---
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.h| 1 +
.../drm/amd/displ
go.Siqueira%40amd.com%7Cd602106c4a3d4f0d9ba208d90e28289f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637556387922456015%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=b%2B7HCBCtToQVE5nJ9gqTr9vV1Amj4PS%2BXJSJB5743%2Fc%3D&reserved=0
--
Rodrigo Siqueira
https://siqueira.tech
signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 05/03, Simon Ser wrote:
> On Monday, May 3rd, 2021 at 4:20 PM, Rodrigo Siqueira
> wrote:
>
> > > diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> > > b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> > > index 109d11fb4cd4..aeb808a0ba5
LGTM,
Jay, any comment?
Reviewed-by: Rodrigo Siqueira
On 05/08, Rouven Czerwinski wrote:
> This function is not used anywhere, remove it. It was added in
> 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
> through debugfs") and moved in fe798de53a7
lgtm,
Reviewed-by: Rodrigo Siqueira
On 05/10, Andrey Grodzovsky wrote:
> It's already being released by DRM core through devm
>
> Signed-off-by: Andrey Grodzovsky
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
> 1 file changed, 1 deletion(-)
>
ng module options should be supported through configfs
> too.
>
> Writeback support
> @@ -162,6 +175,7 @@ Writeback support
> - The writeback and CRC capture operations share the use of composer_enabled
>boolean to ensure vblanks. Probably, when these operations work together,
>
ntil
we isolate everything in the fpu_operation folder.
Changes since V1:
- Use a better name for variables.
- Update documentation.
- Avoid preemption.
* See update details per commit message
Best Regards
Rodrigo Siqueira
Rodrigo Siqueira (4):
drm/amd/display: Introduce FPU directory insi
s for achieving the complete isolation of
this file.
Change since V1:
- Update documentation and rebase.
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/Makefile | 1 +
.../drm/amd/display/dc/dcn20/dcn20_resource.c | 39 +
.../drm/amd/display/dc/dcn20/dcn20_resource.h
We don't have any mechanism for tracing FPU operations inside the
display core, making the debug work a little bit tricky. This commit
introduces a trace mechanism inside our DC_FP_START/END macros for
trying to alleviate this problem.
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/di
f the function is invoked under FP
protection. If not, it will trigger a kernel warning.
Changes since V1:
- Remove fp_enable variables
- Rename dc_is_fp_enabled to dc_assert_fp_enabled
- Replace wrong variable type
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
:
- Use a better variable names
- Use get_cpu_ptr and put_cpu_ptr to better balance preemption enable
and disable
Signed-off-by: Rodrigo Siqueira
---
.../amd/display/amdgpu_dm/amdgpu_dm_trace.h | 13 ---
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c| 36 ---
drivers/gpu/drm
t; Now that the CRTCs have been converted, let's move forward with the
> connectors to provide a consistent interface.
>
> The conversion was done using the coccinelle script below, and built tested
> on all the drivers.
For the VKMS change:
Reviewed-by: Rodrigo Siqueira
> Cc:
_CUSTOM_PATTERN_263_256 0x2250
> > +
> > +/* DSC Extended Capability Branch Total DSC Resources */
> > +#define DP_DSC_SUPPORT_AND_DSC_DECODER_COUNT 0x2260 /* 2.0
> > */
> > +# define DP_DSC_DECODER_COUNT_MASK (0b111 << 5)
> > +# define DP_DSC_DECODER_COUNT
ink we can improve in this series and what
kind of content you want to see for the next series.
Thanks
Siqueira
Rodrigo Siqueira (6):
Documentation/gpu: Reorganize DC documentation
Documentation/gpu: Document amdgpu_dm_visual_confirm debugfs entry
Documentation/gpu: Document pipe sp
Display core provides a feature that makes it easy for users to debug
Pipe Split. This commit introduces how to use such a debug option.
Signed-off-by: Rodrigo Siqueira
---
.../gpu/amdgpu-dc/amdgpu-dc-debug.rst | 28 +--
1 file changed, 26 insertions(+), 2 deletions
Display core documentation is not well organized, and it is hard to find
information due to the lack of sections. This commit reorganizes the
documentation layout, and it is preparation work for future changes.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu-dc.rst
Display core provides a feature that makes it easy for users to debug
Multiple planes by enabling a visual notification at the bottom of each
plane. This commit introduces how to use such a feature.
Signed-off-by: Rodrigo Siqueira
---
.../gpu/amdgpu-dc/amdgpu-dc-debug.rst | 34
Introduce how to collect DTN log from debugfs.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu-dc/amdgpu-dc-debug.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/Documentation/gpu/amdgpu-dc/amdgpu-dc-debug.rst
b/Documentation/gpu/amdgpu-dc/amdgpu-dc
This commit describes how DCN works by providing high-level diagrams
with an explanation of each component. In particular, it details the
Global Sync signals.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu-dc/amdgpu-dc.rst | 22 +-
.../gpu/amdgpu-dc/amdgpu-dcn-overview.rst
In the DC driver, we have multiple acronyms that are not obvious most of
the time. This commit introduces a DC glossary in order to make it
easier to navigate through our driver.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu-dc/amdgpu-dc.rst | 2 +-
Documentation/gpu/amdgpu
and update CPLIB
- Add new acronyms to the glossary
Thanks
Siqueira
Rodrigo Siqueira (6):
Documentation/gpu: Reorganize DC documentation
Documentation/gpu: Document amdgpu_dm_visual_confirm debugfs entry
Documentation/gpu: Document pipe split visual confirmation
Documentation/gpu: How to c
redundant amdgpu prefix.
- Jani: Create index pages.
- Yann: Mirror display folder in the documentation.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu-dc.rst | 74 ---
Documentation/gpu/amdgpu/display/dc-debug.rst | 4 +
.../gpu/amdgpu/display/display
Display core provides a feature that makes it easy for users to debug
Multiple planes by enabling a visual notification at the bottom of each
plane. This commit introduces how to use such a feature.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 34
Display core provides a feature that makes it easy for users to debug
Pipe Split. This commit introduces how to use such a debug option.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 28 +--
1 file changed, 26 insertions(+), 2 deletions
Introduce how to collect DTN log from debugfs.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/Documentation/gpu/amdgpu/display/dc-debug.rst
b/Documentation/gpu/amdgpu/display/dc-debug.rst
.
- Alex: Make terms more consistent and update CPLIB
- Add new acronyms to the glossary
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu/amdgpu-glossary.rst | 47
.../gpu/amdgpu/display/dc-glossary.rst| 243 ++
Documentation/gpu/amdgpu/display/index.rst
This commit describes how DCN works by providing high-level diagrams
with an explanation of each component. In particular, it details the
Global Sync signals.
Signed-off-by: Rodrigo Siqueira
---
.../gpu/amdgpu/display/config_example.svg | 414 ++
.../amdgpu/display
on driver context.
- Make terms more consistent and update CPLIB
- Add new acronyms to the glossary
Thanks
Siqueira
Rodrigo Siqueira (6):
Documentation/gpu: Reorganize DC documentation
Documentation/gpu: Document amdgpu_dm_visual_confirm debugfs entry
Documentation/gpu: Document pipe sp
Display core provides a feature that makes it easy for users to debug
Pipe Split. This commit introduces how to use such a debug option.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 28 +--
1 file changed, 26 insertions(+), 2 deletions
Introduce how to collect DTN log from debugfs.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/Documentation/gpu/amdgpu/display/dc-debug.rst
b/Documentation/gpu/amdgpu/display/dc-debug.rst
Display core provides a feature that makes it easy for users to debug
Multiple planes by enabling a visual notification at the bottom of each
plane. This commit introduces how to use such a feature.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 34
redundant amdgpu prefix.
- Jani: Create index pages.
- Yann: Mirror display folder in the documentation.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu-dc.rst | 74 ---
Documentation/gpu/amdgpu/display/dc-debug.rst | 4 +
.../gpu/amdgpu/display/display
This commit describes how DCN works by providing high-level diagrams
with an explanation of each component. In particular, it details the
Global Sync signals.
Change since V2:
- Add a comment about MMHUBBUB.
Signed-off-by: Rodrigo Siqueira
---
.../gpu/amdgpu/display/config_example.svg
glossary based on driver context.
- Alex: Make terms more consistent and update CPLIB
- Add new acronyms to the glossary
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu/amdgpu-glossary.rst | 50
.../gpu/amdgpu/display/dc-glossary.rst| 243 ++
Documentation
: Add link between dc and amdgpu glossary
Changes since V2:
- Add MMHUB
Changes since V1:
- Yann: Divide glossary based on driver context.
- Alex: Make terms more consistent and update CPLIB
- Add new acronyms to the glossary
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu
redundant amdgpu prefix.
- Jani: Create index pages.
- Yann: Mirror display folder in the documentation.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu-dc.rst | 74 ---
Documentation/gpu/amdgpu/display/dc-debug.rst | 4 +
.../gpu/amdgpu/display/display
Display core provides a feature that makes it easy for users to debug
Multiple planes by enabling a visual notification at the bottom of each
plane. This commit introduces how to use such a feature.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 34
Introduce how to collect DTN log from debugfs.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/Documentation/gpu/amdgpu/display/dc-debug.rst
b/Documentation/gpu/amdgpu/display/dc-debug.rst
- Create index pages.
- Mirror display folder in the documentation.
- Divide glossary based on driver context.
- Make terms more consistent and update CPLIB
- Add new acronyms to the glossary
Thanks
Siqueira
Rodrigo Siqueira (6):
Documentation/gpu: Reorganize DC documentation
Documen
This commit describes how DCN works by providing high-level diagrams
with an explanation of each component. In particular, it details the
Global Sync signals.
Change since V2:
- Add a comment about MMHUBBUB.
Signed-off-by: Rodrigo Siqueira
---
.../gpu/amdgpu/display/config_example.svg
Display core provides a feature that makes it easy for users to debug
Pipe Split. This commit introduces how to use such a debug option.
Signed-off-by: Rodrigo Siqueira
---
Documentation/gpu/amdgpu/display/dc-debug.rst | 28 +--
1 file changed, 26 insertions(+), 2 deletions
Ramamurthy
Signed-off-by: Wesley Chalmers
Reviewed-by: Martin Leung
Reviewed-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c
b/drivers/gpu/drm/amd/displa
iLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=4gcQRS3HI4u1UEWu35Ze1w5CLWmAof5nouCFQoKEQD0%3D&reserved=0
>
> References
>
>Visible links
> 1.
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cbindu.r%40amd.com%7Cae8f547c92
/dri-devel/msg283767.html
Thanks
Rodrigo Siqueira (3):
Revert "drm/amd/display: Fix unused variable warning"
Revert "drm/amdgpu/disply: fix documentation warnings in display
manager"
Revert "drm/amd/display: Expose new CRC window property"
.../gpu/drm
This reverts commit 1206904465c8a9eebff9ca5a65effc8cf8f3cb84.
Cc: Wayne Lin
Cc: Alexander Deucher
Cc: Harry Wentland
Cc: Roman Li
Cc: Bindu R
Cc: Daniel Vetter
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 21 +--
1 file changed, 1
This reverts commit b5d8f1d02ba7021cad1bd5ad8460ce5611c479d8.
Cc: Wayne Lin
Cc: Alexander Deucher
Cc: Harry Wentland
Cc: Roman Li
Cc: Bindu R
Cc: Daniel Vetter
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++-
drivers/gpu/drm/amd/display
This reverts commit 110d586ba77ed573eb7464ca69b6490ec0b70c5f.
Cc: Wayne Lin
Cc: Alexander Deucher
Cc: Harry Wentland
Cc: Roman Li
Cc: Bindu R
Cc: Daniel Vetter
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 142 +-
.../gpu/drm/amd
se we will
need to create a debugfs or full UAPI for CRC soon, which will make this
code obsolete. We got two other patches related to this same code; for
this reason, this patchset reverts all changes associated with that
specific commit.
Rodrigo Siqueira (3):
Revert "drm/amd/display: Fix
This reverts commit b5d8f1d02ba7021cad1bd5ad8460ce5611c479d8.
Cc: Wayne Lin
Cc: Alexander Deucher
Cc: Harry Wentland
Cc: Roman Li
Cc: Bindu R
Cc: Daniel Vetter
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++-
drivers/gpu/drm/amd/display
This reverts commit 1206904465c8a9eebff9ca5a65effc8cf8f3cb84.
Cc: Wayne Lin
Cc: Alexander Deucher
Cc: Harry Wentland
Cc: Roman Li
Cc: Bindu R
Cc: Daniel Vetter
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 21 +--
1 file changed, 1
This reverts commit 110d586ba77ed573eb7464ca69b6490ec0b70c5f.
Cc: Wayne Lin
Cc: Alexander Deucher
Cc: Harry Wentland
Cc: Roman Li
Cc: Bindu R
Cc: Daniel Vetter
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 142 +-
.../gpu/drm/amd
From: Wayne Lin
[Why]
Find out when we try to disable CRC calculation, crc generation is still
enabled. Main reason is that dc_stream_configure_crc() will never get
called when the source is AMDGPU_DM_PIPE_CRC_SOURCE_NONE.
[How]
Add checking condition that when source is
AMDGPU_DM_PIPE_CRC_SOURC
c_add_crc_entry(crtc, true, frame_start++, &crc32);
This commit fixes this issue by adding a check that validates whether
the current vblank timestamp is still the same, thus avoiding excessive
timestamp decrement of the timestamp value.
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Shayenne Mo
Hi Daniel,
I forgot to apply this patch. Is it ok for you if I apply it?
On Fri, Mar 15, 2019 at 1:11 PM Rodrigo Siqueira
wrote:
>
> The function vkms_output_init() is invoked during the module
> initialization, and it handles the creation/configuration of the vkms
> essential e
On 01/18, Thomas Gleixner wrote:
> Rodrigo,
>
> On Wed, 16 May 2018, Rodrigo Siqueira wrote:
>
> All files added by this commit have inconsistent license information:
>
> > --- /dev/null
> > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> > @@ -0,0 +1,35 @@
>
Fixes license inconsistent related to the VKMS driver and remove the
redundant boilerplate comment.
Fixes: 854502fa0a38 ("drm/vkms: Add basic CRTC initialization")
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/vkms/vkms_crc.c| 3 ++-
drivers/gpu/drm/vkms/vkms_cr
r_dst + offset_dst, b_alpha, sizeof(u8));
> + memset(vaddr_dst + offset_dst + 1, g_alpha,
> sizeof(u8));
Take care with extra spaces at the end.
Finally, remember to run checkpatch in your patches.
> + memset(vaddr_dst + offset_dst + 2, r_alpha,
gt; - memcpy(vaddr_dst + offset_dst,
> -vaddr_src + offset_src, sizeof(u32));
> }
> i_dst++;
> }
> --
> 2.17.1
>
Finally, your patch introduces some checkpatch warnings and errors. I
highl
anks for the patchset :)
The patchset worked like a charm; it fixes many of the tests in the
kms_flip. \o/
I'll apply it.
Thanks!
Reviewed-by: Rodrigo Siqueira
--
Rodrigo Siqueira
https://siqueira.tech
Graduate Student
Department of Computer Science
University of Sã
1..23146ff2a25b 100644
> --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> @@ -87,6 +87,9 @@ bool vkms_get_vblank_timestamp(struct drm_device *dev,
> unsigned int pipe,
>
> *vblank_time = output->vblank_hrtimer.node.expires;
>
> +
vblank_hrtimer);
> - int ret_overrun;
> -
> - _vblank_handle(output);
> -
> ret_overrun = hrtimer_forward_now(&output->vblank_hrtimer,
> output->period_ns);
> +
Fixes license inconsistent related to the VKMS driver and remove the
redundant boilerplate comment.
Fixes: 854502fa0a38 ("drm/vkms: Add basic CRTC initialization")
Cc: sta...@vger.kernel.org
Signed-off-by: Rodrigo Siqueira
---
Changes in V2:
- Add "Cc: sta...@vger.kernel.org
On 02/06, Daniel Vetter wrote:
> On Wed, Feb 06, 2019 at 12:01:16PM -0200, Rodrigo Siqueira wrote:
> > Fixes license inconsistent related to the VKMS driver and remove the
> > redundant boilerplate comment.
> >
> > Fixes: 854502fa0a38 ("drm/vkms: Add basic CRTC i
enum hrtimer_restart vkms_vblank_simulate(struct
> hrtimer *timer)
>
> ret_overrun = hrtimer_forward_now(&output->vblank_hrtimer,
> output->period_ns);
> + WARN_ON(ret_overrun != 1);
> +
> spin_unlock(&output->lo
h is correct, and the problem pointed out by CI is not related
to this change.
Make sense?
Best Regards
On 10/17, Daniel Vetter wrote:
> On Wed, Oct 17, 2018 at 2:43 PM Rodrigo Siqueira
> wrote:
> >
> > Hi,
> >
> > First of all, thanks to all for the reviewers and feedback
Add maintainers and reviewers for VKMS driver
Signed-off-by: Rodrigo Siqueira
---
Changes in v2:
- Insert the section in alphabetical order
Resend:
- Update patch due to changes in MAINTAINER file
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b
On 01/14, Maarten Lankhorst wrote:
> Op 13-01-2019 om 21:23 schreef Rodrigo Siqueira:
> > Hi,
> >
> > I resend this patch for CI via “intel-...@lists.freedesktop.org” as
> > Daniel suggested, and I got a feedback that reported an issue as can be
>
state && output->crc_enabled) {
> - u64 frame = drm_crtc_accurate_vblank_count(crtc);
> + u64 frame = vblank->count;
>
> /* update frame_start only if a queued vkms_crc_work_handle()
>* has read the data
> --
> 2.17.1
>
--
elease() and kfree().
>
> Fix it by skipping the second release and free.
>
> This bug was originally found in the vgem driver by syzkaller using
> fault injection, but I noticed it's also present in the vkms driver.
>
> Fixes: 559e50fd34d1 ("drm/vkms: Add dumb
On 02/28, Dmitry Vyukov wrote:
> On Thu, Feb 28, 2019 at 12:12 AM Rodrigo Siqueira
> wrote:
> >
> > On 02/26, Eric Biggers wrote:
> > > From: Eric Biggers
> > >
> > > If drm_gem_handle_create() fails in vkms_gem_create(), then the
> > > vkms
R_PTR(ret);
> }
>
> static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device
> *dev,
> --
> 2.21.0.rc2.261.ga7da99ff1b-goog
>
> _______
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/
On 03/01, Maarten Lankhorst wrote:
> Convert vkms to using __drm_atomic_helper_crtc_reset(), instead of
> writing its own version. Instead of open coding destroy_state(),
> call it directly for freeing the old state.
>
> Signed-off-by: Maarten Lankhorst
> Cc: Rodrigo Siqu
nformats,
> + NULL,
> + DRM_PLANE_TYPE_OVERLAY, NULL);
> + if (ret) {
> + kfree(overlay);
> + return ERR_PTR(ret);
> + }
> +
IMHO you don't need to create a new function just for overlays
initi
On 03/05, Dmitry Vyukov wrote:
> On Tue, Mar 5, 2019 at 12:23 AM Rodrigo Siqueira
> wrote:
> >
> > On 02/28, Dmitry Vyukov wrote:
> > > On Thu, Feb 28, 2019 at 12:12 AM Rodrigo Siqueira
> > > wrote:
> > > >
> > > >
gt; > /* queue_work can fail to schedule crc_work; add crc for
> > > > > > > * missing frames
> > > > > > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c
> > > > > > > b/drivers/gpu/drm/vkms/vkms_crtc.c
> > > > > > > index 8a9aeb0a9ea8..9bf3268e2e92 100644
> > > > > > > --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> > > > > > > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> > > > > > > @@ -10,6 +10,8 @@ static enum hrtimer_restart
> > > > > > > vkms_vblank_simulate(struct hrtimer *timer)
> > > > > > > vblank_hrtimer);
> > > > > > > struct drm_crtc *crtc = &output->crtc;
> > > > > > > struct vkms_crtc_state *state =
> > > > > > > to_vkms_crtc_state(crtc->state);
> > > > > > > + unsigned int pipe = drm_crtc_index(crtc);
> > > > > > > + struct drm_vblank_crtc *vblank = &crtc->dev->vblank[pipe];
> > > > > > > u64 ret_overrun;
> > > > > > > bool ret;
> > > > > > >
> > > > > > > @@ -20,7 +22,7 @@ static enum hrtimer_restart
> > > > > > > vkms_vblank_simulate(struct hrtimer *timer)
> > > > > > > DRM_ERROR("vkms failure on handling vblank");
> > > > > > >
> > > > > > > if (state && output->crc_enabled) {
> > > > > > > - u64 frame = drm_crtc_accurate_vblank_count(crtc);
> > > > > > > + u64 frame = vblank->count;
> > > > > > >
> > > > > > > /* update frame_start only if a queued
> > > > > > > vkms_crc_work_handle()
> > > > > > > * has read the data
> > > > > > > --
> > > > > > > 2.17.1
> > > > > > >
> > > > > >
> > > > > > --
> > > > > > Daniel Vetter
> > > > > > Software Engineer, Intel Corporation
> > > > > > http://blog.ffwll.ch
> > > > > > ___
> > > > > > dri-devel mailing list
> > > > > > dri-devel@lists.freedesktop.org
> > > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > > > >
> > > > > --
> > > > > Ville Syrjälä
> > > > > Intel
> > >
> > > --
> > > Ville Syrjälä
> > > Intel
>
> --
> Ville Syrjälä
> Intel
--
Rodrigo Siqueira
https://siqueira.tech
Graduate Student
Department of Computer Science
University of São Paulo
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
et(dev);
diff --git a/drivers/gpu/drm/vkms/vkms_plane.c
b/drivers/gpu/drm/vkms/vkms_plane.c
index 0e67d2d42f0c..14259ffe47d8 100644
--- a/drivers/gpu/drm/vkms/vkms_plane.c
+++ b/drivers/gpu/drm/vkms/vkms_plane.c
@@ -190,7 +190,7 @@ struct drm_plane *vkms_plane_init(struct vkms_device
*vkmsdev,
NULL pointer dereference.
Fixes: 0f0eb98e33c6 ("drm/bochs: atomic: add atomic_flush+atomic_enable
callbacks")
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/bochs/bochs_kms.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/bochs/bochs_kms.c
b/drivers/gpu
1 - 100 of 458 matches
Mail list logo
