Re: [PATCH v2] drm: log errors in drm_gem_fb_init_with_funcs

[Rodrigo Siqueira]

On 05/03, Simon Ser wrote:
> Let the user know what went wrong in drm_gem_fb_init_with_funcs
> failure paths.
> 
> v2: use proper format specifier for size_t (kernel test robot)
> 
> Signed-off-by: Simon Ser <cont...@emersion.fr>
> Reviewed-by: Michel Dänzer <mdaen...@redhat.com>
> Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
> Cc: Sam Ravnborg <s...@ravnborg.org>
> Cc: Noralf Trønnes <nor...@tronnes.org>
> Cc: Andrzej Pietrasiewicz <andrze...@collabora.com>
> ---
>  drivers/gpu/drm/drm_gem_framebuffer_helper.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c 
> b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> index 109d11fb4cd4..aeb808a0ba54 100644
> --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> @@ -155,8 +155,10 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev,
>       int ret, i;
>  
>       info = drm_get_format_info(dev, mode_cmd);
> -     if (!info)
> +     if (!info) {
> +             drm_dbg_kms(dev, "Failed to get FB format info\n");

Just for curiosity,
Why not say something like "FB format is not supported" by the driver?
I'm asking because the kernel-doc for drm_get_format_info says "NULL if
the format is unsupported".

Thanks
Siqueira

>               return -EINVAL;
> +     }
>  
>       for (i = 0; i < info->num_planes; i++) {
>               unsigned int width = mode_cmd->width / (i ? info->hsub : 1);
> @@ -175,6 +177,9 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev,
>                        + mode_cmd->offsets[i];
>  
>               if (objs[i]->size < min_size) {
> +                     drm_dbg_kms(dev,
> +                                 "GEM object size (%zu) smaller than minimum 
> size (%u) for plane %d\n",
> +                                 objs[i]->size, min_size, i);
>                       drm_gem_object_put(objs[i]);
>                       ret = -EINVAL;
>                       goto err_gem_object_put;
> -- 
> 2.31.1
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Cd602106c4a3d4f0d9ba208d90e28289f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637556387922456015%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=b%2B7HCBCtToQVE5nJ9gqTr9vV1Amj4PS%2BXJSJB5743%2Fc%3D&amp;reserved=0

-- 
Rodrigo Siqueira
https://siqueira.tech

signature.asc
Description: PGP signature

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel