ta-xilinx-bsp/recipes-graphics/mali/kernel-module-mali
>
> -Mads
>
> On 7/19/21, 10:38 AM, "Jianqiang Chen" wrote:
>
> Add Mads.
>
> Thanks,
> Jason
>
> > -Original Message-
> > From: Michal Simek
> > Sen
Thanks for the remind, indeed miss a lock. Patch is:
Reviewed-by: Qiang Yu
Regards,
Qiang
On Fri, Aug 13, 2021 at 3:28 AM Daniel Vetter wrote:
>
> On Thu, Aug 05, 2021 at 12:46:53PM +0200, Daniel Vetter wrote:
> > Nothing special going on here.
> >
> > Aside reviewing
This function is kept for debug usage.
On Fri, Aug 20, 2021 at 10:19 AM Cai Huoqing wrote:
>
> lima_vm_print() isn't used, so remove it
>
> Signed-off-by: Cai Huoqing
> ---
> drivers/gpu/drm/lima/lima_vm.c | 29 -
> drivers/gpu/drm/lima/lima_vm.h | 1 -
> 2 files ch
Hi guys,
I have some interest to enable explicit sync for X11, so send a draft
MR to collect feedback:
https://gitlab.freedesktop.org/xorg/proto/xorgproto/-/merge_requests/34
As no comments on the gitlab MR, send this to mailing list and hope to
hear some voice. If NAKed early, it will save me a
Thanks, applied to drm-misc-next.
Regards,
Qiang
On Fri, Nov 27, 2020 at 5:42 PM Qinglang Miao wrote:
>
> pm_runtime_get_sync will increment pm usage counter even it
> failed. Forgetting to putting operation will result in a
> reference leak here.
>
> A new function pm_runtime_resume_and_get is
Thanks for the patch. But I can't observe any difference on glmark2
with or without this patch.
Maybe you can provide other test which can benefit from it.
Considering it will wake up CPU more frequently, and user may choose
to change this by sysfs,
I'd like to not apply it.
Regards,
Qiang
On We
This patch gets minor improvement on glmark2 (160->162).
Seems there's no way for user to change this value, do we?
Or there's work pending to expose it to sysfs?
Regards,
Qiang
On Thu, Jan 28, 2021 at 3:40 AM Christian Hewitt
wrote:
>
> This patch adapts the panfrost pre-defined thresholds cha
like phone suspend?
Regards,
Qiang
On Mon, Feb 1, 2021 at 5:53 PM Lukasz Luba wrote:
>
> Hi Qiang,
>
> On 1/30/21 1:51 PM, Qiang Yu wrote:
> > Thanks for the patch. But I can't observe any difference on glmark2
> > with or without this patch.
> > Maybe y
OK, I see. Patch is also:
Reviewed-by: Qiang Yu
Regards,
Qiang
On Mon, Feb 1, 2021 at 5:59 PM Lukasz Luba wrote:
>
>
>
> On 1/30/21 1:57 PM, Qiang Yu wrote:
> > This patch gets minor improvement on glmark2 (160->162).
>
> It has bigger impact when the load is chan
On Tue, Feb 2, 2021 at 10:02 PM Lukasz Luba wrote:
>
>
>
> On 2/2/21 1:01 AM, Qiang Yu wrote:
> > Hi Lukasz,
> >
> > Thanks for the explanation. So the deferred timer option makes a mistake
> > that
> > when GPU goes from idle to busy for only one p
Applied to drm-misc-next.
Regards,
Qiang
On Tue, Feb 2, 2021 at 9:04 AM Qiang Yu wrote:
>
> OK, I see. Patch is also:
> Reviewed-by: Qiang Yu
>
> Regards,
> Qiang
>
> On Mon, Feb 1, 2021 at 5:59 PM Lukasz Luba wrote:
> >
> >
> >
> > On 1/30/2
Applied to drm-misc-next.
Regards,
Qiang
On Thu, Feb 4, 2021 at 10:24 PM Lukasz Luba wrote:
>
>
>
> On 2/4/21 1:39 PM, Robin Murphy wrote:
> > On 2021-02-03 02:01, Qiang Yu wrote:
> >> On Tue, Feb 2, 2021 at 10:02 PM Lukasz Luba wrote:
> >>>
> >>
"gpu_pp0"/"gpu_pp1"
clk? Do they need to be controlled separately or we can just control the
"gpu" clk? Because the devfreq code just controls a single module clk.
>
> Signed-off-by: Marek Vasut
> Cc: Qiang Yu
> Cc: l...@lists.freedesktop.org
&g
On Sat, Jul 17, 2021 at 9:08 PM Marek Vasut wrote:
>
> On 7/17/21 2:34 PM, Qiang Yu wrote:
> > On Sat, Jul 17, 2021 at 2:20 AM Marek Vasut wrote:
> >>
> >> Instead of requesting two separate clock and then handling them
> >> separately in various pla
On Sat, Jul 17, 2021 at 10:52 PM Marek Vasut wrote:
>
> On 7/17/21 4:21 PM, Qiang Yu wrote:
> > On Sat, Jul 17, 2021 at 9:08 PM Marek Vasut wrote:
> >>
> >> On 7/17/21 2:34 PM, Qiang Yu wrote:
> >>> On Sat, Jul 17, 2021 at 2:20 AM Marek Vasut wrot
Applied to drm-misc-next.
On Fri, Nov 13, 2020 at 9:50 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/lima/lima_drv.c:264: warning: cannot understand function
> prototype: 'const struct drm_driver lima_drm_driver = '
>
but
> not used [-Wunused-but-set-variable]
>
> Cc: Qiang Yu
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Sumit Semwal
> Cc: "Christian König"
> Cc: dri-devel@lists.freedesktop.org
> Cc: l...@lists.freedesktop.org
> Cc: linux-me...@vger.kernel.org
> Cc:
Applied to drm-misc-next.
On Sat, Sep 19, 2020 at 6:43 PM Qiang Yu wrote:
>
> Looks good for me, patch is:
> Reviewed-by: Qiang Yu
>
> Regards,
> Qiang
>
> On Sat, Sep 19, 2020 at 5:47 PM Liu Shixin wrote:
> >
> > Simplify the return expressio
p_of_remove_table()
> unconditionally here.
>
> Reviewed-by: Qiang Yu
> Signed-off-by: Viresh Kumar
>
> ---
> V2: Applied Reviewed by tag.
> ---
> drivers/gpu/drm/lima/lima_devfreq.c | 6 +-
> drivers/gpu/drm/lima/lima_devfreq.h | 1 -
> 2 files changed, 1 insertion(+), 6
Looks good for me, patch is:
Reviewed-by: Qiang Yu
Regards,
Qiang
On Fri, Nov 6, 2020 at 3:05 PM Viresh Kumar wrote:
>
> The dev_pm_opp_put_*() APIs now accepts a NULL opp_table pointer and so
> there is no need for us to carry the extra check. Drop them.
>
> Signed-off-b
On Fri, Feb 18, 2022 at 3:46 PM Christian König
wrote:
>
> Am 18.02.22 um 04:08 schrieb Qiang Yu:
> > On Thu, Feb 17, 2022 at 8:22 PM Christian König
> > wrote:
> >> Am 17.02.22 um 11:58 schrieb Qiang Yu:
> >>> On Thu, Feb 17, 2022 at 6:39 PM Christi
On Fri, Feb 18, 2022 at 5:27 PM Christian König
wrote:
>
> Am 18.02.22 um 09:58 schrieb Qiang Yu:
> > On Fri, Feb 18, 2022 at 3:46 PM Christian König
> > wrote:
> >> Am 18.02.22 um 04:08 schrieb Qiang Yu:
> >>> On Thu, Feb 17, 2022 at 8:22 PM Christian Kö
On Fri, Feb 18, 2022 at 6:24 PM Christian König
wrote:
>
> Am 18.02.22 um 11:16 schrieb Qiang Yu:
> > [SNIP]
> >>> If amdgpu_vm_ready() use evicting flag, it's still not equivalent to check
> >>> vm idle: true -> vm idle, false -> vm may be idle or b
h the
waiting VM ops. But we'd better clear the error log by check the
evicting flag which really stop VM ops latter.
Signed-off-by: Qiang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
r in "evicted" list but no page table in it) gets done
immediately.
v2: update commit comments.
Reviewed-by: Christian König
Signed-off-by: Qiang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/g
On Wed, Feb 23, 2022 at 3:47 PM Paul Menzel wrote:
>
> Dear Qiang,
>
>
> Am 22.02.22 um 03:46 schrieb Qiang Yu:
> > Workstation application ANSA/META v21.1.4 get this error dmesg when
> > running CI test suite provided by ANSA/META:
> > [drm:amdgpu_gem_va_ioctl
ing flag")
Signed-off-by: Qiang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 2cd9f1a2e5fa..fc4563cf2828 100644
--- a/drivers/gpu/d
Otherwise get following warning:
DMA-API: lima 1c4.gpu: mapping sg segment longer than device claims to
support [len=4149248] [max=65536]
See: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5496
Reported-by: Roman Stratiienko
Signed-off-by: Qiang Yu
---
drivers/gpu/drm/lima
Looks good for me, patch is:
Reviewed-by: Qiang Yu
I'll apply it to drm-misc-next.
Regards,
Qiang
On Tue, May 21, 2019 at 6:46 AM Erico Nunes wrote:
>
> After "5918045c4ed4 drm/scheduler: rework job destruction", lima started
> to leak memory due to buffers not b
On Tue, May 21, 2019 at 8:17 PM Erico Nunes wrote:
>
> On Tue, May 21, 2019 at 8:47 AM Koenig, Christian
> wrote:
> >
> > Am 21.05.19 um 01:16 schrieb Erico Nunes:
> > > [CAUTION: External Email]
> > >
> > > After "5918045c4ed4 drm/scheduler: rework job destruction", jobs are
> > > only deleted w
it, gfp_t gfp)
> > > ^
> > > make[4]: *** [scripts/Makefile.build:276:
> > > drivers/gpu/drm/lima/lima_ctx.o] Error 1
> > > make[3]: *** [scripts/Makefile.build:486: drivers/gpu/drm/lima] Error 2
> > > make[2]: *** [scri
or MMU configs, and the attached config
> does not set/enable MMU.
> Maybe this driver should depend on MMU, like several other drm drivers do.
>
>
> Also, lima_gem.c needs this line to be added to it:
>
> --- mmotm-2019-0405-1828.orig/drivers/gpu/drm/lima/lima_gem.c
>
Looks good for me, patch is:
Reviewed-by: Qiang Yu
Should I apply this patch to drm-misc in this case? Or this patch will be
submitted in other kernel tree and back merged to drm-misc?
Regards,
Qiang
On Mon, Apr 8, 2019 at 3:12 AM Randy Dunlap wrote:
>
> From: Randy Dunlap
>
> N
Feedback from kbuild robot:
config: sh-allyesconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
lima_gem.c:(.text+0x6c): undefined reference to `vmf_insert_mixed'
Cc: Randy Dunlap
Signed-off-by: Qiang Yu
---
drivers/gpu/drm/lima/Kconfig| 2 ++
drivers/gp
On Mon, Apr 8, 2019 at 7:56 PM Neil Armstrong wrote:
>
> Hi,
>
> On 08/04/2019 13:26, Qiang Yu wrote:
> > Feedback from kbuild robot:
> > config: sh-allyesconfig (attached as .config)
> > compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> > lima_gem.c:
On Mon, Apr 8, 2019 at 8:00 PM Neil Armstrong wrote:
>
> On 08/04/2019 03:37, Qiang Yu wrote:
> > Looks good for me, patch is:
> > Reviewed-by: Qiang Yu
>
> Also:
> Reviewed-by: Neil Armstrong
>
> >
> > Should I apply this patch to drm-misc in this ca
Patch has been applied to drm-misc-next branch.
Thanks,
Qiang
On Mon, Apr 8, 2019 at 3:12 AM Randy Dunlap wrote:
>
> From: Randy Dunlap
>
> Note that the lima mailing list is moderated.
>
> Signed-off-by: Randy Dunlap
> Cc: Qiang Yu
> Cc: dri-devel@lists
pr 8, 2019 at 8:26 PM Qiang Yu wrote:
>
> On Mon, Apr 8, 2019 at 8:00 PM Neil Armstrong wrote:
> >
> > On 08/04/2019 03:37, Qiang Yu wrote:
> > > Looks good for me, patch is:
> > > Reviewed-by: Qiang Yu
> >
> > Also:
> > Reviewed-by: Neil Arm
ar ones in the history.
Could any maintainer help with this?
Thanks,
Qiang
On Mon, Apr 8, 2019 at 8:40 PM Qiang Yu wrote:
>
> Here's a question first time I use command:
> dim push-branch drm-misc-next
>
> I see it updates both drm-misc-next and for-linux-next branch, is this
On Mon, Apr 8, 2019 at 9:45 PM Neil Armstrong wrote:
>
> Hi,
>
> On 08/04/2019 15:19, Qiang Yu wrote:
> > Oh, I'm really sorry if I did something wrong to use:
> > dim push-branch drm-misc-next
> > (Should the committer just use "git push" not the &q
To prevent build fail on some platform which does
not have it in the include file chain.
Cc: Neil Armstrong
Suggested-by: Randy Dunlap
Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
Signed-off-by: Qiang Yu
---
drivers/gpu/drm/lima/lima_gem.c | 1 +
1 file changed, 1
Current implementation does not support MMU-less
plarforms.
Cc: Randy Dunlap
Cc: Neil Armstrong
Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
Signed-off-by: Qiang Yu
---
drivers/gpu/drm/lima/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gp
Modify comments and pushed to drm-misc-next.
Thanks,
Qiang
On Tue, Apr 9, 2019 at 8:36 AM Qiang Yu wrote:
>
> Current implementation does not support MMU-less
> plarforms.
>
> Cc: Randy Dunlap
> Cc: Neil Armstrong
> Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali
Pushed to drm-misc-next.
Thanks,
Qiang
On Tue, Apr 9, 2019 at 8:37 AM Qiang Yu wrote:
>
> To prevent build fail on some platform which does
> not have it in the include file chain.
>
> Cc: Neil Armstrong
> Suggested-by: Randy Dunlap
> Fixes: a1d2a6339961 ("drm/li
Thanks, patch is:
Reviewed-by: Qiang Yu
I'll add a "Fix" tag and push it to drm-misc-next.
Regards,
Qiang
On Tue, Apr 16, 2019 at 10:44 PM Yue Haibing wrote:
>
> From: YueHaibing
>
> Fix sparse warning:
>
> drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
&
Pushed to drm-misc-next.
Thanks,
Qiang
On Tue, Apr 16, 2019 at 10:44 PM Yue Haibing wrote:
>
> From: YueHaibing
>
> Fix sparse warning:
>
> drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
> symbol 'lima_sched_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot
> Signed-
Looks good for me, patch is:
Reviewed-by: Qiang Yu
I'll push this patch to drm-misc-next.
Regards,
Qiang
On Fri, Apr 19, 2019 at 4:35 PM Peter Griffin wrote:
>
> On Hikey board all lima ip blocks are shared with one irq.
> This patch avoids a NULL ptr deref crash on this
-by: Peter Griffin
> Cc: Rob Herring
> Cc: Daniel Vetter
> Cc: Qiang Yu
> ---
> drivers/gpu/drm/lima/lima_pp.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_pp.c b/drivers/gpu/drm/lima/lima_pp.c
> index d29721e
mscube and glamrk2, and some
single full screen application like kodi-gbm, see:
https://gitlab.freedesktop.org/lima/mesa
[rfc]
https://lists.freedesktop.org/archives/dri-devel/2018-May/177314.html
Lima Project Developers (1):
drm/lima: driver for ARM Mali4xx GPUs
Qiang Yu (1):
drm/fourcc: add
Signed-off-by: Qiang Yu
---
include/uapi/drm/drm_fourcc.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index 0b44260a5ee9..953b59eb3fd2 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
On Thu, Feb 7, 2019 at 3:17 AM Eric Anholt wrote:
>
> Qiang Yu writes:
>
> > From: Lima Project Developers
> >
> > Signed-off-by: Andreas Baierl
> > Signed-off-by: Erico Nunes
> > Signed-off-by: Heiko Stuebner
> > Signed-off-by: Marek Vasut
>
On Thu, Feb 7, 2019 at 5:09 PM Daniel Vetter wrote:
>
> On Wed, Feb 06, 2019 at 09:14:55PM +0800, Qiang Yu wrote:
> > Kernel DRM driver for ARM Mali 400/450 GPUs.
> >
> > Since last RFC, all feedback has been addressed. Most Mali DTS
> > changes are already upst
On Thu, Feb 7, 2019 at 5:39 PM Christian König
wrote:
>
> Am 07.02.19 um 10:09 schrieb Daniel Vetter:
> > On Wed, Feb 06, 2019 at 09:14:55PM +0800, Qiang Yu wrote:
> >> Kernel DRM driver for ARM Mali 400/450 GPUs.
> >>
> >> Since last RFC, all fee
77314.html
Cc: Andreas Baierl
Cc: Erico Nunes
Cc: Heiko Stuebner
Cc: Marek Vasut
Cc: Neil Armstrong
Cc: Simon Shields
Cc: Vasily Khoruzhick
Cc: Rob Herring
Qiang Yu (2):
drm: export drm_timeout_abs_to_jiffies
drm/lima: driver for ARM Mali4xx GPUs
drivers/gpu/drm/Kconfig
For other driver like lima usage.
Cc: Rob Herring
Signed-off-by: Qiang Yu
---
drivers/gpu/drm/drm_syncobj.c | 3 ++-
include/drm/drm_utils.h | 4
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
index
> > +static struct lima_fence *lima_fence_create(struct lima_sched_pipe *pipe)
> > +{
> > + struct lima_fence *fence;
> > +
> > + fence = kmem_cache_zalloc(lima_fence_slab, GFP_KERNEL);
>
> Out of curiosity, what is the benefit of using a separate slab here?
> If this is beneficial, the
Hi Sam,
Thanks, I'll fix them in next version.
Regards,
Qiang
On Sun, Mar 3, 2019 at 11:02 PM Sam Ravnborg wrote:
>
> Hi Qiang.
>
> Good to see you do prompt follow-up on the feedback you get.
> I applied the patch and noticed that git compains about
> a few whitespace errors.
> So for good mea
On Tue, Mar 5, 2019 at 1:20 AM Rob Herring wrote:
>
> On Sat, Mar 2, 2019 at 12:23 PM Rob Clark wrote:
> >
> > On Fri, Mar 1, 2019 at 9:32 PM Qiang Yu wrote:
> > >
> > > On Thu, Feb 28, 2019 at 5:41 AM Rob Herring wrote:
> > > >
> &g
On Wed, Mar 6, 2019 at 4:18 AM Eric Anholt wrote:
>
> Rob Herring writes:
>
> > On Fri, Mar 1, 2019 at 11:23 PM Qiang Yu wrote:
> >>
> >> > > +static struct lima_fence *lima_fence_create(struct lima_sched_pipe
> >> > > *pipe)
On Wed, Mar 6, 2019 at 4:16 AM Eric Anholt wrote:
>
> Qiang Yu writes:
>
> > - Mali 4xx GPUs have two kinds of processors GP and PP. GP is for
> > OpenGL vertex shader processing and PP is for fragment shader
> > processing. Each processor has its own MMU so prce
On Thu, Mar 7, 2019 at 8:08 AM Dave Airlie wrote:
>
> On Thu, 7 Mar 2019 at 09:46, Rob Herring wrote:
> >
> > On Wed, Mar 6, 2019 at 9:24 AM Qiang Yu wrote:
> > >
> > > - Mali 4xx GPUs have two kinds of processors GP and PP. GP is for
> > >
rm.h
> > @@ -0,0 +1,164 @@
> > +/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR MIT */
> > +/* Copyright 2017-2018 Qiang Yu */
> > +
> > +#ifndef __LIMA_DRM_H__
> > +#define __LIMA_DRM_H__
> > +
> > +#include "drm.h"
> &
On Thu, Mar 7, 2019 at 9:11 AM Eric Anholt wrote:
>
> Rob Herring writes:
>
> > On Wed, Mar 6, 2019 at 9:24 AM Qiang Yu wrote:
> >>
> >> - Mali 4xx GPUs have two kinds of processors GP and PP. GP is for
> >> OpenGL vertex shader processing and PP is f
v2: seperate AFBC and GPU encoding
Cc: Brian Starkey
Cc: Rob Herring
Cc: Alyssa Rosenzweig
Signed-off-by: Qiang Yu
---
include/uapi/drm/drm_fourcc.h | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/include/uapi/drm/drm_fourcc.h b/include
On Sun, Mar 10, 2019 at 10:08 AM Alyssa Rosenzweig wrote:
>
> > +/*
> > + * Arm Device code
> > + *
> > + * Arm has multiple devices which do not share buffer format,
> > + * so add a device field at the MSB of the format field to seperate
> > + * each device's encoding.
> > + */
> > +#define DRM_
uild test ERROR on linus/master]
> [also build test ERROR on v5.0 next-20190306]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Qiang-Yu/drm-lima-driver-for-ARM-Mali4x
On Sun, Mar 10, 2019 at 10:53 AM Alyssa Rosenzweig wrote:
>
> > If you think Midgard/Bifrost is compatible with AFBC and don't have it's
> > own format, and name "device" is improper, I can rename
> > DRM_FORMAT_MOD_ARM_DEVICE_AFBC to DRM_FORMAT_MOD_ARM_TYPE_AFBC
> > DRM_FORMAT_MOD_ARM_DEVICE_GPU
Alyssa did a very good description of our needs. Since I can't open the
cgit mesa link and give you a clear view of this format:
https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/gallium/drivers/panfrost/pan_swizzle.c
https://gitlab.freedesktop.org/lima/mesa/blob/lima-18.3/src/gallium/driver
On Mon, Mar 11, 2019 at 11:37 PM Rob Herring wrote:
>
> On Sat, Mar 9, 2019 at 6:21 AM Qiang Yu wrote:
> >
> > - Mali 4xx GPUs have two kinds of processors GP and PP. GP is for
> > OpenGL vertex shader processing and PP is for fragment shader
> > processing. Eac
On Tue, Mar 12, 2019 at 11:41 PM Ayan Halder wrote:
>
> On Mon, Mar 11, 2019 at 09:39:28AM -0700, Alyssa Rosenzweig wrote:
> > > You might want to re-use the exisiting modifier
> > > AFBC_FORMAT_MOD_BLOCK_SIZE_16x16.
> > >
> > > I would suggest you to have a look at the exisiting AFBC modifiers
>
Looks good for me:
Reviewed-by: Qiang Yu
Regards,
Qiang
On Thu, Jun 6, 2019 at 6:59 PM Emil Velikov wrote:
>
> On Mon, 27 May 2019 at 09:19, Emil Velikov wrote:
> >
> > From: Emil Velikov
> >
> > The authentication can be circumvented, by design, by using the
Looks good for me, patch is:
Reviewed-by: Qiang Yu
Regards,
Qiang
On Sat, Jun 15, 2019 at 4:37 AM Daniel Vetter wrote:
>
> It was only used for prime import, which is now handled by
> drm_prime.c.
>
> Signed-off-by: Daniel Vetter
> Cc: Qiang Yu
> Cc: l...@
Looks good for me, patch is:
Reviewed-by: Qiang Yu
I'll apply it to drm-misc-next.
Regards,
Qiang
On Wed, Jun 19, 2019 at 2:55 AM Krzysztof Kozlowski wrote:
>
> Mark long numbers with ULL to silence the Smatch warning:
>
> drivers/gpu/drm/lima/lima_device.c:314:32:
It looks like lima_clk_init will have the same problem if devm_clk_get
returns -EPROBE_DEFER.
Regards,
Qiang
On Wed, Jun 19, 2019 at 2:55 AM Krzysztof Kozlowski wrote:
>
> There is no point to print deferred probe (and its failures to get
> resources) as an error. For example getting a regulato
Thanks. This patch series are:
Reviewed-by: Qiang Yu
I'll apply them to drm-misc-next.
Regards,
Qiang
On Sat, Jun 22, 2019 at 12:21 AM Krzysztof Kozlowski wrote:
>
> Mark long numbers with ULL to silence the Smatch warning:
>
> drivers/gpu/drm/lima/lima_device.c:314:32:
On Fri, Jun 21, 2019 at 11:27 PM Daniel Vetter wrote:
>
> On Fri, Jun 21, 2019 at 12:21 PM Raymond Smith wrote:
> >
> > Add the DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED modifier to
> > denote the 16x16 block u-interleaved format used in Arm Utgard and
> > Midgard GPUs.
> >
> > Signed-off-by:
v2: separate AFBC and GPU encoding
v3: rename device to type and GPU modifer name
Cc: Brian Starkey
Cc: Rob Herring
Cc: Alyssa Rosenzweig
Cc: Ayan Halder
Signed-off-by: Qiang Yu
---
include/uapi/drm/drm_fourcc.h | 31 ++-
1 file changed, 30 insertions(+), 1
Hi Brian,
> Since your first patch set, I did raise this internally. The request
> has been making it's way through:
>
> - GPU engineering, to determine what exactly this format is, and
>what other variants there might be which are supported on different
>GPU generations, so that we can d
On Fri, Mar 29, 2019 at 5:31 AM Eric Anholt wrote:
>
> Daniel Vetter writes:
>
> > On Thu, Mar 28, 2019 at 03:12:23PM +0100, Neil Armstrong wrote:
> >> On 27/03/2019 20:06, Eric Anholt wrote:
> >> > Neil Armstrong writes:
> >> >
> >> >> Hi,
> >> >>
> >> >> On 26/03/2019 21:40, Vasily Khoruzhick
Signed-off-by: Qiang Yu
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f8e63bcc4c1c..cd2d632b713d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5101,6 +5101,15 @@ S: Maintained
F: drivers/gpu/drm/hisilicon/
F
On Fri, Mar 29, 2019 at 11:20 PM Daniel Vetter wrote:
>
> On Fri, Mar 29, 2019 at 09:47:48PM +0800, Qiang Yu wrote:
> > Signed-off-by: Qiang Yu
> > ---
> > MAINTAINERS | 9 +
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/MAINTA
On Tue, Apr 2, 2019 at 1:48 AM Eric Anholt wrote:
>
> Qiang Yu writes:
>
> > On Fri, Mar 29, 2019 at 11:20 PM Daniel Vetter wrote:
> >>
> >> On Fri, Mar 29, 2019 at 09:47:48PM +0800, Qiang Yu wrote:
> >> > Signed-off-by: Qiang Yu
> >>
Thanks, patch is:
Reviewed-by: Qiang Yu
Regards,
Qiang
On Tue, Apr 2, 2019 at 7:50 AM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the drm-misc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included fro
On Tue, Apr 2, 2019 at 3:57 PM Daniel Vetter wrote:
>
> On Tue, Apr 02, 2019 at 01:55:03PM +0800, Qiang Yu wrote:
> > Thanks, patch is:
> > Reviewed-by: Qiang Yu
>
> Good time to get started with committing patches? In general it's kinda
> confusing if the main
On Tue, Apr 2, 2019 at 6:26 AM Eric Anholt wrote:
>
> I haven't tested this, but it's a pretty direct port of what I did for
> v3d.
>
> Signed-off-by: Eric Anholt
> ---
> drivers/gpu/drm/lima/lima_gem.c | 37 +
> drivers/gpu/drm/lima/lima_sched.c | 66 ++
On Tue, Apr 2, 2019 at 7:21 PM Matthew Wilcox wrote:
>
> On Tue, Apr 02, 2019 at 10:50:06AM +1100, Stephen Rothwell wrote:
> > +++ b/drivers/gpu/drm/lima/lima_ctx.c
> > @@ -23,7 +23,7 @@ int lima_ctx_create(struct lima_device *dev, struct
> > lima_ctx_mgr *mgr, u32 *id)
> >
Cc: Stephen Rothwell
Cc: Matthew Wilcox
Cc: Daniel Vetter
Signed-off-by: Qiang Yu
---
drivers/gpu/drm/lima/lima_ctx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/lima/lima_ctx.c b/drivers/gpu/drm/lima/lima_ctx.c
index c8d12f7c6894..22fff6caa961 100644
On Tue, Apr 2, 2019 at 7:26 PM Matthew Wilcox wrote:
>
> On Tue, Apr 02, 2019 at 01:55:03PM +0800, Qiang Yu wrote:
> > Thanks, patch is:
> > Reviewed-by: Qiang Yu
>
> This looks like a fairly naive conversion from the old IDR API to the
> XArray API. You should
Indeed not that important, so patch 5&7 is:
Reviewed-and-tested-by: Qiang Yu
Regards,
Qiang
On Wed, Apr 3, 2019 at 12:57 AM Eric Anholt wrote:
>
> Qiang Yu writes:
>
> > On Tue, Apr 2, 2019 at 6:26 AM Eric Anholt wrote:
> >>
> >> I haven't tested thi
target
drm-misc branch.
2. Any special care need to take before push? Like need to test on
some public CI/CD system or just test locally on affected functionality
and arch is enough?
3. Do drm-misc have plan to move to gitlab?
Thanks,
Qiang
On Tue, Apr 2, 2019 at 10:30 AM Qiang Yu wrote:
&g
Looks good for me, patch is:
Reviewed-by: Qiang Yu
On Sun, Feb 6, 2022 at 2:59 AM Erico Nunes wrote:
>
> Currently when users try to run an application with lima and that hits
> an issue such as a timeout, a message saying "fail to save task state"
> and "error tas
message when the user
> has not explicitly set the max_error_tasks parameter to enable the
> feature.
>
> Signed-off-by: Erico Nunes
> Reviewed-by: Qiang Yu
> Reviewed-by: Javier Martinez Canillas
> ---
> v2:
> - collect review tags
> - update summary line to "drm/lima:"
h the
waiting VM ops. But we'd better make the amdgpu_vm->evicting
correctly reflact the vm status and clear the error log.
Signed-off-by: Qiang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 85 ++---
1 file changed, 47 insertions(+), 38 deletions(-)
diff --git a/d
On Thu, Feb 17, 2022 at 5:15 PM Christian König
wrote:
>
> Am 17.02.22 um 10:04 schrieb Qiang Yu:
> > Workstation application ANSA/META get this error dmesg:
> > [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16)
> >
> > This is caused
On Thu, Feb 17, 2022 at 5:46 PM Christian König
wrote:
>
> Am 17.02.22 um 10:40 schrieb Qiang Yu:
> > On Thu, Feb 17, 2022 at 5:15 PM Christian König
> > wrote:
> >> Am 17.02.22 um 10:04 schrieb Qiang Yu:
> >>> Workstation app
On Thu, Feb 17, 2022 at 6:39 PM Christian König
wrote:
>
>
>
> Am 17.02.22 um 11:13 schrieb Qiang Yu:
> > On Thu, Feb 17, 2022 at 5:46 PM Christian König
> > wrote:
> >> Am 17.02.22 um 10:40 schrieb Qiang Yu:
> >>> On Thu, Feb 17, 2022 at 5:15 PM Chr
On Thu, Feb 17, 2022 at 8:22 PM Christian König
wrote:
>
> Am 17.02.22 um 11:58 schrieb Qiang Yu:
> > On Thu, Feb 17, 2022 at 6:39 PM Christian König
> > wrote:
> >>
> >>
> >> Am 17.02.22 um 11:13 schrieb Qiang Yu:
> >>> On Thu, Feb 17
Thanks for adding this.
As the license, it's up to you, I think it's OK for now.
For the code, I think you may need some lock to protect the time records as
there are two kernel threads gp/pp will try to mark GPU busy and several
interrupts try to mark GPU idle.
Regards,
Qiang
On Mon, Dec 16,
On Sat, Dec 28, 2019 at 1:37 AM Martin Blumenstingl
wrote:
>
> Most platforms with a Mali-400 or Mali-450 GPU also have support for
> changing the GPU clock frequency. Add devfreq support so the GPU clock
> rate is updated based on the actual GPU usage when the
> "operating-points-v2" property is
drm_sched_job_timedout works with drm_sched_stop as a pair,
so we'd better use the drm_sched_fault helper to make the
error and timeout handling go the same path.
This also fixes application hang when task error.
Signed-off-by: Qiang Yu
---
drivers/gpu/drm/lima/lima_sched.c
1 - 100 of 345 matches
Mail list logo
