Re: drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Pin-yen Lin
Hi Xin, Can we use dev_dbg instead of dev_info for the logging? The log here is more like a debugging message, and using dev_dbg makes it consistent with anx7625_dp_stop. Sorry for not catching this earlier. Best regards, Pin-yen On Thu, Mar 3, 2022 at 3:52 PM Pin-yen Lin wrote: > > Re

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Pin-yen Lin
mode while bridge disabled, > > this patch used for setting downstream sink into normal status > > while enable bridge. > > > > Signed-off-by: Xin Ji > > Reviewed-by: Pin-Yen Lin > > > > --- > > V1 -> V2: use dev_dbg replace of dev_info >

Re: drm/bridge: anx7625: Set downstream sink into normal status

2022-03-02 Thread Pin-yen Lin
Reviewed-by: Pin-Yen Lin On Wed, Mar 2, 2022 at 8:09 PM Xin Ji wrote: > > As downstream sink was set into standby mode while bridge disabled, > this patch used for setting downstream sink into normal status > while enable bridge. > > Signed-off-by: Xin Ji > --- >

[PATCH] drm/bridge: it6505: Power off downstream device in .atomic_enable

2022-06-06 Thread Pin-Yen Lin
Power off the downstream device in .atomic_enable callback, so the external display shows up again after changing resolution. Fixes: 46ca7da7f1e8 ("drm/bridge: it6505: Send DPCD SET_POWER to downstream") Signed-off-by: Pin-Yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 3 +

Re: [PATCH v2 7/7] drm/bridge: anx7625: Add typec_mux_set callback function

2022-06-14 Thread Pin-yen Lin
Hi AngeloGioacchino, On Tue, Jun 14, 2022 at 4:15 PM AngeloGioacchino Del Regno wrote: > > Il 09/06/22 20:09, Prashant Malani ha scritto: > > From: Pin-Yen Lin > > > > Add the callback function when the driver receives state > > changes of the Type-C port. The ca

[PATCH] drm/bridge: anx7625: Fix overflow issue on reading EDID

2022-02-09 Thread Pin-Yen Lin
The length of EDID block can be longer than 256 bytes, so we should use `int` instead of `u8` for the `edid_pos` variable. Signed-off-by: Pin-Yen Lin --- drivers/gpu/drm/bridge/analogix/anx7625.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge

[PATCH v2] drm/bridge: anx7625: Fix overflow issue on reading EDID

2022-02-10 Thread Pin-Yen Lin
The length of EDID block can be longer than 256 bytes, so we should use `int` instead of `u8` for the `edid_pos` variable. Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP") Signed-off-by: Pin-Yen Lin Reviewed-by: Jernej Skrabec --- Changes in v2: - add &

[PATCH] drm/bridge: it6505: Send DPCD SET_POWER to downstream

2022-04-25 Thread Pin-Yen Lin
Send DPCD SET_POWER command to downstream in .atomic_disable to make the downstream monitor enter the power down mode, so the device suspend won't be affected. Fixes: b5c84a9edcd418 ("drm/bridge: add it6505 driver") Signed-off-by: Pin-Yen Lin --- drivers/gpu/drm/bridge/it

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-29 Thread Pin-yen Lin
On Wed, Jun 29, 2022 at 2:23 AM Rob Herring wrote: > > On Mon, Jun 27, 2022 at 02:43:39PM -0700, Prashant Malani wrote: > > Hello Rob, > > > > On Mon, Jun 27, 2022 at 2:04 PM Rob Herring wrote: > > > > > > On Wed, Jun 22, 2022 at 05:34:30PM +, Prashant Malani wrote: > > > > Introduce a bindin

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-29 Thread Pin-yen Lin
On Wed, Jun 29, 2022 at 10:33 PM Pin-yen Lin wrote: > > On Wed, Jun 29, 2022 at 2:23 AM Rob Herring wrote: > > > > On Mon, Jun 27, 2022 at 02:43:39PM -0700, Prashant Malani wrote: > > > Hello Rob, > > > > > > On Mon, Jun 27, 2022 at 2:04 PM Rob H

[PATCH] drm/bridge: it6505: Fix the order of DP_SET_POWER commands

2022-08-26 Thread Pin-yen Lin
pping DP") Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index f9251ec49bf0..2bb957cffd94 100644 --- a/drivers/gpu/drm/

[PATCH v2] drm/bridge: it6505: Fix the order of DP_SET_POWER commands

2022-08-29 Thread Pin-yen Lin
tream") Signed-off-by: Pin-yen Lin Reviewed-by: Robert Foss --- Changes in v2: - Correct "fixes" tag. - Collect "Reviewed-by" tag. drivers/gpu/drm/bridge/ite-it6505.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it65

[PATCH 0/2] drm/bridge: it6505: Power management fixes for it6505 bridge

2022-09-08 Thread Pin-yen Lin
This series contains 2 fixes related to it6505 power management. Pin-yen Lin (2): drm/bridge: it6505: Adapt runtime power management framework drm/bridge: it6505: Add pre_enable/post_disable callback drivers/gpu/drm/bridge/ite-it6505.c | 49 +++-- 1 file changed, 40

[PATCH 1/2] drm/bridge: it6505: Adapt runtime power management framework

2022-09-08 Thread Pin-yen Lin
ridge: add it6505 driver") Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index 2bb957cffd94..9d3766054

[PATCH 2/2] drm/bridge: it6505: Add pre_enable/post_disable callback

2022-09-08 Thread Pin-yen Lin
: add it6505 driver") Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index 9d37660545fb..f5eea138ace4 100644 --- a/drive

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-10-02 Thread Pin-yen Lin
Hi all, Are there any thoughts or comments about this proposal? On Sat, Sep 17, 2022 at 2:22 AM Prashant Malani wrote: > > Hi folks, > > On Fri, Sep 2, 2022 at 12:41 AM Prashant Malani wrote: > > > > Hi Rob, > > > > On Jul 12 11:45, Rob Herring wrote: > > > > > > That's not the right interpreta

[PATCH v2 0/2] drm/bridge: it6505: Power management fixes for it6505 bridge

2022-10-02 Thread Pin-yen Lin
This series contains 2 fixes related to it6505 power management. Changes in v2: - Handle the error from pm_runtime_get_sync in it6505_extcon_work Pin-yen Lin (2): drm/bridge: it6505: Adapt runtime power management framework drm/bridge: it6505: Add pre_enable/post_disable callback drivers

[PATCH v2 1/2] drm/bridge: it6505: Adapt runtime power management framework

2022-10-02 Thread Pin-yen Lin
ridge: add it6505 driver") Signed-off-by: Pin-yen Lin --- Changes in v2: - Handle the error from pm_runtime_get_sync in it6505_extcon_work drivers/gpu/drm/bridge/ite-it6505.c | 33 + 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH v2 2/2] drm/bridge: it6505: Add pre_enable/post_disable callback

2022-10-02 Thread Pin-yen Lin
: add it6505 driver") Signed-off-by: Pin-yen Lin --- (no changes since v1) drivers/gpu/drm/bridge/ite-it6505.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index 685d8e750b12..27de6652f

Re: [PATCH 1/3] drm/bridge: it6505: Modified power sequence

2022-07-12 Thread Pin-yen Lin
Hi Robert, On Tue, Jul 12, 2022 at 4:07 PM Robert Foss wrote: > > Hi Allen, > > On Thu, 7 Jul 2022 at 10:06, allen wrote: > > > > From: allen chen > > > > Change power sequence to meet it6505 data sheet requirement when boot on. > > > > Signed-of

Re: [PATCH v5 5/9] drm/bridge: anx7625: Add typec_mux_set callback function

2022-07-12 Thread Pin-yen Lin
On Thu, Jul 7, 2022 at 8:17 AM Stephen Boyd wrote: > > Quoting Prashant Malani (2022-07-06 11:26:19) > > > > Stephen, any pending concerns? > > No more pending concerns. > > > If not,I will post a v6 series with the suggested changes: > > - Drop typec-switch binding; instead add a new top-level po

[PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic_enable

2022-07-14 Thread Pin-Yen Lin
Send DPCD DP_SET_POWER_D0 command to the monitor in .atomic_enable callback. Without this command, some monitors won't show up again after changing the resolution. Fixes: 46ca7da7f1e8 ("drm/bridge: it6505: Send DPCD SET_POWER to downstream") Signed-off-by: Pin-Yen Lin ---

Re: [PATCH v2] drm/bridge: it6505: Add i2c api power on check

2022-07-20 Thread Pin-yen Lin
n it6505 power off. > > > > Signed-off-by: Pin-Yen Lin > > Signed-off-by: Allen Chen > > Reviewed-by: Robert Foss > > --- > > drivers/gpu/drm/bridge/ite-it6505.c | 12 ++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > &

[PATCH v11 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-02-04 Thread Pin-yen Lin
modified the drivers accordingly - Merged it6505/anx7625 driver changes into a single patch Pin-yen Lin (7): drm/display: Add Type-C switch helpers dt-bindings: display: bridge: anx7625: Add mode-switch support drm/bridge: anx7625: Check for Type-C during panel registration drm/bridge: an

[PATCH v11 1/9] device property: Add remote endpoint to devcon matcher

2023-02-04 Thread Pin-yen Lin
. This is required when a device supports two mode switches in its endpoints, so we can't simply register the mode switch with the parent node. Signed-off-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- Changes in v11: - Added mi

[PATCH v11 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-02-04 Thread Pin-yen Lin
ff-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Acked-by: Heikki Krogerus --- Changes in v11: - Collected Acked-by tag Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v7: - Fix the long comment lines Changes in v6: - New

[PATCH v11 3/9] drm/display: Add Type-C switch helpers

2023-02-04 Thread Pin-yen Lin
Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "reg" properties are available in Device Tre

[PATCH v11 4/9] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-02-04 Thread Pin-yen Lin
. Also include the link to the product brief in the bindings. Signed-off-by: Pin-yen Lin Reviewed-by: Krzysztof Kozlowski Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- Changes in v11: - Updated the description of the endpoints - Referenced video

[PATCH v11 5/9] drm/bridge: anx7625: Check for Type-C during panel registration

2023-02-04 Thread Pin-yen Lin
n the port endpoint, and skip panel registration completely if so. Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- (no changes since v10) Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v6: - New in v6 drivers/gpu/drm/bridge/analogix/anx7

[PATCH v11 6/9] drm/bridge: anx7625: Register Type C mode switches

2023-02-04 Thread Pin-yen Lin
different orientations of a single USB Type-C connector, but the orientation switch is not implemented yet. A TODO is added for this. Signed-off-by: Pin-yen Lin --- Changes in v11: - Added back "data-lanes" parsing logics - Removed Kconfig dependency - Updated the usage of the pr

[PATCH v11 7/9] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-02-04 Thread Pin-yen Lin
. Signed-off-by: Pin-yen Lin --- Changes in v11: - Updated the description of the endpoints in the bindings - Referenced video-interfaces.yaml instead for the endpoints binding - Removed duplicated definitions from inherited schema Changes in v9: - Fixed subject prefix again - Changed the naming of the

[PATCH v11 8/9] drm/bridge: it6505: Fix Kconfig indentation

2023-02-04 Thread Pin-yen Lin
Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v10) Changes in v10: - Collected Reviewed-by tag Changes in v7: - New in v7 drivers/gpu/drm/bridge/Kconfig | 20 ++-- 1

[PATCH v11 9/9] drm/bridge: it6505: Register Type C mode switches

2023-02-04 Thread Pin-yen Lin
chip. Signed-off-by: Pin-yen Lin --- Changes in v11: - Added back "data-lanes" parsing logics - Removed Kconfig dependency - Updated the usage of the private data Changes in v7: - Fixed style issues in it6505 driver - Removed the redundant sleep in it6505 driver - Removed DT proper

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add GPIO display mux binding

2023-02-07 Thread Pin-yen Lin
Hi Rob, Thanks for the review. On Wed, Jan 18, 2023 at 4:17 AM Rob Herring wrote: > > On Mon, Jan 16, 2023 at 07:08:19PM +0800, Pin-yen Lin wrote: > > From: Nicolas Boichat > > > > Add bindings for Generic GPIO mux driver. > > > > Signed-off-by: Nicolas Boi

Re: [PATCH v9 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-02-07 Thread Pin-yen Lin
om me (feel free to respond if it > does!), but I wanted to say nice work! This is something I've wanted to see > added to DRM for a while ♥ > > > On Mon, 2023-01-09 at 16:40 +0800, Pin-yen Lin wrote: > > This series introduces bindings for anx7625/it6505 to register T

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add GPIO display mux binding

2023-02-07 Thread Pin-yen Lin
Hi Laurent, On Tue, Feb 7, 2023 at 6:25 PM Laurent Pinchart wrote: > > On Tue, Feb 07, 2023 at 06:07:44PM +0800, Pin-yen Lin wrote: > > On Wed, Jan 18, 2023 at 4:17 AM Rob Herring wrote: > > > On Mon, Jan 16, 2023 at 07:08:19PM +0800, Pin-yen Lin wrote: > >

Re: [PATCH v11 7/9] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-02-08 Thread Pin-yen Lin
Hi Rob, Thanks for the review. On Wed, Feb 8, 2023 at 4:52 AM Rob Herring wrote: > > On Sat, Feb 04, 2023 at 09:30:38PM +0800, Pin-yen Lin wrote: > > ITE IT6505 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB Type-C DisplayP

Re: [PATCH v11 1/9] device property: Add remote endpoint to devcon matcher

2023-02-08 Thread Pin-yen Lin
Hi Sakari, Thanks for the review. On Mon, Feb 6, 2023 at 5:11 AM Sakari Ailus wrote: > > Hi Pin-yen, > > On Sat, Feb 04, 2023 at 09:30:32PM +0800, Pin-yen Lin wrote: > > From: Prashant Malani > > > > When searching the device graph for device matches, check the &g

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add GPIO display mux binding

2023-02-09 Thread Pin-yen Lin
Hi Laurent, On Tue, Feb 7, 2023 at 11:21 PM Laurent Pinchart wrote: > > Hello Pin-yen, > > On Tue, Feb 07, 2023 at 06:30:36PM +0800, Pin-yen Lin wrote: > > On Tue, Feb 7, 2023 at 6:25 PM Laurent Pinchart wrote: > > > On Tue, Feb 07, 2023 at 06:07:44PM +0800, Pin-ye

Re: [PATCH v11 7/9] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-02-10 Thread Pin-yen Lin
On Thu, Feb 9, 2023 at 9:58 PM Rob Herring wrote: > > On Wed, Feb 8, 2023 at 10:00 PM Pin-yen Lin wrote: > > > > Hi Rob, > > > > Thanks for the review. > > > > On Wed, Feb 8, 2023 at 4:52 AM Rob Herring wrote: > > > > > > On Sat, Feb

[PATCH v3 0/5] Add generic-display-mux driver and bindings

2023-02-18 Thread Pin-yen Lin
status in IRQ handler - Rebased to drm-misc-next - Update the license: "GPL v2" --> "GPL" Nicolas Boichat (2): dt-bindings: display: bridge: Add GPIO display mux binding drm: bridge: Generic GPIO mux driver Pin-yen Lin (3): dt-bindings: display: bridge: Add ddc-i2c-bus f

[PATCH v3 1/5] dt-bindings: display: bridge: Add ddc-i2c-bus for anx7688

2023-02-18 Thread Pin-yen Lin
Introduce a optional "ddc-i2c-bus" property for anx7688 bridge. This allows the bridge to register a .get_edid callback. Signed-off-by: Pin-yen Lin --- Changes in v3: - New in v3 .../bindings/display/bridge/google,cros-ec-anx7688.yaml | 5 + 1 file changed, 5 insertion

[PATCH v3 2/5] drm/bridge: Add .get_edid callback for anx7688 driver

2023-02-18 Thread Pin-yen Lin
Allow the driver to read EDID when ddc-i2c-bus phandle is present in the device node. Signed-off-by: Pin-yen Lin --- Changes in v3: - New in v3 drivers/gpu/drm/bridge/cros-ec-anx7688.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/bridge/cros-ec

[PATCH v3 3/5] drm/mediatek: Remove .get_edid callback

2023-02-18 Thread Pin-yen Lin
The original implementation peaking into the remote nodes to get the ddc bus fwnode, which is not a good practice. Remove the callback from this driver and rely on drm_connector helpers to read EDID. Signed-off-by: Pin-yen Lin --- Changes in v3: - New in v3 drivers/gpu/drm/mediatek/mtk_hdmi.c

[PATCH v3 5/5] drm: bridge: Generic GPIO mux driver

2023-02-18 Thread Pin-yen Lin
From: Nicolas Boichat This driver supports single input, 2 output display mux (e.g. HDMI mux), that provide its status via a GPIO. Signed-off-by: Nicolas Boichat Signed-off-by: Pin-yen Lin --- Changes in v3: - Added .get_edid callback in generic-gpio-mux driver Changes in v2: - Dropped

[PATCH v3 4/5] dt-bindings: display: bridge: Add GPIO display mux binding

2023-02-18 Thread Pin-yen Lin
From: Nicolas Boichat Add bindings for Generic GPIO mux driver. Signed-off-by: Nicolas Boichat Signed-off-by: Pin-yen Lin --- Rob mentioned that this series can probably use the common MUX bindings. Those bindings are designed for MUX consumers that requests a certain MUX configuration, while

Re: [PATCH v11 3/9] drm/display: Add Type-C switch helpers

2023-02-20 Thread Pin-yen Lin
Hi Andi, Thanks for the review. On Wed, Feb 8, 2023 at 5:25 AM Andi Shyti wrote: > Hi Pin-yen, > > [...] > > > +static int drm_dp_register_mode_switch(struct device *dev, > > +struct fwnode_handle *fwnode, > > +struct drm_d

Re: [PATCH v11 3/9] drm/display: Add Type-C switch helpers

2023-02-20 Thread Pin-yen Lin
I think I accidentally used HTML mode for the previous email. Sorry about that. On Mon, Feb 20, 2023 at 4:41 PM Pin-yen Lin wrote: > > Hi Andi, > > Thanks for the review. > > On Wed, Feb 8, 2023 at 5:25 AM Andi Shyti wrote: >> >> Hi Pin-yen, &

[PATCH v12 00/10] Register Type-C mode-switch in DP bridge endpoints

2023-02-21 Thread Pin-yen Lin
tches - Changed the driver implementation to accommodate with the new binding - Dropped typec-switch binding and use endpoints and data-lanes properties to describe the pin connections - Added new patches (patch 1,2,4) to fix probing issues - Changed the bindings of it6505/anx7625 and modified

[PATCH v12 01/10] device property: Add remote endpoint to devcon matcher

2023-02-21 Thread Pin-yen Lin
. This is required when a device supports two mode switches in its endpoints, so we can't simply register the mode switch with the parent node. Signed-off-by: Prashant Malani Signed-off-by: Pin-yen Lin --- Changes in v12: - Check the availability of the device node in fwnode_graph_devcon_ma

[PATCH v12 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-02-21 Thread Pin-yen Lin
ff-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Acked-by: Heikki Krogerus --- (no changes since v11) Changes in v11: - Collected Acked-by tag Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v7: - Fix the long comment

[PATCH v12 03/10] drm/display: Add Type-C switch helpers

2023-02-21 Thread Pin-yen Lin
Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "reg" properties are available in Device Tre

[PATCH v12 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-02-21 Thread Pin-yen Lin
. Also include the link to the product brief in the bindings. Signed-off-by: Pin-yen Lin Reviewed-by: Krzysztof Kozlowski Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- Changes in v12: - Removed the 4-lane binding in analogix,anx7625.yaml

[PATCH v12 05/10] drm/bridge: anx7625: Check for Type-C during panel registration

2023-02-21 Thread Pin-yen Lin
n the port endpoint, and skip panel registration completely if so. Signed-off-by: Pin-yen Lin --- Changes in v12: - Updated to use fwnode_for_each_typec_mode_switch macro - Dropped collected tags Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v6: - New in v6 drivers/gpu/

[PATCH v12 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505

2023-02-21 Thread Pin-yen Lin
These two drivers embed a i2c_client in there private driver data, but only strict device is actually needed. Replace the i2c_client reference with a struct device one. Signed-off-by: Pin-yen Lin --- Changes in v12: - New in v12 drivers/gpu/drm/bridge/analogix/anx7625.c | 96

[PATCH v12 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-02-21 Thread Pin-yen Lin
different orientations of a single USB Type-C connector, but the orientation switch is not implemented yet. A TODO is added for this. Signed-off-by: Pin-yen Lin --- Changes in v12: - Fixed style issues in anx7625 driver - Fixed the inverted orientation setting in anx7625 driver - Changed &qu

[PATCH v12 08/10] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-02-21 Thread Pin-yen Lin
. Signed-off-by: Pin-yen Lin --- Changes in v12: - Fixed the schema of "data-lanes" property for it6505 - Reworded the description of the mode-switch property Changes in v11: - Updated the description of the endpoints in the bindings - Referenced video-interfaces.yaml instead for the endpoin

[PATCH v12 09/10] drm/bridge: it6505: Fix Kconfig indentation

2023-02-21 Thread Pin-yen Lin
Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v10) Changes in v10: - Collected Reviewed-by tag Changes in v7: - New in v7 drivers/gpu/drm/bridge/Kconfig | 20 ++-- 1

[PATCH v12 10/10] drm/bridge: it6505: Register Type C mode switches

2023-02-21 Thread Pin-yen Lin
chip. Signed-off-by: Pin-yen Lin --- Changes in v12: - Fixes style issues in it6505 driver - Replaced &it6505->client->dev with it6505->dev - Updated the error logs when parsing data-lanes property Changes in v11: - Added back "data-lanes" parsing logics - Removed Kc

Re: [PATCH v12 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505

2023-02-21 Thread Pin-yen Lin
On Tue, Feb 21, 2023 at 5:51 PM Pin-yen Lin wrote: > > These two drivers embed a i2c_client in there private driver data, but This should be "their private driver data". I'll fix this in the next version. Pin-yen > only strict device is actually needed. Replace the i2c

Re: [PATCH v12 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-02-21 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Tue, Feb 21, 2023 at 7:36 PM Andy Shevchenko wrote: > > On Tue, Feb 21, 2023 at 05:50:51PM +0800, Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > > relevant ports are available i

Re: [PATCH v12 03/10] drm/display: Add Type-C switch helpers

2023-02-22 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Tue, Feb 21, 2023 at 7:48 PM Andy Shevchenko wrote: > > On Tue, Feb 21, 2023 at 05:50:47PM +0800, Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output be

Re: [PATCH v3 1/5] dt-bindings: display: bridge: Add ddc-i2c-bus for anx7688

2023-02-23 Thread Pin-yen Lin
On Sat, Feb 18, 2023 at 07:17:08PM +0800, Pin-yen Lin wrote: > > Introduce a optional "ddc-i2c-bus" property for anx7688 bridge. This > > allows the bridge to register a .get_edid callback. > > What's .get_edid? This is a binding and is independent of Linux. > > &

Re: [PATCH v3 1/5] dt-bindings: display: bridge: Add ddc-i2c-bus for anx7688

2023-02-23 Thread Pin-yen Lin
en On Tue, Feb 21, 2023 at 11:41 PM Rob Herring wrote: > > On Sat, Feb 18, 2023 at 07:17:08PM +0800, Pin-yen Lin wrote: > > Introduce a optional "ddc-i2c-bus" property for anx7688 bridge. This > > allows the bridge to register a .get_edid callback. > >

[PATCH v13 00/10] Register Type-C mode-switch in DP bridge endpoints

2023-03-03 Thread Pin-yen Lin
obing issues - Changed the bindings of it6505/anx7625 and modified the drivers accordingly - Merged it6505/anx7625 driver changes into a single patch Pin-yen Lin (8): drm/display: Add Type-C switch helpers dt-bindings: display: bridge: anx7625: Add mode-switch support drm/bridge: anx7625:

[PATCH v13 01/10] device property: Add remote endpoint to devcon matcher

2023-03-03 Thread Pin-yen Lin
. This is required when a device supports two mode switches in its endpoints, so we can't simply register the mode switch with the parent node. Signed-off-by: Prashant Malani Signed-off-by: Pin-yen Lin --- Changes in v13: - Update the kernel doc of fwnode_connection_find_match Changes i

[PATCH v13 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-03-03 Thread Pin-yen Lin
ff-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Acked-by: Heikki Krogerus --- (no changes since v11) Changes in v11: - Collected Acked-by tag Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v7: - Fix the long comment

[PATCH v13 03/10] drm/display: Add Type-C switch helpers

2023-03-03 Thread Pin-yen Lin
Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "reg" properties are available in Device Tre

[PATCH v13 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-03-03 Thread Pin-yen Lin
. Also include the link to the product brief in the bindings. Signed-off-by: Pin-yen Lin Reviewed-by: Krzysztof Kozlowski Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v12) Changes in v12: - Removed the 4-lane binding in

[PATCH v13 05/10] drm/bridge: anx7625: Check for Type-C during panel registration

2023-03-03 Thread Pin-yen Lin
n the port endpoint, and skip panel registration completely if so. Signed-off-by: Pin-yen Lin --- Changes in v13: - Use the new typec_mode_switch_node_count helper Changes in v12: - Updated to use fwnode_for_each_typec_mode_switch macro - Dropped collected tags Changes in v10: - Collected Revie

[PATCH v13 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505

2023-03-03 Thread Pin-yen Lin
These two drivers embed a i2c_client in their private driver data, but only strict device is actually needed. Replace the i2c_client reference with a struct device one. Signed-off-by: Pin-yen Lin Reviewed-by: Andy Shevchenko --- Changes in v13: - Update a typo in the commit message - Collect

[PATCH v13 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-03-03 Thread Pin-yen Lin
different orientations of a single USB Type-C connector, but the orientation switch is not implemented yet. A TODO is added for this. Signed-off-by: Pin-yen Lin --- (no changes since v12) Changes in v12: - Fixed style issues in anx7625 driver - Fixed the inverted orientation setting in anx7

[PATCH v13 08/10] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-03-03 Thread Pin-yen Lin
. Signed-off-by: Pin-yen Lin --- (no changes since v12) Changes in v12: - Fixed the schema of "data-lanes" property for it6505 - Reworded the description of the mode-switch property Changes in v11: - Updated the description of the endpoints in the bindings - Referenced video-interfaces.ya

[PATCH v13 09/10] drm/bridge: it6505: Fix Kconfig indentation

2023-03-03 Thread Pin-yen Lin
Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v10) Changes in v10: - Collected Reviewed-by tag Changes in v7: - New in v7 drivers/gpu/drm/bridge/Kconfig | 20 ++-- 1

[PATCH v13 10/10] drm/bridge: it6505: Register Type C mode switches

2023-03-03 Thread Pin-yen Lin
chip. Signed-off-by: Pin-yen Lin --- Changes in v13: - Fix style issues Changes in v12: - Fixes style issues in it6505 driver - Replaced &it6505->client->dev with it6505->dev - Updated the error logs when parsing data-lanes property Changes in v11: - Added back "data-l

Re: [PATCH v13 03/10] drm/display: Add Type-C switch helpers

2023-03-08 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Mon, Mar 6, 2023 at 7:49 PM Andy Shevchenko wrote: > > On Fri, Mar 03, 2023 at 10:33:43PM +0800, Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output be

Re: [PATCH v13 05/10] drm/bridge: anx7625: Check for Type-C during panel registration

2023-03-08 Thread Pin-yen Lin
HI Andy, On Mon, Mar 6, 2023 at 7:52 PM Andy Shevchenko wrote: > > On Fri, Mar 03, 2023 at 10:33:45PM +0800, Pin-yen Lin wrote: > > The output port endpoints can be connected to USB-C connectors. > > Running drm_of_find_panel_or_bridge() with such endpoints leads to > > a

Re: [PATCH v13 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-03-08 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Mon, Mar 6, 2023 at 7:55 PM Andy Shevchenko wrote: > > On Fri, Mar 03, 2023 at 10:33:47PM +0800, Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > > relevant ports are available i

Re: [PATCH v13 10/10] drm/bridge: it6505: Register Type C mode switches

2023-03-08 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Mon, Mar 6, 2023 at 8:03 PM Andy Shevchenko wrote: > > On Fri, Mar 03, 2023 at 10:33:50PM +0800, Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > > relevant port are available i

[PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-01-11 Thread Pin-yen Lin
nections - Added new patches (patch 1,2,4) to fix probing issues - Changed the bindings of it6505/anx7625 and modified the drivers accordingly - Merged it6505/anx7625 driver changes into a single patch Pin-yen Lin (7): drm/display: Add Type-C switch helpers dt-bindings: display: bridge: anx7

[PATCH v10 1/9] device property: Add remote endpoint to devcon matcher

2023-01-11 Thread Pin-yen Lin
. This is required when a device supports two mode switches in its endpoints, so we can't simply register the mode switch with the parent node. Signed-off-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- Changes in v10: - Collected Review

[PATCH v10 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-01-11 Thread Pin-yen Lin
ff-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v7: - Fix the long comment lines Changes in v6: - New in v6 drivers/platform/chrome/cros_ec_typec.c | 10 ++ 1

[PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-11 Thread Pin-yen Lin
Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "data-lanes" properties are available in Device Tre

[PATCH v10 4/9] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-01-11 Thread Pin-yen Lin
. Also include the link to the product brief in the bindings. Signed-off-by: Pin-yen Lin Reviewed-by: Krzysztof Kozlowski Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v9

[PATCH v10 5/9] drm/bridge: anx7625: Check for Type-C during panel registration

2023-01-11 Thread Pin-yen Lin
n the port endpoint, and skip panel registration completely if so. Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v6: - New in v6 drivers/gpu/drm/bridge/analogix/anx7625.c | 13 +++

[PATCH v10 6/9] drm/bridge: anx7625: Register Type C mode switches

2023-01-11 Thread Pin-yen Lin
different orientations of a single USB Type-C connector, but the orientation switch is not implemented yet. A TODO is added for this. Signed-off-by: Pin-yen Lin Tested-by: Chen-Yu Tsai --- Changes in v10: - Added a TODO for implementing orientation switch for anx7625 - Updated the commit messa

[PATCH v10 7/9] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-01-11 Thread Pin-yen Lin
. Signed-off-by: Pin-yen Lin --- (no changes since v9) Changes in v9: - Fixed subject prefix again - Changed the naming of the example node for it6505 Changes in v8: - Updated bindings for data-lanes property - Fixed subject prefix Changes in v7: - Fixed issues reported by dt_binding_check. - Updated

[PATCH v10 8/9] drm/bridge: it6505: Fix Kconfig indentation

2023-01-11 Thread Pin-yen Lin
Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin Reviewed-by: AngeloGioacchino Del Regno --- Changes in v10: - Collected Reviewed-by tag Changes in v7: - New in v7 drivers/gpu/drm/bridge/Kconfig | 20 ++-- 1 file changed, 10 insertions

[PATCH v10 9/9] drm/bridge: it6505: Register Type C mode switches

2023-01-11 Thread Pin-yen Lin
chip. Signed-off-by: Pin-yen Lin --- (no changes since v7) Changes in v7: - Fixed style issues in it6505 driver - Removed the redundant sleep in it6505 driver - Removed DT property validation in it6505 driver - Rebased to drm-misc-next - Extracted common codes to another commit Chan

Re: [PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-01-11 Thread Pin-yen Lin
Hi Dmitry, On Thu, Jan 12, 2023 at 12:34 PM Dmitry Baryshkov wrote: > > On 12/01/2023 06:20, Pin-yen Lin wrote: > > > > This series introduces bindings for anx7625/it6505 to register Type-C > > mode-switch in their output endpoints, and use data-lanes property to > >

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-11 Thread Pin-yen Lin
Hi Dmitry, Thanks for the review. On Thu, Jan 12, 2023 at 12:40 PM Dmitry Baryshkov wrote: > > On 12/01/2023 06:20, Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output between two dow

Re: [PATCH v10 4/9] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-01-11 Thread Pin-yen Lin
Hi Dmitry, Thanks for the review. On Thu, Jan 12, 2023 at 12:43 PM Dmitry Baryshkov wrote: > > On 12/01/2023 06:20, Pin-yen Lin wrote: > > Analogix 7625 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB Type-C DisplayPort alternat

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-11 Thread Pin-yen Lin
On Thu, Jan 12, 2023 at 1:24 PM Dmitry Baryshkov wrote: > > On 12/01/2023 07:19, Pin-yen Lin wrote: > > Hi Dmitry, > > > > Thanks for the review. > > > > On Thu, Jan 12, 2023 at 12:40 PM Dmitry Baryshkov > > wrote: > >> > >> On 12/01/

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-12 Thread Pin-yen Lin
On Thu, Jan 12, 2023 at 1:50 PM Dmitry Baryshkov wrote: > > On 12/01/2023 07:48, Pin-yen Lin wrote: > > On Thu, Jan 12, 2023 at 1:24 PM Dmitry Baryshkov > > wrote: > >> > >> On 12/01/2023 07:19, Pin-yen Lin wrote: > >>> Hi Dmitry, > >>

Re: [PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-01-13 Thread Pin-yen Lin
Hi Rob, On Fri, Jan 13, 2023 at 6:44 AM Rob Herring wrote: > > On Wed, Jan 11, 2023 at 10:21 PM Pin-yen Lin wrote: > > > > > > This series introduces bindings for anx7625/it6505 to register Type-C > > mode-switch in their output endpoints, and use data-lanes pr

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-13 Thread Pin-yen Lin
Hi Jani, Thanks for the review. On Thu, Jan 12, 2023 at 4:37 PM Jani Nikula wrote: > > On Thu, 12 Jan 2023, Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output between two downstream

[PATCH v2 0/2] Add generic-display-mux driver and bindings

2023-01-16 Thread Pin-yen Lin
This is the v2 the mux driver part of v1. This series is developed for and tested on MT8173 board, whose layout looks like: /-- anx7688 -- MT8173 HDMI bridge -- GPIO mux \-- native HDMI v1: https://patchwork.kernel.org/project/d

[PATCH v2 1/2] dt-bindings: display: bridge: Add GPIO display mux binding

2023-01-16 Thread Pin-yen Lin
From: Nicolas Boichat Add bindings for Generic GPIO mux driver. Signed-off-by: Nicolas Boichat Signed-off-by: Pin-yen Lin --- Changes in v2: - Referenced existing dt-binding schemas from graph.yaml - Added ddc-i2c-bus into the bindings .../bindings/display/bridge/gpio-mux.yaml | 95

[PATCH v2 2/2] drm: bridge: Generic GPIO mux driver

2023-01-16 Thread Pin-yen Lin
From: Nicolas Boichat This driver supports single input, 2 output display mux (e.g. HDMI mux), that provide its status via a GPIO. Signed-off-by: Nicolas Boichat Signed-off-by: Pin-yen Lin --- Laurent in v1 pointed out that the driver doesn't support panels as a downstream. IIUC this c

[PATCH v3 0/2] drm/bridge: it6505: Power management fixes for it6505 bridge

2022-10-03 Thread Pin-yen Lin
This series contains 2 fixes related to it6505 power management. Changes in v3: - Handle the error from extcon_get_state - Collect review tag Changes in v2: - Handle the error from pm_runtime_get_sync in it6505_extcon_work Pin-yen Lin (2): drm/bridge: it6505: Adapt runtime power management

  1   2   3   >