Re: [PATCH 2/7] drm/sti: Use correct printk format specifiers for size_t

2021-07-30 Thread Philippe CORNU
d+%d+%d+%d != %zu)\n", Hi Laurent, Looping Benjamin (new email address) and Alain (future maintainer of drm/sti). Reviewed-by: Philippe Cornu Many thanks for your patch, Philippe :-) sizeof(*header), header->rd_size, header->wr_size,

Re: [PATCH 5/7] drm/sti: Enable COMPILE_TEST on all ARM and ARM64 platforms

2021-07-30 Thread Philippe CORNU
M64) Reviewed-by: Philippe Cornu Many thanks for your patch, Philippe :-) COMPILE_TEST is selected. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/sti/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kcon

RE: [PATCH V4] drm/stm: Fix bus_flags handling

2021-02-15 Thread Philippe CORNU
; Benjamin Gaignard ; Maxime Coquelin ; Philippe CORNU ; Sam Ravnborg ; Vincent ABRIOU ; linux-arm-ker...@lists.infradead.org; linux-st...@st-md-mailman.stormreply.com Subject: [PATCH V4] drm/stm: Fix bus_flags handling The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW or

Re: [PATCH] MAINTAINERS: Add Raphael Gallais-Pou as STM32 DRM maintainer

2021-07-09 Thread Philippe CORNU
+++ b/MAINTAINERS @@ -6165,6 +6165,7 @@ DRM DRIVERS FOR STM M:Yannick Fertre M:Philippe Cornu M:Benjamin Gaignard +M: Raphael Gallais-Pou Hi Raphaël, Warm welcome on board! Reviewed-by: Philippe Cornu Note: you may have to wait and resend your patch as Benjamin sent

Re: [PATCH] drm/stm: ltdc: Silence -EPROBE_DEFER till bridge attached

2021-07-13 Thread Philippe CORNU
DEFER) + drm_encoder_cleanup(encoder); Many thanks for your patch. This means that we are counting on the future success of the deferred probe because we do not clean the encoder... However, Yannick gave his "Tested-by" and this patch seems useful so Acked-by: Philippe Cornu I will merge it

Re: [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back

2021-07-13 Thread Philippe CORNU
actual delay from the lane's bps. Signed-off-by: Antonio Borneo --- To: Yannick Fertre To: Philippe Cornu To: Benjamin Gaignard To: David Airlie To: Daniel Vetter To: Maxime Coquelin To: Alexandre Torgue To: Raphael Gallais-Pou To: dri-devel@lists.freedesktop.org To: linux-st...@

Re: [PATCH] drm/stm: ltdc: Silence -EPROBE_DEFER till bridge attached

2021-07-19 Thread Philippe CORNU
On 7/13/21 6:43 PM, Philippe CORNU wrote: Hi Jagan, On 7/4/21 3:59 PM, Jagan Teki wrote: As dw-mipi-dsi supported all possible ways to find the DSI devices. It can take multiple iterations for ltdc to find all components attached to the DSI bridge. The current ltdc driver failed to find

Re: [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back

2021-07-19 Thread Philippe CORNU
On 7/13/21 6:47 PM, Philippe CORNU wrote: Hi Antonio, On 7/13/21 4:49 PM, Antonio Borneo wrote: The driver uses a conservative set of hardcoded values for the maximum time delay of the transitions between LP and HS, either for data and clock lanes. By using the info in STM32MP157 datasheet

Re: [PATCH] drm/stm: Avoid using val uninitialized in ltdc_set_ycbcr_config()

2022-02-22 Thread Philippe CORNU
On 2/7/22 8:44 PM, Nick Desaulniers wrote: On Mon, Feb 7, 2022 at 8:53 AM Nathan Chancellor wrote: Clang warns: drivers/gpu/drm/stm/ltdc.c:625:2: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~

Re: [PATCH] drm/stm: ltdc: add support for CRC hashing feature

2022-02-25 Thread Philippe CORNU
On 2/11/22 11:46, Raphaël Gallais-Pou wrote: From: Raphael Gallais-Pou This patch adds the CRC hashing feature supported by some recent hardware versions of the LTDC. This is useful for test suite such as IGT-GPU-tools [1] where a CRTC output frame can be compared to a test reference frame t

Re: [PATCH v2] drm/stm: Avoid using val uninitialized in ltdc_set_ycbcr_config()

2022-02-25 Thread Philippe CORNU
On 2/22/22 16:20, Nathan Chancellor wrote: Clang warns: drivers/gpu/drm/stm/ltdc.c:625:2: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~ drivers/gpu/drm/stm/ltdc.c:635:2: note: uninitiali

Re: [PATCH v2] drm/stm: ltdc: attach immutable zpos property to planes

2021-09-09 Thread Philippe CORNU
On 9/7/21 5:13 PM, Raphael Gallais-Pou wrote: Defines plane ordering by hard-coding an immutable Z position from the first plane, used as primary layer, to the next ones as overlay in order of instantiation. This zpos is only an information as it is not possible to modify it, blending operati

Re: [PATCH v2] drm/stm: ltdc: add layer alpha support

2021-09-09 Thread Philippe CORNU
On 9/7/21 5:15 PM, Raphael Gallais-Pou wrote: Android Hardware Composer supports alpha values applied to layers. Enabling non-opaque layers for the STM CRTC could help offload GPU resources for screen composition. Signed-off-by: Raphael Gallais-Pou Acked-by: Yannick Fertre Reviewed-by: Yann

Re: [PATCH] drm/stm: remove conflicting framebuffers

2021-12-14 Thread Philippe CORNU
; +    ret = drm_aperture_remove_framebuffers(false, &drv_driver); +    if (ret) +    return ret; + Hi Yannick, and many thanks for your patch. Acked-by: Philippe Cornu Philippe :-)   dma_set_coherent_mask(dev, DMA_BIT_MASK(32));   ddev = drm_dev_alloc(&drv_driver, dev);

Re: [PATCH] drm/stm: ltdc: support of new hardware version

2021-12-14 Thread Philippe CORNU
/* bus width (32 or 64 bits) */ const u32 *pix_fmt_hw; /* supported pixel formats */ bool non_alpha_only_l1; /* non-native no-alpha formats on layer 1 */ Hi Yannick, This looks great, many thanks for your patch. Acked-by: Philippe Cornu Philippe :-)

Re: [PATCH v4 1/2] drm: automatic legacy gamma support

2020-12-14 Thread Philippe CORNU
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > drivers/gpu/drm/stm/ltdc.c| 1 - For the stm part, Reviewed-by: Philippe Cornu Thank you Philippe :-) ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/5] drm/stm: ltdc: switch to regmap

2022-01-04 Thread Philippe CORNU
(-) Hi Yannick, many thanks for your patch. Acked-by: Philippe Cornu Reviewed-by: Philippe Cornu Philippe :-)

Re: [PATCH 2/5] drm/stm: ltdc: add YCbCr 422 output support

2022-01-04 Thread Philippe CORNU
, 44 insertions(+), 1 deletion(-) Hi Yannick, many thanks for your patch. Acked-by: Philippe Cornu Reviewed-by: Philippe Cornu Philippe :-)

Re: [PATCH 3/5] drm/stm: ltdc: add per plane update support

2022-01-04 Thread Philippe CORNU
+++--- drivers/gpu/drm/stm/ltdc.h | 1 + 2 files changed, 24 insertions(+), 3 deletions(-) Hi Yannick, many thanks for your patch. Acked-by: Philippe Cornu Reviewed-by: Philippe Cornu Philippe :-)

Re: [PATCH 4/5] drm/stm: ltdc: add support of flexible pixel formats

2022-01-04 Thread Philippe CORNU
: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 196 ++--- drivers/gpu/drm/stm/ltdc.h | 5 +- 2 files changed, 145 insertions(+), 56 deletions(-) Hi Yannick, many thanks for your patch. Nice hw feature. Acked-by: Philippe Cornu Reviewed-by: Philippe Cornu

Re: [PATCH 5/5] drm/stm: ltdc: add support of ycbcr pixel formats

2022-01-04 Thread Philippe CORNU
-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 251 +++-- drivers/gpu/drm/stm/ltdc.h | 1 + 2 files changed, 245 insertions(+), 7 deletions(-) Hi Yannick, many thanks for your patch. Nice hw features! Acked-by: Philippe Cornu Reviewed-by: Philippe

Re: [PATCH 1/3] drm/stm: dsi: move lane capability detection in probe()

2022-01-04 Thread Philippe CORNU
Airlie To: Daniel Vetter To: Andrzej Hajda To: Neil Armstrong To: Robert Foss To: Laurent Pinchart To: Jonas Karlman To: Jernej Skrabec To: Yannick Fertre To: Philippe Cornu To: Benjamin Gaignard To: Maxime Coquelin To: Alexandre Torgue To: Philipp Zabel To: dri-devel@lists.freedesktop.org

Re: [PATCH 2/3] drm/bridge/synopsys: dsi: extend the prototype of mode_valid()

2022-01-04 Thread Philippe CORNU
Hajda To: Neil Armstrong To: Robert Foss To: Laurent Pinchart To: Jonas Karlman To: Jernej Skrabec To: Yannick Fertre To: Philippe Cornu To: Benjamin Gaignard To: Maxime Coquelin To: Alexandre Torgue To: Philipp Zabel To: dri-devel@lists.freedesktop.org To: linux-st...@st-md

Re: [PATCH 3/3] drm/stm: dsi: provide the implementation of mode_valid()

2022-01-04 Thread Philippe CORNU
: Andrzej Hajda To: Neil Armstrong To: Robert Foss To: Laurent Pinchart To: Jonas Karlman To: Jernej Skrabec To: Yannick Fertre To: Philippe Cornu To: Benjamin Gaignard To: Maxime Coquelin To: Alexandre Torgue To: Philipp Zabel To: dri-devel@lists.freedesktop.org To: linux-st...@st-md

Re: [PATCH] drm/stm: remove conflicting framebuffers

2022-01-04 Thread Philippe CORNU
On 12/14/21 11:15 AM, Philippe CORNU wrote: On 12/6/21 3:23 PM, Thomas Zimmermann wrote: Hi Am 06.12.21 um 14:47 schrieb Yannick Fertre: In case of using simplefb or another conflicting framebuffer, call drm_aperture_remove_framebuffers() to remove memory allocated. Signed-off-by

Re: [PATCH] drm/stm: ltdc: support of new hardware version

2022-01-04 Thread Philippe CORNU
On 12/14/21 11:19 AM, Philippe CORNU wrote: On 12/3/21 9:56 AM, Yannick Fertre wrote: Add support of new hardware version 0x40100. Signed-off-by: Yannick Fertre ---   drivers/gpu/drm/stm/ltdc.c | 172 ++---   drivers/gpu/drm/stm/ltdc.h |   3 +-   2 files

Re: [PATCH v3 2/6] drm/plane: Fix typo in format_mod_supported documentation

2022-01-13 Thread Philippe CORNU
On 1/7/22 6:26 PM, José Expósito wrote: Hi Simon, On Wed, Jan 05, 2022 at 11:54:43PM +, Simon Ser wrote: Pushed patches 1 & 2 to drm-misc-next. Thanks for your contribution! Thanks a lot for the review and for applying the changes, appreciate it. Is there something that needs to impro

Re: [PATCH 0/5] drm/stm: new features to display controller

2022-01-13 Thread Philippe CORNU
On 12/15/21 10:46 PM, Yannick Fertre wrote: Hello, List of new feature: * Replace the legacy register access by regmap API. * Support of YCbCr 422 output * Update layer shadow registers per plane. * Support of YCbCr output (planar, semiplanar & coplanar) These featues are available only with

[PATCH 0/2] MAINTAINERS: update various stm & sti maintainer names

2022-01-13 Thread Philippe Cornu
NERS: Update Benjamin Gaignard maintainer status Philippe Cornu (1): MAINTAINERS: update drm/stm drm/sti and cec/sti maintainers MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.17.1

[PATCH 2/2] MAINTAINERS: update drm/stm drm/sti and cec/sti maintainers

2022-01-13 Thread Philippe Cornu
Add Alain as sti maintainer for both drm/sti & cec/sti. Add Raphaël as stm maintainer for drm/stm. Signed-off-by: Philippe Cornu --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6bea080d0159..708f8c86e4c9 100644 --- a/MAINTAINERS +

[PATCH 1/2] MAINTAINERS: Update Benjamin Gaignard maintainer status

2022-01-13 Thread Philippe Cornu
DRM DRIVERS FOR STM M: Yannick Fertre M: Philippe Cornu -M: Benjamin Gaignard L: dri-devel@lists.freedesktop.org S: Maintained T: git git://anongit.freedesktop.org/drm/drm-misc @@ -18154,7 +18152,6 @@ F: Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt

Re: [PATCH 1/2] MAINTAINERS: Update Benjamin Gaignard maintainer status

2022-01-14 Thread Philippe CORNU
On 1/13/22 6:19 PM, Philippe Cornu wrote: From: Benjamin Gaignard Update Benjamin Gaignard address and remove it from no more maintained drivers. Signed-off-by: Benjamin Gaignard --- MAINTAINERS | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/MAINTAINERS b

Re: [PATCH 1/2] MAINTAINERS: Update Benjamin Gaignard maintainer status

2022-01-14 Thread Philippe CORNU
On 1/14/22 1:45 AM, Arnd Bergmann wrote: On Thu, Jan 13, 2022 at 6:19 PM Philippe Cornu wrote: DRM DRIVERS FOR STI -M: Benjamin Gaignard L: dri-devel@lists.freedesktop.org S: Maintained T: git git://anongit.freedesktop.org/drm/drm-misc If there is no longer a

Re: [PATCH v2] drm/bridge/synopsys: dsi: Allow VPG to be enabled via debugfs

2019-05-03 Thread Philippe CORNU
Hi Matt, and many thanks for the patch. Tested successfully by Yannick on STM32MP1 boards :-) Tested-by: Yannick Fertré Reviewed-by: Philippe Cornu Thank you, Philippe :-) On 4/30/19 10:17 AM, Matt Redfearn wrote: > The Synopsys MIPI DSI IP contains a video test pattern generator which &

Re: [PATCH v2 1/5] dt-bindings: display: stm32: add supply property to DSI controller

2019-05-10 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, (already ;-) Reviewed-by: Philippe Cornu Philippe :) On 5/10/19 4:20 PM, Yannick Fertré wrote: > This patch adds documentation of a new property phy-dsi-supply to the > STM32 DSI controller. > > Signed-off-by: Yannick Fertré > --- &g

Re: [PATCH v2 2/3] drm/stm: dsi: add support of an optional regulator

2019-05-10 Thread Philippe CORNU
d > dw_mipi_dsi_stm_resume(struct device *dev) > { > struct dw_mipi_dsi_stm *dsi = dw_mipi_dsi_stm_plat_data.priv_data; > + int ret; > > DRM_DEBUG_DRIVER("\n"); > > + ret = regulator_enable(dsi->vdd_supply); > + if (ret) { > + DRM_ERROR("failed to enable regulator: %d\n", ret); > + return ret; > + } > + > clk_prepare_enable(dsi->pllref_clk); for a future patch: we may check clk_prepare_enable return value. > > return 0; > Acked-by: Philippe Cornu Philippe :) ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 3/5] ARM: dts: stm32: add phy-dsi-supply property on stm32mp157c

2019-05-10 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Reviewed-by: Philippe Cornu Philippe :-) On 5/10/19 4:20 PM, Yannick Fertré wrote: > The dsi physical layer is powered by the 1v8 power controller supply. > > Signed-off-by: Yannick Fertré > --- > arch/arm/boot/dts/stm32mp157c.dtsi |

Re: [PATCH] drm/stm: dsi: check hardware version

2019-05-10 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Dear Benjamin, If you are fine with this patch, please push it *after* the patch named "drm/stm: dsi: add support of an optional regulator" (if I well understood those two patches) Thank you Philippe :-) On 5/10/

Re: [PATCH] drm/stm: ltdc: remove clk_round_rate comment

2019-05-10 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, In your patch, you have removed clk_disable() & clk_enable(). Could you please double confirm ? thanks Philippe :-) On 5/10/19 5:03 PM, Yannick Fertré wrote: > Clk_round_rate returns rounded clock without changing > the hardware in any way. > This functio

Re: [PATCH v2 2/3] drm/stm: dsi: add support of an optional regulator

2019-05-13 Thread Philippe CORNU
Hi Yannick, On 5/10/19 6:16 PM, Philippe Cornu wrote: > Dear Yannick, > Thank you for your patch, > > I like better the new shorter commit heading, thank you. > > > On 5/10/19 4:20 PM, Yannick Fertré wrote: >> Add support of an optional regulator for the phy pa

Re: [PATCH v2] drm/stm: ltdc: remove clk_round_rate comment

2019-05-13 Thread Philippe CORNU
Dear Yannick, Acked-by: Philippe Cornu Thank you, Philippe :-) On 5/13/19 3:15 PM, Yannick Fertré wrote: > Clk_round_rate returns rounded clock without changing > the hardware in any way. > This function couldn't replace set_rate/get_rate calls. > Todo comment has been re

Re: [PATCH] drm/stm: ltdc: restore calls to clk_{enable/disable}

2019-05-27 Thread Philippe CORNU
Hi Benjamin, Many thanks for this fix (and more generally for pushing STM patches on misc :-) Acked-by: Philippe Cornu Philippe :-) On 5/27/19 1:58 PM, Benjamin Gaignard wrote: > From: Benjamin Gaignard > > Restore calls to clk_{enable/disable} deleted after applying the wrong >

Re: [PATCH] drm/stm: ltdc: No message if probe

2019-05-27 Thread Philippe CORNU
Hi Yannick, Thank you for your patch Acked-by: Philippe Cornu Philippe :-) On 5/27/19 12:14 PM, Yannick Fertré wrote: > Print display controller hardware version in debug mode only. > > Signed-off-by: Yannick Fertré > --- > drivers/gpu/drm/stm/ltdc.c | 2 +- > 1 file ch

Re: [PATCH v1 1/2] drm/bridge/synopsys: dsi: add power on/off optional phy ops

2019-05-27 Thread Philippe CORNU
Hi Yannick, and thank you for your patch. Tested successfully on stm32f too. Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu Philippe :-) On 5/27/19 12:21 PM, Yannick Fertré wrote: > Add power on & off optional physical operation functions, helpful to > program specific re

Re: [PATCH v1 2/2] drm/stm: dsi: add power on/off phy ops

2019-05-27 Thread Philippe CORNU
Hi Yannick, and thank you for your patch. Tested successfully on stm32f too. Acked-by: Philippe Cornu Tested-by: Philippe Cornu Philippe :-) On 5/27/19 12:21 PM, Yannick Fertré wrote: > These new physical operations are helpful to power_on/off the dsi > wrapper. If the dsi wrapper is p

Re: [PATCH] drm/stm: ltdc: limit number of layer to avoid memory overflow

2019-04-05 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :) On 4/3/19 11:20 AM, Yannick Fertré wrote: > If the number of layer is greater than LTDC_MAX_LAYER, we can have > memory overflow when reading plane_fpsi[]. > > Signed-off-by: Yannick Fertré > --- >

Re: [PATCH] drm/stm: ltdc: reset controller to avoid partial refresh

2019-04-05 Thread Philippe CORNU
usleep_range(10, 20); > - reset_control_deassert(rstc); > - } > - Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :) > /* Disable interrupts */ > reg_clear(ldev->regs, LTDC_IER, > IER_L

Re: [PATCH] drm/stm: ltdc: add modifier support

2019-04-05 Thread Philippe CORNU
if (ret < 0) > return NULL; > > @@ -1179,6 +1196,8 @@ int ltdc_load(struct drm_device *ddev) > goto err; > } > > + ddev->mode_config.allow_fb_modifiers = true; > + Acked-by: Philippe Cornu Philippe :) > ret =

Re: [PATCH v1 1/5] dt-bindings: display: stm32: add supply property to DSI controller

2019-04-05 Thread Philippe CORNU
Example 2: DSI panel > clock-names = "pclk", "ref"; > resets = <&rcc STM32F4_APB2_RESET(DSI)>; > reset-names = "apb"; > + phy-dsi-supply = <

Re: [PATCH v1 2/5] drm/stm: dw_mipi_dsi-stm: add support of an optional regulator

2019-04-05 Thread Philippe CORNU
_supply); > clk_disable_unprepare(dsi->pllref_clk); > return PTR_ERR(dsi->dsi); > } > @@ -351,6 +370,7 @@ static int dw_mipi_dsi_stm_remove(struct platform_device > *pdev) > struct dw_mipi_dsi_stm *dsi = platform_get_drvdata(pdev); >

Re: [PATCH 1/2] drm/stm: ltdc: manage the get_irq probe defer case

2019-04-26 Thread Philippe CORNU
Hi Fabien, and thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 4/24/19 4:03 PM, Fabien Dessenne wrote: > Manage the -EPROBE_DEFER error case for the ltdc IRQ. > > Signed-off-by: Fabien Dessenne > --- > drivers/gpu/drm/stm/ltdc.c | 3 +++ > 1 file cha

Re: [PATCH 2/2] drm/stm: ltdc: return appropriate error code during probe

2019-04-26 Thread Philippe CORNU
Hi Fabien, and thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 4/24/19 4:03 PM, Fabien Dessenne wrote: > During probe, return the "clk_get" error value instead of -ENODEV. > > Signed-off-by: Fabien Dessenne > --- > drivers/gpu/drm/stm/ltdc.c | 5

Re: [PATCH] drm/stm: ltdc: No message if probe

2019-06-07 Thread Philippe CORNU
Hi Yannick, Thank you for your patch Acked-by: Philippe Cornu Philippe :-) On 6/3/19 10:31 AM, Yannick Fertré wrote: > Print display controller hardware version in debug mode only. > > Signed-off-by: Yannick Fertré > --- > drivers/gpu/drm/stm/ltdc.c | 2 +- > 1 file ch

Re: [PATCH] drm/stm: support runtime power management

2019-06-07 Thread Philippe CORNU
Hi Yannick, Thank you for your patch Acked-by: Philippe Cornu Philippe :-) On 6/3/19 10:32 AM, Yannick Fertré wrote: > This patch enables runtime power management (runtime PM) support for > the display controller. pm_runtime_enable() and pm_runtime_disable() > are added during ltdc

Re: [PATCH 30/59] drm/stm: Drop drm_gem_prime_export/import

2019-06-18 Thread Philippe CORNU
Hi Daniel, Acked-by: Philippe Cornu We will have a look to simplify this part of the code. Thank you for your patch. Philippe :-) On 6/14/19 10:35 PM, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_f

Re: [PATCH 1/3] drm/stm: drv: fix suspend/resume

2019-06-18 Thread Philippe CORNU
Hi Yannick, Thank you for your patch. Acked-by: Philippe Cornu Philippe :-) On 6/17/19 9:18 AM, Yannick Fertré wrote: > Without this fix, the system can not go in "suspend" mode > due to an error in drv_suspend function. > > Fixes: 35ab6cf ("drm/stm: suppo

Re: [PATCH 1/3] drm/bridge: sii902x: fix missing reference to mclk clock

2019-07-05 Thread Philippe CORNU
Hi Olivier, and many thanks for your patch. I do not see how audio could work without your patch, so: Reviewed-by: Philippe Cornu Philippe :-) On 7/2/19 5:47 PM, Olivier Moysan wrote: > Add devm_clk_get call to retrieve reference to master clock. > > Fixes: ff5781634c41 ("drm/b

Re: [PATCH 2/3] dt-bindings: display: sii902x: Change audio mclk binding

2019-07-05 Thread Philippe CORNU
s not required." So, even if #sound-dai-cells is there, this is not mandatory to have MCLK. Reviewed-by: Philippe Cornu Philippe :-) On 7/2/19 5:47 PM, Olivier Moysan wrote: > As stated in SiL9022/24 datasheet, master clock is not required for I2S. > Make mclk property optional in DT bind

Re: [PATCH 3/3] drm/bridge: sii902x: make audio mclk optional

2019-07-05 Thread Philippe CORNU
Hi Olivier, and many thanks for your patch. Reviewed-by: Philippe Cornu Philippe :-) On 7/2/19 5:47 PM, Olivier Moysan wrote: > The master clock on i2s bus is not mandatory, > as sii902X internal PLL can be used instead. > Make use of mclk optional. > > Fixes: ff5781634c

Re: [PATCH] drm/bridge: sii902x: add audio graph card support

2019-07-05 Thread Philippe CORNU
Hi Olivier, and many thanks for your patch. Good to have the audio graph card support, looks ok. Reviewed-by: Philippe Cornu Philippe :-) On 7/3/19 10:04 AM, Olivier Moysan wrote: > Implement get_dai_id callback of audio HDMI codec > to support ASoC audio graph card. > HDMI audio outp

Re: [PATCH] drm/stm: dw_mipi_dsi-stm: add sleep power management

2019-03-26 Thread Philippe CORNU
Dear Yannick, Many thanks for your patch. Acked-by: Philippe Cornu Philippe :-) On 3/21/19 9:13 AM, Yannick Fertré wrote: > Implements system sleep power management ops. > > Signed-off-by: Yannick Fertré > --- > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 28 +++

Re: [PATCH] drm/panel: rm68200: no error msg if probe deferred

2019-03-26 Thread Philippe CORNU
Dear Yannick, Many thanks for your patch. Reviewed-by: Philippe Cornu Philippe :-) On 3/21/19 9:05 AM, Yannick Fertré wrote: > Do not print an error message if the regulator framework > returns EPROBE_DEFER. > > Signed-off-by: Yannick Fertré > --- > drivers/gpu/drm/p

Re: [PATCH] drm/stm: add sleep power management

2019-03-26 Thread Philippe CORNU
(+ Benjamin) Dear Yannick, Many thanks for your patch. Acked-by: Philippe Cornu Dear Benjamin, May I ask you please to merge this patch + "drm/stm: dw_mipi_dsi-stm: add sleep power management" on drm-misc, if you agree of course and when you think it is the right time (next week?)

Re: [PATCH] drm/panel: otm8009a: add delay at the end of initialization

2019-03-26 Thread Philippe CORNU
Dear Yannick, Many thanks for your patch. Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu Best regards, Philippe On 3/21/19 9:04 AM, Yannick Fertré wrote: > At the end of initialization, a delay is required by the panel. > Without this delay, the panel could received a frame

Re: [PATCH] drm/panel: otm8009a: set clock to 29.70 Mhz

2019-03-26 Thread Philippe CORNU
Dear Yannick, Many thanks for your patch. Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu Philippe :-) On 3/21/19 9:07 AM, Yannick Fertré wrote: > The panel does not support clock frequency over 30.74 Mhz. > The clock rate has been reduced to 29.70 Mhz & new timings h

Re: [PATCH] drm/panel: otm8009a: no error msg if probe deferred

2019-03-26 Thread Philippe CORNU
Dear Yannick, Many thanks for your patch. Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu Philippe :-) On 3/21/19 9:04 AM, Yannick Fertré wrote: > Do not print an error message if the regulator framework > returns EPROBE_DEFER. > > Signed-off-by: Yannick Fertré > ---

Re: [PATCH] drm/gamma: Clarify gamma lut uapi

2019-03-29 Thread Philippe CORNU
gt; Cc: Maarten Lankhorst > Cc: Harry Wentland > Cc: Leo Li > Cc: amd-...@lists.freedesktop.org > Cc: James (Qian) Wang > Cc: Liviu Dudau > Cc: Mali DP Maintainers > Cc: CK Hu > Cc: Philipp Zabel > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard

Re: [PATCH] drm/stm: ltdc: fix data enable polarity

2019-04-01 Thread Philippe CORNU
AY_FLAGS_DE_LOW but not with DISPLAY_FLAGS_DE_HIGH." With that or something similar Acked-by: Philippe Cornu Philippe :-) >> >> Signed-off-by: Yannick Fertré >> --- >>drivers/gpu/drm/stm/ltdc.c | 2 +- >>1 file changed, 1 insertion(+), 1 deletion(-) &

Re: [PATCH] drm/stm: ltdc: disable hw interrupts before its handler init

2019-04-01 Thread Philippe CORNU
if (irq < 0) > @@ -1138,10 +1142,6 @@ int ltdc_load(struct drm_device *ddev) > reset_control_deassert(rstc); > } > > - /* Disable interrupts */ > - reg_clear(ldev->regs, LTDC_IER, > - IER_LIE | IER_RRIE | IER_FUIE | IER_TERRI

Re: [PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages

2019-04-01 Thread Philippe CORNU
Dear Yannick, Fully agree with this approach, Acked-by: Philippe Cornu Philippe :-) On 3/29/19 4:49 PM, Yannick Fertré wrote: > From: Philippe Cornu > > Use DRM_WARN() instead of DRM_DEBUG_DRIVER() to better > inform the user in case of fifo underruns or > transfer errors. >

Re: [PATCH] drm/stm: ltdc: update planes at next vblank to avoid partial refresh

2019-04-01 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, works fine, Acked-by: Philippe Cornu Philippe :-) On 4/1/19 9:24 AM, Yannick Fertré wrote: > Plane updates must be synchronized on vblank with the shadow register > mechanism > to avoid partial refresh on screen. > > Signed-off-by:

Re: [PATCH] drm/bridge: sii902x: add audio graph card support

2019-07-11 Thread Philippe CORNU
Hi Daniel, On 7/10/19 5:27 PM, Daniel Vetter wrote: > On Fri, Jul 05, 2019 at 12:41:03PM +0000, Philippe CORNU wrote: >> Hi Olivier, >> and many thanks for your patch. >> Good to have the audio graph card support, looks ok. >> Reviewed-by: Philippe Cornu > &g

Re: [PATCH] drm/stm: attach gem fence to atomic state

2019-07-19 Thread Philippe CORNU
Hi Lucas & Ahmad, Many thanks for your patch, Tested successfully on stm32mp157-dk2 (weston & drm). Acked-by: Philippe Cornu Tested-by: Philippe Cornu Philippe :-) On 7/12/19 10:42 AM, Lucas Stach wrote: > From: Ahmad Fatoum > > To properly synchronize with other devic

Re: [PATCH 17/23] drm/sti: plane: Remove redundant zpos initialisation

2022-02-10 Thread Philippe CORNU
reset(). Hi Maxime, and many thanks for your patches. Great you added Alain as he is now the drm/sti maintainer (Maintainers file should be updated soon) Minor typo in the commit message as rcar_du_vsp_plane_reset() is not part of drm/sti Reviewed-by: Philippe Cornu Philippe :-) However

Re: [PATCH] drm/stm: ltdc: disable all layers before crtc shutdown

2022-06-27 Thread Philippe CORNU
On 6/3/22 15:41, Yannick Fertre wrote: All plans must be disabled before the CRTC shutdown helping the crtc to restart from a clean situation (without unwanted planes already enable). Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 6 ++ 1 file changed, 6 insertions(+)

Re: [PATCH] drm/stm: ltdc: remove error message about scaling

2022-06-27 Thread Philippe CORNU
On 6/3/22 15:42, Yannick Fertre wrote: Remove error message about scaling & replace it by a debug message to avoid too much error. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/stm/ltdc.c

Re: [PATCH] drm/stm: ltdc: fix various coding-style warnings

2022-06-27 Thread Philippe CORNU
On 6/3/22 15:43, Yannick Fertre wrote: Fix issues reported by checkpatch.pl: - Braces {} should be used on all arms - Blank lines Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.

Re: [PATCH] drm/stm: ltdc: add support of horizontal & vertical mirroring

2022-06-27 Thread Philippe CORNU
On 6/3/22 15:45, Yannick Fertre wrote: Support of vertical & horizontal mirroring features thanks to the plane rotation property. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 163 - drivers/gpu/drm/stm/ltdc.h | 1 + 2 files changed,

Re: [PATCH] drm/stm: ltdc: update hardware error management

2022-06-27 Thread Philippe CORNU
On 6/3/22 15:46, Yannick Fertre wrote: The latest hardware version (0x40100) supports a hardware threshold register (aka FUTR) to trigger a fifo underrun interrupt. A software threshold has been implemented for other hardware versions. The threshold is set to 128 by default. Signed-off-by: Ya

Re: [PATCH] drm/stm: ltdc: add support of the dynamic z-order

2022-06-27 Thread Philippe CORNU
On 6/3/22 15:44, Yannick Fertre wrote: Zpos property is immutable for all hardware versions except the last version (0x40100) which support the blending order feature (dynamic z-order). Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/drv.c | 1 + drivers/gpu/drm/stm/ltdc.c | 23 ++

Re: [PATCH] drm: sti: don't use kernel-doc markers

2022-03-31 Thread Philippe CORNU
On 3/28/22 16:26, Daniel Vetter wrote: On Mon, Mar 28, 2022 at 12:21:16PM +0200, Alain Volmat wrote: Hi Randy, thanks for the patch. Acked-by: Alain Volmat Will Philippe apply this one? Hi, yes I will (probably early next week). Many thanks Philippe Just trying to make sure this won

Re: [PATCH] drm: sti: don't use kernel-doc markers

2022-04-07 Thread Philippe CORNU
On 3/31/22 18:58, Philippe CORNU wrote: On 3/28/22 16:26, Daniel Vetter wrote: On Mon, Mar 28, 2022 at 12:21:16PM +0200, Alain Volmat wrote: Hi Randy, thanks for the patch. Acked-by: Alain Volmat Will Philippe apply this one? Hi, yes I will (probably early next week). Many thanks

Re: [PATCH] stm: ltdc: fix two incorrect NULL checks on list iterator

2022-04-07 Thread Philippe CORNU
On 3/28/22 14:37, Raphael Gallais-Pou wrote: Hello Xiaomeng On 3/27/22 07:53, Xiaomeng Tong wrote: The two bugs are here: if (encoder) { if (bridge && bridge->timings) The list iterator value 'encoder/bridge' will *always* be set and non-NULL by drm_for_each_encoder()/list_f

Re: [PATCH] drm: sti: fix spelling mistake: rejec -> rejection

2022-04-07 Thread Philippe CORNU
On 10/4/19 10:27, Colin King wrote: From: Colin Ian King In other places of the driver the string hdmi_rejection_pll is used instead of the truncated hdmi_rejec_pll, so use this string instead to be consistent. Signed-off-by: Colin Ian King --- drivers/gpu/drm/sti/sti_hdmi.c | 2 +- 1 f

Re: [PATCH v2 1/5] drm/bridge/synopsys: dsi: move phy_ops callbacks around panel enablement

2019-11-12 Thread Philippe CORNU
_phy_ops *phy_ops = dsi->plat_data->phy_ops; > > /* Switch to video mode for panel-bridge enable & panel enable */ > dw_mipi_dsi_set_mode(dsi, MIPI_DSI_MODE_VIDEO); > if (dsi->slave) > dw_mipi_dsi_set_mode(dsi->slave, MIPI_DSI_MODE_VIDEO); &g

Re: [PATCH v4 3/3] dt-bindings: panel: Convert orisetech, otm8009a to json-schema

2020-02-07 Thread Philippe CORNU
..6e6ac995c27b > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/

Re: [PATCH v4 2/3] dt-bindings: panel: Convert raydium,rm68200 to json-schema

2020-02-07 Thread Philippe CORNU
AML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/raydium,rm68200.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Raydium Semiconductor Corporation RM68200 5.5" 720p MIPI-DSI TFT LCD > panel > + > +maintainers: > + - Philippe C

Re: [PATCH v4 1/3] dt-bindings: one file of all simple DSI panels

2020-02-07 Thread Philippe CORNU
Hi Benjamin, and many thanks for this serie. Regarding this patch: Reviewed-by: Philippe Cornu Philippe :-) On 2/6/20 2:33 PM, Benjamin Gaignard wrote: > From: Sam Ravnborg > > To complement panel-simple.yaml, create panel-simple-dsi.yaml. > panel-simple-dsi-yaml are for all simpl

Re: [PATCH 39/52] drm/stm: Drop explicit drm_mode_config_cleanup call

2020-02-20 Thread Philippe CORNU
Hi Daniel, On 2/19/20 11:21 AM, Daniel Vetter wrote: > It's right above the drm_dev_put(). > > Aside: Another driver with a bit much devm_kzalloc, which should > probably use drmm_kzalloc instead ... > > Signed-off-by: Daniel Vetter > Cc: Yannick Fertre > Cc: P

Re: [PATCH] drm/stm: dsi: stm mipi dsi doesn't print error on probe deferral

2020-01-23 Thread Philippe CORNU
Dears Yannick & Etienne, Thank you for your patch, Reviewed-by: Philippe Cornu Philippe :-) On 1/21/20 11:24 AM, Yannick Fertre wrote: > From: Etienne Carriere > > Change DSI driver to not print an error trace when probe > is deferred for a clock resource. > >

Re: [PATCH] drm/bridge/synopsys: dsi: missing post disable

2020-01-23 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Reviewed-by: Philippe Cornu Philippe :-) On 1/21/20 11:24 AM, Yannick Fertre wrote: > From: Yannick Fertré > > Sometime the post_disable function is missing (not registered). > > Signed-off-by: Yannick Fertré > --- > drivers/gp

Re: [PATCH] drm/stm: ltdc: check crtc state before enabling LIE

2020-01-23 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 1/21/20 11:14 AM, Yannick Fertre wrote: > Following investigations of a hardware bug, the LIE interrupt > can occur while the display controller is not activated. > LIE interrupt (vblank) don't hav

Re: [PATCH] drm/stm: ltdc: check number of endpoints

2020-01-23 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 1/21/20 11:14 AM, Yannick Fertre wrote: > Number of endpoints could exceed the fix value MAX_ENDPOINTS(2). > Instead of increase simply this value, the number of endpoint > could be read from device t

Re: [PATCH] drm/stm: ltdc: enable/disable depends on encoder

2020-01-23 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 1/20/20 2:46 PM, Yannick Fertre wrote: > From: Yannick Fertré > > When connected to a dsi host, the ltdc display controller > must send frames only after the end of the dsi panel > initialization

Re: [PATCH] drm/stm: ltdc: add number of interrupts

2020-01-23 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 1/21/20 11:13 AM, Yannick Fertre wrote: > The number of interrupts depends on the ltdc version. > Don't try to get interrupt which not exist, avoiding > kernel warning messages. > > Signed-of

Re: [PATCH v4 15/22] drm/stm: Convert to CRTC VBLANK callbacks

2020-01-24 Thread Philippe CORNU
Dear Thomas, Thank you for your patch, For this stm part, Acked-by: Philippe Cornu Philippe :-) On 1/23/20 2:59 PM, Thomas Zimmermann wrote: > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert stm over. > > S

Re: [PATCH v4 14/22] drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-24 Thread Philippe CORNU
Dear Thomas, Thank you for your patch, For this stm part, Acked-by: Philippe Cornu Philippe :-) On 1/23/20 2:59 PM, Thomas Zimmermann wrote: > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Conve

Re: [PATCH v2] dt-bindings: display: Convert etnaviv to json-schema

2020-01-28 Thread Philippe CORNU
errupts: >>> + maxItems: 1 >>> + >>> + clocks: >>> +items: >>> + - description: AXI/master interface clock >>> + - description: GPU core clock >>> + - description: Shader clock (only required if GPU has feature &

Re: [PATCH] drm/stm: ltdc: move pinctrl to encoder mode set

2019-12-02 Thread Philippe CORNU
Dear Yannick, Thank you for your patch, Acked-by: Philippe Cornu Philippe :-) On 11/27/19 11:23 AM, Yannick Fertre wrote: > From: Yannick Fertré > > The pin control must be set to default as soon as possible to > establish a good video link between tv & bridge hdmi > (

Re: [Linux-stm32] [PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver

2019-12-06 Thread Philippe CORNU
Hi Adrian, And sorry for this late reply. Your patches look good and we ("stm guys") understand that v1.01 is very different to v1.30/31. We are doing our best to review & test your patches and we will go back to you asap. Many thanks, Philippe :-) On 12/2/19 8:33 PM, Adrian Ratiu wrote: > Ha

  1   2   3   4   5   >