Add an optional ddc-i2c-bus phandle property that points to
an I2C master controller that handles the connector DDC pins.
Signed-off-by: Philipp Zabel
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/display/connector/hdmi-connector.txt | 1 +
1 file changed, 1 insertion(+)
diff
The hdmitx_dig_cts clock signal is not a child of tvdpll_445p5m,
but is routed out of the HDMI PHY module.
Signed-off-by: Philipp Zabel
---
drivers/clk/mediatek/clk-mt8173.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/mediatek/clk-mt8173.c
b/drivers/clk/mediatek/clk-mt8173.c
Add an HDMI connector node and enable the devices that are part of the
HDMI display path: cec, dpi0, hdmi_phy, and hdmi0.
Signed-off-by: Philipp Zabel
---
arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 38 +
1 file changed, 38 insertions(+)
diff --git a/arch/arm64
setup this HDMI control bit to enable HDMI output in supervisor mode.
Signed-off-by: Jie Qiu
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/mediatek/mtk_hdmi_hw.c | 12
drivers/gpu/drm/mediatek/mtk_hdmi_regs.h | 1 +
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu
From: CK Hu
This patch adds the device nodes for the HDMI encoder, HDMI PHY,
and HDMI CEC modules.
Signed-off-by: CK Hu
Signed-off-by: Cawa Cheng
Signed-off-by: Jie Qiu
Signed-off-by: Daniel Kurtz
Signed-off-by: Philipp Zabel
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 69
Am Freitag, den 19.02.2016, 16:31 +0800 schrieb Jitao Shi:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> ---
> Changes since v9:
> - replace dev_kmalloc with devm_kmalloc in ps8640_get_modes
> - remove ps_bridge->dsi = devm_kzalloc(dev, si
Am Freitag, den 19.02.2016, 16:31 +0800 schrieb Jitao Shi:
> Add documentation for DT properties supported by
> ps8640 DSI-eDP converter.
>
> Signed-off-by: Jitao Shi
> Acked-by: Rob Herring
> Reviewed-by: Philipp Zabel
> ---
> Changes since v9:
> - No change
>
Reset IPU before activating IRQ
Enrico Jorns (1):
drm/imx: Add missing DRM_FORMAT_RGB565 to ipu_plane_formats
Lucas Stach (1):
drm/imx: notify DRM core about CRTC vblank state
Philipp Zabel (1):
gpu: ipu-v3: Do not bail out on missing optional port nodes
drivers/gpu/drm/imx/
Hi John,
Am Montag, den 22.02.2016, 14:14 + schrieb John Keeping:
> Hi,
>
> Is there a reason why endpoints in a device tree graph can't be
> disabled?
You can always remove them using /delete-node/, which also has the
advantage of reminding you not to leave a single dangling endpoint.
> I
Let ipu_cpmem_set_yuv_planar_full take a DRM_FORMAT instead of a
V4L2_PIXFMT and allow better control over U/V stride, U offset and
V offset settings in the CPMEM.
Signed-off-by: Philipp Zabel
---
drivers/gpu/ipu-v3/ipu-cpmem.c | 79 +++---
include/video/imx
check all values against IDMAC limitations.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/ipuv3-plane.c | 103 +-
drivers/gpu/drm/imx/ipuv3-plane.h | 4 ++
2 files changed, 95 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/imx/ipuv3
The driver already advertises multi-planar YUV support, but
previously the U/V offset and stride setup was missing.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/ipuv3-plane.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c
b/drivers
Am Dienstag, den 23.02.2016, 15:30 -0800 schrieb Stefan Agner:
> Any comments on this?
None other that I'm all in favor. consider patch 2
Acked-by: Philipp Zabel
> Also added Manfred, Tomi and Boris to CC which previously attended in
> similar discussions.
>
> Previous
splay subsystem related nodes
arm64: dts: mt8173: Add HDMI related nodes
Jie Qiu (3):
drm/mediatek: Add DPI sub driver
drm/mediatek: Add HDMI support
drm/mediatek: enable hdmi output control bit
Philipp Zabel (5):
dt-bindings: drm/mediatek: Add Mediatek HDMI dts binding
clk: mediatek: make d
From: CK Hu
Add device tree binding documentation for the display subsystem in
Mediatek MT8173 SoCs.
Signed-off-by: CK Hu
Signed-off-by: Philipp Zabel
Acked-by: Rob Herring
---
Changes since v7:
- Add 26 MHz PLL reference input clocks and DSI high-speed output clocks
to the MIPI TX D-PHY
: Philipp Zabel
---
Changes since v7:
- Move PANEL and MIPI_DSI config selection to later patches
- Sort object files alphabetically in Makefile
- Drop mtk_crtc->pipe, use drm_crtc_handle_vblank instead
- Move copied event from mtk_crtc_state back to mtk_crtc
- Wait for exclusive fences on incom
From: CK Hu
This patch add a drm encoder/connector driver for the MIPI DSI function
block of the Mediatek display subsystem and a phy driver for the MIPI TX
D-PHY control module.
Signed-off-by: Jitao Shi
Signed-off-by: Philipp Zabel
---
Changes since v7:
- Select the PANEL and MIPI_DSI
Add the device tree binding documentation for Mediatek HDMI,
HDMI PHY and HDMI DDC devices.
Signed-off-by: Philipp Zabel
Acked-by: Rob Herring
---
Changes since v7:
- Add the HDMI PLL clock output that is fed back into the
TOP clock module.
- Switch the hdmi_sel mux to it in the example
From: Jie Qiu
Add DPI connector/encoder to support HDMI output via the
attached HDMI bridge.
Signed-off-by: Jie Qiu
Signed-off-by: Philipp Zabel
---
Changes since v7:
- Fix mtk_dpi_power_on reference counting
- Make mtk_dpi_power_off return void
---
drivers/gpu/drm/mediatek/Makefile
From: Jie Qiu
This patch adds drivers for the HDMI bridge connected to the DPI0
display subsystem function block, for the HDMI DDC block, and for
the HDMI PHY to support HDMI output.
Signed-off-by: Jie Qiu
Signed-off-by: Philipp Zabel
---
Changes since v7:
- Fill ELD info
- Fix error
setup this HDMI control bit to enable HDMI output in supervisor mode.
Signed-off-by: Jie Qiu
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/mediatek/mtk_hdmi_hw.c | 11 +++
drivers/gpu/drm/mediatek/mtk_hdmi_regs.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/gpu
From: CK Hu
This patch adds the device nodes for the DISP function blocks
comprising the display subsystem.
Signed-off-by: CK Hu
Signed-off-by: Cawa Cheng
Signed-off-by: Jie Qiu
Signed-off-by: Daniel Kurtz
Signed-off-by: Philipp Zabel
---
Changes since v7:
- Add 26 MHz PLL reference input
This mux is supposed to select a fitting divider after the PLL
is already set to the correct rate.
Signed-off-by: Philipp Zabel
Acked-by: James Liao
---
Changes since v7:
- The hdmi_sel mux is kept to propagate rate changes,
selecting the divider from the driver would only be necessary
From: CK Hu
This patch adds the device nodes for the HDMI encoder, HDMI PHY,
and HDMI CEC modules.
Signed-off-by: CK Hu
Signed-off-by: Cawa Cheng
Signed-off-by: Jie Qiu
Signed-off-by: Daniel Kurtz
Signed-off-by: Philipp Zabel
---
Changes since v7:
- Describe HDMI PHY PLL output in the
The configurable hdmi_ref output of the PLL block is derived from
the tvdpll_594m clock signal via a configurable PLL post-divider.
It is used as the PLL reference input to the HDMI PHY module.
Signed-off-by: Philipp Zabel
Acked-by: James Liao
---
drivers/clk/mediatek/clk-mt8173.c | 5
Add an optional ddc-i2c-bus phandle property that points to
an I2C master controller that handles the connector DDC pins.
Signed-off-by: Philipp Zabel
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/display/connector/hdmi-connector.txt | 1 +
1 file changed, 1 insertion(+)
diff
The hdmitx_dig_cts clock signal is not a child of tvdpll_445p5m,
but is routed out of the HDMI PHY module.
Signed-off-by: Philipp Zabel
---
drivers/clk/mediatek/clk-mt8173.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/mediatek/clk-mt8173.c
b/drivers/clk/mediatek/clk-mt8173.c
Am Dienstag, den 29.12.2015, 16:49 +0800 schrieb Yingjoe Chen:
> On Mon, 2015-11-30 at 22:07 +0100, Philipp Zabel wrote:
> > From: Jie Qiu
> >
> > This patch adds drivers for the HDMI bridge connected to the DPI0
> > display subsystem function block, for the HDMI DDC
The port nodes are documented as optional, treat them accordingly.
Reported-by: Martin Fuzzey
Signed-off-by: Philipp Zabel
Fixes: 304e6be652e2 ("gpu: ipu-v3: Assign of_node of child platform devices to
corresponding ports")
---
drivers/gpu/ipu-v3/ipu-common.c | 9 +
1 file
Am Donnerstag, den 07.01.2016, 17:02 +0800 schrieb Yakir Yang:
> RK3229 integrate an DesignedWare HDMI2.0 controller and an INNO HDMI2.0 phy,
> the max output resolution is 4K.
>
> Signed-off-by: Yakir Yang
It sounds like the INNO HDMI2.0 phy is not necessarily specific to
RK3229 but might also
Hi Yakir,
Am Donnerstag, den 07.01.2016, 18:15 +0800 schrieb Yakir Yang:
> Hi Philipp,
>
> Thanks for your fast respond :)
>
> On 01/07/2016 06:04 PM, Philipp Zabel wrote:
> > Am Donnerstag, den 07.01.2016, 17:02 +0800 schrieb Yakir Yang:
> >> RK3229 integrate an D
From: Sascha Hauer
Instead of rereading the edid data each time userspace asks for them,
read them once and cache them in the previously unused edid field in
struct dw_hdmi. When the connector is disconnected, drop the cached
edid data.
Signed-off-by: Sascha Hauer
Signed-off-by: Philipp Zabel
From: Sascha Hauer
The cable_plugin field in struct dw_hdmi is never set. Remove it and with
it all code that is only executed when the variable is true.
Signed-off-by: Sascha Hauer
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/bridge/dw-hdmi.c | 17 -
1 file changed, 17
Allow userspace to read the initial connector state via sysfs without
having to issue a detect manually. There is no reason to keep the state
unknown during initialization.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/bridge/dw-hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a
Due to the voltage divider on the HPD line, the HDMI connector on
imx6q-sabrelite doesn't reliably detect connected DVI monitors.
This patch allows to use the RX_SENSE signals as a workaround when
enabled by a boolean device tree property 'hpd-unreliable'.
Signed-off-by
Am Freitag, den 08.01.2016, 11:24 + schrieb Russell King - ARM
Linux:
> On Fri, Jan 08, 2016 at 10:02:06AM +0100, Philipp Zabel wrote:
> > Allow userspace to read the initial connector state via sysfs without
> > having to issue a detect manually. There is no reason to
l this confused code without ill side-effects.
>
> Someone else needs to audit the locking for ->newfb and
> ->page_flip_event and fix it up. Common approach is to reuse
> dev->event_lock for this.
>
> Cc: Sascha Hauer
> Cc: Philipp Zabel
> Acked-by: Daniel S
ts: mt8173: Add HDMI related nodes
drm/mediatek: Add interface to allocate Mediatek GEM buffer.
Jie Qiu (3):
drm/mediatek: Add DPI sub driver
drm/mediatek: Add HDMI support
drm/mediatek: enable hdmi output control bit
Philipp Zabel (5):
dt-bindings: drm/mediatek: Add Mediatek HDMI dt
From: CK Hu
Add device tree binding documentation for the display subsystem in
Mediatek MT8173 SoCs.
Signed-off-by: CK Hu
Signed-off-by: Philipp Zabel
Acked-by: Rob Herring
---
.../bindings/display/mediatek/mediatek,disp.txt| 203 +
.../bindings/display/mediatek
From: CK Hu
This patch add a drm encoder/connector driver for the MIPI DSI function
block of the Mediatek display subsystem and a phy driver for the MIPI TX
D-PHY control module.
Signed-off-by: Jitao Shi
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/mediatek/Kconfig | 3 +
drivers
: Philipp Zabel
---
drivers/gpu/drm/Kconfig | 2 +
drivers/gpu/drm/Makefile| 1 +
drivers/gpu/drm/mediatek/Kconfig| 12 +
drivers/gpu/drm/mediatek/Makefile | 10 +
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 301
From: Jie Qiu
Add DPI connector/encoder to support HDMI output via the
attached HDMI bridge.
Signed-off-by: Jie Qiu
Signed-off-by: Philipp Zabel
---
Changes since v8:
- Fixed a DPI enable/disable and suspend/resume power count problem
---
drivers/gpu/drm/mediatek/Makefile | 3
Add the device tree binding documentation for Mediatek HDMI,
HDMI PHY and HDMI DDC devices.
Signed-off-by: Philipp Zabel
Acked-by: Rob Herring
---
.../bindings/display/mediatek/mediatek,hdmi.txt| 148 +
1 file changed, 148 insertions(+)
create mode 100644
From: Jie Qiu
This patch adds drivers for the HDMI bridge connected to the DPI0
display subsystem function block, for the HDMI DDC block, and for
the HDMI PHY to support HDMI output.
Signed-off-by: Jie Qiu
Signed-off-by: Philipp Zabel
---
Changes since v8:
- Reworked N, CTS setup (use
setup this HDMI control bit to enable HDMI output in supervisor mode.
Signed-off-by: Jie Qiu
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/mediatek/mtk_hdmi_hw.c | 11 +++
drivers/gpu/drm/mediatek/mtk_hdmi_regs.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/gpu
From: CK Hu
This patch adds the device nodes for the DISP function blocks
comprising the display subsystem.
Signed-off-by: CK Hu
Signed-off-by: Cawa Cheng
Signed-off-by: Jie Qiu
Signed-off-by: Daniel Kurtz
Signed-off-by: Philipp Zabel
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 237
From: CK Hu
This patch adds the device nodes for the HDMI encoder, HDMI PHY,
and HDMI CEC modules.
Signed-off-by: CK Hu
Signed-off-by: Cawa Cheng
Signed-off-by: Jie Qiu
Signed-off-by: Daniel Kurtz
Signed-off-by: Philipp Zabel
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 75
This mux is supposed to select a fitting divider after the PLL
is already set to the correct rate.
Signed-off-by: Philipp Zabel
Acked-by: James Liao
---
drivers/clk/mediatek/clk-mt8173.c | 2 +-
drivers/clk/mediatek/clk-mtk.h| 7 +--
2 files changed, 6 insertions(+), 3 deletions
The configurable hdmi_ref output of the PLL block is derived from
the tvdpll_594m clock signal via a configurable PLL post-divider.
It is used as the PLL reference input to the HDMI PHY module.
Signed-off-by: Philipp Zabel
Acked-by: James Liao
---
drivers/clk/mediatek/clk-mt8173.c | 5
The hdmitx_dig_cts clock signal is not a child of tvdpll_445p5m,
but is routed out of the HDMI PHY module.
Signed-off-by: Philipp Zabel
---
drivers/clk/mediatek/clk-mt8173.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/mediatek/clk-mt8173.c
b/drivers/clk/mediatek/clk-mt8173.c
Add an optional ddc-i2c-bus phandle property that points to
an I2C master controller that handles the connector DDC pins.
Signed-off-by: Philipp Zabel
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/display/connector/hdmi-connector.txt | 1 +
1 file changed, 1 insertion(+)
diff
From: CK Hu
Add an interface to allocate Mediatek GEM buffers, allow the IOCTLs
to be used by render nodes.
This patch also sets the RENDER driver feature.
Signed-off-by: CK Hu
Signed-off-by: Nicolas Boichat
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 13
Am Dienstag, den 12.01.2016, 23:40 +0100 schrieb Daniel Vetter:
> On Tue, Jan 12, 2016 at 11:02 PM, Rob Herring wrote:
> > On Tue, Jan 12, 2016 at 9:15 AM, Philipp Zabel
> > wrote:
> >> From: CK Hu
> >>
> >> Add an interface to allocate Mediatek GEM bu
Hi Maxime,
Am Donnerstag, den 14.01.2016, 16:24 +0100 schrieb Maxime Ripard:
> The core currently doesn't check that the DT cell size matches what the
> driver declares, which means that every xlate function needs to duplicate
> that check.
>
> Make sure that of_reset_control_get checks for this
Am Donnerstag, den 14.01.2016, 16:24 +0100 schrieb Maxime Ripard:
> The ops pointer is holding a pointer to a structure that is usually not
> modified. Make it const.
>
> Signed-off-by: Maxime Ripard
> ---
> include/linux/reset-controller.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Martin,
On Tue, 2020-07-07 at 17:56 +0200, Martin Fuzzey wrote:
> When performing a modeset the atomic core calls
> ipu_crtc_atomic_disable() which switches off the DC and DI.
>
> When we immediately restart as in the modeset case this sometimes
> leads to corruption at the bottom of the scree
: Move imx-drm driver out of staging")
> Cc: Philipp Zabel
> Cc: Sascha Hauer
> Cc: Pengutronix Kernel Team
> Cc: NXP Linux Team
> Cc:
> Signed-off-by: Liu Ying
Thank you, applied to imx-drm/next.
regards
Philipp
___
d
On Thu, 2020-06-11 at 14:43 +0200, Marco Felsch wrote:
> From: Philipp Zabel
>
> Component driver structures allocated with devm_kmalloc() in bind() are
> freed automatically after unbind(). Since the contained drm structures
> are accessed afterwards in drm_mode_config_clea
On Sun, 2020-04-05 at 11:16 +0200, Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 5 Apr 2020 11:01:49 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected b
ess enum
drm/imx: parallel-display: move panel/bridge detection to fail early
Marek Vasut (1):
drm/imx: parallel-display: Adjust bus_flags handling
Markus Elfring (1):
drm/imx: imx-tve: Delete an error message in imx_tve_bind()
Philipp Zabel (1):
drm/imx: fix use after f
Hi Laurentiu,
On Tue, 2020-07-21 at 13:20 +0300, Laurentiu Palcu wrote:
> From: Laurentiu Palcu
>
> This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS).
> Some of its capabilities include:
> * 4K@60fps;
> * HDR10;
> * one graphics and 2 video pipelines;
> * on-the-fly
ipu_mbus_code_to_colorspace, ipu_stride_to_bytes, and
ipu_pixelformat_is_planar are unused. Remove them.
Signed-off-by: Philipp Zabel
---
drivers/gpu/ipu-v3/ipu-common.c | 67 -
include/video/imx-ipu-v3.h | 3 --
2 files changed, 70 deletions(-)
diff --git
This is the same code and comment that is already shared by imx-ldb,
imx-tve, and parallel-display in imx_drm_encoder_parse_of().
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/dw_hdmi-imx.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm
The drm_panel_attach/detach() functions are empty since
commit aa6c43644bc5 ("drm/panel: drop drm_device from drm_panel"),
remove them.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/imx-ldb.c | 10 --
drivers/gpu/drm/imx/parallel-display.c | 6 --
2 fil
The DRM core already takes care that encoder enable and disable calls
are balanced.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/imx-tve.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
Replace the custom spinlock with the fast_io spinlock provided by
regmap.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/imx-tve.c | 22 +-
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index
the memory is
freed.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/drm_simple_kms_helper.c | 42 +
include/drm/drm_simple_kms_helper.h | 4 +++
2 files changed, 46 insertions(+)
diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c
b/drivers/gpu/drm
Move bridge creation into probe, during bind only create the encoder and
attach the bridge.
Use drmm_kzalloc() to align encoder memory lifetime with the drm device,
and use drmm_add_action_or_reset() to make sure drm_encoder_cleanup() is
called before the memory is freed.
Signed-off-by: Philipp
Use drm managed resources to get and put IPU resources automatically.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/ipuv3-crtc.c | 25 +
drivers/gpu/drm/imx/ipuv3-plane.c | 29 -
drivers/gpu/drm/imx/ipuv3-plane.h | 3 ---
3 files
Use drmm_kzalloc() to align plane memory lifetime with the drm device,
and use drmm_add_action_or_reset() to make sure drm_plane_cleanup() is
called before the memory is freed. Also handle error return values of
the plane property creation functions.
Signed-off-by: Philipp Zabel
---
drivers/gpu
Move devres regmap, clock, and interrupt requests into probe.
Use drmm_kzalloc() to align encoder memory lifetime with the drm device,
and use drmm_add_action_or_reset() to make sure drm_encoder_cleanup() is
called before the memory is freed.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx
Use drmm_kzalloc() to align crtc memory lifetime with the drm device,
and use drmm_add_action_or_reset() to make sure IPU resources are
released and drm_crtc_cleanup() is called before the memory is freed.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/ipuv3-crtc.c | 75
Use drmm_mode_config_init() and drop the explicit calls to
drm_mode_config_cleanup().
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/imx-drm-core.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c
b/drivers/gpu/drm/imx/imx
Use drmm_kzalloc() to align encoder memory lifetime with the drm device,
and use drmm_add_action_or_reset() to make sure drm_encoder_cleanup() is
called before the memory is freed.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/parallel-display.c | 50 +-
1 file
Use drmm_kzalloc() to align encoder memory lifetime with the drm device,
and use drmm_add_action_or_reset() to make sure drm_encoder_cleanup() is
called before the memory is freed.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/imx-ldb.c | 67 +++
1 file
Add YCbCr encoding and quantization range parameters to
ipu_dp_setup_channel() and configure the CSC DP matrix
accordingly.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/ipuv3-plane.c | 9 ++---
drivers/gpu/ipu-v3/ipu-dp.c | 25 ++---
include/video/imx-ipu
Add COLOR_ENCODING and COLOR_RANGE plane properties and use them to
control the DP CSC matrix.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/ipuv3-plane.c | 44 +--
1 file changed, 30 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/imx/ipuv3
On Wed, 2020-07-22 at 15:30 +0200, Philipp Zabel wrote:
[...]
> and use drmm_add_action_or_reset() to make sure drm_encoder_cleanup() is
> called before the memory is freed.
[...]
> @@ -259,6 +259,13 @@ static const struct drm_bridge_funcs imx_pd_bri
Hi Thomas,
thank you for your comment.
On Wed, 2020-07-22 at 16:43 +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 22.07.20 um 15:25 schrieb Philipp Zabel:
> > Add a drm_simple_encoder_init() variant that registers
> > drm_encoder_cleanup() with drmm_add_action().
> >
callback, so the main
driver must call drmm_mode_config_init() before binding all components.
The bind callback also is the first place where the component drivers
get to know the drm device, so it is not possible to use drmm_kzalloc()
any earlier.
> Am 22.07.20 um 15:25 schrieb
Hi Daniel,
On Thu, 2020-07-23 at 00:22 +0200, dan...@ffwll.ch wrote:
[...]
> Yeah the drmm_ versions of these need to check that the ->cleanup hook is
> NULL.
>
> Also there's not actually a double-free, since drm_foo_cleanup removes it
> from the lists, which means drm_mode_config_cleanup won't e
Add a drm_simple_encoder_init() variant that allocates an encoder with
drmm_kzalloc() and registers drm_encoder_cleanup() with
drmm_add_action_or_reset().
Signed-off-by: Philipp Zabel
---
Changes since v1:
- based on drmm_encoder_init
- use AE initialize spelling
- fold allocation into drmm_
Add a drm_encoder_init() variant that allocates an encoder with
drmm_kzalloc() and registers drm_encoder_cleanup() with
drmm_add_action_or_reset().
Signed-off-by: Philipp Zabel
---
New in v2
---
drivers/gpu/drm/drm_encoder.c | 101 ++
include/drm/drm_encoder.h
Hi Thomas,
On Fri, 2020-07-24 at 09:17 +0200, Thomas Zimmermann wrote:
[...]
> > > > @@ -71,6 +72,47 @@ int drm_simple_encoder_init(struct drm_device *dev,
> > > > }
> > > > EXPORT_SYMBOL(drm_simple_encoder_init);
> > > >
> > > > +static void drmm_encoder_cleanup(struct drm_device *dev, void *
On Thu, 2020-07-23 at 16:56 +0200, Philipp Zabel wrote:
> Add a drm_encoder_init() variant that allocates an encoder with
> drmm_kzalloc() and registers drm_encoder_cleanup() with
> drmm_add_action_or_reset().
>
> Signed-off-by: Philipp Zabel
> ---
> New in v2
>
le driver data.
>
> Cc: Philipp Zabel
> Signed-off-by: Maxime Ripard
> ---
> drivers/reset/reset-simple.c | 24
> include/linux/reset/reset-simple.h | 6 ++
> 2 files changed, 30 insertions(+)
>
> diff --git a/drivers/reset/rese
On Fri, 2020-04-24 at 17:34 +0200, Maxime Ripard wrote:
> The reset-simple code can be useful for drivers outside of drivers/reset
> that have a few reset controls as part of their features. Let's move it to
> include/linux/reset.
>
> Cc: Philipp Zabel
> Signed-off-by: M
On Mon, 2020-10-26 at 20:41 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> clang warns about functions returning a 'const int' result:
>
> drivers/gpu/drm/imx/imx-tve.c:487:8: warning: type qualifiers ignored on
> function return type [-Wignored-qualifiers]
>
> Remove the extraneous 'co
Marco Felsch (1):
drm/imx: parallel-display: fix edid memory leak
Philipp Zabel (9):
gpu: ipu-v3: remove unused functions
drm/imx: dw_hdmi-imx: use imx_drm_encoder_parse_of
drm/imx: imx-tve: use regmap fast_io spinlock
drm/imx: imx-tve: remove redundant enable tracking
Hi Russell,
On Thu, 2020-06-11 at 14:01 +0100, Russell King - ARM Linux admin wrote:
> On Thu, Jun 11, 2020 at 02:43:31PM +0200, Marco Felsch wrote:
> > From: Philipp Zabel
> >
> > Component driver structures allocated with devm_kmalloc() in bind() are
> > freed
txt.
> +Documentation/devicetree/bindings/clock/imx5-clock.yaml, and in
> +Documentation/devicetree/bindings/clock/imx6q-clock.yaml.
>
> Optional properties:
> - pinctrl-names : should be "default" on i.MX53, not used on i.MX6q
Reviewed-by: Philipp Zabel
regards
Philipp
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
ts")
> Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
regards
Philipp
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, 2020-06-17 at 15:40 -0700, Steve Longerbeam wrote:
> Combine the rotate_irq() and norotate_irq() handlers into a single
> eof_irq() handler.
>
> Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
regards
Philipp
> ---
> drivers/gpu/ipu-v3/ipu-im
Hi Steve,
On Thu, 2020-06-25 at 11:13 -0700, Steve Longerbeam wrote:
> Use a bit-mask of EOF irqs to determine when all required idmac
> channel EOFs have been received for a tile conversion, and only do
> tile completion processing after all EOFs have been received. Otherwise
> it was found that
eans vblank state isn't ill-defined and fail-y at driver load
> > > before the first modeset on each crtc.
> > >
> > > Signed-off-by: Daniel Vetter
> > > Cc: Philipp Zabel
> > > Cc: Shawn Guo
> > > Cc: Sascha Hauer
> > > Cc:
Hi Daniel,
On Wed, 2020-09-16 at 11:08 +0200, Daniel Vetter wrote:
> On Fri, Sep 11, 2020 at 03:57:22PM +0200, Philipp Zabel wrote:
> > This allows to drop the custom drm_encoder_cleanup() actions.
> >
> > Signed-off-by: Philipp Zabel
> > ---
> >
Hi Bernard,
On Mon, 2020-09-21 at 19:11 +0800, Bernard wrote:
> This change will speed-up a bit these ipu_idmac_get &
> ipu_idmac_put processing and there is no need to protect
> kzalloc & kfree.
I don't think that will be measurable, the channel lock is very unlikely
to be contended. It might ma
RR(pfdev->rstc));
> return PTR_ERR(pfdev->rstc);
> }
>
> - err = reset_control_deassert(pfdev->rstc);
> - if (err)
> - return err;
> -
> - return 0;
> + return reset_control_deassert(pfdev->
Add an alternative to drm_encoder_init() that allocates and initializes
an encoder and registers drm_encoder_cleanup() with
drmm_add_action_or_reset().
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/drm_encoder.c | 104 ++
include/drm/drm_encoder.h | 30
Add an alternative to drm_universal_plane_init() that allocates
and initializes a plane and registers drm_plane_cleanup() with
drmm_add_action_or_reset().
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/drm_plane.c | 127
include/drm/drm_plane.h | 42
601 - 700 of 1925 matches
Mail list logo
