Re: [PATCH] dt-bindings: Remove "status" from schema examples

2021-07-21 Thread Philipp Zabel
required property > From schema: schemas/phy/phy-provider.yaml > > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Rui Miguel Silva > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: "David S. Miller" &

Re: [PATCH] Fix i.MX IPU-v3 offset calculations for (semi)planar U/V formats

2021-07-27 Thread Philipp Zabel
On Mon, 2021-06-07 at 12:49 +0200, Krzysztof Hałasa wrote: > Video captured in 1400x1050 resolution (bytesperline aka stride = 1408 > bytes) is invalid. Fix it. > > Signed-off-by: Krzysztof Halasa Thank you, I've prefixed the subject with "gpu: ipu-v3:" and applied to imx-drm/next. regards Phil

Re: [PATCH v2] gpu: ipu-v3: use swap()

2021-07-27 Thread Philipp Zabel
On Tue, 2021-07-13 at 15:05 +0100, Salah Triki wrote: > Use swap() instead of implementing it since it makes code cleaner. > > Signed-off-by: Salah Triki > --- > > Changes since v1: > - Remove the declaration of tmp > - Fix typo in the description Thank you, I've changed the subject

Re: [PATCH 3/7] drm/imx/dcss: Enable COMPILE_TEST on all ARM64 platforms

2021-07-30 Thread Philipp Zabel
On Fri, 2021-07-30 at 14:10 +0200, Geert Uytterhoeven wrote: > Hi Laurent, > > On Wed, Jul 28, 2021 at 5:37 PM Laurent Pinchart > wrote: > > To extend test coverage, relax the dependency on ARCH_MXC to also enable > > compilation when COMPILE_TEST is selected. > > > > Signed-off-by: Laurent Pinc

[PATCH] drm/imx: ipuv3-plane: fix accidental partial revert of 8 pixel alignment fix

2021-08-16 Thread Philipp Zabel
ing and range properties") Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 8710f55d2579..bd1f9f0366d3 100644 --- a/drivers/gpu/drm/i

[GIT PULL] drm/imx: fixes for v5.14

2021-08-23 Thread Philipp Zabel
94dfec48fca7 ("drm/imx: Add 8 pixel alignment fix") and plane offset calculations for capture of non-aligned resolutions. Krzysztof Hałasa (1): gpu: ipu-v3: Fix i.MX IPU-v3 offset calculations for (semi)planar U/V format

Re: [PATCH v4 10/17] soc: mediatek: mmsys: Add reset controller support for MT8195 vdosys1

2021-08-25 Thread Philipp Zabel
Hi, On Wed, 2021-08-25 at 18:05 +0800, Nancy.Lin wrote: > Among other features the mmsys driver should implement a reset > controller to be able to reset different bits from their space. > > For MT8195 vdosys1, many async modules need to reset after > the display pipe stops and restart. > > Sign

Re: [PATCH] drm/imx: fix memory leak when fails to init

2021-03-25 Thread Philipp Zabel
On Wed, Jan 20, 2021 at 01:16:08AM -0800, Pan Bian wrote: > Put DRM device on initialization failure path rather than directly > return error code. > > Fixes: a67d5088ceb8 ("drm/imx: drop explicit drm_mode_config_cleanup") > Signed-off-by: Pan Bian Thank you, applied to imx-drm/fixes. regards P

Re: [PATCH] drm/imx: imx-ldb: Register LDB channel1 when it is the only channel to be used

2021-03-25 Thread Philipp Zabel
On Mon, Mar 22, 2021 at 10:56:40AM +0800, Liu Ying wrote: > LDB channel1 should be registered if it is the only channel to be used. > Without this patch, imx_ldb_bind() would skip registering LDB channel1 > if LDB channel0 is not used, no matter LDB channel1 needs to be used or > not. > > Fixes: 8

Re: [PATCH] [v3] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-25 Thread Philipp Zabel
On Thu, Mar 25, 2021 at 10:03:23AM +0800, Liu Ying wrote: > On Wed, 2021-03-24 at 17:47 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When CONFIG_OF is disabled, building with 'make W=1' produces warnings > > about out of bounds array access: > > > > drivers/gpu/drm/imx/imx-ldb.c:

[GIT PULL] drm/imx: fixes for v5.12

2021-04-01 Thread Philipp Zabel
Hi Dave, Daniel, this PR includes a regression fix for the imx-ldb driver, which fails to register channel 1 if channel 0 is disabled since v5.12-rc2. Also, there's an imx-ldb build warning fix for W=1 builds and a fix for a memory leak in the imx-drm-core bind error path. The following changes s

Re: [PATCH v4 4/7] dt-bindings: display: imx: hdmi: Convert binding to YAML

2021-01-14 Thread Philipp Zabel
.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX6 DWC HDMI TX Encoder > + > +maintainers: > + - Philipp Zabel Acked-by: Philipp Zabel regards Philipp ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/imx: ipuv3-plane: do not advertise YUV formats on planes without CSC

2021-01-19 Thread Philipp Zabel
Only planes that are displayed via the Display Processor (DP) path support color space conversion. Limit formats on planes that are shown via the direct Display Controller (DC) path to RGB. Reported-by: Fabio Estevam Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 41

Re: [PATCH 4/7] media: hantro: imx: remove unused include

2021-03-08 Thread Philipp Zabel
Hi Emil, On Fri, Mar 05, 2021 at 06:39:21PM +, Emil Velikov wrote: > From: Emil Velikov > > The current imx8 code does not use the jpeg encoder. Remove the > unnecessary include. > > Cc: Ezequiel Garcia > Cc: Philipp Zabel > Cc: linux-me...@vger.kern

Re: [PATCH 5/7] media: hantro: introduce hantro_g1.c for common API

2021-03-08 Thread Philipp Zabel
Garcia > Cc: Philipp Zabel > Cc: linux-me...@vger.kernel.org > Cc: linux-rockc...@lists.infradead.org > Signed-off-by: Emil Velikov Reviewed-by: Philipp Zabel regards Philipp ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [PATCHv2 2/5] drm/imx: Add 8 pixel alignment fix

2021-05-10 Thread Philipp Zabel
Hi Sebastian, On Thu, 2021-04-29 at 00:29 +0200, Sebastian Reichel wrote: > Some standard resolutions like 1366x768 do not work properly with > i.MX6 SoCs, since the horizontal resolution needs to be aligned > to 8 pixels (so 1360x768 or 1368x768 would work). > > This patch allocates framebuffers

Re: [PATCH] drm/imx: ipuv3-plane: use drm managed resources

2021-05-10 Thread Philipp Zabel
Hi Lucas, On Mon, 2021-05-10 at 16:29 +0200, Lucas Stach wrote: > The conversion to drm managed resources introduced two bugs: the plane is now > always initialized with the linear-only list, while the list with the Vivante > GPU modifiers should have been used when the PRG/PRE engines are present

Re: [PATCH v2] drm/imx: ipuv3-plane: fix PRG modifiers after drm managed resource conversion

2021-05-10 Thread Philipp Zabel
On Mon, 2021-05-10 at 16:59 +0200, Lucas Stach wrote: > The conversion to drm managed resources introduced two bugs: the plane is now > always initialized with the linear-only list, while the list with the Vivante > GPU modifiers should have been used when the PRG/PRE engines are present. This > ma

[GIT PULL] drm/imx: fixes, dma-fence annotation, and color encoding/range plane properties

2021-05-12 Thread Philipp Zabel
xport symbols Lucas Stach (1): drm/imx: ipuv3-plane: fix PRG modifiers after drm managed resource conversion Philipp Zabel (3): drm/imx: ipuv3-plane: do not advertise YUV formats on planes without CSC gpu: ipu-v3: Add Rec.709 limited range support to DP drm/imx: ipuv3-plane: add

Re: [GIT PULL] drm/imx: fixes, dma-fence annotation, and color encoding/range plane properties

2021-05-19 Thread Philipp Zabel
On Wed, 2021-05-19 at 09:19 +1000, Dave Airlie wrote: > On Wed, 12 May 2021 at 23:33, Philipp Zabel wrote: > > Hi Dave, Daniel, > > > > The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: > > > > Linux 5.13-rc1 (2021-05-09 14:17:44 -07

Re: [PATCH v3 1/7] drm: add drmm_encoder_alloc()

2020-12-04 Thread Philipp Zabel
Hi Laurent, On Fri, 2020-12-04 at 11:17 +0200, Laurent Pinchart wrote: > Hi Philipp, > > Thank you for the patch. Thank you for the review. > On Fri, Sep 11, 2020 at 03:57:18PM +0200, Philipp Zabel wrote: > > Add an alternative to drm_encoder_init() that allocates and

Re: [PATCH v3 2/7] drm/simple_kms_helper: add drmm_simple_encoder_alloc()

2020-12-04 Thread Philipp Zabel
Hi Laurent, On Fri, 2020-12-04 at 11:19 +0200, Laurent Pinchart wrote: > Hi Philipp, > > Thank you for the patch. > > On Fri, Sep 11, 2020 at 03:57:19PM +0200, Philipp Zabel wrote: > > Add an alternative to drm_simple_encoder_init() that allocates and > > initi

[PATCH v4 00/19] drm: managed encoder/plane/crtc allocation

2020-12-08 Thread Philipp Zabel
where they are the only remaining call. [1] https://lore.kernel.org/dri-devel/20200911135724.25833-1-p.za...@pengutronix.de/ [2] https://lore.kernel.org/dri-devel/20200911133855.29801-1-p.za...@pengutronix.de/ regards Philipp Philipp Zabel (19): drm/encoder: make encoder control functions

[PATCH v4 05/19] drm/crtc: add drmm_crtc_alloc_with_planes()

2020-12-08 Thread Philipp Zabel
Add an alternative to drm_crtc_init_with_planes() that allocates and initializes a crtc and registers drm_crtc_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/drm_crtc.c | 116

[PATCH v4 13/19] drm/imx: parallel-display: move initialization into probe

2020-12-08 Thread Philipp Zabel
Parts of the initialization that do not require the drm device can be done once during probe instead of possibly multiple times during bind. The bind function only creates the encoder. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/parallel-display.c | 42 -- 1

[PATCH v4 07/19] drm/imx: imx-ldb: use local connector variable

2020-12-08 Thread Philipp Zabel
Use a local variable for the connector. This simplifies the following commits. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/imx-ldb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index

[PATCH v4 08/19] drm/imx: imx-ldb: move initialization into probe

2020-12-08 Thread Philipp Zabel
Parts of the initialization that do not require the drm device can be done once during probe instead of possibly multiple times during bind. The bind function only creates the encoders. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/imx-ldb.c | 72 ++- 1

[PATCH v4 11/19] drm/imx: imx-tve: use devm_clk_register

2020-12-08 Thread Philipp Zabel
Avoid leaking the clock provider when the driver is unbound. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/imx-tve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index 649e2f56a5da..3ef71f688f79 100644

[PATCH v4 01/19] drm/encoder: make encoder control functions optional

2020-12-08 Thread Philipp Zabel
Simple managed encoders do not require the .destroy callback, make the whole funcs structure optional. Signed-off-by: Philipp Zabel Reviewed-by: Laurent Pinchart --- New in v4. --- drivers/gpu/drm/drm_encoder.c | 4 ++-- drivers/gpu/drm/drm_mode_config.c | 5 +++-- include/drm

[PATCH v4 12/19] drm/imx: parallel-display: use local bridge and connector variables

2020-12-08 Thread Philipp Zabel
Use local variables for bridge and connector. This simplifies the following commits. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/parallel-display.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/imx/parallel-display.c b

[PATCH v4 15/19] drm/imx: imx-ldb: use drm managed resources

2020-12-08 Thread Philipp Zabel
Use drmm_simple_encoder_alloc() to align encoder memory lifetime with the drm device. drm_encoder_cleanup() is called automatically before the memory is freed. Signed-off-by: Philipp Zabel --- Changes since v3: - use drmm_simple_encoder_alloc() --- drivers/gpu/drm/imx/imx-ldb.c | 31

[PATCH v4 04/19] drm/plane: add drmm_universal_plane_alloc()

2020-12-08 Thread Philipp Zabel
Add an alternative to drm_universal_plane_init() that allocates and initializes a plane and registers drm_plane_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/drm_plane.c | 126

[PATCH v4 17/19] drm/imx: parallel-display: use drm managed resources

2020-12-08 Thread Philipp Zabel
Use drmm_simple_encoder_alloc() to align encoder memory lifetime with the drm device. drm_encoder_cleanup() is called automatically before the memory is freed. Signed-off-by: Philipp Zabel --- Changes since v3: - use drmm_simple_encoder_alloc() --- drivers/gpu/drm/imx/parallel-display.c | 57

[PATCH v4 02/19] drm: add drmm_encoder_alloc()

2020-12-08 Thread Philipp Zabel
Add an alternative to drm_encoder_init() that allocates and initializes an encoder and registers drm_encoder_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel Reviewed-by: Laurent Pinchart --- Changes since v3: - allow the funcs parameter to __drmm_encoder_alloc() to be

[PATCH v4 10/19] drm/imx: imx-tve: move initialization into probe

2020-12-08 Thread Philipp Zabel
Parts of the initialization that do not require the drm device can be done once during probe instead of possibly multiple times during bind. The bind function only creates the encoder. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/imx-tve.c | 42 --- 1

[PATCH v4 06/19] drm/imx: dw_hdmi-imx: move initialization into probe

2020-12-08 Thread Philipp Zabel
Parts of the initialization that do not require the drm device can be done once during probe instead of possibly multiple times during bind. The bind function only creates the encoder and attaches the bridge. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/dw_hdmi-imx.c | 74

[PATCH v4 14/19] drm/imx: dw_hdmi-imx: use drm managed resources

2020-12-08 Thread Philipp Zabel
Use drmm_simple_encoder_alloc() to align encoder memory lifetime with the drm device. drm_encoder_cleanup() is called automatically. Signed-off-by: Philipp Zabel --- Changes since v3: - use drmm_simple_encoder_alloc() --- drivers/gpu/drm/imx/dw_hdmi-imx.c | 25 + 1 file

[PATCH v4 09/19] drm/imx: imx-tve: use local encoder and connector variables

2020-12-08 Thread Philipp Zabel
Introduce local variables for encoder and connector. This simplifies the following commits. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/imx-tve.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx

[PATCH v4 18/19] drm/imx: ipuv3-plane: use drm managed resources

2020-12-08 Thread Philipp Zabel
required. Handle error return values of the plane property creation functions. Signed-off-by: Philipp Zabel --- Changes since v3: - use drmm_universal_plane_alloc() - squash with patch "drm/imx: move call to ipu_plane_get_resources() into ipu_plane_init()" --- drivers/gpu/drm/imx/ip

[PATCH v4 03/19] drm/simple_kms_helper: add drmm_simple_encoder_alloc()

2020-12-08 Thread Philipp Zabel
Add an alternative to drm_simple_encoder_init() that allocates and initializes a simple encoder and registers drm_encoder_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel Reviewed-by: Laurent Pinchart --- Changes since v3: - drop drmm_simple_encoder_funcs_empty, now that

[PATCH v4 16/19] drm/imx: imx-tve: use drm managed resources

2020-12-08 Thread Philipp Zabel
Use drmm_simple_encoder_alloc() to align encoder memory lifetime with the drm device. drm_encoder_cleanup() is called automatically before the memory is freed. Also fold imx_tve_register() into imx_tve_bind(). Signed-off-by: Philipp Zabel --- Changes since v3: - use drmm_simple_encoder_alloc

[PATCH v4 19/19] drm/imx: ipuv3-crtc: use drm managed resources

2020-12-08 Thread Philipp Zabel
Use use drmm_crtc_alloc_with_planes() to align crtc memory lifetime with the drm device. drm_crtc_cleanup() is called automatically before the memory is freed. Also use drmm_add_action_or_reset() to make sure IPU resources are released automatically. Signed-off-by: Philipp Zabel --- Changes

Re: [PATCH v4 00/19] drm: managed encoder/plane/crtc allocation

2020-12-08 Thread Philipp Zabel
On Tue, 2020-12-08 at 16:54 +0100, Philipp Zabel wrote: > Hi, > > this is an update of the drmm_(simple_)encoder_alloc(), > drmm_universal_plane_alloc(), and drmm_crtc_alloc_with_plane() > functions in v3 [1] together with the imx-drm managed allocation > conversion from [2] a

Re: [PATCH v4 01/19] drm/encoder: make encoder control functions optional

2020-12-09 Thread Philipp Zabel
Hi Sam, On Tue, 2020-12-08 at 19:48 +0100, Sam Ravnborg wrote: > Hi Philipp, > On Tue, Dec 08, 2020 at 04:54:33PM +0100, Philipp Zabel wrote: > > Simple managed encoders do not require the .destroy callback, > > make the whole funcs structure optional. > > > >

Re: [PATCH v4 02/19] drm: add drmm_encoder_alloc()

2020-12-10 Thread Philipp Zabel
Hi Daniel, thank you for the review. I'll work in all your other comments, there's just one I'm not sure what to do about: On Wed, 2020-12-09 at 17:05 +0100, Daniel Vetter wrote: [...] > > +void *__drmm_encoder_alloc(struct drm_device *dev, size_t size, size_t > > offset, > > +

[PATCH v5 00/19] drm: managed encoder/plane/crtc allocation

2020-12-10 Thread Philipp Zabel
nal in drmm_encoder_alloc() documentation. - Address FIXME in drm_simple_encoder_init() documentation by pointing out drmm_simple_encoder_alloc(). [1] https://lore.kernel.org/dri-devel/20201208155451.8421-1-p.za...@pengutronix.de/ regards Philipp Philipp Zabel (19): drm/encoder: make encoder c

[PATCH v5 01/19] drm/encoder: make encoder control functions optional

2020-12-10 Thread Philipp Zabel
Simple managed encoders do not require the .destroy callback, make the whole funcs structure optional. Signed-off-by: Philipp Zabel Reviewed-by: Laurent Pinchart Reviewed-by: Daniel Vetter --- Changes since v4: - Roll back drm_mode_config_cleanup() change, any encoders that are kept on the

[PATCH v5 03/19] drm/simple_kms_helper: add drmm_simple_encoder_alloc()

2020-12-10 Thread Philipp Zabel
Add an alternative to drm_simple_encoder_init() that allocates and initializes a simple encoder and registers drm_encoder_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel Reviewed-by: Laurent Pinchart Reviewed-by: Daniel Vetter --- Changes since v4: - address FIXME in

[PATCH v5 06/19] drm/imx: dw_hdmi-imx: move initialization into probe

2020-12-10 Thread Philipp Zabel
Parts of the initialization that do not require the drm device can be done once during probe instead of possibly multiple times during bind. The bind function only creates the encoder and attaches the bridge. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/dw_hdmi

[PATCH v5 08/19] drm/imx: imx-ldb: move initialization into probe

2020-12-10 Thread Philipp Zabel
Parts of the initialization that do not require the drm device can be done once during probe instead of possibly multiple times during bind. The bind function only creates the encoders. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/imx-ldb.c | 72

[PATCH v5 15/19] drm/imx: imx-ldb: use drm managed resources

2020-12-10 Thread Philipp Zabel
Use drmm_simple_encoder_alloc() to align encoder memory lifetime with the drm device. drm_encoder_cleanup() is called automatically before the memory is freed. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/imx-ldb.c | 31 ++- 1 file

[PATCH v5 07/19] drm/imx: imx-ldb: use local connector variable

2020-12-10 Thread Philipp Zabel
Use a local variable for the connector. This simplifies the following commits. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/imx-ldb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm

[PATCH v5 19/19] drm/imx: ipuv3-crtc: use drm managed resources

2020-12-10 Thread Philipp Zabel
Use use drmm_crtc_alloc_with_planes() to align crtc memory lifetime with the drm device. drm_crtc_cleanup() is called automatically before the memory is freed. Also use drmm_add_action_or_reset() to make sure IPU resources are released automatically. Signed-off-by: Philipp Zabel Acked-by: Daniel

[PATCH v5 02/19] drm: add drmm_encoder_alloc()

2020-12-10 Thread Philipp Zabel
Add an alternative to drm_encoder_init() that allocates and initializes an encoder and registers drm_encoder_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel Reviewed-by: Laurent Pinchart Reviewed-by: Daniel Vetter --- Changes since v4: - mention that

[PATCH v5 12/19] drm/imx: parallel-display: use local bridge and connector variables

2020-12-10 Thread Philipp Zabel
Use local variables for bridge and connector. This simplifies the following commits. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/parallel-display.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/imx

[PATCH v5 14/19] drm/imx: dw_hdmi-imx: use drm managed resources

2020-12-10 Thread Philipp Zabel
Use drmm_simple_encoder_alloc() to align encoder memory lifetime with the drm device. drm_encoder_cleanup() is called automatically. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/dw_hdmi-imx.c | 25 + 1 file changed, 17 insertions(+), 8

[PATCH v5 05/19] drm/crtc: add drmm_crtc_alloc_with_planes()

2020-12-10 Thread Philipp Zabel
Add an alternative to drm_crtc_init_with_planes() that allocates and initializes a crtc and registers drm_crtc_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel Reviewed-by: Laurent Pinchart Reviewed-by: Daniel Vetter --- Changes since v4: - Mention that

[PATCH v5 09/19] drm/imx: imx-tve: use local encoder and connector variables

2020-12-10 Thread Philipp Zabel
Introduce local variables for encoder and connector. This simplifies the following commits. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/imx-tve.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b

[PATCH v5 16/19] drm/imx: imx-tve: use drm managed resources

2020-12-10 Thread Philipp Zabel
Use drmm_simple_encoder_alloc() to align encoder memory lifetime with the drm device. drm_encoder_cleanup() is called automatically before the memory is freed. Also fold imx_tve_register() into imx_tve_bind(). Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/imx

[PATCH v5 11/19] drm/imx: imx-tve: use devm_clk_register

2020-12-10 Thread Philipp Zabel
Avoid leaking the clock provider when the driver is unbound. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/imx-tve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index

[PATCH v5 17/19] drm/imx: parallel-display: use drm managed resources

2020-12-10 Thread Philipp Zabel
Use drmm_simple_encoder_alloc() to align encoder memory lifetime with the drm device. drm_encoder_cleanup() is called automatically before the memory is freed. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/parallel-display.c | 57 +- 1

[PATCH v5 04/19] drm/plane: add drmm_universal_plane_alloc()

2020-12-10 Thread Philipp Zabel
Add an alternative to drm_universal_plane_init() that allocates and initializes a plane and registers drm_plane_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel Reviewed-by: Laurent Pinchart Reviewed-by: Daniel Vetter --- Changes since v4: - Mention that

[PATCH v5 10/19] drm/imx: imx-tve: move initialization into probe

2020-12-10 Thread Philipp Zabel
Parts of the initialization that do not require the drm device can be done once during probe instead of possibly multiple times during bind. The bind function only creates the encoder. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/imx-tve.c | 42

[PATCH v5 18/19] drm/imx: ipuv3-plane: use drm managed resources

2020-12-10 Thread Philipp Zabel
required. Handle error return values of the plane property creation functions. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/ipuv3-crtc.c | 27 +--- drivers/gpu/drm/imx/ipuv3-plane.c | 69 +++ drivers/gpu/drm/imx/ipuv3-plane.h

[PATCH v5 13/19] drm/imx: parallel-display: move initialization into probe

2020-12-10 Thread Philipp Zabel
Parts of the initialization that do not require the drm device can be done once during probe instead of possibly multiple times during bind. The bind function only creates the encoder. Signed-off-by: Philipp Zabel Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/parallel-display.c | 42

Re: [PATCH -next] gpu: drm: imx: convert comma to semicolon

2020-12-11 Thread Philipp Zabel
On Fri, 2020-12-11 at 16:58 +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/gpu/drm/imx/parallel-display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/imx/pa

Re: [PATCH v4 00/19] drm: managed encoder/plane/crtc allocation

2020-12-11 Thread Philipp Zabel
Hi Laurent, Daniel, On Thu, 2020-12-10 at 14:19 +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Wed, Dec 09, 2020 at 10:13:54PM +0100, Daniel Vetter wrote: > > On Wed, Dec 09, 2020 at 10:10:47PM +0100, Daniel Vetter wrote: > > > On Tue, Dec 08, 2020 at 04:59:16PM +0

Re: [PATCH] drm/imx: depend on COMMON_CLK to fix compile tests

2020-11-17 Thread Philipp Zabel
On Mon, 2020-11-16 at 19:14 +0100, Krzysztof Kozlowski wrote: > The iMX DRM drivers use Common Clock Framework thus they cannot be built > on platforms without it (e.g. compile test on MIPS with RALINK and > SOC_RT305X): > > /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in functio

Re: [PATCH 41/42] gpu/ipu-v3/ipu-di: Strip out 2 unused 'di_sync_config' entries

2020-11-17 Thread Philipp Zabel
i.c:391:1: warning: the frame size of 1064 bytes is > larger than 1024 bytes [-Wframe-larger-than=] > > Cc: Philipp Zabel > Cc: Sascha Hauer > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/ipu-v3/ipu-di.c | 4 > 1 file changed

Re: [PATCH v2] drm/imx: depend on COMMON_CLK to fix compile tests

2020-11-18 Thread Philipp Zabel
Hi Krzysztof, On Tue, 2020-11-17 at 19:24 +0100, Krzysztof Kozlowski wrote: > The iMX DRM LVDS driver uses Common Clock Framework thus it cannot be > built on platforms without it (e.g. compile test on MIPS with RALINK and > SOC_RT305X): > > /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx

Re: [PATCH 1/4] drm/etnaviv: check for reaped mapping in etnaviv_iommu_unmap_gem

2022-03-24 Thread Philipp Zabel
ucas Stach Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH 2/4] drm/etnaviv: move MMU context ref/unref into map/unmap_gem

2022-03-24 Thread Philipp Zabel
h Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH 3/4] drm/etnaviv: move flush_seq increment into etnaviv_iommu_map/unmap

2022-03-24 Thread Philipp Zabel
functional change. Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH v2] drm/imx: Fix memory leak in imx_pd_connector_get_modes

2022-03-29 Thread Philipp Zabel
On Sa, 2022-01-08 at 17:52 +0100, José Expósito wrote: > Avoid leaking the display mode variable if of_get_drm_display_mode > fails. > > Fixes: 76ecd9c9fb24 ("drm/imx: parallel-display: check return code > from of_get_drm_display_mode()") > Addresses-Coverity-ID: 1443943 ("Resource leak") > Signed

Re: [PATCH] drm/imx: imx-ldb: Check for null pointer after calling kmemdup

2022-03-29 Thread Philipp Zabel
On Mi, 2022-01-05 at 15:47 +0800, Jiasheng Jiang wrote: > As the possible failure of the allocation, kmemdup() may return NULL > pointer. > Therefore, it should be better to check the return value of kmemdup() > and return error if fails. > > Fixes: dc80d7038883 ("drm/imx-ldb: Add support to drm-b

Re: [PATCH] drm/imx: dw_hdmi-imx: Fix bailout in error cases of probe

2022-03-29 Thread Philipp Zabel
ion into > probe") > Cc: Philipp Zabel > Cc: David Airlie > Cc: Daniel Vetter > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Signed-off-by: Liu Ying > --- >  drivers/gpu/drm/imx/dw_hdmi-i

Re: [PATCH] gpu: ipu-v3: Fix dev_dbg frequency output

2022-03-29 Thread Philipp Zabel
On Mo, 2022-02-07 at 16:14 +0100, Mark Jonas wrote: > From: Leo Ruan > > This commit corrects the printing of the IPU clock error percentage > if > it is between -0.1% to -0.9%. For example, if the pixel clock > requested > is 27.2 MHz but only 27.0 MHz can be achieved the deviation is -0.8%. > B

Re: [PATCH] drm/imx: make static read-only array channel_offsets const

2022-03-29 Thread Philipp Zabel
On So, 2022-01-23 at 22:34 +, Colin Ian King wrote: > The static array channel_offsets is read-only so it make sense to > make > it const. > > Signed-off-by: Colin Ian King > --- >  drivers/gpu/ipu-v3/ipu-dc.c | 5 +++-- >  1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/driv

Re: [PATCH 09/22] drm/imx: Use drm_mode_duplicate()

2022-02-18 Thread Philipp Zabel
t; identifier newmode; > @@ > - newmode = drm_mode_create(dev); > + newmode = drm_mode_duplicate(dev, oldmode); >   ... > - drm_mode_copy(newmode, oldmode); > > Cc: Philipp Zabel > Signed-off-by: Ville Syrjälä Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH] drm/imx: imx-tve: Make use of the helper function devm_platform_ioremap_resource()

2021-08-31 Thread Philipp Zabel
Hi Cai, On Tue, 2021-08-31 at 21:55 +0800, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Thank you, applied to imx-drm/next. regards Philipp

Re: [PATCH v5 09/16] soc: mediatek: mmsys: modify reset controller for MT8195 vdosys1

2021-09-06 Thread Philipp Zabel
Hi Nancy, On Mon, 2021-09-06 at 15:15 +0800, Nancy.Lin wrote: > MT8195 vdosys1 has more than 32 reset bits and a different reset base > than other chips. Modify mmsys for support 64 bit and different reset > base. > > Signed-off-by: Nancy.Lin > --- > drivers/soc/mediatek/mt8195-mmsys.h | 1 + >

Re: [PATCH v1 6/6] drm/mediatek: Add mt8195 DisplayPort driver

2021-09-07 Thread Philipp Zabel
Hi Markus, On Mon, 2021-09-06 at 21:35 +0200, Markus Schneider-Pargmann wrote: > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. > > It supports both functional units on the mt8195, the embedded > DisplayPort as well as the external DisplayPort units. It offers > hot-plug-detect

Re: [PATCH v10 07/17] dt-bindings: display: mediatek: merge: add additional prop for mt8195

2021-09-07 Thread Philipp Zabel
Hi Jason, On Wed, 2021-09-08 at 14:03 +0800, jason-jh.lin wrote: > add MERGE additional properties description for mt8195: > 1. async clock > 2. fifo setting enable > 3. reset controller > > Signed-off-by: jason-jh.lin > --- > .../display/mediatek/mediatek,merge.yaml | 30 +

[PATCH v2 1/2] drm/edid: support Microsoft extension for HMDs and specialized monitors

2022-01-23 Thread Philipp Zabel
ardware/drivers/display/specialized-monitors-edid-extension Tested with HPN-36C1 and LEN-B800. Signed-off-by: Philipp Zabel Reviewed-by: Jani Nikula --- Changes since v1 [2]: - Split out quirk removal into a separate patch. - Set non_desktop to true instead of 1. [2] https://lore.kernel.org/all/2021

[PATCH v2 2/2] drm/edid: remove non_desktop quirk for HPN-3515 and LEN-B800.

2022-01-23 Thread Philipp Zabel
without it. Tested with LEN-B800. Signed-off-by: Philipp Zabel Reviewed-by: Jani Nikula --- Changes since v1 [1]: - Quirk removal split out of patch 1. [1] https://lore.kernel.org/all/20211213184706.5776-1-philipp.za...@gmail.com/ --- drivers/gpu/drm/drm_edid.c | 2 -- 1 file changed, 2

Re: [PATCH] drm/edid: improve non-desktop quirk logging

2022-01-23 Thread Philipp Zabel
On Tue, Dec 28, 2021 at 11:10 AM Jani Nikula wrote: > > Improve non-desktop quirk logging if the EDID indicates non-desktop. If > both are set, note about redundant quirk. If there's no quirk but the > EDID indicates non-desktop, don't log non-desktop is set to 0. > >

Re: [PATCH v9 16/22] drm/mediatek: add ETHDR support for MT8195

2021-11-30 Thread Philipp Zabel
Hi Nancy, On Tue, 2021-11-30 at 11:35 +0800, Nancy.Lin wrote: [...] > +void mtk_ethdr_stop(struct device *dev) > +{ > + struct mtk_ethdr *priv = dev_get_drvdata(dev); > + struct mtk_ethdr_comp *mixer = &priv->ethdr_comp[ETHDR_MIXER]; > + > + writel(0, mixer->regs + MIX_EN); > + wri

[PATCH] drm/edid: support Microsoft extension for HMDs and specialized monitors

2021-12-13 Thread Philipp Zabel
d with HPN-36C1 and LEN-B800. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/drm_edid.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 12893e7be89b..baea65dfff7d 100644 --- a/

Re: [PATCH v2 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML

2021-01-04 Thread Philipp Zabel
+1,130 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/imx/fsl,imx6-hdmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX6 DWC HDMI TX Encoder > + > +mainta

Re: [PATCH v2 1/6] dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI

2021-01-04 Thread Philipp Zabel
s for the IP core. > > Signed-off-by: Laurent Pinchart Reviewed-by: Philipp Zabel regards Philipp > --- > Changes since v1: > > - Add default to reg-io-width property > - Add additionalProperties > - Rebase on top of OF graph schema, dropped redundant properties &

[GIT PULL] drm/imx: fixes and drm managed resources

2021-01-04 Thread Philipp Zabel
. Krzysztof Kozlowski (1): drm/imx: depend on COMMON_CLK to fix compile tests Lee Jones (1): gpu/ipu-v3/ipu-di: Strip out 2 unused 'di_sync_config' entries Philipp Zabel (19): drm/encoder: make encoder control

Re: [PATCH v2 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML

2021-01-05 Thread Philipp Zabel
On Tue, 2021-01-05 at 07:49 +0200, Laurent Pinchart wrote: > Hi Philipp, > > On Mon, Jan 04, 2021 at 04:30:36PM +0100, Philipp Zabel wrote: > > On Sun, 2020-12-20 at 21:50 +0200, Laurent Pinchart wrote: > > > Convert the i.MX6 HDMI TX text binding to YAML. > > &

Re: [PATCH v2 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML

2021-01-06 Thread Philipp Zabel
Hi Laurent, On Tue, 2021-01-05 at 13:50 +0200, Laurent Pinchart wrote: > Hi Philipp, > > On Tue, Jan 05, 2021 at 10:32:01AM +0100, Philipp Zabel wrote: > > On Tue, 2021-01-05 at 07:49 +0200, Laurent Pinchart wrote: > > > On Mon, Jan 04, 2021 at 04:30:36PM +0100, Philipp

[PATCH] drm/imx: dw_hdmi-imx: depend on OF to fix randconfig compile tests on x86_64

2021-01-06 Thread Philipp Zabel
lap Fixes: c805ec7eb210 ("drm/imx: dw_hdmi-imx: move initialization into probe") Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig index 73fe2bc5633c..b5fa0

[PATCH 1/2] gpu: ipu-v3: Add Rec.709 limited range support to DP

2021-01-07 Thread Philipp Zabel
Add YCbCr encoding and quantization range parameters to ipu_dp_setup_channel() and configure the CSC DP matrix accordingly. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 9 ++--- drivers/gpu/ipu-v3/ipu-dp.c | 25 ++--- include/video/imx-ipu

[PATCH 2/2] drm/imx: ipuv3-plane: add color encoding and range properties

2021-01-07 Thread Philipp Zabel
Add COLOR_ENCODING and COLOR_RANGE plane properties and use them to control the DP CSC matrix. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 44 +-- 1 file changed, 30 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3

[PATCH] drm/modes: add non-OF stub for of_get_drm_display_mode

2021-01-08 Thread Philipp Zabel
an inline stub so they can be build-tested with non-OF configurations. Reported-by: Randy Dunlap Signed-off-by: Philipp Zabel --- include/drm/drm_modes.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h index a0d79d1c51e2..29ba4adf0

Re: linux-next: Tree for Jan 7 (drivers/gpu/drm/imx/parallel-display.o)

2021-01-08 Thread Philipp Zabel
On Fri, 2021-01-08 at 10:03 +0100, Daniel Vetter wrote: > On Fri, Jan 8, 2021 at 9:55 AM Randy Dunlap wrote: > > On 1/6/21 7:01 PM, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20210106: > > > > > > > on x86_64: > > > > ld: drivers/gpu/drm/imx/parallel-display.o: in function

[GIT PULL] drm/imx: compile test fixes

2021-01-08 Thread Philipp Zabel
) drm/imx: compile test fixes - Fix COMPILE_TEST builds with CONFIG_OF disabled. Philipp Zabel (2): drm/imx: dw_hdmi-imx: depend on OF to fix randconfig compile tests on x86_64 drm/modes: add non-OF stub for

Re: [RFC 22/28] drm: rcar-du: Add RZ/G2L DSI driver

2022-01-14 Thread Philipp Zabel
Hi Biju, On Wed, 2022-01-12 at 17:46 +, Biju Das wrote: [...] > +static int rzg2l_mipi_dsi_probe(struct platform_device *pdev) > +{ [...] > + dsi->rstc = devm_reset_control_get(dsi->dev, "rst"); [...] > + dsi->arstc = devm_reset_control_get(dsi->dev, "arst"); [...] > + dsi->prstc =

  1   2   3   4   5   6   7   8   9   10   >