Re: [PATCH 000/190] Revertion of all of the umn.edu commits

2021-04-29 Thread Pavel Machek
Hi! > > Revert "drm/radeon: Fix reference count leaks caused by > > pm_runtime_get_sync" > > Revert "drm/radeon: fix multiple reference count leak" > > Revert "drm/amdkfd: Fix reference count leaks." > > I didn't review these carefully, but from a quick look they all seem > rather incon

Re: [PATCH v5] Add power/gpu_frequency tracepoint.

2021-03-12 Thread Pavel Machek
On Wed 2021-03-10 13:56:29, Peiyong Lin wrote: > On Mon, Dec 21, 2020 at 12:10 PM Peiyong Lin wrote: > > > > Historically there is no common trace event for GPU frequency, in > > downstream Android each different hardware vendor implements their own > > way to expose GPU frequency, for example as

Re: [PATCH 5.10 078/120] drm/dp/mst: Export drm_dp_get_vc_payload_bw()

2021-02-10 Thread Pavel Machek
Hi! > commit 83404d581471775f37f85e5261ec0d09407d8bed upstream. > > This function will be needed by the next patch where the driver > calculates the BW based on driver specific parameters, so export it. > > At the same time sanitize the function params, passing the more natural > link rate inste

Re: [PATCH] kernel: Expose SYS_kcmp by default

2021-02-13 Thread Pavel Machek
Hi! > Userspace has discovered the functionality offered by SYS_kcmp and has > started to depend upon it. In particular, Mesa uses SYS_kcmp for > os_same_file_description() in order to identify when two fd (e.g. device > or dmabuf) point to the same struct file. Since they depend on it for > core

Re: [PATCH V1 0/2] Fix WLED FSC Sync and brightness Sync settings

2021-02-19 Thread Pavel Machek
Hi! > The FSC (Full scale current) setting is not updated properly due to the > wrong register toggling for WLED5. Also the ILED_SYNC toggle and MOD_SYNC > toggle sequence is updated as per the hardware team recommendation to fix > the FSC update and brightness update issue. If this is phone hard

udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-24 Thread Pavel Machek
Hi! This is in -next, but I get same behaviour on 5.11; and no, udl does not work, but monitor is detected: pavel@amd:~/g/tui/crashled$ xrandr Screen 0: minimum 320 x 200, current 1024 x 768, maximum 4096 x 4096 LVDS1 connected 1024x768+0+0 (normal left inverted right x axis y axis) 246mm x 185

Re: [PATCH v4] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-25 Thread Pavel Machek
should use DRM_GEM_SHMEM_DROVER_OPS_USB to initialize their > instance of struct drm_driver. > > Tested by joining/mirroring displays of udl and radeon un der > Gnome/X11. Thanks for doing this. Tested-by: Pavel Machek Best regards,

udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Pavel Machek
Hi! > >This is in -next, but I get same behaviour on 5.11; and no, udl does > > Thanks for reporting. We are in the process of fixing the issue. The latest > patch is at [1]. > Thank you, that fixes the DMA issue, and I can use the udl. ...for a while. Then screensaver blanks laptop screen, udl

Re: udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Pavel Machek
Hi! > > Thank you, that fixes the DMA issue, and I can use the udl. > > > > ...for a while. Then screensaver blanks laptop screen, udl screen > > blanks too. Upon hitting a key, internal screen shows up, udl does > > not. > > > > I try rerunning xrandr ... --auto, but could not recover it. > >

Re: udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-25 Thread Pavel Machek
Hi! > > > > This is in -next, but I get same behaviour on 5.11; and no, udl does > > > > > > Thanks for reporting. We are in the process of fixing the issue. The > > > latest > > > patch is at [1]. > > > > > > > Thank you, that fixes the DMA issue, and I can use the udl. > > > > ...for a whil

Re: [PATCH v5] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-26 Thread Pavel Machek
Hi! > > + struct device *dmadev; > > + struct drm_gem_object *obj; > > + > > + if (!dev_is_usb(dev->dev)) > > + return ERR_PTR(-ENODEV); > > + > > + dmadev = usb_intf_get_dma_device(to_usb_interface(dev->dev)); > > + if (drm_WARN_ONCE(dev, !dmadev, "buffer sharing not supporte

Re: [PATCH AUTOSEL 4.4 08/31] drm/virtio: Fixes a potential NULL pointer dereference on probe failure

2021-07-12 Thread Pavel Machek
Hi! > From: Xie Yongji > > [ Upstream commit 17f46f488a5d82c5568e6e786cd760bba1c2ee09 ] > > The dev->dev_private might not be allocated if virtio_gpu_pci_quirk() > or virtio_gpu_init() failed. In this case, we should avoid the cleanup > in virtio_gpu_release(). The check is in wrong place at l

Re: [PATCH 5/5] spi: make remove callback a void function

2022-03-02 Thread Pavel Machek
e not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. Acked-by: Pavel Machek

AUTOSEL series truncated was -- Re: [PATCH AUTOSEL 5.15 001/146] dma-buf: WARN on dmabuf release with pending attachments

2021-11-09 Thread Pavel Machek
Hi! This series is truncated .. I only got first patches. Similary, 5.10 series is truncated, [PATCH AUTOSEL 5.10 035/101] media: s5p-mfc: Add checking to s5p_mfc_probe... is last one I got. I got all the patches before that, so I believe it is not problem on my side, but I'd not mind someone con

[PATCH 0/7] de-stage SW_SYNC validation frawework

2016-08-07 Thread Pavel Machek
On Sun 2016-07-24 15:21:11, Greg Kroah-Hartman wrote: > On Mon, Jul 18, 2016 at 04:12:45PM -0300, Gustavo Padovan wrote: > > Hi, > > > > Do you think there is time to get this in for 4.8? > > No, it was too late on my end, due to travel and vacation, sorry. I'll > queue it up for 4.9-rc1. Could

[PATCH 0/7] de-stage SW_SYNC validation frawework

2016-08-08 Thread Pavel Machek
On Mon 2016-08-08 16:08:12, Gustavo Padovan wrote: > 2016-08-07 Pavel Machek : > > > On Sun 2016-07-24 15:21:11, Greg Kroah-Hartman wrote: > > > On Mon, Jul 18, 2016 at 04:12:45PM -0300, Gustavo Padovan wrote: > > > > Hi, > > > > > > &g

[PATCH v2 1/6] staging/android: remove doc from sw_sync

2016-08-09 Thread Pavel Machek
On Mon 2016-08-08 18:24:17, Gustavo Padovan wrote: > From: Gustavo Padovan > > SW_SYNC should never be used by other pieces of the kernel apart from > sync_debug as it is only a Sync File Validation Framework, so hide any > info to avoid confuse this with a standard kernel internal API. > Signed

[PATCH 0/7] de-stage SW_SYNC validation frawework

2016-08-10 Thread Pavel Machek
On Tue 2016-08-09 08:04:54, Daniel Vetter wrote: > On Sun, Jul 24, 2016 at 05:00:31PM +0200, Pavel Machek wrote: > > On Mon 2016-08-08 16:08:12, Gustavo Padovan wrote: > > > 2016-08-07 Pavel Machek : > > > > > > > On Sun 2016-07-24 15:21:11, Greg Kroah-

[PATCH] staging/android: add Doc for SW_SYNC ioctl interface

2016-08-18 Thread Pavel Machek
gt; > v2: take in Eric suggestions for the Documentation > > v3: really take in Eric suggestions > > Signed-off-by: Gustavo Padovan > Reviewed-by: Eric Engestrom Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karl

Re: [PATCHv6 4/4] drm/omap: add support for manually updated displays

2019-05-22 Thread Pavel Machek
s still neccessary, still needed, and still not merged. How can I help? Can the patches simply be picked up for drm tree? Tested-by: Pavel Machek Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH v6 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-24 Thread Pavel Machek
an Not a great fan of duplicating MAINTAINERS information here. But this is a comment for Rob, again. Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH v6 3/3] backlight: lm3630a: add firmware node support

2019-04-24 Thread Pavel Machek
of this driver. > > Driver was tested on a LG Nexus 5 (hammerhead) phone. > > Signed-off-by: Brian Masney > Reviewed-by: Dan Murphy Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/ho

Re: [PATCH v6 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-24 Thread Pavel Machek
On Wed 2019-04-24 10:57:50, Rob Herring wrote: > On Wed, Apr 24, 2019 at 9:20 AM Pavel Machek wrote: > > > > Hi! > > > > > --- /dev/null > > > +++ > > > b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > > @@ -0,

Re: [PATCH v3 3/3] backlight: lm3630a: add firmware node support

2019-05-01 Thread Pavel Machek
Hi! > > @@ -396,13 +506,20 @@ static int lm3630a_probe(struct i2c_client *client, > > GFP_KERNEL); > > if (pdata == NULL) > > return -ENOMEM; > > + > > /* default values */ > > - pdata->leda_ctrl = LM3630A_LEDA_

Re: [PATCHv6 0/4] omapdrm: DSI command mode panel support

2019-06-03 Thread Pavel Machek
Hi! > > > Here is another round of the DSI command mode panel patchset > > > integrating the feedback from PATCHv5. The patches are based > > > on v5.2-rc1 tag. It does not contain the patches required for > > > OMAP3 support (it needs a workaround for a hardware bug) and > > > for automatic displ

Re: [PATCH 1/2] dt-bindings: pwm-backlight: Add 'max-brightness' property

2019-06-11 Thread Pavel Machek
On Mon 2019-06-10 16:37:38, Matthias Kaehlcke wrote: > Add an optional 'max-brightness' property, which is used to specify > the number of brightness levels (max-brightness + 1) when the node > has no 'brightness-levels' table. > > Signed-off-by: Matthia

Re: [PATCH 2/2] backlight: pwm_bl: Get number of brightness levels for CIE 1931 from the device tree

2019-06-11 Thread Pavel Machek
d it with another heuristics ("256"). > Signed-off-by: Matthias Kaehlcke Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digi

Re: Re: [PATCH 2/3] backlight/arcxcnn fix vendor prefix

2019-06-21 Thread Pavel Machek
Hi! > [Sorry to those receiving this twice... had to dig this out from the > archives and sent it to the lists from the wrong mailer] > > On 27/11/2018 00:44, Brian Dodge wrote: > >Thank you Pavel, that is a good point. > > > >The chip vendor has indicated that there is no reason to maintain the

Re: [PATCH v2 2/4] backlight: Expose brightness curve type through sysfs

2019-06-26 Thread Pavel Machek
Hi! > Export the type of the brightness curve via the new sysfs attribute > 'scale'. The value of the attribute may be a simple string like > 'linear' or 'non-linear', or a composite string similar to > 'compatible' strings of the device tree. A composite string consists > of different elements se

Re: [PATCH v2 4/4] backlight: pwm_bl: Set scale type for brightness curves specified in the DT

2019-06-26 Thread Pavel Machek
On Mon 2019-06-24 13:31:13, Matthias Kaehlcke wrote: > Check if a brightness curve specified in the device tree is linear or > not and set the corresponding property accordingly. This makes the > scale type available to userspace via the 'scale' sysfs attribute. > > To determine if a curve is line

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

2019-06-26 Thread Pavel Machek
On Wed 2019-06-26 11:56:14, Daniel Thompson wrote: > On Tue, Jun 25, 2019 at 07:44:06AM -0400, Brian Dodge wrote: > > I would like to deprecate the old prefix in the future after communicating > > with all chip customers, which is why the old prefix is not documented in > > the new bindings. > > D

Re: [PATCH v2 4/4] backlight: pwm_bl: Set scale type for brightness curves specified in the DT

2019-06-28 Thread Pavel Machek
On Fri 2019-06-28 08:55:16, Daniel Thompson wrote: > On Wed, Jun 26, 2019 at 04:56:18PM +0200, Pavel Machek wrote: > > On Mon 2019-06-24 13:31:13, Matthias Kaehlcke wrote: > > > Check if a brightness curve specified in the device tree is linear or > > > not and set

Re: [PATCH 2/2] backlight: arcxcnn: add "arctic" vendor prefix

2019-07-05 Thread Pavel Machek
On Sun 2019-06-30 20:28:15, Brian Dodge wrote: > The original patch adding this driver and DT bindings improperly > used "arc" as the vendor-prefix. This adds "arctic" which is the > proper prefix and retains "arc" to allow existing users of the > "arc" prefix to update to new kernels. There is at

Re: [PATCH 3/4] backlight: add led-backlight driver

2019-07-05 Thread Pavel Machek
Hi! > > > > Also still relevant is whether the LED device is being correctly > > > > modelled if the act of turning on the LED doesn't, in fact, turn the LED > > > > on. Is it *really* a correct implementation of an LED device that > > > > setting it to LED_FULL using sysfs doesn't cause it to lig

Re: [PATCH 4/4] devicetree: Add led-backlight binding

2019-07-05 Thread Pavel Machek
Hi! > Add DT binding for led-backlight. > > Signed-off-by: Tomi Valkeinen > Signed-off-by: Jean-Jacques Hiblot > Cc: devicet...@vger.kernel.org > --- > +Required properties: > + - compatible: "led-backlight" > + - brightness-levels: Array of distinct LED brightness levels. These > + are

Re: [PATCH 0/4] Add a generic driver for LED-based backlight

2019-07-05 Thread Pavel Machek
On Mon 2019-07-01 17:14:19, Jean-Jacques Hiblot wrote: > This series aims to add a led-backlight driver, similar to pwm-backlight, > but using a LED class device underneath. > > A few years ago (2015), Tomi Valkeinen posted a series implementing a > backlight driver on top of a LED device: > https

Re: [PATCH AUTOSEL 5.0 070/262] drm/amd/display: Pass app_tf by value rather than by reference

2019-03-28 Thread Pavel Machek
> From: Nathan Chancellor > > [ Upstream commit 672e78cab819ebe31e3b9b8abac367be8a110472 ] > > Clang warns when an expression that equals zero is used as a null > pointer constant (in lieu of NULL): Fixes warning, with unsupported compiler; not a serious bug. Plus, not a minimal fix.

Re: [PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-01 Thread Pavel Machek
On Mon 2019-04-01 06:30:33, Brian Masney wrote: > Add new backlight bindings for the TI LM3630A dual-string white LED. > > Signed-off-by: Brian Masney > --- > .../leds/backlight/lm3630a-backlight.yaml | 112 ++ What is that? Is it future of all the bindings? Up to device tre

Re: [PATCH v2 1/3] backlight: lm3630a: return 0 on success in update_status functions

2019-04-01 Thread Pavel Machek
to be returned. These functions should return 0 on > success, so let's change it to correct that error. > > Signed-off-by: Brian Masney > Fixes: 28e64a68a2ef ("backlight: lm3630: apply chip revision") Acked-by: Pavel Machek > --- > drivers/video/backlight/lm36

Re: [PATCH v2 3/3] backlight: lm3630a: add device tree supprt

2019-04-01 Thread Pavel Machek
On Mon 2019-04-01 06:30:34, Brian Masney wrote: > Add device tree support to the lm3630a driver and allow configuring > independently on both banks the mapping mode (linear or exponential), > initial and maximum LED brightness. > > Driver was tested on a LG Nexus 5 (hammerhead) phone. > > Signed-

Re: [PATCH v2 3/3] backlight: lm3630a: add device tree supprt

2019-04-02 Thread Pavel Machek
On Tue 2019-04-02 08:45:40, Dan Murphy wrote: > Hello > > On 4/1/19 5:30 AM, Brian Masney wrote: > > Add device tree support to the lm3630a driver and allow configuring > > independently on both banks the mapping mode (linear or exponential), > > initial and maximum LED brightness. > > > > Driver

Re: [PATCH v3 1/4] leds: Add of_led_get() and led_put()

2019-07-10 Thread Pavel Machek
On Wed 2019-07-10 14:39:29, Jean-Jacques Hiblot wrote: > From: Tomi Valkeinen > > This patch adds basic support for a kernel driver to get a LED device. > This will be used by the led-backlight driver. > > Only OF version is implemented for now, and the behavior is similar to > PWM's of_pwm_get(

Re: [PATCH v3 2/4] leds: Add managed API to get a LED from a device driver

2019-07-10 Thread Pavel Machek
On Wed 2019-07-10 14:39:30, Jean-Jacques Hiblot wrote: > If the LED is acquired by a consumer device with devm_led_get(), it is > automatically release when the device is detach. released, detached. Acked-by: Pavel

Re: [PATCH v3 3/4] dt-bindings: backlight: Add led-backlight binding

2019-07-10 Thread Pavel Machek
On Wed 2019-07-10 14:39:31, Jean-Jacques Hiblot wrote: > Add DT binding for led-backlight. > > Signed-off-by: Jean-Jacques Hiblot > --- > .../bindings/leds/backlight/led-backlight.txt | 28 +++ > 1 file changed, 28 insertions(+) > create mode 100644 > Documentation/devicetree/b

Re: [PATCH v3 4/4] backlight: add led-backlight driver

2019-07-10 Thread Pavel Machek
lt-brightness-level", &value); > + if (!ret && value <= priv->max_brightness) > + priv->default_brightness = value; > + else if (!ret && value > priv->max_brightness) > + dev_warn(dev, "invalid default brightnes

[PATCH] Enable backlight when trigger is activated

2019-07-18 Thread Pavel Machek
Configuring backlight trigger from dts results in backlight off during boot. Machine looks dead upon boot, which is not good. Fix that by enabling LED on trigger activation. Signed-off-by: Pavel Machek diff --git a/drivers/leds/trigger/ledtrig-backlight.c b/drivers/leds/trigger/ledtrig

Re: [PATCH] Enable backlight when trigger is activated

2019-07-22 Thread Pavel Machek
Hi! > > Configuring backlight trigger from dts results in backlight off during > > boot. Machine looks dead upon boot, which is not good. > > > > Fix that by enabling LED on trigger activation. > > +++ b/drivers/leds/trigger/ledtrig-backlight.c > > @@ -114,6 +114,8 @@ static int bl_trig_activate

Re: [PATCH] Enable backlight when trigger is activated

2019-07-22 Thread Pavel Machek
Hi! > >> This looks fishy. > >> > >> Maybe you should use a default-state = "keep" instead? (and you'll have > >> to support it in the LED driver). > >> > >> That'll give you proper "don't touch the LED if it was turned on" behavior, > >> which is what you seem to want. > > > > Actually no, that'

Re: [PATCH] Enable backlight when trigger is activated

2019-07-24 Thread Pavel Machek
Hi! > >>> +++ b/drivers/leds/trigger/ledtrig-backlight.c > >>> @@ -114,6 +114,8 @@ static int bl_trig_activate(struct led_classdev *led) > >>> n->old_status = UNBLANK; > >>> n->notifier.notifier_call = fb_notifier_callback; > >>> > >>> + led_set_brightness(led, LED_ON); > >>> + > >> > >> Thi

Re: [PATCH v4 1/4] leds: Add of_led_get() and led_put()

2019-07-30 Thread Pavel Machek
> PWM's of_pwm_get() and pwm_put(). > > Signed-off-by: Tomi Valkeinen > Signed-off-by: Jean-Jacques Hiblot Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH 0/4] Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-04 Thread Pavel Machek
Hi! > Linux code for running as a Hyper-V guest includes special cases for the > first released versions of Hyper-V: 2008 and 2008R2/Windows 7. These > versions were very thinly used for running Linux guests when first > released more than 12 years ago, and they are now out of support > (except fo

Re: [PATCH v6 04/13] dt-bindings: leds: Add MediaTek MT6370 flashlight

2022-07-30 Thread Pavel Machek
On Fri 2022-07-22 18:23:58, ChiaEn Wu wrote: > From: Alice Chen > > Add MediaTek MT6370 flashlight binding documentation. > > Signed-off-by: Alice Chen > Reviewed-by: Krzysztof Kozlowski You'll need to get sign-offs right... And review from dt people before this can be applied. Best regards,

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-07-30 Thread Pavel Machek
Hi! > From: ChiYuan Huang > > The MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery > charger, a USB Type-C & Power Delivery (PD) controller, dual > Flash LED current sources, a RGB LED driver, a backlight WLED dr

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

2022-07-30 Thread Pavel Machek
Hi! > From: Alice Chen > > The MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery > charger, a USB Type-C & Power Delivery (PD) controller, dual Flash > LED current sources, a RGB LED driver, a backlight WLED drive

Re: [PATCH AUTOSEL 5.10 01/46] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-08-12 Thread Pavel Machek
Hi! In this series, I only received patches up-to 42/46. Is problem at sender or receiver? Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/

Re: [PATCH AUTOSEL 5.10 05/46] drm/panfrost: Handle HW_ISSUE_TTRX_2968_TTRX_3162

2022-08-13 Thread Pavel Machek
Hi! > From: Alyssa Rosenzweig > > [ Upstream commit 382435709516c1a7dc3843872792abf95e786c83 ] > > Add handling for the HW_ISSUE_TTRX_2968_TTRX_3162 quirk. Logic ported > from kbase. kbase lists this workaround as used on Mali-G57. AFAICT this quirk is not used anywhere in 5.10, and its users

Re: [PATCH v2 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-05-30 Thread Pavel Machek
On Mon 2022-05-09 12:43:00, Rex-BC Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 RDMA definition. > > Signed-off-by: Nancy.Lin > Reviewed-by: AngeloGioacchino Del Regno > Your signoff will be needed, too. Best regards, Pavel

Re: [PATCH AUTOSEL 4.19 04/22] drm/vc4: crtc: Use an union to store the page flip callback

2022-06-29 Thread Pavel Machek
Hi! > From: Maxime Ripard > > [ Upstream commit 2523e9dcc3be91bf9fdc0d1e542557ca00bbef42 ] > > We'll need to extend the vc4_async_flip_state structure to rely on > another callback implementation, so let's move the current one into a > union. This and [04/22] drm/vc4: crtc: Use an union to sto

Re: [PATCH AUTOSEL 4.9 05/13] video: fbdev: skeletonfb: Fix syntax errors in comments

2022-06-29 Thread Pavel Machek
Hi! > From: Xiang wangx > > [ Upstream commit fc378794a2f7a19cf26010dc33b89ba608d4c70f ] > > Delete the redundant word 'its'. Calling typo in comment "syntax error" is ... interesting. Anyway, we don't need this in stable. Best regards,

Re: [PATCH AUTOSEL 4.9 08/13] video: fbdev: simplefb: Check before clk_put() not needed

2022-06-29 Thread Pavel Machek
Hi! > [ Upstream commit 5491424d17bdeb7b7852a59367858251783f8398 ] > > clk_put() already checks the clk ptr using !clk and IS_ERR() > so there is no need to check it again before calling it. Nice cleanup, but not a bugfix; we don't need it in -stable. Best regards,

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-07-17 Thread Pavel Machek
Hi! > The MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery > charger, a USB Type-C & Power Delivery (PD) controller, dual > Flash LED current sources, a RGB LED driver, a backlight WLED driver, > a display bias dri

Re: [PATCH 6/8] dt-bindings: backlight: Update Lee Jones' email address

2022-07-17 Thread Pavel Machek
Hi! > Going forward, I'll be using my kernel.org for upstream work. > Acked-by: Pavel Machek Let me know if you want to take it through the LED tree. Best regards, Pavel -- People of Russia, stop Putin before his war

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-18 Thread Pavel Machek
This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. > > Signed-off-by: Uwe Kleine-König

Re: [PATCH V6 2/8] backlight: qcom-wled: restructure the qcom-wled bindings

2019-11-04 Thread Pavel Machek
Hi! > If you're going to apply them, you need to send out an immutable > branch for me to pull from. Aha, its backlight, not LED. I really should not be taking those. Sorry for the noise, I dropped them from my tree. Best regards,

LED backlight on Droid 4 and others

2020-01-05 Thread Pavel Machek
. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot Acked-by: Pavel Machek Reviewed-by: Daniel Thompson commit 44b7adbf0b07904e4198ae1d0a763917d1c68a23 Author: Jean-Jacques Hiblot Date: Thu Oct 3 10:28:10

Re: LED backlight on Droid 4 and others

2020-01-05 Thread Pavel Machek
Hi! > > It would be good to get LED backlight to work in clean way for 5.6 > > kernel. > > I agree, this is badly needed for many devices. > > > [If you have an idea what else is needed, it would be welcome; it > > works for me in development tree but not in tree I'd like to > > upstream.] > >

Re: LED backlight on Droid 4 and others

2020-01-05 Thread Pavel Machek
backlight driver This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques

Re: [PATCH v10 6/6] backlight: add led-backlight driver

2020-01-07 Thread Pavel Machek
Hi! > > * Jean-Jacques Hiblot [700101 00:00]: > > > From: Tomi Valkeinen > > > > > > This patch adds a led-backlight driver (led_bl), which is similar to > > > pwm_bl except the driver uses a LED class driver to adjust the > > > brightness in the HW. Multiple LEDs can be used for a single backl

Re: New sysfs interface for privacy screens

2019-10-06 Thread Pavel Machek
On Tue 2019-10-01 10:09:46, Mat King wrote: > Resending in plain text mode > > I have been looking into adding Linux support for electronic privacy > screens which is a feature on some new laptops which is built into the > display and allows users to turn it on instead of needing to use a > physic

Re: New sysfs interface for privacy screens

2019-10-06 Thread Pavel Machek
On Wed 2019-10-02 09:46:50, Jonathan Corbet wrote: > On Tue, 1 Oct 2019 10:09:46 -0600 > Mat King wrote: > > > I have been looking into adding Linux support for electronic privacy > > screens which is a feature on some new laptops which is built into the > > display and allows users to turn it on

Re: New sysfs interface for privacy screens

2019-10-06 Thread Pavel Machek
Hi! > > >> I have been looking into adding Linux support for electronic privacy > > >> screens which is a feature on some new laptops which is built into the > > >> display and allows users to turn it on instead of needing to use a > > >> physical privacy filter. In discussions with my colleagues

Re: [PATCH v8 0/5] Add a generic driver for LED-based backlight

2019-10-08 Thread Pavel Machek
ee/bindings/leds/backlight/led-backlight.txt > > create mode 100644 drivers/video/backlight/led_bl.c > > How should this set be processed? I'm happy to take it through > Backlight via an immutable branch and PR to be consumed by LED. That would make sense to me. For the record,

Re: [PATCH v9 3/5] leds: Add managed API to get a LED from a device driver

2019-10-13 Thread Pavel Machek
Hi! > If the LED is acquired by a consumer device with devm_led_get(), it is > automatically released when the device is detached. > > Signed-off-by: Jean-Jacques Hiblot > Acked-by: Pavel Machek > --- > drivers/leds/led-class.c | 49

Re: [PATCH V6 2/8] backlight: qcom-wled: restructure the qcom-wled bindings

2019-10-13 Thread Pavel Machek
On Mon 2019-09-30 12:09:07, Kiran Gunda wrote: > Restructure the qcom-wled bindings for the better readability. > > Signed-off-by: Kiran Gunda > Reviewed-by: Bjorn Andersson > Reviewed-by: Rob Herring > Acked-by: Daniel Thompson > Acked-by: Pavel Machek I applied 1,2 to

Re: [PATCH] drm: Add support for integrated privacy screens

2019-10-25 Thread Pavel Machek
On Tue 2019-10-22 17:12:06, Rajat Jain wrote: > Certain laptops now come with panels that have integrated privacy > screens on them. This patch adds support for such panels by adding > a privacy-screen property to the drm_connector for the panel, that > the userspace can then use to control and che

Re: LED backlight on Droid 4 and others

2020-02-12 Thread Pavel Machek
Hi! > > > It would be good to get LED backlight to work in clean way for 5.6 > > > kernel. > ... > > > [If you have an idea what else is needed, it would be welcome; it > > > works for me in development tree but not in tree I'd like to > > > upstream.] > > > > > > Lee, would you be willing to tak

Re: LED backlight on Droid 4 and others

2020-02-18 Thread Pavel Machek
Best regards, Pavel commit 81a2daadf8dd6c8e0cbc3b60246932436be3c714 Author: Tomi Valkeinen Date: Thu Oct 3 10:28:12 2019 +0200 backlight: add led-backlight driver This patch adds a led-backlight driver (led_

[PATCH] backlight: add led-backlight driver

2020-02-19 Thread Pavel Machek
Acked-by: Pavel Machek Reviewed-by: Daniel Thompson Acked-by: Lee Jones Acked-by: Tony Lindgren Tested-by: Tony Lindgren Signed-off-by: Pavel Machek --- drivers/video/backlight/Kconfig | 7 ++ drivers/video/backlight/Makefile | 1 + drivers/video/backlight/led_bl.c | 260

Re: [PATCH] backlight: add led-backlight driver

2020-02-19 Thread Pavel Machek
gt; > Signed-off-by: Jean-Jacques Hiblot > > Acked-by: Pavel Machek > > Reviewed-by: Daniel Thompson > > Acked-by: Lee Jones > > Acked-by: Tony Lindgren > > Tested-by: Tony Lindgren > > Signed-off-by: Pavel Machek > > --- > > drivers/video/ba

Re: [PATCH] backlight: add led-backlight driver

2020-02-19 Thread Pavel Machek
; Pavel, care to ack the dts patch? It looks okay to me (but did not test it yet). Acked-by: Pavel Machek Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karl

Re: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-15 Thread Pavel Machek
Hi! > > > > Is this needed? > > > > > > > > This is a remove path, not a power management path, and we have no idea > > > > what the original status of the pin was anyway? > > > > > > > > > > Looking at Ishdn on page 5 of the datasheet, switching it off everytime > > > possible seems not need

AUXdisplay for LED arrays, keyboards with per-key LEDs -- was Re: [PATCH v2 2/2] leds: add aw20xx driver

2023-02-28 Thread Pavel Machek
Hi! > > +config LEDS_AW200XX > > + tristate "LED support for Awinic AW20036/AW20054/AW20072" > > + depends on LEDS_CLASS > > + depends on I2C > > + help > > + This option enables support for the AW20036/AW20054/AW20072 LED > > driver. > > + It is a 3x12/6x9/6x12 matrix LED driver

6.1-rc: names of video outputs changed?

2022-10-31 Thread Pavel Machek
Hi! I used to be able to do: pavel@duo:~$ xrandr --output HDMI1 --mode 1920x1080 --primary warning: output HDMI1 not found; ignoring pavel@duo:~$ xrandr --output VGA1 --mode 1280x1024 --below HDMI1 warning: output VGA1 not found; ignoring ...but now I have to do: pavel@duo:~$ xrandr

Re: 6.1-rc: names of video outputs changed?

2022-10-31 Thread Pavel Machek
Hi! > > I used to be able to do: > > > > pavel@duo:~$ xrandr --output HDMI1 --mode 1920x1080 --primary > > warning: output HDMI1 not found; ignoring > > pavel@duo:~$ xrandr --output VGA1 --mode 1280x1024 --below HDMI1 > > warning: output VGA1 not found; ignoring > > > > ...but now I have

Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code

2022-12-05 Thread Pavel Machek
r now all drivers return success unconditionally. They are adapted > in the following patches to make the changes easier reviewable. > > Signed-off-by: Uwe Kleine-König LED part: Acked-by: Pavel Machek Best regards, Pavel > sta

Re: [PATCH] treewide: Convert del_timer*() to timer_shutdown*()

2022-12-20 Thread Pavel Machek
On Tue 2022-12-20 13:45:19, Steven Rostedt wrote: > [ > Linus, > > I ran the script against your latest master branch: > commit b6bb9676f2165d518b35ba3bea5f1fcfc0d969bf > > As the timer_shutdown*() code is now in your tree, I figured > we can start doing the conversions. At leas

Re: [PATCH v4 0/4] Add PinePhone Pro display support

2023-01-01 Thread Pavel Machek
Hi! > This series add support for the display present in the PinePhone Pro. > > Patch #1 adds a driver for panels using the Himax HX8394 panel controller, > such as the HSD060BHW4 720x1440 TFT LCD panel present in the PinePhone Pro. > > Patch #2 adds a devicetree binding schema for this driver a

Re: [PATCH] drm/display: Add missing OLED Vesa brightnesses definitions

2023-03-25 Thread Pavel Machek
On Wed 2023-03-22 10:05:13, Rodrigo Siqueira wrote: > Cc: Anthony Koo > Cc: Iswara Negulendran > Cc: Felipe Clark > Cc: Harry Wentland > Signed-off-by: Rodrigo Siqueira Some changelog would be useful. > +++ b/include/drm/display/drm_dp.h > @@ -977,6 +977,8 @@ > # define DP_EDP_BACKLIGHT_FR

Re: [PATCH AUTOSEL 4.14 5/6] fbdev: imsttfb: Release framebuffer and dealloc cmap on error path

2023-06-16 Thread Pavel Machek
Hi! > From: Helge Deller > > [ Upstream commit 5cf9a090a39c97f4506b7b53739d469b1c05a7e9 ] > > Add missing cleanups in error path. If we insist this is important enough for -stable, it will need tweaking. The function returns void, so we can't return a value. Best regards,

Re: [PATCH] video/aperture: fix typos

2023-05-12 Thread Pavel Machek
Hi! > > Am 04.04.23 um 06:01 schrieb Sui Jingfeng: > >> EFI FB, VESA FB or VGA FB etc are belong to firmware based framebuffer > >> driver. > > > ... > I fixed that before applying, also removed the "are" in the sentence > above, since it sounded off and repharsed subject line as "Fix typos >

Re: [PATCH AUTOSEL 4.14 1/9] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-07-24 Thread Pavel Machek
Hi! > From: hackyzh002 > > [ Upstream commit f828b681d0cd566f86351c0b913e6cb6ed8c7b9c ] > > The type of size is unsigned, if size is 0x4000, there will be an > integer overflow, size will be zero after size *= sizeof(uint32_t), > will cause uninitialized memory to be referenced later I onl

4.8-rc1: it is now common that machine needs re-run of xrandr after resume

2016-10-18 Thread Pavel Machek
Hi! On Wed 2016-09-14 14:14:35, Jani Nikula wrote: > On Wed, 14 Sep 2016, Jani Nikula wrote: > > On Wed, 14 Sep 2016, Pavel Machek wrote: > >> For the "sometimes need xrandr after resume": I don't think I can > >> bisect that. It only happens sometimes

Re: [regression] Re: 4.11-rc0, thinkpad x220: GPU hang

2017-04-09 Thread Pavel Machek
On Mon 2017-03-06 12:23:41, Chris Wilson wrote: > On Mon, Mar 06, 2017 at 01:10:48PM +0100, Pavel Machek wrote: > > On Mon 2017-03-06 11:15:28, Chris Wilson wrote: > > > On Mon, Mar 06, 2017 at 12:01:51AM +0100, Pavel Machek wrote: > > > > Hi! > > > > &

v4.9-rc3: radeon oops on shutdown

2016-11-07 Thread Pavel Machek
Hi! On old thinkpad T40p... with v4.9-rc3+ I'm getting radeon oops on shutdown. Seems repeatable. Unable to handle kernel NULL pointer dereference at 78c. IP: .. radeon_connector_unregister ... trace: ? drm_connector_unregister.part.5 drm_connector_unregister_all Best regards,

v4.9-rc3: graphical artefacts in X

2016-11-18 Thread Pavel Machek
Hi! With v4.9, if I maximize "nowcast -x" application, I get broken display (as if someone split the window into rectangles and shuffled them a bit). Switching virtual desktops either fixes it or breaks it, depending in how fast I switch. (Yes, strange). pavel at amd:~$ lspci | grep VGA 00:02.0 V

[Intel-gfx] v4.9-rc3: graphical artefacts in X

2016-11-25 Thread Pavel Machek
On Fri 2016-11-18 11:14:16, Chris Wilson wrote: > On Fri, Nov 18, 2016 at 12:02:56PM +0100, Pavel Machek wrote: > > Hi! > > > > With v4.9, if I maximize "nowcast -x" application, I get broken > > display (as if someone split the window into rectangles an

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

2017-07-04 Thread Pavel Machek
Hi! > Are you sure it doesn't probe? It fails the omapdss_stack_is_ready() > check? > >>> > >>> It appears the reason was that I didn't have > >>> CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV enabled. > >>> > >>> I think that's wrong. I don't own an analog TV, so why should I enable > >>> such op

4.11-rc0, thinkpad x220: GPU hang

2017-02-28 Thread Pavel Machek
Hi! mplayer stopped working after a while. Dmesg says: [ 3000.266533] cdc_ether 2-1.2:1.0 usb0: register 'cdc_ether' at usb-:00:1d.0-1.2, CDC Ethernet Device, 22:1b:e4:4e:56:f5 [ 3190.767227] [drm] GPU HANG: ecode 6:0:0xbb409fff, in chromium [4597], reason: Hang on render ring, action: reset

[regression] Re: 4.11-rc0, thinkpad x220: GPU hang

2017-03-05 Thread Pavel Machek
Hi! > > mplayer stopped working after a while. Dmesg says: > > > > [ 3000.266533] cdc_ether 2-1.2:1.0 usb0: register 'cdc_ether' at Now I'm pretty sure it is a regression in v4.11-rc0. Any ideas what to try? Bisect will be slow and nasty :-(.

Re: [regression] Re: 4.11-rc0, thinkpad x220: GPU hang

2017-03-06 Thread Pavel Machek
On Mon 2017-03-06 11:15:28, Chris Wilson wrote: > On Mon, Mar 06, 2017 at 12:01:51AM +0100, Pavel Machek wrote: > > Hi! > > > > > > mplayer stopped working after a while. Dmesg says: > > > > > > > > [ 3000.266533] cdc_ether 2-1.2:1.0 usb0: regi

  1   2   3   4   >