Hi!

> From: Helge Deller <del...@gmx.de>
> 
> [ Upstream commit 5cf9a090a39c97f4506b7b53739d469b1c05a7e9 ]
> 
> Add missing cleanups in error path.

If we insist this is important enough for -stable, it will need
tweaking. The function returns void, so we can't return a value.

Best regards,
                                                                Pavel
                                                                
> +++ b/drivers/video/fbdev/imsttfb.c
> @@ -1452,9 +1452,13 @@ static void init_imstt(struct fb_info *info)
>                     FBINFO_HWACCEL_FILLRECT |
>                     FBINFO_HWACCEL_YPAN;
>  
> -     fb_alloc_cmap(&info->cmap, 0, 0);
> +     if (fb_alloc_cmap(&info->cmap, 0, 0)) {
> +             framebuffer_release(info);
> +             return -ENODEV;
> +     }
>  
>       if (register_framebuffer(info) < 0) {
> +             fb_dealloc_cmap(&info->cmap);
>               framebuffer_release(info);
>               return;
>       }

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature

Reply via email to