[PATCH 20/30] drm/gma500: Add generic cursor functions

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 151 +++ drivers/gpu/drm/gma500/gma_display.h | 5 ++ 2 files changed, 156 insertions(+) diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c index

[PATCH 21/30] drm/gma500/cdv: Convert to generic cursor funcs

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 130 + 1 file changed, 2 insertions(+), 128 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c index e30761a..2351f42

[PATCH 22/30] drm/gma500/psb: Convert to generic cursor funcs

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 157 + 1 file changed, 2 insertions(+), 155 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index f4d308f..1e6a357

[PATCH 23/30] drm/gma500: Add generic encoder functions

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 41 ++ drivers/gpu/drm/gma500/gma_display.h | 4 drivers/gpu/drm/gma500/psb_intel_drv.h | 10 + 3 files changed, 55 insertions(+) diff --git a/drivers/gpu/drm/gma500

[PATCH 24/30] drm/gma500: Convert to generic encoder funcs

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_crt.c | 13 drivers/gpu/drm/gma500/cdv_intel_display.c | 4 +-- drivers/gpu/drm/gma500/cdv_intel_dp.c| 17 +- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 19 ++- drivers/gpu/drm

[PATCH 25/30] drm/gma500: Add generic crtc save/restore funcs

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 105 +++ drivers/gpu/drm/gma500/gma_display.h | 3 + 2 files changed, 108 insertions(+) diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c index

[PATCH 26/30] drm/gma500/psb: Convert to generic save/restore

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 109 + 1 file changed, 2 insertions(+), 107 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index a419e79..317c585

[PATCH 27/30] drm/gma500/cdv: Convert to generic save/restore

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 172 + 1 file changed, 2 insertions(+), 170 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c index 257e0e8..b84912f

[PATCH 29/30] drm/gma500/psb: Convert to generic set_config()

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index 317c585..05faf1c 100644 --- a

[PATCH 28/30] drm/gma500: Add generic set_config() function

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 16 drivers/gpu/drm/gma500/gma_display.h | 3 +++ 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c index cca40c0..2a3e925

[PATCH 30/30] drm/gma500/cdv: Convert to generic set_config()

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c index b84912f..6bca1fe 100644 --- a

Re: [PATCH v3 2/4] drm/gem: convert to new unified vma manager

2013-07-18 Thread Patrik Jakobsson
s exactly the same as before with an > additional lock inside of the vma-manager, which strictly wouldn't be > needed for gem. > > v2: > - rebase on drm-next > - init nodes via drm_vma_node_reset() in drm_gem.c > v3: > - fix tegra > > Cc: Inki Dae > Cc: P

Re: [PATCH 14/15] gma500: nuke the PSB debug stuff

2011-06-09 Thread Patrik Jakobsson
On Thu, Jun 9, 2011 at 12:36 PM, Dave Airlie wrote: > On Thu, 2011-06-09 at 09:11 +0100, Alan Cox wrote: >> On Thu, 9 Jun 2011 03:10:03 +0200 >> Patrik Jakobsson wrote: >> >> > Hi Alan >> > >> > Just a thought. Shouldn't we use the DRM macros fo

Re: Proposal for a low-level Linux display framework

2011-09-20 Thread Patrik Jakobsson
On Mon, Sep 19, 2011 at 9:29 AM, Tomi Valkeinen wrote: >> So DSI is more like i2c than the DisplayPort aux channel or DDC. That > > Well, not quite. DSI is like DisplayPort and DisplayPort aux combined; > there's only one bus, DSI, which is used to transfer video data and > commands. > > For DSI vi

Re: Proposal for a low-level Linux display framework

2011-09-20 Thread Patrik Jakobsson
On Tue, Sep 20, 2011 at 5:55 PM, Keith Packard wrote: > I'm not sure we need a new abstraction that subsumes both DSI and SDVO, Ok. SDVO fits within the current abstraction, but I guess what I'm fishing for is more code sharing of encoders. For instance, the SDVO code in GMA500 could be shared wit

Re: Proposal for a low-level Linux display framework

2011-09-21 Thread Patrik Jakobsson
On Wed, Sep 21, 2011 at 8:01 AM, Tomi Valkeinen wrote: > I don't know what MCS is. MCS is manufacturer specific commands (Manufacturer Command Set). > But DSI is just a bi-directional transfer > protocol between the SoC and the peripheral, you can send arbitrary data > over it. > > Normally the S

Proposal for a low-level Linux display framework

2011-09-20 Thread Patrik Jakobsson
On Mon, Sep 19, 2011 at 9:29 AM, Tomi Valkeinen wrote: >> So DSI is more like i2c than the DisplayPort aux channel or DDC. That > > Well, not quite. DSI is like DisplayPort and DisplayPort aux combined; > there's only one bus, DSI, which is used to transfer video data and > commands. > > For DSI vi

Proposal for a low-level Linux display framework

2011-09-20 Thread Patrik Jakobsson
On Tue, Sep 20, 2011 at 5:55 PM, Keith Packard wrote: > I'm not sure we need a new abstraction that subsumes both DSI and SDVO, Ok. SDVO fits within the current abstraction, but I guess what I'm fishing for is more code sharing of encoders. For instance, the SDVO code in GMA500 could be shared wit

Proposal for a low-level Linux display framework

2011-09-21 Thread Patrik Jakobsson
On Wed, Sep 21, 2011 at 8:01 AM, Tomi Valkeinen wrote: > I don't know what MCS is. MCS is manufacturer specific commands (Manufacturer Command Set). > But DSI is just a bi-directional transfer > protocol between the SoC and the peripheral, you can send arbitrary data > over it. > > Normally the S

[PATCH] cdv: Fix typos in initialization of mdfld_chip_ops

2012-04-28 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/mdfld_device.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/mdfld_device.c b/drivers/gpu/drm/gma500/mdfld_device.c index a0bd48c..717f4db 100644 --- a/drivers/gpu/drm/gma500

[PATCH] intel, gma500, lvds: Fix use after free and mem leak in psb_intel_lvds_init()

2012-01-17 Thread Patrik Jakobsson
On Sat, Jan 14, 2012 at 10:15 PM, Jesper Juhl wrote: > In psb_intel_lvds_init(), if we fail to allocate memory for > 'psb_intel_connector' we free the memory we previously allocated for > 'psb_intel_encoder', but we then proceed to use that free'd pointer > when we do 'psb_intel_encoder->dev_priv =

question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-09 Thread Patrik Jakobsson
On Sun, Jul 8, 2012 at 10:16 PM, Alan Cox wrote: > On Sun, 8 Jul 2012 10:39:43 +0200 (CEST) > Julia Lawall wrote: > >> In the function oaktrail_lvds_mode_set, I don't think that the following >> code makes any sense: >> >> /* Find the connector we're trying to set up */ >> list_

[PATCH 0/9] gma500: Fix SDVO DDC probing on Poulsbo

2011-12-07 Thread Patrik Jakobsson
This set of patches removes psb_intel_output and replaces it with psb_intel_encoder and psb_intel_connector. It also replaces the SDVO code with a slightly modified version from i915. i915 SDVO needs Intel gmbus so this is added along with a SDVO DDC bus guessing fix for Poulsbo. Patrik Jakobsson

[PATCH 1/9] gma500: Initial support for our encoder and connector structs

2011-12-07 Thread Patrik Jakobsson
First step towards adding i915 alike encoder and connector abstractions. This will make life easier when adding i915 output code into our driver. It also removes the old psb_intel_output struct. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c |7 + drivers

[PATCH 2/9] gma500: Remove psb_intel_output from ddc_probe and ddc_get_modes

2011-12-07 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_drv.h |5 +++-- drivers/gpu/drm/gma500/psb_intel_modes.c | 16 +++- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_drv.h b/drivers/gpu/drm/gma500

[PATCH 3/9] gma500: Fix encoder type checking for connectors

2011-12-07 Thread Patrik Jakobsson
Fix cases where we need to know what encoder type is behind a given connector. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c |8 drivers/gpu/drm/gma500/psb_drv.c |6 +++--- drivers/gpu/drm/gma500/psb_intel_display.c | 24

[PATCH 4/9] gma500: Convert PSB LVDS to new output handling

2011-12-07 Thread Patrik Jakobsson
LVDS for PSB now uses psb_intel_encoder and psb_intel_connectors instead of psb_intel_output. i2c_bus and ddc_bus are moved to lvds_priv. There was also a pointer to mode_dev (for no obvious reason) that we now get directly from dev_priv. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm

[PATCH 5/9] gma500: Add support for Intel GMBUS

2011-12-07 Thread Patrik Jakobsson
Before we integrate the new SDVO code we need GMBUS support Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/Makefile|1 + drivers/gpu/drm/gma500/intel_gmbus.c | 493 drivers/gpu/drm/gma500/psb_device.c|7 + drivers/gpu/drm

[PATCH 7/9] gma500: Convert Cedarview to work with new output handling

2011-12-07 Thread Patrik Jakobsson
Replace psb_intel_output with psb_intel_encoder and psb_intel_connector. Things will need to be cleaned up and tested so consider this an initial patch for Cedarview. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_crt.c | 47 +++- drivers/gpu/drm/gma500

[PATCH 6/9] gma500: Replace SDVO code with slightly modified version from i915

2011-12-07 Thread Patrik Jakobsson
Our current SDVO implementation is not working properly, so replace it with a modified version of the i915. Further testing and debugging is needed to make sure we can handle the different SDVO setups and wiring. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_drv.h

[PATCH 8/9] gma500: Convert Moorestown to work with new output handling

2011-12-07 Thread Patrik Jakobsson
Replace psb_intel_output with psb_intel_encoder and psb_intel_connector Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/oaktrail_crtc.c | 18 drivers/gpu/drm/gma500/oaktrail_hdmi.c | 29 +++ drivers/gpu/drm/gma500/oaktrail_lvds.c | 79

[PATCH 9/9] gma500: SDVO DDC bus guessing isn't working so hardcode it instead

2011-12-07 Thread Patrik Jakobsson
We currently don't have support for parsing SDVO mappings from BIOS so we're guessing the bus switch parameter. This isn't working so hardcode it to a configuration known to work on most poulsbo hardware. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_inte

Re: [PATCH 7/9] drm/gma500: use gem get/put page helpers

2013-10-08 Thread Patrik Jakobsson
On Tue, Oct 8, 2013 at 10:19 PM, Rob Clark wrote: > On Tue, Oct 8, 2013 at 3:57 PM, Guillaume CLÉMENT wrote: >> On Wed, Aug 07, 2013 at 01:41:25PM -0400, Rob Clark wrote: >>> Signed-off-by: Rob Clark >>> --- >>> drivers/gpu/drm/gma500/gtt.c | 38 ++ >>> 1 fil

[PATCH 14/15] gma500: nuke the PSB debug stuff

2011-06-09 Thread Patrik Jakobsson
Hi Alan Just a thought. Shouldn't we use the DRM macros for printing debug info? -Patrik On Wed, Jun 8, 2011 at 12:15 PM, Alan Cox wrote: > From: Alan Cox > > Lose all the PSB debug gunge. We can replace it with dev_dbg() like normal > drivers if and when we need debug on stuff. > > Signed-off

[PATCH 14/15] gma500: nuke the PSB debug stuff

2011-06-09 Thread Patrik Jakobsson
On Thu, Jun 9, 2011 at 12:36 PM, Dave Airlie wrote: > On Thu, 2011-06-09 at 09:11 +0100, Alan Cox wrote: >> On Thu, 9 Jun 2011 03:10:03 +0200 >> Patrik Jakobsson wrote: >> >> > Hi Alan >> > >> > Just a thought. Shouldn't we use the DRM macros fo

[patch] drm/gma500: cleanup in psb_mode_operation_ioctl()

2014-03-11 Thread Patrik Jakobsson
On Tue, Feb 18, 2014 at 3:59 PM, Dan Carpenter wrote: > It looks like the "mode" test was changed at some point and but it > wasn't totally cleaned up. I've removed the unneeded indent block and > the duplicative test for "if (mode)". > > Signed-off-by: Dan Carpenter Hi Dan, Sorry for the lat

[RFC 09/12] drm/gma500: Remove dead code

2014-03-11 Thread Patrik Jakobsson
On Fri, Feb 21, 2014 at 8:55 AM, Thierry Reding wrote: > From: Thierry Reding > > The gma500 driver sets DRIVER_GEM unconditionally, so testing for the > absence of the feature will always fail. > > Signed-off-by: Thierry Reding Queued for -next Thanks Patrik > --- > drivers/gpu/drm/gma500/g

[PATCH 1/1] drm/gma500: Code cleanup and adding inline documentation

2014-03-12 Thread Patrik Jakobsson
wing directions from kernel > documentation: DRM > drm/gma500: Improve readability by adding inline documentation > drm/gma500: Removed centralized exiting of function (goto statement), since > it was the only used in one single location with only a return statement. > > CC: Pa

[PATCH 1/1] drm/gma500: Code cleanup and adding inline documentation

2014-03-12 Thread Patrik Jakobsson
nks for the review Patrik! > > In the beginning I guess we will have small talks like this, and after a > while we are on the same line, I guess. ;) > Yes, there is a lot of "process" and it takes a while to get used to it. Documentation/SubmittingPatches is a good read if you have

[PATCH 3/3] drm/gma500: Code cleanup - removal of centralized exiting of function

2014-03-15 Thread Patrik Jakobsson
On Thu, Mar 13, 2014 at 10:49 PM, Arthur Borsboom wrote: > Removed centralized exiting of function (goto statement), since it was the > only used in one single location with only a return statement. As in previous patch, keep the commit message at around 72 cols. > Signed-off-by: Arthur Borsboo

[PATCH 1/3] drm/gma500: Code cleanup - inline documentation

2014-03-15 Thread Patrik Jakobsson
On Thu, Mar 13, 2014 at 10:49 PM, Arthur Borsboom wrote: > Improve readability by adding/changing inline documentation > > Signed-off-by: Arthur Borsboom > --- > drivers/gpu/drm/gma500/psb_drv.c | 56 > +--- > drivers/gpu/drm/gma500/psb_drv.h | 24 +++

[PATCH 2/3] drm/gma500: Code cleanup - style fixes

2014-03-15 Thread Patrik Jakobsson
On Thu, Mar 13, 2014 at 10:49 PM, Arthur Borsboom wrote: > Cleanup of code by following i915 constant/variable names and ordering > Cleanup of code by following directions from kernel documentation: Codingstyle > Cleanup of code by following directions from kernel documentation: DRM ~72 col lines

[PATCH 00/16] drm/gma500: Patches for 3.15-rc1

2014-03-18 Thread Patrik Jakobsson
Arthur Borsboom (3): drm/gma500: Code cleanup - removal of centralized exiting of function drm/gma500: Code cleanup - style fixes drm/gma500: Code cleanup - inline documentation Patrik Jakobsson (12): drm/gma500: Make SGX MMU driver actually do something drm/gma500: Add support for SGX

[PATCH 02/16] drm/gma500: Add support for SGX interrupts

2014-03-18 Thread Patrik Jakobsson
Add 2D blit status and MMU fault interrupts to the IRQ handler. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_irq.c | 81 ++-- 1 file changed, 69 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm

[PATCH 01/16] drm/gma500: Make SGX MMU driver actually do something

2014-03-18 Thread Patrik Jakobsson
Old MMU code never wrote PDs or PTEs to any registers. Now we do, and that's a good start. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/mmu.c | 258 --- drivers/gpu/drm/gma500/psb_drv.c | 4 +- drivers/gpu/drm/gma500/psb_drv.h | 10

[PATCH 04/16] drm/gma500: Add first piece of blitter code

2014-03-18 Thread Patrik Jakobsson
Right now, all we need to know about the blitter is that it's not doing anything that can be messed up when fiddling with MMU mappings. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/Makefile | 1 + drivers/gpu/drm/gma500/blitter.c

[PATCH 07/16] drm/gma500: Remove unused ioctls

2014-03-18 Thread Patrik Jakobsson
All of these ioctls are unused and most of them just duplicate what drm already provides. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 44 --- drivers/gpu/drm/gma500/psb_drv.c | 196 - drivers/gpu/drm/gma500

[PATCH 08/16] drm/gma500: Add backing type and base align to psb_gem_create()

2014-03-18 Thread Patrik Jakobsson
We'll need this for our gem create ioctl in a later patch. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c | 2 +- drivers/gpu/drm/gma500/gem.c | 9 + drivers/gpu/drm/gma500/gem.h | 21 + drivers/gp

[PATCH 05/16] drm/gma500: Hook up the MMU

2014-03-18 Thread Patrik Jakobsson
Properly init the MMU and add MMU entries when adding GTT entries Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gtt.c | 41 drivers/gpu/drm/gma500/psb_drv.c | 27 +- 2 files changed, 55 insertions(+), 13 deletions

[PATCH 06/16] drm/gma500: Always trap MMU page faults

2014-03-18 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_drv.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c index 89804fd..99e8f78 100644 --- a/drivers/gpu/drm/gma500/psb_drv.c +++ b/drivers

[PATCH 09/16] drm/gma500: Remove dead code

2014-03-18 Thread Patrik Jakobsson
From: Thierry Reding The gma500 driver sets DRIVER_GEM unconditionally, so testing for the absence of the feature will always fail. Signed-off-by: Thierry Reding Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu

[PATCH 11/16] drm/gma500: Unify _get_core_freq for cdv and psb

2014-03-18 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/Makefile | 1 + drivers/gpu/drm/gma500/cdv_device.c | 40 ++ drivers/gpu/drm/gma500/gma_device.c | 56 + drivers/gpu/drm/gma500/gma_device.h | 21 ++ drivers

[PATCH 12/16] drm/gma500: Unify encoder mode fixup

2014-03-18 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_crt.c | 9 + drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 9 + drivers/gpu/drm/gma500/gma_display.c| 7 +++ drivers/gpu/drm/gma500/gma_display.h| 3 +++ drivers/gpu/drm/gma500/oaktrail_hdmi.c | 9

[PATCH 13/16] drm/gma500/cdv: Cedarview display cleanups

2014-03-18 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 71 -- 1 file changed, 19 insertions(+), 52 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c index 8fbfa06..7ff91ce

[PATCH 03/16] drm/gma500: Give MMU code it's own header file

2014-03-18 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/mmu.c | 45 +-- drivers/gpu/drm/gma500/mmu.h | 93 drivers/gpu/drm/gma500/psb_drv.h | 45 +-- 3 files changed, 95 insertions(+), 88 deletions(-) create

[PATCH 10/16] drm/gma500: Move asle interrupt work into a work task

2014-03-18 Thread Patrik Jakobsson
Previously the backlight code was called from IRQ context which isn't allowed. This patch moves all the asle work into a work task which takes care of the locking bug reported by users. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64221 Signed-off-by: Patrik Jakobsson --- driver

[PATCH 14/16] drm/gma500: Code cleanup - removal of centralized exiting of function

2014-03-18 Thread Patrik Jakobsson
From: Arthur Borsboom Removed centralized exiting of function (goto statement), since it was the only used in one single location with only a return statement. Signed-off-by: Arthur Borsboom Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_drv.c | 7 +-- 1 file changed, 1

[PATCH 15/16] drm/gma500: Code cleanup - style fixes

2014-03-18 Thread Patrik Jakobsson
From: Arthur Borsboom Code cleanup by following i915 constant/variable names and ordering Code cleanup by following directions from kernel doc: Codingstyle Code cleanup by following directions from kernel doc: DRM Signed-off-by: Arthur Borsboom Signed-off-by: Patrik Jakobsson --- drivers/gpu

[PATCH 16/16] drm/gma500: Code cleanup - inline documentation

2014-03-18 Thread Patrik Jakobsson
From: Arthur Borsboom Improve readability by adding/changing inline documentation Signed-off-by: Arthur Borsboom Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_drv.c | 25 ++-- drivers/gpu/drm/gma500/psb_drv.h | 135 ++- 2 files

[PATCH 1/3] drm/gma500: Code cleanup - removal of centralized exiting of function

2014-03-18 Thread Patrik Jakobsson
On Sat, Mar 15, 2014 at 10:12 PM, Arthur Borsboom wrote: > Removed centralized exiting of function (goto statement), since it was > the only used in one single location with only a return statement. > > Signed-off-by: Arthur Borsboom > --- > drivers/gpu/drm/gma500/psb_drv.c | 7 +-- > 1 file

[GIT PULL] gma500-next

2014-03-20 Thread Patrik Jakobsson
centralized exiting of function drm/gma500: Code cleanup - style fixes drm/gma500: Code cleanup - inline documentation David Herrmann (1): drm/gma500: remove stub .open/postclose Patrik Jakobsson (12): drm/gma500: Make SGX MMU driver actually do something drm/gma500:

[PATCH 2/2] drm/gma500: add locking to fixed panel edid probing

2014-03-23 Thread Patrik Jakobsson
ntel_ddc_get_modes(connector, &lvds_priv->ddc_bus->adapter); > list_for_each_entry(scan, &connector->probed_modes, head) { > if (scan->type & DRM_MODE_TYPE_PREFERRED) { > @@ -827,10 +828,12 @@ void psb_intel_lvds_init(struct drm_device *dev, >

[PATCH 04/11] drm/gma500: Replace DRM_LOG_KMS() by DRM_DEBUG_KMS()

2014-03-24 Thread Patrik Jakobsson
On Mon, Mar 24, 2014 at 9:39 PM, Daniel Vetter wrote: > On Mon, Mar 24, 2014 at 03:53:11PM +, Damien Lespiau wrote: > > There are only a few users of the DRM_LOG_KMS() macro. We can simplify > > the DRM code a bit by replacing them by DRM_DEBUG_KMS(). > > > > Cc: P

[PATCH 00/11] A few patches around DRM logging

2014-03-25 Thread Patrik Jakobsson
have any objection if the driver specific patch go through the DRM tree? > should people judge that series worthwhile, of course. > > I'm ok with this going through the DRM tree. Reviewed-by: Patrik Jakobsson > -- > Damien > > Damien Lespiau (11): > drm: Re

[PATCH 1/1] drm/gma500: Code cleanup - inline documentation

2014-03-29 Thread Patrik Jakobsson
On Thu, Mar 20, 2014 at 6:06 PM, Arthur Borsboom wrote: > Mainly styling fixes of inline documentation > > Signed-off-by: Arthur Borsboom > Hi Arthur I'm not a code style fanatic, but I see a bunch of problems with this patch. If you're going through the hassle of changing stuff in accordance t

[PATCH] drm/dp-helper: Deprecate old i2c-over-dp_aux heleprs

2014-05-07 Thread Patrik Jakobsson
abuse from new drivers. I'll try to find some time to convert gma500 this weekend. If that fails, I'm ok with moving it into gma500. Thanks for reminding me Patrik > Cc: Patrik Jakobsson > Cc: Alan Cox > Cc: Thierry Reding > Signed-off-by: Daniel Vetter > --- >

[PATCH] gma500: Make VGA and HDMI connector hotpluggable

2013-04-02 Thread Patrik Jakobsson
drm_connector_init(dev, connector, >&cdv_hdmi_connector_funcs, > -- Your patch has been applied to: https://github.com/patjak/drm-gma500.git gma500-next We might also consider polling if this causes problems for people, but for now this is fine. No biggie, but your tabs where converted to spaces so I recommend running checkpatch.pl before submitting. Thanks Patrik Jakobsson

[PATCH] drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup

2013-04-02 Thread Patrik Jakobsson
bl)); > dev_priv->lvds_bl = lvds_bl; > } > > -- > 1.7.9.5 > > -- Your patch has been applied to: https://github.com/patjak/drm-gma500.git gma500-next Thanks Patrik Jakobsson

[PATCH] gma500: medfield: Fix possible NULL pointer dereference

2013-04-02 Thread Patrik Jakobsson
eturn; > } > > + dev = sender->dev; > + dev_priv = dev->dev_private; > + > /* Set default display backlight value to 85% (0xd8)*/ > mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1, > true)

gma500: Other things that I could work on

2013-04-03 Thread Patrik Jakobsson
On Wed, Apr 3, 2013 at 5:21 PM, Kero wrote: > Hi, > > I would not mind improving use of my Asus EeePC X101CH with Cedar View / > gma3600 > a bit more. But a barrier is knowledge of the hardware. Meddling with > existing (initialization) > code is possible, but for point 1 and 3 below that is not

gma500: Other things that I could work on

2013-04-07 Thread Patrik Jakobsson
Hi Kero > 4) when using modules, initialization from hibernation is not good enough: >my screen stays black; without using modules, the kernel boots normally, > and everything is fine. > 5) initialization from suspend is not good enough: my Asus stays in >some text mode (80x25?), but show

[PATCH] drivers/gpu/drm/gma500:fix build failure for 3.9-rc5

2013-04-09 Thread Patrik Jakobsson
On Tue, Apr 9, 2013 at 8:35 AM, Xiong Zhou wrote: > From: Xiong Zhou > > This patch fixes build failure of v3.9-rc5. > When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure. > gma5/600 needs acpi_video just like nouveau. > > Failure message: > drivers/built-in.o: In function `psb_d

[PATCH v2] gma500:fix build failure for 3.9-rc5

2013-04-10 Thread Patrik Jakobsson
On Wed, Apr 10, 2013 at 2:37 PM, Xiong Zhou wrote: > From: Xiong Zhou > > Last version of this patch is not clear enough and X86 duplicated. > > This patch fixes build failure of v3.9-rc5 and rc6. > When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure. > GMA5/600 needs acpi_video

[PATCH 00/15] drm/gma500: Requesting review for gma500-next

2013-04-10 Thread Patrik Jakobsson
ssues with hibernating on Cedarview but hopefully no regressions. The repository can be found at: https://github.com/patjak/drm-gma500.git gma500-next Thanks Patrik Jakobsson Alexandru Gheorghiu (1): drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup Kero van Gelder (1):

[PATCH 01/15] gma500: remove unused drm_psb_no_fb

2013-04-10 Thread Patrik Jakobsson
From: Wang YanQing commit f9f23a77f07506a32d9dc1d925bf85c0e7507b66(gma500: remove no_fb bits) remove all the drm_psb_no_fb relations code in gma500 except this line code, so remove it also. Signed-off-by: Wang YanQing Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_drv.h

[PATCH 02/15] drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup

2013-04-10 Thread Patrik Jakobsson
From: Alexandru Gheorghiu Replaced calls kzalloc followed by memcpy with call to kmemdup. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/intel_bios.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 03/15] gma500: medfield: Fix possible NULL pointer dereference

2013-04-10 Thread Patrik Jakobsson
From: Syam Sidhardhan The use of pointer sender should be after the NULL check. Signed-off-by: Syam Sidhardhan Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/mdfld_dsi_output.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500

[PATCH 04/15] drm/gma500: Remove unused i8xx clock limits

2013-04-10 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 54 ++-- 1 file changed, 2 insertions(+), 52 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index 9edb190..414df48

[PATCH 05/15] drm/gma500: Calculate clock in one function instead of three identical

2013-04-10 Thread Patrik Jakobsson
i9xx_clock() and i8xx_clock() did the same calc and psb_intel_clock() just called i9xx_clock() so just move it all into psb_intel_clock(). The same calculation is duplicated in cdv_intel_display.c as well so maybe we can share it later on. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm

[PATCH 06/15] drm/gma500: Type clock limits directly into array and remove defines

2013-04-10 Thread Patrik Jakobsson
This makes it easier to read. We do the same for cdv so it becomes more consistent as well. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 66 +--- 1 file changed, 20 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/gma500

[PATCH 07/15] drm/gma500: Remove unnecessary function exposure

2013-04-10 Thread Patrik Jakobsson
psb_intel_crtc_gamma_set() and psb_intel_crtc_destroy() aren't used outside of psb_intel_display.c right now so no need to expose them. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c |4 ++-- drivers/gpu/drm/gma500/psb_intel_display.h |3 --- 2

[PATCH 08/15] drm/gma500: Clean up various defines

2013-04-10 Thread Patrik Jakobsson
Remove unused defines that we'll never use and fix naming in some include guards Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/intel_bios.h|6 +++--- drivers/gpu/drm/gma500/psb_intel_display.c |2 -- drivers/gpu/drm/gma500/psb_intel_drv.h |

[PATCH 09/15] gma500: Make VGA and HDMI connector hotpluggable

2013-04-10 Thread Patrik Jakobsson
From: Kero van Gelder Both VGA and HDMI connectors are available on my Asus EeePC X101CH. This patch will cause output to be shown on either when plugged in. For both, it shows the leftmost 800x600, of the 1024x600 on LVDS. Signed-off-by: Kero van Gelder Signed-off-by: Patrik Jakobsson

[PATCH 10/15] drm/gma500: Change fb name so pm-utils doesn't apply quirks

2013-04-10 Thread Patrik Jakobsson
By having 'drm' and 'fb' in the fb screeninfo id, pm-utils will leave us alone. Otherwise we'll have quirks up to our ears and resume will break. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH 11/15] drm/gma500: Add support for rebuilding the gtt

2013-04-10 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gtt.c | 45 ++ drivers/gpu/drm/gma500/gtt.h |2 +- 2 files changed, 38 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/gma500/gtt.c b/drivers/gpu/drm/gma500/gtt.c index 04a371a

[PATCH 12/15] drm/gma500: Activate the gtt rebuild on suspend/resume

2013-04-10 Thread Patrik Jakobsson
than sorry. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/power.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c index 889b854..4c575a9 100644 --- a/drivers/gpu/drm/gma500/power.c +++ b/drivers/gpu/drm/gma500/po

[PATCH 13/15] drm/gma500: Add hooks for hibernation

2013-04-10 Thread Patrik Jakobsson
Currently we do whatever is done during suspend/resume but we might need some more work for hibernation so keep them in separate functions. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/power.c | 15 +++ drivers/gpu/drm/gma500/power.h |3 +++ drivers/gpu/drm

[PATCH 14/15] drm/gma500: Fix hibernation problems on sdvo encoders

2013-04-10 Thread Patrik Jakobsson
The state of the SDVO chip is more difficult to save than the LVDS so we do a full mode set on the crtc to get SDVO operational again. The SDVOB/C register is also stored just in case we have special bits set in the future. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500

[PATCH 15/15] gma500:fix build failure for 3.9-rc5

2013-04-10 Thread Patrik Jakobsson
message: drivers/built-in.o: In function `psb_driver_load': kernel-3.9-rc5/drivers/gpu/drm/gma500/psb_drv.c:340: \ undefined reference to `acpi_video_register' make: *** [vmlinux] Error 1 Signed-off-by: Xiong Zhou Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/Kcon

[PATCH] drm/gma500: Check connector status before restoring sdvo

2013-04-16 Thread Patrik Jakobsson
This patch fixes a bug introduced by: commit 749387dc8d8270b279f27a0a794cdf4f4a4aa774 Author: Patrik Jakobsson Date: Sun Apr 7 16:35:50 2013 +0200 drm/gma500: Fix hibernation problems on sdvo encoders The bug is triggered when we do a mode set on a sdvo encoder with all connectors in the

[PATCH] drm/gma500: Add debugging info to psb_gtt_restore()

2013-04-16 Thread Patrik Jakobsson
This makes it easier to see what's going on during resume/restore. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gtt.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/gtt.c b/drivers/gpu/drm/gma500/gtt.c index 2f12faf..01

[GIT PULL] gma500-next

2013-04-16 Thread Patrik Jakobsson
ng info to psb_gtt_restore() (2013-04-15 23:44:56 +0200) Alexandru Gheorghiu (1): drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup Kero van Gelder (1): gma500: Make VGA and HDMI connector hotplu

gma500: Other things that I could work on

2013-04-18 Thread Patrik Jakobsson
On Wed, Apr 17, 2013 at 7:57 PM, Kero wrote: >> > 4) when using modules, initialization from hibernation is not good enough: >> >my screen stays black; without using modules, the kernel boots >> > normally, and everything is fine. >> > 5) initialization from suspend is not good enough: my Asu

[PATCH] drm/gma500: fix backlight hotkeys behaviour on cedarview netbooks

2013-04-24 Thread Patrik Jakobsson
On Wed, Apr 24, 2013 at 5:36 PM, Anisse Astier wrote: > Backlight hotkeys weren't working before on certain cedartrail laptops. > > The source of this problem is that the hotkeys' ASLE opregion interrupts > were simply ignored. Driver seemed to expect the interrupt to be > associated with a pipe,

[GIT PULL] gma500-fixes

2013-04-25 Thread Patrik Jakobsson
n for mode setting (2013-04-25 22:23:36 +0200) Anisse Astier (1): drm/gma500: fix backlight hotkeys behaviour on netbooks Patrik Jakobsson (1): drm/gma500: Increase max resolution for mode setting drivers/gpu/drm/g

abuse of dumb ioctls in exynos

2013-04-30 Thread Patrik Jakobsson
On Mon, Apr 29, 2013 at 12:31 PM, Dave Airlie wrote: >> The reason we (currently) use the dumb buffer interface is because it >> does pretty much exactly what we need it to, as we only want linear >> RGB buffers: > > Except in the cases where it doesn't do what you want, and possibly in > the futu

abuse of dumb ioctls in exynos

2013-04-30 Thread Patrik Jakobsson
On Tue, Apr 30, 2013 at 10:19 PM, Dave Airlie wrote: >>> Except in the cases where it doesn't do what you want, and possibly in >>> the future where it does less of what you want. You've started on a >>> slippery slope, and I'm stopping you before you make things worse. >>> >>> You are going to ha

[Intel-gfx] [PATCH 13/20] drm/gem: create drm_gem_dumb_destroy

2013-08-01 Thread Patrik Jakobsson
reate_dumb *args); > int tegra_bo_dumb_map_offset(struct drm_file *file, struct drm_device *drm, > uint32_t handle, uint64_t *offset); > -int tegra_bo_dumb_destroy(struct drm_file *file, struct drm_device *drm, > - unsigned int handle); > > int tegra_drm_mmap(struct file *file, struct vm_area_struct *vma); > > diff --git a/drivers/staging/imx-drm/imx-drm-core.c > b/drivers/staging/imx-drm/imx-drm-core.c > index 6455305..9b16b56 100644 > --- a/drivers/staging/imx-drm/imx-drm-core.c > +++ b/drivers/staging/imx-drm/imx-drm-core.c > @@ -800,7 +800,7 @@ static struct drm_driver imx_drm_driver = { > .gem_vm_ops = &drm_gem_cma_vm_ops, > .dumb_create= drm_gem_cma_dumb_create, > .dumb_map_offset= drm_gem_cma_dumb_map_offset, > - .dumb_destroy = drm_gem_cma_dumb_destroy, > + .dumb_destroy = drm_gem_dumb_destroy, > > .get_vblank_counter = drm_vblank_count, > .enable_vblank = imx_drm_enable_vblank, > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > index 1da1ca2..4d7ea3d 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -1670,6 +1670,9 @@ int drm_gem_handle_create(struct drm_file *file_priv, > u32 *handlep); > int drm_gem_handle_delete(struct drm_file *filp, u32 handle); > > +int drm_gem_dumb_destroy(struct drm_file *file, > +struct drm_device *dev, > +uint32_t handle); > > void drm_gem_free_mmap_offset(struct drm_gem_object *obj); > int drm_gem_create_mmap_offset(struct drm_gem_object *obj); > diff --git a/include/drm/drm_gem_cma_helper.h > b/include/drm/drm_gem_cma_helper.h > index c34f27f..89b4d7d 100644 > --- a/include/drm/drm_gem_cma_helper.h > +++ b/include/drm/drm_gem_cma_helper.h > @@ -30,14 +30,6 @@ int drm_gem_cma_dumb_map_offset(struct drm_file *file_priv, > /* set vm_flags and we can change the vm attribute to other one at here. */ > int drm_gem_cma_mmap(struct file *filp, struct vm_area_struct *vma); > > -/* > - * destroy memory region allocated. > - * - a gem handle and physical memory region pointed by a gem object > - * would be released by drm_gem_handle_delete(). > - */ > -int drm_gem_cma_dumb_destroy(struct drm_file *file_priv, > - struct drm_device *drm, unsigned int handle); > - > /* allocate physical memory. */ > struct drm_gem_cma_object *drm_gem_cma_create(struct drm_device *drm, > unsigned int size); > -- > 1.8.3.2 Looks good Acked-by: Patrik Jakobsson Thanks Patrik

[GIT PULL] gma500-next

2013-08-09 Thread Patrik Jakobsson
9:43 +0200) -------- Patrik Jakobsson (33): drm/gma500: Add generic code for clock calculation drm/gma500/cdv: Make use of the generic clock code drm/gma500: Make use of gma_pipe_has_type() drm/gma500/psb: Make use of generic clock code drm/gma500: Remove

[PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Patrik Jakobsson
On Sat, Aug 10, 2013 at 9:40 PM, Guillaume CL?MENT wrote: >> >> Can you please submit the exact same change for drm/i915/intel_sdvoc.c >> >> too? The sdvo encoders can be the same ones for psb and i915 so having >> >> the same code would be great. Separate patch for drm/i915 ofc. >> > >> > Are yo

<    1   2   3   4   5   6   7   >