on Cedarview HW.
>
> v2:
> * remove fb_base (Patrik)
> * use 'static inline' in header files (kernel test robot)
> * fix many minor issues and typos
>
Thanks Thomas! For the entire series:
Acked-by: Patrik Jakobsson
> Thomas Zimmermann (7):
>
On Sun, Mar 19, 2023 at 3:23 PM Tom Rix wrote:
>
> clang with W=1 reports
> drivers/gpu/drm/gma500/psb_irq.c:35:19: error: unused function
> 'gma_pipe_event' [-Werror,-Wunused-function]
> static inline u32 gma_pipe_event(int pipe)
> ^
> This function is not used, so remove it.
On Mon, May 22, 2023 at 09:06:37PM +0200, Thomas Zimmermann wrote:
> The fbdev framebuffer is I/O memory, so clear it with fb_memset_io().
> Fixes the following sparse warning:
>
> ../drivers/gpu/drm/gma500/fbdev.c:234:20: warning: incorrect type in argument
> 1 (different address spaces)
> ../dr
On Tue, May 23, 2023 at 1:29 PM Thomas Zimmermann wrote:
>
> Hi
>
> Am 23.05.23 um 09:00 schrieb Patrik Jakobsson:
> > On Mon, May 22, 2023 at 09:06:37PM +0200, Thomas Zimmermann wrote:
> >> The fbdev framebuffer is I/O memory, so clear it with fb_memset_io().
>
On Tue, Jul 25, 2023 at 02:31:07PM -0300, Jorge Maidana wrote:
> Remove identical duplicate block of macro definitions in
> drivers/gpu/drm/gma500/psb_drv.h.
>
> Signed-off-by: Jorge Maidana
Applied to drm-misc-next
Thanks
Patrik
> ---
> drivers/gpu/drm/gma500/psb_drv.h | 8
> 1 file
On Fri, Jul 28, 2023 at 02:58:55AM +0800, Sui Jingfeng wrote:
> Because the gma_irq_install() is call after psb_gem_mm_init() function,
> when psb_gem_mm_init() fails, the interrupt line haven't been allocated.
> Yet the gma_irq_uninstall() is called in the psb_driver_unload() function
> without ch
On Thu, Aug 17, 2023 at 09:37:54PM +0800, Yue Haibing wrote:
> These declarations are not implemented now, remove them.
>
> Signed-off-by: Yue Haibing
Applied to drm-misc-next
Thanks
Patrik
> ---
> drivers/gpu/drm/gma500/gma_display.h | 1 -
> drivers/gpu/drm/gma500/psb_intel_drv.h | 14 --
On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini wrote:
> Replace explicit computation of vma page count by a call to
> vma_pages()
Hi, I already have this patch in the "queue" from:
Muhammad Falak R Wani
Will include that one when I get around to sending out a PR.
Thanks
Patrik
>
> Signed-off-by
On Tue, Oct 11, 2016 at 10:15 AM, Daniel Vetter wrote:
> On Mon, Oct 10, 2016 at 07:22:47AM +0530, Shyam Saini wrote:
>> On Mon, 2016-10-10 at 01:46 +0200, Patrik Jakobsson wrote:
>> > On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini
>> > wrote:
>> > >
>>
Hi,
Sorry for late reply. Could be that we're not restoring the state
properly. Not sure though that we guarantee that the framebuffer
contents is valid after unbind. Perhaps take a look at what other
drivers do. I see the same issue on my PSB systems which run SDVO so
it is at least not LVDS rela
://bugs.freedesktop.org/show_bug.cgi?id=78562
Cc:
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_intel_lvds.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_intel_lvds.c
b/drivers/gpu/drm/gma500/psb_intel_lvds.c
index
On Wed, Jan 25, 2017 at 7:26 AM, Daniel Vetter wrote:
> Returning 0 for an on-chip gpu doesn't change anything at all.
>
> Cc: Patrik Jakobsson
> Signed-off-by: Daniel Vetter
Acked-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/psb_drv.c | 6 --
> 1
Hook up drm_compat_ioctl to support 32-bit userspace on 64-bit kernels.
It turns out that N2600 and N2800 comes with 64-bit enabled. We
previously assumed there where no such systems out there.
Cc: stable at vger.kernel.org
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_drv.c
On Tue, Nov 1, 2016 at 4:40 PM, Jani Nikula wrote:
> If we define drm_compat_ioctl NULL on CONFIG_COMPAT=n, we don't have to
> check for the config everywhere.
>
> Signed-off-by: Jani Nikula
Looks good and I like the idea.
Reviewed-by: Patrik Jakobsson
> ---
>
&
On Tue, Feb 28, 2017 at 1:55 PM, Joe Perches wrote:
> Use a more common logging style.
>
> Miscellanea:
>
> o Coalesce formats and realign arguments
> o Neaten a few macros now using pr_
>
> Signed-off-by: Joe Perches
For the gma500 changes:
Acked-by: Patrik Jakobsso
On Fri, May 19, 2017 at 11:19 AM, Gustavo A. R. Silva
wrote:
> Local variable use_gct is assigned to a constant value and it is never
> updated again. Remove this variable and the dead code it guards.
>
> Addresses-Coverity-ID: 145690
> Signed-off-by: Gustavo A. R. Silva
I believe the first vers
On Fri, May 19, 2017 at 2:28 PM, Patrik Jakobsson
wrote:
> On Fri, May 19, 2017 at 11:19 AM, Gustavo A. R. Silva
> wrote:
>> Local variable use_gct is assigned to a constant value and it is never
>> updated again. Remove this variable and the dead code it guards.
>>
x27;
> [-Werror=unused-variable]
>
> This removes them as well.
>
> Fixes: 94d7fb4982d2 ("gpu: drm: gma500: remove dead code")
> Signed-off-by: Arnd Bergmann
Thanks, I'll take this through drm-misc
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/g
Hi Dave and Daniel,
We had a little mishap this morning when I had pushed a fix for gma500
into drm-misc-fixes without first getting someone to review it. The
patch have been on the list for over a month and I don't feel like I
have enough karma to force someone to review it. Since I'm the only
on
On Wed, May 24, 2017 at 9:52 PM, Daniel Vetter wrote:
> On Wed, May 24, 2017 at 6:57 PM, Patrik Jakobsson
> wrote:
>> Hi Dave and Daniel,
>>
>> We had a little mishap this morning when I had pushed a fix for gma500
>> into drm-misc-fixes without first getting some
On Fri, May 26, 2017 at 8:49 AM, Daniel Vetter wrote:
> On Thu, May 25, 2017 at 1:09 AM, Patrik Jakobsson
> wrote:
>> On Wed, May 24, 2017 at 9:52 PM, Daniel Vetter wrote:
>>> On Wed, May 24, 2017 at 6:57 PM, Patrik Jakobsson
>>> wrote:
>>>> Hi Dave an
On Fri, May 26, 2017 at 1:44 PM, Daniel Vetter wrote:
> On Fri, May 26, 2017 at 1:42 PM, Jani Nikula
> wrote:
>> On Fri, 26 May 2017, Daniel Vetter wrote:
>>> On Thu, May 25, 2017 at 1:09 AM, Patrik Jakobsson
>>> wrote:
>>>> Either way, I don't wa
re's a hard rule about
that. I'll fix it up and take it through drm-misc-next.
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/accel_2d.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/accel_2d.c
>
On Mon, May 29, 2017 at 9:35 AM, Daniel Vetter wrote:
> On Mon, May 29, 2017 at 8:53 AM, Daniel Vetter wrote:
Find another smaller driver in need of some cleanup (we can add more
to drm-misc), cross review. Yes it's a bit of work (see above), but at
least from the drm subsystem pov
of no HW, but buildbot is happy with this series at
> least. A branch can be found here:
Not sure anybody have hardware to test mdfld + tc358765. Perhaps some
smartphone exists but I've never seen one.
FWIW, for the small gma500 change you have my:
Acked-by: Patrik Jakobsson
Cheers
>
On Sat, Oct 29, 2016 at 9:13 PM, Paul Gortmaker
wrote:
> Dusted off an old Portwell nano-8044 that hadn't been booted for years
> and found that it wouldn't boot mainline - it puts the D-sub VGA into no
> signal mode. Hooking up a serial cable and I see a boot splat, which I
> bisected down to
>
On Fri, Sep 2, 2016 at 11:31 AM, wrote:
>
> JiangBiao162664/user/zte_ltd Wrote 2016/08/31 10:27:34:
>
>> JiangBiao162664/user/zte_ltd
>> 2016/08/31 10:27
>>
>> From
>> Patrik Jakobsson ,
>> Re: [PATCH] drm/gma500: remove the process of stolen page in
On Tue, Sep 20, 2016 at 2:08 PM, Jani Nikula
wrote:
> On Tue, 20 Sep 2016, Dan Carpenter wrote:
>> Don't be a dummy... This is easy to review an it fixes a bug.
In this particular case it might not be clear that an unknown GCT
version causes a complete GCT failure so both messages are useful.
On Wed, May 18, 2016 at 10:31 PM, Heinrich Schuchardt
wrote:
> Only dereference sender after checking if sender is NULL.
Hi Heinrich
I think we had a patch that did something similar a while ago. Don't
remember what happened to it. We do check for !sender right before
calling this function (at o
On Sat, May 21, 2016 at 3:21 PM, Muhammad Falak R Wani
wrote:
> Replace explicit computation of vma page count by a call to
> vma_pages()
>
> Signed-off-by: Muhammad Falak R Wani
Thanks, queued for gma500-next
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 2 +-
> 1 file changed, 1 insertion(+
On Tue, Feb 16, 2016 at 10:44 PM, Daniel Vetter wrote:
> On Tue, Feb 16, 2016 at 11:44:52AM +1000, Dave Airlie wrote:
>> On 15 February 2016 at 20:06, Daniel Vetter
>> wrote:
>> > Hi all,
>> >
>> > I've already chatted with some of you in private, here's the entire idea
>> > with a
>> > bit mor
function
This is called without dev->struct_mutex held, we need to use the
_unlocked variant.
Never caught in the wild since you'd need an evil userspace which
races a gem_close ioctl call with the in-progress open.
Cc: Patrik Jakobsson
Acked-by: Patrik J
git-send-email-sudipm.mukherjee
at gmail.com
Acked-by: Patrik Jakobsson
Signed-off-by: Daniel Vetter
Thanks
Patrik
On Thu, Feb 18, 2016 at 3:58 PM, Daniel Wagner
wrote:
> 9a69a9ac20f7 ("drm: Make the connector dpms callback
> return a value, v2.") wants mdfld_dsi_connector
tire function can be
> replaced by a simple if call.
>
> Signed-off-by: Alan Cox
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 20
> 1 file changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/d
On Mon, Jan 11, 2016 at 10:41 PM, Daniel Vetter
wrote:
> I'm auditing them all, empty ones just confuse ...
>
> Cc: Patrik Jakobsson
> Acked-by: Daniel Stone
> Reviewed-by: Alex Deucher
> Signed-off-by: Daniel Vetter
Acked-by: Patrik Jakobsson
> ---
> drivers
On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter wrote:
>
> On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > gcc -Wextra notices that one of the fields in psbfb_roll_ops has two
> > initializers:
> >
> > drivers/gpu/drm/gma500/framebuffer.c:185:20: warn
GTT roll support was used to accelerate fb panning on some machines.
Unfortunately this never worked properly with multiple monitors and
caused issues on others where the framebuffer wouldn't fit in stolen
memory. Let's remove it!
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/
On Tue, Oct 27, 2020 at 5:50 PM Arnd Bergmann wrote:
>
> On Tue, Oct 27, 2020 at 10:54 AM Patrik Jakobsson
> wrote:
> > On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter wrote:
> > > On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote:
> > > > From
On Wed, Oct 28, 2020 at 4:41 PM Daniel Vetter wrote:
>
> On Wed, Oct 28, 2020 at 3:36 PM Patrik Jakobsson
> wrote:
> >
> > GTT roll support was used to accelerate fb panning on some machines.
> > Unfortunately this never worked properly with multiple monitors and
On Mon, Jun 22, 2020 at 10:45 PM Denis Efremov wrote:
>
> psb_accel_2d_copy() checks direction PSB_2D_COPYORDER_BR2TL twice.
> Based on psb_accel_2d_copy_direction() results, PSB_2D_COPYORDER_TL2BR
> should be checked instead in the second direction check.
>
> Fixes: 4d8d096e9ae8 ("gma500: introdu
On Sat, Jun 27, 2020 at 12:01 AM Linus Walleij wrote:
>
> This file includes but does not use any
> symbols from it, drop the include.
Hi Linus,
Seems the include should be moved to mdfld_dsi_output.c instead.
Thanks
Patrik
>
> Cc: Patrik Jakobsson
> Signed-off
tform/intel-mid) exists: the
> GMA500 probes directly from the PCI device. Apparently GPIOs
> 88 and 34 are used on all of these so just go ahead and
Is 88 meant to be 128 here?
> register those for resetting the DSI pipes.
>
> Cc: Patrik Jakobsson
> Signed-off-by: Linus Walleij
On Mon, Apr 20, 2020 at 8:04 PM Souptick Joarder wrote:
>
> These are dead code since 3.7. If there is no plan to use them further,
> these can be removed forever.
Thanks. Will apply to drm-misc-next.
Signed-off-by: Patrik Jakobsson
>
> Signed-off-by: Souptick Joarder
>
On Wed, Aug 5, 2020 at 10:59 PM wrote:
>
> From: Tom Rix
>
> Reviewing this block of code in cdv_intel_dp_init()
>
> ret = cdv_intel_dp_aux_native_read(gma_encoder, DP_DPCD_REV, ...
>
> cdv_intel_edp_panel_vdd_off(gma_encoder);
> if (ret == 0) {
> /* if this fails, presume the device is a
tform/intel-mid) exists: the
> GMA500 probes directly from the PCI device. Apparently GPIOs
> 128 and 34 are used on all of these so just go ahead and
> register those for resetting the DSI pipes.
>
> Acked-by: Patrik Jakobsson
> Signed-off-by: Linus Walleij
> ---
> ChangeL
On Mon, May 11, 2015 at 5:54 PM, Nicholas Krause wrote:
>
>
> On May 11, 2015 4:24:01 AM EDT, Patrik Jakobsson gmail.com> wrote:
>>On Sun, May 10, 2015 at 9:50 PM, Nicholas Krause
>>wrote:
>>>
>>>
>>> On May 10, 2015 3:45:36 PM EDT, patrik
myself.
>
> Ping. Anyone interested in rotation actually working with
> drm_plane_helper_check_update() ?
>
Passing state structs sounds better but since that patch doesn't exist
I'd go for this one.
There are now more users of drm_plane_helper_check_upd
ivers, where an atomic commit can
> fail with -EINTR or -ENOMEM and should be restarted.
>
> Changes since v1:
> - Fix compiler warning. (Emil)
> - Fix commit message (Daniel)
>
> Cc: Alex Deucher
> Acked-by: Alex Deucher
> Cc: Christian König
> Cc: David Airlie
&
On Tue, Jun 7, 2016 at 4:07 PM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Replace the legacy drm_vblank_{on,off}() with the new helper functions.
>
> Signed-off-by: Gustavo Padovan
Acked-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/gma_display.c | 2 +-
On Mon, Jun 9, 2014 at 5:41 PM, Jani Nikula
wrote:
>
> Patrik, Alan -
>
> Should you add a MAINTAINERS entry for gma500 with one or both of you as
> maintainers? What's the status?
>
> BR,
> Jani.
Hi Jani
Adding an entry would make people think that I have time to spend on gma500
development or
The psb_intel_crtc is generic and should be named appropriately
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_crt.c | 7 +-
drivers/gpu/drm/gma500/cdv_intel_display.c | 28 +++
drivers/gpu/drm/gma500/cdv_intel_dp.c| 10 +--
drivers/gpu/drm/gma500
The psb_intel_connector is generic and should be named appropriately
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_crt.c | 14 +++---
drivers/gpu/drm/gma500/cdv_intel_dp.c | 16
drivers/gpu/drm/gma500/cdv_intel_hdmi.c| 12
-
> struct cdv_intel_limit_t {
> struct cdv_intel_range_t dot, vco, n, m, m1, m2, p, p1;
> struct cdv_intel_p2_t p2;
> --
> 1.8.3
Hi Stéphane
I have already removed that define in my gma500-next branch. You can check the
official repo at: git://gi
reate_dumb *args);
> int tegra_bo_dumb_map_offset(struct drm_file *file, struct drm_device *drm,
> uint32_t handle, uint64_t *offset);
> -int tegra_bo_dumb_destroy(struct drm_file *file, struct drm_device *drm,
> - unsigned int handle);
9:43 +0200)
--------
Patrik Jakobsson (33):
drm/gma500: Add generic code for clock calculation
drm/gma500/cdv: Make use of the generic clock code
drm/gma500: Make use of gma_pipe_has_type()
drm/gma500/psb: Make use of generic clock code
drm/gma500: Remove
On Sat, Aug 10, 2013 at 9:40 PM, Guillaume CLÉMENT wrote:
>> >> Can you please submit the exact same change for drm/i915/intel_sdvoc.c
>> >> too? The sdvo encoders can be the same ones for psb and i915 so having
>> >> the same code would be great. Separate patch for drm/i915 ofc.
>> >
>> > Are you
On Sun, Aug 11, 2013 at 12:00 PM, Daniel Vetter wrote:
> On Sat, Aug 10, 2013 at 10:12 PM, Patrik Jakobsson
> wrote:
>> I will give this a spin on my gma500 and i915 hardware on monday. The gma500
>> sdvo code should be pretty much identical to i915 from around 2011 but I
On Fri, Sep 20, 2013 at 3:56 PM, Dave Jones wrote:
> This code appears to be calling psb_gtt_free_range twice with the same args.
> (The second call didn't appear in the diff output, it's right after the
> mutex_unlock)
>
> Spotted with Coverity, not tested due to lack of hardware.
>
> Signed-off
; -#endif
> +#endif
> }
>
> void gma_backlight_set(struct drm_device *dev, int v)
> @@ -67,7 +67,7 @@ void gma_backlight_set(struct drm_device *dev, int v)
> dev_priv->backlight_device->props.brightness = v;
> do_gma_backlight_set(dev);
> }
> -#endif
On Tue, Aug 30, 2016 at 7:10 AM, wrote:
>
> Direct gtt range is used in the page fault scene in current driver,
> instead of stolen page. So no need to keep relative process.
Hi
Are you saying that we don't use stolen memory? Afaik stolen memory
should be accessed through the stolen range so we
y-bounds]
> u32 dspcntr = dev_priv->dspcntr[pipe];
> ^
>
> Fix this by checking for a valid pipe before indexing the pipeconf and
> dspcntr arrays.
>
> Cc: Patrik Jakobsson
> Signed-off-by: Thierry Reding
Reviewed-by: Patrik Jakobsson
ollow the execution path then we should be freeing
>> backing after we have released the helper. So remove the one which frees
>> backing before the helper is released.
>> While at it the error labels are also renamed to give a meaningful
>> name.
>>
>> Sign
does is: if (mode == connector->dpms)
>
> Signed-off-by: Sudip Mukherjee
Looks good, thanks.
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/mdfld_dsi_output.c | 12 +---
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/
Hi Carlos
Any particular reason why this patch isn't squashed with patch 8/17?
Thanks
Patrik
On Mon, Feb 15, 2016 at 1:58 PM, Carlos Palminha
wrote:
> mode_fixup function for encoder drivers became optional with patch
> http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-e
ummy mode_fixup implementations.
>
> (made on top of Daniel topic/drm-misc branch)
>
> Signed-off-by: Carlos Palminha
Reviewed-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/cdv_intel_crt.c | 1 -
> drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 1 -
> drivers/gpu/drm/gma500/gma_disp
On Thu, Sep 24, 2015 at 10:07 AM, Thierry Reding
wrote:
> From: Thierry Reding
>
> The DRM/DP helpers already contain a definition for this macro. Remove
> the duplicate in the GMA500 driver to avoid having to keep both updated
> synchronously.
>
> Cc: Patrik Jakobsson
>
On Thu, Sep 24, 2015 at 5:57 PM, Sudip Mukherjee
wrote:
> On Wed, Sep 09, 2015 at 06:20:40PM +0530, Sudip Mukherjee wrote:
>> If backing->stolen is true then we were freeing backing by calling
>> psb_gtt_free_range() but we called it again after unlocking the mutex.
>> Lets make it NULL after free
On Wed, Mar 23, 2016 at 2:28 AM, One Thousand Gnomes
wrote:
> On Tue, 22 Mar 2016 16:40:18 -0700
> Joe Perches wrote:
>
>> On Tue, 2016-03-22 at 22:49 +, Colin King wrote:
>> > From: Colin Ian King
>> >
>> > There is a missing comma between two strings in the dsi_errors[]
>> > array initiali
On Thu, Apr 7, 2016 at 5:52 PM, Sudip Mukherjee
wrote:
> On Wednesday 09 December 2015 05:50 PM, Patrik Jakobsson wrote:
>>
>> On Wed, Dec 9, 2015 at 12:53 PM, Sudip Mukherjee
>> wrote:
>>>
>>> On Thu, Oct 08, 2015 at 06:17:48PM +0530, Sudip Mukherjee wro
Hi Dave,
A few fixes and cleanups for 4.7 that's been collecting dust in my
inbox for a while.
Thanks
Patrik
The following changes since commit d00b39c17573ece6f5fb1385314877d29f540db8:
Merge branch 'drm-next-analogix-dp-v2' of
github.com:yakir-Yang/linux into drm-next (2016-04-06 09:57:33 +1
On Fri, Apr 22, 2016 at 1:03 AM, Emil Velikov
wrote:
> Cc: Patrik Jakobsson
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: Emil Velikov
> ---
> MAINTAINERS | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
On Mon, Oct 1, 2018 at 5:36 PM Phillip Potter wrote:
>
> Replace all 120ms mdelay macro calls with msleep function calls. As msleep is
> not suitable for < 20ms sleeps, also remove comment from mdelay(5) call.
>
> Signed-off-by: Phillip Potter
> ---
> diff --git a/drivers/gpu/drm/gma500/mdfld_dsi
On Tue, Oct 2, 2018 at 10:23 AM Phillip Potter wrote:
>
> On Tue, Oct 02, 2018 at 09:52:51AM +0200, Patrik Jakobsson wrote:
> > Hi Phillip,
> > This is executed while holding a spinlock so we cannot sleep here.
> > This is true for send_pkg_done() as well.
> >
On Sun, Aug 11, 2013 at 12:00 PM, Daniel Vetter wrote:
> On Sat, Aug 10, 2013 at 10:12 PM, Patrik Jakobsson
> wrote:
>> I will give this a spin on my gma500 and i915 hardware on monday. The gma500
>> sdvo code should be pretty much identical to i915 from around 2011 but I
On Wed, Dec 11, 2013 at 11:34 AM, Daniel Vetter
wrote:
> This has the nice advantage that we'll get rid of a DRM_WAIT_ON user
> for free.
>
> Cc: Patrik Jakobsson
> Cc: Alan Cox
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/gma500/psb_irq.c | 15
On Wed, Dec 11, 2013 at 2:24 PM, Daniel Vetter
wrote:
> Cc: Patrik Jakobsson
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/gma500/psb_intel_drv.h | 5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_intel_drv.h
>
e constants with DP_ for improved namespacing.
>
> Signed-off-by: Thierry Reding
Sorry if I'm late to the party. Seems good to me.
Perhaps all that shifting is a little unintuitive but I don't wanna
nitpick this.
Reviewed-by: Patrik Jakobsson
> ---
>
On Tue, Mar 5, 2024 at 5:09 PM Andy Shevchenko
wrote:
>
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
> this driver doesn't use it, so simply remove the unused header.
>
Applied to drm-misc-next
Thanks
P
On Tue, Jul 9, 2024 at 10:59 AM Ma Ke wrote:
>
> In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate()
> is assigned to mode, which will lead to a NULL pointer dereference on
> failure of drm_mode_duplicate(). Add a check to avoid npd.
>
> Cc: sta...@vger.kernel.org
> Fixes: 6a22
On Tue, Jul 9, 2024 at 1:33 PM Ma Ke wrote:
>
> In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate()
> is assigned to mode, which will lead to a NULL pointer dereference on
> failure of drm_mode_duplicate(). Add a check to avoid npd.
>
> Cc: sta...@vger.kernel.org
> Fixes: 6a227
On Thu, Sep 14, 2023 at 09:37:31PM -0700, Kees Cook wrote:
> On Thu, Sep 14, 2023 at 08:52:21PM +, Justin Stitt wrote:
> > `strncpy` is deprecated for use on NUL-terminated destination strings [1].
> >
> > We should prefer more robust and less ambiguous string interfaces.
> >
> > Since `chan-
On Thu, Sep 21, 2023 at 10:47:58AM +0200, Maxime Ripard wrote:
> Hi,
>
> Adding Paul in Cc
>
> On Thu, Sep 21, 2023 at 04:25:50PM +0800, suijingfeng wrote:
> > On 2023/9/19 21:12, Maxime Ripard wrote:
> > > We've had a number of times when a patch slipped through and we couldn't
> > > pick them u
On Thu, Sep 21, 2023 at 1:00 PM Maxime Ripard wrote:
>
> The GMA500 driver has been handled through drm-misc for a while but the
> git repo hasn't been updated. Make sure it points to the right place.
>
> Signed-off-by: Maxime Ripard
Acked-by: Patrik Jakobsson
>
> --
On Tue, Sep 19, 2023 at 04:41:16AM +, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>
> We should prefer more robust and less ambiguous string interfaces.
>
> Since `chan->base.name` is expected to be NUL-terminated, a suitable
> replacement
On Tue, May 7, 2024 at 2:04 PM Thomas Zimmermann wrote:
>
> Implement struct drm_client_funcs with the respective helpers and
> remove the custom code from the emulation. The generic helpers are
> equivalent in functionality.
>
> Signed-off-by: Thomas Zimmermann
Acked-by
Due to changes in the order of initialization the psb_lid_timer_func
could get called without the device being powered. Fix this by checking
the power status before accessing the opregion.
Cc: Enrico Bartky
Cc: Thomas Zimmermann
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500
alled before initialization. That might be
another place to look.
I'll see if I can do some testing on my own.
>
> Best regards
> Thomas
>
> Am 12.04.24 um 09:24 schrieb Patrik Jakobsson:
> > Due to changes in the order of initialization the psb_lid_timer_func
> > could get
ed by the graphics driver so let's get rid of the lid code. This
fixes the crash during boot.
Fixes: 8f1aaccb04b7 ("drm/gma500: Implement client-based fbdev emulation")
Cc: Enrico Bartky
Cc: Thomas Zimmermann
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/Makefile
On Mon, Apr 15, 2024 at 1:45 PM Thomas Zimmermann wrote:
>
> Hi
>
> Am 15.04.24 um 13:27 schrieb Patrik Jakobsson:
> > Due to a change in the order of initialization, the lid timer got
> > started before proper setup was made. This resulted in a crash during
> > b
. Apr. 2024 um 13:57 Uhr schrieb Patrik Jakobsson
> :
>>
>> On Mon, Apr 15, 2024 at 1:45 PM Thomas Zimmermann
>> wrote:
>> >
>> > Hi
>> >
>> > Am 15.04.24 um 13:27 schrieb Patrik Jakobsson:
>> > > Due to a change in the order of in
On Thu, Apr 18, 2024 at 2:40 PM Harshit Mogalapalli
wrote:
>
> Hi,
>
> While fuzzing 5.15.y kernel with Syzkaller, we noticed a INFO: task hung
> bug in fb_deferred_io_work()
>
>
> This is in 5.15.149 tag, and this is introduced by a set of commits:
>
> 2655757a3f10 fbdev: flush deferred IO before
On Thu, Apr 18, 2024 at 4:05 PM Nam Cao wrote:
>
> On 2024-04-18 Patrik Jakobsson wrote:
> > This sounds similar to the SUSE bug [1]. We fixed it by reverting [2]
> > in the SUSE kernel. The problem seems to be that flush_delayed_work()
> > kills the timer and re-que
On Fri, Apr 19, 2024 at 9:45 AM Takashi Iwai wrote:
>
> On Fri, 19 Apr 2024 09:39:09 +0200,
> Harshit Mogalapalli wrote:
> >
> > Hi Takashi,
> >
> > On 19/04/24 12:14, Takashi Iwai wrote:
> > > On Thu, 18 Apr 2024 21:29:57 +0200,
> > > Helge Deller wrote:
> > >>
> > >> On 4/18/24 16:26, Takashi Iw
On Fri, Apr 19, 2024 at 5:34 PM Nam Cao wrote:
>
> On 2024-04-19 Patrik Jakobsson wrote:
> > Neither cancel_delayed_work_sync() or flush_delayed_work() prevent new
> > work from being scheduled after they return.
>
> flush_delayed_work() is called during device closing.
On Thu, Mar 14, 2024 at 5:35 PM Colin Ian King wrote:
>
> There is a spelling mistake in a DRM_DEBUG_KMS message. Fix it.
>
> Signed-off-by: Colin Ian King
Applied to drm-misc-next
Thanks
Patrik
> ---
> drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion
ock.m1' may be used
> uninitialized in this function
> drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.n' may be used
> uninitialized in this function
>
> This adds an initialization at declaration time to avoid the warning
> and make it well-defined on
t in case of gma500 it's hard to resist. No need to change
this.
This might already have been merged but if not:
Reviewed-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/cdv_intel_display.c | 13 ++---
> drivers/gpu/drm/gma500/gma_display.c | 7 ---
On Thu, Jan 11, 2024 at 06:56:48AM +, GuoHua Chen wrote:
Hi,
Please use the correct prefix: drm/gma500
Also, the change is made in cdv_intel_dp.c and not cdv_intel_dp.h. This
seems to be wrong in most of the patches you sent.
Please send these fixes as a series. That makes them easier to pr
This set of patches removes psb_intel_output and replaces it with
psb_intel_encoder and psb_intel_connector. It also replaces the SDVO code with a
slightly modified version from i915. i915 SDVO needs Intel gmbus so this is
added along with a SDVO DDC bus guessing fix for Poulsbo.
Patrik Jakobsson
First step towards adding i915 alike encoder and connector abstractions. This
will make life easier when adding i915 output code into our driver. It also
removes the old psb_intel_output struct.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_intel_display.c |7 +
drivers
201 - 300 of 644 matches
Mail list logo
