On Thu, Jan 11, 2024 at 06:56:48AM +0000, GuoHua Chen wrote:
Hi,
Please use the correct prefix: drm/gma500
Also, the change is made in cdv_intel_dp.c and not cdv_intel_dp.h. This
seems to be wrong in most of the patches you sent.
Please send these fixes as a series. That makes them easier to process.
> Fix the following errors reported by checkpatch:
>
> ERROR: else should follow close brace '}'
>
> Signed-off-by: GuoHua Chen <chenguohua_...@163.com>
> ---
> drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c
> b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> index 27cfeb6b470f..135a1226df1a 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> @@ -735,7 +735,7 @@ cdv_intel_dp_aux_native_read(struct gma_encoder *encoder,
> if ((ack & DP_AUX_NATIVE_REPLY_MASK) ==
> DP_AUX_NATIVE_REPLY_ACK) {
> memcpy(recv, reply + 1, ret - 1);
> return ret - 1;
> - } else
> + } else
This doesn't apply. Not sure what happened here. You're removing a
trailing space but the error in your description says you need to fix
the style of an if-else statement.
-Patrik
> if ((ack & DP_AUX_NATIVE_REPLY_MASK) ==
> DP_AUX_NATIVE_REPLY_DEFER)
> udelay(100);
> else
> --
> 2.17.1
>
