+
Drop. Not needed as there is only one reg now.
[...]
Nick Chan
rivers/clk/clk-apple-nco.c
> F: drivers/cpufreq/apple-soc-cpufreq.c
> F: drivers/dma/apple-admac.c
> +F: drivers/gpu/drm/adp/
> F: drivers/pmdomain/apple/
> F: drivers/i2c/busses/i2c-pasemi-core.c
> F: drivers/i2c/busses/i2c-pasemi-platform.c
>
Nick Chan
;0x2 0x2860 0x0 0x10>;
> + power-domains = <&ps_dispdfr_fe>, <&ps_dispdfr_be>,
> <&ps_mipi_dsi>;
> + interrupt-parent = <&aic>;
> + interrupts = ,
> + ;
> + interrupt-names = "be", "fe";
> + status = "disabled";
> + iommus = <&displaydfr_dart 0>;
> + };
> +
> + displaydfr_dart: iommu@228304000 {
> + compatible = "apple,t8110-dart";
> + reg = <0x2 0x28304000 0x0 0x4000>;
> + interrupt-parent = <&aic>;
> + interrupts = ;
> + #iommu-cells = <1>;
> + power-domains = <&ps_dispdfr_fe>;
> + status = "disabled";
> + };
> +
> sio_dart: iommu@235004000 {
> compatible = "apple,t8110-dart";
> reg = <0x2 0x35004000 0x0 0x4000>;
>
Nick Chan
ings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> Best regards,
> Krzysztof
Nick Chan
t; + interrupts = ,
> + ;
> + interrupt-names = "be", "fe";
> + status = "disabled";
Forgot to add, status should go after other properties here as well.
> + iommus = <&displaydfr_dart 0>;
> + };
[...]
Nick Chan
On 9/12/2024 17:16, Krzysztof Kozlowski wrote:
> On Sat, Dec 07, 2024 at 09:03:14PM +0800, Nick Chan wrote:
>> Add the device tree bindings for backlight controllers attached via Apple
>> DWI 2-wire interface.
[...]
Ack all the changes, will be in v4.
Nick Chan
Add the device tree bindings for backlight controllers attached via Apple
DWI 2-wire interface.
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 54 +++
1 file changed, 54 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds
Add MAINTAINERS entries for the driver.
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 17daa9ee9384..3a7dec3f9a5a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2196,6 +2196,7 @@ F:
Documentation/devicetree
Add driver for backlight controllers attached via Apple DWI 2-wire
interface, which is found on some Apple iPhones, iPads and iPod touches
with a LCD display.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig | 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video
://lore.kernel.org/asahi/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add bindings for Apple DWI
backlight
backlight: dwi_bl: Add Apple DWI backlight driver
MAINTAINERS: Add entries for Apple DWI backlight controller
backlight/dwi_bl.c
>> @@ -0,0 +1,124 @@
[...]
>> +
>> +dwi_bl = devm_kzalloc(&dev->dev, sizeof(struct apple_dwi_bl),
>> GFP_KERNEL);
>
> sizeof(*)
Ack this change as well for v4.
>
>> +if (!dwi_bl)
>> +return -ENOMEM;
[...]
Nick Chan
Krzysztof Kozlowski 於 2024/12/9 下午5:22 寫道:
> On Sat, Dec 07, 2024 at 09:03:15PM +0800, Nick Chan wrote:
>> Add driver for backlight controllers attached via Apple DWI 2-wire
>> interface, which is found on some Apple iPhones, iPads and iPod touches
>> with a LCD display
Add the device tree bindings for backlight controllers attached via Apple
DWI 2-wire interface.
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 54 +++
1 file changed, 54 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds
Add driver for backlight controllers attached via Apple DWI 2-wire
interface, which is found on some Apple iPhones, iPads and iPod touches
with a LCD display.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig | 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video
Add MAINTAINERS entries for the driver.
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1e930c7a58b1..36de76bc6fd4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2204,6 +2204,7 @@ F:
Documentation/devicetree
optional property in dt-bindings.
- Added missing error checking after devm_ioremap_resource() in
dwi_bl_probe().
v1: https://lore.kernel.org/asahi/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add bindings for Apple DWI
different
from the Samsung-derived DWI block.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig | 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/dwi_bl.c | 122 +++
3 files changed, 135 insertions(+)
create mode 100644 drivers/video
Add MAINTAINERS entries for the driver.
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 910305c11e8a..54a6c8ca7017 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2196,6 +2196,7 @@ F:
Documentation/devicetree
/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add Apple DWI backlight
backlight: dwi_bl: Add Apple DWI backlight driver
MAINTAINERS: Add entries for Apple DWI backlight controller
.../bindings/leds/backlight/apple,dwi
Add backlight controllers attached via Apple DWI 2-wire interface.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++
1 file changed, 57 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds
Add MAINTAINERS entries for the driver.
Reviewed-by: Daniel Thompson (RISCstar)
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 896a307fa065..a576324807f5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2228,6
Add backlight controllers attached via Apple DWI 2-wire interface.
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Daniel Thompson (RISCstar)
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++
1 file changed, 57 insertions(+)
create mode 100644
different
from the Samsung-derived DWI block.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig| 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/apple_dwi_bl.c | 123 +
3 files changed, 136 insertions(+)
create mode 100644
Changes since v1:
- Fixed dt-bindings $id.
- Make power-domains an optional property in dt-bindings.
- Added missing error checking after devm_ioremap_resource() in
dwi_bl_probe().
v1: https://lore.kernel.org/asahi/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt
Add backlight controllers attached via Apple DWI 2-wire interface.
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++
1 file changed, 57 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml
diff
Add MAINTAINERS entries for the driver.
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 17daa9ee9384..3a7dec3f9a5a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2196,6 +2196,7 @@ F:
Documentation/devicetree
/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add Apple DWI backlight
backlight: dwi_bl: Add Apple DWI backlight driver
MAINTAINERS: Add entries for Apple DWI backlight controller
.../bindings/leds/backlight/apple,dwi
different
from the Samsung-derived DWI block.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig | 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/dwi_bl.c | 122 +++
3 files changed, 135 insertions(+)
create mode 100644 drivers/video
Krzysztof Kozlowski 於 2024/12/10 下午4:32 寫道:
> Nothing improved here.
This is sent before you left any review, v4 will have improvements
Nick Chan
Add MAINTAINERS entries for the driver.
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1e930c7a58b1..36de76bc6fd4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2204,6 +2204,7 @@ F:
Documentation/devicetree
Add the device tree bindings for backlight controllers attached via Apple
DWI 2-wire interface.
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 55 +++
1 file changed, 55 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds
on all controllers at the same time. This series adds a backlight
driver for backlight controllers connected this way.
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add bindings for Apple DWI
backlight
backlight: dwi_bl: Add Apple DWI backlight driver
Add driver for backlight controllers attached via Apple DWI 2-wire
interface, which is found on some Apple iPhones, iPads and iPod touches
with a LCD display.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig | 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video
reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> + };
> +
[...]
With that in mind,
Reviewed-by: Nick Chan
Add MAINTAINERS entries for the driver.
Reviewed-by: Daniel Thompson (RISCstar)
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 910305c11e8a..67ad74f987c8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2196,6
Add backlight controllers attached via Apple DWI 2-wire interface.
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Daniel Thompson (RISCstar)
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++
1 file changed, 57 insertions(+)
create mode 100644
-domains an optional property in dt-bindings.
- Added missing error checking after devm_ioremap_resource() in
dwi_bl_probe().
v1: https://lore.kernel.org/asahi/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add Apple DWI backlight
different
from the Samsung-derived DWI block.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig| 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/apple_dwi_bl.c | 123 +
3 files changed, 136 insertions(+)
create mode 100644
Daniel Thompson 於 2025/1/8 下晝6:52 寫道:
> On Wed, Dec 11, 2024 at 07:34:38PM +0800, Nick Chan wrote:
>> Add driver for backlight controllers attached via Apple DWI 2-wire
>> interface, which is found on some Apple iPhones, iPads and iPod touches
>> with a LCD display.
>&
Add backlight controllers attached via Apple DWI 2-wire interface.
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Daniel Thompson (RISCstar)
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++
1 file changed, 57 insertions(+)
create mode 100644
different
from the Samsung-derived DWI block.
Reviewed-by: Daniel Thompson (RISCstar)
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig| 11 +++
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/apple_dwi_bl.c | 123 +
3 files changed
devm_ioremap_resource() in
dwi_bl_probe().
v1: https://lore.kernel.org/asahi/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add Apple DWI backlight
backlight: apple_dwi_bl: Add Apple DWI backlight driver
MAINTAINERS: Add
Add MAINTAINERS entries for the driver.
Reviewed-by: Daniel Thompson (RISCstar)
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 896a307fa065..a576324807f5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2228,6
#include
> #include
> +#include
> #include
> #include
>
Reviewed-by: Nick Chan
7 @@
> #include
> #include
> #include
> +#include
> #include
> #include
>
Reviewed-by: Nick Chan
45 matches
Mail list logo
