On 15/1/2025 05:38, Sasha Finkelstein via B4 Relay wrote:
> From: Sasha Finkelstein <fnkl.ker...@gmail.com>
> 
> Adds device tree entries for the touchbar screen
> 
> Co-developed-by: Janne Grunau <j...@jannau.net>
> Signed-off-by: Janne Grunau <j...@jannau.net>
> Signed-off-by: Sasha Finkelstein <fnkl.ker...@gmail.com>
> ---
>  arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++++++++++++++++
>  arch/arm64/boot/dts/apple/t8103.dtsi     | 60 +++++++++++++++++++++++++++++++
>  arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++++++++++++++++
>  arch/arm64/boot/dts/apple/t8112.dtsi     | 61 
> ++++++++++++++++++++++++++++++++
>  4 files changed, 183 insertions(+)
> 
[...]
> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi 
> b/arch/arm64/boot/dts/apple/t8103.dtsi
> index 
> 9b0dad6b618444ac6b1c9735c50cccfc3965f947..9b088f74e0cb9f42fbc8df822fca6451dcd1b717
>  100644
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
> @@ -356,6 +356,66 @@ cpufreq_p: performance-controller@211e20000 {
[...]
> +
> +             displaydfr_mipi: dsi@228600000 {
> +                     compatible = "apple,t8103-display-pipe-mipi", 
> "apple,h7-display-pipe-mipi";
> +                     reg = <0x2 0x28600000 0x0 0x100000>;
> +                     power-domains = <&ps_mipi_dsi>;
> +                     #address-cells = <1>;
> +                     #size-cells = <0>;
> +                     status = "disabled";

Missing empty line.
> +                     ports {
> +                             #address-cells = <1>;
> +                             #size-cells = <0>;
> +
> +                             dfr_mipi_in: port@0 {
> +                                     reg = <0>;
> +                                     #address-cells = <1>;
> +                                     #size-cells = <0>;
> +
> +                                     dfr_mipi_in_adp: endpoint@0 {
> +                                             reg = <0>;
> +                                             remote-endpoint = 
> <&dfr_adp_out_mipi>;
> +                                     };
> +                             };
> +
> +                             dfr_mipi_out: port@1 {
> +                                     reg = <1>;
> +                                     #address-cells = <1>;
> +                                     #size-cells = <0>;
> +                             };
> +                     };
> +             };
> +
[...]

With that in mind,

Reviewed-by: Nick Chan <towinche...@gmail.com>

Reply via email to