ested it some time ago; but now, for v3d, don't forget to rebase.
Also, common parts lgtm, so for them:
Acked-by: Melissa Wen
>
> Cheers, Daniel
>
> Daniel Vetter (18):
> drm/sched: Split drm_sched_job_init
> drm/sched: Barriers are needed for entity->last_
On 07/28, Daniel Vetter wrote:
> On Wed, Jul 28, 2021 at 1:29 PM Christian König
> wrote:
> > Am 27.07.21 um 13:09 schrieb Daniel Vetter:
> > > Adding a few more people to this bikeshed.
> > >
> > > On Mon, Jul 12, 2021 at 10:02 PM Daniel Vetter
> > > wrote:
> > >
> > >> @@ -349,6 +367,13 @@ int
On 08/01, Sumera Priyadarsini wrote:
> Add a virtual hardware or vblank-less mode as a module
> to enable VKMS to emulate virtual hardware drivers. This means
> no vertical blanking events occur and pageflips are completed
> arbitrarily and when required for updating the frame.
>
> Add a new drm_c
On 04/05, Sumera Priyadarsini wrote:
> Add two new functions vkms_composer_common() and vkms_crtc_composer().
> The actual plane composition work has been moved to the helper function,
> vkms_composer_common() which is called by both vkms_composer_worker()
> and vkms_crtc_composer(). vkms_crtc_comp
On 04/05, Sumera Priyadarsini wrote:
> Add a virtual hardware or vblank-less mode as a module to
> enable VKMS to emulate virtual graphic drivers.
>
> Add a new drm_crtc_helper_funcs struct,
> vkms_virtual_crtc_helper_funcs() which holds the atomic helpers
> for virtual hardware mode. Change the e
On 04/07, Pekka Paalanen wrote:
> On Mon, 5 Apr 2021 11:41:50 +0530
> Sumera Priyadarsini wrote:
>
> > This patchset adds support for emulating virtual hardware with VKMS.
> > The virtual hardware mode can be enabled by using the following command
> > while loading the module:
> > sudo mo
start to pass (pointed out in the commit
message).
-
v2:
- Drop unnecessary changes that init crtc without cursor (Daniel)
- Replace function to initialize planes (Daniel)
- Add proper pixel blending op according to the plane format (Daniel)
Melissa Wen (4):
drm/vkms: init plane using
By using drmm_universal_plane_alloc instead of
drm_universal_plane_init, we let the DRM infrastructure handles
resource allocation and cleanup. We can also get rid of some
code repetitions for plane cleanup, improving code maintainability
in vkms.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm
Generalize variables and function names used for planes composition
(from cursor to plane), since we will reuse the operations for both
cursor and overlay types.
No functional change.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_composer.c | 28 ++--
1 file
Add support for composing XRGB888 planes in addition to the
ARGB format. In the case of an XRGB plane at the top, the
composition consists of just copying the RGB values of a
pixel from src to dst, without the need for alpha blending
operations for each pixel.
Signed-off-by: Melissa Wen
sfully:
- kms_plane_cursor:
- pipe-A-[overlay, primary, viewport]-size-[64, 128, 256]
- kms_atomic:
- plane-overlay-legacy
and preserves the successful execution of kms_cursor_crc,
kms_writeback and kms_flip
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_composer.
)
- Adjust the patch series format
Melissa Wen (4):
drm/vkms: init plane using drmm_universal_plane_alloc
drm/vkms: rename cursor to plane on ops of planes composition
drm/vkms: add XRGB planes composition
drm/vkms: add overlay support
drivers/gpu/drm/vkms/vkms_composer.c | 67
By using drmm_universal_plane_alloc instead of
drm_universal_plane_init, we let the DRM infrastructure handles
resource allocation and cleanup. We can also get rid of some
code repetitions for plane cleanup, improving code maintainability
in vkms.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm
Generalize variables and function names used for planes composition
(from cursor to plane), since we will reuse the operations for both
cursor and overlay types.
No functional change.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_composer.c | 28 ++--
1 file
Add support for composing XRGB888 planes in addition to the
ARGB format. In the case of an XRGB plane at the top, the
composition consists of just copying the RGB values of a
pixel from src to dst, without the need for alpha blending
operations for each pixel.
Signed-off-by: Melissa Wen
sfully:
- kms_plane_cursor:
- pipe-A-[overlay, primary, viewport]-size-[64, 128, 256]
- kms_atomic:
- plane-overlay-legacy
and preserves the successful execution of kms_cursor_crc,
kms_writeback and kms_flip
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_composer.
On 04/21, Daniel Vetter wrote:
> I always forget where it was, store it until this gets picked up by an
> internship again.
>
> Cc: Wambui Karuga
> Cc: Melissa Wen
> Signed-off-by: Daniel Vetter
> ---
> Documentation/gpu/todo.rst | 2 ++
> 1 file changed, 2 inse
series format
v4:
- use better names for functions of plane composition (Daniel)
- clear alpha channel (0xff) after blend color values by pixel
- improve comments on blend ops to reflect the current state
- describe in the commit message future improvements for plane composition
Melissa Wen (4
By using drmm_universal_plane_alloc instead of
drm_universal_plane_init, we let the DRM infrastructure handles
resource allocation and cleanup. We can also get rid of some
code repetitions for plane cleanup, improving code maintainability
in vkms.
Signed-off-by: Melissa Wen
Reviewed-by: Daniel
Generalize variables and function names used for planes composition
(from cursor to plane), since we will reuse the operations for both
cursor and overlay types.
No functional change.
v4:
- use better names for functions of plane composition (Daniel)
Signed-off-by: Melissa Wen
Reviewed-by
) after blend color values by pixel
- improve comments on blend ops to reflect the current state
- describe in the commit message future improvements for plane composition
Signed-off-by: Melissa Wen
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/vkms/vkms_composer.c | 56
sfully:
- kms_plane_cursor:
- pipe-A-[overlay, primary, viewport]-size-[64, 128, 256]
- kms_atomic:
- plane-overlay-legacy
and preserves the successful execution of kms_cursor_crc,
kms_writeback and kms_flip
Signed-off-by: Melissa Wen
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/vkms/vkms_composer.
/394614/
- overlay plane: this feature was added by
https://patchwork.freedesktop.org/patch/430941/
Cc: Daniel Vetter
Cc: Rodrigo Siqueira
Cc: Sumera Priyadarsini
Signed-off-by: Melissa Wen
---
Documentation/gpu/vkms.rst | 36
1 file changed, 24 insertions
On 04/25, Simon Ser wrote:
> On Saturday, April 24th, 2021 at 3:57 PM, Melissa Wen
> wrote:
>
> > -- Real overlay planes, not just cursor.
>
> Maybe we should mention "multiple overlay planes" as a good task?
Sure. I'll include it.
Thanks for taking
On 04/26, Pekka Paalanen wrote:
> On Sat, 24 Apr 2021 05:26:10 -0300
> Melissa Wen wrote:
>
> > Add support to overlay plane, in addition to primary and cursor
> > planes. In this approach, the plane composition still requires an
> > active primary plane and planes ar
On 04/26, Daniel Vetter wrote:
> On Mon, Apr 26, 2021 at 11:03:15AM +0300, Pekka Paalanen wrote:
> > On Sat, 24 Apr 2021 05:25:31 -0300
> > Melissa Wen wrote:
> >
> > > Add support for composing XRGB888 planes in addition to the ARGB
> > > format. In th
On 04/27, Pekka Paalanen wrote:
> On Mon, 26 Apr 2021 14:31:28 -0300
> Melissa Wen wrote:
>
> > On 04/26, Daniel Vetter wrote:
> > > On Mon, Apr 26, 2021 at 11:03:15AM +0300, Pekka Paalanen wrote:
> > > > On Sat, 24 Apr 2021 05:25:31 -0300
> > > &
/uapi/drm/amdgpu_drm.h#n556
PS: I'm cc'ing more people to get any comments for the generic
extension approach and the multiple semaphores support too.
Melissa Wen (3):
drm/v3d: decouple adding job dependencies from job init
drm/v3d: add generic ioctl extension
drm/v3d: add multipl
Prep work to enable multiple syncobj as job dependency.
Also get rid of old checkpatch warnings in the v3d_gem file.
No functional changes.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_gem.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff
determines the data type to be pointed.
The first application is to enable multiples in/out syncobj (next
patch), but the base is already done for future features.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_drv.c | 4 +-
drivers/gpu/drm/v3d/v3d_gem.c | 84
the case.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_drv.c | 3 +
drivers/gpu/drm/v3d/v3d_drv.h | 14 +++
drivers/gpu/drm/v3d/v3d_gem.c | 210 --
include/uapi/drm/v3d_drm.h| 38 ++
4 files changed, 231 insertions(+), 34 deletions(-)
diff
n the mesa side, the work related to this series is available at
https://gitlab.freedesktop.org/mwen/mesa/-/commit/77bd2b21f61a9caeced934bd13b99e675a428398
where I checked these changes using Mesa CI.
Melissa Wen (3):
drm/v3d: decouple adding job dependencies steps from job init
drm/v3d: add ge
Prep work to enable a job to wait for more than one syncobj before
start. Also get rid of old checkpatch warnings in the v3d_gem file.
No functional changes.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_gem.c | 28 ++--
1 file changed, 18 insertions(+), 10
determines the data type to be pointed.
The first application is to enable multiples in/out syncobj (next
patch), but the base is already done for future features.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_drv.c | 4 +-
drivers/gpu/drm/v3d/v3d_gem.c | 80
the case.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_drv.c | 3 +
drivers/gpu/drm/v3d/v3d_drv.h | 14 +++
drivers/gpu/drm/v3d/v3d_gem.c | 209 +++---
include/uapi/drm/v3d_drm.h| 38 +++
4 files changed, 226 insertions(+), 38 deletions(-)
diff
+4fc21a003c8332eb0...@syzkaller.appspotmail.com
> Cc: Rodrigo Siqueira
> Cc: Melissa Wen
> Cc: Haneen Mohammed
> Cc: Daniel Vetter
> Cc: David Airlie
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-ker...@vger.kernel.org
> Change-Id: I7f01c288092bc7e472ec63af198f93ce3d8c49f7
On 03/25, Dmitry Vyukov wrote:
> On Wed, Mar 24, 2021 at 11:00 PM Melissa Wen wrote:
> >
> > On 03/20, Dmitry Vyukov wrote:
> > > vkms_vblank_simulate() uses WARN_ON for timing-dependent condition
> > > (timer overrun). This is a mis-use of WARN_ON, WARN_ON mu
gt; > Fix this by adding the missing null check.
> >
> > Addresses-Coverity: ("Dereference null return value")
> > Fixes: 2df7af93fdad ("drm/vkms: Add vkms_config type")
> > Signed-off-by: Colin Ian King
>
> Good catch, thank you!
>
> Reviewe
the current results of IGT tests: kms_cursor_crc;
kms_flip and kms_writeback. In addition, subtests related to overlay in
kms_atomic and kms_plane_cursor start to pass (pointed out in the commit
message).
Melissa Wen (3):
drm/vkms: decouple cursor plane setup from crtc_init
drm/vkms: rename
Initialize CRTC only with primary plane (without cursor) as a preparation
to init overlay plane before cursor plane and keep cursor on the top.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_crtc.c | 4 ++--
drivers/gpu/drm/vkms/vkms_drv.h| 2 +-
drivers/gpu/drm/vkms
Generalize variables and function names used for planes composition
(from cursor to plane), since we will reuse the operations for both
cursor and overlay types.
No functional change.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_composer.c | 28 ++--
1 file
sfully:
- kms_plane_cursor:
- pipe-A-[overlay, primary, viewport]-size-[64, 128, 256]
- kms_atomic:
- plane-overlay-legacy
and preserves the successful execution of kms_cursor_crc,
kms_writeback and kms_flip
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_composer.
On 02/22, Daniel Vetter wrote:
> On Sat, Feb 20, 2021 at 11:38:50AM -0300, Melissa Wen wrote:
> > Initialize CRTC only with primary plane (without cursor) as a preparation
> > to init overlay plane before cursor plane and keep cursor on the top.
> >
> > Signed-off-by:
On 02/22, Daniel Vetter wrote:
> On Sat, Feb 20, 2021 at 11:42:12AM -0300, Melissa Wen wrote:
> > Add support to overlay plane, in addition to primary and cursor
> > planes. In this approach, the plane composition still requires an
> > active primary plane and planes are comp
On 02/23, Daniel Vetter wrote:
> On Tue, Feb 23, 2021 at 11:21 AM Melissa Wen wrote:
> >
> > On 02/22, Daniel Vetter wrote:
> > > On Sat, Feb 20, 2021 at 11:42:12AM -0300, Melissa Wen wrote:
> > > > Add support to overlay plane, in addition to primary and cur
Hi Sumera,
Thanks for the doc improvements.
Please see some complimentary comments below.
On 12/03, Daniel Vetter wrote:
> On Thu, Dec 3, 2020 at 8:13 PM Sumera Priyadarsini
> wrote:
> >
> > Update the vkms documentation to contain steps to:
> >
> > - setup the vkms driver
> > - run tests usin
On 12/09, Daniel Vetter wrote:
> On Wed, Dec 9, 2020 at 12:33 PM Sumera Priyadarsini
> wrote:
> >
> > On Wed, Dec 9, 2020 at 6:24 AM Daniel Vetter wrote:
> > >
> > > On Wed, Dec 09, 2020 at 02:07:35AM +0530, Sumera Priyadarsini wrote:
> > > > Update the vkms documentation to contain steps to:
> >
On 12/09, Daniel Vetter wrote:
> On Thu, Dec 10, 2020 at 12:34:53AM +0530, Sumera Priyadarsini wrote:
> > Update the vkms documentation to contain steps to:
> >
> > - setup the vkms driver
> > - run tests using igt
> >
> > Signed-off-by: Sumera Priyadarsini
> > ___
> > Changes in v2:
> > - Ch
On 07/05, Daniel Vetter wrote:
> On Mon, Jul 05, 2021 at 12:05:28PM +0200, Thomas Zimmermann wrote:
> > Hi
> >
> > Am 05.07.21 um 11:27 schrieb Daniel Vetter:
> > > On Mon, Jul 05, 2021 at 09:46:29AM +0200, Thomas Zimmermann wrote:
> > > > Vkms copies each plane's framebuffer into the output buffe
for your patch.
Changes lgtm.
However commit message needs small improvements. Besides typo, it would
be good to make the subject clearer in terms of its purpose (creating
a debugfs file to get/track vkms config data).
Please, address these minor things and add my r-b.
Reviewed-by: Melissa Wen
>
On 07/08, Beatriz Martins de Carvalho wrote:
> Creating a vkms_config_debufs file in vkms_drv.c to get/track vkms config
> data, for the long-term plan of making vkms configurable and have multiple
> different instances.
>
> Reviewed-by: Melissa Wen
> Signed-off-by: Beatriz M
On 07/06, Thomas Zimmermann wrote:
> Hi
>
> Am 05.07.21 um 23:29 schrieb Melissa Wen:
> > On 07/05, Daniel Vetter wrote:
> > > On Mon, Jul 05, 2021 at 12:05:28PM +0200, Thomas Zimmermann wrote:
> > > > Hi
> > > >
> > > > Am 05.07.21 um
to include the
> drm_sched_job_arm() call (Emma).
>
> v3: Cleanup jobs under construction correctly (Emma)
>
> Cc: Melissa Wen
> Signed-off-by: Daniel Vetter
> Cc: Emma Anholt
> ---
> drivers/gpu/drm/v3d/v3d_drv.h | 1 +
> drivers/gpu/drm/v3d/v3d_gem.c | 88 +++
> job->dependencies xarray this should be fixable.
>
> Cc: Melissa Wen
> Signed-off-by: Daniel Vetter
> Cc: Cc: Emma Anholt
> ---
> drivers/gpu/drm/v3d/v3d_drv.h | 5 -
> drivers/gpu/drm/v3d/v3d_gem.c | 25 --
As v3d_lookup_bos() performs the same steps as drm_gem_objects_lookup(),
replace the explicit code in v3d to simply use the DRM function.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_gem.c | 49 +++
1 file changed, 3 insertions(+), 46 deletions(-)
diff
cks that the object passed is not NULL, doing the job->bo[i]
checker redundant.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_gem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index 92bc0faee84
n code in drm_gem_objects_lookup().
Melissa Wen (2):
drm/v3d: cleanup BOs properly when lookup_bos fails
drm/v3d: replace obj lookup steps with drm_gem_objects_lookup
drivers/gpu/drm/v3d/v3d_gem.c | 55 ---
1 file changed, 6 insertions(+), 49 deletions(-)
--
2.35.1
out what I misunderstood about these
concepts?
Thanks,
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 4
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display
in dcn10 - that calls dcn_validate_bandwidth and wraps with DC_FP_*
accordingly. The second patch removes invocations of DC_FP_* from dml
files and properly wraps FPU functions in dc code outside dml folder.
Melissa Wen (2):
drm/amd/display: detach fpu operations from dcn10_validate_bandwidth
function with DC_FP_* macro.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 14 ++
.../gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.c | 5 +
drivers/gpu/drm/amd/display/dc/inc/dcn_calcs.h | 2 +-
3 files changed, 16 insertions(+), 5 deletions
required.
Signed-off-by: Melissa Wen
---
.../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 10 --
.../gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 2 ++
.../gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.c | 14 --
.../gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 2 --
4
On 03/12, Harshit Mogalapalli wrote:
> kvcalloc is same as kvmalloc_array + __GFP_ZERO.
>
> Signed-off-by: Harshit Mogalapalli
> ---
> drivers/gpu/drm/v3d/v3d_gem.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/
On 03/28, Kazlauskas, Nicholas wrote:
> [AMD Official Use Only]
>
> > -Original Message-
> > From: Melissa Wen
> > Sent: Friday, March 25, 2022 4:45 PM
> > To: amd-...@lists.freedesktop.org; Wentland, Harry
> > ; Deucher, Alexander
> > ; Si
On 03/28, Simon Ser wrote:
> Thanks a lot for you patch! I've noticed as well that amdgpu ignores
> the plane alpha property [1]. I'll try to find time to test it.
Hi Simon,
So you've faced this kind of issue many times :/
Let me know the results from your side, so we can use it to find the
correc
On 03/28, Christian König wrote:
> Am 26.03.22 um 21:24 schrieb Melissa Wen:
> > dcn10_validate_bandwidth is only used on dcn10 files, but is declared in
> > dcn_calcs files. Rename dcn10_* to dcn_* in calcs, remove DC_FP_* wrapper
> > inside DML folder a
On 03/28, Melissa Wen wrote:
> On 03/28, Kazlauskas, Nicholas wrote:
> > [AMD Official Use Only]
> >
> > > -Original Message-----
> > > From: Melissa Wen
> > > Sent: Friday, March 25, 2022 4:45 PM
> > > To: amd-...@lists.freedesk
alue (Nicholas)
* correct the logical ordering for combined global gain (Nicholas)
* apply to dcn10 too (Nicholas)
Signed-off-by: Melissa Wen
---
.../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 14 +-
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 14 +-
2 files
On 03/30, Rodrigo Siqueira Jordao wrote:
>
>
> On 2022-03-26 16:24, Melissa Wen wrote:
> > From FPU documentation, developers must not use DC_FP_START/END in dml
> > files, but invoke it when calling FPU-associated functions (isolated in
> > dml folder). Therefo
e);
- void dcn20_fpu_adjust_dppclk(): adjust operation on RequiredDPPCLK
that is a double.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/dcn20/Makefile | 25 -
.../drm/amd/display/dc/dcn20/dcn20_resource.c | 1370 +---
.../drm/amd/display/dc/dcn20/dcn20_resource.h | 30 +-
.
On 02/23, Rodrigo Siqueira Jordao wrote:
>
>
> On 2022-02-21 06:31, Melissa Wen wrote:
> > Move parts of dcn20 code that uses FPU to dml folder. It aims to isolate
> > FPU operations as described by series:
> >
> > drm/amd/display: Introduce
ned-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/dcn20/Makefile | 25 -
.../drm/amd/display/dc/dcn20/dcn20_resource.c | 1370 +---
.../drm/amd/display/dc/dcn20/dcn20_resource.h | 30 +-
.../drm/amd/display/dc/dcn21/dcn21_resource.c |2 +
.../drm/amd/displa
Remove redundant error message (since now it is very similar to what
we do in drm_sched_init) and centralize all error handling in a
unique place, as we follow the same steps in any case of failure.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_sched.c | 40
) functions that require FPU access`
Also, there isn't a dcn10_fpu in dml/dcn10 folder, therefore, I create
related files to isolate FPU structs there.
This patchset depends on previous patch to isolate FPU code from dcn20
driver: https://patchwork.freedesktop.org/series/100487/
Melissa W
dcn20_fpu.
Reuse dcn20_fpu_adjust_dppclk() in dcn21_fast_validate_bw() as it isolates
the same FPU operation.
Include dchubbub.h as it is required in dcn21_populate_dml_pipes_from_context()
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/dcn21/Makefile | 25 -
.../drm/amd/display
: Melissa Wen
---
.../drm/amd/display/dc/dcn10/dcn10_resource.c | 62 -
.../drm/amd/display/dc/dcn10/dcn10_resource.h | 4 +
drivers/gpu/drm/amd/display/dc/dml/Makefile | 2 +
.../drm/amd/display/dc/dml/dcn10/dcn10_fpu.c | 124 ++
.../drm/amd/display/dc/dml/dcn10
On 02/25, Maxime Ripard wrote:
> Hi Melissa,
>
> On Tue, Feb 01, 2022 at 08:26:51PM -0100, Melissa Wen wrote:
> > Trace submit_cl_ioctl and related IRQs for CL submission and bin/render
> > jobs execution. It might be helpful to get a rendering timeline and
>
On Mon, Feb 28, 2022 at 8:21 PM Andrey Grodzovsky
wrote:
>
> Acked-by: Andrey Grodzovsky
>
> Andrey
Thanks. Applied to drm-misc-next.
Melissa
>
> On 2022-02-28 13:16, Melissa Wen wrote:
> > Remove redundant error message (since now it is very similar to what
> >
- dcn31x_update_bw_bounding_box() functions
- dcn31_calculate_wm_and_dlg_fp()
Also, it adds dc_assert_fp_enabled() in public dml-fpu functions, as required,
and I've checked if their calls are properly wrapped by DC_FP_START/END (and
removed when inside dml/fpu files too).
Melissa Wen (3):
drm/amd/dicplay: mov
Moves related structs and dcn315_update_bw_bounding_box from dcn315
driver code to dml/dcn31_fpu that centralizes FPU code for DCN 3.1x.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/dc/dcn315/Makefile| 26 --
.../amd/display/dc/dcn315/dcn315_resource.c | 232
()
- dcn31_update_bw_bounding_box()
adding dc_assert_fp_enabled to them and drop DC_FP_START/END inside
functions that was moved to dml folder, as required.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 26 --
.../drm/amd/display/dc/dcn31/dcn31_resource.c | 355 +--
.../drm
Moves FPU-related structs and dcn316_update_bw_bounding_box from dcn316
driver to dml/dcn31 that centralize FPU operations for DCN 3.1x
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/dc/dcn316/Makefile| 26 --
.../amd/display/dc/dcn316/dcn316_resource.c | 231
iner flush\n");
hm.. would it be clearer to say "TMU write combiner" here?
in the next version, you can already include:
Reviewed-by: Melissa Wen
Thanks,
Melissa
> }
>
> --
> 2.25.1
>
signature.asc
Description: PGP signature
On 09/15, Iago Toral wrote:
> On Wed, 2021-08-18 at 18:56 +0100, Melissa Wen wrote:
> > Add support to attach generic extensions on job submission.
> > This patch is a second prep work to enable multiple syncobjs on job
> > submission. With this work, when the job submission i
On 09/15, Iago Toral Quiroga wrote:
> The hardware sets the TMUWCF bit back to 0 when the TMU write
> combiner flush completes so we should be checking for that instead
> of the L2TFLS bit.
>
> v2 (Melissa Wen):
> - Add Signed-off-by and Fixes tags.
> - Change the
On 09/01, Sumera Priyadarsini wrote:
> Add a virtual hardware or vblank-less mode as a module
> to enable VKMS to emulate virtual hardware drivers. This means
> no vertical blanking events occur and pageflips are completed
> arbitrarily and when required for updating the frame.
>
> Add a new drm_c
On 09/16, Iago Toral wrote:
> I think this looks good overall, I have a few questions/commments
> below:
>
> On Wed, 2021-08-18 at 18:57 +0100, Melissa Wen wrote:
> > Using the generic extension support set in the previous patch, this
> > patch enables more than one in/ou
On 09/16, Daniel Vetter wrote:
> On Wed, Aug 18, 2021 at 06:56:41PM +0100, Melissa Wen wrote:
> > Add support to attach generic extensions on job submission.
> > This patch is a second prep work to enable multiple syncobjs on job
> > submission. With this work, when the job
it to v3d_job_init")
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_gem.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index 1953706bdaeb..ead0be8d48a7 100644
--- a/drivers/gpu/drm/v3d/v3d_gem.c
+++
> I think that should make error handling in these functions a lot
> easier.
Hi,
yes, sounds good. I can include this refactoring in the v2 of the
multisync patchset, since there is a prep work there (first patch).
Thanks for reviewing both,
Melissa
>
> Iago
>
>
> O
f(multisync));
> - if (ret)
> - return ret;
> + if (copy_from_user(&multisync, ext, sizeof(multisync)))
> + return -EFAULT;
>
> if (multisync.pad)
> return -EINVAL;
Hi Dan,
Thanks for catching this.
Reviewed-by: Melissa Wen
> --
> 2.20.1
>
signature.asc
Description: PGP signature
v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
> if (ret)
> goto fail;
Thanks,
Reviewed-by: Melissa Wen
and I'll apply do drm-misc-next.
>
> --
> 1.8.3.1
>
signature.asc
Description: PGP signature
;drm.dev, res);
> + *regs = devm_platform_ioremap_resource_byname(v3d_to_pdev(v3d), name);
> return PTR_ERR_OR_ZERO(*regs);
> }
lgtm.
Reviewed-by: Melissa Wen
>
> --
> 2.25.1
>
signature.asc
Description: PGP signature
On 09/20, Melissa Wen wrote:
> On 09/01, Cai Huoqing wrote:
> > Use the devm_platform_ioremap_resource_byname() helper instead of
> > calling platform_get_resource_byname() and devm_ioremap_resource()
> > separately
> >
> > Signed-off-by: Cai Huoqing
> >
extension struct (Daniel)
- make job dependency conditions more understandable (Iago)
Melissa Wen (4):
drm/v3d: decouple adding job dependencies steps from job init
drm/v3d: alloc and init job in one shot
drm/v3d: add generic ioctl extension
drm/v3d: add multiple syncobjs support
drivers/gpu
Prep work to enable a job to wait for more than one syncobj before
start. Also get rid of old checkpatch warnings in the v3d_gem file.
No functional changes.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_gem.c | 28 ++--
1 file changed, 18 insertions(+), 10
structs
have the first element a struct v3d_job (bin, render, tfu, csd) or it is a
v3d_job itself (clean_job) for pointer casting.
Suggested-by: Iago Toral
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_gem.c | 115 +-
1 file changed, 42 insertions(+), 73
submission.
v2:
- remove redundant elements to subclass struct (Daniel)
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_drv.c | 4 +-
drivers/gpu/drm/v3d/v3d_gem.c | 71 +--
include/uapi/drm/v3d_drm.h| 31 +++
3 files changed, 100 insertions
:
- subclass the generic extension struct (Daniel)
- simplify adding dependency conditions to make understandable (Iago)
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_drv.c | 6 +-
drivers/gpu/drm/v3d/v3d_drv.h | 23 +++--
drivers/gpu/drm/v3d/v3d_gem.c | 176
On 09/30, Iago Toral wrote:
> On Wed, 2021-09-29 at 10:43 +0100, Melissa Wen wrote:
> > Move job memory allocation to v3d_job_init function. This aim to
> > facilitate
> > error handling in job initialization, since cleanup steps are similar
> > for all
> > (s
O 09/30, Iago Toral wrote:
> On Wed, 2021-09-29 at 10:44 +0100, Melissa Wen wrote:
> > Add support to attach generic extensions on job submission. This
> > patch
> > is third prep work to enable multiple syncobjs on job submission.
> > With
> > this work, when the
1 - 100 of 886 matches
Mail list logo
