[RFC PATCH 1/3] drm/v3d: decouple adding job dependencies from job init

[Melissa Wen]

Prep work to enable multiple syncobj as job dependency.
Also get rid of old checkpatch warnings in the v3d_gem file.
No functional changes.

Signed-off-by: Melissa Wen <m...@igalia.com>
---
 drivers/gpu/drm/v3d/v3d_gem.c | 28 ++++++++++++++++++----------
 1 file changed, 18 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index 5689da118197..944bc4728055 100644
--- a/drivers/gpu/drm/v3d/v3d_gem.c
+++ b/drivers/gpu/drm/v3d/v3d_gem.c
@@ -417,7 +417,7 @@ v3d_wait_bo_ioctl(struct drm_device *dev, void *data,
                return -EINVAL;
 
        ret = drm_gem_dma_resv_wait(file_priv, args->handle,
-                                             true, timeout_jiffies);
+                                   true, timeout_jiffies);
 
        /* Decrement the user's timeout, in case we got interrupted
         * such that the ioctl will be restarted.
@@ -435,12 +435,25 @@ v3d_wait_bo_ioctl(struct drm_device *dev, void *data,
        return ret;
 }
 
+static int
+v3d_job_add_deps(struct drm_file *file_priv, struct v3d_job *job,
+                u32 in_sync, u32 point)
+{
+       struct dma_fence *in_fence = NULL;
+       int ret;
+
+       ret = drm_syncobj_find_fence(file_priv, in_sync, point, 0, &in_fence);
+       if (ret == -EINVAL)
+               return ret;
+
+       return drm_gem_fence_array_add(&job->deps, in_fence);
+}
+
 static int
 v3d_job_init(struct v3d_dev *v3d, struct drm_file *file_priv,
             struct v3d_job *job, void (*free)(struct kref *ref),
             u32 in_sync)
 {
-       struct dma_fence *in_fence = NULL;
        int ret;
 
        job->v3d = v3d;
@@ -452,11 +465,7 @@ v3d_job_init(struct v3d_dev *v3d, struct drm_file 
*file_priv,
 
        xa_init_flags(&job->deps, XA_FLAGS_ALLOC);
 
-       ret = drm_syncobj_find_fence(file_priv, in_sync, 0, 0, &in_fence);
-       if (ret == -EINVAL)
-               goto fail;
-
-       ret = drm_gem_fence_array_add(&job->deps, in_fence);
+       ret = v3d_job_add_deps(file_priv, job, in_sync, 0);
        if (ret)
                goto fail;
 
@@ -503,7 +512,7 @@ v3d_attach_fences_and_unlock_reservation(struct drm_file 
*file_priv,
        for (i = 0; i < job->bo_count; i++) {
                /* XXX: Use shared fences for read-only objects. */
                dma_resv_add_excl_fence(job->bo[i]->resv,
-                                                 job->done_fence);
+                                       job->done_fence);
        }
 
        drm_gem_unlock_reservations(job->bo, job->bo_count, acquire_ctx);
@@ -924,8 +933,7 @@ v3d_gem_init(struct drm_device *dev)
        if (!v3d->pt) {
                drm_mm_takedown(&v3d->mm);
                dev_err(v3d->drm.dev,
-                       "Failed to allocate page tables. "
-                       "Please ensure you have CMA enabled.\n");
+                       "Failed to allocate page tables. Please ensure you have 
CMA enabled.\n");
                return -ENOMEM;
        }
 
-- 
2.30.2

signature.asc
Description: PGP signature