[PATCH v7 03/12] clk: Enforce that disjoints limits are invalid

2022-02-25 Thread Maxime Ripard
ll drivers, and most importantly we'll break that assumption in a later patch. It can also be argued that we shouldn't even reach the point where we're calling clk_core_set_rate_nolock(). Let's make an explicit check for disjoints range before we're doing anything. Signed

[PATCH v7 04/12] clk: Always clamp the rounded rate

2022-02-25 Thread Maxime Ripard
ork will always clamp the rate to the current range found on the clock, which will fix both these inconsistencies. Signed-off-by: Maxime Ripard --- drivers/clk/clk.c | 2 ++ drivers/clk/clk_test.c | 50 +++--- 2 files changed, 34 insertions(+), 18 deletions(-

[PATCH v7 06/12] clk: Always set the rate on clk_set_range_rate

2022-02-25 Thread Maxime Ripard
-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/clk.c | 45 drivers/clk/clk_test.c | 58 +++--- 2 files changed, 49 insertions(+), 54 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index c

[PATCH v7 08/12] clk: bcm: rpi: Add variant structure

2022-02-25 Thread Maxime Ripard
x27;s switch to a variant structure that defines the behaviour we need to have for a given clock. Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 62 +++ 1 file changed, 46 insertions(+), 16 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberry

[PATCH v7 07/12] clk: Add clk_drop_range

2022-02-25 Thread Maxime Ripard
In order to reset the range on a clock, we need to call clk_set_rate_range with a minimum of 0 and a maximum of ULONG_MAX. Since it's fairly inconvenient, let's introduce a clk_drop_range() function that will do just this. Suggested-by: Stephen Boyd Signed-off-by: Maxime Ripard --- d

[PATCH v7 09/12] clk: bcm: rpi: Set a default minimum rate

2022-02-25 Thread Maxime Ripard
controller to deal with this before, but it makes more sense to have it in the clock driver. Move it there. Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b

[PATCH v7 01/12] clk: Fix clk_hw_get_clk() when dev is NULL

2022-02-25 Thread Maxime Ripard
pi to get clk consumer from clk_hw") Signed-off-by: Maxime Ripard --- drivers/clk/clk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 8de6a22498e7..fff5edb89d6d 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -3773

[PATCH v7 10/12] clk: bcm: rpi: Run some clocks at the minimum rate allowed

2022-02-25 Thread Maxime Ripard
t the clk_request minimum (which is the aggregated minimum of all the clock users) is what we want at all times. Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 37 +++ 1 file changed, 37 insertions(+) diff --git a/drivers/clk/bcm/clk-raspberrypi

[PATCH v7 11/12] drm/vc4: Add logging and comments

2022-02-25 Thread Maxime Ripard
The HVS core clock isn't really obvious, so let's add a bunch more comments and some logging for easier debugging. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_kms.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/g

[PATCH v7 12/12] drm/vc4: hdmi: Remove clock rate initialization

2022-02-25 Thread Maxime Ripard
Now that the clock driver makes sure we never end up with a rate of 0, the HDMI driver doesn't need to care anymore. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gp

Re: [PATCH] drm/vc4: add tracepoints for CL submissions

2022-02-25 Thread Maxime Ripard
Hi Melissa, On Tue, Feb 01, 2022 at 08:26:51PM -0100, Melissa Wen wrote: > Trace submit_cl_ioctl and related IRQs for CL submission and bin/render > jobs execution. It might be helpful to get a rendering timeline and > track job throttling. > > Signed-off-by: Melissa Wen I'm not really sure wha

Re: (subset) [Nouveau] [PATCH v2 13/22] drm/nouveau/kms: Remove redundant zpos initialisation

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:09 +0100, Maxime Ripard wrote: > The nouveau KMS driver will call drm_plane_create_zpos_property() with > an init value depending on the plane purpose. > > Since the initial value wasn't carried over in the state, the driver had > to set it agai

Re: (subset) [PATCH v2 04/22] drm/omap: plane: Fix zpos initial value mismatch

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:00 +0100, Maxime Ripard wrote: > While the omap_plane_init() function calls > drm_plane_create_zpos_property() with an initial value of 0, > omap_plane_reset() will force it to another value depending on the plane > type. > > Fix the discrepancy by s

Re: (subset) [PATCH v2 07/22] drm/object: Add default zpos value at reset

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:03 +0100, Maxime Ripard wrote: > From: Dave Stevenson > > The drm_plane_create_zpos_property() function asks for an initial value, > and will set the associated plane state variable with that value if a > state is present. > > However, that funct

Re: (subset) [PATCH v2 15/22] drm/rcar: plane: Remove redundant zpos initialisation

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:11 +0100, Maxime Ripard wrote: > The rcar-du KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane type. > > Since the initial value wasn't carried over in the state, the driver had > to set it again in

Re: (subset) [PATCH v2 14/22] drm/omap: plane: Remove redundant zpos initialisation

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:10 +0100, Maxime Ripard wrote: > The omap KMS driver will call drm_plane_create_zpos_property() with an > init value of the plane index and the plane type. > > Since the initial value wasn't carried over in the state, the driver had > to set it again

Re: (subset) [PATCH v2 12/22] drm/msm/mdp5: Remove redundant zpos initialisation

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:08 +0100, Maxime Ripard wrote: > The mdp KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane purpose. > > Since the initial value wasn't carried over in the state, the driver had > to set it again

Re: (subset) [PATCH v2 16/22] drm/sti: plane: Remove redundant zpos initialisation

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:12 +0100, Maxime Ripard wrote: > The sti KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane type. > > Since the initial value wasn't carried over in the state, the driver had > to set it again in sti_plan

Re: (subset) [PATCH v2 17/22] drm/sun4i: layer: Remove redundant zpos initialisation

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:13 +0100, Maxime Ripard wrote: > The sun4i KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane type. > > Since the initial value wasn't carried over in the state, the driver had > to set it again in sun4i

Re: (subset) [PATCH v2 06/22] drm/object: Add drm_object_property_get_default_value() function

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:02 +0100, Maxime Ripard wrote: > From: Dave Stevenson > > Some functions to create properties (drm_plane_create_zpos_property or > drm_plane_create_color_properties for example) will ask for a range of > acceptable value and an initial one. > >

Re: (subset) [PATCH v2 18/22] drm/object: Add default color encoding and range value at reset

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:14 +0100, Maxime Ripard wrote: > From: Dave Stevenson > > The drm_plane_create_color_properties() function asks for an initial > value for the color encoding and range, and will set the associated > plane state variable with that value if a s

Re: (subset) [PATCH v2 22/22] drm/omap: plane: Remove redundant color encoding and range initialisation

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:18 +0100, Maxime Ripard wrote: > The omap KMS driver will call drm_plane_create_color_properties() with > a default encoding and range values of BT601 and Full Range, > respectively. > > Since the initial value wasn't carried over in the state, the dr

Re: (subset) [PATCH v6 1/5] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-28 Thread Maxime Ripard
On Sun, 27 Feb 2022 13:47:09 +0100, Noralf Trønnes wrote: > Add binding for MIPI DBI compatible SPI panels. > > v6: > - Fix indentation (Rob) > > v5: > - Add sainsmart18 to compatible items (Rob) > - Expand write-only description (Sam) > > [...] Applied to drm/drm-misc (drm-misc-next). Thanks!

Re: (subset) [PATCH v6 3/5] drm/modes: Add of_get_drm_panel_display_mode()

2022-02-28 Thread Maxime Ripard
On Sun, 27 Feb 2022 13:47:11 +0100, Noralf Trønnes wrote: > Add a function to get a drm_display_mode from a panel-timing > device tree subnode. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v6 2/5] drm/modes: Remove trailing whitespace

2022-02-28 Thread Maxime Ripard
On Sun, 27 Feb 2022 13:47:10 +0100, Noralf Trønnes wrote: > Remove trailing whitespace from a comment. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v6 4/5] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev

2022-02-28 Thread Maxime Ripard
On Sun, 27 Feb 2022 13:47:12 +0100, Noralf Trønnes wrote: > devm_drm_dev_alloc() can't allocate structures that embed a structure > which then again embeds drm_device. Workaround this by adding a > driver_private pointer to struct mipi_dbi_dev which the driver can use for > its additional state. >

Re: (subset) [PATCH v6 5/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-28 Thread Maxime Ripard
On Sun, 27 Feb 2022 13:47:13 +0100, Noralf Trønnes wrote: > Add a driver that will work with most MIPI DBI compatible SPI panels. > This avoids adding a driver for every new MIPI DBI compatible controller > that is to be used by Linux. The 'compatible' Device Tree property with > a '.bin' suffix wi

Re: [PATCH v6 0/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-28 Thread Maxime Ripard
Hi, On Sun, Feb 27, 2022 at 01:47:08PM +0100, Noralf Trønnes wrote: > Hi, > > This patchset adds a driver that will work with most MIPI DBI compatible > SPI panels out there. > > One change this time: Fix indentation in the DT binding. > > All patches are reviewed now so I will apply this after

Re: [PATCH v6 02/12] clk: Introduce Kunit Tests for the framework

2022-02-28 Thread Maxime Ripard
On Fri, Feb 25, 2022 at 01:29:03PM -0800, Daniel Latypov wrote: > On Fri, Feb 25, 2022 at 5:23 AM Maxime Ripard wrote: > > > > Hi Daniel, > > > > On Wed, Feb 23, 2022 at 02:50:59PM -0800, Daniel Latypov wrote: > > > On Wed, Feb 23, 2022 at 2:56 AM Maxime Ripar

Re: [PATCH v6 02/12] clk: Introduce Kunit Tests for the framework

2022-02-28 Thread Maxime Ripard
On Fri, Feb 25, 2022 at 02:44:04PM -0800, Stephen Boyd wrote: > Quoting Maxime Ripard (2022-02-25 06:26:06) > > Hi Stephen, > > > > On Thu, Feb 24, 2022 at 02:54:20PM -0800, Stephen Boyd wrote: > > > Quoting Daniel Latypov (2022-02-23 14:50:59) > > > &

Re: [PATCH V2 01/12] drm: bridge: icn6211: Fix register layout

2022-03-02 Thread Maxime Ripard
i/ICN6211-Configurator > > Fixes: ce517f18944e3 ("drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB > bridge") > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > To: dri-devel@lists

Re: [PATCH V2 02/12] drm: bridge: icn6211: Fix HFP_HSW_HBP_HI and HFP_MIN handling

2022-03-02 Thread Maxime Ripard
8944e3 ("drm: bridge: Add Chipone ICN6211 MIPI-DSI to RGB > bridge") > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > To: dri-devel@lists.freedesktop.org Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH V2 03/12] drm: bridge: icn6211: Add HS/VS/DE polarity handling

2022-03-02 Thread Maxime Ripard
by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > To: dri-devel@lists.freedesktop.org > --- > V2: Rebase on next-20220214 > --- > drivers/gpu/drm/bridge/chipone-icn6211.c | 16 +++- &g

Re: [PATCH V2 04/12] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-02 Thread Maxime Ripard
igned-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > To: dri-devel@lists.freedesktop.org > --- > V2: Rebase on next-20220214 > --- > drivers/gpu/drm/bridge/chipone-icn6211.c | 21 +

Re: [PATCH V2 05/12] drm: bridge: icn6211: Add generic DSI-to-DPI PLL configuration

2022-03-02 Thread Maxime Ripard
han one hard-coded pixel clock > value anyway. > > [1] > https://github.com/rockchip-linux/kernel/blob/develop-4.19/drivers/gpu/drm/bridge/icn6211.c > [2] https://github.com/tdjastrzebski/ICN6211-Configurator > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: M

Re: [PATCH V2 06/12] drm: bridge: icn6211: Use DSI burst mode without EoT and with LP command mode

2022-03-02 Thread Maxime Ripard
itting it. > Enable transmission of data in LP mode, otherwise register read via DSI > does not work with this chip. > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > To: dri-devel@lists.f

Re: [PATCH V2 07/12] drm: bridge: icn6211: Disable DPI color swap

2022-03-02 Thread Maxime Ripard
by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > To: dri-devel@lists.freedesktop.org Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH V2 08/12] drm: bridge: icn6211: Set SYS_CTRL_1 to value used in examples

2022-03-02 Thread Maxime Ripard
mple code. > > [1] > https://github.com/rockchip-linux/kernel/blob/develop-4.19/drivers/gpu/drm/bridge/icn6211.c > [2] https://github.com/tdjastrzebski/ICN6211-Configurator > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: Robert Foss > Cc: Sam

Re: [PATCH V2 09/12] drm: bridge: icn6211: Implement atomic_get_input_bus_fmts

2022-03-02 Thread Maxime Ripard
loser to the scanout engine. > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > To: dri-devel@lists.freedesktop.org Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH V2 10/12] drm: bridge: icn6211: Add I2C configuration support

2022-03-02 Thread Maxime Ripard
able only on chips which have additional MCU on > the panel/bridge board which preconfigures the ICN6211, while the > I2C configuration mode added by this patch does not require any > such MCU. > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: R

Re: [PATCH V2 11/12] drm: bridge: icn6211: Rework ICN6211_DSI to chipone_writeb()

2022-03-02 Thread Maxime Ripard
On Thu, Feb 17, 2022 at 01:25:29AM +0100, Marek Vasut wrote: > Rename and inline macro ICN6211_DSI() into function chipone_writeb() > to keep all function names lower-case. No functional change. > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: R

Re: [PATCH V2 12/12] drm: bridge: icn6211: Read and validate chip IDs before configuration

2022-03-02 Thread Maxime Ripard
, since that tends to be broken on various bridges. > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Maxime Ripard > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: Thomas Zimmermann > To: dri-devel@lists.freedesktop.org Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format

2022-03-02 Thread Maxime Ripard
Hi, Please try to avoid top posting On Wed, Feb 23, 2022 at 04:25:19PM +0100, Max Krummenacher wrote: > The goal here is to set the element bus_format in the struct > panel_desc. This is an enum with the possible values defined in > include/uapi/linux/media-bus-format.h. > > The enum values are

Mandatory Test Suite for KMS Drivers?

2022-03-03 Thread Maxime Ripard
Hi, Back at XDC we floated the idea of creating a test suite for IGT that we expect any KMS driver to pass, similar to what v4l2-compliance and cec-compliance provide for v4l2 and CEC respectively. I was looking at the list of tests, and it's fairly massive, so it's not clear to me what tests we

Re: [PATCH V2 04/12] drm: bridge: icn6211: Add DSI lane count DT property parsing

2022-03-03 Thread Maxime Ripard
On Wed, Mar 02, 2022 at 04:17:04PM +0100, Marek Vasut wrote: > On 3/2/22 11:01, Maxime Ripard wrote: > > On Thu, Feb 17, 2022 at 01:25:22AM +0100, Marek Vasut wrote: > > > The driver currently hard-codes DSI lane count to two, however the chip > > > is capable of opera

Re: [PATCH v4] drm: of: Lookup if child node has panel or bridge

2022-03-04 Thread Maxime Ripard
Hi Paul, On Thu, Mar 03, 2022 at 09:26:30PM +0100, Paul Kocialkowski wrote: > On Wed 02 Feb 22, 21:34, Jagan Teki wrote: > > Devices can also be child nodes when we also control that device > > through the upstream device (ie, MIPI-DCS for a MIPI-DSI device). > > > > drm_of_find_panel_or_bridge c

Re: [PATCH v4] drm: of: Lookup if child node has panel or bridge

2022-03-04 Thread Maxime Ripard
On Fri, Mar 04, 2022 at 12:05:14PM +0100, Paul Kocialkowski wrote: > On Fri 04 Mar 22, 12:00, Paul Kocialkowski wrote: > > Hi Maxime, > > > > On Fri 04 Mar 22, 09:54, Maxime Ripard wrote: > > > Hi Paul, > > > > > > On Thu, Mar 03, 2022 at 09:26:30P

Writeback Assumptions for XRGB

2022-03-04 Thread Maxime Ripard
Hi, The writeback-check-output is currently broken on vc4. It's in part due to a bug in the kernel driver that results in a page flip timeout, but once that's fixed the test is still broken, and I'm not sure how to solve this one. Indeed, the frame comparison is done between the (XRGB) buffe

Re: (subset) [PATCH] drm/sun4i: mixer: Fix P010 and P210 format numbers

2022-03-08 Thread Maxime Ripard
On Mon, 28 Feb 2022 19:14:36 +0100, Jernej Skrabec wrote: > It turns out that DE3 manual has inverted YUV and YVU format numbers for > P010 and P210. Invert them. > > This was tested by playing video decoded to P010 and additionally > confirmed by looking at BSP driver source. > > > [...] Appli

Re: (subset) [PATCH v2 01/22] drm/komeda: plane: switch to plane reset helper

2022-03-08 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:58:57 +0100, Maxime Ripard wrote: > komeda_plane_reset() does the state initialisation by copying a lot of > the code found in the __drm_atomic_helper_plane_reset(). Let's switch to > that helper and reduce the boilerplate. > > Applied to drm/drm

Re: (subset) [PATCH v2 09/22] drm/komeda: plane: Remove redundant zpos initialisation

2022-03-08 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:05 +0100, Maxime Ripard wrote: > The komeda KMS driver will call drm_plane_create_zpos_property() with an > init value of the plane index. > > Since the initial value wasn't carried over in the state, the driver had > to set it again in komeda_plane_r

Re: (subset) [PATCH v2 19/22] drm/komeda: plane: Remove redundant color encoding and range initialisation

2022-03-08 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:15 +0100, Maxime Ripard wrote: > The komeda KMS driver will call drm_plane_create_color_properties() with > a default encoding and range values of BT601 and Limited Range, > respectively. > > Since the initial value wasn't carried over in the state,

[PATCH v2 1/2] drm/probe-helper: Create a HPD IRQ event helper for a single connector

2021-08-30 Thread Maxime Ripard
ation for each connector or use that helper and iterate over all connectors all the time. Since both are suboptimal, let's create a helper that will only perform the status detection on a single connector. Signed-off-by: Maxime Ripard --- Changes from v1: - Rename the shared function

[PATCH v2 10/52] dt-bindings: display: Move idk-1110wr to panel-lvds

2021-09-01 Thread Maxime Ripard
t Cc: Sam Ravnborg Cc: Thierry Reding Signed-off-by: Maxime Ripard --- .../display/panel/advantech,idk-1110wr.yaml | 69 --- .../bindings/display/panel/lvds.yaml | 22 -- 2 files changed, 15 insertions(+), 76 deletions(-) delete mode 100644 Documentation/

[PATCH v2 11/52] dt-bindings: display: Move idk-2121wr to panel-lvds

2021-09-01 Thread Maxime Ripard
data-mapping requirement to a conditional. Let's move it to the generic panel-lvds binding Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Cc: Sam Ravnborg Cc: Thierry Reding Signed-off-by: Maxime Ripard --- .../display/panel/advantech,idk-2121wr.yaml

[PATCH v2 12/52] dt-bindings: display: Move ee101ia-01d to panel-lvds

2021-09-01 Thread Maxime Ripard
ned-off-by: Maxime Ripard --- .../display/panel/innolux,ee101ia-01d.yaml| 31 --- .../bindings/display/panel/lvds.yaml | 1 + 2 files changed, 1 insertion(+), 31 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml

[PATCH v2 13/52] dt-bindings: display: aa104xd12: Remove unused vcc-supply

2021-09-01 Thread Maxime Ripard
rg Cc: Laurent Pinchart Cc: Sam Ravnborg Cc: Thierry Reding Signed-off-by: Maxime Ripard --- .../bindings/display/panel/mitsubishi,aa104xd12.yaml | 5 - 1 file changed, 5 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml b/Document

[PATCH v2 14/52] dt-bindings: display: aa104xd12: Fix data-mapping

2021-09-01 Thread Maxime Ripard
The Mitsubishi AA140XD12 Device Tree Binding was requiring a data-mapping property value which was set to another value in the existing Device Trees. Fix this. Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Cc: Sam Ravnborg Cc: Thierry Reding Signed-off-by: Maxime Ripard

[PATCH v2 15/52] dt-bindings: display: Move aa104xd12 to panel-lvds

2021-09-01 Thread Maxime Ripard
t Cc: Sam Ravnborg Cc: Thierry Reding Signed-off-by: Maxime Ripard --- .../bindings/display/panel/lvds.yaml | 12 .../display/panel/mitsubishi,aa104xd12.yaml | 70 --- 2 files changed, 12 insertions(+), 70 deletions(-) delete mode 100644 Documentation/devicetre

[PATCH v2 16/52] dt-bindings: display: aa121td01: Remove unused vcc-supply

2021-09-01 Thread Maxime Ripard
rg Cc: Laurent Pinchart Cc: Sam Ravnborg Cc: Thierry Reding Signed-off-by: Maxime Ripard --- .../bindings/display/panel/mitsubishi,aa121td01.yaml | 5 - 1 file changed, 5 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml b/Document

[PATCH v2 17/52] dt-bindings: display: aa121td01: Fix data-mapping

2021-09-01 Thread Maxime Ripard
The Mitsubishi AA121TD01 Device Tree Binding was requiring a data-mapping property value which was set to another value in the existing Device Trees. Fix this. Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Cc: Sam Ravnborg Cc: Thierry Reding Signed-off-by: Maxime Ripard

[PATCH v2 18/52] dt-bindings: display: Move aa121td01 to panel-lvds

2021-09-01 Thread Maxime Ripard
t Cc: Sam Ravnborg Cc: Thierry Reding Signed-off-by: Maxime Ripard --- .../bindings/display/panel/lvds.yaml | 5 +- .../display/panel/mitsubishi,aa121td01.yaml | 69 --- 2 files changed, 4 insertions(+), 70 deletions(-) delete mode 100644 Documentation/devicetre

[PATCH v2 20/52] dt-bindings: display: panel-lvds: Document missing panel compatibles

2021-09-01 Thread Maxime Ripard
A few panel-lvds compatibles were never documented. Let's add them. Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Cc: Sam Ravnborg Cc: Thierry Reding Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/panel/lvds.yaml | 2 ++ 1 file changed, 2 inser

[PATCH v2 19/52] dt-bindings: display: Move gktw70sdae4se to panel-lvds

2021-09-01 Thread Maxime Ripard
top.org Cc: Laurent Pinchart Cc: Sam Ravnborg Cc: Thierry Reding Signed-off-by: Maxime Ripard --- .../bindings/display/panel/lvds.yaml | 2 + .../display/panel/sgd,gktw70sdae4se.yaml | 68 --- 2 files changed, 2 insertions(+), 68 deletions(-) delete mode 100644 Doc

Re: [PATCH] drm/vc4: Make use of the helper function devm_platform_ioremap_resource()

2021-09-01 Thread Maxime Ripard
On Tue, Aug 31, 2021 at 09:59:03PM +0800, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Applied, thanks Maxime signature.asc Description: PGP signature

Re: [PATCH] drm/sun4i: Make use of the helper function devm_platform_ioremap_resource()

2021-09-01 Thread Maxime Ripard
On Tue, Aug 31, 2021 at 09:57:39PM +0800, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Applied, thanks Maxime signature.asc Description: PGP signature

Re: [PATCH] drm/sun4i: Fix macros in sun8i_csc.h

2021-09-01 Thread Maxime Ripard
On Wed, Sep 01, 2021 at 11:13:01AM +0800, Chen-Yu Tsai wrote: > On Wed, Sep 1, 2021 at 2:48 AM Jernej Skrabec > wrote: > > > > Macros SUN8I_CSC_CTRL() and SUN8I_CSC_COEFF() don't follow usual > > recommendation of having arguments enclosed in parenthesis. While that > > didn't change anything for

Re: Regression with mainline kernel on rpi4

2021-09-03 Thread Maxime Ripard
Hi Sudip, On Thu, Sep 02, 2021 at 10:08:19AM +0100, Sudip Mukherjee wrote: > Hi All, > > Our last night's test on rpi4 had a nasty trace. The test was with > 7c636d4d20f8 ("Merge tag 'dt-5.15' of > git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc"). Previous test > was on 9e9fb7655ed5 ("Merg

Re: Regression with mainline kernel on rpi4

2021-09-04 Thread Maxime Ripard
On Fri, Sep 03, 2021 at 09:09:50PM +0100, Sudip Mukherjee wrote: > Hi Maxime, > > On Fri, Sep 3, 2021 at 5:03 PM Maxime Ripard wrote: > > > > Hi Sudip, > > > > On Thu, Sep 02, 2021 at 10:08:19AM +0100, Sudip Mukherjee wrote: > > > Hi All, > >

[PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-09-10 Thread Maxime Ripard
the two patches that were reverting that commit - Add some documentation - Make drm_panel_attach and _detach succeed when no callback is there Maxime Ripard (24): drm/bridge: Add documentation sections drm/bridge: Document the probe issue with MIPI-DSI bridges drm/mipi-dsi: Create

[PATCH v4 01/24] drm/bridge: Add documentation sections

2021-09-10 Thread Maxime Ripard
The bridge documentation overview is quite packed already, and we'll add some more documentation that isn't part of an overview at all. Let's add some sections to the documentation to separate each bits. Reviewed-by: Andrzej Hajda Reviewed-by: Sam Ravnborg Signed-off-by

[PATCH v4 02/24] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-09-10 Thread Maxime Ripard
Interactions between bridges, panels, MIPI-DSI host and the component framework are not trivial and can lead to probing issues when implementing a display driver. Let's document the various cases we need too consider, and the solution to support all the cases. Signed-off-by: Maxime R

[PATCH v4 03/24] drm/mipi-dsi: Create devm device registration

2021-09-10 Thread Maxime Ripard
call to mipi_dsi_device_unregister(). Let's create a device-managed variant of the registration function that will automatically unregister the device at unbind. Reviewed-by: Andrzej Hajda Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_mipi_dsi.c

[PATCH v4 04/24] drm/mipi-dsi: Create devm device attachment

2021-09-10 Thread Maxime Ripard
will automatically detach the device at unbind. Reviewed-by: Andrzej Hajda Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_mipi_dsi.c | 35 ++ include/drm/drm_mipi_dsi.h | 1 + 2 files changed, 36 insertions(+) diff --git a/drivers/gpu/drm/drm_mipi_ds

[PATCH v4 05/24] drm/bridge: adv7533: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 - drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

[PATCH v4 06/24] drm/bridge: adv7511: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 13 ++--- 1 file ch

[PATCH v4 07/24] drm/bridge: anx7625: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/analogix/anx7625.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/bridge/ana

[PATCH v4 08/24] drm/bridge: anx7625: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/analogix/anx7625.c | 20 ++-- 1

[PATCH v4 09/24] drm/bridge: lt8912b: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/bridge/lo

[PATCH v4 10/24] drm/bridge: lt8912b: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 11 +++ 1 file chang

[PATCH v4 11/24] drm/bridge: lt9611: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/lo

[PATCH v4 12/24] drm/bridge: lt9611: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611.c | 38 - 1

[PATCH v4 13/24] drm/bridge: lt9611uxc: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 38 +- 1 file changed, 8 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/bridge/lo

[PATCH v4 14/24] drm/bridge: lt9611uxc: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 31 +- 1

[PATCH v4 15/24] drm/bridge: ps8640: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device on removal. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/parade-ps8640.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --

[PATCH v4 16/24] drm/bridge: ps8640: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/parade-ps8640.c | 97 +++--- 1

[PATCH v4 17/24] drm/bridge: sn65dsi83: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge but don't remove its driver. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 12 +++- 1 file

[PATCH v4 18/24] drm/bridge: sn65dsi83: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 80 +++ 1

[PATCH v4 19/24] drm/bridge: sn65dsi86: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 22 +++--- 1 file changed, 7 insertions(+

[PATCH v4 21/24] drm/bridge: tc358775: Switch to devm MIPI-DSI helpers

2021-09-10 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/tc358775.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-)

[PATCH v4 20/24] drm/bridge: sn65dsi86: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 74 ++- 1

[PATCH v4 22/24] drm/bridge: tc358775: Register and attach our DSI device at probe

2021-09-10 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/tc358775.c | 37 +-- 1

[PATCH v4 23/24] drm/kirin: dsi: Adjust probe order

2021-09-10 Thread Maxime Ripard
following the same conventions, resulting in various incompatibilities between DSI hosts and devices. Now that we have a sequence agreed upon and documented, let's convert kirin to it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 27 +++- 1

[PATCH v4 24/24] drm/exynos: dsi: Adjust probe order

2021-09-10 Thread Maxime Ripard
following the same conventions, resulting in various incompatibilities between DSI hosts and devices. Now that we have a sequence agreed upon and documented, let's convert exynos to it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 19 --- 1

[PATCH 0/3] drm/bridge: Create a function to abstract panels away

2021-09-10 Thread Maxime Ripard
w what you think, Maxime Maxime Ripard (3): drm/bridge: Add a function to abstract away panels drm/vc4: dpi: Switch to devm_drm_of_get_bridge drm/vc4: dsi: Switch to devm_drm_of_get_bridge drivers/gpu/drm/drm_bridge.c | 42 +++ drivers/gpu/drm/drm_of.c

[PATCH 1/3] drm/bridge: Add a function to abstract away panels

2021-09-10 Thread Maxime Ripard
the boilerplate and hopefully create a path of least resistance towards using the DRM panel bridge layer, let's create the function devm_drm_of_get_next to reduce that boilerplate. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_bridge.c | 42 driver

[PATCH 2/3] drm/vc4: dpi: Switch to devm_drm_of_get_bridge

2021-09-10 Thread Maxime Ripard
The new devm_drm_of_get_bridge removes most of the boilerplate we have to deal with. Let's switch to it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/dr

[PATCH 3/3] drm/vc4: dsi: Switch to devm_drm_of_get_bridge

2021-09-10 Thread Maxime Ripard
The new devm_drm_of_get_bridge removes most of the boilerplate we have to deal with. Let's switch to it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.c | 2 ++ drivers/gpu/drm/vc4/vc4_dsi.c | 28 2 files changed, 6 insertions(+), 24 dele

Re: [PATCH v3 0/6] drm/vc4: hdmi: Fix CEC access while disabled

2021-09-14 Thread Maxime Ripard
On Thu, Aug 19, 2021 at 03:59:25PM +0200, Maxime Ripard wrote: > Hi, > > This series aims at fixing a complete and silent hang when one tries to use > CEC > while the display output is off. > > This can be tested with: > > echo off > /sys/class/drm/card0-HDMI-A

Re: [PATCH v2 0/6] drm/displayid: VESA vendor block and drm/i915 MSO use of it

2021-09-14 Thread Maxime Ripard
for merging this via > drm-intel? I think at this time we can get the merge to drm-next and > backmerge to drm-misc fairly quickly, and a topic branch would be > overkill. Yep, that works for me Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

<    3   4   5   6   7   8   9   10   11   12   >